Re: [PATCH 19/56] Revert "Move void_list_node init to common code". (8ff2a92a0450243e52d3299a13b30f208bafa7e0)

2022-12-01 Thread Richard Biener via Gcc-patches
On Fri, Dec 2, 2022 at 1:23 AM Zopolis0 wrote: > > > But that looks like the correct thing to do. > > It's not. The patch I reverted changes it so that no matter what, > void_list_node = build_tree_list (NULL_TREE, void_type_node);. > > Before, each front-end set it in their own way, but they all

Re: [PATCH 19/56] Revert "Move void_list_node init to common code". (8ff2a92a0450243e52d3299a13b30f208bafa7e0)

2022-12-01 Thread Richard Biener via Gcc-patches
On Fri, Dec 2, 2022 at 8:43 AM Richard Biener wrote: > > On Fri, Dec 2, 2022 at 1:23 AM Zopolis0 wrote: > > > > > But that looks like the correct thing to do. > > > > It's not. The patch I reverted changes it so that no matter what, > > void_list_node = build_tree_list (NULL_TREE, void_type_node)

Re: [PATCH RFA] driver: fix validate_switches logic

2022-12-01 Thread Richard Biener via Gcc-patches
On Fri, Dec 2, 2022 at 7:37 AM Alexandre Oliva via Gcc-patches wrote: > > On Dec 1, 2022, Jason Merrill wrote: > > > Once we see g*, starred is set. Then we see %:, and it sees that as a > > zero-length switch, which because starred is still set, matches any and all > > command-line options. S

<    1   2