Re: [PATCH] Check for class type before assuming a type is one [PR103703]

2021-12-15 Thread Jason Merrill via Gcc-patches
On 12/14/21 17:28, Martin Sebor wrote: The attached patch avoids an ICE when using the CLASSTYPE_IMPLICIT_INSTANTIATION() macro with an argument that is not a class type but rather a typename_type. The test case should trigger a warning but doesn't because the code doesn't fully handle explicit

Re: [PATCH] c++: local_specializations and recursive constrained fn [PR103714]

2021-12-15 Thread Jason Merrill via Gcc-patches
On 12/14/21 17:26, Patrick Palka wrote: Here during constraint checking for the recursive call to 'f', substitution into the PARM_DECL 'd' in the atomic constraint gives us the wrong local specialization because local_specializations at this point contains entities associated with the _outer_ cal

Re: [PATCH] gengtype: remove "tree_exp" special attribute

2021-12-15 Thread Jason Merrill via Gcc-patches
On 12/10/21 10:41, Patrick Palka wrote: The function comment for adjust_field_tree_exp says this special case is for handling trees whose operands may contain pointers to RTL instead of to trees. But ever since r0-59671, which fixed/removed the last two tree codes for which this was possible (GO

Re: [PATCH] c++: two-stage name lookup for overloaded operators [PR51577]

2021-12-15 Thread Patrick Palka via Gcc-patches
On Wed, 15 Dec 2021, Jason Merrill wrote: > On 12/10/21 09:53, Patrick Palka wrote: > > In order to properly implement two-stage name lookup for dependent > > operator expressions, we need to remember the result of unqualified > > lookup of the operator at template definition time, and reuse th

Re: testsuite: Be more informative for ICEs

2021-12-15 Thread Thomas Schwinge
Hi! On 2021-12-13T14:12:26-0500, David Malcolm wrote: > On Mon, 2021-12-13 at 10:53 -0700, Martin Sebor via Gcc-patches wrote: >> On 12/10/21 3:42 PM, Thomas Schwinge wrote: >> > OK to push the attached "testsuite: Be more informative for ICEs"? >> >> Adding more detail here seems like a useful i

Re: [PATCH v4 1/6] tree-object-size: Use trees and support negative offsets

2021-12-15 Thread Siddhesh Poyarekar
On 12/16/21 00:13, Jakub Jelinek wrote: On Wed, Dec 15, 2021 at 10:42:29PM +0530, Siddhesh Poyarekar wrote: On 12/15/21 20:51, Jakub Jelinek wrote: Shouldn't this also tree_int_cst_compare (old_wholeval, wholeval) ? AFAICT, there is no situation where wholeval changes but val doesn't, so I b

Re: [PATCH v7] rtl: builtins: (not just) rs6000: Add builtins for fegetround, feclearexcept and feraiseexcept [PR94193]

2021-12-15 Thread Segher Boessenkool
On Wed, Dec 15, 2021 at 01:29:57PM -0700, Jeff Law wrote: > I think the generic parts are fine once Segher is happy with the rest of > the bits. https://gcc.gnu.org/pipermail/gcc-patches/2021-November/585478.html (last lines) :-) Segher

Re: [PATCH] Verbose support in analyze_brprob_spec

2021-12-15 Thread Xionghu Luo via Gcc-patches
On 2021/12/15 18:34, Martin Liška wrote: > On 12/15/21 02:58, Xionghu Luo wrote: >> Also add verbose argument support like analyze_brprob.py >> >> contrib/ChangeLog: >> >> * analyze_brprob_spec.py: Add verbose argument. >> --- >>   contrib/analyze_brprob_spec.py | 1 + >>   1 file changed, 1

Re: [PATCH v4 2/6] __builtin_dynamic_object_size: Recognize builtin

2021-12-15 Thread Siddhesh Poyarekar
On 12/15/21 20:54, Jakub Jelinek wrote: On Wed, Dec 01, 2021 at 07:57:53PM +0530, Siddhesh Poyarekar wrote: Recognize the __builtin_dynamic_object_size builtin and add paths in the object size path to deal with it, but treat it like __builtin_object_size for now. Also add tests to provide the s

[r12-6007 Regression] FAIL: g++.dg/modules/xtreme-header_a.H -std=c++2b (internal compiler error: tree check: expected none of template_decl, have template_decl in add_specializations, at cp/module.cc

2021-12-15 Thread sunil.k.pandey via Gcc-patches
On Linux/x86_64, 45b768cb80930c0beeb735727349c44ec66f7dd2 is the first bad commit commit 45b768cb80930c0beeb735727349c44ec66f7dd2 Author: Thomas Schwinge Date: Fri Dec 10 19:08:26 2021 +0100 testsuite: Be more informative for ICEs caused FAIL: g++.dg/modules/xtreme-header-3_a.H module-cm

Re: [PATCH 1/2] Sync with binutils: GCC: Pass --plugin to AR and RANLIB

2021-12-15 Thread Sandra Loosemore
On 11/13/21 9:33 AM, H.J. Lu via Gcc-patches wrote: Sync with binutils for building binutils with LTO: From 50ad1254d5030d0804cbf89c758359ae202e8d55 Mon Sep 17 00:00:00 2001 From: "H.J. Lu" Date: Sat, 9 Jan 2021 06:43:11 -0800 Subject: [PATCH] GCC: Pass --plugin to AR and RANLIB Detect GCC LT

Re: [PATCH 1/2] Sync with binutils: GCC: Pass --plugin to AR and RANLIB

2021-12-15 Thread H.J. Lu via Gcc-patches
On Wed, Dec 15, 2021 at 7:38 PM Sandra Loosemore wrote: > > On 11/13/21 9:33 AM, H.J. Lu via Gcc-patches wrote: > > Sync with binutils for building binutils with LTO: > > > > From 50ad1254d5030d0804cbf89c758359ae202e8d55 Mon Sep 17 00:00:00 2001 > > From: "H.J. Lu" > > Date: Sat, 9 Jan 2021 06:4

Re: [PATCH 1/2] Sync with binutils: GCC: Pass --plugin to AR and RANLIB

2021-12-15 Thread H.J. Lu via Gcc-patches
On Wed, Dec 15, 2021 at 8:28 PM H.J. Lu wrote: > > On Wed, Dec 15, 2021 at 7:38 PM Sandra Loosemore > wrote: > > > > On 11/13/21 9:33 AM, H.J. Lu via Gcc-patches wrote: > > > Sync with binutils for building binutils with LTO: > > > > > > From 50ad1254d5030d0804cbf89c758359ae202e8d55 Mon Sep 17 0

Re: [PATCH 1/2] Sync with binutils: GCC: Pass --plugin to AR and RANLIB

2021-12-15 Thread Sandra Loosemore
On 12/15/21 9:28 PM, H.J. Lu wrote: I built nios2-linux-gnu cross compiler using glibc build-many-glibcs.py script: [snip] using glibc master, binutils master and gcc master. Is there a way to reproduce it with build-many-glibcs.py? If it requires host tools built from binutils master, tha

[PATCH] [i386] Add option -mvect-compare-costs

2021-12-15 Thread liuhongt via Gcc-patches
Also with corresponding target attribute, option default disabled. Bootstrapped and regtested on x86_64-pc-linux-gnu{-m32,}. Ok for trunk? gcc/ChangeLog: * config/i386/i386-options.c (ix86_target_string): Handle -mvect-compare-costs. (ix86_valid_target_attribute_inner_p):

[PATCH] [i386] Optimize bit_and op1 float_vector_all_ones_operands to op1.

2021-12-15 Thread liuhongt via Gcc-patches
Bootstrapped and regtested on x86_64-pc-linux-gnu{-m32,}. Ok for trunk? gcc/ChangeLog: PR target/98468 * config/i386/sse.md (*bit_and_float_vector_all_ones): New pre-reload splitter. gcc/testsuite/ChangeLog: * gcc.target/i386/pr98468.c: New test. --- gcc/config/

<    1   2