Re: redundant bitmap_bit_p followed by bitmap_clear_bit [was: Re: [COMMITTED] Kill second order relations in the path solver.]

2021-11-02 Thread Bernhard Reutner-Fischer via Gcc-patches
On 2 November 2021 14:43:38 CET, Richard Biener wrote: >On Mon, Nov 1, 2021 at 10:02 PM Bernhard Reutner-Fischer via >Gcc-patches wrote: >> >> On Mon, 1 Nov 2021 15:21:03 +0100 >> Aldy Hernandez wrote: >> >> > I'm not convinced this makes the code clearer to read, especially if >> > it's not on

Re: [PATCH 1/2] Flag CPP_W_BIDIRECTIONAL so that source lines are escaped

2021-11-02 Thread David Malcolm via Gcc-patches
On Tue, 2021-11-02 at 16:58 -0400, David Malcolm wrote: > Before: > >   Wbidirectional-1.c: In function ‘main’: >   Wbidirectional-1.c:6:43: warning: unpaired UTF-8 bidirectional > character detected [-Wbidirectional=] >   6 | /*‮ } ⁦if (isAdmin)⁩ ⁦ begin admins only */ >     |

[PATCH] Add 'no_builtin' function attribute

2021-11-02 Thread Keith Packard via Gcc-patches
This attribute controls optimizations which make assumptions about the semantics of builtin functions. Typical cases here are code which match memcpy, calloc, sincos, or which call builtins like free. This extends on things like the -ftree-loop-distribute-patterns flag. That flag only covers conve

Re: [PATCH] RISC-V: Enable overlap-by-pieces in case of fast unaliged access

2021-11-02 Thread Christoph Müllner via Gcc-patches
On Tue, Nov 2, 2021 at 9:15 PM Vineet Gupta wrote: > > > > On 11/2/21 1:09 PM, Christoph Müllner wrote: > Without overlap_op_by_pieces we get: > 8e: 00053023sd zero,0(a0) > 92: 00052423sw zero,8(a0) > 96: 00051623

ipa-modref cleanup

2021-11-02 Thread Jan Hubicka via Gcc-patches
Hi, this patch is a small refactoring of ipa-modref to make it bit more C++y by moving logic analyzing ssa name flags to a class and I also moved the anonymous namespace markers so we do not export unnecessary stuff. There are no functional changes. Bootstrapped/regtested x86_64-linux, will commi

Re: [PATCH] RISC-V: Enable overlap-by-pieces in case of fast unaliged access

2021-11-02 Thread Vineet Gupta
On 11/2/21 2:18 PM, Christoph Müllner wrote: On Tue, Nov 2, 2021 at 9:15 PM Vineet Gupta wrote: On 11/2/21 1:09 PM, Christoph Müllner wrote: Without overlap_op_by_pieces we get: 8e: 00053023sd zero,0(a0) 92: 00052423sw zero,8(a0) 9

Re: [PATCH 1/2] add -Wuse-after-free

2021-11-02 Thread David Malcolm via Gcc-patches
On Mon, 2021-11-01 at 16:17 -0600, Martin Sebor via Gcc-patches wrote: > Patch 1 in the series detects a small subset of uses of pointers > made indeterminate by calls to deallocation functions like free > or C++ operator delete. To control the conditions the warnings > are issued under the new -W

[patch][PR103033]handle the case when native_interpret_expr return NULL

2021-11-02 Thread Qing Zhao via Gcc-patches
Hi, PR103033 (c-c++-common/auto-init-4.c ICEs starting with r12-4829) https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103033 Is an -ftrivial-auto-var-init bug exposed on Powerpc64-linux only. For the following code in gcc/internal-fn.c: 3085 if (can_native_interpret_type_p (var_typ

Re: ipa-modref cleanup

2021-11-02 Thread H.J. Lu via Gcc-patches
On Tue, Nov 2, 2021 at 2:21 PM Jan Hubicka via Gcc-patches wrote: > > Hi, > this patch is a small refactoring of ipa-modref to make it bit more > C++y by moving logic analyzing ssa name flags to a class > and I also moved the anonymous namespace markers so we do not > export unnecessary stuff. Th

Re: [PATCH] Record that -gtoggle is already used in gcc_options.

2021-11-02 Thread Andrew Pinski via Gcc-patches
On Tue, Nov 2, 2021 at 7:11 AM Martin Liška wrote: > > Patch can bootstrap on x86_64-linux-gnu and survives regression tests. > > Ready to be installed? > Thanks, > Martin > > When doing flip based on -gtoggle, record it. Otherwise, we will > apply it for the second time in finish_options. > >

Re: ipa-modref cleanup

2021-11-02 Thread Jan Hubicka via Gcc-patches
> It broke GCC bootstrap: > > https://gcc.gnu.org/pipermail/gcc-regression/2021-November/075676.html > > In file included from ../../src-master/gcc/coretypes.h:474, > from ../../src-master/gcc/expmed.c:26: > In function ‘poly_uint16 mode_to_bytes(machine_mode)’, > inlined fro

Re: ipa-modref cleanup

2021-11-02 Thread Jakub Jelinek via Gcc-patches
On Wed, Nov 03, 2021 at 12:04:20AM +0100, Jan Hubicka via Gcc-patches wrote: > > It broke GCC bootstrap: > > > > https://gcc.gnu.org/pipermail/gcc-regression/2021-November/075676.html > > > > In file included from ../../src-master/gcc/coretypes.h:474, > > from ../../src-master/gc

[committed] libstdc++: Add some noexcept to std::valarray

2021-11-02 Thread Jonathan Wakely via Gcc-patches
Tested x86_64-linux, pushed to trunk. libstdc++-v3/ChangeLog: * include/std/valarray (valarray::valarray()): Add noexcept. (valarray::operator[]): Likewise. --- libstdc++-v3/include/std/valarray | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/lib

[PATCH] libstdc++: Deprecate std::unexpected and handler functions

2021-11-02 Thread Jonathan Wakely via Gcc-patches
These functions have been deprecated since C++11, and were removed in C++17. The proposal P0323 wants to reuse the name std::unexpected for a class template, so we will need to stop defining the current function for C++23 anyway. This marks them as deprecated for C++11 and up, to warn users they w

c: Fold implicit integer-to-floating conversions in static initializers with -frounding-math [PR103031]

2021-11-02 Thread Joseph Myers
Recent fixes to avoid inappropriate folding of some conversions to floating-point types with -frounding-math also prevented such folding in C static initializers, when folding (in the default rounding mode, exceptions discarded) is required for correctness. Folding for static initializers is handl

Re: [PATCH 1/2] add -Wuse-after-free

2021-11-02 Thread Martin Sebor via Gcc-patches
On 11/2/21 4:29 PM, David Malcolm wrote: On Mon, 2021-11-01 at 16:17 -0600, Martin Sebor via Gcc-patches wrote: Patch 1 in the series detects a small subset of uses of pointers made indeterminate by calls to deallocation functions like free or C++ operator delete. To control the conditions the

Fix wrong code caused by ipa-modref retslot handling

2021-11-02 Thread Jan Hubicka via Gcc-patches
Hi, this patch fixes (quite nasty) thinko in how I propagate EAF flags from callee to caller. In this case some flags needs to be changed. In particular - EAF_NOT_RETURNED in callee does not really mean EAF_NOT_RETURNED in caller since we speak of different return values - if callee escap

Re: [PATCH 08/18] rs6000: Builtin expansion, part 3

2021-11-02 Thread Segher Boessenkool
On Wed, Sep 01, 2021 at 11:13:44AM -0500, Bill Schmidt wrote: > * config/rs6000/rs6000-call.c (new_cpu_expand_builtin): > Implement. (just one line) > @@ -14646,6 +14646,108 @@ static rtx > new_cpu_expand_builtin (enum rs6000_gen_builtins fcode, > tree exp ATTRI

Re: [PATCH 09/18] rs6000: Builtin expansion, part 4

2021-11-02 Thread Segher Boessenkool
Hi! On Wed, Sep 01, 2021 at 11:13:45AM -0500, Bill Schmidt wrote: > static insn_code > elemrev_icode (rs6000_gen_builtins fcode) > { > + switch (fcode) > +{ > +default: > + gcc_unreachable (); default: goes at the end. > +case RS6000_BIF_ST_ELEMREV_V1TI: > + return BYTE

Re: [PATCH, rs6000] Disable gimple fold for float or double vec_minmax when fast-math is not set

2021-11-02 Thread HAO CHEN GUI via Gcc-patches
David,   Thanks for your comments. I refined it according to your advice. ChangeLog 2021-11-01 Haochen Gui gcc/     * config/rs6000/rs6000-call.c (rs6000_gimple_fold_builtin): Disable     gimple fold for VSX_BUILTIN_XVMINDP, ALTIVEC_BUILTIN_VMINFP,     VSX_BUILTIN_XVMAXDP, ALTIVEC_

Re: [PATCH] Check number of iterations for test cases pr101145

2021-11-02 Thread Jiufu Guo via Gcc-patches
Richard Biener writes: > On Mon, 1 Nov 2021, Jiufu Guo wrote: > >> PR101145 is supporting if the number of iterations can be calculated >> for the 'until wrap' condition. Current test cases are checking if >> the loop can be vectorized, if a loop can be vectorized then the number >> of interatio

Re: [PATCH] libstdc++: Clear padding bits in atomic compare_exchange

2021-11-02 Thread Thomas Rodgers
This version of the patch specifically doesn’t deal with long double. Mostly looking for Jonathan’s review to ensure his previous feedback is addressed. I plan to rev the patch to handle long doubles after some further discussion with you and Jonathan. On Tue, Nov 2, 2021 at 12:49 AM Jakub Jelinek

<    1   2