Re: [PATCH, rs6000] Disable gimple fold for float or double vec_minmax when fast-math is not set

2021-08-25 Thread HAO CHEN GUI via Gcc-patches
Hi,     I refined the patch according to Bill's advice. I pasted the ChangeLog and diff file here. If it doesn't work, please let me know. Thanks. 2021-08-25 Haochen Gui gcc/     * config/rs6000/rs6000-call.c (rs6000_gimple_fold_builtin):     Modify the VSX_BUILTIN_XVMINDP, ALTIVEC_BUILTIN_

Re: [GCC-11] [PATCH 0/5] Finish and general-regs-only

2021-08-25 Thread Uros Bizjak via Gcc-patches
On Tue, Aug 24, 2021 at 4:57 PM H.J. Lu wrote: > > On Sun, Aug 15, 2021 at 11:11 PM Richard Biener > wrote: > > > > On Fri, Aug 13, 2021 at 3:51 PM H.J. Lu wrote: > > > > > > and target("general-regs-only") function attribute > > > were added to GCC 11. But their implementations are incomplete

Re: [PATCH] i386: Add peephole for lea and zero extend [PR 101716]

2021-08-25 Thread Uros Bizjak via Gcc-patches
On Tue, Aug 24, 2021 at 5:22 PM Hongyu Wang wrote: > > Hi Uros, > > Sorry for the late update. I have tried adjusting the combine pass but > found it is not easy to modify shift const, so I came up with an > alternative solution with your patch. It matches the non-canonical > zero-extend in ix86_d

Re: [PATCH, rs6000] Disable gimple fold for float or double vec_minmax when fast-math is not set

2021-08-25 Thread Kewen.Lin via Gcc-patches
Hi Haochen, on 2021/8/25 下午3:06, HAO CHEN GUI via Gcc-patches wrote: > Hi, > >     I refined the patch according to Bill's advice. I pasted the ChangeLog > and diff file here. If it doesn't work, please let me know. Thanks. > > 2021-08-25 Haochen Gui > > gcc/ IIUC, this patch is for PR93127,

[PATCH] analyzer: Impose recursion limit on indirect calls.

2021-08-25 Thread Ankur Saini via Gcc-patches
This should also fix the failing regression found in PR analyzer/101980. - The patch is in sync with current master - successfully bootstrapped and tested on x86_64-linux-gnu. fix.patch Description: Binary data Thanks - Ankur

Re: [PATCH, rs6000] Disable gimple fold for float or double vec_minmax when fast-math is not set

2021-08-25 Thread HAO CHEN GUI via Gcc-patches
Hi Kewen,   Thanks for your advice. On 25/8/2021 下午 3:50, Kewen.Lin wrote: Hi Haochen, on 2021/8/25 下午3:06, HAO CHEN GUI via Gcc-patches wrote: Hi,     I refined the patch according to Bill's advice. I pasted the ChangeLog and diff file here. If it doesn't work, please let me know. Thanks.

Re: [PATCH] Change illegitimate constant into memref of constant pool in change_zero_ext.

2021-08-25 Thread Hongtao Liu via Gcc-patches
On Wed, Aug 25, 2021 at 5:14 AM Segher Boessenkool wrote: > > Hi! > > On Tue, Aug 24, 2021 at 04:55:30PM +0800, liuhongt wrote: > > This patch extend change_zero_ext to change illegitimate constant > > into constant pool, this will enable simplification of below: > > It should be in a separate f

Re: [PATCH] Change illegitimate constant into memref of constant pool in change_zero_ext.

2021-08-25 Thread Hongtao Liu via Gcc-patches
On Wed, Aug 25, 2021 at 5:14 AM Segher Boessenkool wrote: > > Hi! > > On Tue, Aug 24, 2021 at 04:55:30PM +0800, liuhongt wrote: > > This patch extend change_zero_ext to change illegitimate constant > > into constant pool, this will enable simplification of below: > > It should be in a separate f

Re: [PATCH, rs6000] Disable gimple fold for float or double vec_minmax when fast-math is not set

2021-08-25 Thread HAO CHEN GUI via Gcc-patches
On 25/8/2021 下午 4:17, HAO CHEN GUI via Gcc-patches wrote: Hi Kewen,   Thanks for your advice. On 25/8/2021 下午 3:50, Kewen.Lin wrote: Hi Haochen, on 2021/8/25 下午3:06, HAO CHEN GUI via Gcc-patches wrote: Hi, I refined the patch according to Bill's advice. I pasted the ChangeLog and di

[PATCH] tree-optimization/102046 - fix SLP build from scalars with patterns

2021-08-25 Thread Richard Biener via Gcc-patches
When we swap operands for SLP builds we lose track where exactly pattern defs are - but we fail to update the any_pattern member of the operands info. Do so conservatively. Bootstrapped and tested on x86_64-unknown-linux-gnu, pushed. 2021-08-25 Richard Biener PR tree-optimization/102

Re: [Patch v2] C, C++, Fortran, OpenMP: Add support for device-modifiers for 'omp target device'

2021-08-25 Thread Marcel Vollweiler
Hi Jakub, I applied all your suggested changes and checked for no test regressions on x86_64-linux with nvptx offloading. The revised patch is attached. Do you think that it's ok to commit the code? Thanks, Marcel Am 23.08.2021 um 19:47 schrieb Jakub Jelinek: On Fri, Aug 20, 2021 at 09:18:32

Re: [PATCH] analyzer: Recognize __builtin_free as a matching deallocator

2021-08-25 Thread Matthias Klose
On 7/28/21 1:44 PM, David Malcolm via Gcc-patches wrote: > On Wed, 2021-07-28 at 10:34 +0530, Siddhesh Poyarekar wrote: >> Recognize __builtin_free as being equivalent to free when passed into >> __attribute__((malloc ())), similar to how it is treated when it is >> encountered as a call.  This fix

Re: [GCC-11] [PATCH 0/5] Finish and general-regs-only

2021-08-25 Thread H.J. Lu via Gcc-patches
On Wed, Aug 25, 2021 at 12:34 AM Uros Bizjak wrote: > > On Tue, Aug 24, 2021 at 4:57 PM H.J. Lu wrote: > > > > On Sun, Aug 15, 2021 at 11:11 PM Richard Biener > > wrote: > > > > > > On Fri, Aug 13, 2021 at 3:51 PM H.J. Lu wrote: > > > > > > > > and target("general-regs-only") function attribut

Re: [PATCH] Use non-numbered clones for target_clones.

2021-08-25 Thread Martin Liška
Hello. There's updated version of the patch that: - strips '.$number' suffix for default clones - skips numbering for both declarations and definitions of target clones. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Ready to be installed? Thanks, MartinFrom 99fdcd317cec

Re: [PATCH, rs6000] Disable gimple fold for float or double vec_minmax when fast-math is not set

2021-08-25 Thread Bill Schmidt via Gcc-patches
Hi Haochen, Thanks for the updates!  This looks good to me; please await Segher's response. Bill On 8/25/21 2:06 AM, HAO CHEN GUI wrote: Hi,     I refined the patch according to Bill's advice. I pasted the ChangeLog and diff file here. If it doesn't work, please let me know. Thanks. 2021

Re: [llvm-dev] [PATCH] Add optional _Float16 support

2021-08-25 Thread H.J. Lu via Gcc-patches
On Mon, Aug 23, 2021 at 10:55 PM John McCall wrote: > > On Thu, Jul 29, 2021 at 9:40 AM H.J. Lu wrote: >> >> On Tue, Jul 13, 2021 at 9:24 AM H.J. Lu wrote: >> > >> > On Tue, Jul 13, 2021 at 8:41 AM Joseph Myers >> > wrote: >> > > >> > > On Tue, 13 Jul 2021, H.J. Lu wrote: >> > > >> > > > On Mo

Re: [PATCH] analyzer: Impose recursion limit on indirect calls.

2021-08-25 Thread David Malcolm via Gcc-patches
On Wed, 2021-08-25 at 13:39 +0530, Ankur Saini wrote: > This should also fix the failing regression found in PR > analyzer/101980. > > - The patch is in sync with current master > - successfully bootstrapped and tested on x86_64-linux-gnu. > The patch is OK for trunk. Thanks for fixing this Dav

Re: Ping: [PATCH] diagnostics: Support for -finput-charset [PR93067]

2021-08-25 Thread David Malcolm via Gcc-patches
On Tue, 2021-08-24 at 19:28 -0400, Lewis Hyatt wrote: > On Tue, Aug 24, 2021 at 6:51 PM David Malcolm > wrote: > > > > On Tue, 2021-08-24 at 08:17 -0400, Lewis Hyatt wrote: > > > Hello- > > > > > > I thought it might be a good time to check on this patch please? > > > Thanks! > > > https://gcc.g

Re: [PATCH] analyzer: Impose recursion limit on indirect calls.

2021-08-25 Thread Martin Liška
On 8/25/21 15:22, David Malcolm via Gcc-patches wrote: On Wed, 2021-08-25 at 13:39 +0530, Ankur Saini wrote: This should also fix the failing regression found in PR analyzer/101980. - The patch is in sync with current master - successfully bootstrapped and tested on x86_64-linux-gnu. The pat

Re: [PATCH] analyzer: Impose recursion limit on indirect calls.

2021-08-25 Thread David Malcolm via Gcc-patches
On Wed, 2021-08-25 at 20:31 +0530, Ankur Saini wrote: > > > > On 25-Aug-2021, at 7:24 PM, Martin Liška wrote: > > > > On 8/25/21 15:22, David Malcolm via Gcc-patches wrote: > > > On Wed, 2021-08-25 at 13:39 +0530, Ankur Saini wrote: > > > > This should also fix the failing regression found in P

Re: [PATCH] analyzer: Recognize __builtin_free as a matching deallocator

2021-08-25 Thread Siddhesh Poyarekar
On 8/25/21 5:44 PM, Matthias Klose wrote: On 7/28/21 1:44 PM, David Malcolm via Gcc-patches wrote: On Wed, 2021-07-28 at 10:34 +0530, Siddhesh Poyarekar wrote: Recognize __builtin_free as being equivalent to free when passed into __attribute__((malloc ())), similar to how it is treated when it

[PING][PATCH] enable ranger and caching in pass_waccess

2021-08-25 Thread Martin Sebor via Gcc-patches
Ping: Andrew, did I answer your questions? Do you (or anyone else) have any other comments on the latest patch below? https://gcc.gnu.org/pipermail/gcc-patches/2021-August/577865.html On 8/20/21 4:16 PM, Martin Sebor wrote: On 8/20/21 7:09 AM, Andrew MacLeod wrote: On 8/19/21 7:09 PM, Martin

Re: [PATCH] analyzer: Impose recursion limit on indirect calls.

2021-08-25 Thread Ankur Saini via Gcc-patches
> On 25-Aug-2021, at 8:35 PM, David Malcolm wrote: > > On Wed, 2021-08-25 at 20:31 +0530, Ankur Saini wrote: >> >> >>> On 25-Aug-2021, at 7:24 PM, Martin Liška wrote: >>> >>> On 8/25/21 15:22, David Malcolm via Gcc-patches wrote: On Wed, 2021-08-25 at 13:39 +0530, Ankur Saini wrote: >

Re: [PING][PATCH] enable ranger and caching in pass_waccess

2021-08-25 Thread Andrew MacLeod via Gcc-patches
On 8/25/21 11:20 AM, Martin Sebor wrote: Ping: Andrew, did I answer your questions?  Do you (or anyone else) have any other comments on the latest patch below? https://gcc.gnu.org/pipermail/gcc-patches/2021-August/577865.html I wasn't attempting to block it, its outside my review purview.. I

[PATCH] Make xxsplti*, xpermx, xxeval be vecperm type.

2021-08-25 Thread Michael Meissner via Gcc-patches
Make xxsplti*, xpermx, xxeval be vecperm type. I noticed that the built-functions for xxspltiw, xxspltidp, xxsplti32dx, xxpermx, and xxeval all used the 'vecsimple' type. These instructions are permute instructions (3 cycle latency) and should use 'vecperm' instead. While I was at it, I changed

[Patch] Fix cygming-crtend.c build warning due to -Wprio-ctor-dtor

2021-08-25 Thread Jonathan Yong via Gcc-patches
Attached patches OK? cygming-crtend.c: fix build warnings libgcc/Changelog: * config/i386/cygming-crtend.c: Fix register_frame_ctor and register_frame_dtor warnings. extend.texi: add note about reserved ctor/dtor priorities gcc/Changelog: *

Re: [PATCH] analyzer: Impose recursion limit on indirect calls.

2021-08-25 Thread David Malcolm via Gcc-patches
On Wed, 2021-08-25 at 21:25 +0530, Ankur Saini wrote: > > > > On 25-Aug-2021, at 8:35 PM, David Malcolm > > wrote: > > > > On Wed, 2021-08-25 at 20:31 +0530, Ankur Saini wrote: > > > > > > > > > > On 25-Aug-2021, at 7:24 PM, Martin Liška > > > > wrote: > > > > > > > > On 8/25/21 15:22, Davi

[PATCH] avoid printing range table header alone

2021-08-25 Thread Martin Sebor via Gcc-patches
I noticed that the output of -fdump-tree-walloca (and probably all passes that call gimple_ranger::export_global_ranges()) includes the following two lines for all functions, even when there's nothing else of relevance after them: Exported global range table === I was a b

Re: [PATCH] configure: Allow a host makefile fragment to override PIE flag settings.

2021-08-25 Thread Iain Sandoe via Gcc-patches
Hi, > On 20 Aug 2021, at 11:29, Richard Sandiford wrote: > >>> Maybe it would be easier to have the makefile fragments determine >>> something like CODE_MODEL_CFLAGS, which can be "-fPIC", "-mdynamic-no-pic", >>> etc., and use: >>> >>> COMPILER += $(NO_PIE_CFLAGS) $(CODE_MODEL_CFLAGS) >> >> OK

Re: [PATCH] Make xxsplti*, xpermx, xxeval be vecperm type.

2021-08-25 Thread Segher Boessenkool
Hi Mike, On Wed, Aug 25, 2021 at 12:37:14PM -0400, Michael Meissner wrote: > I noticed that the built-functions for xxspltiw, xxspltidp, xxsplti32dx, > xxpermx, and xxeval all used the 'vecsimple' type. These instructions are > permute instructions (3 cycle latency) and should use 'vecperm' inste

Re: [PATCH] avoid printing range table header alone

2021-08-25 Thread Andrew MacLeod via Gcc-patches
On 8/25/21 1:25 PM, Martin Sebor wrote: I noticed that the output of -fdump-tree-walloca (and probably all passes that call gimple_ranger::export_global_ranges()) includes the following two lines for all functions, even when there's nothing else of relevance after them: Exported global range tab

Re: [PATCH] configure: Allow a host makefile fragment to override PIE flag settings.

2021-08-25 Thread H.J. Lu via Gcc-patches
On Wed, Aug 25, 2021 at 10:42 AM Iain Sandoe wrote: > > Hi, > > > On 20 Aug 2021, at 11:29, Richard Sandiford > > wrote: > > > >>> Maybe it would be easier to have the makefile fragments determine > >>> something like CODE_MODEL_CFLAGS, which can be "-fPIC", > >>> "-mdynamic-no-pic", > >>> etc.

Re: [PATCH] configure: Allow a host makefile fragment to override PIE flag settings.

2021-08-25 Thread H.J. Lu via Gcc-patches
On Wed, Aug 25, 2021 at 10:51 AM H.J. Lu wrote: > > On Wed, Aug 25, 2021 at 10:42 AM Iain Sandoe wrote: > > > > Hi, > > > > > On 20 Aug 2021, at 11:29, Richard Sandiford > > > wrote: > > > > > >>> Maybe it would be easier to have the makefile fragments determine > > >>> something like CODE_MODE

Merge stores/loads in modref summaries

2021-08-25 Thread Jan Hubicka
Hi, this patch adds logic needed to merge neighbouring accesses in ipa-modref summaries. This helps analyzing array initializers and similar code. It is bit of work, since it breaks the fact that modref tree makes a good lattice for dataflow: the access ranges can be extended indefinitely. For t

Re: [PATCH] diagnostics: Fix sporadic test failure

2021-08-25 Thread H.J. Lu via Gcc-patches
On Sat, May 29, 2021 at 1:03 PM Jeff Law via Gcc-patches wrote: > > > > On 5/29/2021 1:55 PM, Bernd Edlinger wrote: > > > > On 5/29/21 9:31 PM, Jeff Law wrote: > >> > >> On 5/28/2021 6:38 AM, Bernd Edlinger wrote: > >>> Hi, > >>> > >>> it turns out to be reproducible this way: > >>> > >>> COLUMNS=

Re: [PATCH] configure: Allow a host makefile fragment to override PIE flag settings.

2021-08-25 Thread Iain Sandoe via Gcc-patches
> On 25 Aug 2021, at 18:56, H.J. Lu via Gcc-patches > wrote: > > On Wed, Aug 25, 2021 at 10:51 AM H.J. Lu wrote: >> >> On Wed, Aug 25, 2021 at 10:42 AM Iain Sandoe wrote: >>> >>> Hi, >>> On 20 Aug 2021, at 11:29, Richard Sandiford wrote: >> Maybe it would be easier

Re: [PATCH] Make xxsplti*, xpermx, xxeval be vecperm type.

2021-08-25 Thread Michael Meissner via Gcc-patches
On Wed, Aug 25, 2021 at 12:44:16PM -0500, Segher Boessenkool wrote: > Hi Mike, > > On Wed, Aug 25, 2021 at 12:37:14PM -0400, Michael Meissner wrote: > > I noticed that the built-functions for xxspltiw, xxspltidp, xxsplti32dx, > > xxpermx, and xxeval all used the 'vecsimple' type. These instructio

Re: [PATCH] configure: Allow a host makefile fragment to override PIE flag settings.

2021-08-25 Thread H.J. Lu via Gcc-patches
On Wed, Aug 25, 2021 at 11:10 AM Iain Sandoe wrote: > > > > > On 25 Aug 2021, at 18:56, H.J. Lu via Gcc-patches > > wrote: > > > > On Wed, Aug 25, 2021 at 10:51 AM H.J. Lu wrote: > >> > >> On Wed, Aug 25, 2021 at 10:42 AM Iain Sandoe > >> wrote: > >>> > >>> Hi, > >>> > On 20 Aug 2021, at

Re: [PATCH] configure: Allow a host makefile fragment to override PIE flag settings.

2021-08-25 Thread Iain Sandoe via Gcc-patches
> On 25 Aug 2021, at 19:22, H.J. Lu wrote: > > On Wed, Aug 25, 2021 at 11:10 AM Iain Sandoe wrote: >> >> >> >>> On 25 Aug 2021, at 18:56, H.J. Lu via Gcc-patches >>> wrote: >>> >>> On Wed, Aug 25, 2021 at 10:51 AM H.J. Lu wrote: On Wed, Aug 25, 2021 at 10:42 AM Iain Sandoe

*PING* – Re: [Patch] Fortran: Fix Bind(C) char-len check, add ptr-contiguous check

2021-08-25 Thread Tobias Burnus
Early *PING*. (I also should still review several Fortan patches... There are lots of patches waiting for review :-/) On 20.08.21 19:24, Tobias Burnus wrote: The following is about interoperability (BIND(C)) only. * The patch adds a missing check for pointer + contiguous. (Rejected to avoid co

Re: [PATCH] avoid printing range table header alone

2021-08-25 Thread Martin Sebor via Gcc-patches
On 8/25/21 11:46 AM, Andrew MacLeod wrote: On 8/25/21 1:25 PM, Martin Sebor wrote: I noticed that the output of -fdump-tree-walloca (and probably all passes that call gimple_ranger::export_global_ranges()) includes the following two lines for all functions, even when there's nothing else of rele

Re: [PATCH] avoid printing range table header alone

2021-08-25 Thread Andrew MacLeod via Gcc-patches
On 8/25/21 3:15 PM, Martin Sebor wrote: On 8/25/21 11:46 AM, Andrew MacLeod wrote: On 8/25/21 1:25 PM, Martin Sebor wrote: I noticed that the output of -fdump-tree-walloca (and probably all passes that call gimple_ranger::export_global_ranges()) includes the following two lines for all function

[PATCH] Generate XXSPLTIDP on power10.

2021-08-25 Thread Michael Meissner via Gcc-patches
Generate XXSPLTIDP on power10. This patch implements XXSPLTIDP support for SF and DF scalar constants and V2DF vector constants. The XXSPLTIDP instruction is given a 32-bit immediate that is converted to a vector of two DFmode constants. The immediate is in SFmode format, so only constants that

[PATCH] improve note location and refactor warn_uninit

2021-08-25 Thread Martin Sebor via Gcc-patches
Richard, some time ago you mentioned you'd had trouble getting -Wuninitialized to print the note pointing to the uninitialized variable. I said I'd look into it, and so I did. The attached patch simplifies the warn_uninit() function to get rid of some redundant cruft: besides a few pointless nul

Re: [PATCH] c++: Fix cp_tree_equal for template value args using dependent sizeof/alignof/noexcept expressions

2021-08-25 Thread Jason Merrill via Gcc-patches
On 8/21/21 12:55 AM, Barrett Adair via Gcc-patches wrote: This patch fixes AST comparison for trailing return types using dependent sizeof/alignof/noexcept expressions as template value arguments. I believe this bug is over a decade old, hailing from GCC 4.6. I found it over 5 years ago and sat o

Re: [PATCH] c++: Fix up value initialization of structs with zero width bitfields [PR102019]

2021-08-25 Thread Jason Merrill via Gcc-patches
On 8/23/21 4:16 PM, Jakub Jelinek wrote: Hi! The removal of remove_zero_width_bit_fields, in addition to triggering some ABI issues that need solving anyway (ABI incompatibility between C and C++) also resulted in UB inside of gcc, we now call build_zero_init which calls build_int_cst on an inte

Re: [llvm-dev] [PATCH] Add optional _Float16 support

2021-08-25 Thread John McCall via Gcc-patches
On Wed, Aug 25, 2021 at 8:36 AM H.J. Lu wrote: > On Mon, Aug 23, 2021 at 10:55 PM John McCall wrote: > > On Thu, Jul 29, 2021 at 9:40 AM H.J. Lu wrote: > >> On Tue, Jul 13, 2021 at 9:24 AM H.J. Lu wrote: > >> > On Tue, Jul 13, 2021 at 8:41 AM Joseph Myers > wrote: > >> > > On Tue, 13 Jul 2021

Re: [PATCH] Fix PR c++/66590: incorrect warning "reaches end of non-void function" for switch

2021-08-25 Thread Jason Merrill via Gcc-patches
On 8/13/21 2:40 PM, apinski--- via Gcc-patches wrote: From: Andrew Pinski So the problem here is there is code in the C++ front-end not to add a break statement (to the IR) if the previous block does not fall through. The problem is the code which does the check to see if the block may fallthro

Re: [PING][PATCH] enable ranger and caching in pass_waccess

2021-08-25 Thread Martin Sebor via Gcc-patches
On 8/25/21 10:14 AM, Andrew MacLeod wrote: On 8/25/21 11:20 AM, Martin Sebor wrote: Ping: Andrew, did I answer your questions?  Do you (or anyone else) have any other comments on the latest patch below? https://gcc.gnu.org/pipermail/gcc-patches/2021-August/577865.html I wasn't attempting to

[committed] libstdc++: Remove __gnu_cxx::rope::erase(size_type) [PR102048]

2021-08-25 Thread Jonathan Wakely via Gcc-patches
This function claims to remove a single character at index p, but it actually removes p+1 characters beginning at p. So r.erase(0) removes the first character, but r.erase(1) removes the second and third, and r.erase(2) removes the second, third and fourth. This is not a useful API. The overload i

[committed] libstdc++: Fix conditions for optimizing uninitialized algos [PR102064]

2021-08-25 Thread Jonathan Wakely via Gcc-patches
While laying some groundwork for constexpr std::vector, I noticed some bugs in the std::uninitialized_xxx algorithms. The conditions being checked for optimizing trivial cases were not quite right, as shown in the examples in the PR. This consolidates the checks into a single macro. The macro has

[PATCH] Fix float128-call.c test for power8 IEEE 128 and power10.

2021-08-25 Thread Michael Meissner via Gcc-patches
>From 327273dfeec5c000f3c33ca7b88ee0097fd33586 Mon Sep 17 00:00:00 2001 From: Michael Meissner Date: Wed, 25 Aug 2021 00:31:35 -0400 Subject: [PATCH] Fix float128-call.c test for power8 IEEE 128 and power10. I built a compiler on a little endian power8 system where the default long double was IEE

Re: [PATCH] Make xxsplti*, xpermx, xxeval be vecperm type.

2021-08-25 Thread Segher Boessenkool
On Wed, Aug 25, 2021 at 02:22:06PM -0400, Michael Meissner wrote: > On Wed, Aug 25, 2021 at 12:44:16PM -0500, Segher Boessenkool wrote: > > Out of interest, did you notice any scheduling differences with this? > > I don't use the built-ins so I wouldn't notice a difference. I noticed this > as >

Re: [PATCH] Make xxsplti*, xpermx, xxeval be vecperm type.

2021-08-25 Thread Michael Meissner via Gcc-patches
On Wed, Aug 25, 2021 at 05:29:22PM -0500, Segher Boessenkool wrote: > On Wed, Aug 25, 2021 at 02:22:06PM -0400, Michael Meissner wrote: > > On Wed, Aug 25, 2021 at 12:44:16PM -0500, Segher Boessenkool wrote: > > > Out of interest, did you notice any scheduling differences with this? > > > > I don'

Re: [PATCH 11/34] rs6000: Add MMA builtins

2021-08-25 Thread Segher Boessenkool
Hi! On Thu, Jul 29, 2021 at 08:30:58AM -0500, Bill Schmidt wrote: > * config/rs6000/rs6000-builtin-new.def: Add mma stanza. Okay for trunk. Thanks! Segher

Re: [PATCH 12/34] rs6000: Add miscellaneous builtins

2021-08-25 Thread Segher Boessenkool
On Thu, Jul 29, 2021 at 08:30:59AM -0500, Bill Schmidt wrote: > * config/rs6000/rs6000-builtin-new.def: Add ieee128-hw, dfp, > crypto, and htm stanzas. Okay for trunk. Thanks! Segher

Re: [PATCH 13/34] rs6000: Add Cell builtins

2021-08-25 Thread Segher Boessenkool
On Thu, Jul 29, 2021 at 08:31:00AM -0500, Bill Schmidt wrote: > * config/rs6000/rs6000-builtin-new.def: Add cell stanza. This one is fine, too. Thanks! Segher

Re: [PATCH] improve note location and refactor warn_uninit

2021-08-25 Thread Jeff Law via Gcc-patches
On 8/25/2021 2:03 PM, Martin Sebor via Gcc-patches wrote: Richard, some time ago you mentioned you'd had trouble getting -Wuninitialized to print the note pointing to the uninitialized variable.  I said I'd look into it, and so I did.  The attached patch simplifies the warn_uninit() function t

[PATCH] declare get_range_query attribute returns_nonnull

2021-08-25 Thread Martin Sebor via Gcc-patches
Andrew, based on your remarks in our discussion Re: enable ranger and caching in pass_waccess, I've added some comments to struct function and get_range_query() and declared the latter with attribute returns_nonnull to make it explicit both to readers and to GCC that the x_range_query member is ne

Re: [PATCH] declare get_range_query attribute returns_nonnull

2021-08-25 Thread Jeff Law via Gcc-patches
On 8/25/2021 5:01 PM, Martin Sebor via Gcc-patches wrote: Andrew, based on your remarks in our discussion Re: enable ranger and caching in pass_waccess, I've added some comments to struct function and get_range_query() and declared the latter with attribute returns_nonnull to make it explicit

Re: [PATCH] diagnostics: Fix sporadic test failure

2021-08-25 Thread Jeff Law via Gcc-patches
On 8/25/2021 12:07 PM, H.J. Lu wrote: On Sat, May 29, 2021 at 1:03 PM Jeff Law via Gcc-patches wrote: On 5/29/2021 1:55 PM, Bernd Edlinger wrote: On 5/29/21 9:31 PM, Jeff Law wrote: On 5/28/2021 6:38 AM, Bernd Edlinger wrote: Hi, it turns out to be reproducible this way: COLUMNS=80 ma

Re: [Patch] Fix cygming-crtend.c build warning due to -Wprio-ctor-dtor

2021-08-25 Thread Jeff Law via Gcc-patches
On 8/25/2021 10:46 AM, Jonathan Yong via Gcc-patches wrote: Attached patches OK?     cygming-crtend.c: fix build warnings     libgcc/Changelog:     * config/i386/cygming-crtend.c: Fix register_frame_ctor     and register_frame_dtor warnings.     extend.texi: add note about

Re: [PATCH] analyzer: Recognize __builtin_free as a matching deallocator

2021-08-25 Thread Jeff Law via Gcc-patches
On 8/25/2021 9:16 AM, Siddhesh Poyarekar wrote: On 8/25/21 5:44 PM, Matthias Klose wrote: On 7/28/21 1:44 PM, David Malcolm via Gcc-patches wrote: On Wed, 2021-07-28 at 10:34 +0530, Siddhesh Poyarekar wrote: Recognize __builtin_free as being equivalent to free when passed into __attribute__

[committed] libstdc++: Fix non-reserved names in

2021-08-25 Thread Jonathan Wakely via Gcc-patches
Signed-off-by: Jonathan Wakely libstdc++-v3/ChangeLog: * include/std/valarray: Uglify 'func' parameters. * testsuite/17_intro/names.cc: Add 'func' to checks. Tested powerpc64le-linux. Committed to trunk. commit 0163bbaaef119ef9e98c4b3dcba159609f77c818 Author: Jonathan Wakely D

[committed] libstdc++: Fix names.cc test failures on Windows

2021-08-25 Thread Jonathan Wakely via Gcc-patches
The Windows CRT headers define structs with members called f, x, y etc so don't check those. There are also lots of unnecessary function parameters in mingw headers using non-reserved names, e.g. uses p and z as parameters of mingw_gettimeofday uses j as a parameter of imaxabs uses l, o and fun

Re: [PATCH] Use non-numbered clones for target_clones.

2021-08-25 Thread Jeff Law via Gcc-patches
On 8/25/2021 6:23 AM, Martin Liška wrote: Hello. There's updated version of the patch that: - strips '.$number' suffix for default clones - skips numbering for both declarations and definitions of target clones. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Ready to

[committed] libstdc++: Add another non-reserved name to tests

2021-08-25 Thread Jonathan Wakely via Gcc-patches
Signed-off-by: Jonathan Wakely libstdc++-v3/ChangeLog: * testsuite/17_intro/names.cc: Check 'sz'. Tested x86_64-linux. Committed to trunk. commit ea5674687ac45fe7242c57220b699337899881f0 Author: Jonathan Wakely Date: Wed Aug 25 23:19:25 2021 libstdc++: Add another non-reserved

Re: [PATCH] Make sure we're playing with integral modes before call extract_integral_bit_field.

2021-08-25 Thread Jeff Law via Gcc-patches
On 8/24/2021 3:44 AM, Hongtao Liu via Gcc-patches wrote: On Tue, Aug 24, 2021 at 5:40 PM Hongtao Liu wrote: On Tue, Aug 17, 2021 at 9:52 AM Hongtao Liu wrote: On Mon, Aug 9, 2021 at 4:34 PM Hongtao Liu wrote: On Fri, Aug 6, 2021 at 7:27 PM Richard Biener via Gcc-patches wrote: On Fri,

Re: [PATCH 14/34] rs6000: Add remaining overloads

2021-08-25 Thread Segher Boessenkool
On Thu, Jul 29, 2021 at 08:31:01AM -0500, Bill Schmidt wrote: > * config/rs6000/rs6000-overload.def: Add remaining overloads. > +; TODO: Note that the entry for VEC_ADDE currently gets ignored in > +; altivec_resolve_overloaded_builtin. Revisit whether we can remove > +; that. We still nee

Re: [PATCH] avoid printing range table header alone

2021-08-25 Thread Martin Sebor via Gcc-patches
On 8/25/21 1:34 PM, Andrew MacLeod wrote: On 8/25/21 3:15 PM, Martin Sebor wrote: On 8/25/21 11:46 AM, Andrew MacLeod wrote: On 8/25/21 1:25 PM, Martin Sebor wrote: I noticed that the output of -fdump-tree-walloca (and probably all passes that call gimple_ranger::export_global_ranges()) includ

Re: [PATCH] improve note location and refactor warn_uninit

2021-08-25 Thread Martin Sebor via Gcc-patches
On 8/25/21 5:00 PM, Jeff Law wrote: On 8/25/2021 2:03 PM, Martin Sebor via Gcc-patches wrote: Richard, some time ago you mentioned you'd had trouble getting -Wuninitialized to print the note pointing to the uninitialized variable.  I said I'd look into it, and so I did.  The attached patch sim

[PATCH] Inline IBM long double __gcc_qsub

2021-08-25 Thread David Edelsohn via Gcc-patches
rs6000: inline ldouble __gcc_qsub While performing some tests of IEEE 128 float for PPC64LE, Michael Meissner noticed that __gcc_qsub is substantially slower than __gcc_qadd. __gcc_qsub valls __gcc_add with the second operand negated. Because the functions normally are invoke

[r12-3144 Regression] FAIL: gcc.dg/tree-ssa/pr64130.c scan-tree-dump evrp "int \\[-8589934591, -2\\]" on Linux/x86_64

2021-08-25 Thread sunil.k.pandey via Gcc-patches
On Linux/x86_64, ed3de423f1694d30f90c024fb6e19e2c6323 is the first bad commit commit ed3de423f1694d30f90c024fb6e19e2c6323 Author: Martin Sebor Date: Wed Aug 25 14:36:13 2021 -0600 Avoid printing range table header alone. caused FAIL: gcc.dg/tree-ssa/evrp1.c scan-tree-dump evrp "\

[r12-3142 Regression] FAIL: 20_util/enable_shared_from_this/89303.cc (test for excess errors) on Linux/x86_64

2021-08-25 Thread sunil.k.pandey via Gcc-patches
On Linux/x86_64, 5c85f29537662f1f4195a102cbf0182ffa32d8ac is the first bad commit commit 5c85f29537662f1f4195a102cbf0182ffa32d8ac Author: Jan Hubicka Date: Wed Aug 25 21:43:07 2021 +0200 Merge load/stores in ipa-modref summaries caused FAIL: 20_util/enable_shared_from_this/89303.cc (test

Re: [PATCH] Make sure we're playing with integral modes before call extract_integral_bit_field.

2021-08-25 Thread Hongtao Liu via Gcc-patches
On Tue, Aug 24, 2021 at 7:39 PM Richard Biener wrote: > > On Tue, Aug 24, 2021 at 11:38 AM Hongtao Liu wrote: > > > > On Tue, Aug 24, 2021 at 5:40 PM Hongtao Liu wrote: > > > > > > On Tue, Aug 17, 2021 at 9:52 AM Hongtao Liu wrote: > > > > > > > > On Mon, Aug 9, 2021 at 4:34 PM Hongtao Liu wro

Re: [PATCH, rs6000] Disable gimple fold for float or double vec_minmax when fast-math is not set

2021-08-25 Thread HAO CHEN GUI via Gcc-patches
Hi Bill,    Thanks for your comments. Hi Segher,    Here is the ChangeLog and patch diff. Thanks. 2021-08-25 Haochen Gui gcc/     * config/rs6000/rs6000-call.c (rs6000_gimple_fold_builtin):     Modify the VSX_BUILTIN_XVMINDP, ALTIVEC_BUILTIN_VMINFP,     VSX_BUILTIN_XVMAXDP, ALTIVEC_BUILTIN_V

Re: [Patch] Fix cygming-crtend.c build warning due to -Wprio-ctor-dtor

2021-08-25 Thread Jonathan Yong via Gcc-patches
On 8/25/21 11:06 PM, Jeff Law wrote: On 8/25/2021 10:46 AM, Jonathan Yong via Gcc-patches wrote: Attached patches OK?     cygming-crtend.c: fix build warnings     libgcc/Changelog:     * config/i386/cygming-crtend.c: Fix register_frame_ctor     and register_frame_dtor warning

Re: [PATCH] Make sure we're playing with integral modes before call extract_integral_bit_field.

2021-08-25 Thread Hongtao Liu via Gcc-patches
On Thu, Aug 26, 2021 at 7:16 AM Jeff Law wrote: > > > > On 8/24/2021 3:44 AM, Hongtao Liu via Gcc-patches wrote: > > On Tue, Aug 24, 2021 at 5:40 PM Hongtao Liu wrote: > > On Tue, Aug 17, 2021 at 9:52 AM Hongtao Liu wrote: > > On Mon, Aug 9, 2021 at 4:34 PM Hongtao Liu wrote: > > On Fri, Aug 6,

[PATCH] Fold more shuffle builtins to VEC_PERM_EXPR.

2021-08-25 Thread liuhongt via Gcc-patches
This patch is a follow-up to [1], it fold all shufps/shufpd builtins into gimple. Bootstrapped and regtested on x86_64-linux-gnu{-m32,}. [1] https://gcc.gnu.org/pipermail/gcc-patches/2019-May/521983.html gcc/ PR target/98167 PR target/43147 * config/i386/i386.c (ix86_

Re: [PATCH] Fold more shuffle builtins to VEC_PERM_EXPR.

2021-08-25 Thread Hongtao Liu via Gcc-patches
On Thu, Aug 26, 2021 at 12:57 PM liuhongt wrote: > > This patch is a follow-up to [1], it fold all shufps/shufpd builtins into > gimple. Of course for non-mask or mask all-ones version. > Bootstrapped and regtested on x86_64-linux-gnu{-m32,}. > > [1] https://gcc.gnu.org/pipermail/gcc-patches/

Re: [PATCH v3] Fix incomplete computation in fill_always_executed_in_1

2021-08-25 Thread Xionghu Luo via Gcc-patches
On 2021/8/24 16:20, Richard Biener wrote: > On Tue, 24 Aug 2021, Xionghu Luo wrote: > >> >> >> On 2021/8/19 20:11, Richard Biener wrote: - class loop *inn_loop = loop; if (ALWAYS_EXECUTED_IN (loop->header) == NULL) { @@ -3232,19 +3231,6 @@ fill_always_e

Re: [GCC-11] [PATCH 0/5] Finish and general-regs-only

2021-08-25 Thread Richard Biener via Gcc-patches
On Wed, Aug 25, 2021 at 9:34 AM Uros Bizjak wrote: > > On Tue, Aug 24, 2021 at 4:57 PM H.J. Lu wrote: > > > > On Sun, Aug 15, 2021 at 11:11 PM Richard Biener > > wrote: > > > > > > On Fri, Aug 13, 2021 at 3:51 PM H.J. Lu wrote: > > > > > > > > and target("general-regs-only") function attribute

Re: [PATCH] configure: Allow a host makefile fragment to override PIE flag settings.

2021-08-25 Thread Richard Biener via Gcc-patches
On Wed, Aug 25, 2021 at 8:30 PM Iain Sandoe via Gcc-patches wrote: > > > > > On 25 Aug 2021, at 19:22, H.J. Lu wrote: > > > > On Wed, Aug 25, 2021 at 11:10 AM Iain Sandoe > > wrote: > >> > >> > >> > >>> On 25 Aug 2021, at 18:56, H.J. Lu via Gcc-patches > >>> wrote: > >>> > >>> On Wed, Aug 25,