Re: [PATCH] constructor: Elide expand_constructor when can move by pieces is true

On 5/21/21 8:57 AM, Richard Biener wrote: > On Thu, May 20, 2021 at 4:04 PM H.J. Lu wrote: >> >> On Thu, May 20, 2021 at 12:51 AM Richard Biener >> wrote: >>> >>> On Wed, May 19, 2021 at 3:22 PM H.J. Lu wrote: On Wed, May 19, 2021 at 2:33 AM Richard Biener wrote: > > O

[PATCH] aarch64: Add attributes for builtins specified in aarch64-builtins.c

Hi all, Besides the builtins in aarch64-simd-builtins.def there are a number of builtins defined in aarch64-builtins.c itself. They could also benefit from the attributes generated by aarch64_get_attributes. However aarch64_get_attributes and its helpers are only set up to handle a aarch64_simd_

Re: [Ping^2, Patch, Fortran] PR98301 Re: RANDOM_INIT() and coarray Fortran

Ping, ping! Please find attached a rebased version of the patch for the RANDOM_INIT issue with coarray Fortran. Nothing changed to the previous version, just rebased to current master. Regtested fine on x86_64-linux/f33. Ok for trunk? - Andre On Mon, 3 May 2021 08:20:36 -0700 Steve Kargl wrote

[Ada] Use EXACT_DIV_EXPR as much as possible

...when the division is exact, typically dividing TYPE_SIZE by BITS_PER_UNIT. Tested on x86-64/Linux, applied on the mainline. 2021-05-21 Eric Botcazou * gcc-interface/decl.c (gnat_to_gnu_entity) : Replace CEIL_DIV_EXPR with EXACT_DIV_EXPR. * gcc-interface/misc.c (gna

Re: [PATCH] Try LTO partial linking. (Was: Speed of compiling gimple-match.c)

On 5/20/21 5:55 PM, Jan Hubicka wrote: Quick solution is to also modify partitioner to use the local symbol names when doing incremental linking (those mixing in source code and random seeds) to avoid clashes. Good hint. I added hash based on object file name (I don't want to handle proper stri

[Ada] Fix incorrect SLOC on instruction

This puts the missing SLOC on a statement generated by a return. Tested on x86-64/Linux, applied on the mainline, 11 and 10 branches. 2021-05-21 Eric Botcazou * gcc-interface/trans.c (gnat_to_gnu) : Put a SLOC on the assignment from the return value to the return obje

[Ada] Fix spurious No_Elaboration violation for Size attribute

We optimize the associated range check but nevertheless flag a violation. Tested on x86-64/Linux, applied on the mainline. 2021-05-21 Eric Botcazou * gcc-interface/trans.c (Call_to_gnu): Minor tweaks. (gnat_to_gnu_external): Likewise. (Raise_Error_to_gnu): Return an e

[Ada] Fix segfault at run time on strict-alignment platforms

This fixes a regression present on the mainline and 11 branch by restricting the problematic change dealing with bitfields whose nomimal subtype is self- referential to the cases where the size is really lower. Tested on x86-64/Linux, applied on the mainline and 11 branch. 2021-05-21 Eric Botc

Re: [PATCH] Try LTO partial linking. (Was: Speed of compiling gimple-match.c)

On 5/20/21 2:54 PM, Richard Biener wrote: On Thu, May 20, 2021 at 2:34 PM Martin Liška wrote: Hello. I've got a patch candidate that leverages partial linking for a couple of selected object files. I'm sending make all-host- jX results for my machine: before: 3m18s (user 32m52s) https://gi

[Ada] Always translate Is_Pure flag into pure in C sense

Gigi has historically translated the Is_Pure flag of the front-end into the "const" attribute of GNU C. That's correct for subprograms of pure Ada units, but not fully exact according to the semantics of the flag. Tested on x86-64/Linux, applied on the mainline, 11 and 10 branches. 2021-05-21

Re: [PATCH] Add no_sanitize_coverage attribute.

On 5/20/21 12:55 PM, Marco Elver wrote: I think this came up with other no_sanitize [1] based on what I had written to you last year [2]. [1]https://gcc.gnu.org/pipermail/gcc-patches/2020-June/547618.html [2]https://lore.kernel.org/lkml/canpmjnnrz5ovkb6pe7k6gjfogbht_zhypkng9ad+kjndzk7...@mail.gm

[Ada] Fix internal error on locally derived bit-packed array type

This is a regression present on the mainline, 11 and 10 branches, in the form of an ICE on a locally derived bit-packed array type. Tested on x86-64/Linux, applied on the mainline, 11 and 10 branches. 2021-05-21 Eric Botcazou * gcc-interface/decl.c (gnat_to_gnu_entity) : Process

Re: [PATCH][DOCS] Remove install-old.texi

On 5/19/21 4:49 PM, Joseph Myers wrote: On Wed, 19 May 2021, Martin Liška wrote: I'm not sure where this list comes from I split parts in contrib/config-list.mk and printed them. but I'd expect "linux" to be the canonical "linux-gnu", along with "linux-uclibc", "linux-android", "linux-musl"

[Ada] Replace ? with ?? in warning messages

The former has been deprecated in favor of the latter. Tested on x86-64/Linux, applied on the mainline. 2021-05-21 Ghjuvan Lacambre * gcc-interface/decl.c (gnat_to_gnu_entity): Replace ? with ??. (gnat_to_gnu_param): Likewise. (gnat_to_gnu_subprog_type): Likewise.

[Ada] Consistently generate debug info for elaboration variables

This makes sure that debug info is generated for elaboration variables, even if the variables are not generated exclusively for this purpose. Tested on x86-64/Linux, applied on the mainline. 2021-05-21 Eric Botcazou * gcc-interface/decl.c (gnat_to_gnu_entity) : Do not pass de

[Ada] Detect illegal conditions in Raise_xxx_Error nodes

Enforce comment from sinfo.ads about the Condition field in N_Raise_xxx_Error nodes. Only an extra sanity check; the behaviour is not affected. Tested on x86-64/Linux, applied on the mainline. 2021-05-21 Piotr Trojanek * gcc-interface/trans.c (Raise_Error_to_gnu): Add an assertion.

Re: [Ada] Detect illegal conditions in Raise_xxx_Error nodes

> 2021-05-21 Piotr Trojanek > > * gcc-interface/trans.c (Raise_Error_to_gnu): Add an assertion. -- Eric Botcazoudiff --git a/gcc/ada/gcc-interface/trans.c b/gcc/ada/gcc-interface/trans.c index 289a2efcaf1..ee014a35cc2 100644 --- a/gcc/ada/gcc-interface/trans.c +++ b/gcc/ada/gcc-interfac

Re: PowerPC64 ELFv2 -fpatchable-function-entry

On Wed, May 19, 2021 at 09:39:30PM +0930, Alan Modra wrote: > On Tue, May 18, 2021 at 05:48:40AM -0500, Segher Boessenkool wrote: > > I wrote a bit later: > > > > > > Can you make this less hacky please? Changing the generic code is just > > > > fine as well, it needs some love. > > > > In effec

[PATCH] lto-dump : Fix an ICE when lto-dump try to call 'get_size()' on thunk symbols.

Hi, ​ We, ByteDance, have seen an ICE on trunk which can be reproduced with the following symbol testcase. The problem is caused by referencing a null pointer when applying 'n_basic_blocks_for_fn' on a thunk symbol. For the thunk symbol, 'DECL_STRUCT_FUNCTION (cnode->decl)' will return an empty poi

Re: [PATCH v3] bpf.2: Use standard types and attributes

Hello Daniel, On 5/17/21 8:56 PM, Daniel Borkmann wrote: On 5/16/21 11:16 AM, Alejandro Colomar (man-pages) wrote: Signed-off-by: Alejandro Colomar Discussion: Nacked-by: Alexei Starovoitov Nacked-by: G

[PATCH][GCC-9][committed][libsanitizer]: Remove cyclades from libsanitizer

Hi All, [rebased patch for GCC-9 but the same as the others] The Linux kernel has removed the interface to cyclades from the latest kernel headers[1] due to them being orphaned for the past 13 years. libsanitizer uses this header when compiling against glibc, but glibcs itself doesn't seem to h

[PATCH] i386: Add comparisons for 4-byte vectors [PR100637]

2021-05-21 Uroš Bizjak gcc/ PR target/100637 * config/i386/i386-expand.c (ix86_expand_sse_movcc): Handle V4QI and V2HI modes. (ix86_expand_sse_movcc): Ditto. * config/i386/mmx.md (*3): New instruction pattern. (*eq3): Ditto. (*gt3): Ditto. (*xop_pcmov_): Ditt

[PATCH 2/5] Convert Walloca pass to RANGE_QUERY(cfun).

This patch converts the Walloca pass to use an on-demand ranger accesible with RANGE_QUERY instead of having to create a ranger and pass it around. Tested on x86-64 Linux. OK? gcc/ChangeLog: * gimple-ssa-warn-alloca.c (alloca_call_type): Use RANGE_QUERY instead of query argument

[PATCH 5/5] Cleanup get_range_info

Now that there is only one user of get_range_info() we can clean this up to always return a range instead of pairs of wide_ints. A follow-up patch will inline both get_range_info and get_ptr_nonnull into its only remaining user. Tested on x86-64 Linux. OK? gcc/ChangeLog: * tree-ssaname

[PATCH 1/5] Common API for accessing global and on-demand ranges.

This patch provides a generic API for accessing global ranges. It is meant to replace get_range_info() and get_ptr_nonnull() with one common interface. It uses the same API as the ranger (class range_query), so there will now be one API for accessing local and global ranges alike. Follow-up patc

[PATCH 3/5] Convert evrp pass to RANGE_QUERY(cfun).

Some tests required tweaking, as exporting global ranges from evrp will now provide better ranges for subsequent passes. Tested on x86-64 Linux. OK? gcc/ChangeLog: * gimple-ssa-evrp.c (rvrp_folder): Call enable_ranger. Use RANGE_QUERY. (~rvrp_folder): Call disable_range

[PATCH 4/5] Convert remaining passes to RANGE_QUERY.

This patch converts the remaining users of get_range_info and get_ptr_nonnull to the range_query API. No effort was made to move passes away from VR_ANTI_RANGE, or any other use of deprecated methods. This was a straight up conversion to the new API, nothing else. Tested on x86-64 Linux. OK? g

Re: [PATCH] Add 3 target hooks for memset

On Thu, May 20, 2021 at 10:42 PM Bernd Edlinger wrote: > > On 5/20/21 10:49 PM, H.J. Lu wrote: > > On Wed, May 19, 2021 at 5:55 AM H.J. Lu wrote: > >> > >> On Wed, May 19, 2021 at 2:25 AM Richard Biener > >> wrote: > >>> > >>> On Tue, May 18, 2021 at 9:16 PM H.J. Lu wrote: > > Add TAR

Re: [PATCH] aarch64: Add attributes for builtins specified in aarch64-builtins.c

Kyrylo Tkachov writes: > Hi all, > > Besides the builtins in aarch64-simd-builtins.def there are a number of > builtins defined in aarch64-builtins.c itself. > They could also benefit from the attributes generated by > aarch64_get_attributes. > However aarch64_get_attributes and its helpers are

[PATCH] c++/88601 - [C/C++] __builtin_shufflevector support

This adds support for the clang __builtin_shufflevector extension to the C and C++ frontends. The builtin is lowered to VEC_PERM_EXPR. Because VEC_PERM_EXPR does not support different sized vector inputs or result or the special permute index of -1 (don't-care) c_build_shufflevector applies loweri

Re: [PATCH] Try LTO partial linking. (Was: Speed of compiling gimple-match.c)

On Fri, May 21, 2021 at 5:25 AM Martin Liška wrote: > > On 5/20/21 2:54 PM, Richard Biener wrote: > > On Thu, May 20, 2021 at 2:34 PM Martin Liška wrote: > >> > >> Hello. > >> > >> I've got a patch candidate that leverages partial linking for a couple of > >> selected object files. > >> > >> I'm

Re: [PATCH] Add no_sanitize_coverage attribute.

On Fri, May 21, 2021 at 10:50AM +0200, Martin Liška wrote: > On 5/20/21 12:55 PM, Marco Elver wrote: > > I think this came up with other no_sanitize [1] based on what I had > > written to you last year [2]. > > > > [1]https://gcc.gnu.org/pipermail/gcc-patches/2020-June/547618.html > > [2]https://l

Re: [PATCH 00/57] Replace the Power target-specific built-in machinery

On 5/20/21 4:57 PM, Segher Boessenkool wrote: Is there some (semi-)automatic way to compare the results of the old and new systems? Yes...very "semi".  There's a patch in the series that updates the information printed from -mdebug=builtin.  I use this to print the builtins generated by the o

Re: [PATCH 04/57] rs6000: Add initial input files

On 5/20/21 5:46 PM, Segher Boessenkool wrote: On Tue, Apr 27, 2021 at 10:32:39AM -0500, Bill Schmidt via Gcc-patches wrote: This patch adds a tiny subset of the built-in and overload descriptions. * config/rs6000/rs6000-builtin-new.def: New. You'll have to rename this to not have "-ne

Re: [PATCH 05/57] rs6000: Add file support and functions for diagnostic support

On 5/20/21 6:03 PM, Segher Boessenkool wrote: Hi! On Tue, Apr 27, 2021 at 10:32:40AM -0500, Bill Schmidt via Gcc-patches wrote: * config/rs6000/rs6000-gen-builtins.c (bif_file): New filescope variable. What makes it interesting that this var has file scope? Did you mean to say

[PATCH] Elide expand_constructor if move by pieces is preferred

On Thu, May 20, 2021 at 11:57 PM Richard Biener wrote: > > On Thu, May 20, 2021 at 4:04 PM H.J. Lu wrote: > > > > On Thu, May 20, 2021 at 12:51 AM Richard Biener > > wrote: > > > > > > On Wed, May 19, 2021 at 3:22 PM H.J. Lu wrote: > > > > > > > > On Wed, May 19, 2021 at 2:33 AM Richard Biener

Re: [PATCH] constructor: Elide expand_constructor when can move by pieces is true

On Fri, May 21, 2021 at 12:30 AM Bernd Edlinger wrote: > > > > On 5/21/21 8:57 AM, Richard Biener wrote: > > On Thu, May 20, 2021 at 4:04 PM H.J. Lu wrote: > >> > >> On Thu, May 20, 2021 at 12:51 AM Richard Biener > >> wrote: > >>> > >>> On Wed, May 19, 2021 at 3:22 PM H.J. Lu wrote: > > >

[Patch, Fortran] PR100337 Should be able to pass non-present optional arguments to CO_BROADCAST

Hi, the attached patch fixes an issue when calling CO_BROADCAST in -fcoarray=single mode, where the optional but non-present (in the calling scope) stat variable was assigned to before checking for it being not present. Regtests fine on x86-64-linux/f33. Ok for trunk? Regards, Andre -- A

Re: [PATCH] c++/88601 - [C/C++] __builtin_shufflevector support

On Fri, May 21, 2021 at 3:19 PM Richard Biener wrote: > > This adds support for the clang __builtin_shufflevector extension to > the C and C++ frontends. The builtin is lowered to VEC_PERM_EXPR. > Because VEC_PERM_EXPR does not support different sized vector inputs > or result or the special perm

RE: [PATCH] aarch64: Add attributes for builtins specified in aarch64-builtins.c

> -Original Message- > From: Richard Sandiford > Sent: 21 May 2021 13:08 > To: Kyrylo Tkachov > Cc: gcc-patches@gcc.gnu.org > Subject: Re: [PATCH] aarch64: Add attributes for builtins specified in > aarch64- > builtins.c > > Kyrylo Tkachov writes: > > Hi all, > > > > Besides the buil

[RFC PATCH] i386: Enable auto-vectorization for 32bit modes (+ testcases)

Here it is, the patch that enables auto-vectorization for 32bit modes. Sent as RFC, because the patch fails some vectorizer scans, as it obviously enables more vectorization to happen: Running target unix FAIL: gcc.dg/vect/pr71264.c -flto -ffat-lto-objects scan-tree-dump vect "vectorized 1 loops

Add 'libgomp.oacc-fortran/privatized-ref-2.f90'

Hi! This came into existance internally, when the og10 branch was set up. On 2020-06-03T17:23:51+0200, Tobias Burnus wrote: > This fixes [...] on OG10 (og10_prerelease); it will be > later applied to gcn/… to fix the issue. (Upstream is unaffected.) > [...] However, that means that your testcas

Re: [Ping^2, Patch, Fortran] PR98301 Re: RANDOM_INIT() and coarray Fortran

On Fri, May 21, 2021 at 10:09:02AM +0200, Andre Vehreschild wrote: > Ping, ping! > > Please find attached a rebased version of the patch for the RANDOM_INIT issue > with coarray Fortran. Nothing changed to the previous version, just rebased to > current master. > > Regtested fine on x86_64-linux/

Re: [PATCH 0.5/2] ipa-sra: Restructure how cloning and call redirection communicate (PR 93385)

Hi, this is a PING of the following patch, which however also now got two fixes, it deallocated the newly added summary in toplev::finalize and fixes a mistakenly uninitialized field (dummy, used by OpenMP SIMD cloning). The subsequent patch which actually deals with the PR has already been appro

Re: [PATCH 1.0/2] ipa-sra: Introduce a mini-DCE to tree-inline.c (PR 93385)

Hi, On Tue, May 11 2021, Richard Biener wrote: > On Mon, May 10, 2021 at 8:52 PM Martin Jambor wrote: [...] >> @@ -969,6 +969,97 @@ ipa_param_body_adjustments::carry_over_param (tree t) >>return new_parm; >> } >> >> +/* Return true if BLOCKS_TO_COPY is NULL or if PHI has an argument ARG in

Re: [PATCH] c++: Add new warning options for C++ language mismatches

On 5/20/21 4:05 PM, Jonathan Wakely wrote: On 19/05/21 23:52 +0100, Jonathan Wakely wrote: On 19/05/21 16:08 -0400, Jason Merrill wrote: On 5/19/21 4:05 PM, Jonathan Wakely wrote: Oh, also we have https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93769 which points out a problem with the current wo

Re: [PATCH] c++/88601 - [C/C++] __builtin_shufflevector support

On 5/21/21 8:33 AM, Richard Biener wrote: This adds support for the clang __builtin_shufflevector extension to the C and C++ frontends. The builtin is lowered to VEC_PERM_EXPR. Because VEC_PERM_EXPR does not support different sized vector inputs or result or the special permute index of -1 (don'

Re: GCC 9.4 Status Report (2021-05-19), branch frozen for release

Sorry, just pushed 3 patches before I noticed this. They're safe but not critical, should I back them out? On Wed, May 19, 2021 at 4:06 AM Richard Biener wrote: > > Status > == > > The GCC 9 branch is now frozen for the upcoming GCC 9.4 release. > I will announce a first release candidate s

Re: [PATCH] tree-sra: Avoid refreshing into const base decls (PR 100453)

Hi, On Mon, May 17 2021, Eric Botcazou wrote: >> sorry for breaking Ada over the weekend, however... > > No problem. > >> None of the non-ACATS tests fail for me without doing a bootstrap, but I >> did manage to reproduce this one (by the way, there really should be a >> documentation on how to ru

[PATCH] libstdc++: More efficient std::chrono::year::leap.

Simple change to std::chrono::year::is_leap. If a year is multiple of 100, then it's divisible by 400 if and only if it's divisible by 16. The latter allows for better code generation. Tested on x86_64-pc-linux-gnu. libstdc++-v3/ChangeLog: * include/std/chrono: diff --git a/libstdc++-v3/include

Re: [PATCH] libstdc++: More efficient std::chrono::year::leap.

> On May 21, 2021, at 1:46 PM, Cassio Neri via Gcc-patches > wrote: > > Simple change to std::chrono::year::is_leap. If a year is multiple of 100, > then it's divisible by 400 if and only if it's divisible by 16. The latter > allows for better code generation. I wonder if the optimizer could

Re: [PATCH] libstdc++: More efficient std::chrono::year::leap.

I've checked the generated code and the compiler doesn't figure out the logic. I added a comment to explain. (Revised patch below and attached.) Best wishes, Cassio. --- Simple change to std::chrono::year::is_leap. If a year is multiple of 100, then it's divisible by 400 if and only if it's div

Re: [PATCH 06/57] rs6000: Add helper functions for parsing

Hi! On Tue, Apr 27, 2021 at 10:32:41AM -0500, Bill Schmidt via Gcc-patches wrote: > +/* Used as a sentinel for range constraints on integer fields. No field can > + be 32 bits wide, so this is a safe sentinel value. */ > +#define MININT INT32_MIN INT32_MIN is for value of type int32_t. You u

Re: [PATCH 1/3] openacc: Add support for gang local storage allocation in shared memory

Hi! On 2021-04-19T12:23:56+0100, Julian Brown wrote: > On Thu, 15 Apr 2021 19:26:54 +0200 > Thomas Schwinge wrote: >> This has iterated through several conceptually different designs and >> implementations, by several people, over the past several years. > > I hope this wasn't a hint that I'd fa

Re: [PATCH 3/3] nvptx: NVPTX parts for OpenACC private variables patch

Hi! On 2021-02-26T04:34:52-0800, Julian Brown wrote: > This patch contains the NVPTX backend support for placing OpenACC > gang-private variables in GPU shared memory. > > Tested with offloading to NVPTX. > > This is substantially the same as the version previously posted: I will > assume it is a

Re: [PATCH, OpenACC] Add support for gang local storage allocation in shared memory

Hi! On 2019-06-07T15:08:37+0100, Julian Brown wrote: > Hi Jakub, > > Thanks for the review! I believe I've addressed all your comments in > the attached version of the patch. > > On Mon, 3 Jun 2019 18:23:00 +0200 > Jakub Jelinek wrote: >> > +/* Record vars listed in private clauses in CLAUSES in

Re: [PATCH 1/3] openacc: Add support for gang local storage allocation in shared memory

Hi! On 2021-02-26T04:34:50-0800, Julian Brown wrote: > --- a/gcc/internal-fn.c > +++ b/gcc/internal-fn.c > @@ -2957,6 +2957,8 @@ expand_UNIQUE (internal_fn, gcall *stmt) >else > gcc_unreachable (); >break; > +case IFN_UNIQUE_OACC_PRIVATE: > + break; > } > >

Re: [PATCH 1/2] c-family: Copy DECL_USER_ALIGN even if DECL_ALIGN is similar.

On 5/19/21 6:03 PM, Martin Sebor via Gcc-patches wrote: On 5/3/21 8:53 AM, Robin Dapp via Gcc-patches wrote: Hi, on s390 a warning test fails: inline int ATTR ((cold, aligned (8))) finline_hot_noret_align (int); inline int ATTR ((warn_unused_result)) finline_hot_noret_align (int); inline int

Re: [PATCH 1/3] openacc: Add support for gang local storage allocation in shared memory

Hi! On 2021-04-19T12:23:56+0100, Julian Brown wrote: > On Thu, 15 Apr 2021 19:26:54 +0200 > Thomas Schwinge wrote: >> On 2021-02-26T04:34:50-0800, Julian Brown >> wrote: >> > Two new target hooks are introduced: >> > TARGET_GOACC_ADJUST_PRIVATE_DECL and TARGET_GOACC_EXPAND_VAR_DECL. >> > The fi

Re: [PATCH 1/3] openacc: Add support for gang local storage allocation in shared memory

Hi! On 2021-04-19T12:23:56+0100, Julian Brown wrote: > On Thu, 15 Apr 2021 19:26:54 +0200 > Thomas Schwinge wrote: >> As that may not be obvious to the reader, I'd like to have the >> 'TREE_ADDRESSABLE' conditionalization be documented in the code. You >> had explained that in >>

[committed] openmp: Fix up handling of implicit lastprivate on outer constructs for implicit linear and lastprivate IVs [PR99928]

Hi! This patch fixes the handling of lastprivate propagation to outer combined/composite leaf constructs from implicit linear or lastprivate clauses on simd IVs and adds missing testsuite coverage for explicit and implicit lastprivate on simd IVs. Bootstrapped/regtested on x86_64-linux and i686

[committed] openmp: Fix up firstprivate+lastprivate clause handling [PR99928]

Hi! The C/C++ clause splitting happens very early during construct parsing, but only the FEs later on handle possible instantiations, non-static member handling and array section lowering. In the OpenMP 5.0/5.1 rules, whether firstprivate is added to combined target depends on whether it isn't als

Re: [PATCH] rs6000: MMA test case ICEs using -O3 [PR99842]

Getting back to this now that trunk is open again... On 3/31/21 2:17 PM, Segher Boessenkool wrote: > On Tue, Mar 30, 2021 at 06:49:29PM -0500, Peter Bergner wrote: >> The mma_assemble_input_operand predicate does not accept reg+reg indexed >> addresses which can lead to ICEs. The problem is that

[OpenACC privatization] Reject 'static', 'external' in blocks [PR90115] (was: [Patch][OG10] omp-low.c: Avoid offload-target lto1 is-missing error by not-privatizing TREE_READONLY vars)

Hi! Might be interesting to also research the comments at the end of the email from an OpenMP perspective? On 2020-07-23T17:10:54+0100, Julian Brown wrote: > On Thu, 16 Jul 2020 15:53:54 +0200 > Tobias Burnus wrote: > >> [This is an OpenACC issue but I would not completely surprised if >> somet

Re: [committed] Fix minor CC0 removal fallout on cr16

On Wed, May 5, 2021 at 8:17 AM Jeff Law via Gcc-patches wrote: > > > cr16 failed to build due to remnants of CC0 support (NOTICE_UPDATE_CC). > This removes the macro and obvious bits necessary to support it. > Committed to the trunk. > cr16-elf won't build: /export/gnu/import/git/sources/gcc/gcc

[PATCH] c++: Fix reference NTTP binding to noexcept fn [PR97420]

Here, in C++17 mode, convert_nontype_argument_function is rejecting binding a non-noexcept function reference template parameter to a noexcept function (encoded as the template argument '*(int (&) (int)) &f'). The first roadblock to making this work is that the argument is wrapped an an implicit I

[PATCH] c++: access for hidden friend of nested class template [PR100502]

Here, during ahead of time access checking for the private member EnumeratorRange::end_reached_ in the hidden friend f, we're triggering the the assert in enforce_access that verifies we're not trying to add a dependent access check to TI_DEFERRED_ACCESS_CHECKS. The special thing about this class

Re: [PATCH 07/57] rs6000: Add functions for matching types, part 1 of 3

Hi! On Tue, Apr 27, 2021 at 10:32:42AM -0500, Bill Schmidt via Gcc-patches wrote: > +enum void_status { The { goes on a new line, in our coding style. > +struct typeinfo { The same is true in structs (but that is violated in some places). > + char isvoid; bool? I'm not asking you to change

Re: [PATCH 06/57] rs6000: Add helper functions for parsing

On 5/21/21 1:51 PM, Segher Boessenkool wrote: Hi! On Tue, Apr 27, 2021 at 10:32:41AM -0500, Bill Schmidt via Gcc-patches wrote: +/* Used as a sentinel for range constraints on integer fields. No field can + be 32 bits wide, so this is a safe sentinel value. */ +#define MININT INT32_MIN INT

Re: [PATCH 08/57] rs6000: Add functions for matching types, part 2 of 3

On Tue, Apr 27, 2021 at 10:32:43AM -0500, Bill Schmidt via Gcc-patches wrote: Oh, hrm, I deleted it all? I guess there was nothing to complain about ^W^Wcomment on then! Okay for trunk. Thanks! Segher

Re: [PATCH 09/57] rs6000: Add functions for matching types, part 3 of 3

On Tue, Apr 27, 2021 at 10:32:44AM -0500, Bill Schmidt via Gcc-patches wrote: > static int > match_const_restriction (typeinfo *typedata) > { > + int oldpos = pos; > + if (linebuf[pos] == '<') > + else if (linebuf[pos] == '{') > + assert (linebuf[pos] == '['); Can you factor this plea

Re: [PATCH 10/57] rs6000: Red-black tree implementation for balanced tree search

On Tue, Apr 27, 2021 at 10:32:45AM -0500, Bill Schmidt via Gcc-patches wrote: > 2021-03-03 Bill Schmidt > > gcc/ > * config/rs6000/rbtree.c: New file. > * config/rs6000/rbtree.h: New file. > + struct rbt_string_node *nodeptr > += (struct rbt_string_node *) malloc (sizeof (stru

Re: [PATCH 06/57] rs6000: Add helper functions for parsing

Hi! On Fri, May 21, 2021 at 03:56:09PM -0500, Bill Schmidt wrote: > On 5/21/21 1:51 PM, Segher Boessenkool wrote: > >>+/* Exit codes for the shell. */ > >>+enum exit_codes { > >>+ EC_INTERR > >>+}; > >Please define this with some specified value (so append " = 1" or such), > >or just write "exit

[r12-989 Regression] FAIL: libgomp.oacc-fortran/privatized-ref-2.f90 -DACC_DEVICE_TYPE_host=1 -DACC_MEM_SHARED=1 -foffload=disable -Os (test for warnings, line 98) on Linux/x86_64

On Linux/x86_64, 325aa13996bafce0c4927876c315d1fa706d9881 is the first bad commit commit 325aa13996bafce0c4927876c315d1fa706d9881 Author: Thomas Schwinge Date: Fri May 21 08:51:47 2021 +0200 [OpenACC privatization] Reject 'static', 'external' in blocks [PR90115] caused FAIL: libgomp.oacc

Re: [Ping^2, Patch, Fortran] PR98301 Re: RANDOM_INIT() and coarray Fortran

yes, please commit On 5/21/21 8:08 AM, Steve Kargl via Fortran wrote: On Fri, May 21, 2021 at 10:09:02AM +0200, Andre Vehreschild wrote: Ping, ping! Please find attached a rebased version of the patch for the RANDOM_INIT issue with coarray Fortran. Nothing changed to the previous version, just