[Patch, committed] OpenMP/Fortran - fix pasto + testcase in depobj [PR100397]

Missed a copy-and-paste edit – and I had to move the declaration of the variables further inside to avoid races - the 'x = 1' assignment has to be at the same scope as the var declaration. Interestingly, the runs were rather stable; here it passed for tens to hundreds of runs before failing. Com

Re: restore EH on x86-vx7r2

> On 4 May 2021, at 04:45, Alexandre Oliva wrote: > > > x86-vx7r2 needs svr4_dbx_register_map, but the default in i386/i386.h > was dbx_register_map, partially swapping ebp and esp in unwind info. > > i386/vxworks.h had a correct overrider, but it was conditional for > vxworks < 7. This pat

[PATCH] phiopt: Optimize (x <=> y) cmp z [PR94589]

Hi! genericize_spaceship genericizes i <=> j to approximately ({ int c; if (i == j) c = 0; else if (i < j) c = -1; else c = 1; c; }) for strong ordering and ({ int c; if (i == j) c = 0; else if (i < j) c = -1; else if (i > j) c = 1; else c = 2; c; }) for partial ordering. The C++ standard support

Re: [patch] Reuse non-gimple_reg variable for inlining

On Mon, May 3, 2021 at 5:06 PM Eric Botcazou wrote: > > > Hmm, instead of (ab-)using debug_map can we instead use sth like setting > > TREE_VISITED on the argument decl (not the value - it might be passed > > multiple tiimes)? IIRC TREE_VISITED state is undetermined thus we can > > clear it at th

Re: Minor testsuite fix for cr16 and xstormy16 targets

On Mon, May 3, 2021 at 6:08 PM Jeff Law via Gcc-patches wrote: > > > Richi's recent work twiddles dse1's actions for these targets. This > patch just updates the expected output. I'll keep an eye on other > targets as their results trickle in. > > > Committed to the trunk, Thanks - the same case

[PATCH] Restrict gcc.dg/tree-ssa/ssa-dse-26.c

This restricts the testcase to the target where it exposes the situation fixed with g:e9d297a15d68121ba5bdd5a76ea71c1916180622 which targets BIT_FIELD_REFs created by fold_truth_andor. This avoids strange dejagnu limits with overly long target lists and simplifies the tests. Tested on x86_64-unkn

Re: [PATCH] phiopt: Optimize (x <=> y) cmp z [PR94589]

On 04/05/21 09:44 +0200, Jakub Jelinek wrote: Hi! genericize_spaceship genericizes i <=> j to approximately ({ int c; if (i == j) c = 0; else if (i < j) c = -1; else c = 1; c; }) for strong ordering and ({ int c; if (i == j) c = 0; else if (i < j) c = -1; else if (i > j) c = 1; else c = 2; c; }

Re: [PATCH] Avoid DSE/DCE of pure call that throws

> Do you have extra fixes in your tree or does -fnon-call-exceptions > somehow magically paper over the issue? This optimization is valid in Ada for pure functions. RM 10.2.1(18/3) says: "If a library unit is declared pure, then the implementation is permitted to omit a call on a library-level s

[Ada] Fix reference to SPARK RM rule in comment

Adding rule about a user-defined equality operation as SPARK RM 6.1.4(11) is changing the numeration of previous rules (11,12). Tested on x86_64-pc-linux-gnu, committed on trunk gcc/ada/ * sem_prag.adb (Check_Mode_Restriction_In_Enclosing_Context): Fix reference to SPARK RM rule

[Ada] Guard against leading and trailing spaces reappearing in errors

The leading and trailing spaces in error message strings have been recently removed. This patch adds an assertion to prevent those spaces from appearing again. Tested on x86_64-pc-linux-gnu, committed on trunk gcc/ada/ * errout.adb (Error_Msg_Internal): Add assertion to prevent s

[Ada] Wrong membership test computation for interface type

When the left expression of a membership test is an object implementing an interface type, and the right operand of such membership test is a non-class wide interface type, the compiler generates code that, instead of comparing the actual tag of the left expression to the tag of the right operand,

[Ada] Preliminary cleanup in floating-point output implementation

This moves the low-level processing on characters to the package Img_Util, factors out common processing with fixed point, and overhauls the handling of negative zeros and rounding. This also removes the Is_Negative intrinsic function, which was only accessible from predefined units and is now unu

[Ada] Fix inconsistent handling of character set control switches

Switch -gnatic, where "c" denotes a character set, is described in the GNAT User's Guide sections 4.3.11 Character Set Control and 4.3.1 Alphabetical List of All Switches, but the latter section didn't mention '5' as an allowed value for "c". This is implemented in csets.adb, switch-c.adb (for the

[Ada] Check entries for formals of mode IN appearing as global outputs

Rule SPARK RM 6.1.4(13) only mentions "subprograms", but it is equally applicable to protected entries whose global inputs cannot appear as global outputs in nested subprograms. Tested on x86_64-pc-linux-gnu, committed on trunk gcc/ada/ * sem_prag.adb (Check_Mode_Restriction_In_Enclosing

[Ada] Reject constants of access-to-variable type as function globals

Constants of an access-to-variable type can only appear as global outputs in procedures, tasks and protected entries, not in functions. Tested on x86_64-pc-linux-gnu, committed on trunk gcc/ada/ * sem_prag.adb (Analyze_Global_Item): Take subprogram kind into account when acceptin

[Ada] Reject formals of mode IN appearing as global outputs

Fix implementation of SPARK RM 6.1.4(13), which says: "... if the global_specification of the outer subprogram has an entity denoted by a global_item with a mode_specification of Input or the entity is a formal parameter with a mode of in" but the rule was only enforced for outer subprogr

[Ada] Missing finalization on generic instantiation

If some objects are declared in the body of a generic package, these objects are not finalized when the package is instantiated at the library level. Tested on x86_64-pc-linux-gnu, committed on trunk gcc/ada/ * exp_ch7.adb (Build_Finalizer_Helper.New_Finalizer_Name): Unnest so th

[Ada] Use error marker for messages in GNATprove mode

Force the use of the "error:" marker for error messages in GNATprove. This helps distinguishing these messages from others like warnings, check messages and info messages, in particular when colored output is used. Tested on x86_64-pc-linux-gnu, committed on trunk gcc/ada/ * gnat1drv.adb

[Ada] Simplify use of a global name buffer for Global/Depends errors

Error messages about the Global/Depends contracts are constructed in the Global_Name_Buffer, but there is no need to store those messages as the Name_Id objects. Tested on x86_64-pc-linux-gnu, committed on trunk gcc/ada/ * sem_prag.adb (Role_Error, Usage_Error): Replace calls to

[Ada] Move match function for pragma Warnings to public spec

In order to use the same matching function in GNATprove for justifying messages through pragma Annotate as the matching function used for pragma Warnings, make that function publicly visible in Erroutc. Tested on x86_64-pc-linux-gnu, committed on trunk gcc/ada/ * erroutc.adb (Matches): M

[Ada] Ongoing work for AI12-0212: container aggregates

This patch refines the handling of container aggregates with non-static sizes given with iterated component associations and iterated element associations. When necessary we construct an expression to be evaluated dynamically to guide the allocation of the container, prior to inserting elements. T

[Ada] Simplify iteration over formal parameters for Global/Depends check

Replace low-level First_Entity/Next_Entity with a high-level First_Formal/Next_Formal. The new code is easier to debug, because we don't even see local subprograms, objects, etc. Tested on x86_64-pc-linux-gnu, committed on trunk gcc/ada/ * sem_prag.adb (Collect_Global_Item): Iterate dire

[Ada] Fix inconsistent iteration with First_Formal and Next_Entity

Iteration routines should come in pairs, i.e. First_Formal with Next_Formal and First_Entity with Next_Entity. This patch fixes two occurrences where First_Formal was used with Next_Entity. Cleanup only; semantics is unaffected. Tested on x86_64-pc-linux-gnu, committed on trunk gcc/ada/

[Ada] Reuse First_Formal for generic subprograms

Routine First_Formal works both for non-generic and generic subprograms, so patch removes a dubious special-casing for the latter. Tested on x86_64-pc-linux-gnu, committed on trunk gcc/ada/ * lib-xref.adb (Generate_Reference_To_Formals): Remove dedicated branch for generic subpro

[Ada] Fix handling of access-to-variable objects in Global and Depends

Objects that typically would be constant, but can actually be written because they are of access-to-variable type, can appear as outputs in the Global and Depends contracts of non-functions (i.e. functions, procedures, generic functions, generic procedures, protected entries, task types and single

[Ada] Assert_Failure vs Assertion_Error

When Ada introduced Ada.Assertions.Assertion_Error, we made it a renaming of the existing System.Assertions.Assert_Failure as provisioned by the ARM, but we should have done it the other way around, so that the reference/first class exception is the one from the ARM in e.g. exception messages. Thi

[Ada] Refine type of a counter variable from Integer to Natural

A List_Name_Count variable is initialized with zero, then incremented and decremented in a stack-like manner, so it should never become negative. This gives us extra confidence, but otherwise the behaviour is not affected. Tested on x86_64-pc-linux-gnu, committed on trunk gcc/ada/ * ppr

[Ada] Do not "optimize" by converting Positive to Unsigned

Back out the previous change that tried to "optimize" in Expand_Concatenate. It turns out that this is actually a pessimization, and it causes codepeer to trip over a bunch of extra checks. Tested on x86_64-pc-linux-gnu, committed on trunk gcc/ada/ * exp_ch4.adb (Expand_Concatenate): Rem

[Ada] Minor tweak in pretty-printing of expressions

Printing of expressions is used in GNATprove to display parts of an assertion which are not proved, Here the printing is improved slightly for an expression-with-actions, so that the underlying expression is printed, instead of the corresponding AST form of the expression with Expr_Name. Tested on

[Ada] Reuse existing To_Mixed routine in pretty-printer

Unit Pprint, which implements pretty-printing of the AST, defined routine To_Mixed_Case, which was identical to System.Case_Util.To_Mixed. Tested on x86_64-pc-linux-gnu, committed on trunk gcc/ada/ * pprint.adb (To_Mixed): Removed.diff --git a/gcc/ada/pprint.adb b/gcc/ada/pprint.adb ---

[Ada] Use function and not procedure UI_Image in pretty-printing

Code cleanup; semantics is unaffected. The code for pretty-printing integer, real and string literals now looks the same. Tested on x86_64-pc-linux-gnu, committed on trunk gcc/ada/ * pprint.adb (Expr_Name): Simplify with functional variant of UI_Image.diff --git a/gcc/ada/pprint.

[Ada] Remove arbitrary and redundant qualification with Sinfo

Code cleanup; semantics is unaffected. Perhaps the extra qualification used to be necessary to avoid ambiguities, but it is no longer needed. Tested on x86_64-pc-linux-gnu, committed on trunk gcc/ada/ * pprint.adb: Remove qualification of arbitrary calls to Sinfo.Expressions and

Re: [RFC] Using main loop's updated IV as base_address for epilogue vectorization

On Fri, 30 Apr 2021, Andre Vieira (lists) wrote: > Hi, > > The aim of this RFC is to explore a way of cleaning up the codegen around > data_references.  To be specific, I'd like to reuse the main-loop's updated > data_reference as the base_address for the epilogue's corresponding > data_reference

Re: [PATCH] phiopt: Optimize (x <=> y) cmp z [PR94589]

On Tue, May 04, 2021 at 10:42:12AM +0100, Jonathan Wakely wrote: > > There are two things I'd like to address in a follow-up: > > 1) if (HONOR_NANS (TREE_TYPE (lhs1)) || HONOR_SIGNED_ZEROS (TREE_TYPE > > (lhs1))) > > is what I've copied from elsewhere in phiopt, but thinking about it, > > alll we

Re: ctype support for libstdc++ on VxWorks

On 03/05/21 23:52 -0300, Alexandre Oliva wrote: This patch adds ctype and locale support to libstdc++ on vxworks7. We've been using this for a while internally. It was tested with various vx7r2 targets. Ok to install? +// VxWorks does not consider spaces to be blank, however, the test

Re: [Patch] OpenMP: Support complex/float in && and || reduction

On 03.05.21 19:38, Jakub Jelinek wrote: All the above ChangeLog lines are too long. Fixed. The above line is too long too, ... I counted 80 characters - but the line break is now required for: used '(...)' around '... == ...'). + if (is_fp_and_or) +

Re: [Patch] OpenMP: Support complex/float in && and || reduction

On Tue, May 04, 2021 at 12:16:50PM +0200, Tobias Burnus wrote: > Unless there are further comments, I intent to commit it after the lunch > break. Just further nits, sorry (but no need to retest): > --- a/gcc/omp-low.c > +++ b/gcc/omp-low.c > @@ -6389,6 +6389,11 @@ lower_rec_input_clauses (tree c

[PATCH] tree-optimization/100329 - avoid reassociating asm goto defs

This avoids reassociating asm goto defs because we have no idea on which outgoing edge to insert defs. Bootstrapped and tested on x86_64-unknown-linux-gnu, pushed. 2021-05-04 Richard Biener PR tree-optimization/100329 * tree-ssa-reassoc.c (can_reassociate_p): Do not reassociat

[PATCH] tree-optimization/100398 - avoid DSE of control flow stmt

The following makes sure to preserve control altering stmts when removing trivially dead stmts in DSE. Boostrapped and tested on x86_64-unknown-linux-gnu, pushed. 2021-05-04 Richard Biener PR tree-optimization/100398 * tree-ssa-dse.c (pass_dse::execute): Preserve control

Re: [PATCH] Avoid DSE/DCE of pure call that throws

On Tue, 4 May 2021, Eric Botcazou wrote: > > Do you have extra fixes in your tree or does -fnon-call-exceptions > > somehow magically paper over the issue? > > This optimization is valid in Ada for pure functions. RM 10.2.1(18/3) says: > "If a library unit is declared pure, then the implementati

[RFC v2] bpf.2: Use standard types and attributes

Some manual pages are already using C99 syntax for integral types 'uint32_t', but some aren't. There are some using kernel syntax '__u32'. Fix those. Some pages also document attributes, using GNU syntax '__attribute__((xxx))'. Update those to use the shorter and more portable C11 keywords such

Re: [libstdc++] Inconsistent detection of __int128

On 30/04/21 16:24 -0400, David Edelsohn via Libstdc++ wrote: On Fri, Jan 8, 2021 at 11:10 AM Jonathan Wakely wrote: On 03/01/21 22:26 -0500, David Edelsohn via Libstdc++ wrote: >On Sun, Jan 3, 2021 at 9:45 PM Jonathan Wakely wrote: >> >> On Mon, 4 Jan 2021, 00:44 David Edelsohn via Libstdc++,

[PATCH] Add gnu::diagnose_as attribute

From: Matthias Kretz This attribute overrides the diagnostics output string for the entity it appertains to. The motivation is to improve QoI for library TS implementations, where diagnostics have a very bad signal-to-noise ratio due to the long namespaces involved. On Tuesday, 27 April 2021 11:

[committed] libstdc++: Do not use deduced return type for std::visit [PR 100384]

This avoids errors outside the immediate context when std::visit is an overload candidate because of ADL, but not actually viable. The solution is to give std::visit a non-deduced return type. New helpers are introduced for that, and existing ones refactored slightly. libstdc++-v3/ChangeLog:

Re: [PATCH 6/9] arm: Auto-vectorization for MVE: vcmp

Hi Christophe, On 30/04/2021 15:09, Christophe Lyon via Gcc-patches wrote: Since MVE has a different set of vector comparison operators from Neon, we have to update the expansion to take into account the new ones, for instance 'NE' for which MVE does not require to use 'EQ' with the inverted con

Re: [PATCH 7/9] arm: Auto-vectorization for MVE: add __fp16 support to VCMP

It would be good to also add tests for NEON as you also enable auto-vec for it. I checked and I do think the necessary 'neon_vc' patterns exist for 'VH', so we should be OK there. On 30/04/2021 15:09, Christophe Lyon via Gcc-patches wrote: This patch adds __fp16 support to the previous patch t

Re: [PATCH 9/9] arm: Auto-vectorization for MVE: vld4/vst4

Hi Christophe, The series LGTM but you'll need the approval of an arm port maintainer before committing. I only did code-review, did not try to build/run tests. Kind regards, Andre On 30/04/2021 15:09, Christophe Lyon via Gcc-patches wrote: This patch enables MVE vld4/vst4 instructions for a

Re: [PATCH 13/20] aarch64: Use RTL builtins for FP ml[as][q]_laneq intrinsics

Hi Richard, I think you may be referencing an older checkout as we refactored this pattern in a previous change to: (define_insn "mul_lane3" [(set (match_operand:VMUL 0 "register_operand" "=w") (mult:VMUL (vec_duplicate:VMUL (vec_select: (match_operand:VMUL 2 "register_oper

Re: RFC: Changing AC_PROG_CC to AC_PROG_CC_C99 in top level configure

Hi Guys, On 4/30/21 7:36 PM, Simon Marchi wrote: I think this fix is obvious enough, I encourage you to push it, OK - I have pushed the patch to the mainline branches of both the gcc and binutils-gfdb repositories. Cheers Nick

Re: [patch] Generate debug info for local dynamic record types

On Sat, May 1, 2021 at 9:04 PM Eric Botcazou wrote: > > Hi, > > in Ada you can embed VLAs in local record types and thus end up with dynamic > offsets in record types, which are currently not well described in DWARF > because 1) the temporaries generated for them by the gimplifier are naturally >

Re: [PATCH] Add gnu::diagnose_as attribute

On Tue, 2021-05-04 at 13:13 +0200, Matthias Kretz wrote: > From: Matthias Kretz > > This attribute overrides the diagnostics output string for the entity > it > appertains to. The motivation is to improve QoI for library TS > implementations, where diagnostics have a very bad signal-to-noise > ra

Re: [PATCH 6/9] arm: Auto-vectorization for MVE: vcmp

On Tue, 4 May 2021 at 13:29, Andre Vieira (lists) wrote: > > Hi Christophe, > > On 30/04/2021 15:09, Christophe Lyon via Gcc-patches wrote: > > Since MVE has a different set of vector comparison operators from > > Neon, we have to update the expansion to take into account the new > > ones, for ins

Re: [PATCH 7/9] arm: Auto-vectorization for MVE: add __fp16 support to VCMP

On Tue, 4 May 2021 at 13:48, Andre Vieira (lists) wrote: > > It would be good to also add tests for NEON as you also enable auto-vec > for it. I checked and I do think the necessary 'neon_vc' patterns exist > for 'VH', so we should be OK there. > Actually since I posted the patch series, I've not

Re: [PATCH] Remove CC0

On Tue, May 04, 2021 at 10:44:38AM +0200, Richard Biener wrote: > On Tue, May 4, 2021 at 1:40 AM Segher Boessenkool > wrote: > > > > This removes CC0 and all directly related infrastructure. > > > > CC_STATUS, CC_STATUS_MDEP, CC_STATUS_MDEP_INIT, and NOTICE_UPDATE_CC > > are deleted and poisoned.

[PATCH] tree-optimization/100414 - compute dominance info in phiopt

phiopt now has dominator queries but fails to compute dominance info. Bootstrapped and tested on x86_64-unknown-linux-gnu, pushed. 2021-05-04 Richard Biener PR tree-optimization/100414 * tree-ssa-phiopt.c (get_non_trapping): Do not compute dominance info here.

Re: [libstdc++] Inconsistent detection of __int128

On Tue, May 4, 2021 at 7:12 AM Jonathan Wakely wrote: > > On 30/04/21 16:24 -0400, David Edelsohn via Libstdc++ wrote: > >On Fri, Jan 8, 2021 at 11:10 AM Jonathan Wakely wrote: > >> > >> On 03/01/21 22:26 -0500, David Edelsohn via Libstdc++ wrote: > >> >On Sun, Jan 3, 2021 at 9:45 PM Jonathan Wak

[wwwdocs] Remove CC0 from backends.html

Pushed. What is next? :-) Segher --- htdocs/backends.html | 105 +-- 1 file changed, 52 insertions(+), 53 deletions(-) diff --git a/htdocs/backends.html b/htdocs/backends.html index 8d95e915709c..8034a5776360 100644 --- a/htdocs/backends.html

Re: [RFC v2] bpf.2: Use standard types and attributes

On Tue, May 4, 2021 at 4:05 AM Alejandro Colomar wrote: > > Some manual pages are already using C99 syntax for integral > types 'uint32_t', but some aren't. There are some using kernel > syntax '__u32'. Fix those. > > Some pages also document attributes, using GNU syntax > '__attribute__((xxx))'

Re: [PATCH] s390/testsuite: Fix oscbreak-1.c.

Hi, Yeah, that's because of the very limited analysis we do in the backend to detect such cases. In fact we probably would want to have an OSC break in many of them as well. For me the testcase appears to work with -O2 on all the -march levels. I think -O2 would be preferred because that's wh

Re: [PATCH] Add gnu::diagnose_as attribute

On Tuesday, 4 May 2021 15:34:13 CEST David Malcolm wrote: > On Tue, 2021-05-04 at 13:13 +0200, Matthias Kretz wrote: > > This attribute overrides the diagnostics output string for the entity > > it > > appertains to. The motivation is to improve QoI for library TS > > implementations, where diagnos

Re: [RFC v2] bpf.2: Use standard types and attributes

On Tue, May 04, 2021 at 07:12:01AM -0700, Alexei Starovoitov wrote: > On Tue, May 4, 2021 at 4:05 AM Alejandro Colomar > wrote: > > > > Some manual pages are already using C99 syntax for integral > > types 'uint32_t', but some aren't. There are some using kernel > > syntax '__u32'. Fix those. >

Re: [PATCH] Add gnu::diagnose_as attribute

On Tuesday, 4 May 2021 16:23:23 CEST Matthias Kretz wrote: > On Tuesday, 4 May 2021 15:34:13 CEST David Malcolm wrote: > > Does the patch interact correctly with the %H and %I codes that try to > > show the differences between two template types? > > I don't know. I'll try to find out. If you have

Re: Minor testsuite fix for cr16 and xstormy16 targets

On 5/4/2021 2:33 AM, Richard Biener wrote: On Mon, May 3, 2021 at 6:08 PM Jeff Law via Gcc-patches wrote: Richi's recent work twiddles dse1's actions for these targets. This patch just updates the expected output. I'll keep an eye on other targets as their results trickle in. Committed to

[PATCH] testsuite: Add s390 to gcc.dg/vect/slp-21.c

Hi, on s390 we vectorize 4 statements using SLP. Add s390*-*-* to the appropriate dg-finals. Is that OK? Regards Robin gcc/testsuite/ChangeLog: * gcc.dg/vect/slp-21.c: Add s390. >From 5f31f411ee36be8c8f3000cfc07b2609796142b7 Mon Sep 17 00:00:00 2001 From: Robin Dapp Date: Tue, 27 A

Re: [PATCH 9/9] arm: Auto-vectorization for MVE: vld4/vst4

On Tue, 4 May 2021 at 14:03, Andre Vieira (lists) wrote: > > Hi Christophe, > > The series LGTM but you'll need the approval of an arm port maintainer > before committing. I only did code-review, did not try to build/run tests. > Hi Andre, Thanks for the comments! > Kind regards, > Andre > > On

[committed] Trivial bfin-elf fix

Whee, no more cc0!  This fixes trivial fallout.  Installed on the trunk. Jeff commit b50ccaf6dd743c373af95e90935b9a2b72157f3a Author: Jeff Law Date: Tue May 4 08:56:28 2021 -0600 Make bfin-elf build again gcc/ * config/bfin/bfin.h (NOTICE_UPDATE_CC): Remove. diff

[PATCH] testsuite/s390: Fix risbg-ll-3.c f2_cconly test.

Hi, instead of selecting bits 62 to (wraparound) 59 from r2 and inserting them into r3, we select bits 60 to 62 from r3 and insert them into r2 nowadays. Adjust the test accordingly. Is this OK? Regards Robin gcc/testsuite/ChangeLog: * gcc.target/s390/risbg-ll-3.c: Change match p

Re: RFC: Changing AC_PROG_CC to AC_PROG_CC_C99 in top level configure

On 2021-05-04 8:42 a.m., Nick Clifton wrote: > Hi Guys, > > On 4/30/21 7:36 PM, Simon Marchi wrote: >> I think this fix is obvious enough, I encourage you to push it, > > OK - I have pushed the patch to the mainline branches of both > the gcc and binutils-gfdb repositories. > > Cheers >   Nic

Re: [RFC v2] bpf.2: Use standard types and attributes

Hi Greg and Alexei, On Tue, May 04, 2021 at 07:12:01AM -0700, Alexei Starovoitov wrote: For the same reasons as explained earlier: Nacked-by: Alexei Starovoitov Okay, I'll add that. On 5/4/21 4:24 PM, Greg KH wrote:> I agree, the two are not the same type at all, this change should not be

Re: [RFC v2] bpf.2: Use standard types and attributes

On Tue, May 04, 2021 at 05:53:29PM +0200, Alejandro Colomar (man-pages) wrote: > Hi Greg and Alexei, > > > On Tue, May 04, 2021 at 07:12:01AM -0700, Alexei Starovoitov wrote: > > > For the same reasons as explained earlier: > > > Nacked-by: Alexei Starovoitov > > Okay, I'll add that. > > > On

Re: [RFC v2] bpf.2: Use standard types and attributes

On 5/4/21 5:53 PM, Alejandro Colomar (man-pages) wrote: Hi Greg and Alexei, On Tue, May 04, 2021 at 07:12:01AM -0700, Alexei Starovoitov wrote: For the same reasons as explained earlier: Nacked-by: Alexei Starovoitov Okay, I'll add that. On 5/4/21 4:24 PM, Greg KH wrote:> I agree, the two

Re: [PATCH] Remove CC0

> A quick look through the code suggests it's being used for thumb1 code > gen to try to reproduce the traditional CC0 type behaviour of > eliminating redundant compare operations when you have sequences such as > > cmp a, b > b d1 > cmp a, b > b d2 > > The second compare operation can be elimina

Re: [PATCH] Remove CC0

On 04/05/2021 17:22, Eric Botcazou wrote: A quick look through the code suggests it's being used for thumb1 code gen to try to reproduce the traditional CC0 type behaviour of eliminating redundant compare operations when you have sequences such as cmp a, b b d1 cmp a, b b d2 The second compa

Re: [wwwdocs] Remove CC0 from backends.html

> Pushed. What is next? :-) You can finally remove powerpcspe. :-) -- Eric Botcazou

Re: [PATCH 13/20] aarch64: Use RTL builtins for FP ml[as][q]_laneq intrinsics

Jonathan Wright via Gcc-patches writes: > Hi Richard, > > I think you may be referencing an older checkout as we refactored this > pattern in a previous change to: > > (define_insn "mul_lane3" > [(set (match_operand:VMUL 0 "register_operand" "=w") >(mult:VMUL >(vec_duplicate:VMUL >

Re: [PATCH 7/9] arm: Auto-vectorization for MVE: add __fp16 support to VCMP

On Tue, 4 May 2021 at 15:43, Christophe Lyon wrote: > > On Tue, 4 May 2021 at 13:48, Andre Vieira (lists) > wrote: > > > > It would be good to also add tests for NEON as you also enable auto-vec > > for it. I checked and I do think the necessary 'neon_vc' patterns exist > > for 'VH', so we should

Re: [RFC] ldist: Recognize rawmemchr loop patterns

ping On Thu, Apr 08, 2021 at 10:23:31AM +0200, Stefan Schulze Frielinghaus wrote: > ping > > On Tue, Mar 16, 2021 at 06:13:21PM +0100, Stefan Schulze Frielinghaus wrote: > > [snip] > > > > Please find attached a new version of the patch. A major change compared to > > the previous patch is that

[PATCH] AIX Encode function section and rs6000 MI Thunk

AIX XCOFF symbols can be labels or qualnames (names with an appended mapping class). CSECTs must be declared with a mapping class. Within an assembler file, the symbol names with and without the mapping class are unique. An object file symbol table only presents the symbol nam

*PING* [PATCH] PR fortran/100274 - [9/10/11/12 Regression] ICE in gfc_conv_procedure_call, at fortran/trans-expr.c:6131

PING! --- Dear Fortranners, Gerhard found a case where the mismatch of actual and formal argument lead to an ICE instead of the relevant warning. Furthermore, the special case of character argument avoided the check that the actual argument must be definable if the formal one is INTENT-OUT or -

Re: [RFC v2] bpf.2: Use standard types and attributes

On Tue, May 4, 2021 at 12:06 PM Greg KH wrote: > On Tue, May 04, 2021 at 05:53:29PM +0200, Alejandro Colomar (man-pages) wrote: > > On 5/4/21 4:24 PM, Greg KH wrote: > > > I agree, the two are not the same type at all, this change should not be > > > accepted. > > > > I get that in the kernel you

Re: [RFC v2] bpf.2: Use standard types and attributes

Hi Greg, Daniel, On 5/4/21 6:06 PM, Greg KH wrote: > There's a very old post from Linus where he describes the difference > between things like __u32 and uint32_t. They are not the same, they > live in different namespaces, and worlds, and can not always be swapped > out for each other on all ar

Re: [PATCH] Add gnu::diagnose_as attribute

On Tue, 2021-05-04 at 16:23 +0200, Matthias Kretz wrote: > On Tuesday, 4 May 2021 15:34:13 CEST David Malcolm wrote: > > On Tue, 2021-05-04 at 13:13 +0200, Matthias Kretz wrote: > > > This attribute overrides the diagnostics output string for the > > > entity > > > it > > > appertains to. The motiv

Re: [PATCH] Add gnu::diagnose_as attribute

> On Tuesday, 4 May 2021 15:34:13 CEST David Malcolm wrote: > > Does the patch interact correctly with the %H and %I codes that try to > > show the differences between two template types? While looking into this, I noticed that given namespace std { struct A {}; typedef A B; } const std::B w

Re: [RFC v2] bpf.2: Use standard types and attributes

* Alejandro Colomar: > The thing is, in all of those threads, the only reasons to avoid > types in the kernel (at least, the only explicitly > mentioned ones) are (a bit simplified, but this is the general idea of > those threads): > > * Possibly breaking something in such a big automated change.

Re: ctype support for libstdc++ on VxWorks

On 04/05/21 4:52 am, Alexandre Oliva wrote: This patch adds ctype and locale support to libstdc++ on vxworks7. We've been using this for a while internally. It was tested with various vx7r2 targets. Ok to install? From: Corentin Gay + +// Copyright (C) 2001-2021 Free Software Foundation, In

Re: [RFC v2] bpf.2: Use standard types and attributes

Hi Florian, On 5/4/21 9:45 PM, Florian Weimer wrote: * Alejandro Colomar: The thing is, in all of those threads, the only reasons to avoid types in the kernel (at least, the only explicitly mentioned ones) are (a bit simplified, but this is the general idea of those threads): * Possibly brea

Re: [RFC v2] bpf.2: Use standard types and attributes

On 5/4/21 8:54 PM, Alejandro Colomar (man-pages) wrote: On 5/4/21 6:06 PM, Greg KH wrote: > There's a very old post from Linus where he describes the difference > between things like __u32 and uint32_t.  They are not the same, they > live in different namespaces, and worlds, and can not always

Re: [RFC v2] bpf.2: Use standard types and attributes

Hi Daniel, On 5/4/21 10:06 PM, Daniel Borkmann wrote: On 5/4/21 6:08 PM, Daniel Borkmann wrote:  >  > But what /problem/ is this really solving? Why bother to change this /now/  > after so many years?! I think this is causing more confusion than solving  > anything, really. Moreover, what ar

Re: [RFC v2] bpf.2: Use standard types and attributes

On Tue, May 4, 2021 at 4:06 PM Daniel Borkmann wrote: > > I'm trying to clarify the manual pages as much as possible, by using > > standard conventions and similar structure all around the pages. Not > > everyone understands kernel conventions. Basically, Zack said very much > > what I had in

testsuite: gcc.c-torture/execute/ieee/cdivchkld.c needs fmaxl

The new test gcc.c-torture/execute/ieee/cdivchkld.c needs fmaxl(), which may not be available, for instance on aarch64-elf with newlib. As discussed in the PR, requiring c99_runtime enables to skip the test in this case. 2021-05-04 Christophe Lyon PR testsuite/100355 gcc/testsu

Re: [RFC v2] bpf.2: Use standard types and attributes

On Tue, May 4, 2021 at 1:33 PM Zack Weinberg wrote: > the information that should > appear in the manpages is the information that is most relevant to > user space programmers. The bpf programs are compiled for the kernel and run in the kernel. Hence bpf man pages must reflect the kernel. Also th

Re: [PATCH v2 19/21] libcc1: use variadic templates for callbacks

Jeff> OK Jeff> I think that's the whole set.  If not, let me know. It is. Thank you for the reviews. I am checking it in now. Tom

[PATCH] run early sprintf warning after SSA (PR 100325)

With no optimization, -Wformat-overflow and -Wformat-truncation runs early to detect a subset of simple bugs. But as it turns out, the pass runs just a tad too early, before SSA. That causes it to miss a class of problems that can easily be detected once code is in SSA form, and I would expect m

Re: ctype support for libstdc++ on VxWorks

On 04/05/21 21:53 +0200, François Dumont via Libstdc++ wrote: On 04/05/21 4:52 am, Alexandre Oliva wrote: This patch adds ctype and locale support to libstdc++ on vxworks7. We've been using this for a while internally. It was tested with various vx7r2 targets. Ok to install? From: Corentin G

[committed 1/4] libstdc++ Fix undefined behaviour in testsuite

Fix some test bugs found by ubsan. libstdc++-v3/ChangeLog: * testsuite/20_util/from_chars/3.cc: Use unsigned type to avoid overflow. * testsuite/24_iterators/reverse_iterator/2.cc: Do not add non-zero value to null pointer. * testsuite/25_algorithms/copy_ba

[committed 2/4] libstdc++: Fix null dereference in pb_ds containers

This fixes ubsan errors: ext/pb_ds/detail/cc_hash_table_map_/cc_ht_map_.hpp:533:15: runtime error: member access within null pointer of type 'struct entry' libstdc++-v3/ChangeLog: * include/ext/pb_ds/detail/cc_hash_table_map_/cc_ht_map_.hpp (find_key_pointer(key_const_reference

[committed 3/4] libstdc++: Fix undefined behaviour in std::string

This fixes a ubsan error when constructing a string with a null pointer: bits/basic_string.h:534:21: runtime error: applying non-zero offset 18446744073709551615 to null pointer The _M_construct function only cares whether the second pointer is non-null, so create a non-null value without undef

[committed 4/4] libstdc++: Fix null dereferences in std::promise

This fixes some ubsan errors in std::promise: future:1153:34: runtime error: member call on null pointer of type 'struct element_type' future:1153:34: runtime error: member access within null pointer of type 'struct element_type' The problem is that the check for a null pointer is done inside

Re: RFC: Changing AC_PROG_CC to AC_PROG_CC_C99 in top level configure

On 2021-05-04 8:42 a.m., Nick Clifton wrote: > Hi Guys, > > On 4/30/21 7:36 PM, Simon Marchi wrote: >> I think this fix is obvious enough, I encourage you to push it, > > OK - I have pushed the patch to the mainline branches of both > the gcc and binutils-gdb repositories. Thanks Nick! Incident

Re: ctype support for libstdc++ on VxWorks

On May 4, 2021, Jonathan Wakely wrote: > s/explicitely/explicitly/ Thanks. I also adjusted the attribution in that file. Here's what I'm checking in. ctype support for libstdc++ on VxWorks From: Corentin Gay for libstdc++-v3/ChangeLog * acinclude.m4: Add VxWorks-specific case f

  1   2   >