Re: libstdc++ PR 57272 Fancy pointer support in Hashtable

2021-01-11 Thread François Dumont via Gcc-patches
Hi     I had another look to this attempt to properly support alloc fancy pointers.     I consider all your remarks appart from the big one below about all this being a waste of time :-)     I do not see why we should use the alloc fancy pointer type in our _Hashtable implementation detail

Re: [PATCH] tree-optimization/98221 - fix wrong unpack operation used for big-endian

2021-01-11 Thread Jeff Law via Gcc-patches
On 1/11/21 3:02 AM, Andreas Krebbel via Gcc-patches wrote: > The vec-abi-varargs-1.c testcase on IBM Z currently fails. > > While adding an SI mode vector to a DI mode vector the first is unpacked > using: > > _28 = BIT_INSERT_EXPR <{ 0, 0, 0, 0 }, _2, 0>; > _34 = [vec_unpack_lo_expr] _28;

Re: [PATCH] VAX/testsuite: Remove notsi comparison elimination regressions

2021-01-11 Thread Jeff Law via Gcc-patches
On 1/10/21 7:45 AM, Maciej W. Rozycki wrote: > On Fri, 8 Jan 2021, Jeff Law wrote: > >>> gcc/testsuite/ >>> * gcc.target/vax/cmpelim-eq-notsi.c: Use subtraction from a >>> constant then rather than addition. >>> * gcc.target/vax/cmpelim-le-notsi.c: Likewise. >>> * gcc.target

Re: [PATCH] match.pd: Add ~(X - Y) -> ~X + Y simplification [PR96685]

2021-01-11 Thread Jeff Law via Gcc-patches
On 1/9/21 5:43 PM, Maciej W. Rozycki wrote: > On Mon, 21 Dec 2020, Jakub Jelinek wrote: > This patch adds the ~(X - Y) -> ~X + Y simplification requested in the PR (plus also ~(X + C) -> ~X + (-C) for constants C that can be safely negated. >>> This regresses VAX code produced by

[PATCH] binuitils: Check if AR is usable for LTO build

2021-01-11 Thread H.J. Lu via Gcc-patches
Check if AR is usable for LTO build with --enable-pgo-build=lto: checking for -plugin option... ar: no operation specified Failed: ar --plugin /usr/gcc-11.0.0-x32/libexec/gcc/x86_64-pc-linux-gnu/11.0.0/liblto_plugin.so rc no configure: error: AR with --plugin and rc is required for LTO build ins

Re: [PATCH] c++: private inheritance access diagnostics fix [PR17314]

2021-01-11 Thread Jason Merrill via Gcc-patches
On 1/8/21 7:38 PM, Anthony Sharp wrote: Hi Jason, Thank you! To start with, do you have a copyright assignment on file or in the works already? Good point. I incorrectly assumed it would only be a minor contribution copyright-wise. > Mr Edelsohn gave me a template which I've now filled out a

Re: [PATCH] c++: Fix ICE with CTAD in concept [PR98611]

2021-01-11 Thread Jason Merrill via Gcc-patches
On 1/9/21 5:23 PM, Patrick Palka wrote: This patch teaches find_template_parameters to visit the template represented by a CTAD placeholder, which is normally not visited by for_each_template_parm. This template may be a template template parameter (as in the first testcase), or it may implicitl

Re: [PATCH v4] rs6000, vector integer multiply/divide/modulo instructions

2021-01-11 Thread will schmidt via Gcc-patches
On Mon, 2020-12-07 at 16:31 -0800, Carl Love wrote: > Will: > > I have addressed you comments with regards to the Change Log entries. > > The extra define vec_div was removed. > > Added the missing entries for DIVU_V2DI DIVS_V2DI in rs6000-call.c. > > The extra MULLD_V2DI case statement entr

Re: [PATCH] binuitils: Check if AR is usable for LTO build

2021-01-11 Thread Alan Modra via Gcc-patches
On Mon, Jan 11, 2021 at 11:53:15AM -0800, H.J. Lu via Binutils wrote: > Check if AR is usable for LTO build with --enable-pgo-build=lto: > > checking for -plugin option... ar: no operation specified > Failed: ar --plugin > /usr/gcc-11.0.0-x32/libexec/gcc/x86_64-pc-linux-gnu/11.0.0/liblto_plugin.s

Re: [PATCH] c++: ICE with constrained placeholder return type [PR98346]

2021-01-11 Thread Jason Merrill via Gcc-patches
On 1/7/21 4:06 PM, Patrick Palka wrote: This is essentially a followup to r11-3714 -- we ICEing from another "unguarded" call to build_concept_check, this time in do_auto_deduction, due to the presence of templated trees when !processing_template_decl. Bootstrapped and regtested on x86_64-pc-lin

Re: [PATCH 0/8] [RS6000] rs6000_rtx_costs V2

2021-01-11 Thread Alan Modra via Gcc-patches
On Sat, Dec 05, 2020 at 07:42:07PM +1030, Alan Modra wrote: > Hi Segher, > I've been holding off pinging these knowing you had a lot of other > review work, but maybe that's settling down now? You already OK'd > 1/8, 2/8 and 6/8. Ping. > [PATCH 3/8] [RS6000] rs6000_rtx_costs tidy AND > https://g

[PATCH] Handle fancy_abort before diagnostic initialization [PR98586]

2021-01-11 Thread David Malcolm via Gcc-patches
If fancy_abort is called before the diagnostic subsystem is initialized, internal_error will crash internally in a way that prevents a useful message reaching the user. This can happen with libgccjit in the case of gcc_assert failures that occur outside of the libgccjit mutex that guards the rest

Re: [PATCH] c++: ICE with constrained placeholder return type [PR98346]

2021-01-11 Thread Jason Merrill via Gcc-patches
On 1/11/21 4:40 PM, Jason Merrill wrote: On 1/7/21 4:06 PM, Patrick Palka wrote: This is essentially a followup to r11-3714 -- we ICEing from another "unguarded" call to build_concept_check, this time in do_auto_deduction, due to the presence of templated trees when !processing_template_decl. B

Re: [PATCH] libstdc++: implement locale support for AIX

2021-01-11 Thread David Edelsohn via Gcc-patches
On Mon, Jan 11, 2021 at 10:56 AM CHIGOT, CLEMENT wrote: > > >> Hi David, Clement, > >> > >>> The patch is local to libstdc++ AIX support, so I believe that I can > >>> approve it. > >> > >>have you considered merging the dragonfly and aix trees? I'm asking > >>because it seems prudent to try and

[wwwdocs] Update C++ DR table with new DRs

2021-01-11 Thread Marek Polacek via Gcc-patches
I pushed this patch to update the DR table with a few new DRs. Also update some of the older ones to reflect that they're included in C++20. Marek commit 6be6626d59e1c492d5e05606e5a6902feb9e5bac Author: Marek Polacek Date: Mon Jan 11 17:18:45 2021 -0500 C++ DRs: Add new DRs, update older

Re: [PATCH] binuitils: Check if AR is usable for LTO build

2021-01-11 Thread H.J. Lu via Gcc-patches
On Mon, Jan 11, 2021 at 1:20 PM Alan Modra wrote: > > On Mon, Jan 11, 2021 at 11:53:15AM -0800, H.J. Lu via Binutils wrote: > > Check if AR is usable for LTO build with --enable-pgo-build=lto: > > > > checking for -plugin option... ar: no operation specified > > Failed: ar --plugin > > /usr/gcc-1

Re: [PATCH 0/2] Check if AR works with --plugin and rc

2021-01-11 Thread Alan Modra via Gcc-patches
On Mon, Jan 11, 2021 at 08:57:04AM -0800, H.J. Lu via Binutils wrote: > Check if AR works with --plugin and rc before passing --plugin to AR and > RANLIB. Thanks for looking at this, but next time please assign the bug to yourself. I fixed the bug too this morning, before seeing your email. --

Re: [PATCH v4 02/29] Refactor 'clz' functions into a new file.

2021-01-11 Thread Richard Earnshaw via Gcc-patches
On 11/01/2021 15:58, Daniel Engel wrote: > > On Mon, Jan 11, 2021, at 7:39 AM, Richard Earnshaw wrote: >> On 11/01/2021 15:26, Richard Earnshaw wrote: >>> On 11/01/2021 11:10, g...@danielengel.com wrote: From: Daniel Engel gcc/libgcc/ChangeLog: 2021-01-07 Daniel Engel >>

Re: [PATCH 0/2] Check if AR works with --plugin and rc

2021-01-11 Thread H.J. Lu via Gcc-patches
On Mon, Jan 11, 2021 at 3:05 PM Alan Modra wrote: > > On Mon, Jan 11, 2021 at 08:57:04AM -0800, H.J. Lu via Binutils wrote: > > Check if AR works with --plugin and rc before passing --plugin to AR and > > RANLIB. > > Thanks for looking at this, but next time please assign the bug to > yourself. I

Re: [PATCH v4 01/29] Add and organize macros.

2021-01-11 Thread Daniel Engel
On Mon, Jan 11, 2021, at 7:21 AM, Richard Earnshaw wrote: > Some initial comments. > > On 11/01/2021 11:10, g...@danielengel.com wrote: > > From: Daniel Engel > > > > These definitions facilitate subsequent patches in this series. > > > > gcc/libgcc/ChangeLog: > > 2021-01-07 Daniel Engel > >

[PATCH] c++: -Wmissing-field-initializers in unevaluated ctx [PR98620]

2021-01-11 Thread Marek Polacek via Gcc-patches
This PR wants us not to warn about missing field initializers when the code in question takes places in decltype and similar. Fixed thus. Bootstrapped/regtested on x86_64-pc-linux-gnu, ok for trunk? gcc/cp/ChangeLog: PR c++/98620 * typeck2.c (process_init_constructor_record): Do

Re: [PATCH 1/2] GCC: Check if AR works with --plugin and rc

2021-01-11 Thread Alan Modra via Gcc-patches
On Mon, Jan 11, 2021 at 08:57:05AM -0800, H.J. Lu via Binutils wrote: > diff --git a/config/gcc-plugin.m4 b/config/gcc-plugin.m4 > index c5b72e9a13d..798a2054edd 100644 > --- a/config/gcc-plugin.m4 > +++ b/config/gcc-plugin.m4 > @@ -145,6 +145,18 @@ for plugin in $plugin_names; do > break >

V2 [PATCH 1/2] GCC: Check if AR works with --plugin and rc

2021-01-11 Thread H.J. Lu via Gcc-patches
On Mon, Jan 11, 2021 at 3:27 PM Alan Modra wrote: > > On Mon, Jan 11, 2021 at 08:57:05AM -0800, H.J. Lu via Binutils wrote: > > diff --git a/config/gcc-plugin.m4 b/config/gcc-plugin.m4 > > index c5b72e9a13d..798a2054edd 100644 > > --- a/config/gcc-plugin.m4 > > +++ b/config/gcc-plugin.m4 > > @@ -1

Re: V2 [PATCH 1/2] GCC: Check if AR works with --plugin and rc

2021-01-11 Thread Alan Modra via Gcc-patches
On Mon, Jan 11, 2021 at 04:07:22PM -0800, H.J. Lu wrote: > These are not fatal errors. Here is the updated patch to use > AC_MSG_WARN instead. OK for master? OK by me. Please squash the two patches. -- Alan Modra Australia Development Lab, IBM

Re: V2 [PATCH 1/2] GCC: Check if AR works with --plugin and rc

2021-01-11 Thread H.J. Lu via Gcc-patches
On Mon, Jan 11, 2021 at 4:22 PM Alan Modra wrote: > > On Mon, Jan 11, 2021 at 04:07:22PM -0800, H.J. Lu wrote: > > These are not fatal errors. Here is the updated patch to use > > AC_MSG_WARN instead. OK for master? > > OK by me. Please squash the two patches. > I will keep 2 separate since I

Re: [PATCH] binuitils: Check if AR is usable for LTO build

2021-01-11 Thread Alan Modra via Gcc-patches
On Mon, Jan 11, 2021 at 02:52:43PM -0800, H.J. Lu wrote: > On Mon, Jan 11, 2021 at 1:20 PM Alan Modra wrote: > > > > On Mon, Jan 11, 2021 at 11:53:15AM -0800, H.J. Lu via Binutils wrote: > > > Check if AR is usable for LTO build with --enable-pgo-build=lto: > > > > > > checking for -plugin option.

Re: [PATCH] c++: Fix ICE with CTAD in concept [PR98611]

2021-01-11 Thread Patrick Palka via Gcc-patches
On Mon, 11 Jan 2021, Jason Merrill wrote: > On 1/9/21 5:23 PM, Patrick Palka wrote: > > This patch teaches find_template_parameters to visit the template > > represented by a CTAD placeholder, which is normally not visited by > > for_each_template_parm. This template may be a template template >

[committed] analyzer: fix ICE merging dereferencing unknown ptrs [PR98628]

2021-01-11 Thread David Malcolm via Gcc-patches
Successfully bootstrapped & regrtested on x86_64-pc-linux-gnu. Pushed to master as r11-6603-gab88f3607233376c3145c320e92e71943a495bb5 gcc/analyzer/ChangeLog: PR analyzer/98628 * store.cc (binding_cluster::make_unknown_relative_to): Don't mark dereferenced unknown pointers a

Re: [PATCH] c++: Fix ICE with CTAD in concept [PR98611]

2021-01-11 Thread Jason Merrill via Gcc-patches
On 1/11/21 8:08 PM, Patrick Palka wrote: On Mon, 11 Jan 2021, Jason Merrill wrote: On 1/9/21 5:23 PM, Patrick Palka wrote: This patch teaches find_template_parameters to visit the template represented by a CTAD placeholder, which is normally not visited by for_each_template_parm. This templat

Re: [PATCH] c++: -Wmissing-field-initializers in unevaluated ctx [PR98620]

2021-01-11 Thread Jason Merrill via Gcc-patches
On 1/11/21 6:19 PM, Marek Polacek wrote: This PR wants us not to warn about missing field initializers when the code in question takes places in decltype and similar. Hmm, the warning seems of questionable utility with templated code like this, but I guess this is a reasonable middle ground.

Re: [PATCH v4 05/29] Import replacement 'clz' functions from CM0 library

2021-01-11 Thread Daniel Engel
On Mon, Jan 11, 2021, at 8:32 AM, Richard Earnshaw wrote: > A general comment before we start: > > CLZ was added to the Arm ISA in Armv5. So all subsequent Arm versions > (and all versions implementing thumb2) will have this instruction. So > the only cases where you'll need a fallback are armv6

[COMMITED] MAINTAINERS: Add myself for write after approval

2021-01-11 Thread Qian Jianhua
ChangeLog: 2021-01-12 Qian Jianhua * MAINTAINERS (Write After Approval): Add myself --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index c0aa23df57e..e88808f9fe2 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -451,6 +451,7 @@ Daniel Jacobo

Re: [PATCH] Handle fancy_abort before diagnostic initialization [PR98586]

2021-01-11 Thread Richard Biener via Gcc-patches
On Mon, Jan 11, 2021 at 10:57 PM David Malcolm via Gcc-patches wrote: > > If fancy_abort is called before the diagnostic subsystem is initialized, > internal_error will crash internally in a way that prevents a useful > message reaching the user. > > This can happen with libgccjit in the case of g

<    1   2