Re: [PATCH] genemit: Handle `const_double_zero' rtx

2020-12-16 Thread Maciej W. Rozycki
On Wed, 16 Dec 2020, Paul Koning wrote: > > NB the PDP-11 pieces affected here and tripping this assertion are I > > believe dead code, as these insns are only ever produced by splitters and > > do not appear to be referred by their names. > > Right; I gave them names for documentation purpos

[PATCH][AArch32] MVE: Split refactoring of remaining complex instrinsics

2020-12-16 Thread Tamar Christina via Gcc-patches
Hi All, This refactors the complex numbers bits of MVE to go through the same unspecs as the NEON variant. This is pre-work to allow code to be shared between NEON and MVE for the complex vectorization patches. Bootstrapped Regtested on arm-none-linux-gnueabihf and no issues. Codegen tested for

Re: [RFC] [avr] Toolchain Integration for Testsuite Execution (avr cc0 to mode_cc0 conversion)

2020-12-16 Thread abebeos via Gcc-patches
+cc: Law, Biener, On Wed, 16 Dec 2020 at 20:27, Dimitar Dimitrov wrote: > On понеделник, 14 декември 2020 г. 20:53:36 EET Dimitar Dimitrov wrote: > > On петък, 11 декември 2020 г. 19:00:35 EET abebeos wrote: > > > After "digesting" a bit more your review, I need to thank you for > opening > > > m

Re: [RFC] [avr] Toolchain Integration for Testsuite Execution (avr cc0 to mode_cc0 conversion)

2020-12-16 Thread abebeos via Gcc-patches
On Wed, 16 Dec 2020 at 22:44, abebeos wrote: [...] > And look at this: > > * 200h (estimation) for the patch > Not my work, other author(s).

[PATCH] PR fortran/98307 - Dependency check fails when using "allocatable"

2020-12-16 Thread Harald Anlauf via Gcc-patches
Dear all, since the introduction of check_forall_dependencies() we mishandled the dependencies of ALLOCATABLE components of derived types, while POINTER was dealt with. Fix that. Regtested on x86_64-pc-linux-gnu. OK for master? Since we generate wrong code under the given circumstances, what d

[COMMITTED] gcc: xtensa: rearrange DI mode constant loading

2020-12-16 Thread Max Filippov via Gcc-patches
From: Takayuki 'January June' Suwa 2020-12-16 Takayuki 'January June' Suwa gcc/ * config/xtensa/xtensa.c (xtensa_emit_move_sequence): Try to replace 'l32r' with 'movi' + 'slli' when optimizing for size. * config/xtensa/xtensa.md (movdi): Split loading DI mode constant

Re: [PATCH v5] Practical Improvement to libgcc Complex Divide

2020-12-16 Thread Joseph Myers
On Thu, 10 Dec 2020, Patrick McGehearty via Gcc-patches wrote: > Thank you for your rapid feedback. > I'll fix the various formatting issues (spaces in the wrong places > and such as well as revise the Changelog magic) in the next submission. I'll await a patch with the formatting issues fixed to

Re: [C PATCH] Drop qualifiers of assignment expressions [PR 97981]

2020-12-16 Thread Joseph Myers
On Sun, 13 Dec 2020, Uecker, Martin wrote: > Here is a patch to drop qualifiers in assignment expressions. > > -- Martin > > > > C: Drop qualifiers of assignment expressions. [PR98047] > > ISO C17 6.5.15.1 specifies that the result is the > type the LHS would have after lvalue conversion. OK

Re: C++ 20 modules

2020-12-16 Thread Nathan Sidwell
Several issues have been fixed today: * Solaris headers 98315 (hopefully finally) * install-strip 98328 * clang offsetof 98323 (I typoed the PR in the commit) * libcody enable-checking 98311 (thanks Jakub for the followup) * source_location etc fix from Jonathan * More dashisms * detailed-mem-sta

Re: [PATCH] d: Fix ICE in in force_decl_die, at dwarf2out.c with -gdwarf-2 -gstrict-dwarf [PR98067]

2020-12-16 Thread Jason Merrill via Gcc-patches
On 12/15/20 7:15 PM, Iain Buclaw wrote: Hi, This patch fixes an ICE in dwarf2out.c that occurs when compiling a selective import declaration in D with strict dwarf2 in effect. Manifest constants in D are represented as CONST_DECLs, which can be imported from one module to another. However, whe

Re: [PATCH 4/1] c++: More precise tracking of potentially unstable satisfaction

2020-12-16 Thread Jason Merrill via Gcc-patches
On 12/14/20 3:29 PM, Patrick Palka wrote: On Mon, 14 Dec 2020, Jason Merrill wrote: On 12/14/20 1:07 PM, Patrick Palka wrote: This makes tracking of potentially unstable satisfaction results more precise by recording the specific types for which completion failed during satisfaction. We now r

Re: [C PATCH] Avoid incorrect warning for volatile in compound expressions [PR 98260]

2020-12-16 Thread Joseph Myers
On Sun, 13 Dec 2020, Uecker, Martin wrote: > Here is a patch that fixes an incorrect warning for volatile > that appeared with the lvalue change.  > > > -- Martin > > C: Avoid incorrect warning for volatile in compound expressions [PR98260] OK. -- Joseph S. Myers jos...@codesourcery.com

Re: [PATCH] add g_nonstandard_bool attribute for GIMPLE FE use

2020-12-16 Thread Joseph Myers
On Sun, 13 Dec 2020, Martin Sebor via Gcc-patches wrote: > "nonstandard" isn't a very descriptive name. The leading g_ prefix > also looks a little too terse (is that supposed to stand dor GIMPLE?). > I would suggest choosing a better name, say, bool_precision. Since Indeed, g_ suggests the GLi

[Patch] Fortran: Delay vtab generation until after parsing [PR92587]

2020-12-16 Thread Tobias Burnus
Calling gfc_find_vtab during resolution during parsing comes too early for finalizers. This patch just moves it to the resolution, which seems to be the simplest solution. (I tried way more complicated ones which do not work; thus, I settled for the simple solution ...) OK for GCC 9/10/mainline?

Re: rs6000: add support for powerpc64le-unknown-freebsd

2020-12-16 Thread Segher Boessenkool
On Tue, Dec 15, 2020 at 12:52:05AM +0100, Piotr Kubaj wrote: > Yes, there is, thanks for noticing that! > > Fixed patch attached. Hi! Could you send this as plain text? It now is quoted-printable, which is really hard to handle. Thanks! Hrm, this is really short, I'll just try to fix it by ha

Re: [PATCH] maintainer-scripts: Prefer temp dir /sourceware/snapshot-tmp/gcc for update_version_git

2020-12-16 Thread Joseph Myers
On Tue, 15 Dec 2020, Jakub Jelinek via Gcc-patches wrote: > On Mon, Dec 14, 2020 at 11:58:05PM +, Joseph Myers wrote: > > > Thanks for heads up. I'm aware of it and I don't see reason why (running > > > the > > > update script in dry mode works). > > > > https://gcc.gnu.org/pipermail/gccadmi

Go testsuite patch committed: Add some new tests

2020-12-16 Thread Ian Lance Taylor via Gcc-patches
This patch adds some new tests from the fixedbugs subdirectory of the source repo that currently pass with gccgo. Bootstrapped and ran Go testsuite on x86_64-pc-linux-gnu. Committed to mainline. Ian e38c912700f001ea1c8a32533bedb4c802e38d3f diff --git a/gcc/testsuite/go.test/test/fixedbugs/bug133

Re: rs6000: add support for powerpc64le-unknown-freebsd

2020-12-16 Thread Segher Boessenkool
On Tue, Dec 15, 2020 at 12:29:45AM +0100, Gerald Pfeifer wrote: > > The patch looks fine. Okay for trunk. Also okay for any backports you > > want (after waiting to see if it creates problems on trunk, as usual). > > Thank you! Segher doesn't have write access, and usually I'd help out, > alas

[PATCH] c++tools: Fix up c++tools for --with-gcc-major-version-only

2020-12-16 Thread Jakub Jelinek via Gcc-patches
Hi! Seems c++tools doesn't honor --with-gcc-major-version-only. Our distro uses that flag and so everything is installed in /usr/lib/gcc//11/... /usr/libexec/gcc//11/... except /usr/libexec/gcc//11.0.0/g++-mapper-server The following patch should fix that, ok for trunk if it passes testing? 2020

Re: [PATCH 4/1] c++: More precise tracking of potentially unstable satisfaction

2020-12-16 Thread Patrick Palka via Gcc-patches
On Wed, 16 Dec 2020, Jason Merrill wrote: > On 12/14/20 3:29 PM, Patrick Palka wrote: > > On Mon, 14 Dec 2020, Jason Merrill wrote: > > > > > On 12/14/20 1:07 PM, Patrick Palka wrote: > > > > This makes tracking of potentially unstable satisfaction results more > > > > precise by recording the sp

Re: [PATCH v2] Add --ld-path= to specify an arbitrary executable as the linker

2020-12-16 Thread Fāng-ruì Sòng via Gcc-patches
On Fri, Dec 4, 2020 at 5:45 AM Martin Liška wrote: > > PING > > May I please ping the patch, it's waiting here for a review > for quite some time. > > Thanks, > Martin Ping. I think Martin LGTMed this patch and was waiting for a maintainer to merge it > On 7/23/20 12:17 PM, Martin Liška wrote: >

Re: [07/23] Add a class that multiplexes two pointer types

2020-12-16 Thread Richard Sandiford via Gcc-patches
Martin Sebor writes: > On 11/26/20 10:06 AM, Richard Sandiford wrote: >> Martin Sebor writes: >>> I do have one concern: the tendency to prioritize efficiency >>> over safety (this can be said about most GCC code). Specifically >>> in this class, the address bit twiddling makes me uneasy. I don'

Re: [16/23] recog: Add a way of temporarily undoing changes

2020-12-16 Thread Richard Sandiford via Gcc-patches
Jeff Law via Gcc-patches writes: > On 11/13/20 1:19 AM, Richard Sandiford via Gcc-patches wrote: >> In some cases, it can be convenient to roll back the changes that >> have been made by validate_change to see how things looked before, >> then reroll the changes. For example, this makes it possib

Re: [08/23] Add an alternative splay tree implementation

2020-12-16 Thread Richard Sandiford via Gcc-patches
Jeff Law writes: > On 11/13/20 1:15 AM, Richard Sandiford via Gcc-patches wrote: >> We already have two splay tree implementations: the old C one in >> libiberty and a templated reimplementation of it in typed-splay-tree.h. >> However, they have some drawbacks: >> >> - They hard-code the assumptio

Re: [PATCH 22/23] Add rtl-ssa

2020-12-16 Thread Richard Sandiford via Gcc-patches
Jeff Law via Gcc-patches writes: > On 11/13/20 1:23 AM, Richard Sandiford via Gcc-patches wrote: >> This patch adds the RTL SSA infrastructure itself. The following >> fwprop.c patch will make use of it. >> >> gcc/ >> * configure.ac: Add rtl-ssa to the list of dependence directories. >>

Re: [PATCH 23/23] fwprop: Rewrite to use RTL SSA

2020-12-16 Thread Richard Sandiford via Gcc-patches
Jeff Law via Gcc-patches writes: > On 11/13/20 1:24 AM, Richard Sandiford via Gcc-patches wrote: >> This patch rewrites fwprop.c to use the RTL SSA framework. It tries >> as far as possible to mimic the old behaviour, even in caes where >> that doesn't fit naturally with the new framework. I've

Re: [20/23] rtlanal: Add simple_regno_set

2020-12-16 Thread Richard Sandiford via Gcc-patches
Jeff Law writes: > On 11/13/20 1:21 AM, Richard Sandiford via Gcc-patches wrote: >> This patch adds a routine for finding a “simple” SET for a register >> definition. See the comment in the patch for details. >> >> gcc/ >> * rtl.h (simple_regno_set): Declare. >> * rtlanal.c (simple_regn

[COMMITTED] gcc: xtensa: add optimizations for shift operations

2020-12-16 Thread Max Filippov via Gcc-patches
From: Takayuki 'January June' Suwa 2020-12-16 Takayuki 'January June' Suwa gcc/ * config/xtensa/xtensa.md (*ashlsi3_1, *ashlsi3_3x, *ashrsi3_3x) (*lshrsi3_3x): New patterns. gcc/testsuite/ * gcc.target/xtensa/shifts.c: New test. --- gcc/config/xtensa/xtensa.md

Re: [x86] recompute opt flags after opt level change

2020-12-16 Thread Alexandre Oliva
Hello, Martin, On Dec 16, 2020, Martin Liška wrote: > On 10/1/19 10:58 AM, Alexandre Oliva wrote: >> + if (opts->x_flag_asynchronous_unwind_tables == 2) >> +opts->x_flag_unwind_tables >> + = opts->x_flag_asynchronous_unwind_tables = 1; > Anyway the code seems fishy, shouldn't it b

[PATCH] correct -Wmismatched-new-delete for template instantiations (PR 98305)

2020-12-16 Thread Martin Sebor via Gcc-patches
The -Wmismatched-new-delete detection of operator members of class template instantiations is incomplete and overly simplistic, leading to incorrect results and false positives. Rather than reinventing the wheel and parsing the mangled qualified names of the operators the attached patch uses the

Re: Change to gcc/testsuite/go.test/test rejected by ChangeLog checker

2020-12-16 Thread Kewen.Lin via Gcc-patches
Hi Ian, on 2020/12/16 上午7:53, Ian Lance Taylor via Gcc-patches wrote: > On Tue, Dec 15, 2020 at 3:51 PM Ian Lance Taylor wrote: >> >> On Tue, Dec 15, 2020 at 3:43 PM Ian Lance Taylor wrote: >>> >>> I'm trying to commit a change that adds a bunch of new files to >>> gcc/testsuite/go.test/test. I

PING^6 [PATCH 1/4] unroll: Add middle-end unroll factor estimation

2020-12-16 Thread Kewen.Lin via Gcc-patches
Hi, Gentle ping^6 for: https://gcc.gnu.org/pipermail/gcc-patches/2020-May/546698.html BR, Kewen on 2020/11/19 下午1:50, Kewen.Lin via Gcc-patches wrote: > Hi, > > Gentle ping^5 for: > > https://gcc.gnu.org/pipermail/gcc-patches/2020-May/546698.html > > BR, > Kewen > > on 2020/11/2 下午5:13, Kew

Re: Change to gcc/testsuite/go.test/test rejected by ChangeLog checker

2020-12-16 Thread Ian Lance Taylor via Gcc-patches
On Wed, Dec 16, 2020 at 6:54 PM Kewen.Lin wrote: > > on 2020/12/16 上午7:53, Ian Lance Taylor via Gcc-patches wrote: > > On Tue, Dec 15, 2020 at 3:51 PM Ian Lance Taylor wrote: > >> > >> On Tue, Dec 15, 2020 at 3:43 PM Ian Lance Taylor wrote: > >>> > >>> I'm trying to commit a change that adds a b

Re: Change to gcc/testsuite/go.test/test rejected by ChangeLog checker

2020-12-16 Thread Kewen.Lin via Gcc-patches
on 2020/12/17 上午11:26, Ian Lance Taylor wrote: > On Wed, Dec 16, 2020 at 6:54 PM Kewen.Lin wrote: >> >> on 2020/12/16 上午7:53, Ian Lance Taylor via Gcc-patches wrote: >>> On Tue, Dec 15, 2020 at 3:51 PM Ian Lance Taylor wrote: On Tue, Dec 15, 2020 at 3:43 PM Ian Lance Taylor wrote:

Re: Go testsuite patch committed: Add some new tests

2020-12-16 Thread Ian Lance Taylor via Gcc-patches
This patch adds some more new tests from the fixedbugs subdirectory of the source repo that currently pass with gccgo. Bootstrapped and ran Go testsuite on x86_64-pc-linux-gnu. Committed to mainline. Ian patch.txt.bz2 Description: application/bzip

Re: Go testsuite patch committed: Add some new tests

2020-12-16 Thread Ian Lance Taylor via Gcc-patches
And another set of new tests. Bootstrapped and ran Go testsuite on x86_64-pc-linux-gnu. Committed to mainline. Ian patch.txt.bz2 Description: application/bzip

Re: [PATCH 3/3] RISC-V: Support version controling for ISA standard extensions

2020-12-16 Thread Kito Cheng via Gcc-patches
Hi Gerald: Thanks for notifying me, we'll update that page soon :) On Tue, Dec 15, 2020 at 4:08 PM Gerald Pfeifer wrote: > > On Fri, 13 Nov 2020, Kito Cheng wrote: > > - New option -misa-spec support: -misa-spec=[2.2|20190608|20191213] and > >corresponding configuration option --with-isa-sp

Re: Change to gcc/testsuite/go.test/test rejected by ChangeLog checker

2020-12-16 Thread Ian Lance Taylor via Gcc-patches
On Wed, Dec 16, 2020 at 7:38 PM Kewen.Lin wrote: > > With the helper gcc-verify from contrib/gcc-git-customization.sh [1], > you can verify your local commit to meet required ChangeLog formats. > Does gcc-verify claim that it's ok locally? > > If no, probably you can amend the commit message with

Re: Change to gcc/testsuite/go.test/test rejected by ChangeLog checker

2020-12-16 Thread Ian Lance Taylor via Gcc-patches
On Wed, Dec 16, 2020 at 8:01 PM Ian Lance Taylor wrote: > > Thanks for the pointer to git-verify. It also fails. It looks like > when the file name contains a non-ASCII character, it comes back with > quotation marks around it. That causes the test "if > path.startswith(ignored):" in git_commit

Patch RFA: Support non-ASCII file names in git-changelog

2020-12-16 Thread Ian Lance Taylor via Gcc-patches
As discussed at https://gcc.gnu.org/pipermail/gcc-patches/2020-December/561995.html , the ChangeLog checker does not correctly handle files with non-ASCII file names. This patch fixes the problem. I have little experience with Python, so I may have made some foolish mistakes here. OK to commit?

Re: [PATCH] Correct -fdump-go-spec's handling of incomplete types

2020-12-16 Thread Nikhil Benesch via Gcc-patches
On 12/16/20 3:13 PM, Nikhil Benesch wrote: On 12/16/20 2:20 PM, Rainer Orth wrote: Hi Nikhil, On 12/15/20 3:00 AM, Nikhil Benesch wrote: If this patch looks good, I'll submit it upstream tomorrow. Assuming no news is good news, I sent https://go-review.googlesource.com/c/gofrontend/+/278672

<    1   2