Re: [PATCH] [PING] Asan changes for RISC-V.

2020-11-04 Thread Jim Wilson
On Wed, Oct 28, 2020 at 4:59 PM Jim Wilson wrote: > We have only riscv64 asan support, there is no riscv32 support as yet. So > I > need to be able to conditionally enable asan support for the riscv > target. I > implemented this by returning zero from the asan_shadow_offset function. > This >

[Patch][i386][PR97715]: Fix a bug when adding -fzero-call-used-regs=all with -mno-80387

2020-11-04 Thread Qing Zhao via Gcc-patches
As we discussed in the bug report, we should not zero stack registers when there is no x87 registers available. The following is the fix per Jakub’s suggestion. And I have tested it on X86. Okay for commit? thanks. Qing From 0080f104df2dc752969a1949981ba343f276e802 Mon Sep 17 00:00:00 2001

Re: [PATCH] arm: Implement vceqq_p64, vceqz_p64 and vceqzq_p64 intrinsics

2020-11-04 Thread Christophe Lyon via Gcc-patches
ping? https://gcc.gnu.org/pipermail/gcc-patches/2020-October/556299.html On Fri, 23 Oct 2020 at 19:20, Christophe Lyon wrote: > > ping? > > On Fri, 16 Oct 2020 at 10:41, Christophe Lyon > wrote: > > > > On Thu, 15 Oct 2020 at 20:10, Andrea Corallo wrote: > > > > > > Hi Christophe, > > > > > > I

Re: [Patch][i386][PR97715]: Fix a bug when adding -fzero-call-used-regs=all with -mno-80387

2020-11-04 Thread Uros Bizjak via Gcc-patches
On Wed, Nov 4, 2020 at 9:16 PM Qing Zhao wrote: > > As we discussed in the bug report, we should not zero stack registers when > there is no x87 registers available. > > The following is the fix per Jakub’s suggestion. > > And I have tested it on X86. > > Okay for commit? > > thanks. > > Qing > >

[PATCH, rs6000] Update instruction attributes for Power10

2020-11-04 Thread Pat Haugen via Gcc-patches
Update instruction attributes for Power10. This patch updates the type/prefixed/dot/size attributes for various new instructions (and a couple existing that were incorrect) in preparation for the Power10 scheduling patch that will be following. Bootstrap/regtest on powerpc64le (Power8/Power10)

Re: [PATCH] libstdc++: Implement C++20 features for

2020-11-04 Thread Thomas Rodgers
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97719 > On Nov 4, 2020, at 11:54 AM, Stephan Bergmann wrote: > > On 07/10/2020 18:55, Thomas Rodgers wrote: >> From: Thomas Rodgers >> New ctors and ::view() accessor for - >> * basic_stingbuf >> * basic_istringstream >> * basic_ostringstream >

Re: [PATCH] PowerPC: PR libgcc/97543, build libgcc with -mno-gnu-attribute

2020-11-04 Thread Segher Boessenkool
Hi! On Tue, Nov 03, 2020 at 10:25:05PM -0500, Michael Meissner wrote: > On Sat, Oct 31, 2020 at 11:39:23PM +1030, Alan Modra wrote: > > Why is this is wrong? If you are configuring using > > --without-long-double-128 then that doesn't mean 128-bit long doubles > > are unsupported, it just selects

Re: [PATCH] "used" attribute saves decl from linker garbage collection

2020-11-04 Thread Hans-Peter Nilsson
On Wed, 4 Nov 2020, H.J. Lu wrote: > On Wed, Nov 4, 2020 at 10:09 AM Hans-Peter Nilsson wrote: > > > > On Wed, 4 Nov 2020, Jozef Lawrynowicz wrote: > > > I personally do not see the problem with the .retain attribute, however > > > if it is going to be a barrier to getting the functionality commit

Re: [PATCH v5] rtl: builtins: (not just) rs6000: Add builtins for fegetround, feclearexcept and feraiseexcept [PR94193]

2020-11-04 Thread Joseph Myers
On Wed, 4 Nov 2020, Raoni Fassina Firmino via Gcc-patches wrote: > IMHO, It seems like it is not necessary if there not a libc that have > different values for the FE_* macros. I didn't check other archs, but if > is the case for some other arch I think it could be changed if and when > some other

Re: [PATCH v5] rtl: builtins: (not just) rs6000: Add builtins for fegetround, feclearexcept and feraiseexcept [PR94193]

2020-11-04 Thread Joseph Myers
On Wed, 4 Nov 2020, Richard Biener wrote: > AFAICS you do nothing to marshall with the actually used libc > implementation which AFAIU can choose arbitrary values for > the FE_* macros. I'm not sure we require the compiler to be > configured for one specific C library and for example require > ma

Re: [PATCH] "used" attribute saves decl from linker garbage collection

2020-11-04 Thread H.J. Lu via Gcc-patches
On Wed, Nov 4, 2020 at 1:03 PM Hans-Peter Nilsson wrote: > > On Wed, 4 Nov 2020, H.J. Lu wrote: > > On Wed, Nov 4, 2020 at 10:09 AM Hans-Peter Nilsson > > wrote: > > > > > > On Wed, 4 Nov 2020, Jozef Lawrynowicz wrote: > > > > I personally do not see the problem with the .retain attribute, howev

Re: [PATCH] libstdc++: Implement C++20 features for

2020-11-04 Thread Jonathan Wakely via Gcc-patches
On 04/11/20 12:43 -0800, Thomas Rodgers wrote: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97719 On Nov 4, 2020, at 11:54 AM, Stephan Bergmann wrote: On 07/10/2020 18:55, Thomas Rodgers wrote: From: Thomas Rodgers New ctors and ::view() accessor for - * basic_stingbuf * basic_istringst

Re: [PATCH] "used" attribute saves decl from linker garbage collection

2020-11-04 Thread Hans-Peter Nilsson
On Wed, 4 Nov 2020, H.J. Lu wrote: > On Wed, Nov 4, 2020 at 1:03 PM Hans-Peter Nilsson wrote: > > > > On Wed, 4 Nov 2020, H.J. Lu wrote: > > > On Wed, Nov 4, 2020 at 10:09 AM Hans-Peter Nilsson > > > wrote: > > > > > > > > On Wed, 4 Nov 2020, Jozef Lawrynowicz wrote: > > > > > I personally d

Re: Testsuite fails on PowerPC with: Re: [PATCH][middle-end][i386][version 6]Add -fzero-call-used-regs=[skip|used-gpr-arg|used-arg|all-gpr-arg|all-arg|used-gpr|all-gpr|used|all])

2020-11-04 Thread Segher Boessenkool
On Wed, Nov 04, 2020 at 01:58:26PM -0600, Qing Zhao wrote: > > On Nov 4, 2020, at 1:00 PM, Segher Boessenkool > > wrote: > > On Wed, Nov 04, 2020 at 01:20:58PM +, Richard Sandiford wrote: > >> Tobias Burnus writes: > >>> Three of the testcases fail on PowerPC: > >>> gcc.target/i386/zero-scr

Re: [PATCH 3/4] IBM Z: Store long doubles in vector registers when possible

2020-11-04 Thread Ilya Leoshkevich via Gcc-patches
On Wed, 2020-11-04 at 18:16 +0100, Andreas Krebbel wrote: > On 03.11.20 22:45, Ilya Leoshkevich wrote: > > On z14+, there are instructions for working with 128-bit floats > > (long > > doubles) in vector registers. It's beneficial to use them instead > > of > > instructions that operate on floatin

Re: [PATCH] "used" attribute saves decl from linker garbage collection

2020-11-04 Thread H.J. Lu via Gcc-patches
On Wed, Nov 4, 2020 at 1:56 PM Hans-Peter Nilsson wrote: > > > > On Wed, 4 Nov 2020, H.J. Lu wrote: > > > On Wed, Nov 4, 2020 at 1:03 PM Hans-Peter Nilsson wrote: > > > > > > On Wed, 4 Nov 2020, H.J. Lu wrote: > > > > On Wed, Nov 4, 2020 at 10:09 AM Hans-Peter Nilsson > > > > wrote: > > > > > >

Re: [PATCH 4/4] IBM Z: Test long doubles in vector registers

2020-11-04 Thread Ilya Leoshkevich via Gcc-patches
On Wed, 2020-11-04 at 18:28 +0100, Andreas Krebbel wrote: > These tests all use the -mzvector option but do not appear to make > use of the z vector languages > extensions. I think that option could be removed. Then these tests > should be moved to the vector subdir. Will change, thanks! > You co

Re: Testsuite fails on PowerPC with: Re: [PATCH][middle-end][i386][version 6]Add -fzero-call-used-regs=[skip|used-gpr-arg|used-arg|all-gpr-arg|all-arg|used-gpr|all-gpr|used|all])

2020-11-04 Thread Tobias Burnus
On 04.11.20 20:00, Segher Boessenkool wrote: But why are tests in gcc.target/i386/ run for other targets at all?! Those under gcc.target/i386/ contain assembler checks – and are only for x86 and are (hence) also only suitable for x86. But the failing ones for PowerPC (PR97680) and ARM (PR97699

Re: [PATCH] "used" attribute saves decl from linker garbage collection

2020-11-04 Thread Hans-Peter Nilsson
On Wed, 4 Nov 2020, H.J. Lu wrote: > On Wed, Nov 4, 2020 at 1:56 PM Hans-Peter Nilsson wrote: > > On Wed, 4 Nov 2020, H.J. Lu wrote: > > > > > On Wed, Nov 4, 2020 at 1:03 PM Hans-Peter Nilsson > > > wrote: > > > > > > > > On Wed, 4 Nov 2020, H.J. Lu wrote: > > > > > On Wed, Nov 4, 2020 at 10:09

Re: [PATCH] i386: Cleanup i386/i386elf.h and align it's return convention with the SVR4 ABI

2020-11-04 Thread Pat Bernardi
> So, since the unpatched compiler crashes with an example that would > make a difference, I think the patch is OK as it is. Thanks for taking the time to look at that Uros, and apologies for not getting back to you sooner. With regards to your other question: > So, is it necessary to define DE

Re: [PATCH] libstdc++: Implement C++20 features for

2020-11-04 Thread Jonathan Wakely via Gcc-patches
On 04/11/20 21:45 +, Jonathan Wakely wrote: On 04/11/20 12:43 -0800, Thomas Rodgers wrote: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97719 On Nov 4, 2020, at 11:54 AM, Stephan Bergmann wrote: On 07/10/2020 18:55, Thomas Rodgers wrote: From: Thomas Rodgers New ctors and ::view() acce

Re: [PATCH] "used" attribute saves decl from linker garbage collection

2020-11-04 Thread H.J. Lu via Gcc-patches
c" .text .retain xyzzy <<<<<<<<< What does it do? .local xyzzy .comm xyzzy,4,4 .ident "GCC: (GNU) 11.0.0 20201103 (experimental)" .section .note.GNU-stack,"",@progbits [hjl@gnu-cfl-2 gcc]$ A symbol directive should operate on the symbol table. With 'R' flag, we got .file "x.c" .text .section .bss.xyzzy,"awR",@nobits .align 4 .type xyzzy, @object .size xyzzy, 4 xyzzy: .zero 4 .ident "GCC: (GNU) 11.0.0 20201104 (experimental)" .section .note.GNU-stack,"",@progbits -- H.J.

[PATCH] middle-end: Store and use the SLP instance kind when aborting load/store lanes

2020-11-04 Thread Tamar Christina via Gcc-patches
Hi All, This patch stores the SLP instance kind in the SLP instance so that we can use it later when detecting load/store lanes support. This also changes the load/store lane support check to only check if the SLP kind is a store. This means that in order for the load/lanes to work all instances

Re: PowerPC: Map IEEE 128-bit long double built-in functions

2020-11-04 Thread Segher Boessenkool
Hi! On Thu, Oct 22, 2020 at 06:03:46PM -0400, Michael Meissner wrote: > To map the scanf functions, is mapped to __isoc99_ieee128. Is that correct? What if you are compiling for c90? > * config/rs6000/rs6000.c (rs6000_mangle_decl_assembler_name): Add > support for mapping built-in

builtins: Add DFP signaling NaN built-in functions

2020-11-04 Thread Joseph Myers
Add built-in functions __builtin_nansd32, __builtin_nansd64 and __builtin_nansd128 to return signaling NaNs of decimal floating-point types, analogous to the functions already present for binary floating-point types. This patch, independent of

[PATCH] cache compute_objsize results in strlen/sprintf (PR 97373)

2020-11-04 Thread Martin Sebor via Gcc-patches
To determine the target of a pointer expression and the offset into it, the increasingly widely used compute_objsize function traverses the IL following the DEF statements of pointer variables, aggregating offsets from POINTER_PLUS assignments along the way. It does that for many statements that

Ping: [PATCH 0/4] rs6000: Enable variable vec_insert with IFN VEC_SET

2020-11-04 Thread Xionghu Luo via Gcc-patches
Ping. On 2020/10/10 16:08, Xionghu Luo wrote: Originated from https://gcc.gnu.org/pipermail/gcc-patches/2020-September/554240.html with patch split and some refinement per review comments. Patch of IFN VEC_SET for ARRAY_REF(VIEW_CONVERT_EXPR) is committed, this patch set enables expanding IFN V

Re: PowerPC: Map IEEE 128-bit long double built-in functions

2020-11-04 Thread Michael Meissner via Gcc-patches
On Wed, Nov 04, 2020 at 06:13:57PM -0600, Segher Boessenkool wrote: > Hi! > > On Thu, Oct 22, 2020 at 06:03:46PM -0400, Michael Meissner wrote: > > To map the scanf functions, is mapped to __isoc99_ieee128. > > Is that correct? What if you are compiling for c90? That is the name in GLIBC. > >

RE: [PATCH 1/5] [PR target/96342] Change field "simdlen" into poly_uint64

2020-11-04 Thread yangyang (ET)
> > Thanks for installing the patch. As you mentioned in the PR, stage1 of > > GCC 11 is going to close in a few weeks, and GCC Development Plan > > describes the stage3 as " During this two-month period, the only > (non-documentation) changes that may be made are changes that fix bugs or > new por

[PATCH] Replace dep_list_size with dep_list_costs for better scheduling

2020-11-04 Thread Jojo R
gcc/ * haifa-sched.c (dep_list_costs): New. (rank_for_schedule): Use dep_list_costs. --- gcc/haifa-sched.c | 26 -- 1 file changed, 24 insertions(+), 2 deletions(-) diff --git a/gcc/haifa-sched.c b/gcc/haifa-sched.c index 350178c82b8..62d1816a55d 1

Re: [PATCH v3] pass: Run cleanup passes before SLP [PR96789]

2020-11-04 Thread Kewen.Lin via Gcc-patches
Hi Lyon, Thanks for reporting and sorry for the failure. >> The patch was updated as your comments above, re-tested on Power8 >> and committed in r11-4637. >> > > The new test gcc.dg/tree-ssa/pr96789.c fails on arm: > FAIL: gcc.dg/tree-ssa/pr96789.c scan-tree-dump dse3 "Deleted dead store:.*tmp"

Re: [00/32] C++ 20 Modules

2020-11-04 Thread Boris Kolpackov
Nathan Sidwell writes: > Here is the implementation of C++20 modules that I have been developing > on the devel/c++-modules branch over the last few years. Congrats on reaching this point. > It is not a complete implementation. The major missing pieces are: > > [...] Building C++20 modules

Re: [PATCH 3/4] IBM Z: Store long doubles in vector registers when possible

2020-11-04 Thread Andreas Krebbel via Gcc-patches
On 04.11.20 23:12, Ilya Leoshkevich wrote: > On Wed, 2020-11-04 at 18:16 +0100, Andreas Krebbel wrote: >> On 03.11.20 22:45, Ilya Leoshkevich wrote: >>> On z14+, there are instructions for working with 128-bit floats >>> (long >>> doubles) in vector registers. It's beneficial to use them instead >

Re: [PATCH] middle-end: Store and use the SLP instance kind when aborting load/store lanes

2020-11-04 Thread Richard Biener
On Thu, 5 Nov 2020, Tamar Christina wrote: > Hi All, > > This patch stores the SLP instance kind in the SLP instance so that we can use > it later when detecting load/store lanes support. > > This also changes the load/store lane support check to only check if the SLP > kind is a store. This me

Re: [PATCH 4/4] IBM Z: Test long doubles in vector registers

2020-11-04 Thread Andreas Krebbel via Gcc-patches
On 04.11.20 23:19, Ilya Leoshkevich wrote: > On Wed, 2020-11-04 at 18:28 +0100, Andreas Krebbel wrote: >> These tests all use the -mzvector option but do not appear to make >> use of the z vector languages >> extensions. I think that option could be removed. Then these tests >> should be moved to t

Re: [PATCH] cache compute_objsize results in strlen/sprintf (PR 97373)

2020-11-04 Thread Richard Biener via Gcc-patches
On Thu, Nov 5, 2020 at 1:59 AM Martin Sebor via Gcc-patches wrote: > > To determine the target of a pointer expression and the offset into > it, the increasingly widely used compute_objsize function traverses > the IL following the DEF statements of pointer variables, aggregating > offsets from PO

<    1   2