Re: [PATCH] postreload: Fix autoinc handling in reload_cse_move2add [PR94516]

2020-04-07 Thread Jeff Law via Gcc-patches
On Wed, 2020-04-08 at 00:55 +0200, Jakub Jelinek wrote: > Hi! > > The following testcase shows two separate issues caused by the cselib > changes. > One is that through the cselib sp tracking improvements on > ... r12 = rsp; rsp -= 8; push cst1; push cst2; push cst3; call > rsp += 32; rsp -= 8; pu

Re: [PATCH v2 00/11] aarch64: Implement TImode comparisons

2020-04-07 Thread Richard Henderson via Gcc-patches
On 4/7/20 4:58 PM, Segher Boessenkool wrote: >> I wonder if it would be helpful to have >> >> (uoverflow_plus x y carry) >> (soverflow_plus x y carry) >> >> etc. > > Those have three operands, which is nasty to express. How so? It's a perfectly natural operation. > On rs6000 we have the car

Re: [PATCH] Fix use of singleton in optinfo framework

2020-04-07 Thread Gustavo Romero via Gcc-patches
Hi David, On 04/06/2020 10:42 PM, David Malcolm wrote: On Mon, 2020-04-06 at 19:44 -0400, Gustavo Romero wrote: Thanks for this patch. The patch looks correct, but I'm not sure that the description of the problem is exact in every detail. I think you've run into a bug in code I wrote; sorry.

Re: [PATCH] Fix use of singleton in optinfo framework

2020-04-07 Thread Gustavo Romero via Gcc-patches
On 04/07/2020 03:24 AM, Jakub Jelinek wrote: On Mon, Apr 06, 2020 at 09:42:17PM -0400, David Malcolm via Gcc-patches wrote: 2020-04-06 Gustavo Romero * dumpfile.c: (selftest::temp_dump_context::temp_dump_context): Fix ctor. --- gcc/dumpfile.c | 2 +- 1 file changed, 1 inse

[PATCH v2] On PPC32 GCC9 or later can throw an ICE when built with older GCCs

2020-04-07 Thread Gustavo Romero via Gcc-patches
When GCC9 is built with an older GCC (4.2.1) on FreeBSD 32-bit on PowerPC an ICE is generated on stage 1 when selftests are performed. After an investigation the root cause was traced to an unnecessary and harmful instantiation of a new dump_context singleton class in order to get the current acti

[PATCH v2] Fix use of singleton in optinfo framework

2020-04-07 Thread Gustavo Romero via Gcc-patches
Currently an use of get() method of dump_context singleton in optinfo framework causes a new class to be instantiated and when its dtor is called it calls delete on uninitialized data, causing an ICE. It happens when a temporary dump_context is instantiated for the 'm_saved' initialization in temp

[committed] libphobos: Merge upstream phobos fb4f6a713

2020-04-07 Thread Iain Buclaw via Gcc-patches
Hi, This patch merges the libphobos implementation with the upstream phobos fb4f6a713. Improves the versioning of IeeeFlags and FloatingPointControl code and unit-tests, making it clearer which targets can and cannot support it. Bootstrapped and regression tested on x86_64-linux-gnu, and committ

[pushed] c++: requires-expression and tentative parse [PR94480]

2020-04-07 Thread Jason Merrill via Gcc-patches
The problem here was that cp_parser_requires_expression committing to a tentative parse confused cp_parser_decltype_expr, which needs to still be tentative. The only reason to commit here is to get syntax errors within the requires-expression, which we can still do when the commit is firewalled fr

<    1   2