Re: [PATCH] print-rtl: Fix printing of CONST_STRING in DEBUG_INSNs [PR93399]

2020-03-05 Thread Jakub Jelinek
On Thu, Mar 05, 2020 at 08:55:33AM +0100, Richard Biener wrote: > It looks like tree-pretty-print.c doesn't bother to truncate it > so why bother for RTL? Ok, so I'll go then with the size_t argument, so that nothing needs to be truncated. Updated patch: 2020-03-05 Jakub Jelinek PR mi

Re: [PATCH] print-rtl: Fix printing of CONST_STRING in DEBUG_INSNs [PR93399]

2020-03-05 Thread Richard Biener
On Thu, 5 Mar 2020, Jakub Jelinek wrote: > On Thu, Mar 05, 2020 at 08:55:33AM +0100, Richard Biener wrote: > > It looks like tree-pretty-print.c doesn't bother to truncate it > > so why bother for RTL? > > Ok, so I'll go then with the size_t argument, so that nothing needs to be > truncated. > Up

Re: Regression on 32-bit powerpc?

2020-03-05 Thread Jakub Jelinek
On Thu, Mar 05, 2020 at 08:56:37AM +0100, John Paul Adrian Glaubitz wrote: > The latest gcc-10 snapshot in Debian fails to build in Debian with: What is the problem? All that is present in what you posted are warnings. > Full log in: > https://buildd.debian.org/status/fetch.php?pkg=gcc-10&arch=p

Re: Regression on 32-bit powerpc?

2020-03-05 Thread John Paul Adrian Glaubitz
On 3/5/20 9:11 AM, Jakub Jelinek wrote: > On Thu, Mar 05, 2020 at 08:56:37AM +0100, John Paul Adrian Glaubitz wrote: >> The latest gcc-10 snapshot in Debian fails to build in Debian with: > > What is the problem? > All that is present in what you posted are warnings. Okay, I was confused by the "

Re: [PATCH v2 3/3] Keep .GCC.command.line sections of LTO objetcs.

2020-03-05 Thread Martin Liška
Hi. I'm sending the updated patch based on Egeyar's work. It utilizes a new environmental variable and uses the currently existing -frecord-gcc-switches option. Thoughts? Martin >From 9436d12e7a540691c6f2d6e2db4730a138e5c458 Mon Sep 17 00:00:00 2001 From: Martin Liska Date: Thu, 5 Mar 2020 09:3

[PATCH] testsuite: Compile asan_test.C with -Wno-alloc-size-larger-than

2020-03-05 Thread Uros Bizjak
asan_test.cc tries to allocate 0xf000 bytes for 32bit targets in a disabled DISABLED_DemoOOM test. Since the testcase is compiled with -Werror, the compilation fails with: error: argument 1 value '4026531840' exceeds maximum object size 2147483647 Compile with -Wno-alloc-size-larger-than to

Re: [PATCH] testsuite: Compile asan_test.C with -Wno-alloc-size-larger-than

2020-03-05 Thread Jakub Jelinek
On Thu, Mar 05, 2020 at 10:05:43AM +0100, Uros Bizjak wrote: > asan_test.cc tries to allocate 0xf000 bytes for 32bit targets in > a disabled DISABLED_DemoOOM test. Since the testcase is compiled with > -Werror, the compilation fails with: > > error: argument 1 value '4026531840' exceeds maxim

Re: GLIBC libmvec status

2020-03-05 Thread Segher Boessenkool
On Fri, Feb 28, 2020 at 05:31:56PM +0100, Jakub Jelinek wrote: > On Fri, Feb 28, 2020 at 04:23:03PM +, GT wrote: > > Do we want to change the name and title of the document since Segher > > doesn't believe it > > is an ABI. My initial suggestion: "POWER Architecture Specification of > > Scala

[PATCH] Backport to gcc-9: PR92398: Fix testcase failure of pr72804.c

2020-03-05 Thread luoxhu
From: Xionghu Luo Backport the patch to fix failures on P9 and P8BE, P7LE for PR94036. Tested pass on P9/P8/P7, ok to commit? (gcc-8 is not needed as the test doesn't exists.) P9LE generated instruction is not worse than P8LE. mtvsrdd;xxlnot;stxv vs. not;not;std;std. It can have longer latency,

Re: [PATCH] [rs6000] Fix a wrong GC issue

2020-03-05 Thread Segher Boessenkool
Hi Bin Bin, On Thu, Mar 05, 2020 at 10:31:39AM +0800, binbin wrote: > On 2020/3/5 上午2:35, Segher Boessenkool wrote: > >On Wed, Mar 04, 2020 at 03:08:41PM +0800, binbin wrote: > * config/rs6000/rs6000.h (MAX_MACHINE_MODE): Include the header file > for MAX_MACHINE_MODE. > >>> > >>>The c

[PATCH][GCC]: Add myself to MAINTAINERS

2020-03-05 Thread Srinath Parvathaneni
Hello, Add myself to MAINTAINERS file. Regards, SRI. ChangeLog: 2020-03-05 Srinath Parvathaneni * MAINTAINERS (Write After Approval): Add myself. ### Attachment also inlined for ease of reply### diff --git a/MAINTAINERS b/MAINTAINERS index 5e0ce3

Re: [GCC][PATCH][AArch64] ACLE intrinsics for BFCVTN, BFCVTN2 (AArch64 AdvSIMD) and BFCVT (AArch64 FP)

2020-03-05 Thread Richard Sandiford
Hi, Thanks for the update and sorry for the slow reply. When I try the patch locally I get: FAIL: gcc.target/aarch64/advsimd-intrinsics/bfcvt-nosimd.c -O0 (test for excess errors) FAIL: gcc.target/aarch64/advsimd-intrinsics/bfcvt-nosimd.c -O1 (test for excess errors) FAIL: gcc.target/aar

Re: Regression on 32-bit powerpc?

2020-03-05 Thread Richard Biener
On Thu, Mar 5, 2020 at 9:14 AM John Paul Adrian Glaubitz wrote: > > On 3/5/20 9:11 AM, Jakub Jelinek wrote: > > On Thu, Mar 05, 2020 at 08:56:37AM +0100, John Paul Adrian Glaubitz wrote: > >> The latest gcc-10 snapshot in Debian fails to build in Debian with: > > > > What is the problem? > > All t

Re: [GCC][PATCH][AArch32] ACLE intrinsics bfloat16 vmmla and vfma for AArch32 AdvSIMD

2020-03-05 Thread Kyrill Tkachov
Hi Delia, On 3/4/20 5:20 PM, Delia Burduv wrote: Hi, This is the latest version of the patch. Thanks, Delia On 2/21/20 11:41 AM, Kyrill Tkachov wrote: Hi Delia, On 2/19/20 5:23 PM, Delia Burduv wrote: Hi, Here is the latest version of the patch. It just has some minor formatting changes

Re: [PING PATCH coroutines] Set side effects flag for BIND_EXPR which build in maybe_promote_captured_temps

2020-03-05 Thread JunMa
Ping Regards JunMa 在 2020/2/27 上午10:17, JunMa 写道: 在 2020/2/11 上午10:50, JunMa 写道: Hi kindly ping~ Regards JunMa Hi As title. in maybe_promote_captured_temps, we promote captured temporaries and co_await_expr into a new BIND_EXPR. As the BIND_EXPR contains co_await_expr and maybe other functio

Re: [PING PATCH coroutines] Do not strip cleanup_point when promote temporaries out of current stmt

2020-03-05 Thread JunMa
Ping Regards JunMa 在 2020/2/27 上午10:18, JunMa 写道: 在 2020/2/11 上午10:14, JunMa 写道: Kindly ping Regards JunMa Hi In maybe_promote_captured_temps, the cleanup_point_stmt has been stripped when handle temporaries captured by reference. However, maybe there are non-reference temporaries in current s

Re: [testsuite] Fix PR94019 to allow one vector char when !vect_hw_misalign

2020-03-05 Thread Richard Sandiford
"Kewen.Lin" writes: > on 2020/3/5 上午3:09, Richard Sandiford wrote: >> "Kewen.Lin" writes: >>> Hi, >>> >>> >>> --- a/gcc/testsuite/gcc.dg/vect/vect-over-widen-17.c >>> +++ b/gcc/testsuite/gcc.dg/vect/vect-over-widen-17.c >>> @@ -41,6 +41,10 @@ main (void) >>> } >>> >>> /* { dg-final { scan-tree-

Re: [Committed 4/4] IBM Z: zTPF: Include glibc-stdint.h

2020-03-05 Thread Andreas Krebbel
On 3/5/20 12:34 AM, Joseph Myers wrote: > On Wed, 4 Mar 2020, Andreas Krebbel wrote: > >> Building a zTPF cross currently fails when building libstdc++ >> complaining about the __UINTPTR_TYPE__ to be missing. >> >> Fixed by including the glibc-stdint.h header. > > To confirm: TPF provides a head

Re: [PATCH v2 3/3] Keep .GCC.command.line sections of LTO objetcs.

2020-03-05 Thread Egeyar Bagcioglu
I'm sending the updated patch based on Egeyar's work. It utilizes a new environmental variable and uses the currently existing -frecord-gcc-switches option. Thoughts? I am leaving it to the more experienced to comment on redefining the functionality of -frecord-gcc-switches. The code see

Re: [PATCH v2 0/3] Introduce a new GCC option, --record-gcc-command-line

2020-03-05 Thread Egeyar Bagcioglu
On 3/5/20 8:36 AM, Richard Biener wrote: On Wed, Mar 4, 2020 at 5:28 PM Egeyar Bagcioglu wrote: On 3/4/20 1:18 AM, Fangrui Song wrote: On 2020-03-03, Joseph Myers wrote: On Tue, 3 Mar 2020, Egeyar Bagcioglu wrote: Although we discussed after the submission of the first version that the

[OG9][devel/omp/gcc-9] Merge from gcc-9-branch [was: devel/omp/gcc-9 branch]

2020-03-05 Thread Tobias Burnus
I have now merged the GCC 9 changes into the branch; before it was up to date with 'releases/gcc-9.1.0', and now it is with today's r9-8340-g7beafc829c5b122298093ba517023015611aeca8 This was done in two pieces (9.1.0 to 9.2.0 changes, and then to today's as only 1000 commits are permitted.) The

Re: [PING PATCH coroutines] Set side effects flag for BIND_EXPR which build in maybe_promote_captured_temps

2020-03-05 Thread Iain Sandoe
Hello JunMa, JunMa wrote: Ping Thanks for your patch(es) and I am sorry this has taken some time to review. (right now, we’re trying to ensure that we have the latest standard represented in GCC10, so updating to n4849). 在 2020/2/27 上午10:17, JunMa 写道: 在 2020/2/11 上午10:50, JunMa 写道: H

Re: [PING PATCH coroutines] Do not strip cleanup_point when promote temporaries out of current stmt

2020-03-05 Thread Iain Sandoe
Hello JunMa, JunMa wrote: Ping Once again, sorry for taking time to review this. 在 2020/2/27 上午10:18, JunMa 写道: 在 2020/2/11 上午10:14, JunMa 写道: Kindly ping Regards JunMa Hi In maybe_promote_captured_temps, the cleanup_point_stmt has been stripped when handle temporaries captured by refer

Re: [RFA/RFC] [tree-optimization/91890] [P1 Regression] Avoid clobbering useful location in Wrestrict code

2020-03-05 Thread Jeff Law
On Thu, 2020-03-05 at 08:51 +0100, Richard Biener wrote: > On Thu, Mar 5, 2020 at 12:49 AM Jeff Law wrote: > > On Wed, 2020-03-04 at 09:22 -0700, Martin Sebor wrote: > > > I don't remember why the code in -Wrestrict unconditionally overwrites > > > the statement location rather than only when it's

Re: [PATCH PR94026] combine missed opportunity to simplify comparisons with zero

2020-03-05 Thread Jeff Law
On Wed, 2020-03-04 at 08:39 +, Yangfei (Felix) wrote: > Hi, > > This is a simple fix for PR94026. > With this fix, combine will try make an extraction if we are in a equality > comparison and this is an AND > with a constant which is power of two minus one. Shift here should be an > c

Re: [PATCH] re PR tree-optimization/90883 (Generated code is worse if returned struct is unnamed)

2020-03-05 Thread Jeff Law
On Tue, 2020-03-03 at 15:34 +0800, Kito Cheng wrote: > After add --param max-inline-insns-size=1 all target will remove the > redundant store at dse1, except some targets like AArch64 and MIPS will > expand the struct initialization into loop due to CLEAR_RATIO. > > Tested on cross compiler of ris

Re: [committed][ARM] Fix minor testsuite fallout on ARM due to recent IRA changes

2020-03-05 Thread Jeff Law
On Mon, 2020-03-02 at 16:40 +, Richard Earnshaw (lists) wrote: > On 02/03/2020 15:46, Jeff Law wrote: > > More minor fallout from Vlad's IRA changes. > > > > Previously this test used r3 to hold a value across a call (it's an ipa-ra > > test). After Vlad's changes we're using r1 instead. > >

Re: ACLE intrinsics: BFloat16 store (vst{q}_bf16) intrinsics for AArch32

2020-03-05 Thread Delia Burduv
Hi, This is the latest version of the patch. I am forcing -mfloat-abi=hard because the register allocator behaves differently depending on which float-abi is used. Thanks, Delia On 3/4/20 5:20 PM, Kyrill Tkachov wrote: Hi Delia, On 3/3/20 5:23 PM, Delia Burduv wrote: Hi, I noticed that t

Re: Minor regression due to recent IRA changes

2020-03-05 Thread Jeff Law
On Sun, 2020-03-01 at 10:37 +0900, Oleg Endo wrote: > On Sat, 2020-02-29 at 12:35 -0700, Jeff Law wrote: > > Yup. That was roughly what I was thinking and roughly the worry I had with > > trying to squash out the quality regressions. But it may ultimately be the > > only way to really resolve the

[pushed GCC9] c++: Fix SFINAE for invalid non-type tparm types.

2020-03-05 Thread Jason Merrill
Just missing the usual SFINAE pattern here. This was fixed for GCC 10 as a drive-by in r277902. gcc/cp/ChangeLog 2020-03-05 Jason Merrill PR c++/90338 * pt.c (invalid_nontype_parm_type_p): Check complain for non-literal and mutable errors. --- gcc/cp/pt.c | 15 +++

Re: [RFA/RFC] [tree-optimization/91890] [P1 Regression] Avoid clobbering useful location in Wrestrict code

2020-03-05 Thread Martin Sebor
On 3/5/20 12:51 AM, Richard Biener wrote: On Thu, Mar 5, 2020 at 12:49 AM Jeff Law wrote: On Wed, 2020-03-04 at 09:22 -0700, Martin Sebor wrote: I don't remember why the code in -Wrestrict unconditionally overwrites the statement location rather than only when it's not available, but I do re

Re: ACLE intrinsics: BFloat16 store (vst{q}_bf16) intrinsics for AArch32

2020-03-05 Thread Delia Burduv
Hi, This is the latest version of the patch. I am forcing -mfloat-abi=hard because the register allocator behaves differently depending on the float-abi used. Thanks, Delia On 3/4/20 5:20 PM, Kyrill Tkachov wrote: Hi Delia, On 3/3/20 5:23 PM, Delia Burduv wrote: Hi, I noticed that the pa

[PATCH] libstdc++: Give ranges::empty() a concrete return type (PR 93978)

2020-03-05 Thread Patrick Palka
This works around PR 93978 by avoiding having to instantiate ranges::empty() when checking the constraints of view_interface::operator bool(). When ranges::empty() has an auto return type, then we must instantiate it in order to determine whether the requires expression { ranges::empty(_M_derived(

[committed] testsuite: Add testcase for already fixed PR [PR90311]

2020-03-05 Thread Jakub Jelinek
Hi! This PR has been fixed by r10-3970. Testcase tested with cross to armv7hl-linux-gnueabi (all of r10-3969 (FAIL), r10-3970 and current trunk (PASS)) and x86_64-linux and i686-linux, committed to trunk as obvious. 2020-03-05 Jakub Jelinek PR target/90311 * gcc.c-torture/ex

[PATCH 2/1] libstdc++: Add missing friend declaration to join_view::_Sentinel

2020-03-05 Thread Patrick Palka
The converting constructor of join_view::_Sentinel needs to be able to access the private members of join_view::_Sentinel. libstdc++-v3/ChangeLog: * include/std/ranges (join_view::_Sentinel<_Const>): Befriend join_view::_Sentinel. * testsuite/std/ranges/adaptors/join.cc: A

Re: ACLE intrinsics: BFloat16 load intrinsics for AArch32

2020-03-05 Thread Delia Burduv
Hi, This is the latest version of the patch. I am forcing -mfloat-abi=hard because the code generated is slightly differently depending on the float-abi used. Thanks, Delia On 3/4/20 5:20 PM, Kyrill Tkachov wrote: Hi Delia, On 3/4/20 2:05 PM, Delia Burduv wrote: Hi, The previous version

[committed] libstdc++: allow string_view insertion to work with (PR 94051)

2020-03-05 Thread Jonathan Wakely
I don't think this is actually required to compile, because using operator<< without a definition of the ostream doesn't seem valid to me. But it's easy to make it work. PR libstdc++/94051 * include/std/string_view: Include . * testsuite/21_strings/basic_string_view/inserte

[PATCH] generate EH info for volatile asm statements (PR inline-asm/93981)

2020-03-05 Thread J.W. Jagersma
The following patch extends the generation of exception handling information to cover volatile asms too. This was already mostly implemented, and only very minor changes are required in order to make it work. The change in rewrite_stmt is necessary because it inserts debug statements after the as

Re: [PATCH 2/1] libstdc++: Add missing friend declaration to join_view::_Sentinel

2020-03-05 Thread Jonathan Wakely
On 05/03/20 11:24 -0500, Patrick Palka wrote: The converting constructor of join_view::_Sentinel needs to be able to access the private members of join_view::_Sentinel. libstdc++-v3/ChangeLog: * include/std/ranges (join_view::_Sentinel<_Const>): Befriend join_view::_Sentinel.

[committed] libstdc++: Fix some warnings in filesystem tests

2020-03-05 Thread Jonathan Wakely
There's a -Wunused-but-set-variable warning in operations/all.cc which can be fixed with [[maybe_unused]]. The statements in operations/copy.cc give -Wunused-value warnings. I think I meant to use |= rather than !=. And operations/file_size.cc gets -Wsign-compare warnings. * testsuite/27

[PATCH] arm: Fix incorrect modes with 'borrow' operations [PR90311]

2020-03-05 Thread Richard Earnshaw
Looking through the arm backend I noticed that the modes used to pass comparison types into subtract-with-carry operations were being incorrectly set. The result is that the compiler is not truly self-consistent. To clean this up I've introduced a new predicate, arm_borrow_operation (borrowed fr

Re: [GCC][PATCH][AArch64] ACLE intrinsics for BFCVTN, BFCVTN2 (AArch64 AdvSIMD) and BFCVT (AArch64 FP)

2020-03-05 Thread Delia Burduv
Hi, Here is the latest version of the patch. That test should now work. Thanks, Delia On 3/5/20 11:06 AM, Richard Sandiford wrote: Hi, Thanks for the update and sorry for the slow reply. When I try the patch locally I get: FAIL: gcc.target/aarch64/advsimd-intrinsics/bfcvt-nosimd.c -O0 (

Re: [GCC][PATCH][AArch32] ACLE intrinsics bfloat16 vmmla and vfma for AArch32 AdvSIMD

2020-03-05 Thread Kyrill Tkachov
On 3/5/20 11:22 AM, Kyrill Tkachov wrote: Hi Delia, On 3/4/20 5:20 PM, Delia Burduv wrote: Hi, This is the latest version of the patch. Thanks, Delia On 2/21/20 11:41 AM, Kyrill Tkachov wrote: Hi Delia, On 2/19/20 5:23 PM, Delia Burduv wrote: Hi, Here is the latest version of the patch

Re: [PATCH 2/1] libstdc++: Add missing friend declaration to join_view::_Sentinel

2020-03-05 Thread Patrick Palka
On Thu, 5 Mar 2020, Jonathan Wakely wrote: > On 05/03/20 11:24 -0500, Patrick Palka wrote: > > The converting constructor of join_view::_Sentinel needs to be able to > > access the private members of join_view::_Sentinel. > > > > libstdc++-v3/ChangeLog: > > > > * include/std/ranges (join_vie

Re: [RFA/RFC] [tree-optimization/91890] [P1 Regression] Avoid clobbering useful location in Wrestrict code

2020-03-05 Thread Richard Biener
On March 5, 2020 4:53:43 PM GMT+01:00, Martin Sebor wrote: >On 3/5/20 12:51 AM, Richard Biener wrote: >> On Thu, Mar 5, 2020 at 12:49 AM Jeff Law wrote: >>> >>> On Wed, 2020-03-04 at 09:22 -0700, Martin Sebor wrote: I don't remember why the code in -Wrestrict unconditionally >overwrites

Re: [RFA/RFC] [tree-optimization/91890] [P1 Regression] Avoid clobbering useful location in Wrestrict code

2020-03-05 Thread Richard Biener
On March 5, 2020 3:55:57 PM GMT+01:00, Jeff Law wrote: >On Thu, 2020-03-05 at 08:51 +0100, Richard Biener wrote: >> On Thu, Mar 5, 2020 at 12:49 AM Jeff Law wrote: >> > On Wed, 2020-03-04 at 09:22 -0700, Martin Sebor wrote: >> > > I don't remember why the code in -Wrestrict unconditionally >overw

[committed] i386: Fix some -O0 avx2intrin.h and xopintrin.h intrinsic macros [PR94046]

2020-03-05 Thread Jakub Jelinek
Hi! As the testcases show, the macros we have for -O0 for intrinsics that require constant argument(s) should first cast the argument to the type the -O1+ inline uses and afterwards to whatever type e.g. a builtin needs. The PR reported one which violated this, and I've grepped for all double-cast

[pushed 9] c++: Avoid ICE on infinite recursion with concepts.

2020-03-05 Thread Jason Merrill
This was simple enough to backport even though it's concepts. gcc/cp/ChangeLog 2020-03-05 Jason Merrill PR c++/88395 PR c++/93551 * constraint.cc (constraints_satisfied_p): Use push_tinst_level. --- gcc/cp/constraint.cc | 4 .../g++.dg/co

Re: [RFA/RFC] [tree-optimization/91890] [P1 Regression] Avoid clobbering useful location in Wrestrict code

2020-03-05 Thread Jeff Law
On Thu, 2020-03-05 at 19:51 +0100, Richard Biener wrote: > On March 5, 2020 3:55:57 PM GMT+01:00, Jeff Law wrote: > > On Thu, 2020-03-05 at 08:51 +0100, Richard Biener wrote: > > > On Thu, Mar 5, 2020 at 12:49 AM Jeff Law wrote: > > > > On Wed, 2020-03-04 at 09:22 -0700, Martin Sebor wrote: > > >

[PATCH] c++: Fix ABI issue with alignas on armv7hl [PR94050]

2020-03-05 Thread Marek Polacek
The static_assert in the following test was failing on armv7hl because we were disregarding the alignas specifier on Cell. BaseShape's data takes up 20B on 32-bit architectures, but we failed to round up its TYPE_SIZE. This happens since the

GCC 9.3 Status Report (2020-03-05)

2020-03-05 Thread Jakub Jelinek
Status == The GCC 9 branch is now frozen for blocking regressions and documentation fixes only, all changes to the branch require a RM approval now. Quality Data Priority # Change from last report --- --- P10 P2

Re: [PATCH 01/10] i386: Properly encode vector registers in vector move

2020-03-05 Thread Jeff Law
On Fri, 2020-02-28 at 18:15 -0800, H.J. Lu wrote: > On Fri, Feb 28, 2020 at 4:16 PM Jeff Law wrote: > > On Thu, 2020-02-27 at 06:50 -0800, H.J. Lu wrote: > > > How about this? If it looks OK, I will post the whole patch set. > > It's better. I'm guessing the two cases that were previously handle

Re: [PATCH 1/6] i386: Properly encode vector registers in vector move

2020-03-05 Thread Jeff Law
On Sat, 2020-02-29 at 06:16 -0800, H.J. Lu wrote: > On x86, when AVX and AVX512 are enabled, vector move instructions can > be encoded with either 2-byte/3-byte VEX (AVX) or 4-byte EVEX (AVX512): > >0: c5 f9 6f d1 vmovdqa %xmm1,%xmm2 >4: 62 f1 fd 08 6f d1 vmovdqa64 %xmm1,

c: ignore initializers for elements of variable-size types [PR93577]

2020-03-05 Thread Joseph Myers
Bug 93577, apparently a regression (although it isn't very clear to me exactly when it was introduced; tests I made with various past compilers produced inconclusive results, including e.g. ICEs appearing with 64-bit-host compilers for some versions but not 32-bit-host compilers for the same versio

Re: [PATCH][testuite] Fix pr80481.C after epilogue vectorization

2020-03-05 Thread Jeff Law
On Thu, 2019-10-31 at 13:55 +, Andre Vieira (lists) wrote: > Hi, > > I used to have this testcase in my patch when testing but forgot to > include it in the patch I sent upstream. This testcase checks that a > vmovaps isn't generated when vectorizing the loop. When I turn epilogue > vecto

Re: [PATCH] drop weakref attribute on function definitions (PR 92799)

2020-03-05 Thread Jeff Law
On Fri, 2020-02-14 at 15:41 -0700, Martin Sebor wrote: > Because attribute weakref introduces a kind of a definition, it can > only be applied to declarations of symbols that are not defined. GCC > normally issues a warning when the attribute is applied to a defined > symbol, but PR 92799 shows th

RE: [PATCH PR94026] combine missed opportunity to simplify comparisons with zero

2020-03-05 Thread Yangfei (Felix)
> -Original Message- > From: Jeff Law [mailto:l...@redhat.com] > Sent: Thursday, March 5, 2020 11:37 PM > To: Yangfei (Felix) ; gcc-patches@gcc.gnu.org > Cc: Zhanghaijian (A) > Subject: Re: [PATCH PR94026] combine missed opportunity to simplify > comparisons with zero > > On Wed, 2020-03-

[PATCH] avoid treating more incompatible redeclarations as builtin-ins [PR94040]

2020-03-05 Thread Martin Sebor
Treating incompatible redeclarations of built-in functions as built-ins is a problem not just for the middle-end but even for the C front-end itself, when different parts of it make different assumptions about what is and isn't valid. The test case that is the subject of this bug report (a GCC 9

Re: [PATCH] [rs6000] Rewrite the declaration of a variable

2020-03-05 Thread binbin
Hi Kewen and Segher, On 2020/3/6 上午10:02, binbin wrote: On 2020/3/4 下午6:35, Kewen.Lin wrote: on 2020/3/4 下午3:24, binbin wrote: Hi On 2020/3/4 上午8:33, Segher Boessenkool wrote: Hi! On Tue, Mar 03, 2020 at 10:13:56AM -0600, Bin Bin Lv wrote: Rewrite the declaration of toc_section from the s

Re: [PATCH][gcc] libgccjit: introduce version entry points

2020-03-05 Thread David Malcolm
On Thu, 2020-01-16 at 11:11 +, Andrea Corallo wrote: > Hi, second version of the patch here cleaning up an unnecessary > change. > > Does not introduce regressions with make check-jit. > > Andrea > > gcc/jit/ChangeLog > 2020-??-?? Andrea Corallo > > * docs/topics/compatibility.rst

Re: [PATCH][gcc] libgccjit: handle long literals in playback::context::new_string_literal

2020-03-05 Thread David Malcolm
On Mon, 2019-09-02 at 09:16 +, Andrea Corallo wrote: > Hi all, > yesterday I've found an interesting bug in libgccjit. > Seems we have an hard limitation of 200 characters for literal > strings. > Attempting to create longer strings lead to ICE during pass_expand > while performing a sanity che

Re: [PING PATCH coroutines] Set side effects flag for BIND_EXPR which build in maybe_promote_captured_temps

2020-03-05 Thread JunMa
在 2020/3/5 下午9:51, Iain Sandoe 写道: Hello JunMa, JunMa wrote: Ping Thanks for your patch(es) and I am sorry this has taken some time to review. (right now, we’re trying to ensure that we have the latest standard represented in  GCC10, so updating to n4849). 在 2020/2/27 上午10:17, JunMa

Re: [PING PATCH coroutines] Do not strip cleanup_point when promote temporaries out of current stmt

2020-03-05 Thread JunMa
在 2020/3/5 下午10:18, Iain Sandoe 写道: Hello JunMa, JunMa wrote: Ping Once again, sorry for taking time to review this. 在 2020/2/27 上午10:18, JunMa 写道: 在 2020/2/11 上午10:14, JunMa 写道: Kindly ping Regards JunMa Hi In maybe_promote_captured_temps, the cleanup_point_stmt has been stripped when

Bind to std::equal plumbing in ranges::equal

2020-03-05 Thread François Dumont
I started to work on ranges::equal to find out if what I am trying to do is totally silly. With this patch ranges::equal is in pare with std::equal specializations that is to say that it correctly deals with Debug mode or std::deque iterators. Once below patch is in: https://gcc.gnu.org/ml/

Bind to std::equal plumbing in ranges::equal

2020-03-05 Thread François Dumont
I started to work on ranges::equal to find out if what I am trying to do is totally silly. With this patch ranges::equal is in pare with std::equal specializations that is to say that it correctly deals with Debug mode or std::deque iterators. Once below patch is in: https://gcc.gnu.org/ml/

Re: [PATCH] re PR tree-optimization/90883 (Generated code is worse if returned struct is unnamed)

2020-03-05 Thread Kito Cheng
Committed, thanks :) On Thu, Mar 5, 2020 at 11:42 PM Jeff Law wrote: > On Tue, 2020-03-03 at 15:34 +0800, Kito Cheng wrote: > > After add --param max-inline-insns-size=1 all target will remove the > > redundant store at dse1, except some targets like AArch64 and MIPS will > > expand the struct i