Re: [PATCH] tree-ssa: Fix ICE in build_vector_type [PR93780]

2020-02-18 Thread Richard Biener
On Tue, 18 Feb 2020, Jakub Jelinek wrote: > Hi! > > The following testcase ICEs, because execute_update_addresses_taken attempts > to create a VECTOR_TYPE with non-power of 2 number of elts. > Fixed by guarding it with the corresponding predicate. > > Bootstrapped/regtested on x86_64-linux and i

Re: [PATCH]Several intrinsic macros lack a closing parenthesis[PR93274]

2020-02-18 Thread Uros Bizjak
On Thu, Feb 13, 2020 at 9:39 AM Uros Bizjak wrote: > > Changelog > > gcc/ > >* config/i386/avx512vbmi2intrin.h > >(_mm512_[,mask_,maskz_]shrdi_epi16, > >_mm512_[,mask_,maskz_]shrdi_epi32, > >_m512_[,mask_,maskz_]shrdi_epi64, > >_mm512_[,mask_,maskz_]shldi_e

Re: [PATCH] ipa: Various diagnostic fixes [PR93797]

2020-02-18 Thread Jan Hubicka
> Hi! > > As the patch shows, various messages didn't match the field names they are > talking about. > > Fixed thusly, bootstrapped/regtested on x86_64-linux and i686-linux, ok for > trunk? > > 2020-02-18 Jakub Jelinek > > PR ipa/93797 > * cgraph.c (verify_speculative_call): Use

Re: [PATCH] add -Wmismatched-tags (PR 61339)

2020-02-18 Thread Stephan Bergmann
On 03/12/2019 22:49, Martin Sebor wrote: I added another warning: -Wredundant-tags to point out instances where the class-key or enum-key can safely be dropped. Both warnings are off by default. I think -Wredundant-tags would be more useful if it did not warn about occurrences within extern "C

Re: [PATCH] ipa: Various diagnostic fixes [PR93797]

2020-02-18 Thread Richard Biener
On Tue, 18 Feb 2020, Jakub Jelinek wrote: > Hi! > > As the patch shows, various messages didn't match the field names they are > talking about. > > Fixed thusly, bootstrapped/regtested on x86_64-linux and i686-linux, ok for > trunk? OK. > 2020-02-18 Jakub Jelinek > > PR ipa/93797 >

[committed] Backports to gcc-9

2020-02-18 Thread Richard Sandiford
The first patch is a backport of Prathamesh's aarch64 fix. The other three were approved for branches during the initial submission. Tested on aarch64-linux-gnu, armeb-eabi and x86_64-linux-gnu. pushed. Richard >From 03d683ec52cd77fa16effdc7d2c5dff7d49249d9 Mon Sep 17 00:00:00 2001 From: Prath

[RFA] Two backports to gcc-9

2020-02-18 Thread Richard Sandiford
Tested on aarch64-linux-gnu, armeb-eabi and x86_64-linux-gnu. OK for gcc-9? Richard >From d170fb108c194ce04713c1ae95f9a107169f27f1 Mon Sep 17 00:00:00 2001 From: Richard Sandiford Date: Fri, 9 Aug 2019 09:37:55 + Subject: [PATCH 1/2] Reject tail calls that read from an escaped RESULT_DECL

[RFC] Run store-merging pass once more before pass fre/pre

2020-02-18 Thread Xionghu Luo
Store-merging pass should run twice, the reason is pass fre/pre will do some kind of optimizations to instructions by: 1. Converting the load from address to load from function arguments (store_merging_30.c:foo1). 2. Converting the byte access to BIT_FIELD_REF(store_merging_30.c:foo2). 3. O

Re: [RFC] Run store-merging pass once more before pass fre/pre

2020-02-18 Thread Jakub Jelinek
On Tue, Feb 18, 2020 at 03:27:39AM -0600, Xionghu Luo wrote: > Store-merging pass should run twice, the reason is pass fre/pre will do > some kind of optimizations to instructions by: > 1. Converting the load from address to load from function arguments > (store_merging_30.c:foo1). > 2. Conve

Re: [RFC] Run store-merging pass once more before pass fre/pre

2020-02-18 Thread Richard Biener
On Tue, 18 Feb 2020, Xionghu Luo wrote: > Store-merging pass should run twice, the reason is pass fre/pre will do > some kind of optimizations to instructions by: > 1. Converting the load from address to load from function arguments > (store_merging_30.c:foo1). > 2. Converting the byte acces

Re: [PATCH] Drop MALLOC attribute for void functions.

2020-02-18 Thread Richard Biener
On Mon, Feb 17, 2020 at 3:47 PM Martin Liška wrote: > > Sorry, I attached wrong patch. Ah yeah, that looks like a better place (the IPA pure-const one). OK with Jakubs suggested changes. Richard. > Martin

Re: [PATCH] Drop MALLOC attribute for void functions.

2020-02-18 Thread Richard Biener
On Mon, Feb 17, 2020 at 3:48 PM Jakub Jelinek wrote: > > On Mon, Feb 17, 2020 at 03:44:53PM +0100, Martin Liška wrote: > > + error ("MALLOC attribute set on a void function"); > > Why the capitals? Either malloc or % IMSHO. > What is special about void functions, missing lhs? That can be mi

Re: [PATCH 3/3] libstdc++: Implement C++20 range adaptors

2020-02-18 Thread Jonathan Wakely
On 17/02/20 23:07 +0100, Stephan Bergmann wrote: On 04/02/2020 03:07, Patrick Palka wrote: This patch implements [range.adaptors]. It also includes the changes from P3280 and P3278 and P3323, without which many standard examples won't work. I see that with this

Re: [PATCH] Compare more sensitive FIX_TRUNC_EXPR in IPA ICF.

2020-02-18 Thread Richard Biener
On Mon, Feb 17, 2020 at 4:21 PM Martin Liška wrote: > > Hi. > > The patch is extension of 446096148ca9775cb56f9ee924fa283babcd0b76 commit > where we need to handle FIX_TRUNC_EXPR in compare_gimple_assign. > > Patch can bootstrap on x86_64-linux-gnu and survives regression tests. > > Ready to be in

Re: [RFA] Two backports to gcc-9

2020-02-18 Thread Richard Biener
On Tue, Feb 18, 2020 at 10:11 AM Richard Sandiford wrote: > > Tested on aarch64-linux-gnu, armeb-eabi and x86_64-linux-gnu. OK for gcc-9? OK > Richard >

Re: [PATCH] analyzer: fix ICE on pointer arithmetic with incomplete types [PR 93774]

2020-02-18 Thread David Malcolm
On Tue, 2020-02-18 at 08:57 +0100, Thomas König wrote: > Hi David > > in principle, any valid test case (especially for an ICE) should > count as obvious and simple, so no approval should be needed. > > Having said that, I think I would prefer a copy of the original test > case rather than an inc

Re: [PATCH]Several intrinsic macros lack a closing parenthesis[PR93274]

2020-02-18 Thread Hongtao Liu
On Tue, Feb 18, 2020 at 4:24 PM Uros Bizjak wrote: > > > > On Thu, Feb 13, 2020 at 9:39 AM Uros Bizjak wrote: >> >> > Changelog >> > gcc/ >> >* config/i386/avx512vbmi2intrin.h >> >(_mm512_[,mask_,maskz_]shrdi_epi16, >> >_mm512_[,mask_,maskz_]shrdi_epi32, >> >_m512_

Re: [PATCH] aarch64: Allow -mcpu=generic -march=armv8.5-a

2020-02-18 Thread Richard Earnshaw (lists)
On 17/02/2020 17:54, Andrew Pinski wrote: On Mon, Feb 17, 2020 at 7:56 AM Richard Earnshaw (lists) wrote: On 17/02/2020 15:42, Richard Sandiford wrote: "Richard Earnshaw (lists)" writes: On 14/02/2020 10:41, Andrew Pinski wrote: On Fri, Feb 14, 2020 at 2:12 AM Richard Earnshaw (lists) wro

Re: [PATCH 3/3] libstdc++: Implement C++20 range adaptors

2020-02-18 Thread Jonathan Wakely
On 17/02/20 20:20 -0500, Patrick Palka wrote: Hi Stephan, On Mon, 17 Feb 2020, Stephan Bergmann wrote: On 04/02/2020 03:07, Patrick Palka wrote: > This patch implements [range.adaptors]. It also includes the changes from > P3280 > and P3278 and P3323, without which many standard examples won'

Re: [PR47785] COLLECT_AS_OPTIONS

2020-02-18 Thread Prathamesh Kulkarni
On Mon, 17 Feb 2020 at 19:52, Richard Biener wrote: > > On Mon, Feb 17, 2020 at 10:28 AM Prathamesh Kulkarni > wrote: > > > > On Thu, 6 Feb 2020 at 20:03, Prathamesh Kulkarni > > wrote: > > > > > > On Thu, 6 Feb 2020 at 18:42, Richard Biener > > > wrote: > > > > > > > > On Thu, Feb 6, 2020 at

Re: [committed] libstdc++: Implement "Safe Integral Comparisons" (P0586R2)

2020-02-18 Thread Christophe Lyon
Hi, On Mon, 17 Feb 2020 at 14:22, Jonathan Wakely wrote: > > * include/std/type_traits (__is_standard_integer): New helper trait. > * include/std/utility (cmp_equal, cmp_not_equal, cmp_less, > cmp_greater) > (cmp_less_equal, cmp_greater_equal, in_range): Define for C++20.

Re: [PATCH] Drop MALLOC attribute for void functions.

2020-02-18 Thread Martin Liška
On 2/18/20 11:09 AM, Richard Biener wrote: On Mon, Feb 17, 2020 at 3:47 PM Martin Liška wrote: Sorry, I attached wrong patch. Ah yeah, that looks like a better place (the IPA pure-const one). OK with Jakubs suggested changes. Richard. Martin All right. There's hopefully a final version

[committed] analyzer.opt: rewrite description of -fdump-analyzer-callgraph [PR 93692]

2020-02-18 Thread David Malcolm
Successfully bootstrapped & regrtested on x86_64-pc-linux-gnu. Pushed to master as 0b2b45a68f48817e2310b12db3e03e648d4d2005. gcc/analyzer/ChangeLog: PR analyzer/93692 * analyzer.opt (fdump-analyzer-callgraph): Rewrite description. --- gcc/analyzer/analyzer.opt | 2 +- 1 file chang

RE: [GCC][PATCH][AArch64] ACLE intrinsics for BFCVTN, BFCVTN2 (AArch64 AdvSIMD) and BFCVT (AArch64 FP)

2020-02-18 Thread Tamar Christina
Hi Richard, > ..ffb5305e2e5ea1aadae07e82f > d8e > > d6f9f247c1a9 > > --- /dev/null > > +++ b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/bfcvt-compil > > +++ e.c > > @@ -0,0 +1,48 @@ > > +/* { dg-do assemble { target { aarch64*-*-* } } } */ > > The

Re: [committed] libstdc++: P1964R2 Wording for boolean-testable

2020-02-18 Thread Jonathan Wakely
On 17/02/20 22:27 +0100, Tim Song wrote: On Mon, Feb 17, 2020 at 12:34 PM Jonathan Wakely wrote: This removes the complicated std::boolean concept, as agreed in Prague. * include/bits/ranges_algo.h (__find_fn, __find_first_of_fn) (__adjacent_find_fn): Cast result of predicate

Re: [PATCH] Add c++2a binary_semaphore

2020-02-18 Thread Sebastian Huber
Hello, On 18/02/2020 07:46, Thomas Rodgers wrote: This patch adds the c++2a semaphore header and binary_semaphore type. The implementation is not complete, this patch is just to solicit initial feedback. how do you plan to implement the binary semaphores? For example, do you want to add the

Re: [PATCH 1/2] libstdc++: P1243R4 Rangify new algorithms

2020-02-18 Thread Jonathan Wakely
On 17/02/20 17:00 -0500, Patrick Palka wrote: This adds rangified overloads for for_each_n, sample and clamp as per P1243R4. libstdc++-v3/ChangeLog: P1243R4 * include/bits/ranges_algo.h (for_each_n_result, __for_each_n_fn, for_each_n, __sample_fn, sample, __clamp_fn, cla

Re: [GCC][PATCH][AArch64] ACLE intrinsics for BFCVTN, BFCVTN2 (AArch64 AdvSIMD) and BFCVT (AArch64 FP)

2020-02-18 Thread Richard Sandiford
Tamar Christina writes: > Hi Richard, > >> ..ffb5305e2e5ea1aadae07e82f >> d8e >> > d6f9f247c1a9 >> > --- /dev/null >> > +++ b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/bfcvt-compil >> > +++ e.c >> > @@ -0,0 +1,48 @@ >> > +/* { dg-do assemble { targ

Re: [PATCH 2/2] libstdc++: P2106R0 Alternative wording for GB315 and GB316

2020-02-18 Thread Jonathan Wakely
On 17/02/20 17:00 -0500, Patrick Palka wrote: libstdc++-v3/ChangeLog: P2106R0 * include/bits/ranges_algo.h (in_fun_result): New. (for_each_result, for_each_n_result): Change into an alias of in_fun_result. (in_in_result): New. (mismatch_result): Ch

Re: [PATCH] Compare more sensitive FIX_TRUNC_EXPR in IPA ICF.

2020-02-18 Thread Martin Liška
On 2/18/20 11:19 AM, Richard Biener wrote: On Mon, Feb 17, 2020 at 4:21 PM Martin Liška wrote: Hi. The patch is extension of 446096148ca9775cb56f9ee924fa283babcd0b76 commit where we need to handle FIX_TRUNC_EXPR in compare_gimple_assign. Patch can bootstrap on x86_64-linux-gnu and survives r

Re: [PATCH] Compare more sensitive FIX_TRUNC_EXPR in IPA ICF.

2020-02-18 Thread Richard Biener
On Tue, Feb 18, 2020 at 3:00 PM Martin Liška wrote: > > On 2/18/20 11:19 AM, Richard Biener wrote: > > On Mon, Feb 17, 2020 at 4:21 PM Martin Liška wrote: > >> > >> Hi. > >> > >> The patch is extension of 446096148ca9775cb56f9ee924fa283babcd0b76 commit > >> where we need to handle FIX_TRUNC_EXPR

[AArch64] Move vmull_* to intrinsics

2020-02-18 Thread James Greenhalgh
Hi, As title, move some arm_neon.h functions which currently use assembly over to intrinsics. Bootstrapped and tested on aarch64-none-linux-gnu. OK, if so can someone please apply on my behalf? Thanks, James --- gcc/ 2020-02-18 James Greenhalgh * config/aarch64/aarch64-simd-built

Re: [PR47785] COLLECT_AS_OPTIONS

2020-02-18 Thread Richard Biener
On Tue, Feb 18, 2020 at 1:52 PM Prathamesh Kulkarni wrote: > > On Mon, 17 Feb 2020 at 19:52, Richard Biener > wrote: > > > > On Mon, Feb 17, 2020 at 10:28 AM Prathamesh Kulkarni > > wrote: > > > > > > On Thu, 6 Feb 2020 at 20:03, Prathamesh Kulkarni > > > wrote: > > > > > > > > On Thu, 6 Feb 2

Re: [PATCH] Add c++2a binary_semaphore

2020-02-18 Thread Jonathan Wakely
On 18/02/20 01:46 -0500, Thomas Rodgers wrote: This patch adds the c++2a semaphore header and binary_semaphore type. The implementation is not complete, this patch is just to solicit initial feedback. Here is some initial feedback on comments and whitespace :-) diff --git a/libstdc++-v3/incl

Re: [PATCH] Add c++2a binary_semaphore

2020-02-18 Thread Jonathan Wakely
On 18/02/20 14:48 +0100, Sebastian Huber wrote: Hello, On 18/02/2020 07:46, Thomas Rodgers wrote: This patch adds the c++2a semaphore header and binary_semaphore type. The implementation is not complete, this patch is just to solicit initial feedback. how do you plan to implement the binary

[PATCH] Do not propagate self-dependent value (PR ipa/93763)

2020-02-18 Thread Feng Xue OS
Currently, for self-recursive call, we never use value originated from non-passthrough jump function as source to avoid propagation explosion, but self-dependent value is missed. This patch is made to fix the bug. Bootstrapped/regtested on x86_64-linux and aarch64-linux. Feng --- 2020-02-18 Fe

Ping: [PATCH] Fix bug in recursiveness check for function to be cloned (ipa/pr93707)

2020-02-18 Thread Feng Xue OS
Thanks, Feng From: Tamar Christina Sent: Monday, February 17, 2020 4:44 PM To: Feng Xue OS; Martin Jambor; Jan Hubicka; gcc-patches@gcc.gnu.org Cc: nd Subject: RE: [PATCH] Fix bug in recursiveness check for function to be cloned (ipa/pr93707) Hi Feng, T

Re: One more patch for PR91333

2020-02-18 Thread Vladimir Makarov
On 2/17/20 10:08 AM, Maxim Kuvyrkov wrote: Hi Vladimir, This patch increases code size at -Os on arm-linux-gnueabihf by 1% (with no code-size reductions) on several SPEC CPU2006 benchmarks: 400.perlbench,perlbench_base.default ,580842,583842 429.mcf,mcf_base.default

Re: gcov: reduce code quality loss by reproducible topn merging [PR92924]

2020-02-18 Thread Martin Liška
On 1/30/20 5:13 PM, Jan Hubicka wrote: @@ -330,7 +334,7 @@ stream_out_histogram_value (struct output_block *ob, histogram_value hist) /* When user uses an unsigned type with a big value, constant converted to gcov_type (a signed type) can be negative. */ gcov_type value = hist->hvalue.counter

Re: One more patch for PR91333

2020-02-18 Thread Maxim Kuvyrkov
> On Feb 18, 2020, at 6:30 PM, Vladimir Makarov wrote: > > On 2/17/20 10:08 AM, Maxim Kuvyrkov wrote: >> Hi Vladimir, >> >> This patch increases code size at -Os on arm-linux-gnueabihf by 1% (with no >> code-size reductions) on several SPEC CPU2006 benchmarks: >> >> 400.perlbench,perlbench_bas

[PATCH] sra: Avoid totally scalarizing overallping field_decls (PR93667)

2020-02-18 Thread Martin Jambor
Hi, [[no_unique_address]] C++ attribute can cause two fields of a RECORD_TYPE overlap, which currently confuses the totally scalarizing code into creating invalid access tree. For GCC 10, I'd like to simply disable total scalarization of types where this happens. For GCC 11 I'll write down a TOD

[PATCH] sra: Do not create zero sized accesses (PR93776)

2020-02-18 Thread Martin Jambor
Hi, SRA can get a bit confused with zero-sized accesses like the one in the testcase. Since there is nothing in the access, nothing is scalarized, but we can get order of the structures wrong, which the verifier is not happy about. Fixed by simply ignoring such accesses. Bootstrapped and tested

Re: [PATCH] add -Wmismatched-tags (PR 61339)

2020-02-18 Thread Martin Sebor
On 2/18/20 1:41 AM, Stephan Bergmann wrote: On 03/12/2019 22:49, Martin Sebor wrote: I added another warning: -Wredundant-tags to point out instances where the class-key or enum-key can safely be dropped. Both warnings are off by default. I think -Wredundant-tags would be more useful if it did

Re: [PATCH] sra: Do not create zero sized accesses (PR93776)

2020-02-18 Thread Richard Biener
On February 18, 2020 4:56:35 PM GMT+01:00, Martin Jambor wrote: >Hi, > >SRA can get a bit confused with zero-sized accesses like the one in >the testcase. Since there is nothing in the access, nothing is >scalarized, but we can get order of the structures wrong, which the >verifier is not happy

Re: [PATCH] sra: Avoid totally scalarizing overallping field_decls (PR93667)

2020-02-18 Thread Richard Biener
On February 18, 2020 4:56:08 PM GMT+01:00, Martin Jambor wrote: >Hi, > >[[no_unique_address]] C++ attribute can cause two fields of a >RECORD_TYPE overlap, which currently confuses the totally scalarizing >code into creating invalid access tree. For GCC 10, I'd like to >simply disable total scal

[PATCH] testsuite/gcc.dg/strcmpopt_6.c: Add space in array for terminator.

2020-02-18 Thread Jon Beniston
Hi, The patch adds space for the string terminator, as the function is called with test_strcpy_strcmp_abc ("abcd") ChangeLog gcc/testsuite 2020-02-18 Jon Beniston * gcc.dg/strcmpopt_6.c: Add space in array for terminator. diff --git a/gcc/testsuite/gcc.dg/strcmpopt_6.c b/gcc/testsui

Re: [GCC][PATCH][AArch64] Add bfloat16 vldn/vstn intrinsics

2020-02-18 Thread Richard Sandiford
Thanks. When trying a bootstrap locally I get: include/arm_neon.h:34709:38: error: cannot convert ‘const __bf16*’ to ‘const __fp16*’ 34709 | __o = __builtin_aarch64_ld1x2v4hf ((const __builtin_aarch64_simd_bf *) __a); | ^

[PATCH] Fix -save-temp leaking files in /tmp and possible data loss in signal handler

2020-02-18 Thread Bernd Edlinger
Hi, I noticed that my /tmp directory gets clobbered with many *.ld/*.le files whenever the test suite runs. I tracked that down to a bug in the collect2 and lto-wrapper executable, which happens when -save-temps is used. As I tunrs out, that these .ld- and .le-files are no longer used, so I re

Re: original TDK & MURATA components with ex-factory price

2020-02-18 Thread Lisa
Dear Customers, Good day! We are a distributor for electronic components, including ICs, Transistors, Diodes, Resistors, Capacitors, and so on. If you need any parts, please send us inquiries, we'll offer you more better price and more better service! Thank you! -

Re: [PATCH] testsuite/gcc.dg/strcmpopt_6.c: Add space in array for terminator.

2020-02-18 Thread Martin Sebor
On 2/18/20 9:55 AM, Jon Beniston wrote: Hi, The patch adds space for the string terminator, as the function is called with test_strcpy_strcmp_abc ("abcd") That looks right. Please go ahead and commit it. Thanks! Martin ChangeLog gcc/testsuite 2020-02-18 Jon Beniston * gcc.dg

[committed 1/4] libstdc++: P2116R0 Remove tuple-like protocol support from fixed-extent span

2020-02-18 Thread Jonathan Wakely
Following this change it's no longer possible to use std::span with structured bindings or with the tuple-like API. It will probably come back for C++23 though. P2116R0 Remove tuple-like protocol support from fixed-extent span * include/std/span (get, tuple_size, tuple_element): Re

[committed 2/4] libstdc++: Reorder declarations of std::span members

2020-02-18 Thread Jonathan Wakely
I find it easier to work with this class when the declarations match the order in the C++2a working paper. There's no need to use long, descriptive template parameter names like _ContiguousIterator when the parameter is already constrained by the std::contiguous_iterator concept. This is also con

[committed 3/4] libstdc++: Fix and simplify constraints on std::span constructors

2020-02-18 Thread Jonathan Wakely
This makes the constraints consistent with the pre-Prague working paper. * include/std/span (span::__is_compatible_array): Simplify alias template by using requires-clause. (span::__is_compatible_ref): New alias template for constraining constructors. (span::__is_compatib

[committed 4/4] libstdc++: P1976R2 Fixed-size span construction from dynamic range

2020-02-18 Thread Jonathan Wakely
This includes fixes for first, last, as_bytes and as_writable_bytes which were missing from the paper. * include/std/span (__cpp_lib_span): Update value. (span(It, size_type), span(It, End)): Make conditionally explicit. Add assertion. (span(R&&), span(const span&)

Re: [committed] libstdc++: Implement "Safe Integral Comparisons" (P0586R2)

2020-02-18 Thread Jonathan Wakely
On 18/02/20 14:04 +0100, Christophe Lyon wrote: Hi, On Mon, 17 Feb 2020 at 14:22, Jonathan Wakely wrote: * include/std/type_traits (__is_standard_integer): New helper trait. * include/std/utility (cmp_equal, cmp_not_equal, cmp_less, cmp_greater) (cmp_less_equal, cmp_gr

[PATCH] libstdc++: P1983R0 Wording for GB301, US296, US292, US291, and US283

2020-02-18 Thread Patrick Palka
Among other changes, P1983R0 resolves LWG 3278 in a different way, so this patch also reverts the already-applied change of LWG 3278. The wording for US283 has already been applied it seems. libstdc++-v3/ChangeLog: P1983R0 Wording for GB301, US296, US292, US291, and US283 * inclu

Re: [PATCH] libstdc++: P1983R0 Wording for GB301, US296, US292, US291, and US283

2020-02-18 Thread Patrick Palka
On Tue, 18 Feb 2020, Patrick Palka wrote: > Among other changes, P1983R0 resolves LWG 3278 in a different way, so this > patch > also reverts the already-applied change of LWG 3278. > > The wording for US283 has already been applied it seems. > > libstdc++-v3/ChangeLog: > > P1983R0 Wordi

[PATCH] only handle true class-keys in -Wredundant-tags (PR 93801)

2020-02-18 Thread Martin Sebor
The -Wredundant-tags warning, new in GCC 10, issues false positives for some declarations involving typename. Typename isn't a C++ class-key so the warning is not intended in these cases. Attached is a simple fix tested on x86_64-linux. Martin PR c++/93801 - False -Wmismatched-tags upon redunda

Re: [patch, libfortran] Fix race condition in asynchronous I/O

2020-02-18 Thread Thomas Koenig
Now committed to trunk after Jerry's OK, as https://gcc.gnu.org/g:3fe1910509e32d611b3a7b8503502103bc53b5e4 I have to say I still have trouble establishing a git workflow which works smoothly. You will notice an "asdf" in the commit message which was not really meant to be there... Regards

libgo patch committed: Update -DGOPKGPATH to current pkgpath encoding

2020-02-18 Thread Ian Lance Taylor
This libgo patch changes the go tool to use the current pkgpath encoding when invoking the C compiler or assembler with -DGOPKGPATH. The GOPKGPATH macro is used to select the right exported name for a function called from Go code, so the pkgpath encoding needs to match. This change will need to be

Re: [PATCH 3/3] libstdc++: Implement C++20 range adaptors

2020-02-18 Thread Stephan Bergmann
On 18/02/2020 12:56, Jonathan Wakely wrote: Does this solve the problem, and work with both compilers? diff --git a/libstdc++-v3/include/std/ranges b/libstdc++-v3/include/std/ranges index b9ac528fdff..481ba75ee5e 100644 --- a/libstdc++-v3/include/std/ranges +++ b/libstdc++-v3/include/std/range

Re: [PATCH] i18n: Fix translation of --help [PR93759]

2020-02-18 Thread Joseph Myers
On Tue, 18 Feb 2020, Jakub Jelinek wrote: > Hi! > > The first two hunks make sure we actually translate what has been marked > for translation, i.e. the cl_options[...].help strings, rather than those > strings ammended in various ways, like: > _("%s Same as %s."), help, ... > or > "%s %s", hel

[committed] c++: Fix array-init1.C for ILP32 [PR93817]

2020-02-18 Thread Marek Polacek
I only tested LP64 targets and missed this maybe-long unsigned int. Tested with GXX_TESTSUITE_STDS=98,11,14,17,2a make check-c++ RUNTESTFLAGS='--target_board=unix\{-m32,-m64\} dg.exp=array-init1.C' 2020-02-18 Marek Polacek PR c++/93817 * g++.dg/diagnostic/array-init1.C: Fix f

Re: [PATCH] c++: Fix poor diagnostic for array initializer [PR93710]

2020-02-18 Thread Marek Polacek
On Mon, Feb 17, 2020 at 02:11:59PM +0100, Christophe Lyon wrote: > On Wed, 12 Feb 2020 at 21:06, Marek Polacek wrote: > > > > A small improvement for an error in build_user_type_conversion_1: > > instead of > > > > array-init1.C:11:1: error: conversion from ‘long int’ to ‘A’ is ambiguous > >11

Re: [AArch64] Move vmull_* to intrinsics

2020-02-18 Thread Richard Sandiford
James Greenhalgh writes: > Hi, > > As title, move some arm_neon.h functions which currently use assembly over > to intrinsics. > > Bootstrapped and tested on aarch64-none-linux-gnu. > > OK, if so can someone please apply on my behalf? LGTM thanks, pushed. Richard > Thanks, > James > > --- > gcc

Re: [PR47785] COLLECT_AS_OPTIONS

2020-02-18 Thread Prathamesh Kulkarni
On Tue, 18 Feb 2020 at 19:40, Richard Biener wrote: > > On Tue, Feb 18, 2020 at 1:52 PM Prathamesh Kulkarni > wrote: > > > > On Mon, 17 Feb 2020 at 19:52, Richard Biener > > wrote: > > > > > > On Mon, Feb 17, 2020 at 10:28 AM Prathamesh Kulkarni > > > wrote: > > > > > > > > On Thu, 6 Feb 2020

Re: [patch, fortran] PR93486 - ICE on valid with nested submodules and long submodule names

2020-02-18 Thread Andrew Benson
*ping* On Tuesday, January 28, 2020 4:45:59 PM PST Andrew Benson wrote: > I opened PR93486 for this problem: > > The following causes an ICE with revision > ad690d79cfbb905c5546c9333c5fd089d906505b: > > module ivs > interface l > module procedure l_ > end interface l > contains > func

Re: [PATCH] RISC-V: Using fmv.x.w/fmv.w.x rather than fmv.x.s/fmv.s.x

2020-02-18 Thread Jim Wilson
On Mon, Feb 17, 2020 at 9:57 PM Kito Cheng wrote: > * config/riscv/riscv.c (riscv_output_move) Using fmv.x.w/fmv.w.x > rather than fmv.x.s/fmv.s.x. Looks good to me also. By the way, since you are listed as one of the riscv port maintainers, you could make changes like this witho

Re: [PATCH 3/3] libstdc++: Implement C++20 range adaptors

2020-02-18 Thread Jonathan Wakely
On 18/02/20 21:11 +0100, Stephan Bergmann wrote: On 18/02/2020 12:56, Jonathan Wakely wrote: Does this solve the problem, and work with both compilers? diff --git a/libstdc++-v3/include/std/ranges b/libstdc++-v3/include/std/ranges index b9ac528fdff..481ba75ee5e 100644 --- a/libstdc++-v3/inclu

Re: [PATCH] libstdc++: P1983R0 Wording for GB301, US296, US292, US291, and US283

2020-02-18 Thread Jonathan Wakely
On 18/02/20 14:31 -0500, Patrick Palka wrote: On Tue, 18 Feb 2020, Patrick Palka wrote: Among other changes, P1983R0 resolves LWG 3278 in a different way, so this patch also reverts the already-applied change of LWG 3278. The wording for US283 has already been applied it seems. libstdc++-v3/C

[PATCH] avoid issuing -Wredundant-tags in shared C/C++ code in headers (PR 93804)

2020-02-18 Thread Martin Sebor
PR 93804 points out that issuing -Wredundant-tags for declarations in C headers included in C++ isn't helpful because the tags cannot be removed without breaking C programs that depend on the headers. Attached is a patch that avoids the warning in these cases tested on x86_64-linux. While strict

Re: [PATCH] testsuite/strlenopt-81.c: Add target limitation.

2020-02-18 Thread Jim Wilson
On Sun, Feb 16, 2020 at 9:02 PM Kito Cheng wrote: > It cause the __builtin_strlen not optimized/folded in test_local_cpy_4, > and the reason is blocked by __builtin_memcpy, it's same issue in > strlenopt-80.c, so I there is two way to fix this issue: Another possible solution is to use { dg-re

Re: [PATCH]Several intrinsic macros lack a closing parenthesis[PR93274]

2020-02-18 Thread Hongtao Liu
On Tue, Feb 18, 2020 at 7:00 PM Hongtao Liu wrote: > > On Tue, Feb 18, 2020 at 4:24 PM Uros Bizjak wrote: > > > > > > > > On Thu, Feb 13, 2020 at 9:39 AM Uros Bizjak wrote: > >> > >> > Changelog > >> > gcc/ > >> >* config/i386/avx512vbmi2intrin.h > >> >(_mm512_[,mask_,maskz_]shrd

Re: [PATCH] RISC-V: Using fmv.x.w/fmv.w.x rather than fmv.x.s/fmv.s.x

2020-02-18 Thread Kito Cheng
Committed. Hi Jim: Thanks for your review and reply, I'll commit directly for such simple patch in future :) On Wed, Feb 19, 2020 at 7:33 AM Jim Wilson wrote: > > On Mon, Feb 17, 2020 at 9:57 PM Kito Cheng wrote: > > * config/riscv/riscv.c (riscv_output_move) Using fmv.x.w/fmv.w.x > >

[PATCH] RISC-V: Adjust floating point code gen for LTGT compare

2020-02-18 Thread Kito Cheng
- Using gcc.dg/torture/pr91323.c as testcase, so no new testcase introduced. - We use 3 eq compare for LTGT compare before, in order to prevent exception flags setting when any input is NaN. - According latest GCC document LTGT and discussion on pr91323 LTGT should signals on NaNs, li