Re: [Darwin, testsuite, committed] Fix Wnonnull on Darwin.

2019-10-30 Thread Iain Sandoe
Iain Sandoe wrote: > Iain Sandoe wrote: > >> Martin Sebor wrote: >> >>> On 10/20/2019 07:27 AM, Iain Sandoe wrote: Martin Sebor wrote: > On 10/19/19 2:56 AM, Iain Sandoe wrote: >> Andreas Schwab wrote: >>> On Okt 19 2019, Iain Sandoe wrote: >>> This test has

Re: [C++ PATCH] Implement P1073R3: Immediate functions (PR c++/88335)

2019-10-30 Thread Jason Merrill
On 10/24/19 7:47 AM, Jakub Jelinek wrote: On Tue, Oct 22, 2019 at 10:57:42AM -0400, Jason Merrill wrote: So, do you prefer to do it the other way during build_cxx_call? It seems more straightforward. I've tried this approach, but am running into issues: 1) the normal constructors aren't an i

Re: [RFC PATCH] targetm.omp.device_kind_arch_isa and OpenMP declare variant kind/arch/isa handling

2019-10-30 Thread Segher Boessenkool
On Tue, Oct 29, 2019 at 11:57:40PM +0100, Jakub Jelinek wrote: > On Tue, Oct 29, 2019 at 05:40:11PM -0500, Segher Boessenkool wrote: > > On Tue, Oct 29, 2019 at 06:15:31PM +0100, Jakub Jelinek wrote: > > There already are a lot of different ways to get information about the > > execution environmen

Re: [PATCH 2/2] Remove cgraph_local_info structure.

2019-10-30 Thread Joseph Myers
This appears to have broken the build for Arm. /scratch/jmyers/glibc-bot/src/gcc/gcc/config/arm/arm.c: In function 'arm_pcs arm_get_pcs_model(const_tree, const_tree)': /scratch/jmyers/glibc-bot/src/gcc/gcc/config/arm/arm.c:5959:4: error: 'cgraph_local_info' was not declared in this scope cgr

Re: [C++ PATCH] P0784R7 constexpr new fixes (PR c++/91369)

2019-10-30 Thread Jakub Jelinek
On Wed, Oct 30, 2019 at 04:26:17PM -0400, Jason Merrill wrote: > OK. > Thanks, committed. > > Now, for the accepts invalid issues. > > From what I unde

Re: [PATCH 2/2] Remove cgraph_local_info structure.

2019-10-30 Thread Joseph Myers
On Wed, 30 Oct 2019, Joseph Myers wrote: > This appears to have broken the build for Arm. And probably bfin and c6x as well, based on grep, but my bot only covers glibc targets so doesn't test those. -- Joseph S. Myers jos...@codesourcery.com

Re: [PATCH V2] rs6000: Refine unroll factor with target unroll_adjust hook.

2019-10-30 Thread Segher Boessenkool
Hi! On Wed, Oct 30, 2019 at 11:34:42AM +0800, Jiufu Guo wrote: > In this patch, loop unroll adjust hook is introduced for powerpc. In this > hook, > we can do target related hueristic adjustment. For this patch, we tunned for > O2 to unroll small loops with small unroll factor (2 times), for othe

Re: [PATCH 2/2] Remove cgraph_local_info structure.

2019-10-30 Thread Jeff Law
On 10/30/19 4:06 PM, Joseph Myers wrote: > On Wed, 30 Oct 2019, Joseph Myers wrote: > >> This appears to have broken the build for Arm. > > And probably bfin and c6x as well, based on grep, but my bot only covers > glibc targets so doesn't test those. > bfin and c6x are definitely affected. My

Re: [PATCH] PR92090: Fix testcase failures by r276469

2019-10-30 Thread Segher Boessenkool
Hi! On Wed, Oct 30, 2019 at 02:02:44AM -0500, Xiong Hu Luo wrote: > -finline-functions is enabled by default for O2 since r276469, update the > test cases that inline small functions caused instruction number difference. > --- a/gcc/testsuite/gcc.target/powerpc/pr79439-1.c > +++ b/gcc/testsuite/g

[C++ PATCH] Fix a recent regression (PR c++/90947)

2019-10-30 Thread Jakub Jelinek
On Tue, Oct 29, 2019 at 04:26:14PM -0400, Jason Merrill wrote: > I think type_initializer_zero_p should return false if > CLASSTYPE_NON_AGGREGATE; we can't expect that value-initialization will have > the intended effect in that case. That indeed works for this testcase and doesn't break anything

[Patch,Fortran] PR92284 – gfc_desc_to_cfi_desc fixes

2019-10-30 Thread Tobias Burnus
Playing with the PR92284 test case revealed two issues related to gfc_desc_to_cfi_desc: * Access of uninitialized memory – copying the array bounds (in libgfortran) does not make sense for unallocted allocatables and nullified pointers. Hence, check for ".data == NULL". * There is a memory l

Re: [PATCH v2 1/2] RISC-V: Add shorten_memrefs pass

2019-10-30 Thread Jim Wilson
On Fri, Oct 25, 2019 at 10:40 AM Craig Blackmore wrote: > This patch aims to allow more load/store instructions to be compressed by > replacing a load/store of 'base register + large offset' with a new load/store > of 'new base + small offset'. If the new base gets stored in a compressed > registe

Re: [PATCH v2 1/2] RISC-V: Add shorten_memrefs pass

2019-10-30 Thread Jim Wilson
FYI the testcase I'm using to test the patch. Some of the functions get smaller, some of them get bigger, and some don't change in size but should when compiled for an rv64 target. Jim void store1z (int *array) { array[200] = 0; array[201] = 0; array[202] = 0; array[203] = 0; } void stor

Re: [PATCH v2 2/2] sched-deps.c: Avoid replacing address if it increases address cost

2019-10-30 Thread Jim Wilson
On Fri, Oct 25, 2019 at 10:40 AM Craig Blackmore wrote: > The sched2 pass undoes some of the addresses generated by the RISC-V > shorten_memrefs code size optimization (patch 1/2) and consequently increases > code size. This patch prevents sched-deps.c from changing an address if it is > expected

[C++ PATCH] PR c++/92268 - hard error satisfying return-type-requirement

2019-10-30 Thread Jason Merrill
Previously we would put the template arguments for the concept-check in a TEMPLATE_ID and then also pass them to constraints_satisfied_p, which meant that we would try to normalize the concept-check with the fully instantiated arguments, leading to sadness. Simply not passing the args to constrain

Re: [PATCH V2] rs6000: Refine unroll factor with target unroll_adjust hook.

2019-10-30 Thread Jiufu Guo
Segher Boessenkool writes: > Hi! > > On Wed, Oct 30, 2019 at 11:34:42AM +0800, Jiufu Guo wrote: >> In this patch, loop unroll adjust hook is introduced for powerpc. In this >> hook, >> we can do target related hueristic adjustment. For this patch, we tunned for >> O2 to unroll small loops with s

Re: [PATCH] PR c++/84810 - constraints on lambdas

2019-10-30 Thread Jason Merrill
On 10/30/19 7:20 AM, Jeff Chapman wrote: Hello, Attached is a patch that adds parsing of the optional requires-clause in a lambda-expression and lambda-declarator. Additionally, shorthand constraints from the template-parameter-list are now actually applied and constrain the synthesized operator

Re: [C++ PATCH] Fix a recent regression (PR c++/90947)

2019-10-30 Thread Jason Merrill
On 10/30/19 7:29 PM, Jakub Jelinek wrote: On Tue, Oct 29, 2019 at 04:26:14PM -0400, Jason Merrill wrote: I think type_initializer_zero_p should return false if CLASSTYPE_NON_AGGREGATE; we can't expect that value-initialization will have the intended effect in that case. That indeed works for t

<    1   2