Re: [PATCH] PR fortran/91497 -- Silence conversion warnings

2019-10-04 Thread Steve Kargl
On Fri, Oct 04, 2019 at 05:49:13PM +0200, Rainer Orth wrote: > > > The attach patch silences -Wconversion and -Wconversion-extra > > warnings that had previously been issued for explicit conversions > > (see testcase for examples). > > > > The patch has been tested on x86-*-freebsd. OK to commit?

Re: [PATCH] Fix -Wshadow=local warnings in defaults.h

2019-10-04 Thread Jeff Law
On 10/4/19 12:24 PM, Bernd Edlinger wrote: > Hi, > > this macro caused -Wshadow=local warnings in varasm.c with > the microblaze target. > > > Only built a bare metal cross compiler that was able to compile > libgcc for that target. > > Is it OK for trunk? > > > Thanks > Bernd. > > > > pat

Re: [PATCH] Fix -Wshadow=local warnings in defaults.h

2019-10-04 Thread Jeff Law
On 10/4/19 12:24 PM, Bernd Edlinger wrote: > Hi, > > this macro caused -Wshadow=local warnings in varasm.c with > the microblaze target. > > > Only built a bare metal cross compiler that was able to compile > libgcc for that target. > > Is it OK for trunk? > > > Thanks > Bernd. > > > > pat

Re: [PATCH] Fix -Wshadow=local warnings in elfos.h

2019-10-04 Thread Jeff Law
On 10/4/19 12:24 PM, Bernd Edlinger wrote: > Hi, > > these macros don't use reserved names for local variables. > This caused -Wshadow=local warnings in varasm.c IIRC. > > Fixed by using _lowercase reserved names for macro parameters. > > > Bootstrapped and reg-tested on x86_64-pc-linux-gnu. >

Re: [PR target/85401] Add test-cases

2019-10-04 Thread Jeff Law
On 10/4/19 1:43 PM, co...@sdf.org wrote: > On Tue, Oct 01, 2019 at 01:26:16PM -0600, Jeff Law wrote: >> On 9/30/19 2:45 PM, co...@sdf.org wrote: >>> On Mon, Sep 30, 2019 at 11:46:24AM -0400, Vladimir Makarov wrote: Yes, the patch is mostly ok.  You can commit it into the trunk after apply

Re: [PATCH] Improve _Safe_iterator _M_distance_to

2019-10-04 Thread François Dumont
I eventually committed the attach patch. The usage of __dp_sign_max_size will come later. François On 9/27/19 1:45 PM, Jonathan Wakely wrote: On 16/09/19 22:31 +0200, François Dumont wrote:     Here is the patch to improve _Safe_iterator<>::_M_get_distance_to implementation. I introduced a

Re: [PATCH] PR fortran/91959 -- Re-arrange matching of %FILL

2019-10-04 Thread Steve Kargl
On Fri, Oct 04, 2019 at 09:59:14PM +0200, Thomas Koenig wrote: > Hi Steve, > > > The attached patch has been tested on x86_64-*-freebsd. > > OK to commit. > > OK. > > Thanks a lot for the patch! > > Since this seems to be a regression to before when %FILL was introduced, > also OK to backport a

Re: [PATCH] Fix up sqrt(x) < c and sqrt(x) >= c match.pd folding (PR tree-optimization/91734, take 2)

2019-10-04 Thread Jeff Law
On 9/21/19 12:14 AM, Jakub Jelinek wrote: > On Mon, Sep 16, 2019 at 08:56:58AM +0200, Richard Biener wrote: >>> As mentioned in the PR, the sqrt (x) < c optimization into x < c*c >>> sometimes breaks the boundary case, if c2=c*c is inexact then in some cases >>> we need to optimize it into x <= c*c

Re: [PATCH] fold more string comparison with known result (PR 90879)

2019-10-04 Thread Jeff Law
On 9/23/19 4:14 PM, Martin Sebor wrote: > > Yes, it looks redundant.  I never remember which of these functions > ICE when their argument is not a constant (e.g., tree_int_cst_lt) > and which ones handle it gracefully (e.g., tree_int_cst_equal) so > I often check even when it isn't necessary.  It

Re: Add a simulate_builin_function_decl langhook

2019-10-04 Thread Jeff Law
On 9/26/19 6:04 AM, Richard Sandiford wrote: > Although it's possible to define the SVE intrinsics in a normal header > file, it's much more convenient to define them directly in the compiler. > This also speeds up compilation and gives better error messages. > > The idea is therefore for arm_sve.

Re: [Patch, GCC]Backporting r269039 to gcc8

2019-10-04 Thread Jeff Law
On 10/4/19 9:11 AM, Delia Burduv wrote: > Ping. Has anyone had a look at the patch? Please let me know if it is fine. I think it's fine to backport to the gcc-8 branch. Do you have commit access? jeff

[PATCHv2] Change the library search path when using --with-advance-toolchain

2019-10-04 Thread Tulio Magno Quites Machado Filho
Michael Meissner writes: > And then I built Spec 2006 and 2017 with my normal options on a power8 system > running Ubuntu and an older set of host libraries. If I have this patch > installed, it breaks linking some/all of the C++ and Fortran benchmarks, > because it finds the host C++/Fortran li

Re: [21/32] Remove global call sets: LRA

2019-10-04 Thread H.J. Lu
On Fri, Oct 4, 2019 at 11:03 AM H.J. Lu wrote: > > On Wed, Sep 11, 2019 at 12:14 PM Richard Sandiford > wrote: > > > > lra_reg has an actual_call_used_reg_set field that is only used during > > inheritance. This in turn required a special lra_create_live_ranges > > pass for flag_ipa_ra to set up

Add strftime format checking support for C2x %OB and %Ob (bug 82752)

2019-10-04 Thread Joseph Myers
C2x adds strftime %OB and %Ob formats, for alternative forms of month names (for mainly Slavic languages where a month name on its own is declined differently from a month name together with a date within that month). This patch adds corresponding format checking support. (glibc support for these

Re: [PATCH][RFC] Add new ipa-reorder pass

2019-10-04 Thread Jeff Law
On 9/19/19 2:33 AM, Martin Liška wrote: > Hi. > > Function reordering has been around for quite some time and a naive > implementation was also part of my diploma thesis some time ago. > Currently, the GCC can reorder function based on first execution, which > happens with PGO and LTO of course. K

[PATCH] PR fortran/89943 -- Duplicate BIND(c) allowed (?)

2019-10-04 Thread Steve Kargl
The attached patch allows the declaration of a BIND(C) module function or module subroutine to appear in a submodule (see testcases). Regression test was clean. OK to commit? Before a rubber stamped 'OK'. I do NOT use submodules. A submodule user needs to pipe up on the validity of the patch.

C++ PATCH for C++20 P0388R4 (conversions to arrays of unknown bounds) and CWG 1307 (c++/91364, c++/69531)

2019-10-04 Thread Marek Polacek
This patch implements P0388R4, Permit conversions to arrays of unknown bound, . CWG 393 allowed references to arrays of unknown bound and this C++20 feature allows conversions like void f(int(&)[]); int arr[1]; void g() { f(arr); } int(&r)[] = arr; The proposal

[PATCH] PR fortran/47054 -- Don't search parent namespace for symbol

2019-10-04 Thread Steve Kargl
I plan to commit this as obviously correct tomorrow morning. However, as the bug has been open for nearly 9 years, I give anyone reading this a chance to speak up. 2019-10-04 Steven G. Kargl PR fortran/47045 * decl.c (variable_decl): Do not search parent namespace for symbol. 2019-10-04 St

Re: [SVE] PR91532

2019-10-04 Thread Prathamesh Kulkarni
On Fri, 4 Oct 2019 at 12:18, Richard Biener wrote: > > On Thu, 3 Oct 2019, Prathamesh Kulkarni wrote: > > > On Wed, 2 Oct 2019 at 12:28, Richard Biener wrote: > > > > > > On Wed, 2 Oct 2019, Prathamesh Kulkarni wrote: > > > > > > > On Wed, 2 Oct 2019 at 01:08, Jeff Law wrote: > > > > > > > > > >

Re: [PATCH] Fix -Wshadow=local warnings in rtl.h

2019-10-04 Thread Bernd Edlinger
On 10/3/19 5:25 PM, Jakub Jelinek wrote: > On Thu, Oct 03, 2019 at 03:17:47PM +, Bernd Edlinger wrote: >> Hi, >> >> this fixes -Wshadow=local warnings in the RTL_FLAG_CHECKx macros, >> which happen when this macro is used recursively in a macro >> argument. The __typeof (RTX) const _rtx in

Re: [PATCH] Fix -Wshadow=local warnings in rtl.h

2019-10-04 Thread Bernd Edlinger
On 10/4/19 10:26 AM, Segher Boessenkool wrote: > On Thu, Oct 03, 2019 at 05:25:55PM +0200, Jakub Jelinek wrote: >> On Thu, Oct 03, 2019 at 03:17:47PM +, Bernd Edlinger wrote: >>> this fixes -Wshadow=local warnings in the RTL_FLAG_CHECKx macros, >>> which happen when this macro is used recursive

Re: [PATCH] Fix -Wshadow=local warnings in defaults.h

2019-10-04 Thread Bernd Edlinger
On 10/4/19 10:23 PM, Jeff Law wrote: > On 10/4/19 12:24 PM, Bernd Edlinger wrote: >> Hi, >> >> this macro caused -Wshadow=local warnings in varasm.c with >> the microblaze target. >> >> >> Only built a bare metal cross compiler that was able to compile >> libgcc for that target. >> >> Is it OK for

Re: [PATCH] Fix -Wshadow=local warnings in elfos.h

2019-10-04 Thread Bernd Edlinger
On 10/4/19 10:26 PM, Jeff Law wrote: > On 10/4/19 12:24 PM, Bernd Edlinger wrote: >> Hi, >> >> these macros don't use reserved names for local variables. >> This caused -Wshadow=local warnings in varasm.c IIRC. >> >> Fixed by using _lowercase reserved names for macro parameters. >> >> >> Bootstr

[PATCH, OBVIOUS] Fix -Wshadow=local warnings in gcc/[a-c]*.c

2019-10-04 Thread Bernd Edlinger
Hi, this fixes -Wshadow=local warnings in the following files: M gcc/asan.c M gcc/attribs.c M gcc/auto-inc-dec.c M gcc/bb-reorder.c M gcc/builtins.c M gcc/caller-save.c M gcc/calls.c M gcc/cfgbuild.c M gcc/cfg.c M gcc/cfgcleanup.c M

<    1   2