Re: Remove nonoverlapping_component_refs_of_decl_p

2019-06-17 Thread Jan Hubicka
> > get_alias_set already handles VCEs properly. Btw I've said I see - i keep thinking of get_alias_set as a simple accessor to type's alias set which it is not. It may make sense to separate these two later. > BIT_FIELD_REF has the same issue but you didn't include that > case below. Sorry,

[Ada] Workaround for PR ada/80590

2019-06-17 Thread Arnaud Charlet
This patch avoids an unnecessary exception propagation in the compiler when handling the "delay" construct. This should avoid the crashes/hangs observed in PR 80590 on g-exptty.adb among others. Note that the proper fix for this PR is to do a full bootstrap of GCC, since the issue is that GNAT swi

Re: [MIPS] Fix for the wrong argument sequence in MSA builtin for FMADD/MADDV family.

2019-06-17 Thread Dragan Mladjenovic
Sorry for the late response. I've checked the patch on gcc-9 and gcc-8 branches with mips{el}-linux-gnu. There are no new regressions, as expected. Is this change still eligible for back-port ? From: Jeff Law Sent: Friday, May 31, 2019 11:41:35 PM To: Dragan

Re: Remove nonoverlapping_component_refs_of_decl_p

2019-06-17 Thread Richard Biener
On Mon, 17 Jun 2019, Jan Hubicka wrote: > > > > get_alias_set already handles VCEs properly. Btw I've said > > I see - i keep thinking of get_alias_set as a simple accessor to type's > alias set which it is not. It may make sense to separate these two > later. > > > BIT_FIELD_REF has the same

Re: Remove nonoverlapping_component_refs_of_decl_p

2019-06-17 Thread Jan Hubicka
> On Mon, 17 Jun 2019, Jan Hubicka wrote: > > > > > > > get_alias_set already handles VCEs properly. Btw I've said > > > > I see - i keep thinking of get_alias_set as a simple accessor to type's > > alias set which it is not. It may make sense to separate these two > > later. > > > > > BIT_FI

Re: [PATCH, sanitizer] Wrap rethrow_primary_exception (PR 87880).

2019-06-17 Thread Jonathan Wakely
On 16/06/19 20:58 +0200, Jakub Jelinek wrote: On Sun, Jun 16, 2019 at 07:54:42PM +0100, Iain Sandoe wrote: So, I guess, unless Jonathan has plans to add __cxa_rethrow_primary_exception during the 10 time-frame, it’s correct to exclude the symbol anyway and we should bump the so version and appl

Re: [PATCH] Avoid unnecessary inclusion of header

2019-06-17 Thread Jonathan Wakely
On 06/06/19 16:38 +0100, Jonathan Wakely wrote: This can greatly reduce the amount of preprocessed code that is included by other headers, because depends on which is huge. * include/std/array: Do not include . * include/std/optional: Include and instead of . Preproc

[build] Remove support for alternative Solaris 11.4 ld -V output

2019-06-17 Thread Rainer Orth
I've been informed that parsing of Solaris ld -V output doesn't work with Solaris sed. The problem is that the alternation used since [build] Cleanup Solaris linker version checks https://gcc.gnu.org/ml/gcc-patches/2017-11/msg00068.html isn't recognized by /usr/bin/sed and /usr/x

[PATCH] Remove dead code (PR ipa/90874).

2019-06-17 Thread Martin Liška
Hi. After r272037 change we have a leftover dead code in odr_type_p. Ready to be installed? Thanks, Martin gcc/ChangeLog: 2019-06-17 Martin Liska PR ipa/90874 * ipa-utils.h (odr_type_p): Remove dead code. --- gcc/ipa-utils.h | 1 - 1 file changed, 1 deletion(-) diff --git

Re: [PATCH v4 2/3] Add predict_doloop_p target hook

2019-06-17 Thread Richard Biener
On Mon, 17 Jun 2019, Kewen.Lin wrote: > Hi Segher and Bill, > > Thanks a lot for your review comments! I've updated the patch accordingly. > > The updated one attached. OK. I suppose all low-overhead loop instructions use a decrement to zero style iterator? Thanks, Richard.

Re: [PATCH] Remove dead code (PR ipa/90874).

2019-06-17 Thread Jan Hubicka
> Hi. > > After r272037 change we have a leftover dead code in odr_type_p. > > Ready to be installed? OK (it is obvious anyway:), thanks! Honza > Thanks, > Martin > > gcc/ChangeLog: > > 2019-06-17 Martin Liska > > PR ipa/90874 > * ipa-utils.h (odr_type_p): Remove dead code. > --

Re: Fix ICE due to commit for PR88834

2019-06-17 Thread Richard Sandiford
Kugan Vivekanandarajah writes: > Hi All, > > As pointed to me by Jeff, after committing patch to fix PR88834, some > tests are failing for target rx-elf. This is because in > preferred_mem_scale_factor we end up with mem_mode which is BLKmode > and hence GET_MODE_UNIT_SIZE returns zero. > > I have

Do not give up early on access path oracle

2019-06-17 Thread Jan Hubicka
Hi, while working on testcases for nonoverlapping_component_refs_p I run into issue that we often bypass it because the indirect-decl and indirect-indirect oracles give up if they manage to match bases and ranges_maybe_overlap_p return true. (one testcase is included in patch). The issue is that d

[PATCH] Add new micro-benchmark for string operations.

2019-06-17 Thread Martin Liška
Hi. I'm adding a micro-benchmark that Honza has been using for quite some time. Sample output: ./contrib/bench-stringop 64 1024 gcc memcpy block size libcall rep1noalg rep4noalg rep8noalg loop noalg unrlnoalg sse noalg bytePGO dynamicBEST 8

[PATCH] Handle '\0' in strcmp in RTL expansion (PR tree-optimization/90892).

2019-06-17 Thread Martin Liška
Hi. The function c_getstr returns string and length of the string. In inline_expand_builtin_string_cmp, we should consider situations where a string constant contains a zero character. In that case we have to shorten len[12]. Patch can bootstrap on x86_64-linux-gnu and survives regression tests.

Re: [PATCH] Handle '\0' in strcmp in RTL expansion (PR tree-optimization/90892).

2019-06-17 Thread Jakub Jelinek
On Mon, Jun 17, 2019 at 11:26:03AM +0200, Martin Liška wrote: > diff --git a/gcc/builtins.c b/gcc/builtins.c > index 3463ffb1539..917852071b9 100644 > --- a/gcc/builtins.c > +++ b/gcc/builtins.c > @@ -7142,6 +7142,20 @@ inline_expand_builtin_string_cmp (tree exp, rtx target) >const char *src_st

Re: [PATCH v4 2/3] Add predict_doloop_p target hook

2019-06-17 Thread Kewen.Lin
on 2019/6/17 下午4:51, Richard Biener wrote: > On Mon, 17 Jun 2019, Kewen.Lin wrote: > >> Hi Segher and Bill, >> >> Thanks a lot for your review comments! I've updated the patch accordingly. >> >> The updated one attached. > > OK. I suppose all low-overhead loop instructions use a decrement to zer

Re: [PATCH v4 2/3] Add predict_doloop_p target hook

2019-06-17 Thread Segher Boessenkool
On Mon, Jun 17, 2019 at 10:51:49AM +0200, Richard Biener wrote: > On Mon, 17 Jun 2019, Kewen.Lin wrote: > > > Hi Segher and Bill, > > > > Thanks a lot for your review comments! I've updated the patch accordingly. > > > > The updated one attached. > > OK. I suppose all low-overhead loop instruc

Re: Remove nonoverlapping_component_refs_of_decl_p

2019-06-17 Thread Jan Hubicka
Hi this is patch for BIT_FIELD_REFs on nonoverlapping_component_refs_p I comitted after testing on x86_64-linux Honza Index: ChangeLog === --- ChangeLog (revision 272379) +++ ChangeLog (working copy) @@ -1,3 +1,8 @@ +2019-06-17

Re: Review Hashtable extract node API

2019-06-17 Thread Jonathan Wakely
On 07/06/19 18:39 +0200, François Dumont wrote: On 6/5/19 6:22 PM, Jonathan Wakely wrote: On 04/06/19 19:19 +0200, François Dumont wrote: Hi     Here is a patch to enhance the _Hashtable extract node API and fix a FIXME request.     The enhancement to the extract node Api is that extract(co

Re: [PATCH, d]: Fix PR90261, FAIL: libphobos.phobos/std/file.d on CentOS 5.11, Linux 2.6.18

2019-06-17 Thread Uros Bizjak
Ping. On Wed, May 8, 2019 at 1:52 PM Uros Bizjak wrote: > > Hello! > > CentOS 5.11 (glibc 2.5) does not have utimensat function, so there is > no nanosecond precision of file times available. Currently, the test > fails with: > > /tmp/cc36u3o7.o: In function > `_D3std4file17__T8setTimesTAyaZ8setT

[COMMITTED] Improve PR64242 testcase

2019-06-17 Thread Wilco Dijkstra
Clear the input array to avoid the testcase accidentally passing with an incorrect frame pointer. Committed as obvious. ChangeLog: 2019-06-17 Wilco Dijkstra testsuite/ PR middle-end/64242 * gcc.c-torture/execute/pr64242.c: Improve test. -- diff --git a/gcc/testsuite/gcc.c-tor

Re: [ARM/FDPIC v5 00/21] FDPIC ABI for ARM

2019-06-17 Thread Christophe Lyon
ping^3 ? On Thu, 6 Jun 2019 at 14:36, Christophe Lyon wrote: > > Hi, > > If this makes review easier, here are the areas covered by the patches: > > - patches 1,3,4,7,8,9,10,12,21: target-specific > - patch 2: configure > - patch 5,6,11,13: generic parts, undef #if defined(__FDPIC__) > - patches

Re: [PATCH v4 2/3] Add predict_doloop_p target hook

2019-06-17 Thread Richard Biener
On June 17, 2019 11:59:30 AM GMT+02:00, Segher Boessenkool wrote: >On Mon, Jun 17, 2019 at 10:51:49AM +0200, Richard Biener wrote: >> On Mon, 17 Jun 2019, Kewen.Lin wrote: >> >> > Hi Segher and Bill, >> > >> > Thanks a lot for your review comments! I've updated the patch >accordingly. >> > >>

Re: Do not give up early on access path oracle

2019-06-17 Thread Richard Biener
On Mon, 17 Jun 2019, Jan Hubicka wrote: > Hi, > while working on testcases for nonoverlapping_component_refs_p I run into > issue > that we often bypass it because the indirect-decl and indirect-indirect > oracles > give up if they manage to match bases and ranges_maybe_overlap_p return true. >

Re: [nvptx] Fix missing mode warnings in nvptx.md, omp part

2019-06-17 Thread Alexander Monakov
On Mon, 17 Jun 2019, Tom de Vries wrote: > Hi Alexander, > > any comments? A couple suggestions (see below), but no serious concerns from my side. > --- a/gcc/config/nvptx/nvptx.c > +++ b/gcc/config/nvptx/nvptx.c > @@ -112,6 +112,17 @@ enum nvptx_data_area >DATA_AREA_MAX > }; > > +rtx >

Re: Do not give up early on access path oracle

2019-06-17 Thread Jan Hubicka
> > But part of the expensiveness we want to avoid is this > (repeated) walking of the ref tree... I was considering to pass contains_union_p down from one of earlier walks, but did not find suitable one for that... > > So... > > > + return !handled_component_p (ref2); > > +} > > + > > /* Ret

Re: Remove nonoverlapping_component_refs_of_decl_p

2019-06-17 Thread Jan Hubicka
Hi, this is patch for aliasing_component_refs_p and VCE. I also turned the refp to ref, but there are no changes relative to that. Bootstrapped/regtested x86_64-linux, OK? Honza * tree-ssa-alias.c (aliasing_component_refs_p): Consider only the access path from base to first VIEW_CO

Re: Do not give up early on access path oracle

2019-06-17 Thread Jan Hubicka
Hi, this is testcase for unions. It is somewhat artificial because nonoverlapping_component_refs is conservative about matching union fields and aliasing_component_refs_p resorts to offset/max_size test which of course suceeds. So I had to add the wrapping struct a (which is matched by the earlier

Re: [PATCH] Replace std::to_string for integers with optimized version

2019-06-17 Thread Jonathan Wakely
On 13/06/19 22:41 +0200, Christophe Lyon wrote: Hi, On Wed, 12 Jun 2019 at 16:54, Jonathan Wakely wrote: The std::to_chars functions from C++17 can be used to implement std::to_string with much better performance than calling snprintf. Only the __detail::__to_chars_len and __detail::__to_cha

Re: Do not give up early on access path oracle

2019-06-17 Thread Richard Biener
On Mon, 17 Jun 2019, Jan Hubicka wrote: > > > > But part of the expensiveness we want to avoid is this > > (repeated) walking of the ref tree... > > I was considering to pass contains_union_p down from one of > earlier walks, but did not find suitable one for that... > > > > So... > > > > > +

Re: Do not give up early on access path oracle

2019-06-17 Thread Jan Hubicka
> > Hmm, !maybe_eq () -> ! max_size1 == size1 -> max_size != size1 thus > I think && is correct if you want to disambiguate a[1].v2 and a[i].v1 > > But yes, if you don't want that then || is cheaper. Probably add > another testcase with one of the accesses with a constant index? Hmm, OK, withou

Re: *ping* Re: [PATCH] PR fortran/89103 - Allow blank format items in format strings

2019-06-17 Thread Mark Eggleston
On 12/06/2019 19:11, Steve Kargl wrote: On Tue, Jun 11, 2019 at 11:50:40AM +0200, Jakub Jelinek wrote: On Tue, Jun 11, 2019 at 10:30:59AM +0100, Mark Eggleston wrote:     Jim MacArthur     Mark Eggleston Two spaces before < instead of one. This is not a patch review, just comments: Mark

Re: [PATCH v4 2/3] Add predict_doloop_p target hook

2019-06-17 Thread Kewen.Lin
on 2019/6/17 下午8:08, Richard Biener wrote: > On June 17, 2019 11:59:30 AM GMT+02:00, Segher Boessenkool > wrote: >> On Mon, Jun 17, 2019 at 10:51:49AM +0200, Richard Biener wrote: >>> On Mon, 17 Jun 2019, Kewen.Lin wrote: >>> Hi Segher and Bill, Thanks a lot for your review comment

Re: Remove nonoverlapping_component_refs_of_decl_p

2019-06-17 Thread Richard Biener
On Mon, 17 Jun 2019, Jan Hubicka wrote: > Hi, > this is patch for aliasing_component_refs_p and VCE. > I also turned the refp to ref, but there are no changes relative > to that. > Bootstrapped/regtested x86_64-linux, OK? OK. Bonus points for wrong-code testcases involving these... like the fol

[PR c++/90754] name lookup ICE

2019-06-17 Thread Nathan Sidwell
It turned out qualify_lookup was rejecting non-decls, and hence the ordering of that call relative to other tests was significant. I've restored the relative ordering to that prior to my reimplementation of lookup_type_scope_1. applying to trunk. nathan -- Nathan Sidwell 2019-06-17 Nathan S

Re: Do not give up early on access path oracle

2019-06-17 Thread Richard Biener
On Mon, 17 Jun 2019, Jan Hubicka wrote: > > > > Hmm, !maybe_eq () -> ! max_size1 == size1 -> max_size != size1 thus > > I think && is correct if you want to disambiguate a[1].v2 and a[i].v1 > > > > But yes, if you don't want that then || is cheaper. Probably add > > another testcase with one of

Re: [PATCH v4 2/3] Add predict_doloop_p target hook

2019-06-17 Thread Richard Biener
On Mon, 17 Jun 2019, Kewen.Lin wrote: > on 2019/6/17 下午8:08, Richard Biener wrote: > > On June 17, 2019 11:59:30 AM GMT+02:00, Segher Boessenkool > > wrote: > >> On Mon, Jun 17, 2019 at 10:51:49AM +0200, Richard Biener wrote: > >>> On Mon, 17 Jun 2019, Kewen.Lin wrote: > >>> > Hi Segher and

Re: [Vectorizer] Support masking fold left reductions

2019-06-17 Thread Richard Sandiford
Sorry for the slow review. Alejandro Martinez Vicente writes: > diff --git a/gcc/tree-vect-loop.c b/gcc/tree-vect-loop.c > index 4942c69..7840ed8 100644 > --- a/gcc/tree-vect-loop.c > +++ b/gcc/tree-vect-loop.c > @@ -5881,6 +5881,31 @@ vect_expand_fold_left (gimple_stmt_iterator *gsi, tree > sca

Re: Remove nonoverlapping_component_refs_of_decl_p

2019-06-17 Thread Jan Hubicka
> On Mon, 17 Jun 2019, Jan Hubicka wrote: > > > Hi, > > this is patch for aliasing_component_refs_p and VCE. > > I also turned the refp to ref, but there are no changes relative > > to that. > > Bootstrapped/regtested x86_64-linux, OK? > > OK. > > Bonus points for wrong-code testcases involving

Re: Do not give up early on access path oracle

2019-06-17 Thread Jan Hubicka
> On Mon, 17 Jun 2019, Jan Hubicka wrote: > > > > > > > Hmm, !maybe_eq () -> ! max_size1 == size1 -> max_size != size1 thus > > > I think && is correct if you want to disambiguate a[1].v2 and a[i].v1 > > > > > > But yes, if you don't want that then || is cheaper. Probably add > > > another test

Re: [PATCH] PR libstdc++/90281 Fix string conversions for filesystem::path

2019-06-17 Thread Jonathan Wakely
On 30/04/19 16:06 +0100, Jonathan Wakely wrote: Fix several bugs in the encoding conversions for filesystem::path that prevent conversion of Unicode characters outside the Basic Multilingual Plane, and prevent returning basic_string specializations with alternative allocator types. The std::code

Re: [PATCH v4 2/3] Add predict_doloop_p target hook

2019-06-17 Thread Kewen.Lin
on 2019/6/17 下午9:44, Richard Biener wrote: > On Mon, 17 Jun 2019, Kewen.Lin wrote: > >> on 2019/6/17 下午8:08, Richard Biener wrote: >>> On June 17, 2019 11:59:30 AM GMT+02:00, Segher Boessenkool >>> wrote: On Mon, Jun 17, 2019 at 10:51:49AM +0200, Richard Biener wrote: > On Mon, 17 Jun 2

Re: Do not give up early on access path oracle

2019-06-17 Thread Richard Sandiford
Richard Biener writes: > On Mon, 17 Jun 2019, Jan Hubicka wrote: > >> > >> > But part of the expensiveness we want to avoid is this >> > (repeated) walking of the ref tree... >> >> I was considering to pass contains_union_p down from one of >> earlier walks, but did not find suitable one for tha

Re: Do not give up early on access path oracle

2019-06-17 Thread Jan Hubicka
> >> > > >> > A more stricter test would be > >> > > >> > if (!maybe_eq (max_size1, size1) && !maybe_eq (max_size2, size2)) > >> > return true; > >> > /* If there's a variable access in one of the refs fall through > >> >to access-path based disambiguation. */ > >>

[PATCH] Add 'noexcept' to std::lerp

2019-06-17 Thread Jonathan Wakely
* include/c_global/cmath (__lerp, lerp): Add noexcept (LWG 3201). Tested x86_64-linux, committed to trunk. commit 4b48ab1965d6d690f6b6b0bb55f48149d1cbbb25 Author: redi Date: Mon Jun 17 14:32:44 2019 + Add 'noexcept' to std::lerp * include/c_global/cmath (__l

Re: [patch][aarch64] add netbsd/aarch64 target

2019-06-17 Thread Richard Earnshaw (lists)
On 14/06/2019 16:38, co...@sdf.org wrote: > Hi folks, > > This patch adds support for netbsd/aarch64. > It would be nice to have it committed, please tell me if anything is > wrong. > > Thanks. > > Matthew Green > Maya Rashish > > gcc: > * config.gcc (aarch64*-*-netbsd*): New target. >

Re: [nvptx] Fix missing mode warnings in nvptx.md, omp part

2019-06-17 Thread Tom de Vries
On 17-06-19 14:35, Alexander Monakov wrote: > On Mon, 17 Jun 2019, Tom de Vries wrote: > >> Hi Alexander, >> >> any comments? > > A couple suggestions (see below), but no serious concerns from my side. > >> --- a/gcc/config/nvptx/nvptx.c >> +++ b/gcc/config/nvptx/nvptx.c >> @@ -112,6 +112,17 @@

Re: C++ PATCH for c++/60364 - noreturn after first decl not diagnosed (v2)

2019-06-17 Thread Martin Sebor
On 6/16/19 10:10 AM, Marek Polacek wrote: On Sat, Jun 15, 2019 at 10:39:13AM -0400, Marek Polacek wrote: On Sat, Jun 15, 2019 at 04:33:26PM +0200, Jakub Jelinek wrote: On Sat, Jun 15, 2019 at 10:29:17AM -0400, Marek Polacek wrote: [dcl.attr.noreturn] says "The first declaration of a function s

Re: [nvptx] Fix missing mode warnings in nvptx.md, omp part

2019-06-17 Thread Jakub Jelinek
On Mon, Jun 17, 2019 at 04:53:24PM +0200, Tom de Vries wrote: > Updated accordingly, and committed as attached. Note, current trunk allows one to define expanders that take mode as the first argument, so you could (define_insn "@set_softstack_" [(unspec [(match_operand:P 0 "nvptx_register_operan

Re: C++ PATCH for c++/60364 - noreturn after first decl not diagnosed (v3)

2019-06-17 Thread Jakub Jelinek
On Sun, Jun 16, 2019 at 12:36:58PM -0400, Marek Polacek wrote: > On Sun, Jun 16, 2019 at 06:18:56PM +0200, Jakub Jelinek wrote: > > On Sun, Jun 16, 2019 at 12:10:37PM -0400, Marek Polacek wrote: > > > > Guess I will really have to make the changes to treat [[noreturn]] > > > > similarly > > > > to

Re: C++ PATCH for c++/83820 - excessive attribute arguments not detected

2019-06-17 Thread Martin Sebor
On 6/16/19 1:10 PM, Marek Polacek wrote: While messing with [[noreturn]] I also found out that we don't detect the case when an attribute specifier that takes no arguments contains an attribute-argument-clause. Bootstrapped/regtested on x86_64-linux, ok for trunk? 2019-06-16 Marek Polacek

[PATCH] Fix AIX test failure due to replacement operator delete

2019-06-17 Thread Jonathan Wakely
On AIX the sized delete defined in the library will call the non-sized delete defined in the library, not the replacement version defined in the test file. By also replacing sized delete we make the test pass everywhere. * testsuite/20_util/allocator/1.cc: Add sized delete, which fixes a

Re: [PATCH] aarch64: fix gcc.target/aarch64/pcs_attribute-2.c on non-gnu targets

2019-06-17 Thread Szabolcs Nagy
On 07/06/2019 17:03, Szabolcs Nagy wrote: > Move the ifunc symbol tests into a separate file with dg-require-ifunc. > And added a base pcs ifunc symbol to the test for completeness. > > gcc/testsuite/ChangeLog: > > 2019-06-07 Szabolcs Nagy > > * gcc.target/aarch64/pcs_attribute-2.c: Rem

Re: C++ PATCH for c++/83820 - excessive attribute arguments not detected

2019-06-17 Thread Jason Merrill
Ok. On Sun, Jun 16, 2019, 3:10 PM Marek Polacek wrote: > While messing with [[noreturn]] I also found out that we don't detect > the case when an attribute specifier that takes no arguments contains > an attribute-argument-clause. > > Bootstrapped/regtested on x86_64-linux, ok for trunk? > > 201

Re: Do not give up early on access path oracle

2019-06-17 Thread Richard Sandiford
Jan Hubicka writes: >> >> > >> >> > A more stricter test would be >> >> > >> >> > if (!maybe_eq (max_size1, size1) && !maybe_eq (max_size2, >> >> > size2)) >> >> > return true; >> >> > /* If there's a variable access in one of the refs fall through >> >> >t

[PATCH] i386: Separate costs of RTL expressions from costs of moves

2019-06-17 Thread H.J. Lu
processor_costs has costs of RTL expressions and costs of moves: 1. Costs of RTL expressions is computed as COSTS_N_INSNS which are used to generate RTL expressions with the lowest costs. Costs of RTL memory operation can be very close to costs of fast instructions to indicate fast memory operati

Re: Do not give up early on access path oracle

2019-06-17 Thread Richard Biener
On June 17, 2019 6:23:03 PM GMT+02:00, Richard Sandiford wrote: >Jan Hubicka writes: >>> >> > >>> >> > A more stricter test would be >>> >> > >>> >> >if (!maybe_eq (max_size1, size1) && !maybe_eq (max_size2, >size2)) >>> >> > return true; >>> >> > /* If there's a vari

RE: [patch][aarch64]: add usra and ssra combine patterns

2019-06-17 Thread Sylvia Taylor
Updating patch with missing scan-assembler checks. Cheers, Syl -Original Message- From: Sylvia Taylor Sent: 04 June 2019 12:24 To: James Greenhalgh Cc: Richard Earnshaw ; Marcus Shawcroft ; gcc-patches@gcc.gnu.org; nd Subject: RE: [patch][aarch64]: add usra and ssra combine patterns

Re: [PATCH, og9] Port OpenACC profiling interface to OG9

2019-06-17 Thread Thomas Schwinge
Hi Kwok! On Mon, 17 Jun 2019 14:27:46 +0100, Kwok Cheung Yeung wrote: > This is a straightforward port of the OpenACC profiling interface from > OG8 to OG9, with a few tweaks Thanks for looking into this. > to compensate for patches that have not > been carried over to OG9. Conceptually ACK

[C++ PATCH] PR c++/90875 - added -Wswitch-outside-range option.

2019-06-17 Thread Matthew Beliveau
This patch adds a new warning option: Wswitch-outside-range, so that users are able to selectively control the warning. The warning is enabled by default. Best, Matthew Beliveau Bootstrapped/regtested on x86_64-linux, ok for trunk? 2019-06-14 Matthew Beliveau PR c++/90875 - added -Wswitch-o

Re: [MIPS] Fix for the wrong argument sequence in MSA builtin for FMADD/MADDV family.

2019-06-17 Thread Jeff Law
On 6/17/19 1:44 AM, Dragan Mladjenovic wrote: > Sorry for the late response. > > > I've checked the patch on gcc-9 and gcc-8 branches with mips{el}-linux-gnu. > > There are no new regressions, as expected. > > > Is this change still eligible for back-port ? Yes, and I went ahead and backported

Re: [C++ PATCH] PR c++/90875 - added -Wswitch-outside-range option.

2019-06-17 Thread Jakub Jelinek
On Mon, Jun 17, 2019 at 01:26:37PM -0400, Matthew Beliveau wrote: > 2019-06-14 Matthew Beliveau > > PR c++/90875 - added -Wswitch-outside-range option > * doc/invoke.texi (Wswitch-outside-range): Document. > > * c-warn.c (c_do_switch_warnings): Implemented new Wswitch-o

Re: [C++ PATCH] PR c++/90875 - added -Wswitch-outside-range option.

2019-06-17 Thread Marek Polacek
Thanks for the patch. On Mon, Jun 17, 2019 at 01:26:37PM -0400, Matthew Beliveau wrote: > --- gcc/c-family/c.opt > +++ gcc/c-family/c.opt > @@ -819,6 +819,10 @@ Wswitch-bool > C ObjC C++ ObjC++ Var(warn_switch_bool) Warning Init(1) > Warn about switches with boolean controlling expression. > >

Re: C++ PATCH for c++/60364 - noreturn after first decl not diagnosed (v2)

2019-06-17 Thread Marek Polacek
On Mon, Jun 17, 2019 at 09:02:17AM -0600, Martin Sebor wrote: > > diff --git gcc/cp/tree.c gcc/cp/tree.c > > index cd021b7f594..bb695e14e73 100644 > > --- gcc/cp/tree.c > > +++ gcc/cp/tree.c > > @@ -4453,6 +4453,8 @@ const struct attribute_spec std_attribute_table[] = > > handle_likeliness_at

Re: C++ PATCH for c++/60364 - noreturn after first decl not diagnosed (v3)

2019-06-17 Thread Marek Polacek
On Mon, Jun 17, 2019 at 05:48:23PM +0200, Jakub Jelinek wrote: > On Sun, Jun 16, 2019 at 12:36:58PM -0400, Marek Polacek wrote: > > On Sun, Jun 16, 2019 at 06:18:56PM +0200, Jakub Jelinek wrote: > > > On Sun, Jun 16, 2019 at 12:10:37PM -0400, Marek Polacek wrote: > > > > > Guess I will really have

Re: C++ PATCH for c++/83820 - excessive attribute arguments not detected

2019-06-17 Thread Marek Polacek
On Mon, Jun 17, 2019 at 09:50:51AM -0600, Martin Sebor wrote: > On 6/16/19 1:10 PM, Marek Polacek wrote: > > While messing with [[noreturn]] I also found out that we don't detect > > the case when an attribute specifier that takes no arguments contains > > an attribute-argument-clause. > > > > Boo

[PATCH, i386]: Fix PR 62055, recognize fnabs (FP negative absolute value)

2019-06-17 Thread Uros Bizjak
2019-06-17 Uroš Bizjak PR target/62055 * config/i386/i386.md (*nabstf2_1): New insn pattern. (*nabs2_1): Ditto. (nabs sse-reg splitter): New splitter. * config/i386/sse.md (*nabs2): New insn_and_split pattern. testsuite/ChangeLog: 2019-06-17 Uroš Bizjak PR target/6

Re: Fix ICE due to commit for PR88834

2019-06-17 Thread Jeff Law
On 6/17/19 3:08 AM, Richard Sandiford wrote: > Kugan Vivekanandarajah writes: >> Hi All, >> >> As pointed to me by Jeff, after committing patch to fix PR88834, some >> tests are failing for target rx-elf. This is because in >> preferred_mem_scale_factor we end up with mem_mode which is BLKmode >>

[PR 90889] Fix IPA-CP topological sorting

2019-06-17 Thread Martin Jambor
Hi, r272115 introduced IPA-CP hook to ignore some edges in order to break useless SCCs, but the condition in the new hook was a bit too lenient. If we want to break SCCs in which contains some nodes has IPA-CP disabled, we must do it at the incoming edges, not at the outgoing, at least without ma

[PATCH], PowerPC PR90822 (cleanup lfiwax, lfiwzx generation)

2019-06-17 Thread Michael Meissner
I wrote the code to generate LFIWAX and LFIWZX originally for the power7 in the 2010 time frame. At the time, we did not allow SImode to go into floating point and vector registers. As part of the power9 work, we now allow SImode to go into FP/vector registers with for 64-bit code targetting -mcp

[PATCH] #pragma omp scan inclusive vectorization

2019-06-17 Thread Jakub Jelinek
Hi! On Mon, Jun 17, 2019 at 08:35:23AM +0200, Richard Biener wrote: > Ugh, not pretty but probably best we can do. Btw, can you please > add support for the SLP case and group_size == 1? I know I'm slow > with the branch ripping out the non-SLP path but it would save me > some extra work (possib

C++ PATCH for c++/61490 - qualified-id in friend function definition

2019-06-17 Thread Marek Polacek
[class.friend]/6 says that when we define a function in a friend declaration, the function name must be unqualified. But we never made sure that's so. For good measure, I'm also improving the location of the related diagnostic. Bootstrapped/regtested on x86_64-linux, ok for trunk? 2019-06-17 M

Re: [PATCH] improve ifcvt optimization (PR rtl-optimization/89430)

2019-06-17 Thread Jeff Law
On 3/14/19 10:46 PM, JiangNing OS wrote: > This patch is to fix a missing ifcvt opportunity in back-end. For the simple > case below, > > if (...) > x = a; /* x is memory */ > /* no else */ > > We can generate conditional move and remove the branch as below if the target > cost is acceptab

Re: [PATCH][Tree-optimization/PR89772]fold memchr builtins for character not in constant nul-padded string

2019-06-17 Thread Jeff Law
On 5/9/19 2:01 AM, JunMa wrote: > 在 2019/5/9 上午10:22, JunMa 写道: >> 在 2019/5/9 上午3:02, Bernd Edlinger 写道: >>> On 5/8/19 4:31 PM, Richard Biener wrote: On Tue, May 7, 2019 at 4:34 AM JunMa  wrote: > 在 2019/5/6 下午7:58, JunMa 写道: >> 在 2019/5/6 下午6:02, Richard Biener 写道: >>> On Thu, Mar

Re: [PATCH] PR c/17896 Check for missplaced bitwise op

2019-06-17 Thread Jeff Law
On 5/24/19 6:53 AM, Rafael Tsuha wrote: > This patch adds a function to warn when there's a bitwise operation > between a boolean and any other type. This kind of operation is > probably a programmer mistake that may lead to unexpected behavior > because possibily the logical operation was intended

Re: [PATCH] Fix PR84521

2019-06-17 Thread Jeff Law
On 5/28/19 11:37 AM, Wilco Dijkstra wrote: > This fixes and simplifies the setjmp and non-local goto implementation. > Currently the virtual frame pointer is saved when using __builtin_setjmp or > a non-local goto. Depending on whether a frame pointer is used, this may > either save SP or FP with

[PATCH] PowerPC: Add 'prefix' to the 'isa' attribute

2019-06-17 Thread Michael Meissner
Some of my future patches for prefixed memory instructions in a future PowerPC processor need the following tweak to the ISA attribute, so that the alternative that uses a prefixed instruction to load up large integer constants can be eliminated if the user does not compile for the 'future' target.

Re: [PATCH] Fix PR84521

2019-06-17 Thread Wilco Dijkstra
Hi Jeff, > So I like the significant simplification here.  My worry is whether or > not this is, in effect, an ABI change.  ie, would we be able to mix and > match .o files from before/after this change which used the builtin > setjmp/longjmp bits? No it's not an ABI change. It does affect the va

Re: [PATCH] Fix PR84521

2019-06-17 Thread Jeff Law
On 6/17/19 6:58 PM, Wilco Dijkstra wrote: > Hi Jeff, > >> So I like the significant simplification here.  My worry is whether or >> not this is, in effect, an ABI change.  ie, would we be able to mix and >> match .o files from before/after this change which used the builtin >> setjmp/longjmp bits?

[PATCH] [RFC, PGO+LTO] Missed function specialization + partial devirtualization

2019-06-17 Thread Xiong Hu Luo
This patch aims to fix PR69678 caused by PGO indirect call profiling bugs. Currently the default instrument function can only find the indirect function that called more than 50% with an incorrect count number returned. This patch leverages the "--param indir-call-topn-profile=1" and enables multi

Re: [PR 90889] Fix IPA-CP topological sorting

2019-06-17 Thread Martin Liška
On 6/17/19 10:36 PM, Martin Jambor wrote: > Hi, > > r272115 introduced IPA-CP hook to ignore some edges in order to break > useless SCCs, but the condition in the new hook was a bit too lenient. Oh, sorry for the breakage. Thank you Martin for the patch. Martin > > If we want to break SCCs in

Re: [PATCH] [RFC, PGO+LTO] Missed function specialization + partial devirtualization

2019-06-17 Thread Martin Liška
On 6/18/19 3:45 AM, Xiong Hu Luo wrote: Hello. Thank you for the interest in the area. > This patch aims to fix PR69678 caused by PGO indirect call profiling bugs. > Currently the default instrument function can only find the indirect function > that called more than 50% with an incorrect count

Re: Review Hashtable extract node API

2019-06-17 Thread François Dumont
A small regression noticed while merging. We shouldn't keep on using a moved-from key_type instance. Ok to commit ? Feel free to do it if you prefer, I'll do so at end of Europe day otherwise. François On 6/17/19 12:28 PM, Jonathan Wakely wrote: On 07/06/19 18:39 +0200, François Dumont wro