Re: [PATCH][Tree-optimization/PR89772]fold memchr builtins for character not in constant nul-padded string

2019-05-09 Thread JunMa
在 2019/5/9 上午10:22, JunMa 写道: 在 2019/5/9 上午3:02, Bernd Edlinger 写道: On 5/8/19 4:31 PM, Richard Biener wrote: On Tue, May 7, 2019 at 4:34 AM JunMa wrote: 在 2019/5/6 下午7:58, JunMa 写道: 在 2019/5/6 下午6:02, Richard Biener 写道: On Thu, Mar 21, 2019 at 5:57 AM JunMa wrote: Hi For now, gcc can not

Re: [PATCH][AArch64] Emit TARGET_DOTPROD-specific sequence for sadv16qi

2019-05-09 Thread Richard Sandiford
Kyrill Tkachov writes: > +;; Helper expander for aarch64_abd_3 to save the callers > +;; the hassle of constructing the other arm of the MINUS. > +(define_expand "abd_3" > + [(use (match_operand:VDQ_BHSI 0 "register_operand")) > + (USMAX:VDQ_BHSI (match_operand:VDQ_BHSI 1 "register_operand") >

[v3 PATCH] Inconsistency wrt Allocators in basic_string assignment vs. basic_string::assign (LWG2579)

2019-05-09 Thread Nina Dinka Ranns
Tested on Linux x86_64 Inconsistency wrt Allocators in basic_string assignment vs. basic_string::assign (LWG2579) 2019-05-09 Nina Dinka Ranns Inconsistency wrt Allocators in basic_string assignment vs. basic_string::assign (LWG2579) * include/bits/basic_string.h: operat

[committed] [PR89221] Continue to default to '--disable-frame-pointer' for x86 GNU systems (was: [PATCH v2, i386]: Fix PR89221, --enable-frame-pointer does not work as intended)

2019-05-09 Thread Thomas Schwinge
Hi! On Sun, 10 Feb 2019 20:51:39 +0100, Uros Bizjak wrote: > On Fri, Feb 8, 2019 at 1:24 PM Uros Bizjak wrote: > > Attached patch fixes --enable-frame-pointer handling [...] ACK. > Please note that this fix will re-enable frame pointer for all targets > but linux* or darwin[[8912]]. However, s

[committed] Clean up MPX-related stuff: CIF_CHKP (was: [PATCH] Clean up another MPX-related stuff.)

2019-05-09 Thread Thomas Schwinge
Hi! On Wed, 13 Feb 2019 14:47:36 +0100, Richard Biener wrote: > On February 13, 2019 6:53:17 AM GMT+01:00, "Martin Liška" > wrote: > >As Honza noticed, there's still some leftover from MPX removal. > >May I remove another bunch of fields now, or should I wait > >for next stage1? > > You can d

Re: [PATCH][stage1] Support profile (BB counts and edge probabilities) in GIMPLE FE.

2019-05-09 Thread Martin Liška
On 5/7/19 4:44 PM, Richard Biener wrote: > On May 7, 2019 4:33:08 PM GMT+02:00, "Martin Liška" wrote: >> On 5/7/19 2:56 PM, Richard Biener wrote: >>> But that can use the existing get_hot_bb_threshold since we never >> want >>> to dump -1 in case min_count was never initialized. >> >> Yes. But the

Re: [committed] Clean up MPX-related stuff: CIF_CHKP

2019-05-09 Thread Martin Liška
On 5/9/19 11:59 AM, Thomas Schwinge wrote: > Hi! > > On Wed, 13 Feb 2019 14:47:36 +0100, Richard Biener > wrote: >> On February 13, 2019 6:53:17 AM GMT+01:00, "Martin Liška" >> wrote: >>> As Honza noticed, there's still some leftover from MPX removal. >>> May I remove another bunch of fields n

[PATCH] Fix Pr90395

2019-05-09 Thread Richard Biener
Bootstrapped/tested on x86_64-unknown-linux-gnu, applied. Richard. 2019-05-09 Richard Biener PR tree-optimization/90395 * tree-ssa-forwprop.c (pass_forwprop::execute): Do not rewrite vector stores that throw internally. * gcc.dg/torture/pr90395.c: New testca

[PATCH] Fix location where lto-dump is installed.

2019-05-09 Thread Martin Liška
Hi. The patch is about proper install location of the newly added tool. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Ready to be installed? Thanks, Martin gcc/lto/ChangeLog: 2019-05-09 Martin Liska * Make-lang.in: Use program_transform_name for lto-dump.

[PATCH] Fix __builtin_init_dwarf_reg_size_table when built with -mfpxx

2019-05-09 Thread Dragan Mladjenovic
From: "Dragan Mladjenovic" Hi all, For TARGET_FLOATXX the odd-numbered FP registers in SFmode are HARD_REGNO_CALL_PART_CLOBBERED. This causes dwarf_frame_reg_mode to fall back to VOIDmode and for __builtin_init_dwarf_reg_size_table to fill them as zero sized. This prevents libgcc's unwinder fo

30_threads/thread/native_handle/typesizes.cc is no good

2019-05-09 Thread Alexandre Oliva
Other classes that have native_handle/typesizes.cc tests have native_type_handle defined as a pointer type, and the pointed-to type is native_handle, the type of the single data member of the class (*). It thus makes sense to check that the single data member and the enclosing class type have the

[RFC] SHIFT_COUNT_TRUNCATED and shift_truncation_mask

2019-05-09 Thread Robin Dapp
Hi, while trying to improve s390 code generation for rotate and shift I noticed superfluous subregs for shift count operands. In our backend we already have quite cumbersome patterns that would need to be duplicated (or complicated further by more subst patterns) in order to get rid of the subregs

[PATCH] Fix PR90402

2019-05-09 Thread Richard Biener
The following fixes PR90402 by avoiding value-numbering bring the loop header PHIs of if-converted and non-if-converted loop copy out-of-sync for the vectorizer. This is done by teaching region VN to handle multiple entries into the entry block which allows us to value-number a cycles body witho

[PATCH 0/2] gcov for huge cyclic graph (PR gcov-profile/90380)

2019-05-09 Thread marxin
Hi. The PR is about a huge number of basic blocks that belong to a line. Apparently, it's a generated code coming from Fortran module end statement. I'm doing fix in 2 steps: 1) I dropped NEGATIVE_LOOP as that can't happen. I've tested that on GCC and works fine. 2) Cycle detection algorithm s

[PATCH 2/2] Do not follow zero edges in cycle detection (PR gcov-profile/90380).

2019-05-09 Thread marxin
gcc/ChangeLog: 2019-05-09 Martin Liska * gcov.c (circuit): Ignore zero count arcs. --- gcc/gcov.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/gcc/gcov.c b/gcc/gcov.c index 6bcd2b23748..f409d67e12c 100644 --- a/gcc/gcov.c +++ b/gcc/gcov.c @@ -742,7 +742

[PATCH] Add params for jump-table expansion params (PR middle-end/90340).

2019-05-09 Thread Martin Liška
Hi. The patch comes up with 2 new params that drive jump table density when optimizing for size and speed. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Ready to be installed? Thanks, Martin gcc/ChangeLog: 2019-05-07 Martin Liska PR middle-end/90340

[PATCH 1/2] Test for not existence of a negative loop (PR gcov-profile/90380).

2019-05-09 Thread marxin
gcc/ChangeLog: 2019-05-09 Martin Liska PR gcov-profile/90380 * gcov.c (enum loop_type): Remove the enum and the operator. (handle_cycle): Assert that we should not reach a negative count. (circuit): Use loop_found instead of a tri-state loop_typ

Re: [PATCH] PR libstdc++/61761 fix std::proj for targets without C99 cproj

2019-05-09 Thread Szabolcs Nagy
On 03/05/2019 20:25, Jonathan Wakely wrote: > On 03/05/19 14:34 +, Szabolcs Nagy wrote: >> there is still an execution failure, but that's not >> related to copysign: proj(i*inf) returns i*inf instead of inf >> i haven't figured out why: >> >> /work/b/src/gcc/libstdc++-v3/testsuite/26_numerics/

Re: [PATCH] Implement LWG 2686, hash

2019-05-09 Thread Szabolcs Nagy
On 07/05/2019 13:21, Christophe Lyon wrote: > On Tue, 7 May 2019 at 12:07, Jonathan Wakely wrote: >> >> On 07/05/19 10:37 +0100, Jonathan Wakely wrote: >>> On 07/05/19 11:05 +0200, Christophe Lyon wrote: On Sat, 4 May 2019 at 16:36, Jonathan Wakely wrote: > > On 03/05/19 23:42 +0100,

Re: [PATCH] Eliminates phi on branch for CMP result

2019-05-09 Thread Jeff Law
On 5/9/19 12:07 AM, Richard Biener wrote: > On Wed, 8 May 2019, Jeff Law wrote: > >> On 5/8/19 6:20 AM, Richard Biener wrote: >>> On Wed, 8 May 2019, Jiufu Guo wrote: >>> Hi, Thanks Richard, Segher, Andrew and all. Segher Boessenkool writes: > Let me try to answe

Re: [PATCH][PR90106] Builtin call transformation changes in cdce pass

2019-05-09 Thread Jeff Law
On 5/8/19 7:20 PM, Bin.Cheng wrote: > On Thu, May 9, 2019 at 5:31 AM Jeff Law wrote: >> >> On 5/8/19 6:28 AM, Richard Biener wrote: >>> On Wed, May 8, 2019 at 12:09 PM JunMa wrote: Hi As PR90106 (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90106), when gcc meets builtin

Re: [PATCH] Add params for jump-table expansion params (PR middle-end/90340).

2019-05-09 Thread Jeff Law
On 5/9/19 7:09 AM, Martin Liška wrote: > Hi. > > The patch comes up with 2 new params that drive jump table density > when optimizing for size and speed. > > Patch can bootstrap on x86_64-linux-gnu and survives regression tests. > > Ready to be installed? > Thanks, > Martin > > gcc/ChangeLog: >

Re: [PATCH] Fix location where lto-dump is installed.

2019-05-09 Thread Jeff Law
On 5/9/19 4:20 AM, Martin Liška wrote: > Hi. > > The patch is about proper install location of the newly added tool. > > Patch can bootstrap on x86_64-linux-gnu and survives regression tests. > > Ready to be installed? > Thanks, > Martin > > gcc/lto/ChangeLog: > > 2019-05-09 Martin Liska >

Re: [PATCH] Implement LWG 2686, hash

2019-05-09 Thread Jonathan Wakely
On Thu, 9 May 2019 at 15:43, Szabolcs Nagy wrote: > > On 07/05/2019 13:21, Christophe Lyon wrote: > > On Tue, 7 May 2019 at 12:07, Jonathan Wakely wrote: > >> > >> On 07/05/19 10:37 +0100, Jonathan Wakely wrote: > >>> On 07/05/19 11:05 +0200, Christophe Lyon wrote: > On Sat, 4 May 2019 at 16

Re: [RFC] SHIFT_COUNT_TRUNCATED and shift_truncation_mask

2019-05-09 Thread Jeff Law
On 5/9/19 5:52 AM, Robin Dapp wrote: > Hi, > > while trying to improve s390 code generation for rotate and shift I > noticed superfluous subregs for shift count operands. In our backend we > already have quite cumbersome patterns that would need to be duplicated > (or complicated further by more s

[arm] PR target/90405 fix regression for thumb1 with -mtpcs-leaf-frame

2019-05-09 Thread Richard Earnshaw (lists)
-mtpcs-leaf-frame causes an APCS-style backtrace frame to be created on the stack. This should probably be deprecated, but it did reveal an issue with the patch I committed previously to improve the code generation when pushing high registers, in that thumb_find_work_register had a different idea

Re: [wwwdocs] Document GCC 9 Solaris changes

2019-05-09 Thread Jeff Law
On 5/6/19 6:51 AM, Rainer Orth wrote: > Better late than never: here's the gcc-9/changes.html update listing > Solaris improvements. I'm all ears for suggestions about wording or > markup improvements. > > Ok? > > Thanks. > Rainer > OK. Please install if you haven't already. jeff

[PATCH] [aarch64] Introduce flags for SVE2.

2019-05-09 Thread Matthew Malcomson
This patch adds support in the compiler for the architecture feature flags that binutils will use to enable/disable the new "Future Architecture Technologies" feature Scalable Vector Extension V2 (SVE2) announced at Linaro Connect. The "sve2" extension that enables the core sve2 instructions. This

RE: [Vectorizer] Add SLP support for masked loads

2019-05-09 Thread Alejandro Martinez Vicente
Hi Richards, This is the new version of the patch, addressing your comments. Alejandro > -Original Message- > From: Richard Sandiford > Sent: 08 May 2019 14:36 > To: Richard Biener > Cc: Alejandro Martinez Vicente ; GCC > Patches ; nd > Subject: Re: [Vectorizer] Add SLP support for ma

Re: [RFC] SHIFT_COUNT_TRUNCATED and shift_truncation_mask

2019-05-09 Thread Segher Boessenkool
[ Please Cc: me on combine patches. Thanks! ] On Thu, May 09, 2019 at 01:52:58PM +0200, Robin Dapp wrote: > I had already finished all the patterns when I realized that > SHIFT_COUNT_TRUNCATED and the target hook shift_truncation_mask already > exist and could do what is needed without extra patt

Re: [RFC] SHIFT_COUNT_TRUNCATED and shift_truncation_mask

2019-05-09 Thread Segher Boessenkool
On Thu, May 09, 2019 at 09:59:55AM -0600, Jeff Law wrote: > THe main reason it's discouraged is because some targets have insns > where the count would be truncated and others where it would not. So > for example normal shifts might truncate, but vector shifts might or > (mips) or shifts might tr

[committed] sel-sched: allow negative insn priority (PR 88879)

2019-05-09 Thread Alexander Monakov
Hi, this fixes PR 88879 by mostly restoring the previous behavior (accepting negative priority values). Approved by Andrey off-list, applying. PR rtl-optimization/88879 * sel-sched.c (sel_target_adjust_priority): Remove assert. Index: sel-sched.c

Re: [Patch] Fix ix86_expand_sse_comi_round (PR Target/89750, PR Target/86444)

2019-05-09 Thread Jeff Law
On 5/6/19 11:38 PM, Hongtao Liu wrote: > Hi Uros and GCC: > This patch is to fix ix86_expand_sse_comi_round whose implementation > was not correct. > New implentation aligns with _mm_cmp_round_s[sd]_mask. > > Bootstrap and regression tests for x86 is fine. > Ok for trunk? > > > ChangeLog: >

[doc, committed] Remove stale reference to FOR_EACH_LOOP_BREAK

2019-05-09 Thread Bill Schmidt
Hi, We removed FOR_EACH_LOOP_BREAK from the compiler six years ago, but it still shows up in the internals manual. Fix that. Tested, committed as obvious. Thanks, Bill 2019-05-09 Bill Schmidt * doc/loop.texi: Remove reference to FOR_EACH_LOOP_BREAK. Index: gcc/doc/loop.texi ===

Re: [PATCH][PR90106] Builtin call transformation changes in cdce pass

2019-05-09 Thread Jeff Law
On 5/8/19 8:25 PM, JunMa wrote: > 在 2019/5/9 上午9:20, Bin.Cheng 写道: >> On Thu, May 9, 2019 at 5:31 AM Jeff Law wrote: >>> On 5/8/19 6:28 AM, Richard Biener wrote: On Wed, May 8, 2019 at 12:09 PM JunMa wrote: > Hi > > As PR90106 (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90106),

Merge from trunk to gccgo branch

2019-05-09 Thread Ian Lance Taylor
I merged trunk revision 271040 to the gccgo branch. Ian

Go patch committed: Avoid copy for string([]byte) conversion in map keys

2019-05-09 Thread Ian Lance Taylor
This patch to the Go frontend by Cherry Zhang avoids a copy for a string([]byte) conversion used as a map key. If a string([]byte) conversion is used immediately as a key for a map read, we don't need to copy the backing store of the byte slice, as mapaccess does not keep a reference to it. The g

Re: [PATCH] libphobos: RISC-V: Fix soft-float build errors with IEEE exception flags

2019-05-09 Thread Maciej W. Rozycki
Iain, Jakub -- > > > > With all of the above in mind, OK to apply to trunk and to GCC 9? > > > > > > Looks OK to me. > > > > The change is ok for 9.1 if it can be committed to gcc-9-branch today. > > Committed to both trunk and gcc-9-branch. Thank you both for the review, however, Iain, in the

Re: [RFC] SHIFT_COUNT_TRUNCATED and shift_truncation_mask

2019-05-09 Thread Uros Bizjak
>> Event SHIFT_COUNT_TRUNCATED is no perfect match to what our hardware >> does because we always only consider the last 6 bits of a shift operand.> >> Despite all the warnings in the other backends, most notably >> SHIFT_COUNT_TRUNCATED being "discouraged" as mentioned in riscv.h, I >> wrote the a

Re: [PATCH] netbsd EABI support

2019-05-09 Thread coypu
On Tue, Apr 09, 2019 at 05:36:47PM +0100, Richard Earnshaw (lists) wrote: > > So we're well into stage4 which means technically it's too late for > > something like this. However, given it's limited scope I won't object > > if the ARM port maintainers want to go forward. Otherwise I'll queue it >

Re: [PATCH] libphobos: RISC-V: Fix soft-float build errors with IEEE exception flags

2019-05-09 Thread Maciej W. Rozycki
On Mon, 6 May 2019, Jim Wilson wrote: > > Hmm, I've been thinking a little bit about this hybrid mode and I have > > one question: how do we pass the IEEE rounding mode setting between `fcsr' > > and softfp where we have `-march=rv32imafc -mabi=ilp32' and > > `-march=rv32imac -mabi=ilp32' object

[PATCH] combine: Don't generate IF_THEN_ELSE

2019-05-09 Thread Segher Boessenkool
On all targets I managed to test (21) this results in better code. Only alpha ends up with slightly bigger code. Committing to trunk. Segher 2019-05-10 Segher Boessenkool * combine.c (combine_simplify_rtx): Don't make IF_THEN_ELSE RTL. --- gcc/combine.c | 8 1 file chan

Re: [PATCH] [MIPS] Fix PR/target 90357 20080502-1.c -O0 start with r269880

2019-05-09 Thread Paul Hua
ping ? On Mon, May 6, 2019 at 4:34 PM Paul Hua wrote: > > The attached patch fix pr90357, bootstraped and regressed test on > mips64el-linux-gnu target. > Ok for commit ?

Re: [PATCH][PR90106] Builtin call transformation changes in cdce pass

2019-05-09 Thread JunMa
在 2019/5/10 上午4:00, Jeff Law 写道: On 5/8/19 8:25 PM, JunMa wrote: 在 2019/5/9 上午9:20, Bin.Cheng 写道: On Thu, May 9, 2019 at 5:31 AM Jeff Law wrote: On 5/8/19 6:28 AM, Richard Biener wrote: On Wed, May 8, 2019 at 12:09 PM JunMa wrote: Hi As PR90106 (https://gcc.gnu.org/bugzilla/show_bug.cgi?i

Re: [PATCH 1/2] or1k: Fix code quality for volatile memory loads

2019-05-09 Thread Bernhard Reutner-Fischer
On 6 May 2019 15:16:20 CEST, Stafford Horne wrote: >Volatile memory does not match the memory_operand predicate. This >causes extra extend/mask instructions instructions when reading >from volatile memory. On OpenRISC loading volitile memory can be s/volitile/volatile/g also at least in the te

Re: [Patch] Fix ix86_expand_sse_comi_round (PR Target/89750, PR Target/86444)

2019-05-09 Thread Hongtao Liu
On Fri, May 10, 2019 at 3:55 AM Jeff Law wrote: > > On 5/6/19 11:38 PM, Hongtao Liu wrote: > > Hi Uros and GCC: > > This patch is to fix ix86_expand_sse_comi_round whose implementation > > was not correct. > > New implentation aligns with _mm_cmp_round_s[sd]_mask. > > > > Bootstrap and regress

Re: [Patch] Fix ix86_expand_sse_comi_round (PR Target/89750, PR Target/86444)

2019-05-09 Thread Hongtao Liu
On Fri, May 10, 2019 at 12:54 PM Hongtao Liu wrote: > > On Fri, May 10, 2019 at 3:55 AM Jeff Law wrote: > > > > On 5/6/19 11:38 PM, Hongtao Liu wrote: > > > Hi Uros and GCC: > > > This patch is to fix ix86_expand_sse_comi_round whose implementation > > > was not correct. > > > New implentatio

Deque code cleanup and optimizations

2019-05-09 Thread François Dumont
Hi     This patch implements a number of simplifications and optimizations already done to other containers like std::vector - Default default and move constructors - The std::swap optimization - The construction always equal allocator optimization - Shortcuts on method calls.     I remove

Re: [PATCH][stage1] Support profile (BB counts and edge probabilities) in GIMPLE FE.

2019-05-09 Thread Bernhard Reutner-Fischer
On 7 May 2019 14:00:32 CEST, "Martin Liška" wrote: /The parameters is/s/parameters/parameter/ thanks,