Re: [PATCH] [RFC] PR target/52813 and target/11807

2018-12-16 Thread Dimitar Dimitrov
On Fri, Dec 14 2018 2:52:17 EET Segher Boessenkool wrote: > You need a few tweaks to what you committed. Or just one perhaps: if > flag_pic is not set, you should not check PIC_OFFSET_TABLE_REGNUM, it is > meaningless in that case. I'm not sure if you need to check whether the > register is fixed

Re: [PATCH] x86: Don't use get_frame_size to finalize stack frame

2018-12-16 Thread Uros Bizjak
On 12/15/18, H.J. Lu wrote: > On Fri, Dec 14, 2018 at 04:04:02PM -0800, H.J. Lu wrote: >> On Fri, Dec 14, 2018 at 3:24 PM Jeff Law wrote: >> > >> > On 12/14/18 4:01 PM, H.J. Lu wrote: >> > > On Thu, Dec 13, 2018 at 11:11 PM Uros Bizjak >> > > wrote: >> > >> On Thu, Dec 13, 2018 at 6:36 PM H.J. L

Re: [PATCH] PR fortran 88116,88467 -- Catch array constructor errors

2018-12-16 Thread Dominique d'Humières
Hi Steve, The patch works as expected. Is "Can\’t " instead of "Can’t " really necessary? Thanks for the patch, Dominique

Typos in [Committed] PR fortran/88138 -- can't initialize a derived type

2018-12-16 Thread Dominique d'Humières
Hi Steve, I think that in decl.c ‘derive’ should be ‘derived’ (twice) and there should be no ’s’ after the dg-error in pr88138.f90. Thanks for the fix. Dominique

Speed up fnsummary stream in time

2018-12-16 Thread Jan Hubicka
Hi, this patch does same chage to fnsymmary as I did to ipa-prop to avoid allocating data we know that will be removed during cgraph merging. Bootstrapped/regtested x86_64-linux, comitted. Honza * ipa-fnsummary.c (analyze_function_body): Do not loeak conds and size_time_table.

Re: Optimize streaming in of non-prevailing ipa-parm summaries

2018-12-16 Thread Jan Hubicka
> On December 15, 2018 10:17:43 PM GMT+01:00, Jan Hubicka > wrote: > >Hi, > >this patch is motivated by finding that Firefox ipa summaries stream-in > >is fully dominated by streaming edge summaries that are not necessary > >because they lead to external calls or are from comdat functions that >

Re: Optimize streaming in of non-prevailing ipa-parm summaries

2018-12-16 Thread Richard Biener
On December 16, 2018 1:19:13 PM GMT+01:00, Jan Hubicka wrote: >> On December 15, 2018 10:17:43 PM GMT+01:00, Jan Hubicka > wrote: >> >Hi, >> >this patch is motivated by finding that Firefox ipa summaries >stream-in >> >is fully dominated by streaming edge summaries that are not >necessary >> >beca

Re: Fix hashtable node deallocation

2018-12-16 Thread François Dumont
Gentle reminder, we still have this issue pending.     * include/bits/hashtable_policy.h (_Hashtable_alloc<>::_M_deallocate_node_ptr(__node_type*)): New.     (_Hashtable_alloc<>::_M_deallocate_node(__node_type*)): Use latter. (_ReuseOrAllocNode<>::operator<_Arg>()(_Arg&&)): Likewise.     * libstd

Re: [PATCH v4][C][ADA] use function descriptors instead of trampolines in C

2018-12-16 Thread Uecker, Martin
Am Freitag, den 14.12.2018, 18:20 -0700 schrieb Martin Sebor: > On 12/14/18 4:36 PM, Jeff Law wrote: > > On 12/14/18 3:05 AM, Uecker, Martin wrote: > > > > > > Am Donnerstag, den 13.12.2018, 16:35 -0700 schrieb Jeff Law: > > > > On 12/12/18 11:12 AM, Uecker, Martin wrote: > > > > > > ... > > > >

Re: [PATCH] [RFC] PR target/52813 and target/11807

2018-12-16 Thread Bernd Edlinger
Hi, if I understood that right, then clobbering sp is and has always been ignored. If that is right, then I would much prefer a warning, that says exactly that, because that would also help to understand why removing that clobber statement is safe even for old gcc versions. Since your patch did

[patch, fortran, committed] Fix PR 88363

2018-12-16 Thread Thomas Koenig
Hi, I just committed the attached patch as obvious and simple. The problem was that clobbering of intent(out) clobbered the whole variable, instead of only the element that was actually clobbered. There is still some optimization work that can be done here, but I will defer that to a later date

Re: [PATCH] x86: Add -march=cascadelake

2018-12-16 Thread Wei Xiao
Thanks for the comments! Fixed as attached. Ok for trunk? Jakub Jelinek 于2018年12月14日周五 下午6:47写道: > > On Fri, Dec 14, 2018 at 06:33:37PM +0800, Wei Xiao wrote: > --- a/gcc/config/i386/driver-i386.c > +++ b/gcc/config/i386/driver-i386.c > @@ -832,8 +832,16 @@ const char *host_detect_local_cpu (int a

Re: [PATCH] PR fortran 88116,88467 -- Catch array constructor errors

2018-12-16 Thread Steve Kargl
On Sun, Dec 16, 2018 at 11:45:11AM +0100, Dominique d'Humières wrote: > Hi Steve, > > The patch works as expected. > > Is "Can\’t " instead of "Can’t " really necessary? > I don't remember how dejagnu handles quotes in the regex expression. "Can\'t" seems to work (for me). If you want to chang

Re: [PATCH] [RFC] PR target/52813 and target/11807

2018-12-16 Thread Dimitar Dimitrov
On Sun, Dec 16 2018 at 14:36:26 EET Bernd Edlinger wrote: > Hi, > > if I understood that right, then clobbering sp is and has always been > ignored. > > If that is right, then I would much prefer a warning, that says exactly > that, because that would also help to understand why removing that clob

Re: [PATCH v4][C][ADA] use function descriptors instead of trampolines in C

2018-12-16 Thread Jeff Law
On 12/16/18 6:45 AM, Uecker, Martin wrote: > Am Freitag, den 14.12.2018, 18:20 -0700 schrieb Martin Sebor: >> On 12/14/18 4:36 PM, Jeff Law wrote: >>> On 12/14/18 3:05 AM, Uecker, Martin wrote: Am Donnerstag, den 13.12.2018, 16:35 -0700 schrieb Jeff Law: > On 12/12/18 11:12 AM, Uecker

Implementation of F2018:18.4 C descriptors and ISO_Fortran_binding.h

2018-12-16 Thread Paul Richard Thomas
The attached is an implementation of ISO_Fortran_binding. Please note that the ChangeLogs contain no mention of the changes that appear in the configure files on building in maintainer mode. The patch only couples to assumed rank and assumed shape formal arguments of bind_c procedures, via trans-e

[PATCH] PR fortran/87992 -- trivially stupid patch, but ...

2018-12-16 Thread Steve Kargl
The following patch removes the ICE reported in PR fortran/87992, and restores the behavior observed with gfortran 7 and 8 (ie, code compiles). The PR marks the code with ice-on-invalid-code. I don't use CLASS in any of code and have never read the standard nor a Fortran book about CLASS. If the

Re: Fix move_if_noexcept usages in _Hashtable

2018-12-16 Thread François Dumont
I reviewed this patch following result of making std::pair piecewise constructor noexcept: https://gcc.gnu.org/ml/libstdc++/2018-12/msg00052.html I restore check of noexcept qualification on move constructor rather than alloc::construct cause when dealing with std::pairValue> I want to check f

Re: [patch] Fix bootstrap powerpc*-*-freebsd* targets

2018-12-16 Thread Andreas Tobler
On 12.12.18 21:32, Andreas Tobler wrote: this patch fixes bootstrap for my powerpc*-unknown-freebsd* targets. The definition of GNU_USER_DYNAMIC_LINKER was recently moved to linux.h. But the GNU_USER_DYNAMIC_LINKER is still used in rs6000/sysv4.h. So I add an empty definition with guard to cure

[PATCH] PR fortran/85798 -- Check for allocatable components in data statement

2018-12-16 Thread Steve Kargl
The attached patch has been tested on i586-*-freebsd and x86_64-*-freebsd. If a data-statement-object is a component of a derived type, it checks if that component is allocatable. 2018-12-16 Steven G . Kargl PR fortran/85798 * decl.c (gfc_match_data): If a component of a derive

[PATCH] DWARF: Don't expand hash table when no insert is needed

2018-12-16 Thread H.J. Lu
find_slot_with_hash has if (insert == INSERT && m_size * 3 <= m_n_elements * 4) expand (); which may expand hash table even if no insert is neeed and change hash table traverse order. When output_macinfo_op is called, all index strings have been added to hash table by save_macinfo_strings,

[patch, fortran] Fix PR 85544

2018-12-16 Thread Thomas Koenig
Hello world, the PR pointed out an old regression because the front-end optimization pass was substituting 2**n with ishift(1,n), where n was an array. Simply removing the optimization for that case would have been easy, but also introduced a performance regression. So, for this, I moved the op

Re: [PATCH v4][C][ADA] use function descriptors instead of trampolines in C

2018-12-16 Thread Uecker, Martin
Am Sonntag, den 16.12.2018, 09:13 -0700 schrieb Jeff Law: > On 12/16/18 6:45 AM, Uecker, Martin wrote: > > Am Freitag, den 14.12.2018, 18:20 -0700 schrieb Martin Sebor: > > > On 12/14/18 4:36 PM, Jeff Law wrote: > > > > On 12/14/18 3:05 AM, Uecker, Martin wrote: > > > > > > > > > > Am Donnerstag,

[PATCH, libphobos] Committed commonize core.sys.posix.sys.msg

2018-12-16 Thread Iain Buclaw
Hi, This patch is a continuation of prior merging common version blocks to help simplify porting the C bindings. For this particular module, it now more closely resembles how glibc arranges msq.h, fixing a couple of targets in the process, notably X32. Bootstrapped and tested on x86_64-linux-gnu

Re: [patch] Fix bootstrap powerpc*-*-freebsd* targets

2018-12-16 Thread Alan Modra
On Sun, Dec 16, 2018 at 07:46:18PM +0100, Andreas Tobler wrote: > On 12.12.18 21:32, Andreas Tobler wrote: > > > this patch fixes bootstrap for my powerpc*-unknown-freebsd* targets. > > The definition of GNU_USER_DYNAMIC_LINKER was recently moved to linux.h. Sorry about the breakage. > > But the

[Committed] PR fortran/85314 -- Remove dead code.

2018-12-16 Thread Steve Kargl
Committed as obvous. 2018-12-16 Steven G. Kargl * resolve.c (resolve_transfer): Remove dead code. Index: gcc/fortran/resolve.c === --- gcc/fortran/resolve.c (revision 267190) +++ gcc/fortran/resolve.c (workin

[PATCH, og8] Add OpenACC 2.6 `serial' construct support

2018-12-16 Thread Maciej W. Rozycki
The `serial' construct is equivalent to a `parallel' construct with clauses `num_gangs(1) num_workers(1) vector_length(1)' implied. Naturally these clauses are therefore not supported with the `serial' construct. All the remaining clauses accepted with `parallel' are also accepted with `seria

Re: [PATCH] x86: Add -march=cascadelake

2018-12-16 Thread Uros Bizjak
On Sun, Dec 16, 2018 at 4:15 PM Wei Xiao wrote: > > Thanks for the comments! > Fixed as attached. > Ok for trunk? OK. Thanks, Uros. > Jakub Jelinek 于2018年12月14日周五 下午6:47写道: > > > > On Fri, Dec 14, 2018 at 06:33:37PM +0800, Wei Xiao wrote: > > --- a/gcc/config/i386/driver-i386.c > > +++ b/gcc/c

[PATCH, middle-end/i386]: Fix PR88502, Inline built-in asinh, acosh, atanh for -ffast-math

2018-12-16 Thread Uros Bizjak
Attached patch inlines calls to asinh{,f}, acosh{,f,l} and atanh{,f,l} using x87 XFmode arithmetic. In the patch, I left out asinhl due to its reduced input argument range, but perhaps it could be added back, since we are expanding under flag_unsafe_math_optimizations. The expanders are modelled af