Re: [PATCH] Add define_insn_and_split for combine to detect x < 123U ? -1 : 0 (PR target/88425)

On Tue, Dec 11, 2018 at 8:54 AM Jakub Jelinek wrote: > > On Tue, Dec 11, 2018 at 08:44:00AM +0100, Uros Bizjak wrote: > > > --- gcc/config/i386/i386.md.jj 2018-11-22 10:40:31.179683319 +0100 > > > +++ gcc/config/i386/i386.md 2018-12-10 11:24:49.785830186 +0100 > > > @@ -17195,6 +17195,24 @@ (

Re: [PATCH] Add define_insn_and_split for combine to detect x < 123U ? -1 : 0 (PR target/88425)

On Tue, Dec 11, 2018 at 09:03:08AM +0100, Uros Bizjak wrote: > On Tue, Dec 11, 2018 at 8:54 AM Jakub Jelinek wrote: > > > > On Tue, Dec 11, 2018 at 08:44:00AM +0100, Uros Bizjak wrote: > > > > --- gcc/config/i386/i386.md.jj 2018-11-22 10:40:31.179683319 +0100 > > > > +++ gcc/config/i386/i386.md

[PATCH] rs6000: Don't use rs6000_isa_flags_explicit for soft float tests (PR88145)

...specifically, those for builtins. Soft float can be enabled implicitly, too (for certain CPUs for example). We should use rs6000_isa_flags instead, to decide whether to expand a builtin or to bail out with an error instead. Tested on powerpc64-linux {-m32,-m64}. Committing. Segher 2018-1

Re: [committed] [PR tree-optimization/80520] Throttle path splitting slightly.

On Tue, Dec 11, 2018 at 5:56 AM Jeff Law wrote: > > > > This is a pre-req for fixing 80520. Essentially the goal here is to > keep the key code in this form: > > > [ ... ] > if (_20 != 0) > goto ; [50.00%] > else > goto ; [50.00%] > >[local count: 531502203]: > _18 = _25 ^

Re: [PATCH] Make LTO tests that require recent binutils UNSUPPORTED with older ones (PR lto/86004)

On Tue, 11 Dec 2018, Jakub Jelinek wrote: > Hi! > > As mentioned in the PR, older binutils (like 2.25) complain on these tests > when using -r that: > plugin needed to handle lto object > The following patch introduces an effective target and guards those tests on > a linker with this issue fixed

[committed] Avoid -Wmissing-attributes warnings in libquadmath

Hi! The following patch avoids -Wmissing-attributes warnings in quadmath headers. Bootstrapped/regtested on x86_64-linux and i686-linux, committed to trunk. 2018-12-11 Jakub Jelinek PR c/88430 * quadmath_weak.h (__qmath2): Add __quadmath_throw. --- libquadmath/quadmath_weak.

Re: [PATCH] Delete powerpcspe

On Mon, Dec 10, 2018 at 9:13 PM Segher Boessenkool wrote: > > On Mon, Dec 10, 2018 at 06:25:31PM +, Andrew Jenner wrote: > > Sorry for the slow response on this, I was on vacation last week. > > > > On 03/12/2018 21:48, Jakub Jelinek wrote: > > >I'd give the maintainers the last week to act if

Re: [PATCH] Add define_insn_and_split for combine to detect x < 123U ? -1 : 0 (PR target/88425)

On Tue, Dec 11, 2018 at 9:14 AM Jakub Jelinek wrote: > > On Tue, Dec 11, 2018 at 09:03:08AM +0100, Uros Bizjak wrote: > > On Tue, Dec 11, 2018 at 8:54 AM Jakub Jelinek wrote: > > > > > > On Tue, Dec 11, 2018 at 08:44:00AM +0100, Uros Bizjak wrote: > > > > > --- gcc/config/i386/i386.md.jj 2018-11

Re: [PATCH] Make LTO tests that require recent binutils UNSUPPORTED with older ones (PR lto/86004)

On Tue, Dec 11, 2018 at 08:52:12AM +0100, Rainer Orth wrote: > Hi Jakub, > > > As mentioned in the PR, older binutils (like 2.25) complain on these tests > > when using -r that: > > plugin needed to handle lto object > > The following patch introduces an effective target and guards those tests on

Re: [PATCH] PR86957

Hi Indu! I recently saw that you just started contributing to GCC, so: welcome, and enjoy to journey! On Mon, 10 Dec 2018 12:54:09 -0800, Indu Bhagat wrote: > On 12/06/2018 05:54 PM, Indu Bhagat wrote: > > [...] Thanks for looking into this issue again. As I said in private email, such things

Re: [PATCH] Make LTO tests that require recent binutils UNSUPPORTED with older ones (PR lto/86004)

Hi Jakub, > On Tue, Dec 11, 2018 at 08:52:12AM +0100, Rainer Orth wrote: >> Hi Jakub, >> >> > As mentioned in the PR, older binutils (like 2.25) complain on these tests >> > when using -r that: >> > plugin needed to handle lto object >> > The following patch introduces an effective target and gua

[PATCH 3/9] [libbacktrace] Handle alt FORMS without .gnu_debugaltlink

Handle DW_FORM_GNU_strp_alt and DW_FORM_GNU_ref_alt references robustly in presence of missing .gnu_debugaltlink file. 2018-11-11 Tom de Vries * dwarf.c (enum attr_val_encoding): Add ATTR_VAL_NONE. (read_attribute): Add altlink parameter. Handle missing altlink for DW_

[PATCH 0/9] [libbacktrace] Handle .gnu_debugaltlink

[ Part of this patch series was earlier posted as "[libbacktrace] Handle DW_FORM_GNU_strp_alt" here ( https://gcc.gnu.org/ml/gcc-patches/2018-11/msg01091.html ). This patch series is based on the patch series submitted here ( https://gcc.gnu.org/ml/gcc-patches/2018-11/msg01091.html). It needs the

[PATCH 2/9] [libbacktrace] Add altlink field to struct dwarf_data

Add an altlink field to struct dwarf_data, and initialize it with the pointer to the struct dwarf_data for the .gnu_debugaltlink. 2018-11-11 Tom de Vries * dwarf.c (struct dwarf_data): Add altlink field. (backtrace_dwarf_add): Add and handle fileline_entry and fileline_

[PATCH 4/9] [libbacktrace] Handle DW_FORM_GNU_strp_alt

Handle DW_FORM_GNU_strp_alt which references the .debug_str section in the .gnu_debugaltlink file. 2018-11-11 Tom de Vries * dwarf.c (read_attribute): Handle DW_FORM_GNU_strp_alt using altlink. --- libbacktrace/dwarf.c | 25 + 1 file changed, 17 inserti

[PATCH 1/9] [libbacktrace] Read .gnu_debugaltlink

Read the elf file pointed at by the .gnu_debugaltlink section, and verify that the build id matches. 2018-11-11 Tom de Vries * elf.c (elf_add): Add and handle with_buildid_data and with_buildid_size parameters. Handle .gnu_debugaltlink section. (phdr_callback, backtrac

[PATCH 6/9] [libbacktrace] Factor out read_referenced_name_1

Factor out the common handling of DW_AT_abstract_origin and DW_AT_specification from read_function_entry and read_referenced_name. 2018-12-10 Tom de Vries * dwarf.c (read_referenced_name_1): New function. Factor out of ... (read_referenced_name): ... here, and ... (rea

[PATCH 7/9] [libbacktrace] Handle DW_FORM_GNU_ref_alt

2018-12-10 Tom de Vries * dwarf.c (enum attr_val_encoding): Add ATTR_VAL_REF_ALT_INFO. (struct unit): Add low and high fields. (struct unit_vector): New type. (struct dwarf_data): Add units and units_counts fields. (read_attribute): Handle DW_FORM_GNU_ref

[PATCH 5/9] [libbacktrace] Unify function name preference handling

Both read_function_entry and read_referenced_name implement a priority scheme for names. The priorities are: - 1st: DW_AT_linkage_name - 2nd: Name from DW_AT_abstract_origin or DW_AT_specification - 3rd: DW_AT_name. Ensure both functions fully adhere to it. 2018-11-21 Tom de Vries *

[PATCH 9/9] [libbacktrace] Add printdwarftest_dwz_cmp.sh test-case

2018-12-10 Tom de Vries * Makefile.am (TESTS): Add printdwarftest_dwz_cmp.sh. * Makefile.in: Regenerate. * printdwarftest.c: New file. * printdwarftest_dwz_cmp.sh: New file. --- libbacktrace/Makefile.am | 11 ++ libbacktrace/Makefile.in

Re: [Ada] Gigi support for OpenACC pragmas

(A message that remained in my drafts box) > On 3 Dec 2018, at 16:50, Pierre-Marie de Rodat wrote: > > Matching front-end bits to support Acc_Kernels, Acc_Parallel, > Acc_Loop and Acc_Data. Note that this was all originally contributed by Ghujan Lacambre () Olivier

[PATCH 8/9] [libbacktrace] Add btest_dwz test-case

2018-11-11 Tom de Vries * configure.ac (DWZ): Set with AC_CHECK_PROG. (HAVE_DWZ): Set with AM_CONDITIONAL. * configure: Regenerate. * Makefile.am (TESTS): Add btest_dwz. * Makefile.in: Regenerate. --- libbacktrace/Makefile.am | 12 ++ libbacktra

[PATCH 0/2][ARC] Fixes needed for the upcomming release.

Hi Andrew, Please find two small patches which are fixing a number of issues found in the upcomming release. Ok to apply? Claudiu Claudiu Zissulescu (2): [ARC] Fix REG_CLASS_NAMES [ARC] Fix millicode wrong blink restore. gcc/config/arc/arc.c | 4 +--- gcc/config/arc/arc

[PATCH 2/2] [ARC] Fix millicode wrong blink restore.

The blink is restored wrongly when using millicode and regular load instructions. gcc/ -xx-xx Claudiu Zissulescu * config/arc/arc.c (arc_restore_callee_milli) Don't clobber off variable. testsuite/ -xx-xx Claudiu Zissulescu * gcc.target/arc/milli-1.c: New t

[PATCH 1/2] [ARC] Fix REG_CLASS_NAMES

Forgot a class name, fix it. gcc/ -xx-xx Claudiu Zissulescu * config/arc/arc.h (REG_CLASS_NAMES): Add SIBCALL_REGS. --- gcc/config/arc/arc.h | 1 + 1 file changed, 1 insertion(+) diff --git a/gcc/config/arc/arc.h b/gcc/config/arc/arc.h index 4d01c99a540..80e785e6562 100644 ---

[PATCH] TLC to ccmp.c

Not sure who approved that... Bootstrap & regtest running on x86_64-unknown-linux-gnu. Richard. 2018-12-11 Richard Biener * ccmp.c (ccmp_candidate_p): Use GIMPLE API properly. Index: gcc/ccmp.c === --- gcc/ccmp.c (re

Re: [ARM/FDPIC v4 00/20] FDPIC ABI for ARM

Ping? On 03/12/2018 10:19, Christophe Lyon wrote: Ping? The series started here: https://gcc.gnu.org/ml/gcc-patches/2018-11/msg01464.html Thanks, Christophe On Mon, 26 Nov 2018 at 11:14, Christophe Lyon wrote: Ping? Thanks On Fri, 16 Nov 2018 at 16:48, Christophe Lyon wrote: From: C

[PATCH] Rip out rhs-to-tree from tree-affine.c

After the previous cleanup the following is more straight-forward now. This should make tree-affine behave wrt the "new" GIMPLE world. Bootstrapped and tested on x86_64-unknown-linux-gnu, now making sure there are no codegen changes as expected. Richard. 2018-12-11 Richard Biener *

Re: [PATCH] Set DEMANGLE_RECURSION_LIMIT to 1536

On 12/11/2018 12:33 AM, Jeff Law wrote: > Actually I would strongly suggest avoiding alloca completely. This > isn't particularly performance sensitive code On the contrary, the demangler is very performance-sensitive code for GDB. See

Re: [PATCH] Set DEMANGLE_RECURSION_LIMIT to 1536

On 12/11/2018 06:58 AM, Jakub Jelinek wrote: > On Mon, Dec 10, 2018 at 05:33:19PM -0700, Jeff Law wrote: where di.num_comps is just strlen (mangled) * 2. Without any analysis whatsoever, bumping the "recursion" limit will just mean we can process 1.5 times long names. Either we nee

[PATCH] Fix PR88448

The following should fix PR88448, I've reverted the semantics changing part of the gimple_assign_set_rhs_* previous change settling for an alternate fix for the tree-complex.c issue. Bootstrap & regtest in progress on x86_64-unknown-linux-gnu. Richard. 2018-12-11 Richard Biener PR

[aarch64] PR target/87369 Prefer bsl/bit/bif for copysign

The copysign operations will almost always be performed on values in floating-point registers. As such, we do not want the compiler to simplify the operations into code sequences that can only be done using the general-purpose register set. Unfortunately, this is what is currently happening. For

[Ada] Suppress call to Initial_Condition when the annotation is ignored

This patch suppresses the generation of the Initial_Condition procedure tasked with verifying the run-time semantics of the pragma when the pragma is ignored by means of -gnata, pragma Assertion_Policy, etc. -- Source -- -- all_asserts_off.adc pragma Assertion_Policy (

[Ada] Crash on nesting of subunits with bodies acting as specs

This patch corrects an issue whereby a set of nested subunits including subprogram subunits acting as bodies would cause a crash when a child subunit "withs" an ansestor in certain instances due to a mismanagment of the scope stack. -- Source -- -- w.ads package W is e

[Ada] Fix an ICE on instantiated subprogram with -gnatc

The following should compile quietly: $ gcc -c p-proc.ads -gnatc procedure P.Proc is new G; with Q; package P is generic procedure G; end P; with System; with Unchecked_Conversion; package Q is generic package Inner_G is type T is access all Integer; function Cnv is new Unche

[Ada] Remove vxworks*-crtbe-link.spec

The VxWorks crtbe are now part of libgcc, needed to support C++ on this target. Tested on x86_64-pc-linux-gnu, committed on trunk 2018-12-11 Jerome Lambourg gcc/ada/ * Makefile.rtl, gcc-interface/Makefile.in: Remove crtbe bits for VxWorks. * libgnat/system-vxworks-arm

[Ada] Spurious visibility error on aspect Predicate

The GNAT-defined aspect Predicate has the same semantics as the Ada aspect Dynamic_Predicate, including direct visibility to the components of a record type to which the aspect applies. The following must compile quietly: gcc -c integer_stacks.ads pragma SPARK_Mode (On); with Bounded_St

[Ada] Spurious errors on aspect specifications in generic units

This patch fixes spurious errors on aspect specifications on record types when the aspect expression references a component of the type that is not a discriminant. The patch also cleans up the legality checks on aspect specifications, and improves error message on illegal aspect specifications whos

[Ada] Additionsal trasformations for unnesting in package bodies

This patch extends the previous algorithm for creating an explicit elaboration procedure for a package body when expansion generates subprograms in the statement part of the body. For unnesting to work properly, these subprograms must appear within an explicit subprogram body so that uplevel refere

[Ada] Better error message from GNATprove on illegal switch

When a compilation switch is wrongly passed to GNATprove without the leading hyphen, this patch issues a clear error message instead of the obscure 'usage' message previously displayed. There is no impact on compilation. Tested on x86_64-pc-linux-gnu, committed on trunk 2018-12-11 Yannick Moy

[Ada] Stubs that complete generic subprogram do have a "prior declaration"

The intuition behind the Is_Subprogram_Stub_Without_Prior_Declaration utility routine is to detect stubs that act as subprogram declarations and False on stubs that act as completions. This behaviour is now fixed for stubs that correspond to generic subprogram declarations. This patch affects a ro

[Ada] Support access types in GNATprove

SPARK RM has been updated to support access types in SPARK. Part of this support is that now SPARK RM 3.1 lists access types as having full default initialization. Now updated. There is no impact on compilation. Tested on x86_64-pc-linux-gnu, committed on trunk 2018-12-11 Yannick Moy gcc/ada

[Ada] Complete implementation of RM C.6(19) clause

This ensures that the compiler fully implements the C.6(19) clause of the Ada Reference Manual and gives a warning when the clause does change the passing mechanism of the affected parameter. Tested on x86_64-pc-linux-gnu, committed on trunk 2018-12-11 Eric Botcazou gcc/ada/ * fe.h (

[Ada] Remove vxlink and vxaddr2line from this repository

Those tools need a dedicated repository as they're VxWorks specific and not related with the Ada front-end. Tested on x86_64-pc-linux-gnu, committed on trunk 2018-12-11 Jerome Lambourg gcc/ada/ * vxaddr2line.adb, vxlink-bind.adb, vxlink-bind.ads, vxlink-link.adb, vxlink-link.

[Ada] Crash on ignored Ghost expression function

This patch updates freezing to ensure that freeze nodes are inserted into the tree when the entity being frozen is non-Ghost, and the context is an ignored Ghost spec expression. Tested on x86_64-pc-linux-gnu, committed on trunk 2018-12-11 Hristian Kirtchev gcc/ada/ * exp_util.adb (I

[Ada] Crash on generic instantiation in ignored Ghost context

The following patch corrects the freezing of entities to properly preserve all freeze nodes in case of recursive freezing when the context is ignored Ghost, and the construct frozen is non-Ghost. Tested on x86_64-pc-linux-gnu, committed on trunk 2018-12-11 Hristian Kirtchev gcc/ada/

[Ada] Crash on compilation unit function that builds in place

This patch fixes a crash on a function that builds its limited result in place. Previously this was handled properly only if the function was a child unit. Tested on x86_64-pc-linux-gnu, committed on trunk 2018-12-11 Ed Schonberg gcc/ada/ * sem_ch3.adb (Build_Itype_Reference): Handle

[Ada] Missing predicate check on declaration with aggregate expression

This patch adds a missing predicate check on the initial value of an object whose declaration initializes the object with an aggregate. Such a declaration is marked No_Initialization to prevent a call to a default initialization procedure, but the check is needed on the value of the aggregate. Exe

[Ada] gnatbind: ghost code with -gnatQ

This patch fixes a bug where if a library unit is compiled with -gnatQ, and that library unit is an ignored Ghost unit, then gnatbind silently fails. Tested on x86_64-pc-linux-gnu, committed on trunk 2018-12-11 Bob Duff gcc/ada/ * gnat1drv.adb (gnat1drv): Pass the correct Object valu

[Ada] Fix setting of Has_Predicate flag for aggregate subtypes

This patch enures that the subtype of an aggregate has the Has_Predicate flag properly set if the array component has a predicate, including the case the predicate function for the component has not been constructed yet. Tested on x86_64-pc-linux-gnu, committed on trunk 2018-12-11 Ed Schonberg

[Ada] Plug small loophole with pathological packed array type

This fixes a crash in gigi on a pathological packed array type, whose component type is a record type without representation clause or packing but with a clause that bumps its size to a non-multiple value of the storage unit. In this case, the front-end fails to detect that calls to the packing ma

[Ada] Volatility, validity checks, and System.Aux_DEC

This patch updates validity checks to prevent the validation of an by-reference formal parameter because the parameter is not being read in the process. Tested on x86_64-pc-linux-gnu, committed on trunk 2018-12-11 Hristian Kirtchev gcc/ada/ * checks.adb: Add with and use clauses for

[Ada] Improve error message when named number passed as global item

When a named number is used in Global/Depends contracts as global item, the error message could be confusing to users new to Ada. Now the message explains that named numbers are not objects. For instance on the following illegal code snippet: $ gcc -c bad_global.ads 1. package Bad_Glob

[Ada] Do not expand code inside ignored ghost bodies

While ignored ghost code is not compiled into the executable, it may lead to compilation errors when it makes use of language features requiring runtime support that is not available in the available runtime library. These errors are spurious, as the executable will never call in these runtime uni

[Ada] Spurious error with pragma Thread_Local_Storage

The following patch modifies the checks related to pragma Thread_Local_Storage to correct a confusion in semantics which led to spurious errors. -- Source -- -- pack.ads package Pack is type Arr is array (1 .. 5) of Boolean; type Arr_With_Default is array (1 ..

[Ada] Crash on misplaced First operation for GNAT iterable type

This patch improves the handling of an improper declaaration of aspect First for a GNAT-defined iterable type, Tested on x86_64-pc-linux-gnu, committed on trunk 2018-12-11 Ed Schonberg gcc/ada/ * sem_util.adb (Get_Actual_Subtype): Function can return type mark. (Get_C

[Ada] Add "Global => null" contracts to Ada.Calendar routines

Routines in Ada.Real_Time are already annotated with Global => null contracts to suppress spurious warnings from the flow analysis in GNATprove. This patch adds such contracts to Ada.Calendar. No change in runtime behavior expected. Tested on x86_64-pc-linux-gnu, committed on trunk 2018-12-11 Pi

Re: [Ada] Add "Global => null" contracts to Ada.Calendar routines

* Pierre-Marie de Rodat: > procedure Split > (Date: Time; >Year: out Year_Number; >Month : out Month_Number; >Day : out Day_Number; > - Seconds : out Day_Duration); > + Seconds : out Day_Duration) > + with > + Global => null; Is this

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84762

Hi All, Please find the attached patch for the subjected issue . Do please let me know your thoughts and comments on the same . Thank you ~Umesh pr84762.patch Description: Binary data

Re: [Ada] Add "Global => null" contracts to Ada.Calendar routines

On Tue, 11 Dec 2018 12:48:15 +0100, Florian Weimer wrote: > * Pierre-Marie de Rodat: > > > procedure Split > > (Date: Time; > >Year: out Year_Number; > >Month : out Month_Number; > >Day : out Day_Number; > > - Seconds : out Day_Duration); > > +

Re: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84762

On Tue, Dec 11, 2018 at 05:30:48PM +0530, Umesh Kalappa wrote: > Hi All, > > Please find the attached patch for the subjected issue . > > Do please let me know your thoughts and comments on the same . Not a patch review (will defer that to rs6000 maintainers), but some comments on gcc-patches pa

Re: [C PATCH] Fix ubsan -fsanitize=float-cast-overflow ICE (PR sanitizer/88426)

On Tue, Dec 11, 2018 at 08:21:50AM +0100, Jakub Jelinek wrote: > Hi! > > The following testcase ICEs since the c_save_expr removal. Unlike other > spots where we use save_expr and potentially pass that to function ubsan > calls, in this case we weren't calling c_fully_fold and > c_fully_fold_inte

Re: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84762

On 11/12/18 13:28 +0100, Jakub Jelinek wrote: On Tue, Dec 11, 2018 at 05:30:48PM +0530, Umesh Kalappa wrote: Hi All, Please find the attached patch for the subjected issue . Do please let me know your thoughts and comments on the same . Not a patch review (will defer that to rs6000 maintaine

Re: Too strict synchronization with the local (host) thread?

On 2018/12/7 11:56 PM, Thomas Schwinge wrote: --- a/libgomp/testsuite/libgomp.oacc-c-c++-common/lib-79.c +++ b/libgomp/testsuite/libgomp.oacc-c-c++-common/lib-79.c @@ -114,6 +114,7 @@ main (int argc, char **argv) for (i = 0; i < N; i++) { + stream = (CUstream) acc_get_cuda_stre

Re: [PATCH] Delete powerpcspe

On 12/11/18 1:44 AM, Richard Biener wrote: > On Mon, Dec 10, 2018 at 9:13 PM Segher Boessenkool > wrote: >> >> On Mon, Dec 10, 2018 at 06:25:31PM +, Andrew Jenner wrote: >>> Sorry for the slow response on this, I was on vacation last week. >>> >>> On 03/12/2018 21:48, Jakub Jelinek wrote:

Re: [PATCH 4/6, OpenACC, libgomp] Async re-work, libgomp/target.c changes (revised, v2)

On 2018/12/7 1:43 AM, Jakub Jelinek wrote: On Thu, Dec 06, 2018 at 06:21:16PM +0100, Thomas Schwinge wrote: On Tue, 25 Sep 2018 21:11:24 +0800, Chung-Lin Tang wrote: Hi Jakub, This part has changes to 'struct goacc_asyncqueue*' arguments to various memory copying/mapping functions. To lessen

Re: [PATCH 6/6, OpenACC, libgomp] Async re-work, nvptx changes (revised, v2)

On 2018/12/10 6:02 PM, Chung-Lin Tang wrote: On 2018/12/7 04:57 AM, Thomas Schwinge wrote>> --- a/libgomp/plugin/plugin-nvptx.c +++ b/libgomp/plugin/plugin-nvptx.c +struct goacc_asyncqueue * +GOMP_OFFLOAD_openacc_async_construct (void) +{ +  struct goacc_asyncqueue *aq +    = GOMP_PLUGIN_mal

Re: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84762

Hi Umesh, On Tue, Dec 11, 2018 at 05:30:48PM +0530, Umesh Kalappa wrote: > Please find the attached patch for the subjected issue . > > Do please let me know your thoughts and comments on the same . First of all: do you have a copyright assignment with the FSF? Second: please don't send applica

Re: [PATCH] Set DEMANGLE_RECURSION_LIMIT to 1536

On Tue, Dec 11, 2018 at 3:05 AM Pedro Alves wrote: > > I noticed that the comment on top of __cxa_demangle says: > > "If OUTPUT_BUFFER is not long enough, it is expanded using realloc." > > and __cxa_demangle calls 'free'. > > And d_demangle, seemingly the workhorse for __cxa_demangle says: > >

Re: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84762

Thank you Jakub for the information. Will make a note of it. Umesh On Tue, Dec 11, 2018, 17:58 Jakub Jelinek On Tue, Dec 11, 2018 at 05:30:48PM +0530, Umesh Kalappa wrote: > > Hi All, > > > > Please find the attached patch for the subjected issue . > > > > Do please let me know your thoughts

Re: [gofrontend-dev] Re: libgo patch committed: Add precise stack scan support

On 10.12.18 16:54, Cherry Zhang wrote: > On Mon, Dec 10, 2018 at 1:41 AM Matthias Klose wrote: > >> On 06.12.18 00:09, Ian Lance Taylor wrote: >>> This libgo patch by Cherry Zhang adds support for precise stack >>> scanning to the Go runtime. This uses per-function stack maps stored >>> in the e

Fix alignment of dynamically allocated stack areas on ppc-vxworks

Hello, The attached patch, provided by Eric Botcazou (thanks!), installs definitions of RS6000_STARTING_FRAME_OFFSET and STACK_DYNAMIC_OFFSET for PowerPC VxWorks, which has STACK_BOUNDARY set to 128 unconditionally. AFAICS, this is the third OS config file doing this, after Darwin and AIX. It see

Re: [PATCH] Set DEMANGLE_RECURSION_LIMIT to 1536

On 12/11/2018 02:25 PM, Ian Lance Taylor wrote: > On Tue, Dec 11, 2018 at 3:05 AM Pedro Alves wrote: >> Ian earlier mentioned that we've wanted to avoid malloc because some >> programs call the demangler from a signal handler, but it seems like >> we already do, these functions already aren't saf

Re: [PATCH, OpenACC] Add support for gang local storage allocation in shared memory

On Fri, 17 Aug 2018 18:39:00 +0200 Bernhard Reutner-Fischer wrote: > On 16 August 2018 17:46:43 CEST, Julian Brown > wrote: > >On Wed, 15 Aug 2018 21:56:54 +0200 > >Bernhard Reutner-Fischer wrote: > > > >> On 15 August 2018 18:46:37 CEST, Julian Brown > >> wrote: > >> >On Mon, 13 Aug 2018

Re: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84762

Thank you Segher, will work on your suggestions. Umesh On Tue, Dec 11, 2018, 19:23 Segher Boessenkool Hi Umesh, > > On Tue, Dec 11, 2018 at 05:30:48PM +0530, Umesh Kalappa wrote: > > Please find the attached patch for the subjected issue . > > > > Do please let me know your thoughts and comments

Re: [PATCH] accept all C integer types in function parameters referenced by alloc_align (PR 88363)

On 12/11/18 2:17 AM, Jakub Jelinek wrote: On Mon, Dec 10, 2018 at 04:30:11PM -0700, Martin Sebor wrote: Some of my testing exposed a minor problem in GCC 9's validation of the type of function parameters referred to by attribute positional arguments. Whereas GCC 8 accepts all C integer types, i

Re: C++ PATCH for c++/86608, reading constexpr volatile variable

On 12/10/18 8:48 PM, Marek Polacek wrote: A template-argument for a non-type template-parameter shall be a converted constant expression. But an lvalue-to-rvalue conversion applied to a volatile glvalue is not allowed to be part of the evaluation of a constant expression. So this test should be

Re: [PATCH 2/4] c/c++, asm: Use nicer error for duplicate asm qualifiers

On Mon, 2018-12-10 at 22:47 +, Segher Boessenkool wrote: [...] > diff --git a/gcc/c/c-parser.c b/gcc/c/c-parser.c > index 121a91c..652e53c 100644 > --- a/gcc/c/c-parser.c > +++ b/gcc/c/c-parser.c > @@ -6360,41 +6360,54 @@ c_parser_for_statement (c_parser *parser, > bool ivdep, unsigned short

Re: [PATCH] accept all C integer types in function parameters referenced by alloc_align (PR 88363)

On Tue, Dec 11, 2018 at 08:17:26AM +0100, Jakub Jelinek wrote: > On Mon, Dec 10, 2018 at 04:30:11PM -0700, Martin Sebor wrote: > > Some of my testing exposed a minor problem in GCC 9's validation > > of the type of function parameters referred to by attribute > > positional arguments. Whereas GCC

[PATCH 9/9][GCC][Arm] Add ACLE intrinsics for complex mutliplication and addition

Hi All, This patch adds NEON intrinsics and tests for the Armv8.3-a complex multiplication and add instructions with a rotate along the Argand plane. The instructions are documented in the ArmARM[1] and the intrinsics specification will be published on the Arm website [2]. The Lane versions of

[PATCH 6/9][GCC][AArch64] Add Armv8.3-a complex intrinsics

Hi All, This patch adds NEON intrinsics and tests for the Armv8.3-a complex multiplication and add instructions with a rotate along the Argand plane. The instructions are documented in the ArmARM[1] and the intrinsics specification will be published on the Arm website [2]. The Lane versions of

Re: C++ PATCH for c++/88216, ICE with class type in non-type template parameter

On 12/10/18 2:52 PM, Marek Polacek wrote: + if (processing_template_decl && value_dependent_expression_p (expr)) You don't need to check processing_template_decl before value_dependent_expression_p. I would lean toward checking for value-dependence in convert_nontype_argument, which alread

Re: [PATCH 2/4] c/c++, asm: Use nicer error for duplicate asm qualifiers

On Tue, 2018-12-11 at 10:35 -0500, David Malcolm wrote: > On Mon, 2018-12-10 at 22:47 +, Segher Boessenkool wrote: > > [...] > > > diff --git a/gcc/c/c-parser.c b/gcc/c/c-parser.c > > index 121a91c..652e53c 100644 > > --- a/gcc/c/c-parser.c > > +++ b/gcc/c/c-parser.c > > @@ -6360,41 +6360,54

Re: [C++ Patch] Add location_t parameter to grokvardecl

On 12/10/18 5:23 AM, Paolo Carlini wrote: Hi, the other day I noticed that we weren't getting right the first location of pr53037-4.C, for a variable, whereas the next one, for a function, was Ok. Indeed, we were passing a location only to grokfndecl. In other terms, I found a good empirical

Re: [PATCH] [RFC] PR target/52813 and target/11807

Dimitar Dimitrov writes: > On понеделник, 10 декември 2018 г. 11:21:53 EET Richard Sandiford wrote: >> Dimitar Dimitrov writes: >> > I have tested this fix on x86_64 host, and found no regression in the C >> > and C++ testsuites. I'm marking this patch as RFC simply because I don't >> > have exp

PING^2: [PATCH] i386; Add -mmanual-endbr and cf_check function attribute

On Mon, Dec 3, 2018 at 5:45 AM H.J. Lu wrote: > > On Mon, Jun 18, 2018 at 2:20 AM Richard Biener > wrote: > > > > On Fri, Jun 15, 2018 at 2:59 PM H.J. Lu wrote: > > > > > > Currently GCC inserts ENDBR instruction at entries of all non-static > > > functions, unless LTO compilation is used. Mark

Re: [PATCH, ARM] Improve robustness of -mslow-flash-data

Hi Kyrill, I've tested on armeb-none-eabi with -mslow-flash-data for both -mfloat-abi=hard and -mfloat-abi=soft. Both show no regression and the former shows some new PASS. Regarding the part you are hesitant about, the code was taken from aarch64_reinterpret_float_as_int in config/aarch64/aarch6

Re: PR88346, Inconsistent list of CPUs supported by the rs6000 backend after r266502

On Mon, Dec 10, 2018 at 6:17 PM Segher Boessenkool wrote: > > Hi Alan, > > Let's ask David? (Cc:ed). Strange that no one noticed powerpc64 before; > titan and rs64 aren't so strange though ;-) The patch is okay with me. Thanks for catching the renaming and the processor missing from the list. I

Re: [PATCH 1/3][GCC] Add new target hook asm_post_cfi_startproc

On 11/5/18 10:18 AM, Sam Tebbs wrote: > On 11/05/2018 07:54 AM, Richard Biener wrote: >> On Fri, 2 Nov 2018, Sam Tebbs wrote: >> >>> On 11/02/2018 05:28 PM, Sam Tebbs wrote: >>> Hi all, This patch adds a new target hook called "asm_post_cfi_startproc". This hook is intend

[PATCH] Add TREE_CODE == SSA_NAME checks to register_edge_assert_for_2 (PR tree-optimization/88444)

Hi! Most spots in vr-values* and tree-vrp* check if convert rhs1 is SSA_NAME, but these 3 spots don't. It can appear if some pass doesn't fold stmts after changing them. Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? 2018-12-11 Jakub Jelinek PR tree-optimizatio

Re: [PATCH] Add TREE_CODE == SSA_NAME checks to register_edge_assert_for_2 (PR tree-optimization/88444)

On Tue, 11 Dec 2018, Jakub Jelinek wrote: > Hi! > > Most spots in vr-values* and tree-vrp* check if convert rhs1 is SSA_NAME, > but these 3 spots don't. It can appear if some pass doesn't fold stmts > after changing them. > > Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk?

[C++ PATCH] Fix up __builtin_is_constant_evaluated (PR c++/88449)

Hi! While working on the libstdc++ patch for P0595R2, I've noticed that while __builtin_is_constant_evaluated () directly works, when wrapped into an constexpr inline noexcept function, it in some cases doesn't. The problem is that the constexpr call cache didn't take ctx->pretend_const_required

[PATCH] Add std::is_constant_evaluated wrapper around __builtin_is_constant_evaluated

Hi! The following patch adds std::is_constant_evaluated to the library. Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? (relies on the previously posted C++ FE patch). 2018-12-11 Jakub Jelinek P0595R2 - is_constant_evaluated * include/bits/c++config (_GLI

[C++ PATCH] Fix up __builtin_is_constant_evaluated handling in array type sizes (PR c++/88446)

Hi! As mentioned in the PR, while we allow VLAs in some contexts in C++ as an extension, they aren't standard and the standard requires in those spots constant expressions, thus __builtin_is_constant_evaluated () needs to be true if those sizes are indeed constant expressions. Fixed by calling cx

[PATCH] Fix cleanup_auto_inc_dec on x86 (PR rtl-optimization/88416)

Hi! As mentioned in the PR, x86 (maybe a couple of other targets) isn't an AUTO_INC_DEC target, it doesn't have REG_INC notes nor wants the generic code to synthetize any pre/post inc/dec/modify, but does support push/pop patterns that use those RTL codes. If unlucky enough, as on the following t

Re: [PATCH] accept all C integer types in function parameters referenced by alloc_align (PR 88363)

On 12/11/18 12:17 AM, Jakub Jelinek wrote: On Mon, Dec 10, 2018 at 04:30:11PM -0700, Martin Sebor wrote: Some of my testing exposed a minor problem in GCC 9's validation of the type of function parameters referred to by attribute positional arguments. Whereas GCC 8 accepts all C integer types,

Re: [PATCH] Add std::is_constant_evaluated wrapper around __builtin_is_constant_evaluated

On 11/12/18 17:35 +0100, Jakub Jelinek wrote: Hi! The following patch adds std::is_constant_evaluated to the library. Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? (relies on the previously posted C++ FE patch). 2018-12-11 Jakub Jelinek P0595R2 - is_constant_

[PATCH] Fix up split-path-11.c testcase (Re: [committed] [PR tree-optimization/80520] Throttle path splitting slightly.)

On Mon, Dec 10, 2018 at 09:56:46PM -0700, Jeff Law wrote: > commit d90b13427e4940adabc4320c68ca88513dee2eef > Author: Jeff Law > Date: Mon Dec 10 21:46:41 2018 -0700 > > PR tree-optimization/80520 > * gimple-ssa-split-paths.c (is_feasible_trace): Recognize half >

Re: [PATCH 2/4] c/c++, asm: Use nicer error for duplicate asm qualifiers

+ { + error_at (loc, "duplicate asm qualifier %qE", token->value); We have been making an effort to quote keywords, identifiers, option names, and other such things in diagnostics. In the message above and all others like it in this patch kit that mention "asm" the keyword

Re: [PATCH][libbacktrace] Add allocfail.sh test-case

On Wed, Nov 28, 2018 at 4:50 AM Tom de Vries wrote: > > Add test-case that forces alloc.c functions to fail, and check whether fail > handling is robust. > > This is the test-case for "[libbacktrace] Fix segfault upon allocation > failure". Without that patch, this test-case fails like this: > ..

  1   2   >