Stream TREE_TYPE of TYPE_DECLs again

2018-11-20 Thread Jan Hubicka
Hi, this patch recovers location infomration in the ODR warnings. Because location info is not attached to types but corresponding TYPE_DECLs, we need to prevent TYPE_DECLs to be merged when corresponding types are not merged. To achieve this I no longer clear TREE_TYPE of TYPE_DECLs which puts th

Re: [maintainer-scipts] Add a bugzilla script

2018-11-20 Thread Jeff Law
On 11/20/18 3:08 AM, Martin Liška wrote: > Hi. > > It's the script that I used to identify potentially resolvable bugs. That's > done > by parsing of comments and seeking for trunk/branch commits. Sample output > looks > as follows: > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88084 branc

Re: Fix PR37916 (unnecessary spilling)

2018-11-20 Thread Jeff Law
On 11/20/18 6:42 AM, Michael Matz wrote: > Hi, > > this bug report is about cris generating worse code since tree-ssa. The > effect is also visible on x86-64. The symptom is that the work horse of > adler32.c (from zlib) needs spills in the inner loop, while gcc 3 did not, > and those spills

Re: [PATCH v2, target]: Fix PR 88070, ICE in create_pre_exit, at mode-switching.c:438

2018-11-20 Thread Jeff Law
On 11/20/18 12:40 PM, Uros Bizjak wrote: > Hello! > > Attached patch is a different approach to the problem of split return > copies in create_pre_exit. It turns out that for vzeroupper insertion > pass, we actually don't need to insert a mode switch before the return > copy, it is enough to split

Re: [PATCH 5/6] ifcvt: Only created temporaries as needed.

2018-11-20 Thread Jeff Law
On 11/15/18 4:38 AM, Robin Dapp wrote: >> This looks pretty reasonable. ISTM it ought to be able to go forward if >> it's tested independently. > > The test suite already passes, any other tests you have in mind? To be > honest I suppose noce_convert_multiple_sets will currently never > successf

Re: [PATCH, ARM, ping3] PR85434: Prevent spilling of stack protector guard's address on ARM

2018-11-20 Thread Jeff Law
On 11/16/18 7:56 AM, Thomas Preudhomme wrote: > Ping? I thought I acked the target independent stuff a while back. What's still waiting on review here? jeff

Re: [PATCH] v3: C/C++: add fix-it hints for missing '&' and '*' (PR c++/87850)

2018-11-20 Thread Jeff Law
On 11/19/18 2:23 PM, David Malcolm wrote: [ Snip ] > > The above code is in c-family, but same_type_p is specific to C++, > so the change is not quite trivial. > > Here's a v3 of the patch which moves same_type_p from cp/cp-tree.h > to c-family/c-common.h, converting it from a macro to an extern

Re: [PATCH] v3: C/C++: add fix-it hints for missing '&' and '*' (PR c++/87850)

2018-11-20 Thread Martin Sebor
+void test_2 (void) +{ + takes_int_ptr(ivar); /* { dg-warning "" "" { target c } } */ + /* { dg-error "" "" { target c++ } .-1 } */ + /* { dg-message "possible fix: take the address with '&'" "" { target *-*-* } .-2 } */ + + /* Expect an '&' fix-it hint. */ + /* { dg-begin-multiline-output

Re: [PATCH] avoid error_mark_node in -Wsizeof-pointer-memaccess (PR 88065)

2018-11-20 Thread Jeff Law
On 11/19/18 5:36 PM, Martin Sebor wrote: > On 11/19/2018 04:10 PM, Jeff Law wrote: >> On 11/17/18 3:45 PM, Martin Sebor wrote: >>> -Wsizeof-pointer-memaccess fails with an ICE when one of >>> the arguments is ill-formed (error_mark_node).  To avoid >>> the error the attached patch has the function

Re: [maintainer-scipts] Add a bugzilla script

2018-11-20 Thread Martin Sebor
On 11/20/2018 03:08 AM, Martin Liška wrote: Hi. It's the script that I used to identify potentially resolvable bugs. That's done by parsing of comments and seeking for trunk/branch commits. Sample output looks as follows: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88084 branches: trunk

Re: [PATCH 01/10] Fix IRA ICE.

2018-11-20 Thread Jeff Law
On 11/16/18 9:27 AM, Andrew Stubbs wrote: > > This patch is unchanged from that which was posted before. Discussion > fizzled out there and I was too busy with other patches to restart it > then. This issue needs to be resolved before libgfortran can be > compiled for GCN. > > The IRA pass make

Re: [PATCH 03/10] GCN libgcc.

2018-11-20 Thread Jeff Law
On 11/16/18 9:27 AM, Andrew Stubbs wrote: > This patch contains the GCN port of libgcc. > > Since the previous posting, I've removed gomp_print.c and reduction.c, > as well as addressing some other feedback. > > 2018-11-16 Andrew Stubbs > Kwok Cheung Yeung > Julian Brown

Re: [PATCH 10/10] Port testsuite to GCN

2018-11-20 Thread Jeff Law
On 11/16/18 9:29 AM, Andrew Stubbs wrote: > This collection of miscellaneous patches configures the testsuite to run on > AMD > GCN in a standalone (i.e. not offloading) configuration. It assumes you have > your Dejagnu set up to run binaries via the gcn-run tool. > > 2018-11-16 Andrew Stubbs

Re: [PATCH][libbacktrace] Handle DW_FORM_GNU_strp_alt

2018-11-20 Thread Ian Lance Taylor
On Wed, Nov 14, 2018 at 6:45 AM, Tom de Vries wrote: > On 14-11-18 14:25, Jakub Jelinek wrote: >> On Wed, Nov 14, 2018 at 02:08:05PM +0100, Tom de Vries wrote: +btest_dwz_CFLAGS = $(AM_CFLAGS) -g -O0 >>> >>> Hmm, I already discovered that specifying the -O0 doesn't work, since >>> it's overri

compute discriminator info for overrides

2018-11-20 Thread Alexandre Oliva
In some cases of overriding or resetting locations, we might retain discriminator info from earlier locations, when we should take discriminator information from the overriding location or reset it. Regstrapped on x86_64-linux-gnu. Ok to install? for gcc/ChangeLog * final.c (compute_di

Re: [maintainer-scipts] Add a bugzilla script

2018-11-20 Thread David Malcolm
On Tue, 2018-11-20 at 11:08 +0100, Martin Liška wrote: > Hi. > > It's the script that I used to identify potentially resolvable bugs. > That's done > by parsing of comments and seeking for trunk/branch commits. Sample > output looks > as follows: > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id

libgo patch committed: Always define _AT_FDCWD and IPv6MTUInfo

2018-11-20 Thread Ian Lance Taylor
This libgo patch alwayss define _AT_FDCWD and IPv6MTUInfo in the syscall package. They aren't defined by old versions of glibc, but are required by the code in syscall_linux.go. This should fix GCC PR 88060. Bootstrapped and ran Go testsuite on x86_64-pc-linux-gnu. Committed to mainline. Ian In

Fix regression introduced by 88069

2018-11-20 Thread Jeff Law
Richi's recent change to fix 88069 is causing various targets to fail tree-ssa/20030711-2.c. That test is verifying a variety of optimizations occur during the first DOM pass. Prior to Richi's change FRE1 would do some significant cleanups of the IL and as a result DOM was fully able to optimize

Re: [PATCH 06/10] GCN back-end config

2018-11-20 Thread Jeff Law
On 11/16/18 9:28 AM, Andrew Stubbs wrote: > This patch contains the configuration adjustments needed to enable the GCN > back-end. > > The new configure check for dlopen is required to allow building the new > gcn-run tool. This tool uses libdl to load the HSA runtime libraries, which > are requi

Re: Stream TREE_TYPE of TYPE_DECLs again

2018-11-20 Thread Jan Hubicka
> PR lto/87957 > * tree.c (fld_decl_context): Break out from ... > (free_lang_data_in_decl): ... here; free TREE_PUBLIC, TREE_PRIVATE > DECL_ARTIFICIAL of TYPE_DECL; do not free TREE_TYPE of TYPE_DECL. > (fld_incomplete_type_of): Build copy of TYP_DECL. > * ipa-d

Re: [PATCH, middle-end]: Fix PR 88070, ICE in create_pre_exit, at mode-switching.c:438

2018-11-20 Thread Uros Bizjak
On Wed, Nov 21, 2018 at 12:50 AM Jeff Law wrote: > > + /* x86 targets use mode-switching infrastructure to > > + conditionally insert vzeroupper instruction at the exit > > + from the function and there is no need to switch the > > + mode before th

Re: Patch ping (Re: [PATCH] Fortran include line fixes and -fdec-include support)

2018-11-20 Thread Thomas Koenig
Hi Jakub, I'd like to ping this patch, ok for trunk? OK. Thanks for the patch! Before 9.0 is released, we should also document the flag (and the extension it supports) in the manual, and note it in changes.html and on the Wiki. Would you also do that? Regards Thomas

[Committed] S/390: Support vector load/store alignment hints

2018-11-20 Thread Andreas Krebbel
The IBM z14 POP adds an optional alignment operand to the vl, vst, vlm, and vstm instruction (vector loads and stores). Vectors residing on 8 or 16 byte boundaries might get loaded or stored faster on some models given the instruction uses the proper hint operand. A wrong hint will hurt performanc

<    1   2