[PATCH] Fix UB in store-merging or bswap opt (PR tree-optimization/87826)

Hi! When compiling code with UB shifts/rotates where the shift count is out of range constant, the store-merging and bswap opts will invoke UB in the compiler too. The following patch prevents that. Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk/8.x? 2018-11-01 Jakub Jeline

Re: [PATCH] Make __PRETTY_FUNCTION__-like functions mergeable string csts (PR c++/64266).

On 10/31/18 2:42 AM, Jason Merrill wrote: > On 10/29/18 9:37 AM, Jason Merrill wrote: >> On Fri, Oct 26, 2018 at 3:14 AM Martin Liška wrote: >>> On 10/24/18 7:24 PM, Jason Merrill wrote: On Tue, Oct 23, 2018 at 4:59 AM Martin Liška wrote: > However, I still see some minor ICEs, it's prob

Re: [PATCH] Remove extra memory allocation of strings.

On 10/23/18 3:17 PM, Martin Liška wrote: > Hello. > > As a follow up patch I would like to remove redundant string allocation > on string which is not needed in my opinion. > > That bootstrap on aarch64-linux. > > Martin > James may I please remind this small patch? Thanks, Martin

[PATCH] Fix simd.d/compilable.d tests on i686-linux (PR d/87824)

Hi! These two tests FAIL on i686-linux, because of extra warnings: /home/jakub/src/gcc/gcc/testsuite/gdc.dg/compilable.d:441:6: warning: MMX vector return without MMX enabled changes the ABI [-Wpsabi] /home/jakub/src/gcc/gcc/testsuite/gdc.dg/simd.d:1138:8: warning: SSE vector return without SSE

Re: introduce --enable-mingw-full32 to default to --large-address-aware

On 10/31/2018 10:39 PM, Alexandre Oliva wrote: > On Oct 12, 2018, Alexandre Oliva wrote: > >> * config/i386/mingw32.h (LINK_SPEC_LARGE_ADDR_AWARE): Define, >> based on MINGW_DEFAULT_LARGE_ADDR_AWARE. >> (LINK_SPEC): Insert it. >> * config/i386/mingw-264.h: Likewise. >

Re: [PATCH] Fix simd.d/compilable.d tests on i686-linux (PR d/87824)

On Thu, 1 Nov 2018 at 11:37, Jakub Jelinek wrote: > > Hi! > > These two tests FAIL on i686-linux, because of extra warnings: > /home/jakub/src/gcc/gcc/testsuite/gdc.dg/compilable.d:441:6: warning: MMX > vector return without MMX enabled changes the ABI [-Wpsabi] > /home/jakub/src/gcc/gcc/testsuit

Patches for gcc/fortran and libgfortran need to be discussed and approved on fortran mailing list

Hi, a gentle reminder: Patches which touch gcc/fortran or libgfortran need to be discussed on the fortran mailing list and approved by a reviewer. There have been a couple of commits recently where this wasn't followed, please remember to do so in the future. Regards Thomasa

[PATCH][BINUTILS][AARCH64] Add support for pointer authentication B key

Hi all, Armv8.3-A has another key used in pointer authentication called the B-key (other than the A-key that is already supported). In order for stack unwinders to work it is necessary to be able to identify frames that have been signed with the B-key rather than the A-key and it was felt that kee

Re: hash-table violation in cselib.c

I created PR87845 for that. Martin

Re: [PATCH][BINUTILS][AARCH64] Add support for pointer authentication B key

On 11/01/2018 11:56 AM, Sam Tebbs wrote: > Hi all, > > Armv8.3-A has another key used in pointer authentication called the B-key > (other > than the A-key that is already supported). In order for stack unwinders to > work > it is necessary to be able to identify frames that have been signed with

Re: hash-table violation in gcc/cp/pt.c

I created PR87847 for that. Martin

[fortran, patch, committed] Adjust error message

Hello world, I just adjusted the error message for BIND(C) functions which return strings of length > 1. I just used the suggestion from the PR. Committed as obvious and simple (although I managed to use up three revisions to do it right :-) Regards Thomas 2018-11-01 Thomas Koenig

Re: [PATCH] Verify that last argument of __builtin_expect_with_probability is a real cst (PR c/87811).

On 10/31/18 11:17 AM, Jakub Jelinek wrote: > On Wed, Oct 31, 2018 at 11:04:32AM +0100, Martin Liška wrote: >> Hi. >> >> As Jakub pointed out we should not ICE when last argument >> of __builtin_expect_with_probability is not a real cst. >> Plus I documented the behavior. > > That is not what you'v

Re: [PATCH] Verify that last argument of __builtin_expect_with_probability is a real cst (PR c/87811).

On Thu, Nov 01, 2018 at 01:09:16PM +0100, Martin Liška wrote: > -range 0.0 to 1.0, inclusive. > +range 0.0 to 1.0, inclusive. The @var{probability} argument must be > +a compiler time constant. When you say must, I think error_at should be used rather than warning_at. If others disagree I'm open

Re: [PATCH] Fix UB in store-merging or bswap opt (PR tree-optimization/87826)

On November 1, 2018 10:14:13 AM GMT+01:00, Jakub Jelinek wrote: >Hi! > >When compiling code with UB shifts/rotates where the shift count is out >of >range constant, the store-merging and bswap opts will invoke UB in the >compiler too. >The following patch prevents that. > >Bootstrapped/regtested

Re: [PATCH] Verify that last argument of __builtin_expect_with_probability is a real cst (PR c/87811).

On 11/1/18 1:15 PM, Jakub Jelinek wrote: > On Thu, Nov 01, 2018 at 01:09:16PM +0100, Martin Liška wrote: >> -range 0.0 to 1.0, inclusive. >> +range 0.0 to 1.0, inclusive. The @var{probability} argument must be >> +a compiler time constant. > > When you say must, I think error_at should be used ra

[PATCH][rs6000] cleanup and rename rs6000_address_for_fpconvert

This patch combines the duties of rs6000_address_for_fpconvert into rs6000_force_indexed_or_indirect_mem which I recently added, and changes all calls to use the latter. The new function name is more descriptive of what is actually going on. This now uses indexed_or_indirect_operand() to test the i

Re: [PATCH] Fix PRs70359/86270

On Wed, Oct 31, 2018 at 4:56 AM Richard Biener wrote: > > On Tue, 30 Oct 2018, Richard Biener wrote: > > > > > This picks up work from earlier this year where Aldy worked on > > undoing forwprop during out-of-SSA to improve coalescing across > > backedges. > > > > The following patch first rectifi

[PING**3] [PATCH] Fix not properly nul-terminated string constants in JIT

Ping... On 10/10/18 9:43 PM, Bernd Edlinger wrote: > Ping... > > > On 08/26/18 21:40, Bernd Edlinger wrote: >> Ping... >> >> This is just plain wrong, independent >> of any STRING_CST semantic issues. >> >> The original patch (retested on current trunk) is >> here: https://gcc.gnu.org/ml/gcc-pat

[PING] [PATCH] Fix PR 87672

Ping... I'd like to ping this patch: https://gcc.gnu.org/ml/gcc-patches/2018-10/msg01335.html Thanks Bernd. On 10/22/18 4:59 PM, Bernd Edlinger wrote: > Hi! > > This fixes an ICE which was exposed by a previous patch of mine, > and a wrong transformation from strcat_chk => strcpy_chk, > which

Re: [PATCH] Fix PR 86572

Ping... For this patch here: https://gcc.gnu.org/ml/gcc-patches/2018-10/msg01336.html Thanks Bernd. On 10/22/18 5:08 PM, Bernd Edlinger wrote: > Hi! > > This makes c_strlen avoid an unsafe strlen folding of const arguments > with non-const offset.  Currently a negative out of bounds offset > ma

[PATCH v3 0/3] PR preprocessor/83173: C preprocessor generates incorrect linemarkers

Hi, Changes in v3: I haven't gotten a response in several months, so I'm reposting these patches. I split up the enhancement to the -fdump-internal-locations output from the actual bugfix. Hopefully this will make these easier to review. I rebased these patches on the gcc master and had to make

[PATCH v3 1/3] PR preprocessor/83173: Additional check before decrementing highest_location

2018-10-31 Mike Gulick PR preprocessor/83173 * libcpp/files.c (_cpp_stack_include): Check if line_table->highest_location is past current line before decrementing. --- libcpp/files.c | 32 +++- 1 file changed, 23 insertions(+), 9 dele

[PATCH v3 2/3] PR preprocessor/83173: New test

2018-10-31 Mike Gulick PR preprocessor/83173 * gcc.dg/plugin/location-overflow-test-pr83173.c: New test. * gcc.dg/plugin/location-overflow-test-pr83173.h: Header for pr83173.c. * gcc.dg/plugin/location-overflow-test-pr83173-1.h: Header for pr83173

[PATCH v3 3/3] PR preprocessor/83173: Enhance -fdump-internal-locations output

2017-10-31 Mike Gulick PR preprocessor/83173 * gcc/input.c (dump_location_info): Dump reason and included_from fields from line_map_ordinary struct. Fix indentation when location > 5 digits. * libcpp/location-example.txt: Update example -fdump-i

Re: [PATCH, ARM, ping] PR85434: Prevent spilling of stack protector guard's address on ARM

Ping? Best regards, Thomas On Fri, 26 Oct 2018 at 22:41, Thomas Preudhomme wrote: > > Hi, > > Please find updated patch to fix PR85434: spilling of stack protector > guard's address on ARM. Quite a few changes have been made to the ARM > part since last round of review so I think it makes more s

Re: [PATCH][rs6000] cleanup and rename rs6000_address_for_fpconvert

Hi! On Thu, Nov 01, 2018 at 09:00:08AM -0500, Aaron Sawdey wrote: > (rs6000_address_for_fpconvert) Combine with > rs6000_force_indexed_or_indirect_mem. (missing colon) > rtx > -rs6000_address_for_fpconvert (rtx x) > +rs6000_force_indexed_or_indirect_mem (rtx x) > { > - rtx addr; >

CES 2019

Hi, I understand that you are one of the Exhibitors of "Consumer Electronics Show - CES 2019" taking place on DEC 8 - 11, 2019, at Las Vegas, NV. I was wondering if you would be interested in acquiring Consumer Electronics Show - CES 2019 - Attendees List for booth invites, drive qualified

Re: C++ PATCH to Implement P0846R0, ADL and function templates [v2]

On 10/31/18 6:45 PM, Marek Polacek wrote: On Mon, Oct 29, 2018 at 05:59:13PM -0400, Jason Merrill wrote: On 10/28/18 3:56 PM, Marek Polacek wrote: This patch implements P0846R0: ADL and Function Templates that are not Visible

[PATCH v2, middle end]: Fix PR58372, internal compiler error: ix86_compute_frame_layout

Hello! v2 of the patch hits the real problem: in pass_expand::execute finish_eh_generation is called after expand_stack_alignment is called. Construction of SjLj landing pads calls emit_library_call, which can change crtl->preferred_stack_boundary value after all dependant variables are already ca

[build] Remove SPARC HAVE_AS_REGISTER_PSEUDO_OP

The autoconf 2.69 upgrade broke Solaris/SPARC bootstrap with as: compiling stage1 libgcc fails with an assembler error: /usr/ccs/bin/as: "/var/tmp//ccYQ2Dxc.s", line 32: error: detect global register use not covered .register pseudo-op /usr/ccs/bin/as: "/var/tmp//ccYQ2Dxc.s", line 32: error: dete

[committed] Fix GIMPLE error in gcc.dg/tree-ssa/cunroll-13.c for 16-bit int

The test fails for msp430-elf which has 16-bit int by default. The test uses __INT32_TYPE__ in place of int, when __SIZEOF_INT__ < 4. gcc.dg/tree-ssa/cunroll-13.c: In function 't': gcc.dg/tree-ssa/cunroll-13.c:13:1: error: type mismatch in binary expression 13 | t (struct a * a) | ^ long

Re: [build] Remove SPARC HAVE_AS_REGISTER_PSEUDO_OP

On Thu, 1 Nov 2018, Rainer Orth wrote: > * One for ia64 in gcc_cv_as_ia64_ltoffx_ldxmov_relocs) ... > > $as_echo '.text > addl r15 = @ltoffx(x#), gp > ;; > ld8.mov r16 = [r15], x#'[] > conftest.s Thanks for pointing this out. I've applied this patch to fix this by

Re: [PATCH] x86: Update VFIXUPIMM* Intrinsics to align with the latest Intel SDM

On Tue, Oct 30, 2018 at 10:12 AM Wei Xiao wrote: > > Hi, > > The attached patch updates VFIXUPIMM* Intrinsics to align with the > latest Intel® 64 and IA-32 Architectures Software Developer’s Manual > (SDM). > Tested with GCC regression test on x86, no regression. A couple of remarks: -_mm512_fi

Re: V2 [PATCH] i386: Use scalar operand in SF/DF/SI/DI vec_dup patterns

On Tue, Oct 30, 2018 at 9:36 PM H.J. Lu wrote: > > Why not at the expand time? Rewrite vector constant as vec_duplicate > > from memory and combine will do the stuff for you. We do have _bcst > > instruction patterns. > > > > Here is the updated patch to do that. OK for trunk? Looks mostly good

Re: C++ PATCH to add test to cover case RANGE_FOR_STMT

Ping. On Thu, Oct 11, 2018 at 09:28:38PM -0400, Marek Polacek wrote: > Recently it came up that no test in the testsuite triggers the RANGE_FOR_STMT > case in potential_constant_expression_1. I came up with this valid test that > tickles that codepath. > > I can't use ({ }) instead of a lambda b

Re: C++ PATCH to add test to cover case RANGE_FOR_STMT

On 11/1/18 2:06 PM, Marek Polacek wrote: Ping. On Thu, Oct 11, 2018 at 09:28:38PM -0400, Marek Polacek wrote: Recently it came up that no test in the testsuite triggers the RANGE_FOR_STMT case in potential_constant_expression_1. I came up with this valid test that tickles that codepath. I can

[PATCH] libgcc build fix for pdp11

This fixes some test suite failures due to a missing arithmetic support routine. Committed. paul ChangeLog: 2018-11-01 Paul Koning * config/pdp11/t-pdp11 (LIB2ADD): Add divmod.c. (HOST_LIBGCC2_CFLAGS): Change to optimize for size. Index: config/pdp11/t-pdp11 ===

Re: [PATCH 2/2 v3][IRA,LRA] Fix PR86939, IRA incorrectly creates an interference between a pseudo register and a hard register

Hi Peter, Is there any update on this issues? arm-none-linux-gnueabihf native toolchain has been mis-compiled for a while. I got the following dump from the test case. x1 is an early clobber operand in the inline assembly statement, r92 should conflict with x1? ;; a0(r93,l0) conflicts: a1(r92,

[PATCH, testsuite] test case fixes for pdp11

This patch fixes a number of test case failures on pdp11. Some are too large for the address space, some have dependencies on the float format that don't match the DEC format, some add pdp11 to the targets that expect particular compiler messages. Committed. paul ChangeLog: 2018-11-

[patch, fortran] Fux PR 87782

Hello world, the attached patch fixes the PR by not trying to determine the length of the base symbol when there is a substring with a length which is not constant. This might make the length of temporary strings generated by the front end optimization pass shorter, while inserting an additional

[PATCH, testsuite] ignore some "conflicting types for built-in" messages

A number of test cases contain declarations like: void *memcpy(); which currently are silently accepted on most platforms but not on all; pdp11 (and possibly some others) generate a "conflicting types for built-in function" warning. It was suggested to prune those messages because the test cas

Re: [patch, fortran] Fux PR 87782

On Thu, Nov 1, 2018 at 9:13 PM Thomas Koenig wrote: > Hello world, > > the attached patch fixes the PR by not trying to determine the length > of the base symbol when there is a substring with a length which > is not constant. This might make the length of temporary strings > generated by the fr

[PATCH, testsuite] add "inf" target attribute

A number of test cases fail on pdp11 because they use the "inf" float value which does not exist on that target (nor on VAX). Rainer Orth and Joseph Myers suggested adding a new effective-target keyword to check for this, and require it for tests that have that dependency. The attached patch i

Re: C++ PATCH to Implement P0846R0, ADL and function templates [v3]

On Thu, Nov 01, 2018 at 12:15:48PM -0400, Jason Merrill wrote: > On 10/31/18 6:45 PM, Marek Polacek wrote: > > On Mon, Oct 29, 2018 at 05:59:13PM -0400, Jason Merrill wrote: > > > On 10/28/18 3:56 PM, Marek Polacek wrote: > > > > This patch implements P0846R0: ADL and Function Templates that are no

Re: C++ PATCH to Implement P0846R0, ADL and function templates [v3]

On Thu, Nov 01, 2018 at 03:36:04PM -0400, Marek Polacek wrote: > this hunk triggered an assert in tsubst_copy (just one testcase), but when > I moved it, everything seemed to work well. *removed*

Re: Update GCC to autoconf 2.69, automake 1.15.1

On Wed, Oct 31, 2018 at 7:05 PM Joseph Myers wrote: > I've committed this revised patch version Thank you for taking on this work. > As noted, my expectation is that libgfortran, libgo, libgomp, > liboffloadmic, libsanitizer, libphobos maintainers will deal with > moving those directories to

Re: C++ PATCH to Implement P0846R0, ADL and function templates [v3]

On Thu, Nov 1, 2018 at 3:36 PM Marek Polacek wrote: > On Thu, Nov 01, 2018 at 12:15:48PM -0400, Jason Merrill wrote: > > On 10/31/18 6:45 PM, Marek Polacek wrote: > > > On Mon, Oct 29, 2018 at 05:59:13PM -0400, Jason Merrill wrote: > > > > On 10/28/18 3:56 PM, Marek Polacek wrote: > > > > > This p

Re: [PATCH 2/2 v3][IRA,LRA] Fix PR86939, IRA incorrectly creates an interference between a pseudo register and a hard register

Hi Renlin, On Thu, Nov 01, 2018 at 06:50:22PM +, Renlin Li wrote: > I got the following dump from the test case. > > x1 is an early clobber operand in the inline assembly statement, > r92 should conflict with x1? Yes, I think so. Or LRA should not pick something that was already a hard regi

Re: [PATCH, testsuite] add "inf" target attribute

On Thu, 1 Nov 2018, Paul Koning wrote: > +@item inf > +Target supports floating point infinite (@code{inf}). > @end table Do you mean supports infinity for type double? (That's what the implementation does.) Supporting it for double is not the same as supporting it for float (SPU supports it

Re: [PATCH, testsuite] add "inf" target attribute

> On Nov 1, 2018, at 4:52 PM, Joseph Myers wrote: > > On Thu, 1 Nov 2018, Paul Koning wrote: > >> +@item inf >> +Target supports floating point infinite (@code{inf}). >> @end table > > Do you mean supports infinity for type double? (That's what the > implementation does.) Supporting it fo

[wwwdocs] readings.html - add OpenRISC links

Hello, As we were getting ready for OpenRISC gcc port upstreaming Segher pointed out that we should be updating this. I don't think have CVS write access (only git binutils-gdb), can someone help to review and commit if OK? -Stafford Index: readings.html

Re: [wwwdocs] readings.html - add OpenRISC links

On Fri, Nov 02, 2018 at 06:20:56AM +0900, Stafford Horne wrote: > As we were getting ready for OpenRISC gcc port upstreaming Segher pointed out > that we should be updating this. > > I don't think have CVS write access (only git binutils-gdb), can someone help > to > review and commit if OK? I c

[PATCH, AArch64, v3 3/6] aarch64: Tidy aarch64_split_compare_and_swap

From: Richard Henderson With aarch64_track_speculation, we had extra code to do exactly what the !strong_zero_p path already did. The rest is reducing code duplication. * config/aarch64/aarch64 (aarch64_split_compare_and_swap): Disable strong_zero_p for aarch64_track_speculation

[PATCH, AArch64, v3 2/6] aarch64: Implement TImode compare-and-swap

From: Richard Henderson This pattern will only be used with the __sync functions, because we do not yet have a bare TImode atomic load. * config/aarch64/aarch64.c (aarch64_gen_compare_reg): Add support for NE comparison of TImode values. (aarch64_emit_load_exclusive): Add

[PATCH, AArch64, v3 1/6] aarch64: Extend %R for integer registers

From: Richard Henderson * config/aarch64/aarch64.c (aarch64_print_operand): Allow integer registers with %R. --- gcc/config/aarch64/aarch64.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/gcc/config/aarch64/aarch64.c b/gcc/config/aarch64/aarc

[PATCH, AArch64, v3 0/6] LSE atomics out-of-line

From: Richard Henderson Changes since v2: * Committed half of the patch set. * Split inline TImode support from out-of-line patches. * Removed the ST out-of-line functions, to match inline. * Moved the out-of-line functions to assembly. What I have not done, but is now a possibility, is

[PATCH, AArch64, v3 6/6] Enable -matomic-ool by default

Do Not Merge Upstream. This is for agraf and his testing within SLES. --- gcc/common/config/aarch64/aarch64-common.c | 6 -- gcc/config/aarch64/aarch64.c | 6 -- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/gcc/common/config/aarch64/aarch64-common.c b/gcc/c

[PATCH, AArch64, v3 4/6] aarch64: Add out-of-line functions for LSE atomics

This is the libgcc part of the interface -- providing the functions. Rationale is provided at the top of libgcc/config/aarch64/lse.S. * config/aarch64/lse-init.c: New file. * config/aarch64/lse.S: New file. * config/aarch64/t-lse: New file. * config.host: Add t-lse

[PATCH, AArch64, v3 5/6] aarch64: Implement -matomic-ool

* config/aarch64/aarch64.opt (-matomic-ool): New. * config/aarch64/aarch64.c (aarch64_atomic_ool_func): New. (aarch64_ool_cas_names, aarch64_ool_swp_names): New. (aarch64_ool_ldadd_names, aarch64_ool_ldset_names): New. (aarch64_ool_ldclr_names, aarch64_ool_ld

Re: [PATCH, OpenACC 2.5, libgomp] Add *_async versions of runtime library API functions

Hi Chung-Lin! On Mon, 10 Sep 2018 23:04:18 +0800, Chung-Lin Tang wrote: > This patch adds *_async versions of several OpenACC runtime library API > functions, > which is to allow execution of a function asynchronously on particular async > stream, an addition to the standard since 2.5. Specific

Re: [PATCH 2/2 v3][IRA,LRA] Fix PR86939, IRA incorrectly creates an interference between a pseudo register and a hard register

On 11/1/18 1:50 PM, Renlin Li wrote: > Is there any update on this issues? > arm-none-linux-gnueabihf native toolchain has been mis-compiled for a while. >From the analysis I've done, my commit is just exposing latent issues in LRA. Can you try the patch I submitted here to see if it helps? ht

Re: C++ PATCH to Implement P0846R0, ADL and function templates [v4]

On Thu, Nov 01, 2018 at 04:26:34PM -0400, Jason Merrill wrote: > > @@ -16319,6 +16359,25 @@ cp_parser_template_name (cp_parser* parser, > > if (TREE_CODE (*iter) == TEMPLATE_DECL) > > found = true; > > > > + if (!found > > + && (cxx_dialect > cxx17) > > + && !

Re: [build] Remove SPARC HAVE_AS_REGISTER_PSEUDO_OP

> So the current patch removes both the autoconf test and the uses of the > macro. Solaris 11/SPARC Bootstraps with both as and gas currently > running. Ok for mainline if they pass? Sure, thanks for fixing this! -- Eric Botcazou

Re: [PATCH AutoFDO/2]Treat ZERO as common profile probability/count

-- Sender:Richard Biener Sent at:2018 Oct 31 (Wed) 17:11 To:bin.cheng ; Jan Hubicka Cc:GCC Patches Subject:Re: [PATCH AutoFDO/2]Treat ZERO as common profile probability/count > > > On Wed, Oct 31, 2018 at 7:30 AM bin.cheng wrote: