[C++ Patch] Fix coerce_new_type and coerce_delete_type locations

2018-06-12 Thread Paolo Carlini
Hi, yesterday I didn't notice that grok_op_properties calls a couple of helpers which are affected by exactly the same location issues. The below simply forwards the location to the helpers. Tested x86_64-linux. Thanks, Paolo. /cp 2018-06-12 Paolo Carlini

Re: [PATCH] libitm/x86: Correct offsets of __private_tm and pointer_guard

2018-06-12 Thread Torvald Riegel
On Wed, 2018-05-30 at 07:54 -0700, H.J. Lu wrote: > In glibc, sysdeps/i386/nptl/tls.h has > > typedef struct > { > void *tcb;/* Pointer to the TCB. Not necessarily the >thread descriptor used by libpthread. */ > dtv_t *dtv; > void *self; /*

Re: [MAINTAINERS, committed] Remove redundant write-after-approval entries

2018-06-12 Thread Martin Liška
Hi. Thanks for the script, it also found me in Write After Approval section. Thus I'll install following patch. Tom what about installing the script into contrib? Martin >From ae02963208cf24d7b0df133507a89f776b3c4599 Mon Sep 17 00:00:00 2001 From: marxin Date: Tue, 12 Jun 2018 10:24:17 +0200 Su

Re: [RFC] Add gcc.dg-selftests/dg-final.exp

2018-06-12 Thread Tom de Vries
On Mon, Jun 11, 2018 at 04:00:39PM -0600, Jeff Law wrote: > On 05/30/2018 04:41 AM, Tom de Vries wrote: > > Hi, > > > > this patch tests the error behaviour of dg-final directives when called > > with an > > incorrect number of arguments. > > > > The test is lazy, in that it doesn't bother to pa

Re: fix libcc1 dependencies in toplevel Makefile

2018-06-12 Thread Olivier Hainque
Hi Alex, Thanks for your feedback and help looking into this. > On 12 Jun 2018, at 04:50, Alexandre Oliva wrote: > > I was missing one possibility: that the problem occurred during the > post-bootstrap all-host all-target build. As far as I can tell from > Nicolas' analysis, this was indeed th

Re: [PATCH] fixincludes: partly repair broken fix for assert.h in vxworks

2018-06-12 Thread Olivier Hainque
Hello Rasmus, > On 7 Jun 2018, at 11:50, Rasmus Villemoes wrote: > > 2018-06-07Rasmus Villemoes > > fixinclude/ > > * inclhack.def: Fix fixup for assert.h on vxworks. > * fixincl.x: Regenerate. Ok by me, thanks. Olivier

[Ada] Fix wrong code for initialization of fat pointer with -Og

2018-06-12 Thread Eric Botcazou
This fixes a long-standing issue with the initialization of fat pointer types. The compiler incorrectly optimizes out the initialization to Null of a variable of an access-to-unconstrained-array type, if the variable is declared in the same declarative part as the access type and the array type,

[Ada] Improve generated code for records with rep clauses

2018-06-12 Thread Eric Botcazou
This makes sure the handling of bit-fields is uniform in packed records or records with representation clause. Tested on x86-64/Linux, applied on mainline, 2018-06-12 Eric Botcazou * gcc-interface/decl.c (variant_desc): Add AUX field. (gnat_to_gnu_entity) : Do not call compu

[PATCH, contrib] Add contrib/maintainers-verify.sh

2018-06-12 Thread Tom de Vries
[ was: Re: [MAINTAINERS, committed] Remove redundant write-after-approval entries ] On Tue, Jun 12, 2018 at 10:26:31AM +0200, Martin Liška wrote: > Hi. > > Thanks for the script, it also found me in Write After Approval section. > Thus I'll install following patch. > > Tom what about installing

[Ada] Plug loophole in warn_on_field_placement

2018-06-12 Thread Eric Botcazou
Only the first component of a group of reordered bitfields was warned about. Tested on x86-64/Linux, applied on mainline and 8 branch. 2018-06-12 Eric Botcazou * gcc-interface/decl.c (warn_on_field_placement): Use specific wording for discriminants. (warn_on_list_plac

Re: [PATCH, contrib] Add contrib/maintainers-verify.sh

2018-06-12 Thread Tom de Vries
[ Fixed ENOPATCH ] On Tue, Jun 12, 2018 at 11:57:13AM +0200, Tom de Vries wrote: > [ was: Re: [MAINTAINERS, committed] Remove redundant write-after-approval > entries ] > > On Tue, Jun 12, 2018 at 10:26:31AM +0200, Martin Liška wrote: > > Hi. > > > > Thanks for the script, it also found me in Wr

[Ada] Fix missing resolution data for secondary dispatch table with LTO

2018-06-12 Thread Eric Botcazou
Dispatch tables are implemented the same way as in the C++ front-end, i.e. by importing and then exporting them to break the inherent circularity. There was a glitch in gigi that was preventing the two views from being merged in the case of secondary dispatch tables in LTO mode. Fixed thusly,

[Ada] Minor tweaks in gigi

2018-06-12 Thread Eric Botcazou
Tested on x86-64/Linux, applied on mainline, 8 and 7 branches. 2018-06-12 Eric Botcazou * gcc-interface/ada-tree.h (TYPE_RETURN_BY_DIRECT_REF_P): Change from using TYPE_LANG_FLAG_4 to using TYPE_LANG_FLAG_0. (TYPE_ALIGN_OK): Move around. (TYPE_PADDING_FOR_COMPO

RE: [PATCH] MIPS: Update I6400 scheduler

2018-06-12 Thread Robert Suchanek
Hi Matthew, > There does seem to be a temporal issue in submission for this as the > i6400_fpu_minmax reservation refers to fminmax and fclass types that > do not exist in trunk. Can you drop that reservation please? > > Otherwise, OK to commit. Reservation dropped. Committed as r261489. Reg

RE: [PATCH] MIPS: Add i6500 processor as an alias for i6400

2018-06-12 Thread Robert Suchanek
Hi, > Looks good, OK to commit. Committed as r261490. Regards, Robert

Re: [PATCH] libitm/x86: Correct offsets of __private_tm and pointer_guard

2018-06-12 Thread H.J. Lu
On Tue, Jun 12, 2018 at 1:23 AM, Torvald Riegel wrote: > On Wed, 2018-05-30 at 07:54 -0700, H.J. Lu wrote: >> In glibc, sysdeps/i386/nptl/tls.h has >> >> typedef struct >> { >> void *tcb;/* Pointer to the TCB. Not necessarily the >>thread descriptor used

Re: [patch] Remove redundant intrinsics

2018-06-12 Thread H.J. Lu
On Mon, Jun 4, 2018 at 3:27 AM, Koval, Julia wrote: > Hi, > > Since pre-Icelake ISA already had 128bit version vpclmul and vaes, we already > have intrinsics for them(_mm_aesdec_si128, _mm_aesdeclast_si128, > _mm_aesenc_si128, _mm_aesenclast_si128, _mm_clmulepi64_si128). Therefore > intrinsics

RE: [PATCH 1/2] [ARC][QuarkSE] Update

2018-06-12 Thread Claudiu Zissulescu
Hi, The purpose of this field is to hold all other possible configurations which doesn't fit in the general scheme. The LP_COUNT width is an example, other can be the information about register banks used for interrupts. I will add extra comments in the sources. Thanks, Claudiu

RE: [PATCH,MIPS] Fix pr86067 ICE: scal-to-vec1.c:86:1: error: unrecognizable insn with -march=loongson3a

2018-06-12 Thread Matthew Fortune
Paul Hua writes: > The gcc.c-torture/execute/scal-to-vec1.c trigger a gcc ICE bug. > > It's a mistake in define_expand vec_setv4hi in loongson.md file. > > 375 (define_expand "vec_setv4hi" > 376 [(set (match_operand:V4HI 0 "register_operand" "=f") > 377 (unspec:V4HI [(match_operand:V4

[PATCH] Improve gimple.vim syntax file.

2018-06-12 Thread Martin Liška
Hi. Following patch improves GIMPLE VIM syntax format. Please take a look at attached screenshots. Ready for trunk? Martin https://drive.google.com/file/d/1KK3GvfX-VXtI_S-TOcIrPq-pex1WTAIJ/view?usp=sharing https://drive.google.com/file/d/1LpKpBJX5jepFgYBjujWbMyUZGfkPBzDD/view?usp=sharing ---

[PATCH] Add initial version of rtl.vim syntax file.

2018-06-12 Thread Martin Liška
Hi. This is equivalent of gimple.vim file. I'm aware of not full coverage of RTL instructions, but hope it's a good start point. Screenshots: https://drive.google.com/open?id=14y-Hca2hf1gyWDfHaht6Wjv-Btf3Bdvl https://drive.google.com/open?id=1LiqsJq2ng-aeKsvw3PhUnDjLWh54Y1Vc Ready for trunk? Th

RE: [PATCH] MIPS: Update I6400 scheduler

2018-06-12 Thread Robert Suchanek
Hi, > > There does seem to be a temporal issue in submission for this as the > > i6400_fpu_minmax reservation refers to fminmax and fclass types that > > do not exist in trunk. Can you drop that reservation please? > > > > Otherwise, OK to commit. > > Reservation dropped. > > Committed as r2614

Re: [PATCH] Come up with Deprecated option flag.

2018-06-12 Thread Martin Liška
On 06/11/2018 09:33 PM, Paul Koning wrote: > > >> On Jun 8, 2018, at 7:09 AM, Martin Liška wrote: >> >> Hi. >> >> First follow-up MPX removal patch comes up with Deprecated option flag. >> That prints warning for options that have no effect: > > Should this be mentioned in the internals manual

Re: [PATCH] fixincludes: a few genfixes changes

2018-06-12 Thread Bruce Korb
This looks pretty reasonable to me. I'm sure "set -- fixincl.x" meant something two decades ago when I wrote it. :) I should update my e-address since I can be off gnu mail for weeks at a time nowadays. (We retired folk are less consistent about checking project emails ...) Oh, the assert.h thingy

[PATCH] Document IntegerRange in internal documentation.

2018-06-12 Thread Martin Liška
Hi. The patch is mentioning IntegerRange in documentation. Ready for trunk? Martin gcc/ChangeLog: 2018-06-12 Martin Liska * doc/options.texi: Document IntegerRange. --- gcc/doc/options.texi | 5 + 1 file changed, 5 insertions(+) diff --git a/gcc/doc/options.texi b/gcc/doc/opt

Re: [PATCH] Document IntegerRange in internal documentation.

2018-06-12 Thread Kyrill Tkachov
Hi Martin, Just a couple of typos... On 12/06/18 15:24, Martin Liška wrote: Hi. The patch is mentioning IntegerRange in documentation. Ready for trunk? Martin gcc/ChangeLog: 2018-06-12 Martin Liska * doc/options.texi: Document IntegerRange. --- gcc/doc/options.texi | 5 + 1

Re: [PATCH] Document IntegerRange in internal documentation.

2018-06-12 Thread Martin Liška
On 06/12/2018 04:27 PM, Kyrill Tkachov wrote: > Hi Martin, > > Just a couple of typos... > > On 12/06/18 15:24, Martin Liška wrote: >> Hi. >> >> The patch is mentioning IntegerRange in documentation. >> >> Ready for trunk? >> Martin >> >> gcc/ChangeLog: >> >> 2018-06-12  Martin Liska  >> >>

Re: [PATCH] fixincludes: partly repair broken fix for assert.h in vxworks

2018-06-12 Thread Jeff Law
On 06/12/2018 03:17 AM, Olivier Hainque wrote: > Hello Rasmus, > >> On 7 Jun 2018, at 11:50, Rasmus Villemoes wrote: >> >> 2018-06-07Rasmus Villemoes >> >> fixinclude/ >> >> * inclhack.def: Fix fixup for assert.h on vxworks. >> * fixincl.x: Regenerate. > > Ok by me, thanks. Instal

Re: [PATCH] fixincludes: a few genfixes changes

2018-06-12 Thread Jeff Law
On 06/12/2018 08:25 AM, Bruce Korb wrote: > This looks pretty reasonable to me. I'm sure "set -- fixincl.x" > meant something two decades ago when I wrote it. :) > I should update my e-address since I can be off gnu mail for > weeks at a time nowadays. (We retired folk are less consistent > about c

PING [PATCH] add support for strnlen (PR 81384)

2018-06-12 Thread Martin Sebor
I'm looking for a review of the patch below (beyond using DEF_EXT_LIB_BUILTIN to declare the built-in rather than DEF_LIB_BUILTIN, as already pointed out by Jakub): https://gcc.gnu.org/ml/gcc-patches/2018-06/msg00267.html On 06/05/2018 03:43 PM, Martin Sebor wrote: The attached patch adds bas

Re: [PATCH] fixincludes: partly repair broken fix for assert.h in vxworks

2018-06-12 Thread Olivier Hainque
> On 12 Jun 2018, at 16:58, Jeff Law wrote: > Installed on the trunk. Thanks Jeff. I missed that Rasmus doesn't have commit rights.

Re: [PATCH] fixincludes: partly repair broken fix for assert.h in vxworks

2018-06-12 Thread Jeff Law
On 06/12/2018 09:19 AM, Olivier Hainque wrote: > > >> On 12 Jun 2018, at 16:58, Jeff Law wrote: > >> Installed on the trunk. > > Thanks Jeff. I missed that Rasmus doesn't have commit rights. No worries. I'm thinking that Rasmus ought to go ahead and get commit privs since it seems like he's m

Re: fix libcc1 dependencies in toplevel Makefile

2018-06-12 Thread Jeff Law
On 06/11/2018 08:50 PM, Alexandre Oliva wrote: > So I see two possible ways to go from now: > > 1. address the previously-mentioned fragility in the patch I posted, to > catch all cases of postbootstrap targets and their deps on > non-postbootstrap targets. > > > 2. revamp the bootstrap/non-boot

[PATCH] Linux/x86: Update TARGET_THREAD_SPLIT_STACK_OFFSET comments

2018-06-12 Thread H.J. Lu
Glibc 2.18 was changed by commit ecbf434213c0333d81706074e4d107ac45011635 Author: Andreas Jaeger Date: Wed May 15 20:20:54 2013 +0200 Reserve new TLS field for x86 and x86_64 [BZ #10686] * sysdeps/x86_64/tls.h (struct tcbhead_t): Add __private_ss field. * s

Re: [PING] [PATCH] refine -Wstringop-truncation and -Wsizeof-pointer-memaccess for strncat of nonstrings (PR 85602)

2018-06-12 Thread Jeff Law
On 05/29/2018 01:21 PM, Martin Sebor wrote: > To make review and testing easier (thank you, Franz), attached > is an updated patch rebased on top of today's trunk. > > (Note that the patch intentionally doesn't suppress the warning > for the submitted test case without adding the nonstring attribu

Re: [PATCH/RFC] enable -Wstrict-prototypes (PR 82922)

2018-06-12 Thread Martin Sebor
The proposal to enable -Wstrict-prototypes discussed below was considered too late for GCC 8. I'd like to revive it now for GCC 9. https://gcc.gnu.org/ml/gcc-patches/2018-01/msg00935.html On 01/11/2018 11:41 AM, Martin Sebor wrote: Declaring a function without a prototype has been deprecated

Re: [PATCH, rs6000 8/9] [v2] Enable gimple folding for vec_xl, vec_xst

2018-06-12 Thread Will Schmidt
Hi, Gimple folding for unaligned vector loads and stores. Regtest completed across variety of systems, P6,P7,P8,P9. [v2] Added the type for the MEM_REF, per feedback. Testcases for gimple-folding of the same are currently in-tree as powerpc/fold-vec-load-*.c and powerpc/fold-vec-store-*.c. Re-

Re: libgo patch committed: Add riscv and js/wasm

2018-06-12 Thread Palmer Dabbelt
On Mon, 11 Jun 2018 20:46:01 PDT (-0700), i...@golang.org wrote: On Mon, Jun 11, 2018 at 12:22 PM, Palmer Dabbelt wrote: On Mon, 11 Jun 2018 12:16:39 PDT (-0700), i...@golang.org wrote: This libgo patch add riscv and js/wasm as known targets. This incorporates cut down versions of https://go

Re: [PATCH] relax -Wsizeof-pointer-memaccess for strncpy with size of source (PR 85931)

2018-06-12 Thread Martin Sebor
On 06/11/2018 03:57 PM, Jeff Law wrote: On 05/29/2018 08:57 PM, Martin Sebor wrote: Warning for a strncpy call whose bound is the same as the size of the source and suggesting to use the size of the source is less than helpful when both sizes are the same, as in: char a[4], b[4]; strncpy (a

Re: [PATCH/RFC] enable -Wstrict-prototypes (PR 82922)

2018-06-12 Thread Joseph Myers
On Tue, 12 Jun 2018, Martin Sebor wrote: > The proposal to enable -Wstrict-prototypes discussed below > was considered too late for GCC 8. I'd like to revive it > now for GCC 9. > > https://gcc.gnu.org/ml/gcc-patches/2018-01/msg00935.html My point from that discussion stands that () for no ar

RE: [PATCH] MIPS: Add support for P6600

2018-06-12 Thread Robert Suchanek
Hi Matthew, As already discussed, the link to the P6600 doesn't appear to be referenced on mips.com but reachable when searching for 'p6600': https://www.mips.com/downloads/p6600-multiprocessing-programmers-guide/ I'm resubmitting the whole patch again with updated ChangeLog. > > > > +/* Classi

[Committed] PR fortran/44491 -- Select non-NULL locus

2018-06-12 Thread Steve Kargl
The attached patch has been committed to trunk after regression testing. Two loci are available for the error messages. If the first locus is NULL, then it uses the second one to report the error. In the audit trail of the PR manu@ suggested removing the assert() that caused the ICE. His patch

[PATCH 0/5] More rtx->rtx_insn * cleanups

2018-06-12 Thread David Malcolm
This patch kit strengthens various parameters in emit-rtl.h/c from rtx to rtx_insn *, eliminating 14 "as_a"/"safe_as_a" casts from emit-rtl.c (though requiring a few new ones elsewhere). It's effectively one patch; I've split it up for ease of review. Nearly all of it is trivial, and would be cov

[PATCH 2/5] arc: update for emit-rtl.h change

2018-06-12 Thread David Malcolm
gcc/ChangeLog: * config/arc/arc.c (hwloop_optimize): Strengthen local "end_label" from rtx to rtx_insn *. --- gcc/config/arc/arc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gcc/config/arc/arc.c b/gcc/config/arc/arc.c index 2bedc9a..987abfd 100644 --- a

[PATCH 3/5] bfin: update for emit-rtl.h changes

2018-06-12 Thread David Malcolm
gcc/ChangeLog: * config/bfin/bfin.c (hwloop_optimize): Strengthen local "label" from rtx to rtx_insn *. (add_sched_insns_for_speculation): Likewise local for "target", converting usage of JUMP_LABEL to JUMP_LABEL_AS_INSN. --- gcc/config/bfin/bfin.c | 4 ++-- 1 file

[PATCH 1/5] emit-rtl.c: more typesafety

2018-06-12 Thread David Malcolm
This patch converts various rtx to rtx_insn * (or rtx_code_label *). It also convert the various "_loc" params from int to location_t gcc/ChangeLog: * emit-rtl.c (next_real_insn): Strengthen param from "rtx" to "rtx_insn *". (add_insn_after): Likewise for first two params.

[PATCH 4/5] c6x: update for emit-rtl.h changes

2018-06-12 Thread David Malcolm
gcc/ChangeLog: * config/c6x/c6x.c (reorg_split_calls): Strengthen param "call_labels" from rtx_insn ** to rtx_code_label **. (reorg_emit_nops): Likewise. (c6x_reorg): Likewise for local "call_labels". --- gcc/config/c6x/c6x.c | 6 +++--- 1 file changed, 3 insertions

[PATCH 5/5] sh: update for emit-rtl.h changes

2018-06-12 Thread David Malcolm
gcc/ChangeLog: * config/sh/sh-protos.h (get_dest_uid): Strengthen 1st param from rtx to rtx_insn *. * config/sh/sh.c (dump_table): Strengthen local "lab" from rtx to rtx_code_label *, adding safe_as_a casts to the loops over LABEL_REFS. (fixup_addr_d

Re: [PATCH] restore -Wstringop-overflow for checked strcpy/strcat (PR 85259)

2018-06-12 Thread Martin Sebor
On 06/11/2018 03:25 PM, Jeff Law wrote: On 05/14/2018 04:41 PM, Martin Sebor wrote: r256683 committed to GCC 8 to avoiding duplicate instances of -Wstringop-overflow warnings on some targets has the unintended side-effect of suppressing even singleton instances of the warning in cases such as 's

Re: [PATCH, rs6000 8/9] [v2] Enable gimple folding for vec_xl, vec_xst

2018-06-12 Thread Bill Schmidt
On 6/12/18 11:56 AM, Will Schmidt wrote: > Hi, > Gimple folding for unaligned vector loads and stores. > Regtest completed across variety of systems, P6,P7,P8,P9. > > [v2] Added the type for the MEM_REF, per feedback. > Testcases for gimple-folding of the same are currently in-tree > as powerp

Re: [C++ Patch] Fix coerce_new_type and coerce_delete_type locations

2018-06-12 Thread Jason Merrill
OK. On Tue, Jun 12, 2018 at 4:07 AM, Paolo Carlini wrote: > Hi, > > yesterday I didn't notice that grok_op_properties calls a couple of helpers > which are affected by exactly the same location issues. The below simply > forwards the location to the helpers. Tested x86_64-linux. > > Thanks, Paolo

C++ PATCH for core issue 1331 (const mismatch with defaulted copy constructor)

2018-06-12 Thread Marek Polacek
As [class.copy.ctor] says, the type of an implicitly declared copy constructor will be either X::X(const X&) if each potentially constructed subobject of a class type M (or array thereof) has a copy constructor whose first parameter is of type const M& or const volatile M&. Otherwise, the impl

[PATCH] P0935R0 Eradicating unnecessarily explicit default constructors

2018-06-12 Thread Jonathan Wakely
Explicit default constructors are problematic, so this change removes them from and , as per P0935R0. * include/bits/random.h (linear_congruential_engine) (mersenne_twister_engine, subtract_with_carry_engine, random_device) (uniform_real_distribution, normal_distribution)

Re: [PATCH 4/6] [ARC] Define LINK_GCC_C_SEQUENCE_SPEC.

2018-06-12 Thread Andrew Burgess
* Claudiu Zissulescu [2018-05-21 13:18:37 +0300]: > From: claziss > > If no specs file is provided, default to nosys library. > > Ok to apply? Looks good. Thanks, Andrew > Claudiu > > gcc/ > 2017-05-03 Claudiu Zissulescu > > * config/arc/elf.h (LINK_GCC_C_SEQUENCE_SPEC): Define.

Re: [PATCH 3/6] [ARC] SYNC instruction is valid on all ARC cores.

2018-06-12 Thread Andrew Burgess
* Claudiu Zissulescu [2018-05-21 13:18:36 +0300]: > From: claziss > > The sync instruction is part of all ARC architectures. Fix this in the > compiler. > > Ok to apply? Looks good. Thanks, Andrew > Claudiu > > gcc/ > 2017-05-03 Claudiu Zissulescu > > * config/arc/builtins.def

Re: [PATCH 1/6] [ARC] Add modes scheduler HS

2018-06-12 Thread Andrew Burgess
* Claudiu Zissulescu [2018-05-21 13:18:34 +0300]: > From: Claudiu Zissulescu > > An update on how the instructions are scheduled for HS processor. > > Ok to apply? Looks good. Thanks, Andrew > Claudiu > > --- > gcc/config/arc/arcHS.md | 21 +++-- > 1 file changed, 15 inse

Re: [PATCH 2/6] [ARC] Allow EX instruction for ARC700 and ARCv2.

2018-06-12 Thread Andrew Burgess
* Claudiu Zissulescu [2018-05-21 13:18:35 +0300]: > From: claziss > > The EX instruction is base line for both architectures. Reflect this in the > compiler. > > OK to apply? Looks good. Thanks, Andrew > Claudiu > > gcc/ > 2017-05-02 Claudiu Zissulescu > > * config/arc/arc.c (a

Re: [PATCH 1/4] Transform switch_conversion into a class.

2018-06-12 Thread Jeff Law
On 06/04/2018 07:32 AM, marxin wrote: > gcc/ChangeLog: > > 2018-06-07 Martin Liska > > * tree-switch-conversion.c (MAX_CASE_BIT_TESTS): Remove. > (hoist_edge_and_branch_if_true): Likewise. > (expand_switch_using_bit_tests_p): Likewise. > (struct case_bit_test): Likewise

Re: [PATCH 5/6] [ARC] Update fma expansions.

2018-06-12 Thread Andrew Burgess
* Claudiu Zissulescu [2018-05-21 13:18:38 +0300]: > Make sure only one operand has an immediate. > > OK to apply? Looks good. Thanks, Andrew > Claudiu > > gcc/ > 2018-03-21 Claudiu Zissulescu > > * config/arc/fpu.md (fmasf4): Force operand to register. > (fnmasf4): Likewise.

Re: [PATCH, rs6000 8/9] [v2] Enable gimple folding for vec_xl, vec_xst

2018-06-12 Thread Will Schmidt
On Tue, 2018-06-12 at 13:17 -0500, Bill Schmidt wrote: > On 6/12/18 11:56 AM, Will Schmidt wrote: > > Hi, > > Gimple folding for unaligned vector loads and stores. > > Regtest completed across variety of systems, P6,P7,P8,P9. > > > > [v2] Added the type for the MEM_REF, per feedback. > > Testc

Re: [PATCH 6/6] [ARC] Reimplement return padding operation for ARC700.

2018-06-12 Thread Andrew Burgess
* Claudiu Zissulescu [2018-05-21 13:18:39 +0300]: > From: Claudiu Zissulescu > > For ARC700, adding padding if necessary to avoid a mispredict. A > return could happen immediately after the function start. A > call/return and return/return must be 6 bytes apart to avoid > mispredict. > > The

Re: C++ PATCH for core issue 1331 (const mismatch with defaulted copy constructor)

2018-06-12 Thread Jason Merrill
OK. On Tue, Jun 12, 2018 at 3:02 PM, Marek Polacek wrote: > As [class.copy.ctor] says, the type of an implicitly declared copy constructor > will be either > > X::X(const X&) > > if each potentially constructed subobject of a class type M (or array thereof) > has a copy constructor whose first

Re: [PATCH, rs6000 8/9] [v3] Enable gimple folding for vec_xl, vec_xst

2018-06-12 Thread Will Schmidt
Hi, version 3. Gimple folding for unaligned vector loads and stores. [v2] Added the type for the MEM_REF, per feedback. Testcases for gimple-folding of the same are currently in-tree as powerpc/fold-vec-load-*.c and powerpc/fold-vec-store-*.c. [v3] Updated the alignment for the MEM_REF t

[PATCH, rs6000] clean up vec_neg related test options

2018-06-12 Thread Will Schmidt
Hi, A few of our vec_neg related tests are failing in some environments. Clean up the options and requires stanzas to avoid running the tests where the vec_neg() intrinsic does not work. OK for trunk? Thanks -Will [testsuite] 2018-06-12 Will Schmidt * gcc.target/powerpc

Re: [PATCH 4/4] Change default for jump_table expansion ratio to 8.

2018-06-12 Thread Jeff Law
On 06/07/2018 03:04 AM, marxin wrote: > > gcc/ChangeLog: > > 2018-06-07 Martin Liska > > * tree-switch-conversion.c (jump_table_cluster::can_be_handled): > Change default ratio from 10 to 8. > --- > gcc/tree-switch-conversion.c | 10 ++ > 1 file changed, 2 insertions(+)

Re: Improve std::rotate usages

2018-06-12 Thread François Dumont
I'm struggling having a validation for this patch. As it is a trivial one and to not bother you I plan to commit it tomorrow if not told otherwise. François On 08/06/2018 07:54, François Dumont wrote: Gentle reminder. On 27/05/2018 19:25, François Dumont wrote: Still no chance to review

Re: [PATCH 3/4] Enable clustering for switch statements.

2018-06-12 Thread Jeff Law
On 06/05/2018 05:59 AM, marxin wrote: > gcc/ChangeLog: > > 2018-06-07 Martin Liska > > * tree-switch-conversion.c (jump_table_cluster::find_jump_tables): > New. > (bit_test_cluster::find_bit_tests): Likewise. > (switch_decision_tree::analyze_switch_statement): Find cl

Re: [PATCH 2/4] Switch other switch expansion methods into classes.

2018-06-12 Thread Jeff Law
On 06/05/2018 01:15 AM, marxin wrote: > gcc/ChangeLog: > > 2018-06-07 Martin Liska > > * tree-switch-conversion.c (switch_conversion::collect): > Record m_uniq property. > (switch_conversion::expand): Bail out for special conditions. > (group_cluster::~group_cluster):

Re: [PATCH 2/5] arc: update for emit-rtl.h change

2018-06-12 Thread Jeff Law
On 06/12/2018 12:54 PM, David Malcolm wrote: > gcc/ChangeLog: > * config/arc/arc.c (hwloop_optimize): Strengthen local "end_label" > from rtx to rtx_insn *. OK when prereqs are approved. jeff

Re: [PATCH 3/5] bfin: update for emit-rtl.h changes

2018-06-12 Thread Jeff Law
On 06/12/2018 12:54 PM, David Malcolm wrote: > gcc/ChangeLog: > * config/bfin/bfin.c (hwloop_optimize): Strengthen local "label" > from rtx to rtx_insn *. > (add_sched_insns_for_speculation): Likewise local for "target", > converting usage of JUMP_LABEL to JUMP_LABEL_AS_INSN

Re: [PATCH 4/5] c6x: update for emit-rtl.h changes

2018-06-12 Thread Jeff Law
On 06/12/2018 12:54 PM, David Malcolm wrote: > gcc/ChangeLog: > * config/c6x/c6x.c (reorg_split_calls): Strengthen param "call_labels" > from rtx_insn ** to rtx_code_label **. > (reorg_emit_nops): Likewise. > (c6x_reorg): Likewise for local "call_labels". OK when prereqs are

Re: [PATCH 5/5] sh: update for emit-rtl.h changes

2018-06-12 Thread Jeff Law
On 06/12/2018 12:54 PM, David Malcolm wrote: > gcc/ChangeLog: > * config/sh/sh-protos.h (get_dest_uid): Strengthen 1st param from > rtx to rtx_insn *. > * config/sh/sh.c (dump_table): Strengthen local "lab" from rtx to > rtx_code_label *, adding safe_as_a casts to > t

Re: [PATCH 1/5] emit-rtl.c: more typesafety

2018-06-12 Thread Jeff Law
On 06/12/2018 12:54 PM, David Malcolm wrote: > This patch converts various rtx to rtx_insn * (or rtx_code_label *). > It also convert the various "_loc" params from int to location_t > > gcc/ChangeLog: > * emit-rtl.c (next_real_insn): Strengthen param from "rtx" > to "rtx_insn *". >

Re: [PATCH] add support for strnlen (PR 81384)

2018-06-12 Thread Jeff Law
On 06/05/2018 03:43 PM, Martin Sebor wrote: > The attached patch adds basic support for handling strnlen > as a built-in function.  It touches the strlen pass where > it folds constant results of the function, and builtins.c > to add simple support for expanding strnlen calls with known > results. 

Re: [RFC PATCH 1/6] vxworks: add target/h/wrn/coreip to the set of system include paths

2018-06-12 Thread Jeff Law
On 06/04/2018 08:46 AM, Rasmus Villemoes wrote: > In order to build crtstuff.c, I need to ensure the headers in > target/h/wrn/coreip are also searched. Of course, that can be done > similar to how wrn/coreip gets manually added for libgcc, e.g. by adding > > CRTSTUFF_T_CFLAGS += -I$(WIND_BASE)/

Re: [PATCH 1/5] emit-rtl.c: more typesafety

2018-06-12 Thread David Malcolm
On Tue, 2018-06-12 at 14:50 -0600, Jeff Law wrote: > On 06/12/2018 12:54 PM, David Malcolm wrote: > > This patch converts various rtx to rtx_insn * (or rtx_code_label > > *). > > It also convert the various "_loc" params from int to location_t > > > > gcc/ChangeLog: > > * emit-rtl.c (next_real

Re: [PATCH v3] add support for --disable-gcov

2018-06-12 Thread Jeff Law
On 06/11/2018 01:25 AM, Rasmus Villemoes wrote: > For some targets (in my case VxWorks 5.5), libgcov does not compile due > to missing functions and macros such as getpid() and F_OK. > > Incidentally, gcc/Makefile.in already contains comments such as > > # Install gcov if it was compiled. > > bu

Re: [PATCH 1/5] emit-rtl.c: more typesafety

2018-06-12 Thread Jeff Law
On 06/12/2018 03:16 PM, David Malcolm wrote: > On Tue, 2018-06-12 at 14:50 -0600, Jeff Law wrote: > > Ultimately these boil down to: > > gcc_checking_assert (INSN_P (rt) > || NOTE_P (rt) > || JUMP_TABLE_DATA_P (rt) > || BARRIER_P (rt)

[PATCH] gracefully deal with invalid strlen declarations (PR 86114)

2018-06-12 Thread Martin Sebor
Declaring strlen() to return a pointer instead of size_t and then calling the function can result in an ICE due to both gimple-fold and tree-ssa-strlen assuming the function necessarily returns an integer. As luck would have it, the incompatible declaration isn't detected by -Wbuiltin-declaration

PING^2: [PATCH v2] C/C++: Add -Waddress-of-packed-member

2018-06-12 Thread H.J. Lu
On Tue, May 29, 2018 at 5:15 AM, H.J. Lu wrote: > On Fri, May 18, 2018 at 4:36 AM, H.J. Lu wrote: >> On Thu, May 17, 2018 at 10:32:56AM -0700, H.J. Lu wrote: >>> On Mon, May 14, 2018 at 8:00 PM, Martin Sebor wrote: >>> > On 05/14/2018 01:10 PM, H.J. Lu wrote: >>> >> >>> >> On Mon, May 14, 2018 a

Re: [RFC PATCH 1/6] vxworks: add target/h/wrn/coreip to the set of system include paths

2018-06-12 Thread Olivier Hainque
> On 12 Jun 2018, at 23:12, Jeff Law wrote: > > I'm going to defer to Olivier on all 6 parts of this kit. He knows > vxworks far better than I. No pb. I haven't forgotten about this :) As I mentioned on another thread, exceptions on VxWorks is an intricate nest of multiple parameters when

Re: [PATCH] gracefully deal with invalid strlen declarations (PR 86114)

2018-06-12 Thread Jeff Law
On 06/12/2018 03:29 PM, Martin Sebor wrote: > Declaring strlen() to return a pointer instead of size_t > and then calling the function can result in an ICE due to > both gimple-fold and tree-ssa-strlen assuming the function > necessarily returns an integer. > > As luck would have it, the incompati

Re: [RFC][PATCH] Stabilize a few qsort comparison functions

2018-06-12 Thread Jeff Law
On 02/07/2018 09:58 AM, Franz Sirl wrote: > Hi, > > this is the result of an attempt to minimize the differences between the > compile results of a Linux-based and a Cygwin64-based powerpc-eabi cross > toolchain. > The method used was: > >     - find the -fverbose-asm assembler files that differ

Re: [PATCH, alpha] PR target/85095

2018-06-12 Thread Jeff Law
On 05/31/2018 12:56 PM, Gerald Pfeifer wrote: > On Thu, 24 May 2018, Jeff Law wrote: >>> I can try to fix openbsd soon, but freebsd dropped alpha in 2009. >>> How does gcc feel about me picking up patches from openbsd ports, their >>> package manager, that weren't written by myself? >> So ISTM we s

[PATCH] Let env var CLICOLOR_FORCE set -fdiagnostics-color=always.

2018-06-12 Thread Adam Borowski
Hi! Here's a patch for Bugzilla 80271, to add support for env CLICOLOR_FORCE. Automated build environments -- and even some which you run by hand -- redirect the output somewhere to save a log, even if they tee it to the terminal anyway. This kills all colored highlights for diagnostics. Those hi

Re: Improve std::rotate usages

2018-06-12 Thread Jonathan Wakely
On 12/06/18 22:39 +0200, François Dumont wrote: I'm struggling having a validation for this patch. As it is a trivial one and to not bother you I plan to commit it tomorrow if not told otherwise. No, please wait for review.

Re: [PATCH 1/3] Add vec::reverse.

2018-06-12 Thread Jeff Law
On 05/22/2018 06:15 AM, marxin wrote: > > gcc/ChangeLog: > > 2018-05-25 Martin Liska > David Malcolm > > * vec.c (test_reverse): New. > (vec_c_tests): Add new test. > * vec.h (vl_ptr>::reverse): New function. OK. Seems generally useful, so from my point of view

Re: [PATCH 2/3] Temporary remove "at least 8 byte alignment" code from x86

2018-06-12 Thread Jeff Law
On 05/21/2018 07:55 AM, marxin wrote: > > gcc/ChangeLog: > > 2017-04-18 Denys Vlasenko > > * config/i386/i386-common.c (ix86_handle_option): Remove support > for obsolete -malign-loops, -malign-jumps and -malign-functions > options. > * config/i386/i386.opt: Likewise. The Chan

[PATCH] [PR86064] split single cross-partition range with nonzero locviews

2018-06-12 Thread Alexandre Oliva
We didn't split cross-partition ranges in loclists to output a whole-function location expression, but with nonzero locviews, we force loclists, and then we have to split to avoid cross-partition list entries. From: Alexandre Oliva for gcc/ChangeLog PR debug/86064 * dwarf2out.

Re: [PATCH] [PR86064] split single cross-partition range with nonzero locviews

2018-06-12 Thread Alexandre Oliva
On Jun 12, 2018, Alexandre Oliva wrote: > We didn't split cross-partition ranges in loclists to output a > whole-function location expression, but with nonzero locviews, we > force loclists, and then we have to split to avoid cross-partition > list entries. Regstrapped on x86_64-linux-gnu and i6

C++ PATCH for c++/86098, ICE with template template parameter placeholder

2018-06-12 Thread Jason Merrill
When comparing two TEMPLATE_TYPE_PARM, we need to consider whether they are acting as placeholders for templates. Tested x86_64-pc-linux-gnu, applying to trunk. commit 10e5cb6bf4c605741ef59f17120304a3c261c06c Author: Jason Merrill Date: Tue Jun 12 22:38:07 2018 -0400 PR c++/86098 -

Re: [RFC PATCH 1/6] vxworks: add target/h/wrn/coreip to the set of system include paths

2018-06-12 Thread Rasmus Villemoes
On 2018-06-12 23:34, Olivier Hainque wrote: > > >> On 12 Jun 2018, at 23:12, Jeff Law wrote: >> >> I'm going to defer to Olivier on all 6 parts of this kit. He knows >> vxworks far better than I. > > No pb. I haven't forgotten about this :) > > As I mentioned on another > thread, exceptions