Re: [PATCH] fix cygwin builds

2017-10-30 Thread Andreas Schwab
This broke ia64: In file included from ./tm_p.h:4:0, from ../../gcc/gimplify.c:30: ../../gcc/config/ia64/ia64-protos.h:49:13: error: use of enum 'memmodel' without previous declaration enum memmodel); ^ Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG

Re: [PATCH] Implement omp async support for nvptx

2017-10-30 Thread Jakub Jelinek
On Fri, Oct 27, 2017 at 03:57:28PM +0200, Tom de Vries wrote: > how about this approach: > 1 - Move async_run from plugin-hsa.c to default_async_run > 2 - Implement omp async support for nvptx > ? > > The first patch moves the GOMP_OFFLOAD_async_run implementation from > plugin-hsa.c to target.c,

Re: [PATCH v3] Add asan and ubsan support on NetBSD/amd64

2017-10-30 Thread Jakub Jelinek
On Thu, Oct 26, 2017 at 09:50:43PM +0200, Kamil Rytarowski wrote: > $ make check-asan > $ make check-asan-dynamic > $ make check-ubsan That is testing of the upstream code, not of GCC and the libsanitizer copy in GCC. What I'm more interested to hear is whether you've bootstrapped/regtested the g

Re: [09/nn] Add a fixed_size_mode_pod class

2017-10-30 Thread Richard Sandiford
Trevor Saunders writes: > On Thu, Oct 26, 2017 at 09:37:31PM +0200, Eric Botcazou wrote: >> > Can you figure what oldest GCC release supports the C++11/14 POD handling >> > that would be required? >> >> GCC needs to be buildable by other compilers than itself though. > > It sounds like people are

Re: [AArch64, testsuite] gfortran.dg/ieee/ieee_8.f90: xfail for aarch64+ilp32

2017-10-30 Thread Janne Blomqvist
On Tue, Oct 24, 2017 at 9:27 PM, Charles Baylis wrote: > The test is already marked xfail for aarch64*-*-gnu, but this needs to > be changed to aarch64*-*-gnu* in order to match > aarch64-linux-gnu_ilp32. > > Test was previously xfail'd in [1]. > > Shows the expected FAIL->XFAILs on aarch64-linux-

Re: [RFA][PATCH] Provide a class interface into substitute_and_fold.

2017-10-30 Thread Pedro Alves
On 10/25/2017 06:20 PM, Jeff Law wrote: > My conclusion on the virtual dtor issue is that it's not strictly needed > right now. > > IIUC the issue is you could do something like > > base *foo = new derived (); > [ ... ] > delete foo; > > If the base's destructor is not virtual and foo is a bas

Re: [PATCH, rs6000] update vec_perm testcase

2017-10-30 Thread Segher Boessenkool
Hi! On Fri, Oct 27, 2017 at 10:58:34AM -0500, Will Schmidt wrote: > Update the vec-perm testcase to use 'long long' rather than 'long'. This was > a missed typo > from when i initially committed the test. > > Credit given to Carl for noticing this one. > > OK for trunk? Yes please (wi

Re: [09/nn] Add a fixed_size_mode_pod class

2017-10-30 Thread Eric Botcazou
> It sounds like people are mostly concerned about sun studio and xlc? It > doesn't seem that hard to provide precompiled binaries for those two > platforms, and maybe 4.8 binaries for people who want to compile theire > own gcc from source. I'm not sure that we want to enter the business of preco

Re: [RFC PATCH] Merge libsanitizer from upstream

2017-10-30 Thread Maxim Ostapenko
Hi, sorry for the late response. On 20/10/17 13:45, Christophe Lyon wrote: Hi, On 19 October 2017 at 13:17, Jakub Jelinek wrote: On Thu, Oct 19, 2017 at 02:07:24PM +0300, Maxim Ostapenko wrote: Is the patch (the merge + this incremental) ok for trunk? I think the patch is OK, just wonderin

Re: [RFC PATCH] Merge libsanitizer from upstream

2017-10-30 Thread Jakub Jelinek
On Mon, Oct 30, 2017 at 01:12:47PM +0300, Maxim Ostapenko wrote: > I've caught the same error on my Arndale board. The issue seems to be quite > obvious: after merge, ASan requires globals array to be aligned by shadow > granularity. > This trivial patch seems to fix the issue. Could you check it o

Re: [006/nnn] poly_int: tree constants

2017-10-30 Thread Pedro Alves
On 10/27/2017 12:29 AM, Martin Sebor wrote: > > IMO, a good rule of thumb to follow in class design is to have > every class with any user-defined ctor either define a default > ctor that puts the object into a determinate state, or make > the default ctor inaccessible (or deleted in new C++ vers

Re: [patch][x86] GFNI enabling [2/4]

2017-10-30 Thread Kirill Yukhin
On 17 Oct 12:58, Koval, Julia wrote: > Hi, this is the second patch of enabling GFNI ISASET. It adds GF2P8AFFINEINV > instruction. > The instruction is described here: > https://software.intel.com/sites/default/files/managed/c5/15/architecture-instruction-set-extensions-programming-reference.pdf >

[patch] Remove old kludge in gcc.c

2017-10-30 Thread Eric Botcazou
Hi, these lines in gcc.c date back to 2001: /* By default there is no special suffix for target executables. */ /* FIXME: when autoconf is fixed, remove the host check - dj */ #if defined(TARGET_EXECUTABLE_SUFFIX) && defined(HOST_EXECUTABLE_SUFFIX) #define HAVE_TARGET_EXECUTABLE_SUFFIX #endif H

[PATCH][GIMPLEFE] Parse ?: stmts

2017-10-30 Thread Richard Biener
We missed handling of conditional stmts in assignments so the following adds support for it. Bootstrap & regtest running on x86_64-unknown-linux-gnu. Richard. 2017-10-30 Richard Biener c/ * gimple-parser.c (c_parser_gimple_statement): Parse conditional stmts.

Re: [PATCH] Assorted store-merging improvements (PR middle-end/22141)

2017-10-30 Thread Richard Biener
On Fri, 27 Oct 2017, Jakub Jelinek wrote: > Hi! > > The following patch attempts to improve store merging, for the time being > it still only optimizes constant stores to adjacent memory. > > The biggest improvement is handling bitfields, it uses the get_bit_range > helper to find the bounds of

Re: [03/nn] [AArch64] Rework interface to add constant/offset routines

2017-10-30 Thread Richard Sandiford
Richard Sandiford writes: > The port had aarch64_add_offset and aarch64_add_constant routines > that did similar things. This patch replaces them with an expanded > version of aarch64_add_offset that takes separate source and > destination registers. The new routine also takes a poly_int64 offse

Re: [RFC] Make 4-stage PGO bootstrap really working

2017-10-30 Thread Richard Biener
On Fri, Oct 27, 2017 at 4:31 PM, Markus Trippelsdorf wrote: > On 2017.10.27 at 15:03 +0200, Martin Liška wrote: >> > And BTW would it make sense to add -gtoggle to stage2 in bootstrap-lto? >> >> Why do you want to have it there? Am I right that we do not do a stage >> comparison with LTO bootstrap

Re: [PATCH] Change default to -fno-math-errno

2017-10-30 Thread Richard Biener
On Fri, Oct 27, 2017 at 6:28 PM, Joseph Myers wrote: > No existing glibc version defines math_errhandling based on > __NO_MATH_ERRNO__. I'd expect such a change to come with a glibc patch, > and indeed a GCC execution test of the value of math_errhandling to make > sure the compiler's behavior is

Re: [PATCH] enhance -Warray-bounds to detect out-of-bounds offsets (PR 82455)

2017-10-30 Thread Richard Biener
On Sun, 29 Oct 2017, Martin Sebor wrote: > In my work on -Wrestrict, to issue meaningful warnings, I found > it important to detect both out of bounds array indices as well > as offsets in calls to restrict-qualified functions like strcpy. > GCC already detects some of these cases but my tests for

Re: [PATCH] Implement omp async support for nvptx

2017-10-30 Thread Tom de Vries
On 10/30/2017 08:15 AM, Jakub Jelinek wrote: On Fri, Oct 27, 2017 at 03:57:28PM +0200, Tom de Vries wrote: how about this approach: 1 - Move async_run from plugin-hsa.c to default_async_run 2 - Implement omp async support for nvptx ? The first patch moves the GOMP_OFFLOAD_async_run implementati

Re: [PATCH] enhance -Warray-bounds to handle strings and excessive indices

2017-10-30 Thread Richard Biener
On Sun, Oct 29, 2017 at 5:15 PM, Martin Sebor wrote: > Ping -- please see my reply below. > > > On 10/20/2017 09:57 AM, Richard Biener wrote: >> >> get_addr_base_and_unit_offset will return NULL if there's any >>> >>> variable >> >> component in 'ref'. So as written it seems to be

Re: [PATCH 1/7] GCOV: document behavior of -fkeep-{static,inline}-functions (PR gcov-profile/82633).

2017-10-30 Thread Nathan Sidwell
On 10/26/2017 04:11 AM, marxin wrote: gcc/ChangeLog: +++ b/gcc/doc/gcov.texi @@ -327,6 +327,11 @@ non-exceptional paths or only exceptional paths such as C++ exception handlers, respectively. Given @samp{-a} option, unexecuted blocks are marked @samp{$} or @samp{%}, depending on w

Re: [PATCH 2/7] GCOV: introduce usage of terminal colors.

2017-10-30 Thread Nathan Sidwell
On 10/26/2017 04:11 AM, marxin wrote: I consider using colors in context of gcov as very useful. There's example for tramp3d: https://pste.eu/p/Tl2D.html nice! gcc/ChangeLog: 2017-10-23 Martin Liska * color-macros.h: New file. * diagnostic-color.c: Factor out color relate

[Patch, fortran] PR80850 - Sourced allocate() fails to allocate a pointer

2017-10-30 Thread Paul Richard Thomas
Dear All, This bug took a silly amount of effort to diagnose but once done, the fix was obvious. The bug is triggered in this function from the reporter's source file gfc_graph.F90: function GraphIterAppendVertex(this,vertex) result(ierr) !Appends a new vertex to the graph. impl

Re: [PATCH 3/7] GCOV: add support for lines with an unexecuted lines.

2017-10-30 Thread Nathan Sidwell
On 10/26/2017 04:11 AM, marxin wrote: It's possible to have a line of code that has a non-zero coverage. However, it can contain unexecuted blocks and I hope adding a notification can be usefull. LLVM also does that: 1*:5: int a = b < 1 ? (c < 3 ? d : c) : e; A useful enhan

Re: [PATCH] Change default to -fno-math-errno

2017-10-30 Thread Joseph Myers
On Mon, 30 Oct 2017, Richard Biener wrote: > On Fri, Oct 27, 2017 at 6:28 PM, Joseph Myers wrote: > > No existing glibc version defines math_errhandling based on > > __NO_MATH_ERRNO__. I'd expect such a change to come with a glibc patch, > > and indeed a GCC execution test of the value of math_e

Re: [PATCH 4/7] GCOV: add -j argument (human readable format).

2017-10-30 Thread Nathan Sidwell
On 10/26/2017 04:11 AM, marxin wrote: Human readable format is quite useful in my opinion. There's example: -:1:unsigned 14.00K:2:loop (unsigned n, int value) My first thought is 'why 2 decimal places'? That seems excessive. Zero surely suffices? Question is do we wa

[PATCH] Fix PR82762

2017-10-30 Thread Richard Biener
Un-revert the reversion. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied. Richard. 2017-10-30 Richard Biener PR tree-optimization/82762 Revert 2017-10-23 Richard Biener PR tree-optimization/82129 Revert 2017-08-01 Richard Bie

[PATCH] Fix PR82757

2017-10-30 Thread Richard Biener
The following fixes the gold linker still recognizing LTO bytecode via an UNDEF __gnu_lto_* symbol. So on "removal" of the symbol make sure to strip two leading _s. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied. Richard. 2017-10-30 Richard Biener PR lto/82757

Re: [PATCH] Fix PR82757

2017-10-30 Thread Jakub Jelinek
On Mon, Oct 30, 2017 at 01:48:00PM +0100, Richard Biener wrote: > > The following fixes the gold linker still recognizing LTO bytecode > via an UNDEF __gnu_lto_* symbol. So on "removal" of the symbol > make sure to strip two leading _s. > > Bootstrapped and tested on x86_64-unknown-linux-gnu, ap

Re: [PATCH] Fix PR82757

2017-10-30 Thread Richard Biener
On Mon, 30 Oct 2017, Jakub Jelinek wrote: > On Mon, Oct 30, 2017 at 01:48:00PM +0100, Richard Biener wrote: > > > > The following fixes the gold linker still recognizing LTO bytecode > > via an UNDEF __gnu_lto_* symbol. So on "removal" of the symbol > > make sure to strip two leading _s. > > >

Re: [Patch, fortran] PR80850 - Sourced allocate() fails to allocate a pointer

2017-10-30 Thread Andre Vehreschild
Hi Paul, whoopsie, I remember that I inserted the check for _len > 0 in allocate(). So it was me causing the bug. Thanks that you found it. The patch looks good to me. Thanks for the work. - Andre On Mon, 30 Oct 2017 12:20:20 + Paul Richard Thomas wrote: > Dear All, > > This bug took a si

Re: [PATCH] Implement omp async support for nvptx

2017-10-30 Thread Tom de Vries
On 10/30/2017 12:55 PM, Tom de Vries wrote: On 10/30/2017 08:15 AM, Jakub Jelinek wrote: On Fri, Oct 27, 2017 at 03:57:28PM +0200, Tom de Vries wrote: how about this approach: 1 - Move async_run from plugin-hsa.c to default_async_run 2 - Implement omp async support for nvptx ? The first patch

[C++ Patch/RFC] PR 82085 ("[6/7/8 Regression] ICE: Template variable reference used in nested template alias")

2017-10-30 Thread Paolo Carlini
Hi, lately I spent quite a bit of time triaging and resolving ICEs and noticed this recently filed regression which, in a wicked way, I find somehow funny. In short, we are seeing an ICE in tsubst_copy_and_build, when, for an INDIRECT_REF, TREE_TYPE (r) is found null: case INDIRECT_REF:    {

Re: [PATCH][ARM] Remove DImode expansions for 1-bit shifts

2017-10-30 Thread Wilco Dijkstra
Kyrill Tkachov wrote: > On 16/10/17 12:30, Wilco Dijkstra wrote: > > DImode right shifts of 1 are rarely used (6 in total in the GCC binary), > > so there is little benefit of the arm_ashrdi3_1bit and arm_lshrdi3_1bit > > patterns. > > ... but it's still used, and the patterns were put there for a

Re: [C++ Patch/RFC] PR 82085 ("[6/7/8 Regression] ICE: Template variable reference used in nested template alias")

2017-10-30 Thread Jason Merrill
OK. On Mon, Oct 30, 2017 at 9:52 AM, Paolo Carlini wrote: > Hi, > > lately I spent quite a bit of time triaging and resolving ICEs and noticed > this recently filed regression which, in a wicked way, I find somehow funny. > In short, we are seeing an ICE in tsubst_copy_and_build, when, for an > I

Re: [RFC PATCH] Merge libsanitizer from upstream

2017-10-30 Thread Christophe Lyon
On 30/10/2017 11:12, Maxim Ostapenko wrote: Hi, sorry for the late response. On 20/10/17 13:45, Christophe Lyon wrote: Hi, On 19 October 2017 at 13:17, Jakub Jelinek wrote: On Thu, Oct 19, 2017 at 02:07:24PM +0300, Maxim Ostapenko wrote: Is the patch (the merge + this incremental) ok for t

Re: [v3 PATCH] Implement LWG 2485

2017-10-30 Thread Jonathan Wakely
On 29/10/17 12:46 +0200, Ville Voutilainen wrote: On 29 October 2017 at 00:57, Ville Voutilainen wrote: 2017-10-29 Ville Voutilainen Implement LWG 2485 The full testsuite passes on Linux-PPC64. The debug mode tests for array have been run manually on Linux-x64. Looks like there are

Re: [PATCH 5/7] GCOV: std::vector refactoring.

2017-10-30 Thread Nathan Sidwell
On 10/26/2017 04:11 AM, marxin wrote: gcc/ChangeLog: 2017-10-26 Martin Liska * gcov.c (struct source_info): Remove typedef. (source_info::source_info): Add proper ctor. (accumulate_line_counts): Use struct, not it's typedef. (output_gcov_file): Likewise.

Re: [PATCH 6/7] GCOV: Vector refactoring II

2017-10-30 Thread Nathan Sidwell
On 10/26/2017 04:11 AM, marxin wrote: gcc/ChangeLog: 2017-10-26 Martin Liska * gcov.c (struct line_info): Remove it's typedef. (line_info::line_info): Add proper ctor. (line_info::has_block): Do not use a typedef. (struct source_info): Do not use typedef.

Re: [PATCH 7/7] GCOV: std::vector refactoring III

2017-10-30 Thread Nathan Sidwell
On 10/26/2017 04:11 AM, marxin wrote: gcc/ChangeLog: 2017-10-26 Martin Liska * gcov.c (struct name_map): do not use typedef. Define operator== and operator<. (name_search): Remove. (name_sort): Remove. (main): Do not allocate names. (process_fi

Re: [Patch, fortran] PR80850 - Sourced allocate() fails to allocate a pointer

2017-10-30 Thread Paul Richard Thomas
Hi Andre, You didn't cause the bug. That was generated by neglect of the correct transfer of actual to formal in gfc_conv_procedure_call. Your _len check hid the bug :-) We presumably have been have been allocating random multiples of the space required when passing class objects to unlimited dumm

Re: [patch] Remove old kludge in gcc.c

2017-10-30 Thread Jeff Law
On 10/30/2017 04:30 AM, Eric Botcazou wrote: > Hi, > > these lines in gcc.c date back to 2001: > > /* By default there is no special suffix for target executables. */ > /* FIXME: when autoconf is fixed, remove the host check - dj */ > #if defined(TARGET_EXECUTABLE_SUFFIX) && defined(HOST_EXECUTA

Re: Fix basic block reordering glitches

2017-10-30 Thread Jeff Law
On 10/26/2017 02:55 PM, Eric Botcazou wrote: > The attached Ada testcase triggers an ICE at -O3 when compiled for x86: > > eric@polaris:~/build/gcc/native> gcc/xgcc -Bprev-gcc -S opt68.adb -O3 -m32 > opt68.adb: In function 'Opt68.Copy': > opt68.adb:51:6: error: multiple hot/cold transitions found

Re: [07/nn] Add unique CONSTs

2017-10-30 Thread Jeff Law
On 10/27/2017 09:56 AM, Richard Sandiford wrote: > Jeff Law writes: >> On 10/23/2017 05:21 AM, Richard Sandiford wrote: >>> This patch adds a way of treating certain kinds of CONST as unique, >>> so that pointer equality is equivalent to value equality. For now it >>> is restricted to VEC_DUPLICA

Re: [PATCH 2/7] GCOV: introduce usage of terminal colors.

2017-10-30 Thread David Malcolm
On Mon, 2017-10-30 at 08:17 -0400, Nathan Sidwell wrote: > On 10/26/2017 04:11 AM, marxin wrote: > > I consider using colors in context of gcov as very useful. There's > > example for tramp3d: > > https://pste.eu/p/Tl2D.html > > nice! > > > gcc/ChangeLog: > > > > 2017-10-23 Martin Liska > >

[PATCH] Fix PR82765

2017-10-30 Thread Richard Biener
The following fixes an ICE in constant pool hashtable functions for overly large (__int128) array indices. The function doesn't try to be correct in any way so simply truncate to HWI. Bootstrapped and tested on x86_64-unknown-linux-gnu, ok? Thanks, Richard. 2017-10-30 Richard Biener

[PATCH] Minor header reorganization for unordered containers

2017-10-30 Thread Jonathan Wakely
In the spirit of "include what you use" (and because I couldn't find why and include when they don't use it ... it's because uses it). * include/bits/hashtable_policy.h: Include . * include/std/unordered_map: Only include instead of and . * include/std/unorde

[PATCH] Minor tweak to libstdc++ FAQ

2017-10-30 Thread Jonathan Wakely
The C++17 standard renumbers the clauses, and I got annoyed again by somebody writing "stdlibc++" ;-) * doc/xml/faq.xml: Adjust "What is libstdc++?" answer slightly. Committed to trunk. commit e9f2efc7ae2ead47cebfefe3707e6bd73448f65e Author: Jonathan Wakely Date: Mon Oct 30 14:56:01

Re: [14/nn] Add helpers for shift count modes

2017-10-30 Thread Jeff Law
On 10/26/2017 06:06 AM, Richard Biener wrote: > On Mon, Oct 23, 2017 at 1:25 PM, Richard Sandiford > wrote: >> This patch adds a stub helper routine to provide the mode >> of a scalar shift amount, given the mode of the values >> being shifted. >> >> One long-standing problem has been to decide wh

Re: [11/nn] Add narrower_subreg_mode helper function

2017-10-30 Thread Jeff Law
On 10/23/2017 05:24 AM, Richard Sandiford wrote: > This patch adds a narrowing equivalent of wider_subreg_mode. At present > there is only one user. > > > 2017-10-23 Richard Sandiford > Alan Hayward > David Sherwood > > gcc/ > * rtl.h (narrower_subreg_mode): New

Re: [PATCH] Change default to -fno-math-errno

2017-10-30 Thread Wilco Dijkstra
Richard Biener wrote: > Should we also get the __ieee764_ entries used if the compiler sets > __NO_MATH_ERRNO__?  That is, if the librari advertises not setting errno > via math_errhandling is it still allowed to set/clobber errno anyways? That's a good question! I checked and the math wrappers cu

Re: [PATCH] enhance -Warray-bounds to detect out-of-bounds offsets (PR 82455)

2017-10-30 Thread Martin Sebor
On 10/30/2017 05:45 AM, Richard Biener wrote: On Sun, 29 Oct 2017, Martin Sebor wrote: In my work on -Wrestrict, to issue meaningful warnings, I found it important to detect both out of bounds array indices as well as offsets in calls to restrict-qualified functions like strcpy. GCC already det

Re: [RFC PATCH] Merge libsanitizer from upstream

2017-10-30 Thread Maxim Ostapenko
On 30/10/17 17:08, Christophe Lyon wrote: On 30/10/2017 11:12, Maxim Ostapenko wrote: Hi, sorry for the late response. On 20/10/17 13:45, Christophe Lyon wrote: Hi, On 19 October 2017 at 13:17, Jakub Jelinek wrote: On Thu, Oct 19, 2017 at 02:07:24PM +0300, Maxim Ostapenko wrote: Is the pa

Re: RFC: why do our std::ofsteam functions add ios_base::trunc ?

2017-10-30 Thread Jonathan Wakely
On 24/10/17 19:25 +0100, Jonathan Wakely wrote: While adding the new C++17 overloads taking filesystem paths to I noticed that ofstream uses out|trunc for the default arguments instead of out as the stadnard says. The effect is the same, but my preference would be to do what the standard says. I

Re: [PATCH] Change default to -fno-math-errno

2017-10-30 Thread Joseph Myers
On Mon, 30 Oct 2017, Wilco Dijkstra wrote: > Richard Biener wrote: > > Should we also get the __ieee764_ entries used if the compiler sets > > __NO_MATH_ERRNO__?  That is, if the librari advertises not setting errno > > via math_errhandling is it still allowed to set/clobber errno anyways? > > Th

Re: [PATCH] fix cygwin builds

2017-10-30 Thread Jim Wilson
On Mon, 2017-10-30 at 08:07 +0100, Andreas Schwab wrote: > This broke ia64: > > In file included from ./tm_p.h:4:0, >  from ../../gcc/gimplify.c:30: > ../../gcc/config/ia64/ia64-protos.h:49:13: error: use of enum > 'memmodel' without previous declaration > enum memmodel); >

Re: [RFC PATCH] Merge libsanitizer from upstream

2017-10-30 Thread Christophe Lyon
On 30/10/2017 16:21, Maxim Ostapenko wrote: On 30/10/17 17:08, Christophe Lyon wrote: On 30/10/2017 11:12, Maxim Ostapenko wrote: Hi, sorry for the late response. On 20/10/17 13:45, Christophe Lyon wrote: Hi, On 19 October 2017 at 13:17, Jakub Jelinek wrote: On Thu, Oct 19, 2017 at 02:07:

Re: [RFC PATCH] Merge libsanitizer from upstream

2017-10-30 Thread Maxim Ostapenko
On 30/10/17 18:46, Christophe Lyon wrote: On 30/10/2017 16:21, Maxim Ostapenko wrote: On 30/10/17 17:08, Christophe Lyon wrote: On 30/10/2017 11:12, Maxim Ostapenko wrote: Hi, sorry for the late response. On 20/10/17 13:45, Christophe Lyon wrote: Hi, On 19 October 2017 at 13:17, Jakub Jeli

Re: [RFC PATCH] Merge libsanitizer from upstream

2017-10-30 Thread Christophe Lyon
On 30/10/2017 16:54, Maxim Ostapenko wrote: On 30/10/17 18:46, Christophe Lyon wrote: On 30/10/2017 16:21, Maxim Ostapenko wrote: On 30/10/17 17:08, Christophe Lyon wrote: On 30/10/2017 11:12, Maxim Ostapenko wrote: Hi, sorry for the late response. On 20/10/17 13:45, Christophe Lyon wrote:

Re: [PATCH, version 5a], Add support for _Float and _FloatX sqrt, fma, fmin, fmax built-in functions

2017-10-30 Thread Joseph Myers
This has broken building the mainline glibc testsuite with GCC mainline for platforms where long double has binary128 format. Recall that _FloatN type names are not supported for C++, because of the expectation that any C++ bindings for such types would be class-based like the TR 24733 DFP supp

Re: Why do we create a broken symlink for include/bits/stamp-bits ?

2017-10-30 Thread Jonathan Wakely
On 25/10/17 13:18 +0100, Jonathan Wakely wrote: In include/Makefile the stamp-bits-sup target creates a symlink called stamp-bits: stamp-bits-sup: stamp-bits ${bits_sup_headers} @-cd ${bits_builddir} && $(LN_S) $? . 2>/dev/null # @$(STA

[committed] Unbreak big-endian bootstrap (PR middle-end/22141)

2017-10-30 Thread Jakub Jelinek
Hi! Apparently I broke bootstrap or testing on big-endian targets, I'm sorry for screwing up testing and not testing on any big-endian. I've committed the following patch which fixes miscompilation on the following short testcase: struct S { char a, b, c, d; } s; struct T { int a : 2, b : 5, c :

Re: [PATCH] fix AIX fortran builds

2017-10-30 Thread Thomas Koenig
Hi Jim, If I add a call to gcc_unreachable after the longjmp call, then it builds on both linux and AIX.  Anyone have a better idea on how to fix this?  If I don't get any responses in a few days, I will check it in under the obvious rule, since it fixes a build failure. The patch is OK. Than

Re: Fix pretty printers for versioned namespace

2017-10-30 Thread François Dumont
On 26/10/2017 22:41, Jonathan Wakely wrote: On 26/10/17 21:37 +0100, Jonathan Wakely wrote: On 26/10/17 21:30 +0100, Jonathan Wakely wrote: On 26/10/17 22:19 +0200, François Dumont wrote: @@ -1232,7 +1232,7 @@ class Printer(object):   # Add a name using _GLIBCXX_BEGIN_NAMESPACE_CONTAINER.   de

Re: [20/nn] Make tree-ssa-dse.c:normalize_ref return a bool

2017-10-30 Thread Jeff Law
On 10/23/2017 05:29 AM, Richard Sandiford wrote: > This patch moves the check for an overlapping byte to normalize_ref > from its callers, so that it's easier to convert to poly_ints later. > It's not really worth it on its own. > > > 2017-10-23 Richard Sandiford > > gcc/ > * tree-ssa-d

Re: [PATCH][AArch64] Wrong type-attribute for stp and str

2017-10-30 Thread Dominik Inführ
Could you please also commit the patch? I don’t have commit rights. Best Dominik > On 24 Oct 2017, at 16:58, Richard Earnshaw (lists) > wrote: > > On 24/10/17 15:54, Dominik Inführ wrote: >> >>> On 24 Oct 2017, at 11:40, Richard Earnshaw (lists) >>> wrote: >>> >>> On 23/10/17 17:36, Domini

Re: Fix pretty printers for versioned namespace

2017-10-30 Thread Jonathan Wakely
On 30/10/17 18:13 +0100, François Dumont wrote: On 26/10/2017 22:41, Jonathan Wakely wrote: On 26/10/17 21:37 +0100, Jonathan Wakely wrote: On 26/10/17 21:30 +0100, Jonathan Wakely wrote: On 26/10/17 22:19 +0200, François Dumont wrote: @@ -1232,7 +1232,7 @@ class Printer(object):   # Add a na

Re: [PATCH, version 5a], Add support for _Float and _FloatX sqrt, fma, fmin, fmax built-in functions

2017-10-30 Thread Michael Meissner
On Mon, Oct 30, 2017 at 04:16:42PM +, Joseph Myers wrote: > This has broken building the mainline glibc testsuite with GCC mainline > for platforms where long double has binary128 format. > > Recall that _FloatN type names are not supported for C++, because of the > expectation that any C++

[PATCH] Fix gfortran.dg/dtio_13.f90 failure on at least FreeBSD

2017-10-30 Thread Steve Kargl
The attached patch fixes the failure of gfortran.dg/dtio_13.f90 on at least FreeBSD. This test has been failing for a very long time. In resolve_transfer, gfortran needs to check for a BT_CLASS, but failed to to do. The patch allows one to remove a TODO in dt90_13.f90 and more important the dg-e

Re: Fix pretty printers for versioned namespace

2017-10-30 Thread Jonathan Wakely
On 30/10/17 17:59 +, Jonathan Wakely wrote: On 30/10/17 18:13 +0100, François Dumont wrote: On 26/10/2017 22:41, Jonathan Wakely wrote: On 26/10/17 21:37 +0100, Jonathan Wakely wrote: On 26/10/17 21:30 +0100, Jonathan Wakely wrote: On 26/10/17 22:19 +0200, François Dumont wrote: @@ -1232

Re: [PATCH][ARM] Remove DImode expansions for 1-bit shifts

2017-10-30 Thread Kyrill Tkachov
On 30/10/17 13:54, Wilco Dijkstra wrote: Kyrill Tkachov wrote: On 16/10/17 12:30, Wilco Dijkstra wrote: DImode right shifts of 1 are rarely used (6 in total in the GCC binary), so there is little benefit of the arm_ashrdi3_1bit and arm_lshrdi3_1bit patterns. ... but it's still used, and the p

Re: [10/nn] Widening optab cleanup

2017-10-30 Thread Jeff Law
On 10/23/2017 05:23 AM, Richard Sandiford wrote: > widening_optab_handler had the comment: > > /* ??? Why does find_widening_optab_handler_and_mode attempt to > widen things that can't be widened? E.g. add_optab... */ > if (op > LAST_CONV_OPTAB) > return CODE_FOR_noth

Re: [PATCH, version 5a], Add support for _Float and _FloatX sqrt, fma, fmin, fmax built-in functions

2017-10-30 Thread Joseph Myers
On Mon, 30 Oct 2017, Michael Meissner wrote: > > One obvious possible fix would be for the builtins.def macros never to > > define public names such as sqrtf128 for C++, only ever for C. That would > > be on the basis that C++ code is expected to be using a sqrt overload > > anyway - so making

Re: [PATCH][AArch64] Wrong type-attribute for stp and str

2017-10-30 Thread Wilco Dijkstra
Dominik wrote: > Could you please also commit the patch? I don’t have commit rights. I've committed it as r254236. Wilco

Re: [PATCH] Fix gfortran.dg/dtio_13.f90 failure on at least FreeBSD

2017-10-30 Thread Paul Richard Thomas
Hi Steve, It looks good to me - OK. Thanks Paul On 30 October 2017 at 18:05, Steve Kargl wrote: > The attached patch fixes the failure of gfortran.dg/dtio_13.f90 > on at least FreeBSD. This test has been failing for a very long > time. In resolve_transfer, gfortran needs to check for a BT_CL

Re: [PATCH, i386]: Fix PR82725, ICE in change_address_1, at emit-rtl.c

2017-10-30 Thread Paolo Carlini
Hi, On 29/10/2017 18:59, H.J. Lu wrote: 2017-10-29 Uros Bizjak PR target/82725 * g++.dg/pr82725.C: New test. The new testcase is failing for everybody in gnu++98 mode. I think you want to move it to the cpp0x directory and use the appropriate DejaGnu incantations. Paolo.

[C++ PATCH] operator name cleanup prepatch

2017-10-30 Thread Nathan Sidwell
I've been fixing an itch to do with operator name encoding. This patch is the preliminary cleanup to that. 1) A bunch of whitespace, indentation and line wrapping 2) the parser has a massive switch that maps cpp-tokens to operator-names. I move the operator name lookup to after the switch. 3)

Re: [PATCH][PR 81376] Remove unnecessary float casts in comparisons

2017-10-30 Thread Jeff Law
On 10/01/2017 02:37 AM, Yuri Gribov wrote: > Hi all, > > (Previous mail was sent with spurious HTML, sorry!) > > This patch gets rid of float casts in comparisons when all values of > casted integral type are exactly representable by the float type > (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=

Re: [PATCH,RFC] collect2 LTO for AIX

2017-10-30 Thread Jeff Law
On 10/13/2017 12:04 PM, David Edelsohn wrote: > The attached patch is an incremental step toward GCC LTO on AIX. The > recent Libiberty Simple Object improvements for XCOFF provide more > capabilities for operations on XCOFF object files, which are a > prerequisite for GCC LTO functionality. > >

Re: [PATCH] Change default optimization level to -Og

2017-10-30 Thread Eric Gallager
On Thu, Oct 26, 2017 at 2:16 PM, Eric Gallager wrote: > On 10/26/17, Wilco Dijkstra wrote: >> GCC's default optimization level is -O0. Unfortunately unlike other >> compilers, >> GCC generates extremely inefficient code with -O0. It is almost unusable >> for >> low-level debugging or manual ins

Re: [PATCH][PR 81376] Remove unnecessary float casts in comparisons

2017-10-30 Thread Marc Glisse
On Mon, 30 Oct 2017, Jeff Law wrote: +/* Optimize various special cases of (FTYPE) N CMP (FTYPE) M. */ +(for cmp (lt le eq ne ge gt) + (simplify + (cmp (float@0 @1) (float @2)) Since this runs on GENERIC as well as GIMPLE, I don't think you can rely on the types of the float expressions being

Re: [PATCH][PR 81376] Remove unnecessary float casts in comparisons

2017-10-30 Thread Richard Biener
On October 30, 2017 8:22:52 PM GMT+01:00, Marc Glisse wrote: >On Mon, 30 Oct 2017, Jeff Law wrote: > >>> +/* Optimize various special cases of (FTYPE) N CMP (FTYPE) M. */ >>> +(for cmp (lt le eq ne ge gt) >>> + (simplify >>> + (cmp (float@0 @1) (float @2)) >> Since this runs on GENERIC as well

Re: [PATCH][PR 81376] Remove unnecessary float casts in comparisons

2017-10-30 Thread Jeff Law
On 10/30/2017 01:28 PM, Richard Biener wrote: > On October 30, 2017 8:22:52 PM GMT+01:00, Marc Glisse > wrote: >> On Mon, 30 Oct 2017, Jeff Law wrote: >> +/* Optimize various special cases of (FTYPE) N CMP (FTYPE) M. */ +(for cmp (lt le eq ne ge gt) + (simplify + (cmp (float

Re: [PATCH] enhance -Warray-bounds to detect out-of-bounds offsets (PR 82455)

2017-10-30 Thread Richard Biener
On October 30, 2017 4:19:25 PM GMT+01:00, Martin Sebor wrote: >On 10/30/2017 05:45 AM, Richard Biener wrote: >> On Sun, 29 Oct 2017, Martin Sebor wrote: >> >>> In my work on -Wrestrict, to issue meaningful warnings, I found >>> it important to detect both out of bounds array indices as well >>> a

Re: [PATCH v3] Add asan and ubsan support on NetBSD/amd64

2017-10-30 Thread Kamil Rytarowski
On 30.10.2017 08:24, Jakub Jelinek wrote: > On Thu, Oct 26, 2017 at 09:50:43PM +0200, Kamil Rytarowski wrote: >> $ make check-asan >> $ make check-asan-dynamic >> $ make check-ubsan > > That is testing of the upstream code, not of GCC and the libsanitizer > copy in GCC. What I'm more interested t

Re: [PATCH, i386]: Fix PR82725, ICE in change_address_1, at emit-rtl.c

2017-10-30 Thread Uros Bizjak
On Mon, Oct 30, 2017 at 7:56 PM, Paolo Carlini wrote: > Hi, > > On 29/10/2017 18:59, H.J. Lu wrote: >> >> >> 2017-10-29 Uros Bizjak >> >> PR target/82725 >> * g++.dg/pr82725.C: New test. > > The new testcase is failing for everybody in gnu++98 mode. I think you want >

Re: [PATCH] enhance -Warray-bounds to detect out-of-bounds offsets (PR 82455)

2017-10-30 Thread Martin Sebor
On 10/30/2017 01:53 PM, Richard Biener wrote: On October 30, 2017 4:19:25 PM GMT+01:00, Martin Sebor wrote: On 10/30/2017 05:45 AM, Richard Biener wrote: On Sun, 29 Oct 2017, Martin Sebor wrote: In my work on -Wrestrict, to issue meaningful warnings, I found it important to detect both out o

Re: [patch, fortran, RFC] Interchange indices for FORALL and DO CONCURRENT if profitable

2017-10-30 Thread Steve Kargl
On Sat, Oct 28, 2017 at 01:23:30PM +0200, Thomas Koenig wrote: > Hi Steve, > > > On Sat, Oct 28, 2017 at 12:03:58AM +0200, Thomas Koenig wrote: > >> +/* Callback function to determine if an expression is the > >> + corresponding variable. */ > >> + > >> +static int > > static bool > > Most of

Re: [PATCH PR79868 ][aarch64] Fix error calls in aarch64 code so they can be translated (version 2)

2017-10-30 Thread Steve Ellcey
On Thu, 2017-10-26 at 13:56 +0100, Richard Earnshaw (lists) wrote: >  > I can't help feeling that all this logic is somewhat excessive and > changing the wording of each message to include "pragma or attribute" > would solve it equally well.  With the new context highlighting it's > trivial to tell

Re: [PATCH] enhance -Warray-bounds to detect out-of-bounds offsets (PR 82455)

2017-10-30 Thread Richard Biener
On October 30, 2017 9:13:04 PM GMT+01:00, Martin Sebor wrote: >On 10/30/2017 01:53 PM, Richard Biener wrote: >> On October 30, 2017 4:19:25 PM GMT+01:00, Martin Sebor > wrote: >>> On 10/30/2017 05:45 AM, Richard Biener wrote: On Sun, 29 Oct 2017, Martin Sebor wrote: > In my work on -

Re: [PATCH] enhance -Warray-bounds to detect out-of-bounds offsets (PR 82455)

2017-10-30 Thread Martin Sebor
On 10/30/2017 02:56 PM, Richard Biener wrote: On October 30, 2017 9:13:04 PM GMT+01:00, Martin Sebor wrote: On 10/30/2017 01:53 PM, Richard Biener wrote: On October 30, 2017 4:19:25 PM GMT+01:00, Martin Sebor wrote: On 10/30/2017 05:45 AM, Richard Biener wrote: On Sun, 29 Oct 2017, Martin

Re: [PATCH] enhance -Warray-bounds to detect out-of-bounds offsets (PR 82455)

2017-10-30 Thread Jeff Law
On 10/30/2017 09:19 AM, Martin Sebor wrote: > On 10/30/2017 05:45 AM, Richard Biener wrote: >> On Sun, 29 Oct 2017, Martin Sebor wrote: >> >>> In my work on -Wrestrict, to issue meaningful warnings, I found >>> it important to detect both out of bounds array indices as well >>> as offsets in calls

Re: [PATCH] enhance -Warray-bounds to detect out-of-bounds offsets (PR 82455)

2017-10-30 Thread Jeff Law
On 10/29/2017 10:01 AM, Martin Sebor wrote: > In my work on -Wrestrict, to issue meaningful warnings, I found > it important to detect both out of bounds array indices as well > as offsets in calls to restrict-qualified functions like strcpy. > GCC already detects some of these cases but my tests f

Re: [Patch, fortran] PR80850 - Sourced allocate() fails to allocate a pointer

2017-10-30 Thread Paul Richard Thomas
Dear Andre, Committed to trunk as revision 254244. In order to debug the code, I was forced to use 7-branch for development since there were dependencies that detected the change in module number. 7-branch accepted the assignments without casts but I was forced to include them in trunk. As advert

Re: [PATCH, version 5a], Add support for _Float and _FloatX sqrt, fma, fmin, fmax built-in functions

2017-10-30 Thread Michael Meissner
On Mon, Oct 30, 2017 at 06:32:44PM +, Joseph Myers wrote: > On Mon, 30 Oct 2017, Michael Meissner wrote: > > > > One obvious possible fix would be for the builtins.def macros never to > > > define public names such as sqrtf128 for C++, only ever for C. That > > > would > > > be on the basi

[PATCH] Add fields to struct gomp_thread for debugging purposes

2017-10-30 Thread Kevin Buettner
This patch adds a new member named "pthread_id" to the gomp_thread struct. It is initialized in team.c. It also adds a field named "parent" which is initialized to the thread which created the thread in question. For non-nested parallel regions, this is always the master thread. These new field

Re: [PATCH] Add fields to struct gomp_thread for debugging purposes

2017-10-30 Thread Kevin Buettner
Below is some additional information about the work I've been doing. It may be useful in understanding where I'm going with my libgomp patch and other patches still to come... I've been working on improvements to gdb, gcc, and libgomp which make GDB able to better access variables in an OpenMP pr

Re: [PATCH, version 5a], Add support for _Float and _FloatX sqrt, fma, fmin, fmax built-in functions

2017-10-30 Thread Michael Meissner
The x86-64 bootstrap/make check run has now finished, and there were no regressions. Can I check the changes into trunk? -- Michael Meissner, IBM IBM, M/S 2506R, 550 King Street, Littleton, MA 01460-6245, USA email: meiss...@linux.vnet.ibm.com, phone: +1 (978) 899-4797

Re: [PATCH] enhance -Warray-bounds to detect out-of-bounds offsets (PR 82455)

2017-10-30 Thread Martin Sebor
On 10/30/2017 03:48 PM, Jeff Law wrote: On 10/30/2017 09:19 AM, Martin Sebor wrote: On 10/30/2017 05:45 AM, Richard Biener wrote: On Sun, 29 Oct 2017, Martin Sebor wrote: In my work on -Wrestrict, to issue meaningful warnings, I found it important to detect both out of bounds array indices as

  1   2   >