Re: [PATCH] Tree-level fix for PR 69526

2017-05-09 Thread Robin Dapp
ping.

Re: [PATCH, v3] Fix PR51513, switch statement with default case containing __builtin_unreachable leads to wild branch

2017-05-09 Thread Richard Biener
On Mon, 8 May 2017, Peter Bergner wrote: > On 05/08/2017 01:20 PM, Peter Bergner wrote: > > That is what the previous patch did, but as I mention above, > > we generate slightly better code for some test cases (other > > tests seemed to generate the same code) if we don't attempt > > to handle the

[PATCH] Simplify VRP vrp_int_const_binop

2017-05-09 Thread Richard Biener
The following avoids using trees with TREE_OVERFLOW in vrp_int_const_binop which is GC memory heavy and simplifies vrp_int_const_binop by using wide_ints (instead of implementing unsigned overflow detection manually). Bootstrapped and tested on x86_64-unknown-linux-gnu, applied to trunk. Richard

[PATCH] Fix bootstrap on arm target

2017-05-09 Thread Bernd Edlinger
Hi, since a few days the bootstrap of ada fails on a native arm target. It is due to a -Werror warning when passing GNAT_EXCEPTION_CLASS which is a string constant to exception_class_eq, but C++ forbids to cast that to "char*". Not sure what is the smartest solution, I tried the following and it

Re: [Testsuite, committed] Fix vector peeling test failures

2017-05-09 Thread Richard Biener
On Mon, May 8, 2017 at 3:49 PM, Richard Biener wrote: > On Mon, May 8, 2017 at 2:41 PM, Wilco Dijkstra wrote: >> This fixes a few failures on ARM and AArch64 due to a recent change in >> alignment peeling by switching the vector cost model off >> (https://gcc.gnu.org/ml/gcc-patches/2017-05/msg004

Re: [Testsuite, committed] Fix vector peeling test failures

2017-05-09 Thread Richard Biener
On Tue, May 9, 2017 at 10:05 AM, Richard Biener wrote: > On Mon, May 8, 2017 at 3:49 PM, Richard Biener > wrote: >> On Mon, May 8, 2017 at 2:41 PM, Wilco Dijkstra >> wrote: >>> This fixes a few failures on ARM and AArch64 due to a recent change in >>> alignment peeling by switching the vector c

[PATCH] More VRP strict-overflow stuff

2017-05-09 Thread Richard Biener
This removes the remaining case (hopefully) where we disabled optimization during propagation when we encountered cases that require undefined overflow knowledge. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied to trunk. I don't plan to immediately remove the warnings emitted at fin

Re: [PATCH, GCC/ARM, Stage 1] PR71607: Fix ICE when loading constant

2017-05-09 Thread Christophe Lyon
Hi, On 5 May 2017 at 15:19, Richard Earnshaw (lists) wrote: > On 04/05/17 11:40, Prakhar Bahuguna wrote: >> On 03/05/2017 11:30:13, Richard Earnshaw (lists) wrote: >>> On 20/04/17 10:54, Prakhar Bahuguna wrote: [ARM] PR71607: Fix ICE when loading constant gcc/ChangeLog:

Re: [PATCH][x86] Fix ADD[SD,SS] and SUB[SD,SS] runtime tests

2017-05-09 Thread Uros Bizjak
On Mon, May 8, 2017 at 9:53 AM, Peryt, Sebastian wrote: > Hi, > > This patch fixes errors in runtime tests for ADDSD, ADDSS, SUBSD and SUBSS > instructions. > > gcc/testsuite/ > * gcc.target/i386/avx512f-vaddsd-2.c: Test fixed. > * gcc.target/i386/avx512f-vaddss-2.c: Ditto. >

Re: [PATCH][x86] Fix ADD[SD,SS] and SUB[SD,SS] runtime tests

2017-05-09 Thread Uros Bizjak
On Mon, May 8, 2017 at 9:53 AM, Peryt, Sebastian wrote: > Hi, > > This patch fixes errors in runtime tests for ADDSD, ADDSS, SUBSD and SUBSS > instructions. > > gcc/testsuite/ > * gcc.target/i386/avx512f-vaddsd-2.c: Test fixed. > * gcc.target/i386/avx512f-vaddss-2.c: Ditto. >

[PATCH] VRP comments cleanup

2017-05-09 Thread Richard Biener
This removes traces of "overflow infinity" from VRP comments and one unreachable case. Bootstrap / regtest running on x86_64-unknown-linux-gnu. Richard. 2017-05-09 Richard Biener * tree-vrp.c (vrp_val_is_max): Adjust comment. (vrp_val_is_min): Likewise. (set_value_ra

Re: [PATCH] disable -Walloc-size-larger-than and -Wstringop-overflow for non-C front ends (PR 80545)

2017-05-09 Thread Richard Biener
On Mon, May 8, 2017 at 4:31 PM, Martin Sebor wrote: > On 05/04/2017 10:13 PM, Jeff Law wrote: >> >> On 04/28/2017 04:02 PM, Martin Sebor wrote: >>> >>> The two options were included in -Wall and enabled for all front >>> ends but only made to be recognized by the driver for the C family >>> of com

[PR80582][X86] Add missing __mm256_set[r] intrinsics

2017-05-09 Thread Koval, Julia
Hi, This patch implements missing intrinsics: _mm256_set_m128 _mm256_set_m128d _mm256_set_m128i _mm256_setr_m128 _mm256_setr_m128d _mm256_setr_m128i gcc/ * config/i386/avxintrin.h (_mm256_set_m128, _mm256_set_m128d, _mm256_set_m128i, _mm256_setr_m128, _mm256_setr_m128d, _m

Re: [PR80582][X86] Add missing __mm256_set[r] intrinsics

2017-05-09 Thread Jakub Jelinek
On Tue, May 09, 2017 at 09:28:40AM +, Koval, Julia wrote: > Hi, > > This patch implements missing intrinsics: > _mm256_set_m128 > _mm256_set_m128d > _mm256_set_m128i > _mm256_setr_m128 > _mm256_setr_m128d > _mm256_setr_m128i > > gcc/ > * config/i386/avxintrin.h (_mm256_set_m128, _mm256_

RE: [PR80582][X86] Add missing __mm256_set[r] intrinsics

2017-05-09 Thread Koval, Julia
Sorry, fixed that. Thanks, Julia -Original Message- From: Jakub Jelinek [mailto:ja...@redhat.com] Sent: Tuesday, May 09, 2017 11:36 AM To: Koval, Julia Cc: GCC Patches ; Uros Bizjak ; Kirill Yukhin Subject: Re: [PR80582][X86] Add missing __mm256_set[r] intrinsics On Tue, May 09, 2017

[Patch, testsuite, committed] Fix cunroll-13.c failure for avr

2017-05-09 Thread Senthil Kumar Selvaraj
Hi, The test reports bogus failures because the loop variable i is declared as int, and the constant expected in the dump doesn't fit in an int for avr. Fixed by explicitly using __INT32_TYPE__ for targets with __SIZEOF_INT__ < 4. Committed to trunk as obvious. Regards Senthil gcc/test

Re: Handle data dependence relations with different bases

2017-05-09 Thread Richard Biener
On Thu, May 4, 2017 at 7:21 PM, Richard Sandiford wrote: > Richard Biener writes: >> On Thu, May 4, 2017 at 2:12 PM, Richard Biener >> wrote: >>> On Wed, May 3, 2017 at 10:00 AM, Richard Sandiford >>> wrote: This patch tries to calculate conservatively-correct distance vectors for two

Re: Handle data dependence relations with different bases

2017-05-09 Thread Richard Biener
On Fri, May 5, 2017 at 11:27 PM, Bernhard Reutner-Fischer wrote: > On 4 May 2017 14:12:04 CEST, Richard Biener > wrote: > >>nonoverlapping_component_refs_of_decl_p >>should simply skip ARRAY_REFs - but I also see there: >> >>/* ??? We cannot simply use the type of operand #0 of the refs here

Re: [RFC] S/390: Alignment peeling prolog generation

2017-05-09 Thread Richard Biener
On Mon, May 8, 2017 at 6:11 PM, Robin Dapp wrote: >> So the new part is the last point? There's a lot of refactoring in > 3/3 that >> makes it hard to see what is actually changed ... you need to resist >> in doing this, it makes review very hard. > > The new part is actually spread across the t

Re: [PATCH 3/4] Vect peeling cost model

2017-05-09 Thread Richard Biener
On Mon, May 8, 2017 at 6:12 PM, Robin Dapp wrote: > gcc/ChangeLog: + /* Compare costs of peeling for known and unknown alignment. */ + if (unknown_align_inside_cost > peel_for_known_alignment.inside_cost + || (unknown_align_inside_cost == peel_for_known_alignment.inside_cost + && u

Re: [PATCH, GCC/LTO, ping3] Fix PR69866: LTO with def for weak alias in regular object file

2017-05-09 Thread Thomas Preudhomme
Ping? Best regards, Thomas On 02/05/17 17:52, Thomas Preudhomme wrote: Now that GCC 7 is released, ping? Original message below: Hi, This patch fixes an assert failure when linking one LTOed object file having a weak alias with a regular object file containing a strong definition for that s

Re: [patch, fortran] Reduce stack use in blocked matmul

2017-05-09 Thread Andreas Schwab
On Mai 05 2017, Thomas Koenig wrote: > @@ -227,6 +226,17 @@ sinclude(`matmul_asm_'rtype_code`.m4')dnl >if (m == 0 || n == 0 || k == 0) > return; > > + /* Adjust size of t1 to what is needed. */ > + index_type t1_dim; > + t1_dim = (a_dim1-1) * 256 + b_dim1; > +

Re: [PATCH 4/4] Vect peeling cost model

2017-05-09 Thread Richard Biener
On Mon, May 8, 2017 at 6:13 PM, Robin Dapp wrote: > gcc/ChangeLog: > > 2017-05-08 Robin Dapp > > * tree-vect-data-refs.c (vect_peeling_hash_get_lowest_cost): > Remove unused variable. > (vect_enhance_data_refs_alignment): > Compare best peelings costs to doing no

[PATCH] Fix typo in -Wimplicit-fallthrough documentation

2017-05-09 Thread Marek Polacek
It was pointed out to me that we have "the these" in docs. Thus fixed. Applying to trunk. 2017-05-09 Marek Polacek * doc/invoke.texi: Fix typo. diff --git gcc/doc/invoke.texi gcc/doc/invoke.texi index 3308b63..2a075b2 100644 --- gcc/doc/invoke.texi +++ gcc/doc/invoke.texi @@ -4279,1

Re: [PATCH] decl lang hooks

2017-05-09 Thread Marek Polacek
On Mon, May 08, 2017 at 03:16:13PM -0400, Nathan Sidwell wrote: > +/* Return the list of decls in the global namespace. */ > + > +static > +tree get_global_decls () > +{ > + return NAMESPACE_LEVEL (global_namespace)->names; > +} > + > +/* Push DECL into the current scope. */ > + > +static > +tre

Re: [PATCH] decl lang hooks

2017-05-09 Thread Nathan Sidwell
On 05/09/2017 07:01 AM, Marek Polacek wrote: On Mon, May 08, 2017 at 03:16:13PM -0400, Nathan Sidwell wrote: +/* Return the list of decls in the global namespace. */ + +static +tree get_global_decls () These look weird - I'd expect to see "static tree" on the same line. D'oh! thanks for no

Re: [PATCH] decl lang hooks

2017-05-09 Thread Nathan Sidwell
On 05/08/2017 05:34 PM, Joseph Myers wrote: On Mon, 8 May 2017, Nathan Sidwell wrote: This patch changes the C++ FE to override the pushdecl and getdecl lang hooks. In addition to simply overriding them there, I had to fixup a couple of places in c-family/c-common.c and objc/objc-gnu-runtime-a

RE: [PATCH][x86] Fix ADD[SD,SS] and SUB[SD,SS] runtime tests

2017-05-09 Thread Peryt, Sebastian
Hi, Can you please commit it for me? Thanks, Sebastian -Original Message- From: Uros Bizjak [mailto:ubiz...@gmail.com] Sent: Tuesday, May 9, 2017 10:40 AM To: Peryt, Sebastian Cc: gcc-patches@gcc.gnu.org; kirill.yuk...@gmail.com Subject: Re: [PATCH][x86] Fix ADD[SD,SS] and SUB[SD,SS] r

[PATCH][x86] Add missing intrinsics for DIV[SD,SS] and MUL[SD,SS]

2017-05-09 Thread Peryt, Sebastian
Hi, This patch adds missing intrinsics for DIVSD, DIVSS, MULSD and MULSS instructions. 2017-05-09 Sebastian Peryt gcc/ * config/i386/avx512fintrin.h (_mm_mask_mul_round_sd, _mm_maskz_mul_round_sd, _mm_mask_mul_round_ss, _mm_maskz_mul_round_ss, _mm_mask_div_round_sd,

[PATCH][x86] Add missing intrinsics for MAX[SD,SS] and MIN[SD,SS]

2017-05-09 Thread Peryt, Sebastian
Hi, This patch adds missing intrinsics for MAXSD, MAXSS, MINSD and MINSS instructions. 2017-05-09 Sebastian Peryt gcc/ * config/i386/avx512fintrin.h (_mm_mask_max_round_sd, _mm_maskz_max_round_sd, _mm_mask_max_round_ss, _mm_maskz_max_round_ss, _mm_mask_min_round_sd,

Re: [RFC][PATCH] Introduce -fdump*-folding

2017-05-09 Thread Martin Liška
On 05/05/2017 01:50 PM, Richard Biener wrote: > On Thu, May 4, 2017 at 1:10 PM, Martin Liška wrote: >> On 05/04/2017 12:40 PM, Richard Biener wrote: >>> >>> On Thu, May 4, 2017 at 11:22 AM, Martin Liška wrote: On 05/03/2017 12:12 PM, Richard Biener wrote: > > > On Wed, May 3

Re: [PATCH 2/N] Add dump_flags_type for handling of suboptions.

2017-05-09 Thread Martin Liška
On 05/05/2017 12:44 PM, Martin Liška wrote: > Hi. > > This one is more interesting as it implements hierarchical option parsing > and as a first step I implemented that for optgroup suboptions. > > Next candidates are dump_option_value_info and obviously my primary > motivation: > dump_option_va

[PATCH] new -fdump flag

2017-05-09 Thread Nathan Sidwell
This patch adds a new '-fdump-front-end' flag and associated dump machinery. I use it on the modules branch, as that's sufficiently complex to need a dumper. The dump file is unnumbered with a '.fe' suffix. Perhaps it will be useful for other front ends too. I'm also prepared to remove the

[c++ PATCH] PR c++/80682

2017-05-09 Thread Ville Voutilainen
Tested on Linux-x64, not tested with the full suite yet. 2017-05-09 Ville Voutilainen gcc/ PR c++/80682 * cp/method.c (is_trivially_xible): Reject void types. testsuite/ PR c++/80682 * g++.dg/ext/is_trivially_constructible1.C: Add tests for void target. diff --git a/

Re: [RFC][PATCH] Introduce -fdump*-folding

2017-05-09 Thread Richard Biener
On Tue, May 9, 2017 at 2:01 PM, Martin Liška wrote: > On 05/05/2017 01:50 PM, Richard Biener wrote: >> On Thu, May 4, 2017 at 1:10 PM, Martin Liška wrote: >>> On 05/04/2017 12:40 PM, Richard Biener wrote: On Thu, May 4, 2017 at 11:22 AM, Martin Liška wrote: > > On 05/03/2017 12

Re: [PATCH] new -fdump flag

2017-05-09 Thread Richard Biener
On Tue, May 9, 2017 at 2:05 PM, Nathan Sidwell wrote: > This patch adds a new '-fdump-front-end' flag and associated dump machinery. > I use it on the modules branch, as that's sufficiently complex to need a > dumper. The dump file is unnumbered with a '.fe' suffix. Perhaps it will > be useful f

[committed] Another 6.x backport (PR testsuite/80678)

2017-05-09 Thread Jakub Jelinek
Hi! Apparently one of the testcases in my recent 6.x backports ICEs on powerpc64le-linux and doesn't on the trunk/7.x. The following backports fix that, bootstrapped/regtested on x86_64-linux and i686-linux and additionally tested with a cross-compiler on the constexpr-77* and pr71310.c testcases

Re: [patch, fortran] Reduce stack use in blocked matmul

2017-05-09 Thread Christophe Lyon
Hi, On 8 May 2017 at 18:58, Jerry DeLisle wrote: > On 05/05/2017 01:31 PM, Thomas Koenig wrote: >> Hello world, >> >> the attached patch reduces the stack usage by the blocked >> version of matmul for cases where we don't need the full buffer. >> This should improve stack usage. >> >> Regression-

Re: [RFC][PATCH] Introduce -fdump*-folding

2017-05-09 Thread Martin Liška
On 05/09/2017 02:16 PM, Richard Biener wrote: > On Tue, May 9, 2017 at 2:01 PM, Martin Liška wrote: >> On 05/05/2017 01:50 PM, Richard Biener wrote: >>> On Thu, May 4, 2017 at 1:10 PM, Martin Liška wrote: On 05/04/2017 12:40 PM, Richard Biener wrote: > > On Thu, May 4, 2017 at 11:22

Re: [RFC][PATCH] Introduce -fdump*-folding

2017-05-09 Thread Richard Biener
On Tue, May 9, 2017 at 2:46 PM, Martin Liška wrote: > On 05/09/2017 02:16 PM, Richard Biener wrote: >> On Tue, May 9, 2017 at 2:01 PM, Martin Liška wrote: >>> On 05/05/2017 01:50 PM, Richard Biener wrote: On Thu, May 4, 2017 at 1:10 PM, Martin Liška wrote: > On 05/04/2017 12:40 PM, Rich

[PATCH] non-checking pure attribute

2017-05-09 Thread Nathan Sidwell
Hi, For name-lookup cleanup I introduced some accessors that are pure functions when we're not checking. I noticed we already had a couple of them, so introduced an ATTRIBUTE_NTC_PURE define. It avoid #ifndefs and stray semicolons. ok? nathan -- Nathan Sidwell 2017-05-09 Nathan Sidwell

[PATCH] GTY skip

2017-05-09 Thread Nathan Sidwell
gengtype doesn't understand about struct-scope for typedefs, and consequently gets confused if multiple classes define the same-named typedef. The regular default_hash_traits is invisible to gengtype, so it doesn't barf on the first specialization, only on the second -- which is what I'll be a

[gomp5] Depend clause changes

2017-05-09 Thread Jakub Jelinek
Hi! In OpenMP 5.0, depend clause operands are location list items, which are either lvalue expressions, or array sections. In C++ it is easy to handle it with tentative parsing, in C I have to use similar hacks to what is used for declare simd. Tested on x86_64-linux, committed to gomp-5_0-branc

Re: [PATCH] Fix bootstrap on arm target

2017-05-09 Thread Arnaud Charlet
> > since a few days the bootstrap of ada fails on a native arm target. > > It is due to a -Werror warning when passing GNAT_EXCEPTION_CLASS > which is a string constant to exception_class_eq, but C++ forbids to cast > that to "char*". > > Not sure what is the smartest solution, I tried the foll

Re: [c++ PATCH] PR c++/80682

2017-05-09 Thread Marc Glisse
On Tue, 9 May 2017, Ville Voutilainen wrote: Tested on Linux-x64, not tested with the full suite yet. 2017-05-09 Ville Voutilainen gcc/ PR c++/80682 * cp/method.c (is_trivially_xible): Reject void types. testsuite/ PR c++/80682 * g++.dg/ext/is_trivially_constructible1.C

Re: [c++ PATCH] PR c++/80682

2017-05-09 Thread Ville Voutilainen
On 9 May 2017 at 16:12, Marc Glisse wrote: > On Tue, 9 May 2017, Ville Voutilainen wrote: > >> Tested on Linux-x64, not tested with the full suite yet. >> >> 2017-05-09 Ville Voutilainen >> >>gcc/ >> >>PR c++/80682 >>* cp/method.c (is_trivially_xible): Reject void types. >> >>te

Re: [PATCH] non-checking pure attribute

2017-05-09 Thread Richard Biener
On Tue, May 9, 2017 at 3:01 PM, Nathan Sidwell wrote: > Hi, > For name-lookup cleanup I introduced some accessors that are pure functions > when we're not checking. I noticed we already had a couple of them, so > introduced an ATTRIBUTE_NTC_PURE define. It avoid #ifndefs and stray > semicolons.

Re: [1/2] PR 78736: New warning -Wenum-conversion

2017-05-09 Thread Prathamesh Kulkarni
ping https://gcc.gnu.org/ml/gcc-patches/2017-05/msg00161.html Thanks, Prathamesh On 3 May 2017 at 11:30, Prathamesh Kulkarni wrote: > On 3 May 2017 at 03:28, Martin Sebor wrote: >> On 05/02/2017 11:11 AM, Prathamesh Kulkarni wrote: >>> >>> Hi, >>> The attached patch attempts to add option -Wenu

Re: [2/2] PR 78736: libgomp fallout

2017-05-09 Thread Prathamesh Kulkarni
ping https://gcc.gnu.org/ml/gcc-patches/2017-05/msg00135.html Thanks, Prathamesh On 2 May 2017 at 22:43, Prathamesh Kulkarni wrote: > Hi, > During gcc bootstrap, there's a couple of places where the warning got > triggered. > I suppose this wasn't a false positive since enum gomp_schedule_type >

Re: [c++ PATCH] PR c++/80682

2017-05-09 Thread Jakub Jelinek
On Tue, May 09, 2017 at 04:17:07PM +0300, Ville Voutilainen wrote: > On 9 May 2017 at 16:12, Marc Glisse wrote: > > On Tue, 9 May 2017, Ville Voutilainen wrote: > > > >> Tested on Linux-x64, not tested with the full suite yet. > >> > >> 2017-05-09 Ville Voutilainen > >> > >>gcc/ > >> > >>

Re: [2/2] PR 78736: libgomp fallout

2017-05-09 Thread Jakub Jelinek
On Tue, May 09, 2017 at 06:55:12PM +0530, Prathamesh Kulkarni wrote: > ping https://gcc.gnu.org/ml/gcc-patches/2017-05/msg00135.html The libgomp patch is ok provided the warning is added. Though, should it be in -Wall and not say just -Wextra? Jakub

Re: [CHKP] Fix for PR79990

2017-05-09 Thread Alexander Ivchenko
Hi, Here is the latest version of the patch with all comments addressed: gcc/ChangeLog: 2017-05-09 Alexander Ivchenko * tree-chkp.c (chkp_get_hard_register_var_fake_base_address): New function. (chkp_get_hard_register_fake_addr_expr): Ditto. (chkp_build_addr_expr): Ad

Re: [PATCH] non-checking pure attribute

2017-05-09 Thread Nathan Sidwell
On 05/09/2017 09:19 AM, Richard Biener wrote: On Tue, May 9, 2017 at 3:01 PM, Nathan Sidwell wrote: Ok, but ... are they not "pure" enough? That is, do we really care to preserve the checking side-effect for example when doing tree_fits_uhwi (t); (result unused)? I wondered about that

Re: [c++ PATCH] PR c++/80682

2017-05-09 Thread Ville Voutilainen
On 9 May 2017 at 16:25, Jakub Jelinek wrote: >> >> 2017-05-09 Ville Voutilainen >> >> >> >>gcc/ >> >> >> >>PR c++/80682 >> >>* cp/method.c (is_trivially_xible): Reject void types. > > No cp/ in cp/ChangeLog entries. So perhaps 2017-05-09 Ville Voutilainen cp/ PR c++/8

[PATCH 2/2] (v2) Use %qH and %qI throughout C++ frontend

2017-05-09 Thread David Malcolm
Changed in v2: use %qH and %qI rather than %H and %I. This is the second half of the kit, which uses %qH and %qI throughout the C++ frontend whenever describing type mismatches between a pair of %qT. gcc/cp/ChangeLog: * call.c (print_conversion_rejection): Replace pairs of %qT with

[PATCH 1/2] (v2) C++ template type diff printing

2017-05-09 Thread David Malcolm
Changes in v2: - pass "quote" as an extra bool argument to the pp_format_decoder callback, so that we can optionally quote the delayed chunks (with %qH and %qI) - use %qH and %qI rather than %H and %I. - use CLASS_TYPE_P. - use TYPE_P rather than EXPR_P in arg_to_string to handle non-type template

Re: [PATCH] non-checking pure attribute

2017-05-09 Thread Richard Biener
On Tue, May 9, 2017 at 3:33 PM, Nathan Sidwell wrote: > On 05/09/2017 09:19 AM, Richard Biener wrote: >> >> On Tue, May 9, 2017 at 3:01 PM, Nathan Sidwell wrote: > > >> Ok, but ... are they not "pure" enough? That is, do we really care to >> preserve >> the checking side-effect for example when

C++ PATCH for c++/70167, array prvalue treated as lvalue

2017-05-09 Thread Jason Merrill
The issue here was that we've been trying to treat C++ list-initialized temporaries (which are rvalues) the same as C99 compound literals (which are lvalues). This patch distinguishes between them so we can treat them each correctly. This leaves open the question of how compound literals ought to

Re: [PATCH] Improve vectorizer peeling for alignment costmodel

2017-05-09 Thread Richard Biener
On Fri, 5 May 2017, Christophe Lyon wrote: > Hi Richard, > > > On 3 May 2017 at 10:19, Richard Biener wrote: > > > > The following extends the very simplistic cost modeling I added somewhen > > late in the release process to, for all unknown misaligned refs, also > > apply this model for loops

Re: [PATCH] Improve vectorizer peeling for alignment costmodel

2017-05-09 Thread Richard Biener
On Tue, 9 May 2017, Richard Biener wrote: > On Fri, 5 May 2017, Christophe Lyon wrote: > > > Hi Richard, > > > > > > On 3 May 2017 at 10:19, Richard Biener wrote: > > > > > > The following extends the very simplistic cost modeling I added somewhen > > > late in the release process to, for all

Re: [PATCH] disable -Walloc-size-larger-than and -Wstringop-overflow for non-C front ends (PR 80545)

2017-05-09 Thread Martin Sebor
On 05/09/2017 02:57 AM, Richard Biener wrote: On Mon, May 8, 2017 at 4:31 PM, Martin Sebor wrote: On 05/04/2017 10:13 PM, Jeff Law wrote: On 04/28/2017 04:02 PM, Martin Sebor wrote: The two options were included in -Wall and enabled for all front ends but only made to be recognized by the d

Re: [c++ PATCH] PR c++/80682

2017-05-09 Thread Nathan Sidwell
On 05/09/2017 08:06 AM, Ville Voutilainen wrote: Tested on Linux-x64, not tested with the full suite yet. 2017-05-09 Ville Voutilainen gcc/ PR c++/80682 * cp/method.c (is_trivially_xible): Reject void types. testsuite/ PR c++/80682 * g++.dg/ext/is_trivially_c

RE: [PATCH 1/2] Automatic context save/restore for regular interrupts.

2017-05-09 Thread Claudiu Zissulescu
Committed r247795 including the indicated fixes. Thank you for your review, Claudiu

RE: [PATCH 2/2] Fast interrupts support.

2017-05-09 Thread Claudiu Zissulescu
Committed r247796. Thank you for your review, Claudiu

RE: [PATCH 3/3] [ARC] Add support for advanced mpy/mac instructions.

2017-05-09 Thread Claudiu Zissulescu
Added two new tests. Committed r247797. Thank you for your review, Claudiu

Re: [PATCH] Pretty-printing of some unsupported expressions (PR c/35441)

2017-05-09 Thread Joseph Myers
On Mon, 8 May 2017, Volker Reichelt wrote: > 2017-05-07 Volker Reichelt > > PR c/35441 > * c-pretty-print.c (c_pretty_printer::expression): Handle MAX_EXPR, > MIN_EXPR, EXACT_DIV_EXPR, RDIV_EXPR, LROTATE_EXPR, RROTATE_EXPR. > (c_pretty_printer::postfix_expression): Hand

Re: [PATCH 1/2] (v2) C++ template type diff printing

2017-05-09 Thread Nathan Sidwell
On 05/09/2017 10:07 AM, David Malcolm wrote: +static const char * +type_to_string_with_compare (tree type, tree peer, bool verbose, +bool show_color) +{ + for (int idx = 0; idx < len_max; idx++) +{ ... + if (idx + 1 < len_max) + pp_character (pp,

Re: [PATCH, rs6000] Fix vec_xl and vec_xst intrinsics for P8

2017-05-09 Thread Segher Boessenkool
Hi! On Thu, May 04, 2017 at 04:35:10PM -0500, Bill Schmidt wrote: > In an earlier patch, I changed vec_xl and vec_xst to make use of new > POWER9 instructions when loading or storing vector short/char values. > In so doing, I failed to enable the existing instruction use for > -mcpu=power8, so the

[gomp4] OpenACC update if_present runtime support

2017-05-09 Thread Cesar Philippidis
This patch adds runtime support for the OpenACC update if_present clause. It turned out to require significantly less work to implement if_present in the runtime. Instead of creating a new API for GOACC_updated, I exploited the fact that OpenACC no longer uses GOMP_MAP_FORCE_* data mappings. This a

Re: PR translation/80280

2017-05-09 Thread Nick Clifton
Hi Martin, I am currently unable to build gcc for the x86_64-pc-cygwin target because gcc/config/i386/msformat-c.c uses the format_flag_spec struct but it has not been updated with the new field. :-( For example: gcc/config/i386/msformat-c.c gcc/config/i386/msformat-c.c:52:1: error

Re: C++ PATCH for c++/70167, array prvalue treated as lvalue

2017-05-09 Thread Jason Merrill
On Tue, May 9, 2017 at 9:46 AM, Jason Merrill wrote: > The issue here was that we've been trying to treat C++ > list-initialized temporaries (which are rvalues) the same as C99 > compound literals (which are lvalues). This patch distinguishes > between them so we can treat them each correctly. T

Re: [PATCH] non-checking pure attribute

2017-05-09 Thread Nathan Sidwell
On 05/09/2017 09:39 AM, Richard Biener wrote: On Tue, May 9, 2017 at 3:33 PM, Nathan Sidwell wrote: I wondered if we'd get sane backtraces and what not, if the optimizer thought such functions never barfed. Well, I think you'd either ICE in the first check or can safely CSE the second. Do

Re: [PATCH, rs6000] gcc mainline, add builtin support for vec_neg()

2017-05-09 Thread Segher Boessenkool
Hi Carl, On Fri, May 05, 2017 at 02:22:14PM -0700, Carl E. Love wrote: > This patch adds support for the various vec_neg() builtins. > > The patch has been tested on powerpc64le-unknown-linux-gnu (Power 8 LE) > with no regressions. > > Is the patch OK for gcc mainline? Yes please, thanks! Seg

Re: PR translation/80280

2017-05-09 Thread Martin Sebor
On 05/09/2017 09:08 AM, Nick Clifton wrote: Hi Martin, I am currently unable to build gcc for the x86_64-pc-cygwin target because gcc/config/i386/msformat-c.c uses the format_flag_spec struct but it has not been updated with the new field. :-( For example: gcc/config/i386/msformat-c.

Re: PR translation/80280

2017-05-09 Thread Nick Clifton
Hi Martin, > Rats! I ran into this when building for sparcv9-solaris2.11 but > didn't look at the cause of the error carefully enough to recognize > it was caused by my change so I just raised 80673 for it. It didn't > occur to me that targets defined their own format extensions like > this. W

[PATCH, Fortran] PR 80668: wrong error message with -finit-derived

2017-05-09 Thread Fritz Reese
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80668 All, The following fixes a bug exposed in PR 80668 in which the compiler attempted to generate an initializer for components of derived types with the POINTER attribute when compiling with -finit-derived and -finit-*=*. It is nonsensical for comp

Re: Fix for PR79987

2017-05-09 Thread Alexander Ivchenko
If we use chkp_generate_extern_var_bounds for void variable just as for arrays with unknown size, we will create the following gimple seq: # VUSE <.MEM> __size_tmp.0 = __builtin_ia32_sizeof (foo); __size_tmp.1_3 = __size_tmp.0; However, this will fail in verify_gimple_call: tree arg = gimple_cal

[PATCH] Kill -fdump-translation-unit

2017-05-09 Thread Nathan Sidwell
-fdump-translation-unit is an inscrutably opaque dump. It turned out that most of the uses of the tree-dump header file was to indirectly get at dumpfile.h, and the dump_function entry point it had forwarded to a dumper in tree-cfg.c. The gimple dumper would use its node dumper when asked for

Re: PR translation/80280

2017-05-09 Thread Martin Sebor
On 05/09/2017 09:33 AM, Nick Clifton wrote: Hi Martin, Rats! I ran into this when building for sparcv9-solaris2.11 but didn't look at the cause of the error carefully enough to recognize it was caused by my change so I just raised 80673 for it. It didn't occur to me that targets defined their

Re: [PATCH 1/2] C++ template type diff printing

2017-05-09 Thread Jakub Jelinek
On Thu, May 04, 2017 at 07:44:58PM -0400, David Malcolm wrote: > This patch kit implements two new options to make it easier > to read diagnostics involving mismatched template types: > -fdiagnostics-show-template-tree and > -fno-elide-type. > > It adds two new formatting codes: %H and %I whic

[committed] initialize target-specific format_flag_spec members for Cygwin and Solaris

2017-05-09 Thread Martin Sebor
As a result of adding a data member to the format_flag_spec struct my change to enhance -Wformat to warn about poorly quoted GCC diagnostics managed to break bootstrap for the Cygwin and Solaris targets, both of which make use of the struct to define their own printf format extensions. I committe

Re: [PATCH, Fortran] PR 80668: wrong error message with -finit-derived

2017-05-09 Thread Dominique d'Humières
Fritz, Thanks for the quick fix, IMO on the obvious side. Two minor nits: (1) you don’t need the lines (as in "please don’t use them") + +! { dg-final { cleanup-modules "pr80668" } } (2) I don’t understand the comments after 'INTEGER,DIMENSION(:),POINTER :: dist’. TIA Dominique PS The failur

PR77644

2017-05-09 Thread Prathamesh Kulkarni
Hi, The attached patch adds the following pattern to match.pd sqrt(x) cmp sqrt(y) -> x cmp y. and is enabled with -funsafe-math-optimization and -fno-math-errno. Bootstrapped+tested on x86_64-unknown-linux-gnu. Cross-tested on arm*-*-*, aarch64*-*-*. OK for trunk ? Thanks, Prathamesh 2017-05-09

[PATCH, committed] PR80611 [8 regression] test case gfortran.dg/coarray_lock_7.f90 fails starting with r247495

2017-05-09 Thread Dominique d'Humières
I just committed a patch at revision r247803 with updated dg-final regexps (approved by Rich in bugzilla). Dominique

Re: [PATCH], Fix PR 68163, PowerPC power8 sometimes generating move direct to GPR to store 32-bit float

2017-05-09 Thread Segher Boessenkool
Hi Mike, On Fri, May 05, 2017 at 07:43:25PM -0400, Michael Meissner wrote: > This code does stores in Altivec registers by moving the value to FPR and > using > the traditional STFS instruction. However, in looking at the code, I came to > the conclusion that we could do better (PR 80510) by usi

[RFC PATCH, i386]: Enable post-reload compare elimination pass

2017-05-09 Thread Uros Bizjak
Hello! Attached patch enables post-reload compare elimination pass by providing expected patterns (duplicates of existing patterns with setters of reg and flags switched in the parallel) for flag setting arithmetic instructions. The merge triggers more than 3000 times during the gcc bootstrap, mo

Re: [PATCH, Fortran] PR 80668: wrong error message with -finit-derived

2017-05-09 Thread Fritz Reese
> (1) you don’t need the lines (as in "please don’t use them") > > + > +! { dg-final { cleanup-modules "pr80668" } } I will remove the "dg-final" lines. > > (2) I don’t understand the comments after 'INTEGER,DIMENSION(:),POINTER :: > dist’. (2) Sorry, the comments were meant to show the error t

Re: [Patch, Fortran, OOP] PR 79311: ICE in generate_finalization_wrapper, at fortran/class.c:1992

2017-05-09 Thread Jerry DeLisle
On 05/08/2017 02:16 PM, Janus Weil wrote: > Hi all, > > the attached patch fixes an ICE-on-valid problem with finalization by > making sure that the finalization procedures are properly resolved. > > In the test case, the finalizer of the component type was not being > resolved if the superordina

Re: [PATCH, Fortran] PR 80668: wrong error message with -finit-derived

2017-05-09 Thread Jerry DeLisle
On 05/09/2017 08:37 AM, Fritz Reese wrote: > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80668 > > All, > > The following fixes a bug exposed in PR 80668 in which the compiler > attempted to generate an initializer for components of derived types > with the POINTER attribute when compiling with

Re: [PATCH, GCC/ARM, Stage 1] Enable Purecode for ARMv8-M Baseline

2017-05-09 Thread Christophe Lyon
Hi, On 4 May 2017 at 11:05, Ramana Radhakrishnan wrote: > On Thu, May 04, 2017 at 09:50:42AM +0100, Prakhar Bahuguna wrote: > > >> > >> > Otherwise ok. Please respin and test with an armhf thumb32 bootstrap >> > and regression test run. >> > >> > regards >> > Ramana >> >> I've respun this patch

Re: [PATCH, Fortran] PR 80668: wrong error message with -finit-derived

2017-05-09 Thread Dominique d'Humières
> Le 9 mai 2017 à 18:15, Fritz Reese a écrit : > >> (1) you don’t need the lines (as in "please don’t use them") >> >> + >> +! { dg-final { cleanup-modules "pr80668" } } > > I will remove the "dg-final" lines. > >> >> (2) I don’t understand the comments after 'INTEGER,DIMENSION(:),POINTER ::

Re: [Patch, Fortran, OOP] PR 79311: ICE in generate_finalization_wrapper, at fortran/class.c:1992

2017-05-09 Thread Steve Kargl
On Tue, May 09, 2017 at 09:18:42AM -0700, Jerry DeLisle wrote: > > Yes Ok and thanks for patch. The lock_7 is fixed today and I did not see the > mvbits fail yesterday. Regardlessm unrelated. > mvbits_7 is a victim of stupid by non-Fortran committers. /home/sgk/gcc/gccx/gcc/testsuite/gfortran.d

Re: [patch, fortran] Reduce stack use in blocked matmul

2017-05-09 Thread Thomas Koenig
Am 09.05.2017 um 12:43 schrieb Andreas Schwab: On Mai 05 2017, Thomas Koenig wrote: @@ -227,6 +226,17 @@ sinclude(`matmul_asm_'rtype_code`.m4')dnl if (m == 0 || n == 0 || k == 0) return; + /* Adjust size of t1 to what is needed. */ + index_type t1_dim; + t1_

Re: [PATCH, rs6000] Add x86 instrinsic headers to GCC PPC64LE taget

2017-05-09 Thread Segher Boessenkool
Hi! On Mon, May 08, 2017 at 09:49:57AM -0500, Steven Munroe wrote: > Thus I would like to restrict this support to PowerPC > targets that support VMX/VSX and PowerISA-2.07 (power8) and later. What happens if you run it on an older machine, or as BE or 32-bit, or with vectors disabled? > So I pro

[patch, libfortran] Fix PR 80687l build failure on nvptx

2017-05-09 Thread Thomas Koenig
Hello world, the attached patch hopefully fixes the build failure on nvptx introduced by my recent matmul library patch. It uses malloc/free if VLAs do not work. Thomas S., does this fix the problem? Tested on x86_64 to make sure that the matmul tests still pass; full regression test still in

Re: [patch, libfortran] Fix PR 80687l build failure on nvptx

2017-05-09 Thread Janne Blomqvist
On Tue, May 9, 2017 at 8:35 PM, Thomas Koenig wrote: > Hello world, > > the attached patch hopefully fixes the build failure on nvptx introduced > by my recent matmul library patch. It uses malloc/free if VLAs do not > work. > > Thomas S., does this fix the problem? > > Tested on x86_64 to make s

Re: [1/2] PR 78736: New warning -Wenum-conversion

2017-05-09 Thread Martin Sebor
On 05/09/2017 07:24 AM, Prathamesh Kulkarni wrote: ping https://gcc.gnu.org/ml/gcc-patches/2017-05/msg00161.html Thanks, Prathamesh On 3 May 2017 at 11:30, Prathamesh Kulkarni wrote: On 3 May 2017 at 03:28, Martin Sebor wrote: On 05/02/2017 11:11 AM, Prathamesh Kulkarni wrote: Hi, The att

Re: [PATCH, rs6000] Fix vec_xl and vec_xst intrinsics for P8

2017-05-09 Thread Bill Schmidt
On May 9, 2017, at 9:58 AM, Segher Boessenkool wrote: > > Hi! > > On Thu, May 04, 2017 at 04:35:10PM -0500, Bill Schmidt wrote: >> In an earlier patch, I changed vec_xl and vec_xst to make use of new >> POWER9 instructions when loading or storing vector short/char values. >> In so doing, I fail

[PATCH] make RTL/TREE/IPA dump kind an index

2017-05-09 Thread Nathan Sidwell
Currently, the TDF_foo flags serve 3 purposes: 1) what kind of dump 2) how detailed to print it 3) auxiliary message control This addresses #1, which currently uses a bit mask of TDF_{TREE,RTL,IPA}, of which exactly one must be set. The patch changes things so that these are now an index value

Re: [PATCH, rs6000] Add x86 instrinsic headers to GCC PPC64LE taget

2017-05-09 Thread Steven Munroe
On Tue, 2017-05-09 at 12:23 -0500, Segher Boessenkool wrote: > Hi! > > On Mon, May 08, 2017 at 09:49:57AM -0500, Steven Munroe wrote: > > Thus I would like to restrict this support to PowerPC > > targets that support VMX/VSX and PowerISA-2.07 (power8) and later. > > What happens if you run it on

  1   2   >