Re: [PATCH] ggc-page loop

2017-05-02 Thread Andrew Pinski
On Tue, May 2, 2017 at 3:41 PM, Nathan Sidwell wrote: > This loop in ggc-page confused me, because the iterator is one greater than > the indexing value. Also the formatting of the array indexing is incorrect. > > Fixed thusly, and applied as obvious after booting on x86_64-linux-gnu - for (i =

[PATCH 1/7] enhance -Wformat to detect quoting problems (PR 80280 et al.)

2017-05-02 Thread Martin Sebor
In bug 80280 - Missing closing quote (%>) c/semantics.c and c/c-typeck.c, a translator points out one of a number of kinds of cosmetic problems that tend to come up late in development, during translation of GCC messages. Other, arguably more minor, kinds of issues are caused by forgetting to use

[PATCH 4/7] clean up quoting problems - config/i386 (PR 80280 et al.)

2017-05-02 Thread Martin Sebor
The attached patch adds missing quoting to diagnostic directives in files in the config/i386 directory. Martin gcc/ChangeLog: * config/i386/i386.c (ix86_function_versions): Quote a %D directive. diff --git a/gcc/config/i386/i386.c b/gcc/config/i386/i386.c index d985657..450f9b0 100644 --- a/gc

[PATCH 2/7] clean up quoting problems - gcc (PR 80280 et al.)

2017-05-02 Thread Martin Sebor
The attached patch adds missing quoting to diagnostic directives in files in the top-level gcc/ directory. Martin gcc/ChangeLog: * builtins.c (expand_builtin_object_size): Add missing quoting to %D and like directives. * hsa-gen.c (hsa_type_for_scalar_tree_type): Same. (hsa_type_for_tree_typ

[PATCH 3/7] clean up quoting problems - c-family (PR 80280 et al.)

2017-05-02 Thread Martin Sebor
The attached patch adds missing quoting to diagnostic directives in files in the c-family/ directory. Martin gcc/c-family/ChangeLog: * c-attribs.c (handle_alias_ifunc_attribute): Quote a %D directive. (handle_weakref_attribute): Same. diff --git a/gcc/c-family/c-attribs.c b/gcc/c-family/c-att

[PATCH 6/7] clean up quoting problems - objc (PR 80280 et al.)

2017-05-02 Thread Martin Sebor
The attached patch adds missing quoting to diagnostic directives in files in the objc/ directory. Martin gcc/objc/ChangeLog: * objc-gnu-runtime-abi-01.c (objc_eh_runtime_type): Add missing quoting to %T directives. * objc-next-runtime-abi-01.c (objc_eh_runtime_type): Ditto. * objc-next-runti

[PATCH 5/7] clean up quoting problems - c-family (PR 80280 et al.)

2017-05-02 Thread Martin Sebor
The attached patch adds missing quoting to diagnostic directives in files in the cp/ directory. Martin gcc/cp/ChangeLog: * call.c (print_z_candidate): Add missing quoting to %D and other like directives. (build_op_call_1): Same. * constraint.cc (diagnose_check_constraint): Same. * mangle.c

[PATCH 7/7] adjust quoting in tests (PR 80280 et al.)

2017-05-02 Thread Martin Sebor
The attached patch adjust tests to expect quoting where it was previously not expected. Martin gcc/testsuite/ChangeLog: * g++.dg/abi/Wabi-2-3.C: Adjust. * g++.dg/abi/Wabi-3-2.C: Ditto. * g++.dg/lookup/using17.C: Ditto. * gcc.dg/format/gcc_diag-1.c (foo): Ditto. diff --git a/gcc/testsuite/g+

Re: {PATCH] New C++ warning -Wcatch-value

2017-05-02 Thread Martin Sebor
On 05/01/2017 02:38 AM, Volker Reichelt wrote: Hi, catching exceptions by value is a bad thing, as it may cause slicing, i.e. a) a superfluous copy b) which is only partial. See also https://github.com/isocpp/CppCoreGuidelines/blob/master/CppCoreGuidelines.md#e15-catch-exceptions-from-a-hierarc

Re: [PATCH] c++ parser: fix-it hints for wrong usage of 'friend' and 'auto'

2017-05-02 Thread Martin Sebor
On 04/29/2017 04:23 PM, Volker Reichelt wrote: Hi, the following patch adds fix-it hints to the C++ parser for two wrongly used keywords detected in cp_parser_decl_specifier_seq. Bootstrapped and regtested on x86_64-pc-linux-gnu. OK for trunk? Regards, Volker 2017-04-29 Volker Reichelt

Re: [PATCH v4 0/12] [i386] Improve 64-bit Microsoft to System V ABI pro/epilogues

2017-05-02 Thread Daniel Santos
On 05/02/2017 05:21 AM, JonY wrote: On 05/01/2017 11:31 AM, Uros Bizjak wrote: I also assume that Cygwin and MinGW people agree with the patch and the functionality itself. Uros. Cygwin and MinGW does not use SysV/MS transitions directly in their own code, changes should be OK. And to be c

Re: [PATCH v4 0/12] [i386] Improve 64-bit Microsoft to System V ABI pro/epilogues

2017-05-02 Thread Daniel Santos
On 05/02/2017 05:40 AM, Kai Tietz wrote: Right, and Wine people will tell, if something doesn't work for them. So ok for me too. Kai Yes, and I although I haven't repeated the Wine tests in a few months, little has changed since my last run. I'll be running them again soon anyway. Daniel

Re: [1/2] PR 78736: New warning -Wenum-conversion

2017-05-02 Thread Prathamesh Kulkarni
On 3 May 2017 at 03:28, Martin Sebor wrote: > On 05/02/2017 11:11 AM, Prathamesh Kulkarni wrote: >> >> Hi, >> The attached patch attempts to add option -Wenum-conversion for C and >> objective-C similar to clang, which warns when an enum value of a type >> is implicitly converted to enum value of

Re: [PATCH 09/12] [i386] Add patterns and predicates foutline-msabi-xlouges

2017-05-02 Thread Uros Bizjak
On Wed, May 3, 2017 at 12:16 AM, Daniel Santos wrote: >> I'd recommend that in the predicate, you check match_parallel from the >> bottom up, since subexpressions on the top are already matched, and >> you can have different number of subexpressions at the top. >> >> Uros. > > > OK, this all make

Re: [PATCH GCC8][01/33]Handle TRUNCATE between tieable modes in rtx_cost

2017-05-02 Thread Eric Botcazou
> 2017-04-11 Bin Cheng > > * rtlanal.c (rtx_cost): Handle TRUNCATE between tieable modes. This breaks bootstrap with RTL checking: /home/eric/build/gcc/native/./gcc/xgcc -B/home/eric/build/gcc/native/./gcc/ - nostdinc -x c /dev/null -S -o /dev/null -fself- test=/home/eric/svn/gcc/gcc/te

<    1   2