Re: [PATCH] Implement a warning for bogus sizeof(pointer) / sizeof(pointer[0])

2017-04-27 Thread Martin Sebor
I suggest avoiding "element size" because the pointed-to argument need not be an array. Mentioning the types should help users better understand the problem (especially in C++ where types are often obscured by layers of templates). It might also be a nice touch to add a note pointing to the decl

Re: [PATCH 05/12] [i386] Add option -mcall-ms2sysv-xlogues

2017-04-27 Thread Sandra Loosemore
On 04/27/2017 02:09 AM, Daniel Santos wrote: @@ -25308,6 +25308,17 @@ You can control this behavior for specific functions by using the function attributes @code{ms_abi} and @code{sysv_abi}. @xref{Function Attributes}. +@item -mcall-ms2sysv-xlogues +@opindex mcall-ms2sysv-xlogues +@opindex

Re: [PATCH] handle sprintf(d, "%s", ...) in gimple-ssa-sprintf.c

2017-04-27 Thread Martin Sebor
On 04/25/2017 09:55 PM, Martin Sebor wrote: On 04/25/2017 04:05 PM, Jeff Law wrote: On 04/21/2017 03:33 PM, Martin Sebor wrote: Bug 77671 - missing -Wformat-overflow warning on sprintf overflow with "%s", is caused by gimple-fold.c transforming s{,n}printf calls with a plain "%s" format string

Re: [PATCH][RFC] Enable -fstrict-overflow by default

2017-04-27 Thread Martin Sebor
On 04/27/2017 03:16 AM, Richard Biener wrote: On Wed, 26 Apr 2017, Martin Sebor wrote: On 04/26/2017 01:59 AM, Richard Biener wrote: On Tue, 25 Apr 2017, Martin Sebor wrote: On 04/24/2017 05:25 AM, Richard Biener wrote: The following makes signed overflow undefined for all (non-)optimizati

Re: [PATCH] Fix AIX bootstrap comparison due to empty *-tests.c and selftest* files (PR bootstrap/80531)

2017-04-27 Thread Richard Biener
On April 27, 2017 10:20:57 PM GMT+02:00, Jakub Jelinek wrote: >Hi! > >This is something that fails bootstrap newly in GCC 7 and only with >(now on the branch default --enable-checking=release (or >--disable-checking)). The problem is that the *-tests.c and >selftest*.c >sources after including so

Re: [PATCH 05/12 rev 1] [i386] Add option -mcall-ms2sysv-xlogues

2017-04-27 Thread Daniel Santos
Oops. I blame my fingers. :) Daniel --- gcc/config/i386/i386.c | 6 +- gcc/config/i386/i386.opt | 4 gcc/doc/invoke.texi | 13 - 3 files changed, 21 insertions(+), 2 deletions(-) diff --git a/gcc/config/i386/i386.c b/gcc/config/i386/i386.c index 113f83742c2..52111

Re: [PR 78687] Set SRA grp_write lazily

2017-04-27 Thread Richard Biener
On Thu, 27 Apr 2017, Martin Jambor wrote: > Hi, > > PR 78687 is a reported SRA missed-optimization issue. The problem, in > its simplest form, happens when we have two big local non-addressable > structures, we initialize only small portions of the first one and > then assign all of it it to th

<    1   2