Re: [PATCH 7/9] Add RTL-error-handling to host

David Malcolm writes: > +inline file_location::file_location (const char *filename_in, int lineno_in, > int colno_in) > +: filename (filename_in), lineno (lineno_in), colno (colno_in) {} > + Long line (a pre-existing problem, since you're just moving the code). I'm happy with this FWIW, but it'

Re: [PATCH] PR fortran/78479 -- allocate a charlen

On Tue, Nov 22, 2016 at 10:21:52PM +0100, Janus Weil wrote: > > > The patch and ChangeLog shuod be sufficient to explain the change. > > Regression tested on x86_64-*-freebsd. OK to commit? > > the patch itself looks good. > Thanks. > For the test case, I'd prefer a somewhat more meaningful n

[PATCH] 78461 - [7 Regression] ICE: in operator+=, at gimple-ssa-sprintf.c:214

With r242674 having enabled the -fprintf-return-value option by default, when warnings are disabled the gimple-ssa-sprintf pass is now exercised in ways it was not being tested. One of these untested use cases exposed a bug in the logic used to compute the minimum number of bytes output by a %.*s

Go patch committed: Move encoding utilities from gcc/go to gofrontend proper

This patch by Than McIntosh moves the name encoding utilities from gcc/go/go-gcc.cc to the gofrontend proper, where they are available for other backend implementations. Bootstrapped and ran Go testsuite on x86_64-pc-linux-gnu. Committed to mainline. Ian Index: gcc/go/Make-lang.in ==

Re: [PING][PATCH][2/2] Early LTO debug -- main part

On 11/11/2016 03:06 AM, Richard Biener wrote: +/* ??? In some cases the C++ FE (at least) fails to + set DECL_CONTEXT properly. Simply globalize stuff + in this case. For example + __dso_handle created via iostream line 74 col 25. */ The comment for DECL_CONTEXT says t

GCC patch committed: Fix -fdump-go-spec to not align last field to type alignment

The code that handles -fdump-go-spec was incorrectly trying to pad the last field of a struct/union to the alignment of the overall struct/union. That is unnecessary and incorrect, as the alignment is handled by go_force_record_alignment anyhow. It caused a compiler crash on x32 and various other

Re: [PATCH PR68030/PR69710][RFC]Introduce a simple local CSE interface and use it in vectorizer

On 11/22/2016 08:07 AM, Bin.Cheng wrote: > On Mon, Nov 21, 2016 at 9:34 PM, Doug Gilmore wrote: >> I haven't seen any followups to this discussion of Bin's patch to >> PR68303 and PR69710, the patch submission: >> http://gcc.gnu.org/ml/gcc-patches/2016-05/msg02000.html >> >> Discussion: >> http://

Re: [PATCH v3] cpp/c: Add -Wexpansion-to-defined

On Tue, 22 Nov 2016, Paolo Bonzini wrote: > > It's not obvious to me whether this belongs in -Wextra. After all, this > > is a perfectly reasonable and useful GNU C feature, or at least some cases > > of it are (like "#define FOO (BAR || defined something)"). Is the > > argument that there are t

Re: [PATCH] Fix up handle_pragma_target (PR target/78451)

On Tue, 22 Nov 2016, Jakub Jelinek wrote: > Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? > > 2016-11-22 Jakub Jelinek > > PR target/78451 > * c-pragma.c (handle_pragma_target): Don't replace > current_target_pragma, but chainon the new args to the cur

Re: GCC patch committed: Fix -fdump-go-spec to not align last field to type alignment

On 11/22/2016 04:25 PM, Ian Lance Taylor wrote: The code that handles -fdump-go-spec was incorrectly trying to pad the last field of a struct/union to the alignment of the overall struct/union. That is unnecessary and incorrect, as the alignment is handled by go_force_record_alignment anyhow. I

[PATCH] eliminate calls to snprintf(0, 0, ...) with known return value (pr78476)

Calls to bounded functions like snprintf with a zero-size buffer are special requests to compute the size of output without actually writing any. For example: int n = snprintf(0, 0, "%08x", rand ()); is a request to compute the number of bytes that the function would format if it were passed

[PATCH, committed] TILE-Gx: fix zero_extract/sign_extract patterns

This patch fixes the zero_extract/sign_extract patterns so that they properly handle the case when pos + size > number of bits in a word. Bootstrapped and tested on TILE-Gx hardware, also backported to GCC 6. * config/tilegx/tilegx.md (*zero_extract): Use define_insn_and_split ins

[PATCH, committed] TILEPro/TILE-Gx: add trap patterns

This patch adds a trap pattern to TILEPro/Tile-Gx. The pattern emits an instruction bundle that causes a SIGABRT. Bootstrapped and tested on TILEPro/TILE-Gx hardware, also backported to GCC 6. * config/tilegx/tilegx.md (trap): New pattern. * config/tilepro/tilepro.md (trap): Likewise. diff --gi

[PATCH v2 0/9] Add optimization -moutline-msabi-xlougues (for Wine 64)

Due to ABI differences, when a 64-bit Microsoft function calls and System V function, it must consider RSI, RDI and XMM6-15 as clobbered. Saving these registers can cost as much as 109 bytes and a similar amount for restoring. This patch set targets 64-bit Wine and aims to mitigate some of the

[PATCH 4/9] Adds class xlouge_layout and new fields to struct machine_function

Of the new fields added to struct machine_function, outline_ms_sysv is initially set in ix86_expand_call, but may later be cleared when ix86_compute_frame_layout is called (both of these are in subsequent patch). If it is not cleared, then the remaining new fields will be set. The new class xloug

[PATCH 2/9] Minor refactor in ix86_compute_frame_layout

This refactor is separated from a future patch that actually alters ix86_compute_frame_layout. --- gcc/config/i386/i386.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/gcc/config/i386/i386.c b/gcc/config/i386/i386.c index 56cc67d..5ed8fb6 100644 --- a/gcc/config

[PATCH 1/9] Change type of x86_64_ms_sysv_extra_clobbered_registers

This will need to be unsigned for a subsequent patch. Also adds the constant NUM_X86_64_MS_CLOBBERED_REGS for brievity. --- gcc/config/i386/i386.c | 8 +++- gcc/config/i386/i386.h | 4 +++- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/gcc/config/i386/i386.c b/gcc/config/i386/

[PATCH 3/9] Add option -moutline-msabi-xlogues

Adds the option to i386.opt and i386.c and adds documentation to invoke.texi. --- gcc/config/i386/i386.c | 1 + gcc/config/i386/i386.opt | 5 + gcc/doc/invoke.texi | 11 ++- 3 files changed, 16 insertions(+), 1 deletion(-) diff --git a/gcc/config/i386/i386.c b/gcc/config/i386

[PATCH 6/9] Modify ix86_compute_frame_layout for foutline-msabi-xlogues

ix86_compute_frame_layout will now populate fields added to structs machine_function and ix86_frame and modify the frame layout specific to facilitate the use of save & restore stubs. --- gcc/config/i386/i386.c | 138 ++--- 1 file changed, 131 insertions

[PATCH 5/9] Modify ix86_save_reg to optionally omit stub-managed registers

Adds static HARD_REG_SET stub_managed_regs to track registers that will be managed by the pro/epilogue stubs for the function. Adds a third parameter bool ignore_outlined to ix86_save_reg to specify rather or not the count should include registers marked in stub_managed_regs. --- gcc/config/i386/

[PATCH 8/9] Add msabi pro/epilogue stubs to libgcc

Adds libgcc/config/i386/i386-asm.h to manage common cpp and gas macros. stubs use the following naming convention: (sav|res)ms64[f][x] save|resSave or restore ms64Avoid possible name collisions with future stubs (specific to 64-bit msabi --> sysv scenario)

[PATCH 9/9] Add remainder of moutline-msabi-xlogues implementation

Adds functions emit_msabi_outlined_save and emit_msabi_outlined_restore, which are called from ix86_expand_prologue and ix86_expand_epilogue, respectively. Also adds the code to ix86_expand_call that enables the optimization (setting the machine_function's outline_ms_sysv field). --- gcc/config/i

[PATCH 7/9] Add patterns and predicates foutline-msabi-xlouges

Adds the predicates save_multiple and restore_multiple to predicates.md, which are used by following patterns in sse.md: * save_multiple - insn that calls a save stub * save_multiple_hfp - insn that calls a save stub when a hard frame pointer is used. * restore_multiple - call_insn that calls a

[PATCH] [AArch64] Fix PR77634

Hi, Please find attached the patch that fixes PR77634. Some testcase does not use -fno-vect-cost-model and hence fails when gcc is configured "--with-cpu=thunderx". The attached patch modifies the testcases to use -fno-vect-cost-model. Please review the patch and let me know if its okay? 2016

[PING] [PATCH] Fix PR31096

Hi, Please consider this as a personal reminder to review the patch at following link and let me know your comments on the same. https://gcc.gnu.org/ml/gcc-patches/2016-11/msg01049.html Thanks, Naveen

[PATCH] [AArch64] Fix PR77635

Hi, Please find attached the patch that fixes PR77635. Some load pair testcase fails when gcc is configured "--with-cpu=thunderx" as -mcpu=generic is missed out in them. The attached patch modifies the testcases to use -mcpu=generic. Please review the patch and let me know if its okay? 2016-11-

[PATCH] [AArch64] Fix PR71112

Hi, Please find attached the patch that fixes PR71112. The current implementation that handles SYMBOL_SMALL_GOT_28K in aarch64_load_symref_appropriately access the high part of RTX for Big-Endian mode which results in ICE for ILP32. The attached patch modifies it by accessing the lower part for

[PING] [PATCH] Fix PR71727

Hi, Please consider this as a personal reminder to review the patch at following link and let me know your comments on the same. https://gcc.gnu.org/ml/gcc-patches/2016-11/msg00697.html Thanks, Naveen

Re: GCC patch committed: Fix -fdump-go-spec to not align last field to type alignment

On Tue, Nov 22, 2016 at 7:01 PM, Martin Sebor wrote: > On 11/22/2016 04:25 PM, Ian Lance Taylor wrote: >> >> The code that handles -fdump-go-spec was incorrectly trying to pad the >> last field of a struct/union to the alignment of the overall >> struct/union. That is unnecessary and incorrect, a

Re: [PING] [PATCH] Fix PR31096

On Wed, 23 Nov 2016, Hurugalawadi, Naveen wrote: Please consider this as a personal reminder to review the patch at following link and let me know your comments on the same. https://gcc.gnu.org/ml/gcc-patches/2016-11/msg01049.html Hi, the gcc part looks good to me (I didn't look at the tests

[PATCH] remove invalid "tail +16c"

Hi all, In "config/acx.m4", there are still some "tail +16c" which are invalid on POSIX systems. In my opinion， all "tail +16c" should be changed to "tail -c +16" directly, as most systems has accept the latter. And, to skip first 16 bytes, we should use "tail -c +17" instead of "tail -c

Re: [PATCH] Fix PR78230

Hi Jeff: Thanks your review and approve, however I don't have commit right yet, can you help me to commit it :) thanks On Wed, Nov 23, 2016 at 1:04 AM, Jeff Law wrote: > > On 11/08/2016 07:43 PM, Kito Cheng wrote: >> >> gcc/testsuite/ChangeLog: >> >> 2016-11-09 Kito Cheng >> >> PR tar

Re: [www-patch] Document new -Wshadow= variants in gcc-7/changes.html

A few markup fixes on top of the committed patch that I just applied. Essentially must not be within and was missing in one case. Thanks again for providing this nice documentation! Gerald Index: changes.html === RCS file: /cv

<    1   2