Re: [patch,avr] Use avr-passes.def to register passes.

2016-10-11 Thread Denis Chertykov
2016-10-10 16:36 GMT+03:00 Georg-Johann Lay : > This is a code clean-up using the new -passes.def feature in order > to register avr target passes and to get -fdump-xxx etc. to work for such > passes. > > Ok for trunk? > > Johann > > * config/avr/avr-passes.def: New file. > * config

Re: [patch] Fix ICE on ACATS test for Aarch64 at -O

2016-10-11 Thread Eric Botcazou
Ping^2: https://gcc.gnu.org/ml/gcc-patches/2016-09/msg01781.html > 2016-09-26 Eric Botcazou > > * expmed.c (expand_shift_1): Add MAY_FAIL parameter and do not assert > that the result is non-zero if it is true. > (maybe_expand_shift): New wrapper around expand_shift_1. >

RE: [PATCH] Disable -mbranch-likely for -Os when targetting generic architecture

2016-10-11 Thread Robert Suchanek
Hi, > > I'm happy to include this. Ok to commit with this change? > > This looks like it got lost at some point. I think this is a reasonable > change for safety. > > Go ahead and commit. > > Thanks, > Matthew Committed as r240965. Regards, Robert

Re: [patch] Fix GC issue triggered by arithmetic overflow checking

2016-10-11 Thread Eric Botcazou
> I think only the calls in build_common_tree_nodes -- those are the ones > built early and that survive GC. The patch is ok if it passes testing > with that. Here's what I have installed, after bootstrap/regtesting on x86-64/Linux and SPARC/Solaris (with the upcoming overflow checking support).

[Visium] Tidy up Condition Code support

2016-10-11 Thread Eric Botcazou
This is in preparation for the overflow checking support: it untangles CCCmode and CC_NOOVmode, renaming the latter CCNZmode in the process. Tested on visium-elf, applied on the mainline. 2016-10-11 Eric Botcazou * config/visium/visium-modes.def (CC_NOOV): Rename into... (CC

Re: [PING][PATCH 1/4][Ada,DJGPP] Ada support for DJGPP

2016-10-11 Thread Arnaud Charlet
> I'd like to ping this patch. > > Last version of the patch together with Changelog entry can be found in > mailing list archive: > > https://gcc.gnu.org/ml/gcc-patches/2016-08/msg01229.html This patch isn't OK, we don't want to add such special case in s-os_lib.adb Arno

Re: [PING][PATCH 3/4][Ada,DJGPP] Ada support for DJGPP

2016-10-11 Thread Arnaud Charlet
> I'd like to ping patch > > https://gcc.gnu.org/ml/gcc-patches/2016-09/msg00164.html > > Additional comments about using ZCX_By_Default := true are in > https://gcc.gnu.org/ml/gcc-patches/2016-09/msg00845.html Well this patch doesn't inspire lots of confidence since the initial version had the

[SPARC] Tidy up Condition Code support and more

2016-10-11 Thread Eric Botcazou
This was initially in preparation for the overflow checking support and aimed at untangling CCCmode and CC_NOOVmode, but ends up doing a little more: - add TARGET_FIXED_CONDITION_CODE_REGS hook to eliminate more explicitly redundant comparisons and, on V9, to generate more movcc instructions.

Re: [PATCH] Fix PR77826

2016-10-11 Thread Richard Biener
On Mon, 10 Oct 2016, Marc Glisse wrote: > On Fri, 7 Oct 2016, Richard Biener wrote: > > > On Thu, 6 Oct 2016, Marc Glisse wrote: > > > > > On Wed, 5 Oct 2016, Richard Biener wrote: > > > > > > > > The following will fix PR77826, the issue that in match.pd matching > > > > > up two things uses o

[Ada] Remove system-linux-ppc64.ads

2016-10-11 Thread Eric Botcazou
This removes system-linux-ppc64.ads and makes system-linux-ppc.ads support both 32-bit and 64-bit modes. Tested on PowerPC/Linux and PowerPC64/Linux, applied on the mainline. 2016-10-11 Eric Botcazou Tristan Gingold * system-linux-ppc64.ads: Delete. * system-li

Re: [PATCH 1/3] Fold __builtin_str{n}{case}cmp functions (version 2)

2016-10-11 Thread Martin Liška
On 10/07/2016 12:50 PM, Richard Biener wrote: > On Fri, Oct 7, 2016 at 10:39 AM, Martin Liška wrote: >> I'm resending the patch, where I implemented all builtins mentions in subject >> in gimp-fold.c. >> >> Patch can bootstrap on ppc64le-redhat-linux and survives regression tests. >> >> Ready to b

[PATCH] Check \0-termination of string in c_getstr

2016-10-11 Thread Martin Liška
As mentioned in the email that I reply to, c_getstr should check null termination of string constants. Tests of the whole series have been running. Thanks, Martin >From b446c659e839caa5ea5f36b06ec9110fe69f6e38 Mon Sep 17 00:00:00 2001 From: marxin Date: Mon, 10 Oct 2016 12:13:12 +0200 Subject: [

[PATCH] Add a helper function: create_tmp

2016-10-11 Thread Martin Liška
Following patch is a small infrastructure enhancement in gimple-fold.c. Tests of the whole series have been running. Thanks, Martin >From cf5983472b8482734393680493293811e5400d6e Mon Sep 17 00:00:00 2001 From: marxin Date: Tue, 11 Oct 2016 11:20:33 +0200 Subject: [PATCH 2/5] Add a helper functio

[committed] Use bool as return type

2016-10-11 Thread Marek Polacek
These two routines should have used bool as the return type. Bootstrapped/regtested on x86_64-linux, applying to trunk. 2016-10-11 Marek Polacek * c-common.c (warning_candidate_p): Change the return type to bool and return true/false instead of 1/0. (vector_mode_valid_

[PATCH] Fold __builtin_str{n}{case}cmp functions (version 3)

2016-10-11 Thread Martin Liška
Changes from the previous version: 1) Handle BUILT_IN_STRNCMP with length == -1. 2) Direct gimple stmts creation and usage gsi_replace_with_seq_vops. (hope using of replace_call_with_value is fine if replacing with a cst?) 3) lhs == NULL cases are handled (Or is it fine to replace with a nop in g

[PATCH] Fold __builtin_memchr (version 3)

2016-10-11 Thread Martin Liška
On 10/07/2016 01:01 PM, Richard Biener wrote: > On Fri, Oct 7, 2016 at 10:41 AM, Martin Liška wrote: >> Resending the patch, where I implemented folding in gimple-fold.c >> >> Patch can bootstrap on ppc64le-redhat-linux and survives regression tests. > > +/* Fold a call to the str{n}{case}cmp bui

[PATCH] Test folding of str{n}{case}cmp and memchr (version 3)

2016-10-11 Thread Martin Liška
Third iteration of tests, where I added both GENERIC and GIMPLE folding tests. Martin >From ac9020c31a6f5291c896a90aae594dd564420d95 Mon Sep 17 00:00:00 2001 From: marxin Date: Tue, 16 Aug 2016 15:56:01 +0200 Subject: [PATCH 5/5] Test folding of str{n}{case}cmp and memchr gcc/testsuite/ChangeLog

[Ada] Fix wrong code for Unchecked_Conversion

2016-10-11 Thread Eric Botcazou
This fixes a wrong code regression present on the mainline, when an unsigned subtype of a signed base type is involved. Tested on x86_64-suse-linux, applied on the mainline. 2016-10-11 Eric Botcazou * gcc-interface/utils.c (type_unsigned_for_rm): New predicate. (make_type_fr

[Ada] Adjust code generated for overflow checking

2016-10-11 Thread Eric Botcazou
This generates an explicit comparison against 0, which yields slightly better code than testing directly the value. 2016-10-11 Eric Botcazou * gcc-interface/trans.c (gnat_to_gnu) : Adjust comment. : Add comment and missing guard. * gcc-interface/trans.c (build_binary_

[Ada] Improve quality of generated code for address clauses

2016-10-11 Thread Eric Botcazou
Tested on x86_64-suse-linux, applied on the mainline. 2016-10-11 Tristan Gingold * fe.h (Constant_Value): Declare. * gcc-interface/decl.c (compile_time_known_address_p): Also consider references to constants. -- Eric BotcazouIndex: gcc-interface/decl.c ==

[Ada] Fix missing debug info for variant record

2016-10-11 Thread Eric Botcazou
The problem is the early folding applied to the expressions based on the discriminant selecting the variant. Tested on x86_64-suse-linux, applied on the mainline. 2016-10-11 Pierre-Marie de Rodat * gcc-interface/utils2.c (build_binary_op): Add a NO_FOLD argument. Disable fo

[PATCH, testsuite] Fix PR77710: incorrect wildchar target triplet

2016-10-11 Thread Thomas Preudhomme
I've applied the following commit as obvious to fix builtin-sprintf-warn-4.c excess error failure on arm-none-eabi due to incorrect wildchar target triplet. ChangeLog entry is as follows: *** gcc/testsuite/ChangeLog *** 2016-10-11 Thomas Preud'homme PR testsuite/PR77710 * g

Re: [PATCH 1/3] Fold __builtin_str{n}{case}cmp functions (version 2)

2016-10-11 Thread Richard Biener
On Tue, Oct 11, 2016 at 11:26 AM, Martin Liška wrote: > On 10/07/2016 12:50 PM, Richard Biener wrote: >> On Fri, Oct 7, 2016 at 10:39 AM, Martin Liška wrote: >>> I'm resending the patch, where I implemented all builtins mentions in >>> subject >>> in gimp-fold.c. >>> >>> Patch can bootstrap on p

Re: [PATCH] Check \0-termination of string in c_getstr

2016-10-11 Thread Richard Biener
On Tue, Oct 11, 2016 at 11:27 AM, Martin Liška wrote: > As mentioned in the email that I reply to, c_getstr should check > null termination of string constants. > > Tests of the whole series have been running. Looks ok to me (if testing passes). Thanks, Richard. > Thanks, > Martin

Re: [PATCH] Add a helper function: create_tmp

2016-10-11 Thread Richard Biener
On Tue, Oct 11, 2016 at 11:28 AM, Martin Liška wrote: > Following patch is a small infrastructure enhancement > in gimple-fold.c. > > Tests of the whole series have been running. Sorry to be picky, but can you rename it to create_reg_tmp? Ok with that change. RIchard. > Thanks, > Martin

Re: [PATCH] Add a helper function: create_tmp

2016-10-11 Thread Richard Biener
On Tue, Oct 11, 2016 at 12:29 PM, Richard Biener wrote: > On Tue, Oct 11, 2016 at 11:28 AM, Martin Liška wrote: >> Following patch is a small infrastructure enhancement >> in gimple-fold.c. >> >> Tests of the whole series have been running. > > Sorry to be picky, but can you rename it to create_r

Re: Compile-time improvement for if conversion.

2016-10-11 Thread Richard Biener
On Mon, Oct 10, 2016 at 4:17 PM, Yuri Rumyantsev wrote: > Richard, > > If "fake" exit or entry block is created in dominance how we can > determine what is its the only predecessor or successor without using > a notion of loop? The caller passes in an entry and exit edge instead of a block or lo

fix -fmax-errors & notes

2016-10-11 Thread Nathan Sidwell
Hi, Jonathan & I were chatting at the cauldron about how -fmax-errors kills any notes about the final error. That's because we bail out just after emitting the final error. This patch fixes the problem by bailing out just before emitting the error or warning after that. Sure, we'll do sligh

[PATCH] More noexcept for standard mutex types and locks

2016-10-11 Thread Jonathan Wakely
These functions can all be noexcept (if we ever wanted to check the mutex is owned by the calling thread in the adopt_lock ctors we'd abort, not throw). * include/bits/std_mutex.h (mutex::native_handle) (lock_guard(mutex_type&, adopt_lock_t) (unique_lock(mutex_type&, adopt

MAINTAINERS

2016-10-11 Thread Nathan Sidwell
Update my email address nathan 2016-10-10 Nathan Sidwell * MAINTAINERS: Update email address. Index: MAINTAINERS === --- MAINTAINERS (revision 240920) +++ MAINTAINERS (working copy) @@ -86,7 +86,7 @@ nds32 port Shiva Chen n

[PATCH] Remove redundant const qualifliers from string_view

2016-10-11 Thread Jonathan Wakely
These return types cause "type qualifiers ignored on function return type" warnings with -Wsystem-headers. * include/experimental/string_view (basic_string_view::_S_compare): Remove redundant const from return type. * include/std/string_view (basic_string_view:_S_compare):

[PATCH] Enable printers and xmethods for std::__cxx11::list

2016-10-11 Thread Jonathan Wakely
This makes the python utils work for the new ABI list (they still need to work with the new string as well). * python/libstdcxx/v6/printers.py (build_libstdcxx_dictionary): Register printer for std::__cxx11::list. * python/libstdcxx/v6/xmethods.py (ListMethodsMatcher.match

[Ada] Fix various debug info issues with renaming

2016-10-11 Thread Eric Botcazou
GNAT encodings for object renamings that involve packed private types were not generated. This is because we were not using Underlying_Type to analyze types involved. This patch introduces Underlying_Type calls where necessary. It also generates GNAT encodings renamings for byte unaligned obj

Re: [PATCH][AArch64] Add spellchecking hints for -march,-mcpu,-mtune and their attributes

2016-10-11 Thread James Greenhalgh
On Fri, Oct 07, 2016 at 01:34:37PM -0700, Andrew Pinski wrote: > On Fri, Oct 7, 2016 at 7:52 AM, Kyrill Tkachov > wrote: > > Hi all, > > > > This patch uses the spellcheck API from David and Jakub [1] to implement > > hints for the > > march, mcpu and mtune options to suggest appropriate architect

[Patch, testsuite] Fix gcc.g/tree-ssa/pr59597.c failure for avr

2016-10-11 Thread Senthil Kumar Selvaraj
Hi, This patch declares loop index variable j as a 32 bit int instead of assuming ints are 32 bits. The smaller int size on the avr makes prior passes optimize away the loop exit check (j < 1000), as the constant is outside the range of a 16 bit int. Committed to trunk, after reg te

[PATCH] Simplify std::rethrow_if_nested definition

2016-10-11 Thread Jonathan Wakely
Originally this header didn't use , but we install that for freestanding builds now, so it's always available. That means we can simplify things a bit, using remove_reference, enable_if etc. This also implements the missing part of LWG 2484, so that we don't try to use dynamic_cast when the stati

[PATCH] Optimise std::list::assign(initializer_list) slightly

2016-10-11 Thread Jonathan Wakely
This is a microoptimisation to call the relevant _M_assign_dispatch function directly (because we know we have iterators), rather than calling assign() to do the dispatching. * include/bits/stl_list.h (assign(initializer_list)): Call _M_assign_dispatch directly with correct tag.

[PATCH][check_GNU_style.sh] More aggressively ignore dg-xxx directives

2016-10-11 Thread Kyrill Tkachov
Hi all, check_GNU_style.sh complains a lot about dg-* directives in the testsuite and in particular about line lengths. There's nothing we can do about the directives and sometimes they're supposed to be long, in particular the scan-assembler checks in dg-final. Currently check_GNU_style.sh ha

Re: [PATCH][check_GNU_style.sh] More aggressively ignore dg-xxx directives

2016-10-11 Thread Jakub Jelinek
On Tue, Oct 11, 2016 at 11:47:21AM +0100, Kyrill Tkachov wrote: > check_GNU_style.sh complains a lot about dg-* directives in the testsuite and > in particular about line lengths. > There's nothing we can do about the directives and sometimes they're supposed > to be long, in particular the scan-

Re: [PATCH][check_GNU_style.sh] More aggressively ignore dg-xxx directives

2016-10-11 Thread Bernd Schmidt
On 10/11/2016 12:56 PM, Jakub Jelinek wrote: On Tue, Oct 11, 2016 at 11:47:21AM +0100, Kyrill Tkachov wrote: check_GNU_style.sh complains a lot about dg-* directives in the testsuite and in particular about line lengths. There's nothing we can do about the directives and sometimes they're suppo

Re: [PATCH][check_GNU_style.sh] More aggressively ignore dg-xxx directives

2016-10-11 Thread Kyrill Tkachov
On 11/10/16 11:56, Jakub Jelinek wrote: On Tue, Oct 11, 2016 at 11:47:21AM +0100, Kyrill Tkachov wrote: check_GNU_style.sh complains a lot about dg-* directives in the testsuite and in particular about line lengths. There's nothing we can do about the directives and sometimes they're supposed

Re: PING! Re: [PATCH, Fortran] Extension: COTAN and degree-valued trig intrinsics with -fdec-math

2016-10-11 Thread Fritz Reese
On Mon, Oct 10, 2016 at 3:56 PM, Steve Kargl wrote: ... > There are a few small clean-up that can be > done. For example, > > +static gfc_expr * > +get_radians (gfc_expr *deg) > +{ > + mpfr_t tmp; ... > the tmp variable is unneeded in the above. Converting the double > precision 180.0 to mpfr_t

Re: [PATCH, PR77558] Remove RECORD_TYPE special-casing in std_canonical_va_list_type

2016-10-11 Thread Christophe Lyon
On 10 October 2016 at 11:53, Richard Biener wrote: > On Sun, Sep 25, 2016 at 11:08 AM, Tom de Vries wrote: >> Hi, >> >> this patch fixes PR77558, an ice-on-invalid-code 6/7 regression. >> >> The fix for PR71602 introduced the invalid-code test-case >> c-c++-common/va-arg-va-list-type.c: >> ... >>

Re: PING! Re: [PATCH, Fortran] Extension: COTAN and degree-valued trig intrinsics with -fdec-math

2016-10-11 Thread Markus Trippelsdorf
On 2016.10.11 at 07:26 -0400, Fritz Reese wrote: > On Mon, Oct 10, 2016 at 3:56 PM, Steve Kargl > wrote: > ... > > There are a few small clean-up that can be > > done. For example, > > > > +static gfc_expr * > > +get_radians (gfc_expr *deg) > > +{ > > + mpfr_t tmp; > ... > > the tmp variable is

[PATCH] Fix PR77931

2016-10-11 Thread Richard Biener
The following fixes PR77931. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied. Richard. 2016-10-11 Richard Biener PR debug/77931 * gimple-low.c (lower_gimple_bind): Handle arbitrary common sub-chains of BLOCK_VARS and gimple_bind_vars. Index: gcc/gimple-

[PATCH] Tiny dwarf2out bits from early LTO debug

2016-10-11 Thread Richard Biener
This merges a few more tiny pieces, one latent issue with -gsplit-dwarf and !DWARF2_ASM_LINE_DEBUG_INFO where we'd produce duplicate labels (happens for darwin and early LTO debug). I've merged a verify_die routine that helped me spotting invalid dwarf trees. Bootstrapped and tested on x86_64-un

Re: [libgo] Silence compiler error message

2016-10-11 Thread Ian Lance Taylor
On Mon, Oct 10, 2016 at 12:44 PM, Eric Botcazou wrote: > > on Solaris the configuration of the library yields an ugly: > > checking whether linker supports split/non-split linked together... cc1: > error: '-fsplit-stack' is not supported by this compiler configuration > xgcc: error: conftest1.o: N

Re: [RFC][VRP] Improve intersect_ranges

2016-10-11 Thread Richard Biener
On Tue, Oct 11, 2016 at 2:57 AM, kugan wrote: > Hi Richard, > > > On 10/10/16 20:13, Richard Biener wrote: >> >> On Sat, Oct 8, 2016 at 9:38 PM, kugan >> wrote: >>> >>> Hi Richard, >>> >>> Thanks for the review. >>> On 07/10/16 20:11, Richard Biener wrote: On Fri, Oct 7, 2016 at 12

Re: [PATCH, ARM 5/7] Add support for MOVT/MOVW to ARMv8-M Baseline

2016-10-11 Thread Thomas Preudhomme
On 10/10/16 13:35, Christophe Lyon wrote: Hi Thomas, Hi Christophe, On 13 July 2016 at 17:34, Thomas Preudhomme wrote: On Wednesday 13 July 2016 17:14:52 Christophe Lyon wrote: Hi Thomas, Hi Christophe, I'm seeing: gcc.target/arm/pr42574.c: syntax error in target selector "arm_thumb1

Re: Compile-time improvement for if conversion.

2016-10-11 Thread Yuri Rumyantsev
Richard, I implemented this by passing callback function in_region which returns true if block belongs to region. I am testing it now I attach modified patch for your quick review. Thanks. 2016-10-11 13:33 GMT+03:00 Richard Biener : > On Mon, Oct 10, 2016 at 4:17 PM, Yuri Rumyantsev wrote: >>

[C++ PATCH] RFC: implement P0386R2 - C++17 inline variables

2016-10-11 Thread Jakub Jelinek
Hi! Here is an attempt to implement C++17 inline variables. Bootstrapped/regtested on x86_64-linux and i686-linux. The main question is if the inline variables, which are vague linkage, should be !DECL_EXTERNAL or DECL_EXTERNAL DECL_NOT_REALLY_EXTERN while in the FE. In the patch, they are !DECL

Re: Compile-time improvement for if conversion.

2016-10-11 Thread Richard Biener
On Tue, Oct 11, 2016 at 3:23 PM, Yuri Rumyantsev wrote: > Richard, > > I implemented this by passing callback function in_region which > returns true if block belongs to region. > I am testing it now > > I attach modified patch for your quick review. + FOR_EACH_VEC_ELT (region, i, bb) +{ +

New option -flimit-function-alignment

2016-10-11 Thread Bernd Schmidt
Denys has submitted some patches to add more capabilities to the -falign-* options, but these still have some issues, and the original ideas seems to have been to allow for large alignments without over-aligning small functions. The following patch implements that idea by taking into account th

Re: New option -flimit-function-alignment

2016-10-11 Thread Denys Vlasenko
On 10/11/2016 04:11 PM, Bernd Schmidt wrote: Denys has submitted some patches to add more capabilities to the -falign-* options, but these still have some issues, and the original ideas seems to have been to allow for large alignments without over-aligning small functions. The following patch i

Re: [SPARC] Tidy up Condition Code support and more

2016-10-11 Thread Jose E. Marchesi
Hi Eric. +(define_insn "*plus_sltu_vis3" + [(set (match_operand:W 0 "register_operand" "=r") + (plus:W (ltu:W (match_operand 2 "icc_register_operand" "X") + (const_int 0)) + (match_operand:W 1 "arith_operand" "rI")))] + "TARGET_ARCH64 && TARG

Re: PING! Re: [PATCH, Fortran] Extension: COTAN and degree-valued trig intrinsics with -fdec-math

2016-10-11 Thread Andrew Pinski
On Tue, Oct 11, 2016 at 5:43 AM, Markus Trippelsdorf wrote: > On 2016.10.11 at 07:26 -0400, Fritz Reese wrote: >> On Mon, Oct 10, 2016 at 3:56 PM, Steve Kargl >> wrote: >> ... >> > There are a few small clean-up that can be >> > done. For example, >> > >> > +static gfc_expr * >> > +get_radians (

Re: [PATCH, PING] DWARF: process all TYPE_DECL nodes when iterating on scopes

2016-10-11 Thread Pierre-Marie de Rodat
On 09/28/2016 09:48 AM, Richard Biener wrote: Hmm, interesting approach. It might work reliably at this point of the compilation but we do actually recycle cgraph nodes. Arf, what a pity. ;-) So I wonder if given we do have ->origin / ->next_nested in the cgraph if we can simply perform a wa

[PATCH, RS6000, PR77934] mtvsrdd needs b (base register) constraint on first input

2016-10-11 Thread Aaron Sawdey
Gcc 7 trunk was generating incorrect code for spec2k6 403.gcc due to this constraint issue. OK for trunk after bootstrap/regtest passes? 2016-10-06  Aaron Sawdey   PR target/77934 * config/rs6000/vmx.md (vsx_concat_): The mtvsrdd instruction needs a base register for arg 1

gcc-patches@gcc.gnu.org

2016-10-11 Thread Bin Cheng
Hi, We missed folding (convert)(X op const) -> (convert)X op (convert)const for unsigned narrowing because of reason reported at https://gcc.gnu.org/ml/gcc/2016-07/msg00126.html This patch fixes the issue by adding new match&simplify pattern, it also adds a test case. This is the prerequisite p

[PATCH GCC]New vectorization pattern turning cond_expr into max/min and plus/minus

2016-10-11 Thread Bin Cheng
Hi, Given below test case, int foo (unsigned short a[], unsigned int x) { unsigned int i; for (i = 0; i < 1000; i++) { x = a[i]; a[i] = (unsigned short)(x >= 32768 ? x - 32768 : 0); } return x; } it now can be vectorized on AArch64, but generated assembly is way from opti

[PATCH] Split print_rtx into subroutines

2016-10-11 Thread David Malcolm
print_rtx is a ~550 line function, the bulk of which is a ~400-line switch statement, with a fair amount to #if logic. This patch simplifies things by moving the switch statement into its own subroutine, and by moving the more complicated cases into their own subroutines. No functional changes (b

Re: [PATCH] Split print_rtx into subroutines

2016-10-11 Thread Bernd Schmidt
On 10/11/2016 05:34 PM, David Malcolm wrote: +static void print_rtx_operand (const_rtx in_rtx, int idx); +static void print_rtx_operand_code_0 (const_rtx in_rtx, int idx); +static void print_rtx_operand_code_e (const_rtx in_rtx, int idx); +static void print_rtx_operand_codes_E_and_V (const_rtx i

Re: [PATCH][check_GNU_style.sh] More aggressively ignore dg-xxx directives

2016-10-11 Thread Jeff Law
On 10/11/2016 05:01 AM, Bernd Schmidt wrote: On 10/11/2016 12:56 PM, Jakub Jelinek wrote: On Tue, Oct 11, 2016 at 11:47:21AM +0100, Kyrill Tkachov wrote: check_GNU_style.sh complains a lot about dg-* directives in the testsuite and in particular about line lengths. There's nothing we can do abo

Re: [PATCH 01/16] read-md.c: Add various cleanups to ~rtx_reader

2016-10-11 Thread David Malcolm
On Wed, 2016-10-05 at 17:51 +0200, Bernd Schmidt wrote: > On 10/05/2016 06:14 PM, David Malcolm wrote: > > The selftests for the RTL frontend require supporting multiple > > reader instances being alive one after another in-process, so > > this lack of cleanup would become a leak. > > > + /* Init

Re: [PATCH][check_GNU_style.sh] More aggressively ignore dg-xxx directives

2016-10-11 Thread Kyrill Tkachov
On 11/10/16 16:13, Jeff Law wrote: On 10/11/2016 05:01 AM, Bernd Schmidt wrote: On 10/11/2016 12:56 PM, Jakub Jelinek wrote: On Tue, Oct 11, 2016 at 11:47:21AM +0100, Kyrill Tkachov wrote: check_GNU_style.sh complains a lot about dg-* directives in the testsuite and in particular about line l

Re: PING! Re: [PATCH, Fortran] Extension: COTAN and degree-valued trig intrinsics with -fdec-math

2016-10-11 Thread Jerry DeLisle
On 10/11/2016 07:37 AM, Andrew Pinski wrote: > > Looks like it was only broken for some mpfr's. That is ones which is > compiled with gcc it worked but one which comes with Ubuntu 1604 it > does not. they are exactly the same version too. > > Thanks, > Andrew Also broken on Fedora 24. Fritz,

[PATCH v2] testsuite: Use -Wno-psabi instead of pruning compiler messages

2016-10-11 Thread Segher Boessenkool
It is much nicer to avoid a warning than to manually prune it from the compiler output. This patch adds -Wno-psabi to various testcases, and removes dg-prune-output, for the testcases where x86 and/or PowerPC had those (or did warn, so the testcase failed). It also removes -w whenever there is -W

[PATCH, PING*3] DWARF: space-optimize loc. descr. for integer literals on 32-bit targets

2016-10-11 Thread Pierre-Marie de Rodat
Hello, Ping for the patch submitted at . Thanks! -- Pierre-Marie de Rodat

Re: [PATCH 09/16] Split class rtx_reader into base_rtx_reader vs rtx_reader

2016-10-11 Thread Bernd Schmidt
On 10/05/2016 06:15 PM, David Malcolm wrote: - rtx_reader_ptr->get_top_level_filename ()); + base_rtx_reader_ptr->get_top_level_filename ()); I wonder if the number of changes could be minimized by retaining the name rtx_reader for the base class, and using something more speci

Re: [PATCH v2] testsuite: Use -Wno-psabi instead of pruning compiler messages

2016-10-11 Thread Jakub Jelinek
On Tue, Oct 11, 2016 at 03:43:03PM +, Segher Boessenkool wrote: > It is much nicer to avoid a warning than to manually prune it from the > compiler output. This patch adds -Wno-psabi to various testcases, and > removes dg-prune-output, for the testcases where x86 and/or PowerPC had > those (or

Re: PING! Re: [PATCH, Fortran] Extension: COTAN and degree-valued trig intrinsics with -fdec-math

2016-10-11 Thread Aaron Sawdey
On Tue, 2016-10-11 at 07:26 -0400, Fritz Reese wrote: > On Mon, Oct 10, 2016 at 3:56 PM, Steve Kargl > wrote: > ... > > > > There are a few small clean-up that can be > > done.  For example, > > > > +static gfc_expr * > > +get_radians (gfc_expr *deg) > > +{ > > +  mpfr_t tmp; > ... > > > > the

[PATCH, alpha]: Use alpha-passes.def to register passes.

2016-10-11 Thread Uros Bizjak
2016-10-11 Uros Bizjak * config/alpha/alpha-passes.def: New file. * config/alpha/t-alpha: New file. * config/alpha/alpha-protos.h (gcc::context, rtl_opt_pass): Declare. (make_pass_handle_trap_shadows): New prototype. (make_pass_align_insns): Ditto. * config/alpha/alpha.c

Re: [PATCH,rs6000] Add built-in function support for Power9 string operations

2016-10-11 Thread Segher Boessenkool
On Mon, Oct 10, 2016 at 12:11:40PM -0600, Kelvin Nilsen wrote: > > This patch adds support for 26 new instructions that are introduced > with the Power ISA 3.0 (Power9). The instructions are lxvl, stxvl, > vcmpneb, "vcmpneb.", vcmnezb, "vcmpnezb.", vcmpneh, "vcmpneh.", vcmpnezh, > "vcmpnezh.", cm

Re: [PATCH] Remove x86 pcommit instruction

2016-10-11 Thread Andrew Senkevich
2016-10-06 1:07 GMT+03:00 H.J. Lu : > On Wed, Oct 5, 2016 at 1:42 PM, Andrew Senkevich > wrote: >> 2016-10-05 18:06 GMT+03:00 Uros Bizjak : >>> On Wed, Oct 5, 2016 at 3:47 PM, Andrew Senkevich >>> wrote: > -mpcommit > -Target Report Mask(ISA_PCOMMIT) Var(ix86_isa_flags) Save > -Suppor

Re: [PATCH] Remove x86 pcommit instruction

2016-10-11 Thread H.J. Lu
On Tue, Oct 11, 2016 at 10:04 AM, Andrew Senkevich wrote: > 2016-10-06 1:07 GMT+03:00 H.J. Lu : >> On Wed, Oct 5, 2016 at 1:42 PM, Andrew Senkevich >> wrote: >>> 2016-10-05 18:06 GMT+03:00 Uros Bizjak : On Wed, Oct 5, 2016 at 3:47 PM, Andrew Senkevich wrote: >> -mpcommit >> -Ta

Re: [PATCH], PR 77924, Fix PowerPC breakage on AIX

2016-10-11 Thread Segher Boessenkool
On Mon, Oct 10, 2016 at 04:46:53PM -0400, Michael Meissner wrote: > I accidently broke AIX with my patch on October 6th. That patch split > -mfloat128 into -mfloat128-type and -mfloat128 under PowerPC Linux. This > patch > fixes that issue. I bootstrapped it on PowerPC Linux with no regressions

Re: [PATCH, RS6000, PR77934] mtvsrdd needs b (base register) constraint on first input

2016-10-11 Thread Segher Boessenkool
On Tue, Oct 11, 2016 at 09:39:10AM -0500, Aaron Sawdey wrote: > Gcc 7 trunk was generating incorrect code for spec2k6 403.gcc due to > this constraint issue. OK for trunk after bootstrap/regtest passes? > > 2016-10-06  Aaron Sawdey   > > PR target/77934 > * config/rs6000/vmx.md (vsx_c

Re: [PATCH v2] testsuite: Use -Wno-psabi instead of pruning compiler messages

2016-10-11 Thread Segher Boessenkool
On Tue, Oct 11, 2016 at 06:11:29PM +0200, Jakub Jelinek wrote: > On Tue, Oct 11, 2016 at 03:43:03PM +, Segher Boessenkool wrote: > > It is much nicer to avoid a warning than to manually prune it from the > > compiler output. This patch adds -Wno-psabi to various testcases, and > > removes dg-p

Re: [PATCH v2] testsuite: Use -Wno-psabi instead of pruning compiler messages

2016-10-11 Thread Jakub Jelinek
On Tue, Oct 11, 2016 at 12:32:03PM -0500, Segher Boessenkool wrote: > > > --- a/gcc/testsuite/g++.dg/cpp0x/constexpr-53094-3.C > > > +++ b/gcc/testsuite/g++.dg/cpp0x/constexpr-53094-3.C > > > @@ -1,7 +1,6 @@ > > > // { dg-do compile { target c++11 } } > > > // { dg-options "" } > > > -// Ignore w

Re: PING! Re: [PATCH, Fortran] Extension: COTAN and degree-valued trig intrinsics with -fdec-math

2016-10-11 Thread Andre Vehreschild
Hi all, attached a small patch that resolves the issues at least on x86_64-linux/F23. - Andre On Tue, 11 Oct 2016 11:32:50 -0500 Aaron Sawdey wrote: > On Tue, 2016-10-11 at 07:26 -0400, Fritz Reese wrote: > > On Mon, Oct 10, 2016 at 3:56 PM, Steve Kargl > > wrote: > > ... > > > > > > There

Re: PING! Re: [PATCH, Fortran] Extension: COTAN and degree-valued trig intrinsics with -fdec-math

2016-10-11 Thread Jerry DeLisle
On 10/11/2016 09:32 AM, Aaron Sawdey wrote: > On Tue, 2016-10-11 at 07:26 -0400, Fritz Reese wrote: >> On Mon, Oct 10, 2016 at 3:56 PM, Steve Kargl ... snip ... > > I think the first part of that cleanup didn't get applied as I am > seeing this: > > ../../gcc/gcc/fortran/iresolve.c: In function âg

Re: PING! Re: [PATCH, Fortran] Extension: COTAN and degree-valued trig intrinsics with -fdec-math

2016-10-11 Thread Steve Kargl
On Tue, Oct 11, 2016 at 11:10:13AM -0700, Jerry DeLisle wrote: > > diff --git a/gcc/fortran/simplify.c b/gcc/fortran/simplify.c > index bf60f747..18135d2f 100644 > --- a/gcc/fortran/simplify.c > +++ b/gcc/fortran/simplify.c > @@ -1768,11 +1768,13 @@ degrees_f (mpfr_t x, mp_rnd_t rnd_mode) > stat

Re: PING! Re: [PATCH, Fortran] Extension: COTAN and degree-valued trig intrinsics with -fdec-math

2016-10-11 Thread Steve Kargl
On Tue, Oct 11, 2016 at 11:10:13AM -0700, Jerry DeLisle wrote: > @@ -1782,6 +1784,7 @@ radians_f (mpfr_t x, mp_rnd_t rnd_mode) > mpfr_div_d (x, x, 180.0, rnd_mode); > I forgot to point out that the above should changed to mpfr_div_ui (x, x, 180, rnd_mode); In fact, any place where

Re: [PATCH v2] testsuite: Use -Wno-psabi instead of pruning compiler messages

2016-10-11 Thread Segher Boessenkool
On Tue, Oct 11, 2016 at 07:40:24PM +0200, Jakub Jelinek wrote: > On Tue, Oct 11, 2016 at 12:32:03PM -0500, Segher Boessenkool wrote: > > > > --- a/gcc/testsuite/g++.dg/cpp0x/constexpr-53094-3.C > > > > +++ b/gcc/testsuite/g++.dg/cpp0x/constexpr-53094-3.C > > > > @@ -1,7 +1,6 @@ > > > > // { dg-do

Re: [PING][PATCH 3/4][Ada,DJGPP] Ada support for DJGPP

2016-10-11 Thread Andris Pavenis
On 10/11/2016 11:46 AM, Arnaud Charlet wrote: I'd like to ping patch https://gcc.gnu.org/ml/gcc-patches/2016-09/msg00164.html Additional comments about using ZCX_By_Default := true are in https://gcc.gnu.org/ml/gcc-patches/2016-09/msg00845.html Well this patch doesn't inspire lots of confidenc

Re: PING! Re: [PATCH, Fortran] Extension: COTAN and degree-valued trig intrinsics with -fdec-math

2016-10-11 Thread Fritz Reese
On Mon, 2016-10-11 08:43 AM, Markus Trippelsdorf wrote: > This patch breaks bootstrap: ... Sorry all!! was in a rush to get in the car this morning and made a hasty commit. Fixed for r241001 (sorry Jerry, I was a little too slow.) --- Fritz Reese

Re: PING! Re: [PATCH, Fortran] Extension: COTAN and degree-valued trig intrinsics with -fdec-math

2016-10-11 Thread Fritz Reese
On Tue, Oct 11, 2016 at 2:44 PM, Fritz Reese wrote: > On Mon, 2016-10-11 08:43 AM, Markus Trippelsdorf > wrote: >> This patch breaks bootstrap: > ... > > Sorry all!! was in a rush to get in the car this morning and made a > hasty commit. Fixed for r241001 (sorry Jerry, I was a little too > slow.

Bootstrap breakage in Fortran

2016-10-11 Thread Jerry DeLisle
There was a breakage in Fortran that has now been fixed. In case anyone runs into it. Resolved by: M gcc/fortran/ChangeLog M gcc/fortran/iresolve.c M gcc/fortran/simplify.c r241000 = 7b8ebc39f2db57dcadd8b8f22b6b7561d187c279 (refs/remotes/svn/trunk) Rela

Re: [PATCH] Implement new hook for max_align_t_align

2016-10-11 Thread Jason Merrill
/* Alignment, in bits, a C conformant malloc implementation has to provide. The HP-UX malloc implementation provides a default alignment of 8 bytes. This can be increased with mallopt. The glibc implementation also provides 8-byte alignment. Note that this isn't enough for various POSIX

Re: [PATCH] Implement new hook for max_align_t_align

2016-10-11 Thread DJ Delorie
Jason Merrill writes: > If PA malloc doesn't actually provide 16-byte alignment, this change > seems problematic; it will mean any type that wants 16-byte alignment > will silently get 8-byte alignment instead. Should such cases be calling memalign (or posix_memalign) instead of malloc?

[PATCH] Fix formatting of the -fdec-math changes

2016-10-11 Thread Jakub Jelinek
On Tue, Oct 11, 2016 at 02:47:34PM -0400, Fritz Reese wrote: > On Tue, Oct 11, 2016 at 2:44 PM, Fritz Reese wrote: > > On Mon, 2016-10-11 08:43 AM, Markus Trippelsdorf > > wrote: > >> This patch breaks bootstrap: > > ... > > > > Sorry all!! was in a rush to get in the car this morning and made a

Re: [PATCH][check_GNU_style.sh] More aggressively ignore dg-xxx directives

2016-10-11 Thread Martin Sebor
On 10/11/2016 09:22 AM, Kyrill Tkachov wrote: On 11/10/16 16:13, Jeff Law wrote: On 10/11/2016 05:01 AM, Bernd Schmidt wrote: On 10/11/2016 12:56 PM, Jakub Jelinek wrote: On Tue, Oct 11, 2016 at 11:47:21AM +0100, Kyrill Tkachov wrote: check_GNU_style.sh complains a lot about dg-* directives

Re: [PATCH] Fix formatting of the -fdec-math changes

2016-10-11 Thread Fritz Reese
On Tue, Oct 11, 2016 at 3:00 PM, Jakub Jelinek wrote: > On Tue, Oct 11, 2016 at 02:47:34PM -0400, Fritz Reese wrote: >> On Tue, Oct 11, 2016 at 2:44 PM, Fritz Reese wrote: >> > On Mon, 2016-10-11 08:43 AM, Markus Trippelsdorf >> > wrote: >> >> This patch breaks bootstrap: >> > ... >> > >> > Sor

Re: [PATCH][check_GNU_style.sh] More aggressively ignore dg-xxx directives

2016-10-11 Thread Jakub Jelinek
On Tue, Oct 11, 2016 at 01:11:04PM -0600, Martin Sebor wrote: > Also, the pattern that starts with "/\+\+\+" looks like it's missing > the ^ anchor. Presumably it should be "/^\+\+\+ \/testsuite\//". No, it will be almost never +++ /testsuite/ There needs to be .* in between "+++ " and "/testsuit

Re: [PATCH] Fix formatting of the -fdec-math changes

2016-10-11 Thread Jakub Jelinek
On Tue, Oct 11, 2016 at 03:15:24PM -0400, Fritz Reese wrote: > > --- gcc/fortran/simplify.c.jj 2016-10-11 20:51:01.767308095 +0200 > > +++ gcc/fortran/simplify.c 2016-10-11 20:56:27.468199551 +0200 > > @@ -1717,27 +1717,24 @@ simplify_trig_call (gfc_expr *icall) > > > >/* The actual simp

Re: [PATCH v2] aarch64: Add split-stack initial support

2016-10-11 Thread Adhemerval Zanella
On 07/10/2016 05:28, Kyrill Tkachov wrote: > Hi Adhemerval, > > CC'ing the aarch64 maintainers/reviewers. > I have some comments inline, mostly about the GCC coding conventions. Thanks for the review. >> diff --git a/gcc/config/aarch64/aarch64.c b/gcc/config/aarch64/aarch64.c >> index df6514d.

[Ada] Set Backend_Overflow_Checks to True everywhere

2016-10-11 Thread Eric Botcazou
It's not clear why this was set to False in some configuration files. Applied on the mainline. 2016-10-11 Eric Botcazou * system-linux-armeb.ads (Backend_Overflow_Checks): Change to True. * system-linux-mips.ads (Backend_Overflow_Checks): Likewise. * system-linux-mips

Re: [PATCH] Implement new hook for max_align_t_align

2016-10-11 Thread John David Anglin
On 2016-10-11 2:50 PM, Jason Merrill wrote: /* Alignment, in bits, a C conformant malloc implementation has to provide. The HP-UX malloc implementation provides a default alignment of 8 bytes. This can be increased with mallopt. The glibc implementation also provides 8-byte alignment

Re: fix -fmax-errors & notes

2016-10-11 Thread David Malcolm
On Tue, 2016-10-11 at 06:34 -0400, Nathan Sidwell wrote: > Hi, > Jonathan & I were chatting at the cauldron about how -fmax-errors > kills any > notes about the final error. That's because we bail out just after > emitting the > final error. This patch fixes the problem by bailing out just befo

Re: [PATCH] Fix formatting of the -fdec-math changes

2016-10-11 Thread Steve Kargl
On Tue, Oct 11, 2016 at 09:00:54PM +0200, Jakub Jelinek wrote: > On Tue, Oct 11, 2016 at 02:47:34PM -0400, Fritz Reese wrote: > > On Tue, Oct 11, 2016 at 2:44 PM, Fritz Reese wrote: > > > On Mon, 2016-10-11 08:43 AM, Markus Trippelsdorf > > > wrote: > > >> This patch breaks bootstrap: > > > ...

  1   2   >