Fortran, committed: ICE on missing parameter value for initialisation (segfault) (pr 66107)

2016-09-22 Thread Louis Krupp
Fixed in revision 240341.

Re: [PATCH] Fix various minor gimple-ssa-sprintf.c issues

2016-09-22 Thread Jakub Jelinek
On Wed, Sep 21, 2016 at 06:38:54PM -0600, Martin Sebor wrote: > On 09/21/2016 09:09 AM, Jakub Jelinek wrote: > >When looking at PR77676, I've noticed various small formatting etc. > >issues, like not using is_gimple_* APIs where we have them, not using > >gimple_call_builtin_p/gimple_call_fndecl (t

Re: [Patch, avr] Provide correct LD offset bound in avr_address_cost

2016-09-22 Thread Denis Chertykov
2016-09-22 7:52 GMT+03:00 Senthil Kumar Selvaraj : > Hi, > > This patch fixes cost computation in avr_address_cost - instead of the > hardcoded 61, it uses the already existing MAX_LD_OFFSET(mode) macro. > > This showed up when investigating a code size regression in the ivopts > pass. That

Re: [PATCH] Fix ICE with inlining and #pragma omp simd (PR fortran/77665)

2016-09-22 Thread Richard Biener
On Wed, 21 Sep 2016, Alexander Monakov wrote: > On Wed, 21 Sep 2016, Jakub Jelinek wrote: > > The simduid pass uses the cfun->has_simduid_loops flag to determine if it > > needs to clean up any left-over GOMP_SIMD_* internal functions. > > During inlining, we set the flag if we inline some loop wi

Re: [PATCH] Fix PR tree-optimization/77550

2016-09-22 Thread Richard Biener
On Wed, 21 Sep 2016, Bernd Edlinger wrote: > On 09/21/16 21:57, Christophe Lyon wrote: > > Hi, > > > > The new testcase pr77550.C fails on arm: > > /testsuite/g++.dg/pr77550.C:39:43: error: 'operator new' takes type > > 'size_t' ('unsigned int') as first parameter [-fpermissive] > > compiler exite

[PATCH] [RTEMS] Always use atomic builtins for libstdc++

2016-09-22 Thread Sebastian Huber
libstdc++-v3/ * config/cpu/m68k/atomicity.h: Adjust comment. * acinclude.m4 (GLIBCXX_ENABLE_ATOMIC_BUILTINS): Honor explicit atomicity_dir setup via configure.host. * configure.host (rtems-*): Set atomicity_dir. * configure: Regenerate. --- libstdc++-v3/acin

RE: [PATCH] Fix PR tree-optimization/77654

2016-09-22 Thread Richard Biener
On Wed, 21 Sep 2016, Doug Gilmore wrote: > > From: Richard Biener [rguent...@suse.de] > > Sent: Wednesday, September 21, 2016 12:48 AM > > To: Doug Gilmore > > Cc: gcc-patches@gcc.gnu.org; rgue...@gcc.gnu.org > > Subject: RE: [PATCH] Fix PR tree-optimization/77654 > > > > On Tue, 20 Sep 2016, Dou

[Patch] Fix variant::operator= on references

2016-09-22 Thread Tim Shen
Hi, this patch fixes the following compilation failure: #include int main() { float f1 = 1.0f, f2 = 2.0f; std::variant v1(f1); v1 = f2; // #1 } The bug is caused by a misuse of __storage. I also examined other __storage usage, they all seem appropriate. Tested on x86_64-linux-gnu.

Re: [Patch] Fix variant::operator= on references

2016-09-22 Thread Tim Shen
On Thu, Sep 22, 2016 at 12:43 AM, Tim Shen wrote: > Hi, this patch fixes the following compilation failure: For the record, the bug is found by Ville. Thank you Ville! :) -- Regards, Tim Shen

Re: [PATCH] Fix various minor gimple-ssa-sprintf.c issues

2016-09-22 Thread Marek Polacek
On Thu, Sep 22, 2016 at 09:24:11AM +0200, Jakub Jelinek wrote: > On Wed, Sep 21, 2016 at 06:38:54PM -0600, Martin Sebor wrote: > > On 09/21/2016 09:09 AM, Jakub Jelinek wrote: > > >When looking at PR77676, I've noticed various small formatting etc. > > >issues, like not using is_gimple_* APIs where

Re: [Patch, fortran] Clean up of error recovery in DTIO procedures

2016-09-22 Thread Paul Richard Thomas
Committed as revision 240342. Paul On 21 September 2016 at 12:18, Paul Richard Thomas wrote: > Dear All, > > Please find attached a patch to clean up the various issues with > errors in DTIO procedures. The tests were all provided by Gerhard > Steinmetz for which thanks are due. > > I intend to

Re: [PATCH] [RTEMS] Always use atomic builtins for libstdc++

2016-09-22 Thread Andreas Schwab
On Sep 22 2016, Sebastian Huber wrote: > diff --git a/libstdc++-v3/acinclude.m4 b/libstdc++-v3/acinclude.m4 > index 6d897be..3256ce4 100644 > --- a/libstdc++-v3/acinclude.m4 > +++ b/libstdc++-v3/acinclude.m4 > @@ -3490,9 +3490,10 @@ EOF >AC_LANG_RESTORE > ># Set atomicity_dir to builtin

Re: [PATCH] libstdc++/77641 fix std::variant for literal types

2016-09-22 Thread Jonathan Wakely
On 22/09/16 09:45 +0300, Ville Voutilainen wrote: This problem is not introduced by the latest patch, but it's something that we should look at anyway. There's been recent discussion about what assignments do with variants that hold references. Consider this: #include int main() { float f1 =

Re: [PATCH] libstdc++/77641 fix std::variant for literal types

2016-09-22 Thread Jonathan Wakely
On 22/09/16 09:37 +0100, Jonathan Wakely wrote: On 22/09/16 09:45 +0300, Ville Voutilainen wrote: This problem is not introduced by the latest patch, but it's something that we should look at anyway. There's been recent discussion about what assignments do with variants that hold references. Con

Re: [Patch] Fix variant::operator= on references

2016-09-22 Thread Jonathan Wakely
On 22/09/16 00:43 -0700, Tim Shen wrote: Hi, this patch fixes the following compilation failure: #include int main() { float f1 = 1.0f, f2 = 2.0f; std::variant v1(f1); v1 = f2; // #1 } The bug is caused by a misuse of __storage. I also examined other __storage usage, they all seem app

Re: [PATCH] [RTEMS] Always use atomic builtins for libstdc++

2016-09-22 Thread Jonathan Wakely
On 22/09/16 09:41 +0200, Sebastian Huber wrote: libstdc++-v3/ * config/cpu/m68k/atomicity.h: Adjust comment. * acinclude.m4 (GLIBCXX_ENABLE_ATOMIC_BUILTINS): Honor explicit atomicity_dir setup via configure.host. * configure.host (rtems-*): Set atomicity_dir.

[PATCH v2] [RTEMS] Always use atomic builtins for libstdc++

2016-09-22 Thread Sebastian Huber
v2: Fix shell script part since shell grouping is expressed by { }. libstdc++-v3/ * config/cpu/m68k/atomicity.h: Adjust comment. * acinclude.m4 (GLIBCXX_ENABLE_ATOMIC_BUILTINS): Honor explicit atomicity_dir setup via configure.host. * configure.host (rtems-*): Set a

Re: [PATCH] [RTEMS] Always use atomic builtins for libstdc++

2016-09-22 Thread Sebastian Huber
On 22/09/16 10:47, Jonathan Wakely wrote: On 22/09/16 09:41 +0200, Sebastian Huber wrote: libstdc++-v3/ * config/cpu/m68k/atomicity.h: Adjust comment. * acinclude.m4 (GLIBCXX_ENABLE_ATOMIC_BUILTINS): Honor explicit atomicity_dir setup via configure.host. * configure.host (rtems

Re: [Patch] Fix variant::operator= on references

2016-09-22 Thread Tim Shen
On Thu, Sep 22, 2016 at 1:39 AM, Jonathan Wakely wrote: > Please qualify std::forward here. Done. When writing the initial version, I was trying to save as much qualifications as possible (as long as the semantic doesn't change) for readability, but that might not be a good idea. > > OK for trun

Re: [PATCH] [RTEMS] Always use atomic builtins for libstdc++

2016-09-22 Thread Jonathan Wakely
On 22/09/16 09:47 +0100, Jonathan Wakely wrote: On 22/09/16 09:41 +0200, Sebastian Huber wrote: libstdc++-v3/ * config/cpu/m68k/atomicity.h: Adjust comment. * acinclude.m4 (GLIBCXX_ENABLE_ATOMIC_BUILTINS): Honor explicit atomicity_dir setup via configure.host. * c

Re: [v3 PATCH] PR libstdc++/77288 and the newest proposed resolution for LWG 2756

2016-09-22 Thread Christophe Lyon
Hi, On 21 September 2016 at 21:42, Ville Voutilainen wrote: > On 21 September 2016 at 12:31, Jonathan Wakely wrote: >> On 06/09/16 09:00 +0300, Ville Voutilainen wrote: >>> >>>PR libstdc++/77288 >>>* include/std/optional (__is_optional_impl, __is_optional): Remove. >>>(__converts_fr

Re: [C++ PATCH] Aligned new option handling fixes (PR c++/77651)

2016-09-22 Thread Christophe Lyon
Hi, On 21 September 2016 at 17:03, Jason Merrill wrote: > OK. > > On Wed, Sep 21, 2016 at 10:46 AM, Jakub Jelinek wrote: >> Hi! >> >> The following patch fixes some ICEs which were because of missing >> RejectNegative for the *aligned-new= options - they have their "negative" >> values as the o

Re: [gofrontend-dev] Go patch committed: Avoid warning by using a local var for std::ofstream

2016-09-22 Thread Torvald Riegel
On Wed, 2016-09-21 at 16:56 +0200, Florian Weimer wrote: > Torvald, would it be possible to align mutexes internally on hppa, to > avoid the 16-byte alignment of the entire struct (that is, store a > pointer to the actual mutex object, which points to a sub-region of > the struct which is suitably

Re: [PATCH] - improve sprintf buffer overflow detection (middle-end/49905)

2016-09-22 Thread Rainer Orth
Hi Martin, >> Another nit, if I may: FWIW I'm not in love with the wording of the >> messages. Sorry to bikeshed, but how about: >> warning: buffer overflow will occur when writing terminating NUL >> and: >> note: formatted output of 2 bytes into a destination of size 1 >> or somesuch. > > I

Re: [v3 PATCH] PR libstdc++/77288 and the newest proposed resolution for LWG 2756

2016-09-22 Thread Ville Voutilainen
On 22 September 2016 at 11:55, Christophe Lyon wrote: > The new test 77288.cc fails on old arm targets (armv5t): > /aci-gcc-fsf/sources/gcc-fsf/gccsrc/libstdc++-v3/testsuite/20_util/optional/77288.cc: > In function 'void test01()': > /aci-gcc-fsf/sources/gcc-fsf/gccsrc/libstdc++-v3/testsuite/20_ut

Re: [PATCH v2] [RTEMS] Always use atomic builtins for libstdc++

2016-09-22 Thread Andreas Schwab
On Sep 22 2016, Sebastian Huber wrote: > diff --git a/libstdc++-v3/acinclude.m4 b/libstdc++-v3/acinclude.m4 > index 6d897be..d7db435 100644 > --- a/libstdc++-v3/acinclude.m4 > +++ b/libstdc++-v3/acinclude.m4 > @@ -3490,9 +3490,10 @@ EOF >AC_LANG_RESTORE > ># Set atomicity_dir to builtin

Re: [RFC] Extend ipa-bitwise-cp with pointer alignment propagation

2016-09-22 Thread Richard Biener
On Wed, Sep 21, 2016 at 6:44 PM, Prathamesh Kulkarni wrote: > Hi, > The attached patch tries to extend ipa bits propagation to handle > pointer alignment propagation. > The patch just disables ipa-cp-alignment pass, I suppose we want to > eventually remove it ? > > Bootstrap+tested on x86_64-unkno

Re: [RFC] Extend ipa-bitwise-cp with pointer alignment propagation

2016-09-22 Thread Richard Biener
On Thu, Sep 22, 2016 at 11:21 AM, Richard Biener wrote: > On Wed, Sep 21, 2016 at 6:44 PM, Prathamesh Kulkarni > wrote: >> Hi, >> The attached patch tries to extend ipa bits propagation to handle >> pointer alignment propagation. >> The patch just disables ipa-cp-alignment pass, I suppose we want

Re: [v3 PATCH] PR libstdc++/77288 and the newest proposed resolution for LWG 2756

2016-09-22 Thread Christophe Lyon
On 22 September 2016 at 11:05, Ville Voutilainen wrote: > On 22 September 2016 at 11:55, Christophe Lyon > wrote: >> The new test 77288.cc fails on old arm targets (armv5t): >> /aci-gcc-fsf/sources/gcc-fsf/gccsrc/libstdc++-v3/testsuite/20_util/optional/77288.cc: >> In function 'void test01()': >>

Re: [v3 PATCH] PR libstdc++/77288 and the newest proposed resolution for LWG 2756

2016-09-22 Thread Ville Voutilainen
On 22 September 2016 at 12:37, Christophe Lyon wrote: >> Does the attached patch fix the problem? > > Yes, thanks! Here be the changelog. Jonathan, ok for trunk? Patch attached again for convenience. 2016-09-22 Ville Voutilainen Fix tests on old arm platforms for optional. * testsuit

Re: [PATCH GCC][v2]Simplify alias check code generation in vectorizer

2016-09-22 Thread Bin.Cheng
On Wed, Sep 21, 2016 at 3:01 PM, Richard Biener wrote: > On Tue, Sep 20, 2016 at 5:25 PM, Bin Cheng wrote: >> Hi, >> I originally posted a patch improving code generation for alias check in >> vectorizer at https://gcc.gnu.org/ml/gcc-patches/2016-06/msg00929.html. >> Here it's the 2nd version

Re: [Patch] Fix variant::operator= on references

2016-09-22 Thread Jonathan Wakely
On 22/09/16 01:49 -0700, Tim Shen wrote: Done. When writing the initial version, I was trying to save as much qualifications as possible (as long as the semantic doesn't change) for readability, but that might not be a good idea. It does change the semantics, as forward<_Tp>(__tp) can find anot

Re: [Patch] Fix variant::operator= on references

2016-09-22 Thread Ville Voutilainen
On 22 September 2016 at 13:03, Jonathan Wakely wrote: > On 22/09/16 01:49 -0700, Tim Shen wrote: >> >> Done. When writing the initial version, I was trying to save as much >> qualifications as possible (as long as the semantic doesn't change) >> for readability, but that might not be a good idea.

Re: [PATCH] libstdc++/77641 fix std::variant for literal types

2016-09-22 Thread Jonathan Wakely
On 21/09/16 20:23 -0700, Tim Shen wrote: On Wed, Sep 21, 2016 at 1:52 AM, Jonathan Wakely wrote: THanks, OK for trunk. Committed. This fixes the pretty printer. Committed to trunk. commit 6b869af56fa80da5b746390ce5616ebebcc0bd5d Author: redi Date: Thu Sep 22 10:06:41 2016 + Upd

Re: [PATCH GCC][v2]Simplify alias check code generation in vectorizer

2016-09-22 Thread Richard Biener
On Thu, Sep 22, 2016 at 11:43 AM, Bin.Cheng wrote: > On Wed, Sep 21, 2016 at 3:01 PM, Richard Biener > wrote: >> On Tue, Sep 20, 2016 at 5:25 PM, Bin Cheng wrote: >>> Hi, >>> I originally posted a patch improving code generation for alias check in >>> vectorizer at https://gcc.gnu.org/ml/gcc-pa

Re: [v3 PATCH] PR libstdc++/77288 and the newest proposed resolution for LWG 2756

2016-09-22 Thread Jonathan Wakely
On 22/09/16 12:41 +0300, Ville Voutilainen wrote: On 22 September 2016 at 12:37, Christophe Lyon wrote: Does the attached patch fix the problem? Yes, thanks! Here be the changelog. Jonathan, ok for trunk? Patch attached again for convenience. OK, thanks. (Somebody should fix PR58938 so e

Re: [PATCH] [RTEMS] Always use atomic builtins for libstdc++

2016-09-22 Thread Jonathan Wakely
On 22/09/16 10:49 +0200, Sebastian Huber wrote: On 22/09/16 10:47, Jonathan Wakely wrote: On 22/09/16 09:41 +0200, Sebastian Huber wrote: libstdc++-v3/ * config/cpu/m68k/atomicity.h: Adjust comment. * acinclude.m4 (GLIBCXX_ENABLE_ATOMIC_BUILTINS): Honor explicit atomicity_dir setup v

Re: [Patch] Fix variant::operator= on references

2016-09-22 Thread Tim Shen
On Thu, Sep 22, 2016 at 3:03 AM, Jonathan Wakely wrote: > On 22/09/16 01:49 -0700, Tim Shen wrote: >> >> Done. When writing the initial version, I was trying to save as much >> qualifications as possible (as long as the semantic doesn't change) >> for readability, but that might not be a good idea

[PATCH] Fix LTO with Java some more

2016-09-22 Thread Richard Biener
Ok, I know... (I'll eventually backport this and the earlier change) Thus, committed as obvious. Richard. 2016-09-22 Richard Biener java/ * class.c (push_super_field): Set DECL_CONTEXT. Index: gcc/java/class.c ===

Re: [Patch] Fix variant::operator= on references

2016-09-22 Thread Tim Shen
On Thu, Sep 22, 2016 at 3:36 AM, Tim Shen wrote: > Then my question is, what about type traits uses like > is_copy_constructible? I have seen non-qualified uses in std::any and > std::optional and other places. Should all of them be qualified? Ah never mind, I realized that *usually* a type trait

Re: [PATCH] [RTEMS] Always use atomic builtins for libstdc++

2016-09-22 Thread Jonathan Wakely
On 22/09/16 11:28 +0100, Jonathan Wakely wrote: On 22/09/16 10:49 +0200, Sebastian Huber wrote: On 22/09/16 10:47, Jonathan Wakely wrote: On 22/09/16 09:41 +0200, Sebastian Huber wrote: libstdc++-v3/ * config/cpu/m68k/atomicity.h: Adjust comment. * acinclude.m4 (GLIBCXX_ENABLE_ATOMIC_BUI

Re: [Patch] Fix variant::operator= on references

2016-09-22 Thread Jonathan Wakely
On 22/09/16 03:40 -0700, Tim Shen wrote: On Thu, Sep 22, 2016 at 3:36 AM, Tim Shen wrote: Then my question is, what about type traits uses like is_copy_constructible? I have seen non-qualified uses in std::any and std::optional and other places. Should all of them be qualified? Ah never mind,

Re: [v3 PATCH] PR libstdc++/77288 and the newest proposed resolution for LWG 2756

2016-09-22 Thread Jonathan Wakely
On 22/09/16 11:16 +0100, Jonathan Wakely wrote: (Somebody should fix PR58938 so exception_ptr is portable). Christophe, would you be able to test this patch? It uses a single global mutex for exception_ptr objects, which doesn't scale well but that probably isn't a problem for processors witho

[PATCH] Fix PR ipa/77653

2016-09-22 Thread Martin Liška
Hi. After some investigation, it shows that IPA ICF merges a pair of variables where for just one them address matters. Which is obvious error, fixed in attached patch. Patch can bootstrap on ppc64le-redhat-linux and survives regression tests. Ready to be installed? Martin >From d16301adc382a1c

Correct module change introduced by DTIO patch.

2016-09-22 Thread Paul Richard Thomas
Dear All, This patch has just been committed to trunk as r240349, following an OK from Andre on #gfortran. This was urgently needed since the original DTIO patch, committed on 2016-31-08, added two extra pairs of parentheses, which are always empty, to the intrinsic operator list in module files.

Re: [PATCH] Fix PR ipa/77653

2016-09-22 Thread Richard Biener
On Thu, Sep 22, 2016 at 1:18 PM, Martin Liška wrote: > Hi. > > After some investigation, it shows that IPA ICF merges a pair of variables > where > for just one them address matters. Which is obvious error, fixed in attached > patch. > > Patch can bootstrap on ppc64le-redhat-linux and survives r

Re: Make regcprop to eliminate noop moves better

2016-09-22 Thread Jan Hubicka
> > while working on the GCN port I ended up with many redundant register copies > > of the form > > mov reg, exec > > do something > > mov reg, exec > > do something > > ... > > these copies are generated by LRA because exec is small register class and > > needs a lot of reloading (it could b

Re: [RFC] Extend ipa-bitwise-cp with pointer alignment propagation

2016-09-22 Thread Jan Hubicka
> Hi, > The attached patch tries to extend ipa bits propagation to handle > pointer alignment propagation. > The patch just disables ipa-cp-alignment pass, I suppose we want to > eventually remove it ? Yes, can you please verify that alignments it computes are monotonously worse than those your ne

[PATCH] Disable sim build for ARC in top-level configure.ac

2016-09-22 Thread Anton Kolesov
Hi, This disables "sim" build for ARC, otherwise it is required to pass --disable-sim to top-level configure. Anton 0001-Disable-sim-builds-for-ARC-in-top-level-configure.ac.patch Description: 0001-Disable-sim-builds-for-ARC-in-top-level-configure.ac.patch

[PATCH] Fix PR77677

2016-09-22 Thread Richard Biener
This avoids some more TREE_OVERFLOWs in the IL (which now confuses IPA VRP). Bootstrapped and tested on x86_64-unknown-linux-gnu, applied to trunk. Richard. 2016-09-22 Richard Biener PR middle-end/77677 * gimple-match-head.c (gimple_resimplify1): Drop TREE_OVERFLOW f

[PATCH] Fix PR77678

2016-09-22 Thread Richard Biener
This fixes an ice-on-invalid for fortran. Bootstrapped/tested on x86_64-unknown-linux-gnu, applied to trunk. Richard. 2016-09-22 Richard Biener PR middle-end/77678 * expr.c (expand_expr_real_1): Guard array access against negative offset. Index: gcc/expr.c =

[PATCH] Fix PR77697

2016-09-22 Thread Richard Biener
This fixes PR77697, an ice-on-invalid for Fortran (varasm later errors). Bootstrapped and tested on x86_64-unknown-linux-gnu, applied to trunk. Richard. 2016-09-22 Richard Biener PR middle-end/77697 * gimple-fold.c (fold_array_ctor_reference): Turn asserts into fold

Re: [PATCH] - improve sprintf buffer overflow detection (middle-end/49905)

2016-09-22 Thread Rainer Orth
Hi Martin, > your patch broke bootstrap with MPFR 2.4.2, which is still the > recommended (or perhaps minimal) version according to install.texi: [...] > The following patch (together with your other one to fix ILP32 targets) > allows a sparc-sun-solaris2.12 bootstrap to continue. I'm going to >

Backport fix for PR 65210 to gcc-5-branch

2016-09-22 Thread Senthil Kumar Selvaraj
Hi, Is it ok to backport PR 65210 to gcc-5-branch? The patch is already in 6.x and trunk. Regards Senthil gcc/ChangeLog 2016-09-22 Senthil Kumar Selvaraj Backport from trunk r227496 PR target/65210 * config/avr/avr.c (avr_eval_addr_attrib): Look for io_low

[C++ Patch] PR 71979

2016-09-22 Thread Paolo Carlini
Hi, in this ICE on invalid [5/6/7] regression the gcc_assert in build_base_path is triggered during error recovery when lookup_base returns NULL_TREE (makes sense because B is looked up as base of A!). It seems to me that we can simply allow for this case in the assertion and be done with the

[PATCH] Improve SCCVN with devirtualization to pure/const calls

2016-09-22 Thread Richard Biener
Not because it might be terribly important but the recent change triggered a latent(?) issue on AIX which broke bootstrap. Let's try if another change mitigates that. The change basically allows devirt-to-const/pure to be taken into account during the value-numbering rather than only in followup

Re: [C++ PATCH] Aligned new option handling fixes (PR c++/77651)

2016-09-22 Thread Jason Merrill
On Thu, Sep 22, 2016 at 4:58 AM, Christophe Lyon wrote: > This new test (aligned-new6.C) fails on arm/aarch64 bare-metal targets > (using newlib): > arm-none-eabi/./libstdc++-v3/src/.libs/libstdc++.a(new_opa.o): In > function `operator new(unsigned int, std::align_val_t)': > /gccsrc/libstdc++-v3/l

Re: [C++ Patch] PR 71979

2016-09-22 Thread Jason Merrill
OK. On Thu, Sep 22, 2016 at 8:53 AM, Paolo Carlini wrote: > Hi, > > in this ICE on invalid [5/6/7] regression the gcc_assert in build_base_path > is triggered during error recovery when lookup_base returns NULL_TREE (makes > sense because B is looked up as base of A!). It seems to me that we can

Re: [PATCH] Fix PR ipa/77653

2016-09-22 Thread David Edelsohn
@@ -,13 +2221,11 @@ sem_variable::merge (sem_item *alias_item) } /* We can not merge if address comparsion metters. */ - if (original_address_matters && alias_address_matters - && flag_merge_constants < 2) + if (alias_address_matters && flag_merge_constants < 2) { i

[PATCH] Increase lto-min-partition

2016-09-22 Thread Wilco Dijkstra
Increase the lto-min-partition size to 5 to reduce the number of partitions. See eg. https://gcc.gnu.org/ml/gcc-patches/2016-04/msg00235.html for a concise explanation why 1 is too small for modern CPU/memory size. Additionally, larger values increase optimization opportunities and reduce

Re: [PATCH 0/4] Properly handle GCC target("march=") (PR71652)

2016-09-22 Thread jh
OK for patches 1-4. Honza Dne 2016-08-12 14:15, Martin Liška napsal: PING^1 Hello. Following small patch set targets $subject, where we ICE if someone uses #pragma GCC target ("arch=generic"). My attempt is to not to create a new target optimization node in case of a wrong value of march str

Re: [PATCH] Fix PR64078

2016-09-22 Thread Bernd Edlinger
On 09/19/16 23:27, Jeff Law wrote: > On 09/19/2016 03:08 PM, Bernd Edlinger wrote: >>> >>> Would it work to break this up into distinct tests, exit()-ing from each >>> function rather than returning back to main? >>> >> >> Yes. I think how this test is designed, each function must be inlined, >> o

Re: [v3 PATCH] PR libstdc++/77288 and the newest proposed resolution for LWG 2756

2016-09-22 Thread Jonathan Wakely
On 22/09/16 12:15 +0100, Jonathan Wakely wrote: On 22/09/16 11:16 +0100, Jonathan Wakely wrote: (Somebody should fix PR58938 so exception_ptr is portable). Christophe, would you be able to test this patch? It uses a single global mutex for exception_ptr objects, which doesn't scale well but t

[PATCH][RFC][regrename][sel-sched] Fix arm bootstrap

2016-09-22 Thread Kyrill Tkachov
Hi all, In the the interest of fixing arm bootstrap here are the two blocking issues and the changes proposed for them. I'm not familiar enough with regrename or sel-sched to make a call on whether these are right or not, I just want to keep the ball rolling so we can fix arm bootstrap. These ch

Re: [PATCH v2] [RTEMS] Always use atomic builtins for libstdc++

2016-09-22 Thread Sebastian Huber
On 22/09/16 15:25, Joel Sherrill wrote: /The target pattern in the commit message doesn't look right. It should be *-*-rtems* I think. It should be ok since host_os is used: # It uses the following shell variables as set by config.guess: # hostThe configuration host (full CPU

Re: [PATCH] Increase lto-min-partition

2016-09-22 Thread Richard Biener
On Thu, Sep 22, 2016 at 3:13 PM, Wilco Dijkstra wrote: > Increase the lto-min-partition size to 5 to reduce the number of > partitions. > See eg. https://gcc.gnu.org/ml/gcc-patches/2016-04/msg00235.html for a concise > explanation why 1 is too small for modern CPU/memory size. Additional

[PATCH, 1/7] Move memory model declarations in memmodel.h

2016-09-22 Thread Thomas Preudhomme
Hi, This patch is part of a patch series to add support for ARMv8-M[1] to GCC. This specific patch moves memory model declarations in memmodel.h. Currently, is_mm_* memory model related functions are declared in tree.h which prevents using them in constraints machine description files. This p

[PATCH, ARM 2/7] Adapt atomic and exclusive load and store to ARMv8-M Baseline

2016-09-22 Thread Thomas Preudhomme
Hi, This patch is part of a patch series to add support for atomic operations on ARMv8-M Baseline targets in GCC. This specific patch adapts atomic and exclusive load and store patterns to the constraints of ARMv8-M Baseline. It consists of two sets of changes: - adding non predicated output

Re: [PATCH] Increase lto-min-partition

2016-09-22 Thread Markus Trippelsdorf
On 2016.09.22 at 15:36 +0200, Richard Biener wrote: > On Thu, Sep 22, 2016 at 3:13 PM, Wilco Dijkstra > wrote: > > Increase the lto-min-partition size to 5 to reduce the number of > > partitions. > > See eg. https://gcc.gnu.org/ml/gcc-patches/2016-04/msg00235.html for a > > concise > > expl

[PATCH, ARM 3/7] Refactor atomic compare_and_swap to make it fit for ARMv8-M Baseline

2016-09-22 Thread Thomas Preudhomme
Hi, This patch is part of a patch series to add support for atomic operations on ARMv8-M Baseline targets in GCC. This specific patch refactors the expander and splitter for atomics to make the logic work with ARMv8-M Baseline which has limitation of Thumb-1 in terms of CC flag setting and dif

[PATCH, ARM 4/7] Adapt atomic compare and swap to ARMv8-M Baseline

2016-09-22 Thread Thomas Preudhomme
Hi, This patch is part of a patch series to add support for atomic operations on ARMv8-M Baseline targets in GCC. This specific patch makes the necessary change for compare and swap to work for ARMv8-M Baseline, doubleword integers excepted. Namely, it adds Thumb-1 specific constraints to comp

[PATCH, ARM 5/7] Adapt other atomic operations to ARMv8-M Baseline

2016-09-22 Thread Thomas Preudhomme
Hi, This patch is part of a patch series to add support for atomic operations on ARMv8-M Baseline targets in GCC. This specific patch adds support for remaining atomic operations (exchange, addition, substraction, bitwise AND, OR, XOR and NAND to ARMv8-M Baseline, doubleword integers excepted.

[PATCH, ARM/testsuite 6/7] Force soft float in ARMv6-M and ARMv8-M Baseline options

2016-09-22 Thread Thomas Preudhomme
Hi, ARMv6-M and ARMv8-M Baseline only support soft float ABI. Therefore, the arm_arch_v8m_base add option should pass -mfloat-abi=soft, much like -mthumb is passed for architectures that only support Thumb instruction set. This patch adds -mfloat-abi=soft to both arm_arch_v6m and arm_arch_v8m_

[PATCH, ARM 7/7] Enable ARMv8-M atomic and synchronization support for ARMv8-M Baseline

2016-09-22 Thread Thomas Preudhomme
Hi, This patch is part of a patch series to add support for atomic operations on ARMv8-M Baseline targets in GCC. This specific patch enables atomic and synchronization support added in previous patches of the series and adds tests. Enabling is done at the end of the patch series to ensure tha

Re: [PATCHv2][ARM] -mpure-code option for ARM

2016-09-22 Thread Richard Earnshaw (lists)
On 11/07/16 17:56, Andre Vieira (lists) wrote: > On 07/07/16 13:30, mickael guene wrote: >> Hi Andre, >> >> Another feedback on your purecode patch. >> You have to disable casesi pattern since then it will >> generate wrong code with -mpure-code option. >> Indeed it will generate an 'adr rx, .Lx

Re: Implement -Wimplicit-fallthrough (version 9)

2016-09-22 Thread Marek Polacek
On Wed, Sep 21, 2016 at 03:14:07PM -0400, Jason Merrill wrote: > On 09/21/2016 02:59 PM, Marek Polacek wrote: > > + if (statement == NULL_TREE > > + && attr != NULL_TREE > > + && maybe_attribute_fallthrough_p (attr)) > > +{ > > + /* Turn [[fallthrough]]; into FALLTHROUGH ();. *

PATCH to fix fallout from recent C++ bool changes

2016-09-22 Thread Marek Polacek
Jason reported that make check-c++1z reveals some fallout because we now reject bool++ in C++1z: https://gcc.gnu.org/ml/gcc-patches/2016-09/msg01460.html I hope this patch fixes all of it. Bootstrapped/regtested on x86_64-linux, ok for trunk? 2016-09-22 Marek Polacek * c-c++-common/g

Re: [C++ PATCH] Aligned new option handling fixes (PR c++/77651)

2016-09-22 Thread Christophe Lyon
On 22 September 2016 at 15:01, Jason Merrill wrote: > On Thu, Sep 22, 2016 at 4:58 AM, Christophe Lyon > wrote: >> This new test (aligned-new6.C) fails on arm/aarch64 bare-metal targets >> (using newlib): >> arm-none-eabi/./libstdc++-v3/src/.libs/libstdc++.a(new_opa.o): In >> function `operator n

Re: [PATCH][RFC][regrename][sel-sched] Fix arm bootstrap

2016-09-22 Thread Bernd Edlinger
On 09/22/16 15:26, Kyrill Tkachov wrote: > Hi all, > > In the the interest of fixing arm bootstrap here are the two blocking > issues > and the changes proposed for them. > I'm not familiar enough with regrename or sel-sched to make a call on > whether > these are right or not, I just want to keep

Re: [PATCH][RFC][regrename][sel-sched] Fix arm bootstrap

2016-09-22 Thread Alexander Monakov
On Thu, 22 Sep 2016, Kyrill Tkachov wrote: > In the the interest of fixing arm bootstrap here are the two blocking issues > and the changes proposed for them. > I'm not familiar enough with regrename or sel-sched to make a call on whether > these are right or not, I just want to keep the ball rolli

Re: [PATCH][RFC][regrename][sel-sched] Fix arm bootstrap

2016-09-22 Thread Kyrill Tkachov
On 22/09/16 15:27, Alexander Monakov wrote: On Thu, 22 Sep 2016, Kyrill Tkachov wrote: In the the interest of fixing arm bootstrap here are the two blocking issues and the changes proposed for them. I'm not familiar enough with regrename or sel-sched to make a call on whether these are right or

[PATCH] Bits from Early LTO debug merge -- move stuff from late to early finish

2016-09-22 Thread Richard Biener
This merges moving of unused type pruning from late to early finish as well as handling of debug types and dwarf2 dups elimination. It adds a flag to DIEs so we can mark them as removed in case sth after early finish tries to lookup a DIE for a removed DIE again - we shouldn't re-use the removed

Re: [PATCH][RFC][regrename][sel-sched] Fix arm bootstrap

2016-09-22 Thread Alexander Monakov
On Thu, 22 Sep 2016, Kyrill Tkachov wrote: > Sorry no, the problem is HARD_FRAME_POINTER_REGNUM that is defined as: > #define HARD_FRAME_POINTER_REGNUM\ > (TARGET_ARM\ >? ARM_HARD_FRAME_POINTER_REGNUM\ >: THUMB_HARD_FRAME_POINTER_REGNUM) > > where ARM_

Re: [PATCH][RFC][regrename][sel-sched] Fix arm bootstrap

2016-09-22 Thread Kyrill Tkachov
On 22/09/16 15:39, Alexander Monakov wrote: On Thu, 22 Sep 2016, Kyrill Tkachov wrote: Sorry no, the problem is HARD_FRAME_POINTER_REGNUM that is defined as: #define HARD_FRAME_POINTER_REGNUM\ (TARGET_ARM\ ? ARM_HARD_FRAME_POINTER_REGNUM\ : THUMB_H

Re: [PATCH, ARM/testsuite 6/7] Force soft float in ARMv6-M and ARMv8-M Baseline options

2016-09-22 Thread Thomas Preudhomme
Sorry, noticed an error in the patch. It was not caught during testing because GCC was built with --with-mode=thumb. Correct patch attached. Best regards, Thomas On 22/09/16 14:49, Thomas Preudhomme wrote: Hi, ARMv6-M and ARMv8-M Baseline only support soft float ABI. Therefore, the arm_arch_

Re: [PATCH][RFC][regrename][sel-sched] Fix arm bootstrap

2016-09-22 Thread Bernd Edlinger
On 09/22/16 16:34, Kyrill Tkachov wrote: > > On 22/09/16 15:27, Alexander Monakov wrote: >> H_F_P_IS_FRAME_POINTER (the ChangeLog is wrong). As I understand, the >> issue is >> that config/arm/arm.h defines that to plain 0, which causes the >> warning (ugh?). >> >> Does the following restore boots

Re: [PATCH] - improve sprintf buffer overflow detection (middle-end/49905)

2016-09-22 Thread Martin Sebor
your patch broke bootstrap with MPFR 2.4.2, which is still the recommended (or perhaps minimal) version according to install.texi: /vol/gcc/src/hg/trunk/local/gcc/gimple-ssa-sprintf.c: In function 'int {anonymous}::format_floating_max(tree, char)': /vol/gcc/src/hg/trunk/local/gcc/gimple-ssa-spri

Re: [PATCHv3][ARM] -mpure-code option for ARM

2016-09-22 Thread Andre Vieira (lists)
On 22/09/16 14:52, Richard Earnshaw (lists) wrote: > On 11/07/16 17:56, Andre Vieira (lists) wrote: >> On 07/07/16 13:30, mickael guene wrote: >>> Hi Andre, >>> >>> Another feedback on your purecode patch. >>> You have to disable casesi pattern since then it will >>> generate wrong code with -mpu

Re: [PATCH] - improve sprintf buffer overflow detection (middle-end/49905)

2016-09-22 Thread Martin Sebor
On 09/22/2016 06:14 AM, Rainer Orth wrote: Hi Martin, your patch broke bootstrap with MPFR 2.4.2, which is still the recommended (or perhaps minimal) version according to install.texi: [...] The following patch (together with your other one to fix ILP32 targets) allows a sparc-sun-solaris2.12

[Fortran, accaf, patch, v1] Fixing compatibility with opencoarrays (mostly)

2016-09-22 Thread Andre Vehreschild
Hi all, attached patch fixes compatibility with opencoarrays by using the old coarray interface of caf_get() as long as possible. Bootstrapped and regtested ok on x86_64-linux/F23. Ok for trunk? Regards, Andre -- Andre Vehreschild * Email: vehre ad gmx dot de gcc/fortran/ChangeLog: 20

Re: [PATCH] fix ILP32 bootstrap failures due to -Wformat-length

2016-09-22 Thread Martin Sebor
Jeff or Richard, As the two middle end maintainers familiar with my work, can one of you approve the updated patch? It's necessary to restore ILP32 bootstrap on a number of targets (pr77676). https://gcc.gnu.org/ml/gcc-patches/2016-09/msg01477.html Thanks Martin On 09/21/2016 06:28 PM, Mart

Re: [PATCH] Fix various minor gimple-ssa-sprintf.c issues

2016-09-22 Thread Martin Sebor
What I would be even more grateful for is a review of the error prone parts like those that caused the bootstrap failure. I.e., any lingering assumptions about integer sizes between the host I must say I'm surprised you do all your computations in HOST_WIDE_INT, rather than say in wide_int, the

Re: [PATCH][RFC][regrename][sel-sched] Fix arm bootstrap

2016-09-22 Thread Alexander Monakov
On Thu, 22 Sep 2016, Kyrill Tkachov wrote: > > I don't follow. The macro used as a boolean in places changed by your patch > > is H_F_P_IS_FRAME_POINTER, not H_F_P_REGNUM. > > > > Am I missing something? > > I'm following Bernd's proposed change from: > https://gcc.gnu.org/ml/gcc-patches/2016-09

Re: [PATCHv3][ARM] -mpure-code option for ARM

2016-09-22 Thread Richard Earnshaw (lists)
On 22/09/16 16:04, Andre Vieira (lists) wrote: > > I reworked the patch according to the comments above. > > Is this OK? > > gcc/ChangeLog: > 2016-09-22 Andre Vieira > Terry Guo > > * target.def (elf_flags_numeric): New target hook. > * targhooks.h (default_asm_

Re: [PATCH][RFC][regrename][sel-sched] Fix arm bootstrap

2016-09-22 Thread Kyrill Tkachov
On 22/09/16 16:24, Alexander Monakov wrote: On Thu, 22 Sep 2016, Kyrill Tkachov wrote: I don't follow. The macro used as a boolean in places changed by your patch is H_F_P_IS_FRAME_POINTER, not H_F_P_REGNUM. Am I missing something? I'm following Bernd's proposed change from: https://gcc.gnu.

Re: [PATCH, ARM/testsuite 6/7] Force soft float in ARMv6-M and ARMv8-M Baseline options

2016-09-22 Thread Richard Earnshaw (lists)
On 22/09/16 15:51, Thomas Preudhomme wrote: > Sorry, noticed an error in the patch. It was not caught during testing > because GCC was built with --with-mode=thumb. Correct patch attached. > > Best regards, > > Thomas > > On 22/09/16 14:49, Thomas Preudhomme wrote: >> Hi, >> >> ARMv6-M and ARMv8

Re: Make regcprop to eliminate noop moves better

2016-09-22 Thread Bernd Schmidt
On 09/22/2016 01:48 PM, Jan Hubicka wrote: * postreload.c (reload_cse_simplify): Also accept USE in noop move patterns. diff --git a/gcc/postreload.c b/gcc/postreload.c index 61c1ce8..4f3a526 100644 --- a/gcc/postreload.c +++ b/gcc/postreload.c @@ -153,7 +153,8 @@ reload_cse_sim

Re: [PATCH, ARM/testsuite 6/7] Force soft float in ARMv6-M and ARMv8-M Baseline options

2016-09-22 Thread Thomas Preudhomme
On 22/09/16 16:47, Richard Earnshaw (lists) wrote: On 22/09/16 15:51, Thomas Preudhomme wrote: Sorry, noticed an error in the patch. It was not caught during testing because GCC was built with --with-mode=thumb. Correct patch attached. Best regards, Thomas On 22/09/16 14:49, Thomas Preudhomme

[PATCH, testsuite]: Add x86_64 to gcc.dg/debug/dwarf2/const-2b.c target selector

2016-09-22 Thread Uros Bizjak
2016-09-22 Uros Bizjak * gcc.dg/debug/dwarf2/const-2b.c: Also compile for x86_64-*-*. Remove SSE effective target requirement. Tested on x86_64-linux-gnu {,-m32} where the testcase currently fails for unrelated reasons. Committed to mainline SVN. Uros. Index: gcc.dg/debug/dwarf2/cons

[arm-embedded] [PATCH, 1/7] Move memory model declarations in memmodel.h

2016-09-22 Thread Thomas Preudhomme
Hi, We've decided to apply the following patch to ARM/embedded-6-branch. Best regards, Thomas --- Begin Message --- Hi, This patch is part of a patch series to add support for ARMv8-M[1] to GCC. This specific patch moves memory model declarations in memmodel.h. Currently, is_mm_* memory mo

  1   2   >