Re: Implement -Wswitch-fallthrough

2016-07-11 Thread David Malcolm
On Mon, 2016-07-11 at 22:20 +0200, Marek Polacek wrote: > On Mon, Jul 11, 2016 at 10:11:52PM +0200, Jakub Jelinek wrote: > > On Mon, Jul 11, 2016 at 10:08:02PM +0200, Eric Botcazou wrote: > > > > After I'd completed the warning, I kicked off a bootstrap so as > > > > to add > > > > various gcc_fall

[v3 PATCH] Implement P0307R2, Making Optional Greater Equal Again.

2016-07-11 Thread Ville Voutilainen
Tested on Linux-X64. The test adjustments are so that the tests are kept valid, which required adding a bunch of now-required relops to the test types. The new transparent-but-non-synthesizing aspects of the relops are tested separately. The constraints are a valid implementation of the current Re

Re: Implement -Wswitch-fallthrough

2016-07-11 Thread David Malcolm
On Mon, 2016-07-11 at 22:34 +0200, Jakub Jelinek wrote: > On Mon, Jul 11, 2016 at 10:23:30PM +0200, Marek Polacek wrote: > > On Mon, Jul 11, 2016 at 01:18:02PM -0700, Andi Kleen wrote: > > > > I explained why supporting the classic lint style comment > > > > wouldn't fly. > > > > > > Not convincin

Re: Implement -Wswitch-fallthrough

2016-07-11 Thread Jakub Jelinek
On Mon, Jul 11, 2016 at 04:43:57PM -0400, David Malcolm wrote: > On Mon, 2016-07-11 at 22:34 +0200, Jakub Jelinek wrote: > > On Mon, Jul 11, 2016 at 10:23:30PM +0200, Marek Polacek wrote: > > > On Mon, Jul 11, 2016 at 01:18:02PM -0700, Andi Kleen wrote: > > > > > I explained why supporting the clas

[committed] Fix #pragma omp target * device (...) expansion (PR middle-end/71758)

2016-07-11 Thread Jakub Jelinek
Hi! As the following testcases show, if device clause argument doesn't have int type (or some compatible one), then we ICE, because we don't emit valid GIMPLE. Fixed thusly, bootstrapped/regtested on x86_64-linux and i686-linux, committed to trunk and 6.2. 2016-07-11 Jakub Jelinek PR

Re: [PATCH], PowerPC support to enable -mlra and/or -mfloat128

2016-07-11 Thread Michael Meissner
Sigh, I keep forgetting to attach the patch. 2016-07-11 Michael Meissner * doc/install.texi (Configuration): Document PowerPC specific configuration options --enable-lra and --enable-float128. * configure.ac: Add --enable-lra and --enable-float128 to turn on -ml

Re: Implement -Wswitch-fallthrough: java

2016-07-11 Thread Tom Tromey
> "Marek" == Marek Polacek writes: Marek> +++ gcc/gcc/java/jcf-dump.c Marek> @@ -926,6 +926,8 @@ print_constant (FILE *out, JCF *jcf, int index, int verbosity) Marek>if (verbosity > 0) Marek> fprintf (out, "Fieldref: %ld=", (long) JPOOL_USHORT2 (jcf, index)); Marek>

Re: Implement -Wswitch-fallthrough: libstdc++

2016-07-11 Thread Jonathan Wakely
On 11 July 2016 at 20:57, Marek Polacek wrote: > > 2016-07-11 Marek Polacek > > PR c/7652 > * libsupc++/hash_bytes.cc: Use __builtin_fallthrough. > > diff --git gcc/libstdc++-v3/libsupc++/hash_bytes.cc > gcc/libstdc++-v3/libsupc++/hash_bytes.cc > index 2e5bbfa..818331f 100644 >

Re: [libiberty][PATCH] Avoid zero-length VLAs.

2016-07-11 Thread Ian Lance Taylor
On Mon, Jul 11, 2016 at 1:05 PM, Brooks Moses wrote: > Ping? This is fine, but please add a comment explaining why the code avoids 0-length VLAs. Thanks. Ian > (I suspect I should have added a libiberty maintainer to cc in the first > place.) > > On Mon, Jun 13, 2016 at 9:05 AM, Brooks Moses

Re: [patch] Fix type merging deficiency during WPA

2016-07-11 Thread Jan Hubicka
> > So something akin to what I initially proposed? > https://gcc.gnu.org/ml/gcc-patches/2016-07/msg00182.html I have similar patch to add_expr. I don't think it should have flag_wpa guard: other FEs are keeping umberged decls, too, just not as often as LTO. I am not sure about operand_equal_p

Re: [libiberty][PATCH] Avoid zero-length VLAs.

2016-07-11 Thread Brooks Moses
On Mon, Jul 11, 2016 at 4:27 PM, Ian Lance Taylor wrote: > On Mon, Jul 11, 2016 at 1:05 PM, Brooks Moses wrote: >> Ping? > > This is fine, but please add a comment explaining why the code avoids > 0-length VLAs. Thanks. Thanks! Committed as r238233. This is the comment I added: +/* Avoid

[patch, fortran] PR66310 Problems with intrinsic repeat for large number of copies

2016-07-11 Thread Jerry DeLisle
Attached patch sets a limit of huge-1 on the character count to avoid the integer wrap. Regression tested with adjustment to test case. OK for trunk? Regards, Jerry 2016-07-11 Jerry DeLisle PR fortran/66310 * simplify.c (gfc_simplify_repeat): Set max repeat to huge - 1 to a

Re: [PATCH] disable IPA-cp cloning for functions with target_clones attribute

2016-07-11 Thread Evgeny Stupachenko
PING. On Fri, Jun 24, 2016 at 1:41 PM, Evgeny Stupachenko wrote: > Hi, > > Fix ICE when IPA-cp and target_clones are applied to the same function. > Is the patch ok for trunk? > > Thanks, > Evgeny > > 2016-06-24 Evgeny Stupachenko > > gcc/ > * ipa-cp.c (determine_versionability): Do no

[PATCH], PR 71805, Fix PowerPC ISA 3.0 xxperm/xxpermr usage

2016-07-11 Thread Michael Meissner
When I initially implemented the xxperm support in the ISA 3.0 extensions, I misread the manual. The xxperm (and xxpermr) instruction logically should have 4 arguments, like vperm/vpermr (ouput, 2 inputs that provide the bytes, and the permute register), but due to encoding issues, it only has 3 V

<    1   2