Re: [PATCH][combine][RFC][2/2] PR rtl-optimization/68796: Perfer zero_extract comparison against zero rather than unsupported shorter modes

2015-12-17 Thread Segher Boessenkool
On Thu, Dec 17, 2015 at 05:12:16PM +0100, Bernd Schmidt wrote: > On 12/17/2015 05:10 PM, Kyrill Tkachov wrote: > >Well, this patch still produces the QImode comparison if the target has > >a QImode comparison > >(the have_insn_for check in the simplify_comparison hunk). > > Ok, I didn't look that

Re: [PATCH][combine][RFC][2/2] PR rtl-optimization/68796: Perfer zero_extract comparison against zero rather than unsupported shorter modes

2015-12-17 Thread Jeff Law
On 12/17/2015 10:04 AM, Kyrill Tkachov wrote: In this case, I'm expecting a QImode compare with zero to map down to the aarch64 TST reg, #255 instruction which definitely zeroes out any bits outside of QImode (as it is a bitwise AND with a bitmask), so zero_extract is the more correct expression

Re: [PATCH][AArch64][1/2] PR rtl-optimization/68796 Add compare-of-zero_extract pattern

2015-12-17 Thread Kyrill Tkachov
Hi James, On 17/12/15 17:24, James Greenhalgh wrote: On Thu, Dec 17, 2015 at 03:36:40PM +, Kyrill Tkachov wrote: 2015-12-17 Kyrylo Tkachov PR rtl-optimization/68796 * config/aarch64/aarch64.md (*and3nr_compare0_zextract): New pattern. * config/aarch64/aarch64.c (aarc

Re: [PATCH][combine][RFC][2/2] PR rtl-optimization/68796: Perfer zero_extract comparison against zero rather than unsupported shorter modes

2015-12-17 Thread Kyrill Tkachov
On 17/12/15 17:27, Segher Boessenkool wrote: On Thu, Dec 17, 2015 at 05:12:16PM +0100, Bernd Schmidt wrote: On 12/17/2015 05:10 PM, Kyrill Tkachov wrote: Well, this patch still produces the QImode comparison if the target has a QImode comparison (the have_insn_for check in the simplify_compari

Re: [PATCH] Fix PR c++/68831 (superfluous -Waddress warning for C++ delete)

2015-12-17 Thread Patrick Palka
On Thu, Dec 10, 2015 at 6:54 PM, Patrick Palka wrote: > Is this OK to commit if bootstrap + regtest on x86_64 succeeds? > > gcc/cp/ChangeLog: > > PR c++/68831 > * init.c (build_delete): Use a warning sentinel to disable > -Waddress warnings when building the conditional tha

Re: [BUILDROBOT] "error: null argument where non-null required" on multiple targets

2015-12-17 Thread Jeff Law
On 12/16/2015 03:46 AM, Jan-Benedict Glaw wrote: On Tue, 2015-12-15 10:43:58 -0700, Jeff Law wrote: On 12/14/2015 01:07 PM, Jan-Benedict Glaw wrote: On Mon, 2015-12-14 18:54:28 +, Moore, Catherine wrote: avr-rtems http://toolchain.lug-owl.de/buildbot/show_build_details.ph

Re: [PATCH][combine][RFC][2/2] PR rtl-optimization/68796: Perfer zero_extract comparison against zero rather than unsupported shorter modes

2015-12-17 Thread Bernd Schmidt
On 12/17/2015 06:44 PM, Kyrill Tkachov wrote: Perhaps I had underestimated how involved this issue is :) So if I want to improve the aarch64 situation for GCC 6, would the recommended course of action be to just define the QI and HImode compare against zero patterns? For GCC 6 I think this is t

Re: [PATCH] PR target/68937: i686: -fno-plt produces wrong code (maybe only with tailcall

2015-12-17 Thread H.J. Lu
On Thu, Dec 17, 2015 at 8:11 AM, H.J. Lu wrote: > On Thu, Dec 17, 2015 at 7:50 AM, H.J. Lu wrote: >> On Thu, Dec 17, 2015 at 5:42 AM, Uros Bizjak wrote: >>> On Thu, Dec 17, 2015 at 2:00 PM, H.J. Lu wrote: On Thu, Dec 17, 2015 at 2:04 AM, Uros Bizjak wrote: > On Thu, Dec 17, 2015 at 12

[PATCH] PR c++/68795: fix uninitialized close_paren_loc in cp_parser_postfix_expression

2015-12-17 Thread David Malcolm
cp_parser_parenthesized_expression_list can leave *close_paren_loc untouched if an error occurs; specifically when following this goto: 7402 if (expr == error_mark_node) 7403goto skip_comma; which can lead to cp_parser_postfix_expression attempting to use uninitialize

Re: ipa-cp heuristics fixes

2015-12-17 Thread Jakub Jelinek
On Wed, Dec 16, 2015 at 08:15:12PM +0100, Jan Hubicka wrote: > just to summarize a discussion on IRC. The problem is that we produce debug > statements for eliminated arguments only in ipa-sra and ipa-split, while we > don't do anything for cgraph clones. This is a problem on release branches, > to

Re: [PATCH] PR c++/68795: fix uninitialized close_paren_loc in cp_parser_postfix_expression

2015-12-17 Thread Bernd Schmidt
On 12/17/2015 07:32 PM, David Malcolm wrote: + if (close_paren_loc) close_paren_loc != UNKNOWN_LOCATION - it's very confusing otherwise. Bernd

config-list.mk and obsoleted configurations (was: [BUILDROBOT] "error: null argument where non-null required" on multiple targets)

2015-12-17 Thread Jan-Benedict Glaw
On Thu, 2015-12-17 11:05:42 -0700, Jeff Law wrote: > On 12/16/2015 03:46 AM, Jan-Benedict Glaw wrote: > > Shall I bisect one of the cases anew, with the "Test value of > > _GLIBCXX_USE_C99_WCHAR not whether it is defined" patch that > > uncovered it, applied? Starting with some arbitrary old revis

Re: config-list.mk and obsoleted configurations

2015-12-17 Thread Jeff Law
On 12/17/2015 11:34 AM, Jan-Benedict Glaw wrote: On Thu, 2015-12-17 11:05:42 -0700, Jeff Law wrote: On 12/16/2015 03:46 AM, Jan-Benedict Glaw wrote: Shall I bisect one of the cases anew, with the "Test value of _GLIBCXX_USE_C99_WCHAR not whether it is defined" patch that uncovered it, applied?

stop IPA wrapping 'main'

2015-12-17 Thread Nathan Sidwell
gcc.dg/20031102-1.c now causes some 'surprising' optimization behaviour. It is essentially int FooBar(void) { ... stuff return 0; } int main(void) { return FooBar(); } What happens is that FooBar gets inlined into main, and then ipa-icf notices FooBar and main have identical bodies.

[PATCH] [graphite] replace ISL with isl

2015-12-17 Thread Sebastian Pop
--- Makefile.in | 2 +- Makefile.tpl | 2 +- config/isl.m4 | 2 +- configure | 10 +++--- configure.ac | 14 contrib/d

Re: [PATCH] C FE: improvements to ranges of bad return values

2015-12-17 Thread Jeff Law
On 12/16/2015 07:19 PM, David Malcolm wrote: In the C FE, c_parser_statement_after_labels passes "xloc" to c_finish_return, which is the location of the first token within the returned expression. Hence we don't get a full underline for the following: diagnostic-range-bad-return.c:34:10: warnin

Re: config-list.mk and obsoleted configurations

2015-12-17 Thread Jan-Benedict Glaw
On Thu, 2015-12-17 11:39:24 -0700, Jeff Law wrote: > On 12/17/2015 11:34 AM, Jan-Benedict Glaw wrote: > > On Thu, 2015-12-17 11:05:42 -0700, Jeff Law wrote: > > > On 12/16/2015 03:46 AM, Jan-Benedict Glaw wrote: > > > > Shall I bisect one of the cases anew, with the "Test value of > > > > _GLIBCX

Re: [PATCH] Fix PR c++/68831 (superfluous -Waddress warning for C++ delete)

2015-12-17 Thread Jason Merrill
OK. Jason

Re: [PATCH 3/5] "Fix" intransitive comparison in reload_pseudo_compare_func

2015-12-17 Thread Vladimir Makarov
On 12/17/2015 04:00 AM, Yury Gribov wrote: This patch fixes intransitive comparison in reload_pseudo_compare_func. Imagine the following situation: 1) bitmap_bit_p is unset for A and B but set for C 2) A < B (due to early ira_reg_class_max_nregs comparison) 3) B < C (due to following regno_assig

Re: [PATCH 1/5] Fix asymmetric comparison functions

2015-12-17 Thread Andrew Pinski
On Thu, Dec 17, 2015 at 12:58 AM, Yury Gribov wrote: > Some obvious symmetry fixes. > > Cc-ing > * Andrey (Belevantsev) for bb_top_order_comparator > * Andrew (MacLeod) for compare_case_labels > * Andrew (Pinski) for resort_field_decl_cmp IIRC this was actually not written by me but I copied it b

Re: [PATCH] IRA: Fix % constraint modifier handling on disabled alternatives.

2015-12-17 Thread Vladimir Makarov
On 12/14/2015 08:05 AM, Andreas Krebbel wrote: Hi, the constraint modifier % applies to all the alternatives of a pattern and hence is mostly added to the first constraint of an operand. IRA currently ignores it if the alternative with the % gets disabled by using the `enabled' attribute or if

Re: config-list.mk and obsoleted configurations

2015-12-17 Thread Jeff Law
On 12/17/2015 11:58 AM, Jan-Benedict Glaw wrote: On Thu, 2015-12-17 11:39:24 -0700, Jeff Law wrote: On 12/17/2015 11:34 AM, Jan-Benedict Glaw wrote: On Thu, 2015-12-17 11:05:42 -0700, Jeff Law wrote: On 12/16/2015 03:46 AM, Jan-Benedict Glaw wrote: Shall I bisect one of the cases anew, with

Re: [PATCH][WIP] libstdc++: Make certain exceptions transaction_safe.

2015-12-17 Thread Jonathan Wakely
On 14/11/15 20:45 +0100, Torvald Riegel wrote: +void +_txnal_cow_string_D1(void *that) +{ + typedef std::basic_string bs_type; + bs_type::_Rep *rep = reinterpret_cast( + const_cast(_txnal_cow_string_c_str(that))) - 1; + + // The string can be shared, in which case we would need to decreme

Re: config-list.mk and obsoleted configurations

2015-12-17 Thread Trevor Saunders
On Thu, Dec 17, 2015 at 12:53:20PM -0700, Jeff Law wrote: > On 12/17/2015 11:58 AM, Jan-Benedict Glaw wrote: > >On Thu, 2015-12-17 11:39:24 -0700, Jeff Law wrote: > >>On 12/17/2015 11:34 AM, Jan-Benedict Glaw wrote: > >>>On Thu, 2015-12-17 11:05:42 -0700, Jeff Law wrote: > On 12/16/2015 03:46

Re: PATCH: PR target/66232: -fPIC -fno-plt -mx32 fails to generate indirect branch via GOT

2015-12-17 Thread H.J. Lu
On Thu, Dec 17, 2015 at 8:49 AM, H.J. Lu wrote: > Since Pmode is 64-bit with -maddress-mode=long for x32, indirect call > via GOT slot doesn't need zero_extend. This patch limits *call_got_x32 > and *call_value_got_x32 patterns to 32-bit Pmode, adds *call_got_x32_long > and *call_value_got_x32_lo

Re: ipa-cp heuristics fixes

2015-12-17 Thread Jan Hubicka
Jakub, thanks a lot for looking into this! I am now bit on tight schedule moving back to Prague and I knew little about the implementation of debug info for optimized out arguments. > > Ok, so here is a WIP patch changing the functions you wanted, untested so > far. > > I've been looking at 3 tes

Re: stop IPA wrapping 'main'

2015-12-17 Thread Jan Hubicka
> gcc.dg/20031102-1.c now causes some 'surprising' optimization > behaviour. It is essentially > > int FooBar(void) > { > ... stuff > return 0; > } > > int main(void) > { > return FooBar(); > } > > > What happens is that FooBar gets inlined into main, and then > ipa-icf notices FooBar an

Re: config-list.mk and obsoleted configurations

2015-12-17 Thread Jeff Law
hWell, it might be the only target that has warnings because of that, but from a quick look it seems like any target that uses avr-stdint.h or newlib-stdint.h could theoretically have null values for those macros. Without a bit of digging I'm not sure how much of that is real and how much is co

[PATCH] shrink-wrap: Once more PRs 67778, 68634, and now 68909

2015-12-17 Thread Segher Boessenkool
It turns out v4 wasn't quite complete anyway; so here "v5". If a candidate PRE cannot get the prologue because a block BB is reachable from it, but PRE does not dominate BB, we try again with the dominators of PRE. That "try again" needs to again consider BB though, we aren't done with it. This

Re: ipa-cp heuristics fixes

2015-12-17 Thread Jan Hubicka
> Jakub, > thanks a lot for looking into this! I am now bit on tight schedule moving back > to Prague and I knew little about the implementation of debug info for > optimized out arguments. Hi, here is better testcase that also trigger splitting struct a {int a;int b;}; inline static int reta (str

Fix alias.c wrt aliases and anchors

2015-12-17 Thread Jan Hubicka
Hi, the alias-2.c testcase fails on targets with anchors. The reason is that the variable itself is anchored while the alias is not and they point to the same location. I folllowed the docs of SYMBOL_REF claiming that SYMBOL_REF_DECL if the symbol is label and tought it is safe to disambiguate t

Re: [PATCH] PR target/68937: i686: -fno-plt produces wrong code (maybe only with tailcall

2015-12-17 Thread Uros Bizjak
On Thu, Dec 17, 2015 at 7:09 PM, H.J. Lu wrote: > On Thu, Dec 17, 2015 at 8:11 AM, H.J. Lu wrote: >> On Thu, Dec 17, 2015 at 7:50 AM, H.J. Lu wrote: >>> On Thu, Dec 17, 2015 at 5:42 AM, Uros Bizjak wrote: On Thu, Dec 17, 2015 at 2:00 PM, H.J. Lu wrote: > On Thu, Dec 17, 2015 at 2:04 A

Re: [PATCH] PR target/68937: i686: -fno-plt produces wrong code (maybe only with tailcall

2015-12-17 Thread H.J. Lu
On Thu, Dec 17, 2015 at 1:21 PM, Uros Bizjak wrote: > On Thu, Dec 17, 2015 at 7:09 PM, H.J. Lu wrote: >> On Thu, Dec 17, 2015 at 8:11 AM, H.J. Lu wrote: >>> On Thu, Dec 17, 2015 at 7:50 AM, H.J. Lu wrote: On Thu, Dec 17, 2015 at 5:42 AM, Uros Bizjak wrote: > On Thu, Dec 17, 2015 at 2:

Re: [PATCH 1/5] Fix asymmetric comparison functions

2015-12-17 Thread Jason Merrill
The C++ changes are also for handling comparing an element to itself, which shouldn't happen; I'd prefer a gcc_checking_assert that it doesn't. Jason

[Patch, fortran} pr68196 [4.9/5 Regression] ICE on function result with procedure pointer component

2015-12-17 Thread Paul Richard Thomas
Dear All, Some problems have come up that are not dissimilar to the original bug, involving infinite recursion with procedure components, with the same type as the containing type. The fix is verging on the trivial. However, given that I found two further bugs in fixing the one reported, I worry t

Re: [testsuite][ARM target attributes] Fix effective_target tests

2015-12-17 Thread Christophe Lyon
Hi, Here is an updated version of this patch. I did test it with -mthumb/-march=armv8-a/-mfpu=crypto-neon-fp-armv8/-mfloat-abi=hard in addition to my usual set of options. Compared to the previous version: - I added some doc in sourcebuild.texi - I no longer modify arm_vfp_ok... - I replaced all

Re: [PTX] simplify calling struct

2015-12-17 Thread Bernhard Reutner-Fischer
On December 16, 2015 2:53:51 PM GMT+01:00, Nathan Sidwell wrote: >PTX's machine_function structure squirrels away the function type to >calculate >the presence of varadic args later, rather than calculate it >immediately. It >also uses an rtx field as a boolean. This patch reorganizes it wi

[PATCH] Limit path splitting to loops we optimize for speed

2015-12-17 Thread Jeff Law
It's not currently clear what the final disposition for the path splitting code will be. However, there's no reason not to implement Richi's request that we only do this transformation when optimizing for speed and at optimization levels higher than -O2. This patch limits the transformation

Re: [Patch,tree-optimization]: Add new path Splitting pass on tree ssa representation

2015-12-17 Thread Jeff Law
On 12/11/2015 03:05 AM, Richard Biener wrote: On Thu, Dec 10, 2015 at 9:08 PM, Jeff Law wrote: On 12/03/2015 07:38 AM, Richard Biener wrote: This pass is now enabled by default with -Os but has no limits on the amount of stmts it copies. The more statements it copies, the more likely it is

Re: [PATCH] PR target/68937: i686: -fno-plt produces wrong code (maybe only with tailcall

2015-12-17 Thread H.J. Lu
On Thu, Dec 17, 2015 at 1:59 PM, H.J. Lu wrote: > On Thu, Dec 17, 2015 at 1:21 PM, Uros Bizjak wrote: >> On Thu, Dec 17, 2015 at 7:09 PM, H.J. Lu wrote: >>> On Thu, Dec 17, 2015 at 8:11 AM, H.J. Lu wrote: On Thu, Dec 17, 2015 at 7:50 AM, H.J. Lu wrote: > On Thu, Dec 17, 2015 at 5:42 A

Fix PR66206

2015-12-17 Thread Bernd Schmidt
This is a small problem found by a static analyzer, a function in bt-load can in theory return the address of a local variable. Bootstrapped and tested on x86_64-linux, ok? Bernd PR rtl-optimization/66206 * bt-load.c (find_btr_use): Change first arg to be a pointer to an rtx. All callers ch

Re: Fix PR66206

2015-12-17 Thread Andrew Pinski
On Thu, Dec 17, 2015 at 5:00 PM, Bernd Schmidt wrote: > This is a small problem found by a static analyzer, a function in bt-load > can in theory return the address of a local variable. > > Bootstrapped and tested on x86_64-linux, ok? Except PATTERN (insn) will never be a REG. The only case where

libgo patch committed: Make sure NLA_HDRLEN is defined

2015-12-17 Thread Ian Lance Taylor
This libgo patch from Lynn Boger makes sure that NLA_HDRLEN is defined in the syscall package. Bootstrapped and ran Go testsuite on x86_64-pc-linux-gnu. Committed to mainline and GCC 5 branch. Ian Index: libgo/mksysinfo.sh === --- l

Re: [PATCH] shrink-wrap: Once more PRs 67778, 68634, and now 68909

2015-12-17 Thread Bernd Schmidt
On 12/17/2015 10:07 PM, Segher Boessenkool wrote: It turns out v4 wasn't quite complete anyway; so here "v5". If a candidate PRE cannot get the prologue because a block BB is reachable from it, but PRE does not dominate BB, we try again with the dominators of PRE. That "try again" needs to agai

Re: Fix PR66206

2015-12-17 Thread Bernd Schmidt
On 12/18/2015 02:15 AM, Andrew Pinski wrote: Except PATTERN (insn) will never be a REG. The only case where the input can be a REG is: gcc_assert (!find_btr_use (src)); Yeah, so we _are_ calling it with a REG. It's a minor issue that won't trigger in practice, but in order to close the PR we

Re: [Patch, fortran} pr68196 [4.9/5 Regression] ICE on function result with procedure pointer component

2015-12-17 Thread Steve Kargl
On Thu, Dec 17, 2015 at 11:12:17PM +0100, Paul Richard Thomas wrote: > > Some problems have come up that are not dissimilar to the original > bug, involving infinite recursion with procedure components, with the > same type as the containing type. The fix is verging on the trivial. > However, give

[PATCH] Move split-path pass next to the tracer pass

2015-12-17 Thread Jeff Law
Richi noted that the two passes, which do very similar things are at slightly different places in the pipeline. There really isn't a good reason for that. This patch sinks the split-path pass slightly so that it's immediately before the tracer pass. Bootstrapped and regression tested on

[COMMITTED] Add myself to MAINTAINERS (Write After Approval)

2015-12-17 Thread Saraswati, Sujoy (OSTL)
Hi, I've added myself to "Write After Approval" maintainers. Committed revision 231805. Regards, Sujoy Index: MAINTAINERS === --- MAINTAINERS (revision 231804) +++ MAINTAINERS (revision 231805) @@ -554,6 +554,7 @@ Matthew Sachs

Re: [PATCH] OpenACC documentation for libgomp

2015-12-17 Thread Sandra Loosemore
On 12/16/2015 06:29 AM, James Norris wrote: Hi, Attached is the patch to add OpenACC documentation for libgomp. Ok to commit to trunk? I have some copy-editing nits. I can't say I'm familiar enough with this functionality to comment intelligently on the content, though +To activate t

[PATCH, i386] Introduce support for PKU instructions.

2015-12-17 Thread Kirill Yukhin
Hello, Patch in the bottom introduces support Intel PKRU instructions: rdpkru and wrpkru. It is pretty straight-forward, so I hope it is still suitable for v6. Names for new intrinsics will appear shortly in new revision of SDM. Bootstrapped & regtested. Is it ok for trunk? gcc/ * commo

<    1   2