Re: [Patch] S/390: Fix symbol ref alignment

2015-11-23 Thread Andreas Krebbel
On 10/23/2015 02:12 PM, Robin Dapp wrote: > gcc/testsuite/ChangeLog: > > 2015-10-23 Robin Dapp > > * gcc.target/s390/load-relative-check.c: New test to check > generation of load relative instructions. > > > gcc/ChangeLog: > > 2015-10-23 Robin Dapp > > * config/s

Re: [PATCH 1/2] Libsanitizer merge from upstream r253555.

2015-11-23 Thread Jakub Jelinek
On Mon, Nov 23, 2015 at 10:46:33AM +0300, Maxim Ostapenko wrote: > Index: libsanitizer/configure.ac > === > --- libsanitizer/configure.ac (revision 230597) > +++ libsanitizer/configure.ac (working copy) > @@ -136,6 +136,12 @@ > esac >

Re: [PATCH 2/2] Libsanitizer merge from upstream r253555.

2015-11-23 Thread Jakub Jelinek
On Mon, Nov 23, 2015 at 10:48:30AM +0300, Maxim Ostapenko wrote: > Index: gcc/testsuite/c-c++-common/asan/halt_on_error-1.c > === > --- gcc/testsuite/c-c++-common/asan/halt_on_error-1.c (revision 0) > +++ gcc/testsuite/c-c++-common/asa

Re: Enable pointer TBAA for LTO

2015-11-23 Thread Eric Botcazou
> You are right, TYPE_NONALIASED_COMPONENT is the wrong way. I will fix it > and try to come up with a testcase (TYPE_NONALIASED_COMPONENT is quite > rarely used beast) It's only used in Ada as far as I know, but is quite sensitive and quickly leads to wrong code if not handled properly in my ex

[PATCH] Fix PR68445

2015-11-23 Thread Richard Biener
The following fixes PR68445, SLP permutation being confused by a permutation only using the "first" vector. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied to trunk. Richard. 2015-11-23 Richard Biener PR tree-optimization/68445 * tree-vect-slp.c (vect_create_mas

Re: [ptx] partitioning optimization

2015-11-23 Thread Jakub Jelinek
On Mon, Nov 23, 2015 at 08:46:30AM +0100, Thomas Schwinge wrote: > Here, -fopenacc induces -lgomp. So, we'll either need a (dummy?) libgomp > available to link against in gcc/testsuite/, or come up with a way to do > LTO/offloading compilation without actually linking (libgomp into) the > final ex

Re: [PATCH] Mark by_ref mem_ref in build_receiver_ref as non-trapping

2015-11-23 Thread Jakub Jelinek
On Sat, Nov 21, 2015 at 07:34:02PM +0100, Tom de Vries wrote: > Mark by_ref mem_ref in build_receiver_ref as non-trapping > > 2015-11-21 Tom de Vries > > * omp-low.c (build_receiver_ref): Mark by_ref mem_ref as non-trapping. This is ok. > > --- > gcc/omp-low.c | 5 - > 1 file chan

[PATCH] Add testcase for PR68482

2015-11-23 Thread Richard Biener
Committed. Richard. 2015-11-23 Richard Biener PR tree-optimization/68482 * gcc.dg/vect/pr68482.c: New testcase. Index: gcc/testsuite/gcc.dg/vect/pr68482.c === --- gcc/testsuite/gcc.dg/vect/pr68482.c (revision 0)

Re: [Aarch64] Use vector wide add for mixed-mode adds

2015-11-23 Thread James Greenhalgh
On Sun, Nov 22, 2015 at 06:24:19PM -0700, Michael Collison wrote: > > > On 11/22/2015 8:48 AM, James Greenhalgh wrote: > >On Sun, Nov 08, 2015 at 11:51:47PM -0700, Michael Collison wrote: > >>2015-11-06 Michael Collison > >> * config/aarch64/aarch64-simd.md (widen_ssum, widen_usum) > >>(aar

RE: [PING][Patch] Add support for IEEE-conformant versions of scalar fmin* and fmax*

2015-11-23 Thread David Sherwood
Hi, This is part 1 of a reworked version of a patch I originally submitted in August, rebased after Richard Sandiford's recent work on the internal functions. This first patch adds the internal function definitions and optabs that provide support for IEEE fmax()/fmin() functions. Later patches wi

[PATCH, gcc5 backport] Fix PR ipa/65908

2015-11-23 Thread Martin Liška
Hi. At the end of last week, Richi asked me to back port aforementioned PR. The patch contains two parts: first one is the patch that was applied to trunk and the second one is a hunk that implements param_used_p (coming from r222374). Patch can bootstrap and survives regression tests on x86_64-l

Re: [PATCH,RFC] Introduce RUN_UNDER_VALGRIND in test-suite

2015-11-23 Thread Martin Liška
On 11/21/2015 05:26 AM, Hans-Peter Nilsson wrote: > On Thu, 19 Nov 2015, Martin Li?ka wrote: >> Hello. >> >> In last two weeks I've removed couple of memory leaks, mainly tight to >> middle-end. >> Currently, a user of the GCC compiler can pass '--enable-checking=valgrind' >> configure option >>

Re: [RFC] Cse reducing performance of register allocation with -O2

2015-11-23 Thread Dominik Vogt
On Tue, Oct 13, 2015 at 11:06:48AM -0600, Jeff Law wrote: > On 10/13/2015 07:12 AM, Dominik Vogt wrote: > >In some cases, the work of the cse1 pass is counterproductive, as > >we noticed on s390x. The effect described below is present since > >at least 4.8.0. Note that this may not become manifes

Re: [PATCH, PR68337] Don't fold memcpy/memmove we want to instrument

2015-11-23 Thread Richard Biener
On Fri, Nov 20, 2015 at 3:30 PM, Ilya Enkovich wrote: > On 20 Nov 14:54, Richard Biener wrote: >> On Fri, Nov 20, 2015 at 2:08 PM, Ilya Enkovich >> wrote: >> > On 19 Nov 18:19, Richard Biener wrote: >> >> On November 19, 2015 6:12:30 PM GMT+01:00, Bernd Schmidt >> >> wrote: >> >> >On 11/19/201

Re: [PATCH, PR tree-optimization/68327] Compute vectype for live phi nodes when copmputing VF

2015-11-23 Thread Richard Biener
On Fri, Nov 20, 2015 at 4:10 PM, Ilya Enkovich wrote: > On 20 Nov 14:31, Ilya Enkovich wrote: >> 2015-11-20 14:28 GMT+03:00 Richard Biener : >> > On Wed, Nov 18, 2015 at 2:53 PM, Ilya Enkovich >> > wrote: >> >> 2015-11-18 16:44 GMT+03:00 Richard Biener : >> >>> On Wed, Nov 18, 2015 at 12:34 PM,

Re: [PATCH, PR68460] Always call free_stmt_vec_info_vec in gather_scalar_reductions

2015-11-23 Thread Richard Biener
On Fri, Nov 20, 2015 at 4:57 PM, Tom de Vries wrote: > [ was: Re: [PATCH] Fix parloops gimple_uid usage ] > > On 09/10/15 23:09, Tom de Vries wrote: >> >> @@ -2392,6 +2397,9 @@ gather_scalar_reductions (loop_p loop, >> reduction_info_table_type *reduction_list >> loop_vec_info simple_inner_loo

Re: [PATCH] Fix PR68067

2015-11-23 Thread Richard Biener
On Fri, 20 Nov 2015, Alan Lawrence wrote: > On 6 November 2015 at 10:39, Richard Biener wrote: > >> ../spec2000/benchspec/CINT2000/254.gap/src/polynom.c:358:11: error: > >> location > >> references block not in block tree > >> l1_279 = PHI <1(28), l1_299(33)> > > > > ^^^ > > > > this is the erro

Re: update zlib to 1.2.8

2015-11-23 Thread Andrew Haley
On 23/11/15 04:37, Matthias Klose wrote: > In GCC zlib is only used for libjava; for binutils and gdb it is used when > building without --with-system-zlib. This just updates zlib from 1.2.7 to > 1.2.8 > (released in 2013). Applies cleanly, libjava still builds and doesn't show > any > regre

Re: [Patch, vrp] Allow VRP type conversion folding only for widenings upto word mode

2015-11-23 Thread Richard Biener
On Fri, 20 Nov 2015, Jeff Law wrote: > On 11/20/2015 10:04 AM, Senthil Kumar Selvaraj wrote: > > On Thu, Nov 19, 2015 at 10:31:41AM -0700, Jeff Law wrote: > > > On 11/18/2015 11:20 PM, Senthil Kumar Selvaraj wrote: > > > > On Wed, Nov 18, 2015 at 09:36:21AM +0100, Richard Biener wrote: > > > > >

Re: [PATCH] Fix GC ICE during simd clone creation (PR middle-end/68339)

2015-11-23 Thread Richard Biener
On Fri, Nov 20, 2015 at 9:03 PM, Jakub Jelinek wrote: > Hi! > > node->get_body () can run various IPA passes and ggc_collect in them Aww. Looks like we never implemented that ggc_defer_collecting idea (don't remember the context this popped up, maybe it was when we introduced TODO_do_not_ggc_col

Re: [PATCH] Add LANG_HOOKS_EMPTY_RECORD_P for C++ empty class

2015-11-23 Thread Richard Biener
On Sat, Nov 21, 2015 at 12:46 AM, H.J. Lu wrote: > On Fri, Nov 20, 2015 at 2:17 PM, Jason Merrill wrote: >> On 11/20/2015 01:52 PM, H.J. Lu wrote: >>> >>> On Tue, Nov 17, 2015 at 4:22 AM, Richard Biener >>> wrote: On Tue, Nov 17, 2015 at 12:01 PM, H.J. Lu wrote: > > Empty reco

Re: Fix lto-symtab ICE during Ada LTO bootstrap

2015-11-23 Thread Arnaud Charlet
> I updated the warning to actually check if the TBAA information is in > conflict > and silence warnings on allowed type transtions that are not > useless_type_conversion_p > (which is needed for Fortran, too). This is list of warnings I get which I > suppose will need to be adressed. Most if not

Re: [PATCH/RFC] C++ FE: expression ranges (v2)

2015-11-23 Thread Richard Biener
On Sat, Nov 21, 2015 at 9:21 AM, Jakub Jelinek wrote: > On Sat, Nov 21, 2015 at 02:16:49AM -0500, Jason Merrill wrote: >> On 11/19/2015 03:46 PM, Jason Merrill wrote: >> >On 11/15/2015 12:01 AM, David Malcolm wrote: >> >>As with the C frontend, there's an issue with tree nodes that >> >>don't have

Re: [PATCH, 10/16] Add pass_oacc_kernels pass group in passes.def

2015-11-23 Thread Richard Biener
On Fri, 20 Nov 2015, Tom de Vries wrote: > On 20/11/15 14:29, Richard Biener wrote: > > I agree it's somewhat of an odd behavior but all passes should > > either be placed in a sub-pipeline with an outer > > loop_optimizer_init()/finalize () call or call both themselves. > > Hmm, but adding loop_

Re: [PATCH, PR68337] Don't fold memcpy/memmove we want to instrument

2015-11-23 Thread Ilya Enkovich
On 23 Nov 10:39, Richard Biener wrote: > On Fri, Nov 20, 2015 at 3:30 PM, Ilya Enkovich wrote: > > On 20 Nov 14:54, Richard Biener wrote: > >> On Fri, Nov 20, 2015 at 2:08 PM, Ilya Enkovich > >> wrote: > >> > On 19 Nov 18:19, Richard Biener wrote: > >> >> On November 19, 2015 6:12:30 PM GMT+01:0

Re: RFA: PATCH to match.pd for c++/68385

2015-11-23 Thread Richard Biener
On Sat, Nov 21, 2015 at 7:57 PM, Marc Glisse wrote: > On Sat, 21 Nov 2015, Richard Biener wrote: > >> On November 20, 2015 8:58:15 PM GMT+01:00, Jason Merrill >> wrote: >>> >>> In this bug, we hit the (A & sign-bit) != 0 -> A < 0 transformation. >>> Because of delayed folding, the operands aren't

Re: [PATCH] GCC system.h and Graphite header order

2015-11-23 Thread Richard Biener
On Sun, Nov 22, 2015 at 4:13 AM, Sebastian Pop wrote: > On Sat, Nov 21, 2015 at 4:03 PM, David Edelsohn wrote: >> Graphite relies on the ISL library and includes multiple ISL headers. >> The ISL headers refer to identifiers that are poisoned for use in GCC. >> The source files for Graphite were o

Re: [PATCH] Check NULL loop->latch in verify_loop_structure

2015-11-23 Thread Richard Biener
On Mon, 23 Nov 2015, Tom de Vries wrote: > Hi, > > In verify_loop_structure, we stop checking the latch once we find that it's > NULL. > > This patch tries a bit harder: > - if !LOOPS_MAY_HAVE_MULTIPLE_LATCHES, we don't allow a NULL latch > - if LOOPS_MAY_HAVE_MULTIPLE_LATCHES, we check that ind

Re: [PATCH] Don't reapply loops flags if unnecessary in loop_optimizer_init

2015-11-23 Thread Richard Biener
On Mon, 23 Nov 2015, Tom de Vries wrote: > [ was: Re: [PATCH, 10/16] Add pass_oacc_kernels pass group in passes.def ] > > On 20/11/15 11:37, Richard Biener wrote: > > I'd rather make loop_optimizer_init do nothing > > if requested flags are already set and no fixup is needed and > > call the abov

Re: [PATCH][AArch64][v2] Improve comparison with complex immediates followed by branch/cset

2015-11-23 Thread Kyrill Tkachov
On 12/11/15 12:05, James Greenhalgh wrote: On Tue, Nov 03, 2015 at 03:43:24PM +, Kyrill Tkachov wrote: Hi all, Bootstrapped and tested on aarch64. Ok for trunk? Comments in-line. Here's an updated patch according to your comments. Sorry it took so long to respin it, had other things t

Re: Enable pointer TBAA for LTO

2015-11-23 Thread Richard Biener
On Mon, 23 Nov 2015, Jan Hubicka wrote: > Hi, > here is updated patch which I finally comitted today. It addresses all the > comments > and also fixes one nasty bug that really cost me a lot of time to understand. > > + /* LTO type merging does not make any difference between > +

Re: [PATCH] Mark by_ref mem_ref in build_receiver_ref as non-trapping

2015-11-23 Thread Richard Biener
On Mon, Nov 23, 2015 at 9:45 AM, Jakub Jelinek wrote: > On Sat, Nov 21, 2015 at 07:34:02PM +0100, Tom de Vries wrote: >> Mark by_ref mem_ref in build_receiver_ref as non-trapping >> >> 2015-11-21 Tom de Vries >> >> * omp-low.c (build_receiver_ref): Mark by_ref mem_ref as non-trapping. > >

Re: [PATCH, gcc5 backport] Fix PR ipa/65908

2015-11-23 Thread Richard Biener
On Mon, Nov 23, 2015 at 10:21 AM, Martin Liška wrote: > Hi. > > At the end of last week, Richi asked me to back port aforementioned PR. > The patch contains two parts: first one is the patch that was applied to trunk > and the second one is a hunk that implements param_used_p (coming from > r2223

Re: [PATCH, PR68337] Don't fold memcpy/memmove we want to instrument

2015-11-23 Thread Richard Biener
On Mon, Nov 23, 2015 at 11:10 AM, Ilya Enkovich wrote: > On 23 Nov 10:39, Richard Biener wrote: >> On Fri, Nov 20, 2015 at 3:30 PM, Ilya Enkovich >> wrote: >> > On 20 Nov 14:54, Richard Biener wrote: >> >> On Fri, Nov 20, 2015 at 2:08 PM, Ilya Enkovich >> >> wrote: >> >> > On 19 Nov 18:19, Ric

Re: [PATCH] Mark by_ref mem_ref in build_receiver_ref as non-trapping

2015-11-23 Thread Jakub Jelinek
On Mon, Nov 23, 2015 at 11:39:26AM +0100, Richard Biener wrote: > On Mon, Nov 23, 2015 at 9:45 AM, Jakub Jelinek wrote: > > On Sat, Nov 21, 2015 at 07:34:02PM +0100, Tom de Vries wrote: > >> Mark by_ref mem_ref in build_receiver_ref as non-trapping > >> > >> 2015-11-21 Tom de Vries > >> > >>

[Ada] Introduce a Frontend_Exceptions flag in system.ads

2015-11-23 Thread Olivier Hainque
Hello, The Ada compiler supports different sorts of exception schemes today. The two most commonly used are what we commonly refer to as "frontend-sjlj", and "gcc-zcx". The former is entirely managed by the front-end (gigi included), relying on builtin_setjmp / builtin_longjmp pairs. The latter ex

[Patch] PR68137, drop constant overflow flag in adjust_range_with_scev when possible

2015-11-23 Thread Jiong Wang
As reported by pr68137 and pr68326, r230150 caused new issues. Those ICEs are caused by adjust_range_with_scev getting range with overflowed constants min or max. So given there are too many places to generate OVF, we do a check in adjust_range_with_scev, to drop OVF flag when it's uncessary. Thi

Re: [PATCH 6/n] OpenMP 4.0 offloading infrastructure: option handling

2015-11-23 Thread Richard Biener
On Fri, 20 Nov 2015, Ilya Verbin wrote: > On Wed, Dec 10, 2014 at 01:48:21 +0300, Ilya Verbin wrote: > > On 09 Dec 14:59, Richard Biener wrote: > > > On Mon, 8 Dec 2014, Ilya Verbin wrote: > > > > Unfortunately, this fix was not general enough. > > > > There might be cases when mixed object files

[gomp4] Adjust Fortran OACC async lib test

2015-11-23 Thread Chung-Lin Tang
Hi Thomas, this fix adds more acc_wait's to libgomp.oacc-fortran/lib-1[13].f90. For lib-12.f90, it's sort of a fix before we can resolve the issue of intended semantics for "wait+async". As for lib-13.f90, I believe these added acc_wait calls seem reasonable, since we can't immediately assume the

Re: [PATCH] Fix up reduction-1{1,2} testcases (PR middle-end/68221)

2015-11-23 Thread Richard Biener
On Fri, 20 Nov 2015, Jakub Jelinek wrote: > Hi! > > If C/C++ array section reductions have non-zero (positive) bias, it is > implemented by declaring a smaller private array and subtracting the bias > from the start of the private array (because valid code may only dereference > elements from bia

Re: [PATCH] Fix PR objc/68438 (uninitialized source ranges)

2015-11-23 Thread Joseph Myers
On Sun, 22 Nov 2015, David Malcolm wrote: > Is there (or could there be) a precanned dg- directive to ask if ObjC is > available? I don't think so. Normal practice is that each language's tests are in appropriate directories for that language, with runtest never called with a --tool option f

Re: Fix lto-symtab ICE during Ada LTO bootstrap

2015-11-23 Thread Eric Botcazou
> So there is indeed no point in trying to fix one or two cases, and we should > instead instruct LTO somehow to treat System.Address is compatible with > void* otherwise we'll run into endless troubles on that since using > System.Address as void* is very common practice in Ada code. Maybe we cou

Re: Fix lto-symtab ICE during Ada LTO bootstrap

2015-11-23 Thread Arnaud Charlet
> > So there is indeed no point in trying to fix one or two cases, and we should > > instead instruct LTO somehow to treat System.Address is compatible with > > void* otherwise we'll run into endless troubles on that since using > > System.Address as void* is very common practice in Ada code. > >

Re: [PATCH] Don't reapply loops flags if unnecessary in loop_optimizer_init

2015-11-23 Thread Tom de Vries
On 23/11/15 11:29, Richard Biener wrote: On Mon, 23 Nov 2015, Tom de Vries wrote: [ was: Re: [PATCH, 10/16] Add pass_oacc_kernels pass group in passes.def ] On 20/11/15 11:37, Richard Biener wrote: I'd rather make loop_optimizer_init do nothing if requested flags are already set and no fixup

Re: [Ada] Introduce a Frontend_Exceptions flag in system.ads

2015-11-23 Thread Olivier Hainque
> On Nov 23, 2015, at 12:02 , Olivier Hainque wrote: > Then all the system.ads files will be updated with a correct value of the > Frontend_Exceptions flags. Here's the patch. eh-flags-rts.diff Description: Binary data

Re: [PATCH, 10/16] Add pass_oacc_kernels pass group in passes.def

2015-11-23 Thread Richard Biener
On Sat, 21 Nov 2015, Tom de Vries wrote: > On 20/11/15 11:28, Richard Biener wrote: > > On Thu, 19 Nov 2015, Tom de Vries wrote: > > > > > >On 17/11/15 15:53, Tom de Vries wrote: > > > > > > > >And the above LIM example > > > > > > > >is none for why you need two LIM passes... > > > > > > > > > >

Re: [gomp4.1] Handle new form of #pragma omp declare target

2015-11-23 Thread Thomas Schwinge
Hi Jakub! On Fri, 17 Jul 2015 15:05:59 +0200, Jakub Jelinek wrote: > [...] "omp declare target link" [...] > This patch only marks them with the new attribute, [...] > --- gcc/c/c-parser.c.jj 2015-07-16 18:09:25.0 +0200 > +++ gcc/c/c-parser.c 2015-07-17 14:11:08.553694975 +0200

Re: [PATCH, PR68337] Don't fold memcpy/memmove we want to instrument

2015-11-23 Thread Ilya Enkovich
On 23 Nov 11:44, Richard Biener wrote: > On Mon, Nov 23, 2015 at 11:10 AM, Ilya Enkovich > wrote: > > On 23 Nov 10:39, Richard Biener wrote: > >> On Fri, Nov 20, 2015 at 3:30 PM, Ilya Enkovich > >> wrote: > >> > On 20 Nov 14:54, Richard Biener wrote: > >> >> > >> >> I don't think you can in any

Re: [gomp4.1] Handle new form of #pragma omp declare target

2015-11-23 Thread Jakub Jelinek
On Mon, Nov 23, 2015 at 12:31:24PM +0100, Thomas Schwinge wrote: > Hi Jakub! > > On Fri, 17 Jul 2015 15:05:59 +0200, Jakub Jelinek wrote: > > [...] "omp declare target link" [...] > > > This patch only marks them with the new attribute, [...] > > > --- gcc/c/c-parser.c.jj 2015-07-16 18:09:2

Re: [PATCH, 4/16] Implement -foffload-alias

2015-11-23 Thread Richard Biener
On Sat, 21 Nov 2015, Tom de Vries wrote: > On 13/11/15 12:39, Jakub Jelinek wrote: > > On Fri, Nov 13, 2015 at 12:29:51PM +0100, Richard Biener wrote: > > > > thanks for the explanation. Filed as PR68331 - '[meta-bug] fipa-pta > > > > issues'. > > > > > > > > Any feedback on the '#pragma GCC offl

Re: Fix lto-symtab ICE during Ada LTO bootstrap

2015-11-23 Thread Eric Botcazou
> No, Interfaces.C.Extensions is non portable, so almost no Ada code out there > is using it. As I said, existing Ada code is using System.Address all the > time, so requiring any code change in this area is just a non starter. We'd > rather require that people don't use LTO with Ada rather than te

Re: [Patch] PR68137, drop constant overflow flag in adjust_range_with_scev when possible

2015-11-23 Thread Richard Biener
On Mon, 23 Nov 2015, Jiong Wang wrote: > As reported by pr68137 and pr68326, r230150 caused new issues. > > Those ICEs are caused by adjust_range_with_scev getting range with > overflowed constants min or max. So given there are too many places to > generate OVF, we do a check in adjust_range_wit

Re: [PATCH v2] Add uaddv_optab, usubv4_optab

2015-11-23 Thread Richard Henderson
On 11/22/2015 05:57 PM, Segher Boessenkool wrote: Hi Richard, On Sun, Nov 22, 2015 at 11:38:31AM +0100, Richard Henderson wrote: One of which I believe I've worked around in the i386 backend, but I believe to be a latent problem within combine. With the following patch, disable the add3_*_over

Re: [PATCH 1/2] Libsanitizer merge from upstream r253555.

2015-11-23 Thread Christophe Lyon
On 23 November 2015 at 09:07, Jakub Jelinek wrote: > On Mon, Nov 23, 2015 at 10:46:33AM +0300, Maxim Ostapenko wrote: >> Index: libsanitizer/configure.ac >> === >> --- libsanitizer/configure.ac (revision 230597) >> +++ libsanitizer/co

Re: [AArch64][dejagnu][PATCH 5/7] Dejagnu support for ARMv8.1 Adv.SIMD.

2015-11-23 Thread James Greenhalgh
On Tue, Oct 27, 2015 at 03:32:04PM +, Matthew Wahab wrote: > On 24/10/15 08:16, Bernhard Reutner-Fischer wrote: > >On October 23, 2015 2:24:26 PM GMT+02:00, Matthew Wahab > > wrote: > >>The ARMv8.1 architecture extension adds two Adv.SIMD instructions,. > >>This > >>patch adds support in Dejag

Re: [PATCH 1/2] Libsanitizer merge from upstream r253555.

2015-11-23 Thread Maxim Ostapenko
+ Adhemerval Christophe, it looks like your kernel headers (asm/ptrace.h) don't contain ARM_VFPREGS_SIZE. Do you use old kernel version? -Maxim On 23/11/15 15:16, Christophe Lyon wrote: On 23 November 2015 at 09:07, Jakub Jelinek wrote: On Mon, Nov 23, 2015 at 10:46:33AM +0300, Maxim Ostap

Re: [OpenACC] declare directive

2015-11-23 Thread Thomas Schwinge
Hi Jim! A few things I noticed when working on merging your trunk r230275 into gomp-4_0-branch. Please fix these (on trunk). | --- gcc/c-family/c-pragma.h | +++ gcc/c-family/c-pragma.h | @@ -176,7 +178,8 @@ enum pragma_omp_clause { |PRAGMA_OACC_CLAUSE_FIRSTPRIVATE = PRAGMA_OMP_CLAUSE_FIRSTP

Re: [PATCH 1/2] Libsanitizer merge from upstream r253555.

2015-11-23 Thread Jakub Jelinek
On Mon, Nov 23, 2015 at 03:33:57PM +0300, Maxim Ostapenko wrote: > + Adhemerval > > Christophe, it looks like your kernel headers (asm/ptrace.h) don't contain > ARM_VFPREGS_SIZE. Do you use old kernel version? Unlike LLVM, we do care to support older kernel headers. So, if it is say a define, you

[gomp4] Merge trunk r230274 (2015-11-12) into gomp-4_0-branch

2015-11-23 Thread Thomas Schwinge
Hi! Committed to gomp-4_0-branch in r230749: commit 4002b8b54d3e1e9ac049446339fc02e3fd192f43 Merge: 018ba48 5902f28 Author: tschwinge Date: Mon Nov 23 10:41:31 2015 + svn merge -r 230255:230274 svn+ssh://gcc.gnu.org/svn/gcc/trunk git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc

Re: [PATCH 1/2] Libsanitizer merge from upstream r253555.

2015-11-23 Thread Christophe Lyon
On 23 November 2015 at 13:41, Jakub Jelinek wrote: > On Mon, Nov 23, 2015 at 03:33:57PM +0300, Maxim Ostapenko wrote: >> + Adhemerval >> >> Christophe, it looks like your kernel headers (asm/ptrace.h) don't contain >> ARM_VFPREGS_SIZE. Do you use old kernel version? > Yes, I do use old kernel hea

Re: [PATCH] Avoid false vector mask conversion

2015-11-23 Thread Ilya Enkovich
Ping 2015-11-13 16:17 GMT+03:00 Ilya Enkovich : > 2015-11-13 13:03 GMT+03:00 Richard Biener : >> On Thu, Nov 12, 2015 at 5:08 PM, Ilya Enkovich >> wrote: >>> Hi, >>> >>> When we use LTO for fortran we may have a mix 32bit and 1bit scalar >>> booleans. It means we may have conversion of one scal

[PATCH, C++] Wrap OpenACC wait in EXPR_STMT

2015-11-23 Thread Chung-Lin Tang
The OpenACC wait directive is represented as a call to the runtime function "GOACC_wait" instead of a tree code. I am seeing when '#pragma acc wait' is using inside a template function, the CALL_EXPR to GOACC_wait is being silently ignored/removed during tsubst_expr(). I think the correct way to

Re: [PATCH 1/2] Libsanitizer merge from upstream r253555.

2015-11-23 Thread Maxim Ostapenko
On 23/11/15 16:00, Christophe Lyon wrote: On 23 November 2015 at 13:41, Jakub Jelinek wrote: On Mon, Nov 23, 2015 at 03:33:57PM +0300, Maxim Ostapenko wrote: + Adhemerval Christophe, it looks like your kernel headers (asm/ptrace.h) don't contain ARM_VFPREGS_SIZE. Do you use old kernel version

Re: [PATCH 1/2] Libsanitizer merge from upstream r253555.

2015-11-23 Thread Jakub Jelinek
On Mon, Nov 23, 2015 at 04:21:34PM +0300, Maxim Ostapenko wrote: > Yeah, right. I've asked about kernel headers just to make sure I correctly > understand the issue. > > Actually, I see such code in > lib/sanitizer_common/sanitizer_platform_limits_posix.cc: > > #if defined(PTRACE_GETVFPREGS) && d

Re: [PATCH, PR68337] Don't fold memcpy/memmove we want to instrument

2015-11-23 Thread Richard Biener
On Mon, Nov 23, 2015 at 12:33 PM, Ilya Enkovich wrote: > On 23 Nov 11:44, Richard Biener wrote: >> On Mon, Nov 23, 2015 at 11:10 AM, Ilya Enkovich >> wrote: >> > On 23 Nov 10:39, Richard Biener wrote: >> >> On Fri, Nov 20, 2015 at 3:30 PM, Ilya Enkovich >> >> wrote: >> >> > On 20 Nov 14:54, Ri

Re: Fix lto-symtab ICE during Ada LTO bootstrap

2015-11-23 Thread Richard Biener
On Mon, Nov 23, 2015 at 12:45 PM, Eric Botcazou wrote: >> No, Interfaces.C.Extensions is non portable, so almost no Ada code out there >> is using it. As I said, existing Ada code is using System.Address all the >> time, so requiring any code change in this area is just a non starter. We'd >> rath

Re: [AArch64][PATCH 6/7] Add NEON intrinsics vqrdmlah and vqrdmlsh.

2015-11-23 Thread James Greenhalgh
On Fri, Oct 23, 2015 at 01:26:11PM +0100, Matthew Wahab wrote: > The ARMv8.1 architecture extension adds two Adv.SIMD instructions, > sqrdmlah and sqrdmlsh. This patch adds the NEON intrinsics vqrdmlah and > vqrdmlsh for these instructions. The new intrinsics are of the form > vqrdml{as}h[q]_. > >

Re: [AArch64][PATCH 7/7] Add NEON intrinsics vqrdmlah_lane and vqrdmlsh_lane.

2015-11-23 Thread James Greenhalgh
On Fri, Oct 23, 2015 at 01:30:46PM +0100, Matthew Wahab wrote: > The ARMv8.1 architecture extension adds two Adv.SIMD instructions, > sqrdmlah and sqrdmlsh. This patch adds the NEON intrinsics vqrdmlah_lane > and vqrdmlsh_lane for these instructions. The new intrinsics are of the > form vqrdml{as}h

Re: [PATCH, PR68337] Don't fold memcpy/memmove we want to instrument

2015-11-23 Thread Ilya Enkovich
On 23 Nov 14:29, Richard Biener wrote: > On Mon, Nov 23, 2015 at 12:33 PM, Ilya Enkovich > wrote: > > > > I see. But it should still be OK to check type in case of strict aliasing, > > right? > > No, memcpy is always "no-strict-aliasing" > Thanks a lot for help! Here is a variant with a siz

[5 PATCH] Fix ICE with mangling aliases (PR c++/67354)

2015-11-23 Thread Jakub Jelinek
Hi! On Thu, Nov 19, 2015 at 03:04:35PM -0500, Jason Merrill wrote: > On 11/19/2015 07:40 AM, Jakub Jelinek wrote: > >@@ -4502,6 +4509,7 @@ c_parse_final_cleanups (void) > > > >locus_at_end_of_parsing = input_location; > >at_eof = 1; > >+ defer_mangling_aliases = false; > > Let's clear th

[PATCH 2/6] Fix memory leak in tree-ssa

2015-11-23 Thread marxin
gcc/ChangeLog: 2015-11-20 Martin Liska * tree-ssa.c (redirect_edge_var_map_destroy): Release vectors that are used as a second argument of a hash_map. --- gcc/tree-ssa.c | 5 + 1 file changed, 5 insertions(+) diff --git a/gcc/tree-ssa.c b/gcc/tree-ssa.c index 02fca4c..db7

Re: Enable pointer TBAA for LTO

2015-11-23 Thread Martin Jambor
Hi, On Mon, Nov 23, 2015 at 12:00:25AM +0100, Jan Hubicka wrote: > Hi, > here is updated patch which I finally comitted today. It addresses all the > comments > and also fixes one nasty bug that really cost me a lot of time to understand. > > + /* LTO type merging does not make any diffe

[PATCH 0/6] Another fixes of various memory leaks

2015-11-23 Thread marxin
Hi. Following series has been just bootregtested on x86_64-linux-gnu (all patches together). Ready for trunk? Thanks, Martin marxin (6): Fix memory leak in cilk Fix memory leak in tree-ssa Fix memory leaks in IPA devirt Fix memory leak in loop_vec_info Fix parser memory leak in cilk_si

[PATCH 4/6] Fix memory leak in loop_vec_info

2015-11-23 Thread marxin
gcc/ChangeLog: 2015-11-23 Martin Liska * tree-vect-loop-manip.c (vect_create_cond_for_alias_checks): Do not release memory for comp_alias_ddrs. * tree-vect-loop.c (destroy_loop_vec_info): Release the memory for all loop_vec_info. --- gcc/tree-vect-loop-manip.c

[PATCH 5/6] Fix parser memory leak in cilk_simd_fn_info

2015-11-23 Thread marxin
gcc/cp/ChangeLog: 2015-11-23 Martin Liska * parser.c (cp_parser_late_parsing_cilk_simd_fn_info): Release tokens. --- gcc/cp/parser.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/gcc/cp/parser.c b/gcc/cp/parser.c index 24ed404..fd5c7ec 100644 --- a/gcc/cp/parser.c +++

[PATCH 6/6] Fix memory leak in tree-chkp.c

2015-11-23 Thread marxin
gcc/ChangeLog: 2015-11-23 Martin Liska * tree-chkp.c (chkp_make_static_bounds): Release buffer used for string. --- gcc/tree-chkp.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/gcc/tree-chkp.c b/gcc/tree-chkp.c index 34d9dfc..8b6381f 100644 --- a/gcc/tree-chkp.c +++ b

[PATCH 1/6] Fix memory leak in cilk

2015-11-23 Thread marxin
gcc/c/ChangeLog: 2015-11-20 Martin Liska PR c++/68312 * c-array-notation.c (fix_builtin_array_notation_fn): Use release_vec_vec instead of vec::release. (build_array_notation_expr): Likewise. (fix_conditional_array_notations_1): Likewise. (fix_ar

[PATCH 3/6] Fix memory leaks in IPA devirt

2015-11-23 Thread marxin
gcc/ChangeLog: 2015-11-20 Martin Liska * ipa-devirt.c (ipa_devirt): Use auto_vec instead of a local-scope vec. Release final_warning_records. --- gcc/ipa-devirt.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/gcc/ipa-devirt.c b/gcc/ipa-devirt.c index

[hsa] Fix operand and instruction types for bit-ops

2015-11-23 Thread Martin Jambor
Hi, I have applied the following patch tot he HSA branch to fix some rather unexpected type requirements of the HSA finalizer we discovered when running the target-3[34].c libgomp tests. Thanks, Martin 2015-11-23 Martin Jambor * hsa-gen.c (gen_hsa_binary_operation): Make immediate

[hsa] depend nowait support for target

2015-11-23 Thread Martin Jambor
On Fri, Nov 13, 2015 at 04:11:50PM +0100, Jakub Jelinek wrote: > On Fri, Nov 13, 2015 at 11:18:41AM +0100, Jakub Jelinek wrote: > > For the offloading case, I actually see a problematic spot, namely that > > GOMP_PLUGIN_target_task_completion could finish too early, and get the > > task_lock before

Re: [hsa] depend nowait support for target

2015-11-23 Thread Jakub Jelinek
On Mon, Nov 23, 2015 at 03:12:05PM +0100, Martin Jambor wrote: > +/* Thread routine to run a kernel asynchronously. */ > + > +static void * > +run_kernel_asynchronously (void *thread_arg) > +{ > + struct async_run_info *info = (struct async_run_info *) thread_arg; > + int device = info->device;

Re: [AARCH64] Adding constant folding for __builtin_fmulx* with scalar 32 and 64 bit arguments

2015-11-23 Thread James Greenhalgh
On Mon, Nov 09, 2015 at 11:40:11AM +, Bilyan Borisov wrote: > This patch adds an extension to aarch64_gimple_fold_builtin () that does > constant folding on __builtin_fmulx* calls for 32 and 64 bit floating point > scalar modes. We fold when both arguments are constant, as well as when only >

[hsa] Use new format of device-specific target arguments

2015-11-23 Thread Martin Jambor
Hi, I have committed this branch which changes the format of device-specific arguments of GOMP_target_ext to something closer to what Jakub wants. Specifically, lowest 7 bits determine the accelerator type (0 means all of them), next bit determines whether the next element in args array is also p

Re: [PATCH 0/6] Another fixes of various memory leaks

2015-11-23 Thread Bernd Schmidt
On 11/23/2015 02:49 PM, marxin wrote: Following series has been just bootregtested on x86_64-linux-gnu (all patches together). All ok except 5/6 which I'm not finding obvious. Better to have a cilk/c++ person have a look. In the future, a few more explanations would help with reviewing. Let'

[hsa] Perform version checks in HSA plugin

2015-11-23 Thread Martin Jambor
Hi, the following patch against the HSA branch makes it call GOMP_offload_register_ver and GOMP_offload_unregister_ver as opposed to the routines without version information and adds a version check to the libgomp plugin along the lines other plugins do it. Committed to the branch, any feedback w

Re: [hsa] Use new format of device-specific target arguments

2015-11-23 Thread Jakub Jelinek
On Mon, Nov 23, 2015 at 03:35:48PM +0100, Martin Jambor wrote: > +/* If the value is directly embeded in target argument, it should be a 16-bit > + at most and shifted by tis many bits. */ this Jakub

Re: [PATCH][AArch64] PR target/68363 Check that argument is real INSN in aarch64_madd_needs_nop

2015-11-23 Thread James Greenhalgh
On Mon, Nov 16, 2015 at 01:21:48PM +, Kyrill Tkachov wrote: > Hi all, > > This RTL checking ICE occurs when processing an rtx_insn* in > aarch64_madd_needs_nop that apparently holds JUMP_TABLE_DATA. This shouldn't > be passed to recog. So instead reject it with the INSN_P check. Such > rtx_in

Re: [PATCH, ARM, v2] PR target/68059 libgcc should not use __write for printing fatal error

2015-11-23 Thread Szabolcs Nagy
On 06/11/15 13:32, Szabolcs Nagy wrote: libgcc/config/arm/linux-atomic-64bit.c uses __write to print an error message if the 64bit cmpxchg method is not available in the kernel. __write is not part of the public libc abi, so use write instead. (user code may define write in iso c conforming mode

Re: [PATCH][AArch64] Documentation fix for -fpic

2015-11-23 Thread Szabolcs Nagy
On 12/11/15 11:30, Szabolcs Nagy wrote: The documentation for -fpic and -fPIC explicitly mentions some targets where the difference matters, but not AArch64. Specifying the GOT size limit is not entirely correct as it can depend on the -mcmodel setting, but probably better than leaving the impre

Re: [PATCH][AArch64][v2] Improve comparison with complex immediates followed by branch/cset

2015-11-23 Thread James Greenhalgh
On Mon, Nov 23, 2015 at 10:33:01AM +, Kyrill Tkachov wrote: > > On 12/11/15 12:05, James Greenhalgh wrote: > >On Tue, Nov 03, 2015 at 03:43:24PM +, Kyrill Tkachov wrote: > >>Hi all, > >> > >>Bootstrapped and tested on aarch64. > >> > >>Ok for trunk? > >Comments in-line. > > > > Here's an

Re: [PATCH, ARM, v2] PR target/68059 libgcc should not use __write for printing fatal error

2015-11-23 Thread Richard Earnshaw
On 06/11/15 13:32, Szabolcs Nagy wrote: > libgcc/config/arm/linux-atomic-64bit.c uses __write to print an error > message if the 64bit cmpxchg method is not available in the kernel. > > __write is not part of the public libc abi, so use write instead. > (user code may define write in iso c conform

Re: [PATCH][AArch64][v2] Improve comparison with complex immediates followed by branch/cset

2015-11-23 Thread Kyrill Tkachov
On 23/11/15 14:58, James Greenhalgh wrote: On Mon, Nov 23, 2015 at 10:33:01AM +, Kyrill Tkachov wrote: On 12/11/15 12:05, James Greenhalgh wrote: On Tue, Nov 03, 2015 at 03:43:24PM +, Kyrill Tkachov wrote: Hi all, Bootstrapped and tested on aarch64. Ok for trunk? Comments in-line.

Re: [PATCH 0/6] Another fixes of various memory leaks

2015-11-23 Thread Martin Liška
On 11/23/2015 03:36 PM, Bernd Schmidt wrote: > On 11/23/2015 02:49 PM, marxin wrote: >> Following series has been just bootregtested on x86_64-linux-gnu >> (all patches together). > > All ok except 5/6 which I'm not finding obvious. Better to have a cilk/c++ > person have a look. Hi. Sure, let'

Re: [PATCH][RTL-ree] PR rtl-optimization/68194: Restrict copy instruction in presence of conditional moves

2015-11-23 Thread Kyrill Tkachov
Hi Bernd, On 20/11/15 01:41, Bernd Schmidt wrote: I1 is def_insn, I3 is cand->insn. tmp_reg is 'ax'. What we want to do is reject this transformation because the destination of def_insn (aka I1), that is 'ax', is not the operand of the extend operation in cand->insn (aka I3). As you said, rtx_eq

Re: [PATCH][AArch64] Documentation fix for -fpic

2015-11-23 Thread Richard Earnshaw
On 12/11/15 11:30, Szabolcs Nagy wrote: > The documentation for -fpic and -fPIC explicitly mentions some targets > where the difference matters, but not AArch64. Specifying the GOT size > limit is not entirely correct as it can depend on the -mcmodel setting, > but probably better than leaving the

[PATCH] Fix problem reported in PR68465

2015-11-23 Thread Richard Biener
The following fixes CH - FRE - LIM not doing store-motion across a loop nest for redundant header checks. FRE is supposed to do such redundant comparison "threading" but didn't do it because of latch edges confusing the single_pred_p check. The following fixes it by disregarding edges that come

Re: [PATCH v2] Add uaddv_optab, usubv4_optab

2015-11-23 Thread Bernd Schmidt
On 11/22/2015 09:58 PM, Uros Bizjak wrote: On Sun, Nov 22, 2015 at 11:38 AM, Richard Henderson wrote: * optabs.def (uaddv4_optab, usubv4_optab): New. * internal-fn.c (expand_addsub_overflow): Use them. * doc/md.texi (Standard Names): Add uaddv4, usubv4. * config/i386/i386.c (ix86_cc_mode): Ext

[PATCH][RTL-ifcvt] PR rtl-optimization/68435 Allow (c ? x++ : x--) form

2015-11-23 Thread Kyrill Tkachov
Hi all, In this PR we fail to if-convert a case where in the expression x = c ? a : b; 'a' and 'b' are something like x + 1 and x - 1. So x appears in a and b. The code that checks that nothing from the else block modifies the registers used in a rejects this case. It should accept when the modi

Re: [PATCH, 10/16] Add pass_oacc_kernels pass group in passes.def

2015-11-23 Thread Tom de Vries
On 23/11/15 12:31, Richard Biener wrote: From the dump below I understand you want no memory references in > >the outer loop? > >So the issue seems to be that store motion fails > >to insert the preheader load / exit store to the outermost loop > >possible and thus another LIM pass is needed to

Re: Enable pointer TBAA for LTO

2015-11-23 Thread Richard Biener
On Mon, 23 Nov 2015, Martin Jambor wrote: > Hi, > > On Mon, Nov 23, 2015 at 12:00:25AM +0100, Jan Hubicka wrote: > > Hi, > > here is updated patch which I finally comitted today. It addresses all the > > comments > > and also fixes one nasty bug that really cost me a lot of time to > > underst

  1   2   >