Re: [1/2] OpenACC routine support

2015-11-10 Thread Jakub Jelinek
On Mon, Nov 09, 2015 at 09:28:47PM -0800, Cesar Philippidis wrote: > Here's the patch that Nathan was referring to. I ended up introducing a > boolean variable named first in the various functions which call > finalize_oacc_routines. The problem the original approach was having was > that the routi

Re: [PATCH PR52272]Be smart when adding iv candidates

2015-11-10 Thread Bin.Cheng
On Tue, Nov 10, 2015 at 9:26 AM, Bin.Cheng wrote: > On Mon, Nov 9, 2015 at 11:24 PM, Bernd Schmidt wrote: >> On 11/08/2015 10:11 AM, Richard Biener wrote: >>> >>> On November 8, 2015 3:58:57 AM GMT+01:00, "Bin.Cheng" >>> wrote: > > +inline bool > +iv_common_cand_hasher::equal (const

Re: [PATCH, VECTOR ABI] Add __attribute__((__simd__)) to GCC.

2015-11-10 Thread Kirill Yukhin
Hi Jakub, On 29 Oct 09:54, Jakub Jelinek wrote: > On Wed, Oct 28, 2015 at 12:16:04PM +0300, Kirill Yukhin wrote: > > Bootstrapped. Regtested. Is it ok for trunk? > > > > > > gcc/ > > * omp-low.c (pass_omp_simd_clone::gate): If target allows - call > > without additional conditions

Re: [hsa 9/12] Small alloc-pool fix

2015-11-10 Thread Martin Liška
On 11/06/2015 10:57 AM, Richard Biener wrote: > On Fri, 6 Nov 2015, Martin Liška wrote: > >> On 11/06/2015 10:00 AM, Richard Biener wrote: >>> On Thu, 5 Nov 2015, Martin Jambor wrote: >>> Hi, we use C++ new operators based on alloc-pools a lot in the subsequent patches and real

Re: [PATCH, VECTOR ABI] Add __attribute__((__simd__)) to GCC.

2015-11-10 Thread Jakub Jelinek
On Tue, Nov 10, 2015 at 11:44:18AM +0300, Kirill Yukhin wrote: > gcc/ > * omp-low.c (pass_omp_simd_clone::gate): If target allows - call > without additional conditions. Please make sure CHangeLog entries are tab indented. I would just use a comma instead of " -" above. >

Re: [hsa 5/12] New HSA-related GCC options

2015-11-10 Thread Richard Biener
On Mon, 9 Nov 2015, Martin Jambor wrote: > Hi, > > On Fri, Nov 06, 2015 at 09:42:25AM +0100, Richard Biener wrote: > > On Thu, 5 Nov 2015, Martin Jambor wrote: > > > > > Hi, > > > > > > the following small part of the merge deals with new options. It adds > > > four independent things: > > >

Re: RFC: C++ delayed folding merge

2015-11-10 Thread Richard Biener
On Mon, 9 Nov 2015, Jason Merrill wrote: > On 11/09/2015 02:28 PM, Jason Merrill wrote: > > On 11/09/2015 04:08 AM, Richard Biener wrote: > > > On Mon, 9 Nov 2015, Jason Merrill wrote: > > > > > > > I'm planning to merge the C++ delayed folding branch this week, but I > > > > need to > > > > get

Re: [patch] Fix PR middle-end/68251

2015-11-10 Thread Eric Botcazou
> Tested on x86_64-suse-linux, OK for the mainline? I'll install the Fortran > testcase once it is reduced because it takes a while to compile ATM. Here it is, as reduced by Joost, installed on the mainline. 2015-11-10 Eric Botcazou * gfortran.dg/pr68251.f90: New test. -- Eric Bot

[PATCH][ARM][3/3][v2] Implement negsicc, notsicc optabs

2015-11-10 Thread Kyrill Tkachov
Hi all, This is a slight respin of https://gcc.gnu.org/ml/gcc-patches/2015-09/msg00075.html. This had been ok'd but I've encountered a bug with the *if__move pattern For some reason, after reload operands[1] doesn't end up living in the same register as operands[0] even though it has the const

[PATCH] Fix PR56118

2015-11-10 Thread Richard Biener
The following fixes PR56118 by adjusting the cost model handling of basic-block vectorization to favor the vectorized version in case estimated cost is the same as the estimated cost of the scalar version. This makes sense because we over-estimate the vectorized cost in several places. Bootstrap

Re: RFC: Incomplete Draft Patches to Correct Errors in Loop Unrolling Frequencies (bugzilla problem 68212)

2015-11-10 Thread Bernhard Reutner-Fischer
On November 9, 2015 6:35:20 PM GMT+01:00, Bernd Schmidt wrote: >On 11/07/2015 03:44 PM, Kelvin Nilsen wrote: >> +bool >> +in_loop_p (basic_block block, struct loop *loop_ptr) >> +{ >> + basic_block *bbs = get_loop_body (loop_ptr); >> + bool result = false; >> + >> + for (unsigned int i = 0; i

Re: Extend tree-call-cdce to calls whose result is used

2015-11-10 Thread Richard Biener
On Mon, Nov 9, 2015 at 10:03 PM, Michael Matz wrote: > Hi, > > On Mon, 9 Nov 2015, Richard Sandiford wrote: > >> +static bool >> +can_use_internal_fn (gcall *call) >> +{ >> + /* Only replace calls that set errno. */ >> + if (!gimple_vdef (call)) >> +return false; > > Oh, I managed to confus

Re: Use combined_fn in tree-vrp.c

2015-11-10 Thread Richard Biener
On Tue, Nov 10, 2015 at 1:09 AM, Bernd Schmidt wrote: > On 11/07/2015 01:46 PM, Richard Sandiford wrote: >> >> @@ -3814,8 +3817,8 @@ extract_range_basic (value_range *vr, gimple *stmt) >> break; >> /* Both __builtin_ffs* and __builtin_popcount return >> [0, prec].

Re: [PATCH PR52272]Be smart when adding iv candidates

2015-11-10 Thread Bernd Schmidt
On 11/10/2015 09:25 AM, Bin.Cheng wrote: Thanks for reviewing. I haven't committed it yet, could you please point out which quoted piece is so that I can update patch? Sorry, I thought it was pretty obvious... +{ + return ccand1->hash == ccand2->hash +&& operand_equal_p (ccand1->bas

Re: [hsa 9/12] Small alloc-pool fix

2015-11-10 Thread Richard Biener
On Tue, Nov 10, 2015 at 9:47 AM, Martin Liška wrote: > On 11/06/2015 10:57 AM, Richard Biener wrote: >> On Fri, 6 Nov 2015, Martin Liška wrote: >> >>> On 11/06/2015 10:00 AM, Richard Biener wrote: On Thu, 5 Nov 2015, Martin Jambor wrote: > Hi, > > we use C++ new operators bas

[PATCH] vect_slp_analyze_node_dependences TLC

2015-11-10 Thread Richard Biener
Some TLC also preparing for further enhancements. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied. Richard. 2015-11-10 Richard Biener * tree-vect-data-refs.c (vect_slp_analyze_node_dependences): Handle memory using/clobbering stmts without a STMT_VINFO_DATA_REF

[Patch GCC 5/Vect] Partial backport of r228751 (pr68238)

2015-11-10 Thread James Greenhalgh
Hi, As requested in the PR, this patch is a partial backport of r228751. I can't claim any responsibility for it, but I did take it through the paces on an aarch64-none-linux-gnu and x86_64-none-linux-gnu bootstrap/ test run and found no issues. Applied as r230092 on gcc-5-branch (pre-approved

[PATCH] Fix PR68240

2015-11-10 Thread Richard Biener
Bootstrapped and tested on x86_64-unknown-linux-gnu, applied to trunk. Richard. 2015-11-10 Richard Biener PR tree-optimization/68240 * tree-ssa-sccvn.c (cond_stmts_equal_p): Handle commutative compares properly. (visit_phi): For PHIs with just a single executa

Re: RFC: Incomplete Draft Patches to Correct Errors in Loop Unrolling Frequencies (bugzilla problem 68212)

2015-11-10 Thread Bernd Schmidt
On 11/10/2015 10:56 AM, Bernhard Reutner-Fischer wrote: On November 9, 2015 6:35:20 PM GMT+01:00, Bernd Schmidt wrote: I think something that starts with bb->loop_father and iterates outwards would be more efficient. flow_bb_inside_loop_p() ? Ah thanks. I knew there must be one but I could

Re: [PATCH PR52272]Be smart when adding iv candidates

2015-11-10 Thread Bin.Cheng
On Tue, Nov 10, 2015 at 6:06 PM, Bernd Schmidt wrote: > On 11/10/2015 09:25 AM, Bin.Cheng wrote: >>> >>> Thanks for reviewing. I haven't committed it yet, could you please >>> point out which quoted piece is so that I can update patch? > > > Sorry, I thought it was pretty obvious... > >> +{ >> +

Re: [PATCH 1/6] Use IFN_SQRT in tree-vect-patterns.c

2015-11-10 Thread Richard Biener
On Mon, Nov 9, 2015 at 5:21 PM, Richard Sandiford wrote: > In practice all targets that can vectorise sqrt define the appropriate > sqrt2 optab. The only case where this isn't immediately obvious > is the libmass support in rs6000.c, but Mike Meissner said that it shouldn't > be exercised for sqr

Re: [mask conversion, patch 2/2, i386] Add pack/unpack patterns for scalar masks

2015-11-10 Thread Ilya Enkovich
On 19 Oct 15:30, Ilya Enkovich wrote: > Hi, > > This patch adds patterns to be used for vector masks pack/unpack for AVX512. > Bootstrapped and tested on x86_64-unknown-linux-gnu. Does it look OK? > > Thanks, > Ilya Here is a modified version which reflects changes in boolean type sign. On

Re: [PATCH 2/6] Make builtin_vectorized_function take a combined_fn

2015-11-10 Thread Richard Biener
On Mon, Nov 9, 2015 at 5:25 PM, Richard Sandiford wrote: > This patch replaces the fndecl argument to builtin_vectorized_function > with a combined_fn and gets the vectoriser to call it for internal > functions too. The patch also moves vectorisation of machine-specific > built-ins to a new hook,

Re: [gomp4 06/14] omp-low: copy omp_data_o to shared memory on NVPTX

2015-11-10 Thread Jakub Jelinek
On Tue, Nov 03, 2015 at 05:25:53PM +0300, Alexander Monakov wrote: > Here's an alternative patch that does not depend on exposure of shared-memory > address space, and does not try to use pass_late_lower_omp. It's based on > Bernd's suggestion to transform FYI, I've committed a new testcase to go

Re: Add internal math functions

2015-11-10 Thread Richard Sandiford
Thanks for the review. Jeff Law writes: > On 11/07/2015 05:30 AM, Richard Sandiford wrote: >> This patch adds internal functions for simple FLT_FN built-in functions, >> in cases where an associated optab already exists. Unlike some of the >> built-in functions, these internal functions never se

Re: RFC: Incomplete Draft Patches to Correct Errors in Loop Unrolling Frequencies (bugzilla problem 68212)

2015-11-10 Thread Richard Biener
On Mon, Nov 9, 2015 at 6:35 PM, Bernd Schmidt wrote: > On 11/07/2015 03:44 PM, Kelvin Nilsen wrote: >> >> This is a draft patch to partially address the concerns described in >> bugzilla problem report >> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68212). The patch is >> incomplete in the sense

Re: [PATCH 1/6] Use IFN_SQRT in tree-vect-patterns.c

2015-11-10 Thread Richard Sandiford
Richard Biener writes: > On Mon, Nov 9, 2015 at 5:21 PM, Richard Sandiford > wrote: >> In practice all targets that can vectorise sqrt define the appropriate >> sqrt2 optab. The only case where this isn't immediately obvious >> is the libmass support in rs6000.c, but Mike Meissner said that it s

Re: [mask-load, patch 2/2, i386] Add/modify mask load/store patterns

2015-11-10 Thread Kirill Yukhin
Hi Ilya, On 08 Oct 18:42, Ilya Enkovich wrote: > Hi, > > This patch reflects changes in maskload and maskstore optabs and adds > patterns for AVX-512. The patch is OK for trunk. -- Thanks, K > > Thanks, > Ilya > -- > 2015-10-08 Ilya Enkovich > > * config/i386/sse.md (maskload): Rename

Re: [mask-vec_cond, patch 2/2, i386] Add patterns for vcond_mask_optab

2015-11-10 Thread Kirill Yukhin
Hello Ilya On 08 Oct 18:53, Ilya Enkovich wrote: > Hi, > > This patch add patterns for vcond_mask_optab. No new expand code is > required, existing ix86_expand_sse_movcc is used. The patch is OK for trunk. -- Thanks, K > > Thanks, > Ilya > -- > gcc/ChangeLog: > > 2015-10-08 Ilya Enkovich >

Re: [mask conversion, patch 2/2, i386] Add pack/unpack patterns for scalar masks

2015-11-10 Thread Kirill Yukhin
Hello Ilya, On 10 Nov 13:25, Ilya Enkovich wrote: > On 19 Oct 15:30, Ilya Enkovich wrote: > > Hi, > > > > This patch adds patterns to be used for vector masks pack/unpack for > > AVX512. Bootstrapped and tested on x86_64-unknown-linux-gnu. Does it > > look OK? The patch is OK for trunk. -- T

[PATCH 0/2] Fix invalid left shift of negative value.

2015-11-10 Thread Dominik Vogt
The following series of patches fixes all occurences of left-shifting negative constants in C code which is undefined by the C standard. The patches have been tested on s390x, covering only a small subset of the changes. Ciao Dominik ^_^ ^_^ -- Dominik Vogt IBM Germany

[patch] Tweak comments in libstdc++ header

2015-11-10 Thread Jonathan Wakely
Minor grammatical fix. Committed to trunk. commit 1d82192ff38f4d0777ed57e8c05f3d1659e98649 Author: Jonathan Wakely Date: Tue Nov 10 08:41:57 2015 + * include/bits/functional_hash.h: Fix grammar in comment. diff --git a/libstdc++-v3/include/bits/functional_hash.h b/libstdc++-v3/inclu

Re: Add basic support for direct_optab internal functions

2015-11-10 Thread Richard Biener
On Sat, Nov 7, 2015 at 1:26 PM, Richard Sandiford wrote: > This patch adds a concept of internal functions that map directly to an > optab (here called "direct internal functions"). The function can only > be used if the associated optab can be used. > > We currently have four functions like that

Re: [PATCH 1/2] Fix invalid left shift of negative value.

2015-11-10 Thread Dominik Vogt
On Tue, Nov 10, 2015 at 12:11:23PM +0100, Dominik Vogt wrote: > The following series of patches fixes all occurences of > left-shifting negative constants in C code which is undefined by > the C standard. The patches have been tested on s390x, covering > only a small subset of the changes. Change

Re: [PATCH 0/2] Fix invalid left shift of negative value.

2015-11-10 Thread Dominik Vogt
Sorry, wrong mailing list, please ignore. On Tue, Nov 10, 2015 at 12:11:23PM +0100, Dominik Vogt wrote: > The following series of patches fixes all occurences of > left-shifting negative constants in C code which is undefined by > the C standard. The patches have been tested on s390x, covering >

Re: [PATCH 2/2] Fix invalid left shift of negative value.

2015-11-10 Thread Dominik Vogt
On Tue, Nov 10, 2015 at 12:11:23PM +0100, Dominik Vogt wrote: > The following series of patches fixes all occurences of > left-shifting negative constants in C code which is undefined by > the C standard. The patches have been tested on s390x, covering > only a small subset of the changes. Change

Re: [PATCH 1/2] simplify-rtx: Simplify trunc of and of shiftrt

2015-11-10 Thread Bernd Schmidt
On 11/09/2015 08:33 AM, Segher Boessenkool wrote: If we have (truncate:M1 (and:M2 (lshiftrt:M2 (x:M2) C) C2)) we can write it instead as (and:M1 (lshiftrt:M1 (truncate:M1 (x:M2)) C) C2) + /* Likewise (truncate:QI (and:SI (lshiftrt:SI (x:SI) C) C2)) into + (and:QI (lshift

Re: Add genmatch support for internal functions

2015-11-10 Thread Richard Biener
On Sat, Nov 7, 2015 at 2:17 PM, Richard Sandiford wrote: > Richard Sandiford writes: >> This patch makes genmatch match calls based on combined_fn rather >> than built_in_function and extends the matching to internal functions. >> It also uses fold_const_call to fold the calls to a constant, rath

Re: [RFC][PATCH] Preferred rename register in regrename pass

2015-11-10 Thread Christophe Lyon
On 9 November 2015 at 18:01, Robert Suchanek wrote: > Hi, > >> On 11/09/2015 02:32 PM, Robert Suchanek wrote: >> > The results below were generated for CSiBE benchmark and the numbers in >> > columns express bytes in format 'net (gain/loss)' to show the difference >> > with and without the patch w

[PATCH] Improve C++ loop's backward-jump location

2015-11-10 Thread Andreas Arnez
While fixing PR67192 it turned out that there are multiple potential issues with the location of the backward-jump statement generated by the C and C++ front-ends for an unconditional loop. First, due to a bug the C front-end had sometimes set the location to the token following the loop. This is

Re: Replace match.pd DEFINE_MATH_FNs with auto-generated lists

2015-11-10 Thread Richard Biener
On Sat, Nov 7, 2015 at 2:23 PM, Richard Sandiford wrote: > This patch autogenerates the operator lists for maths functions > like SQRT, adding an additional entry for internal functions. > E.g.: > > (define_operator_list SQRT > BUILT_IN_SQRTF > BUILT_IN_SQRT > BUILT_IN_

Re: Short-cut generation of simple built-in functions

2015-11-10 Thread Richard Biener
On Sat, Nov 7, 2015 at 2:31 PM, Richard Sandiford wrote: > This patch short-circuits the builtins.c expansion code for a particular > gimple call if: > > - the function has an associated internal function > - the target implements that internal function > - the call has no side effects > > This al

RE: [RFC][PATCH] Preferred rename register in regrename pass

2015-11-10 Thread Robert Suchanek
Hi Christophe, > Hi, > > Since you committed this (r230087 if I'm correct), I can see that GCC > fails to build > ligfortran for target arm-none-linuxgnueabi --with-cpu=cortex-a9. ... > > Can you have a look? Sorry for the breakage. I see that my assertion is being triggered. I'll investigate t

[Patch ARM] Switch ARM to unified asm.

2015-11-10 Thread Ramana Radhakrishnan
[Resending as I managed to muck this up with my mail client] Hi, I held off committing a previous version of this patch that I posted in July to be nice to folks backporting fixes and to watch for any objections to move the ARM backend completely over into the unified assembler. The patch does

[PATCH] Fix target arch attribute for skylake

2015-11-10 Thread Yulia Koval
Hi, This patch fixes the issue, when target(arch="haswell") function was chosen instead of target(arch="skylake") on skylake. Ok for trunk? gcc/ * config/i386/i386.c: Handle "skylake" and "skylake-avx512". gcc/testsuite/ * g++.dg/ext/mv16.C: New functions. Yulia patch_skylake De

Re: [RFC] [PATCH V2]: RE: [RFC] [Patch] Relax tree-if-conv.c trap assumptions.

2015-11-10 Thread Richard Biener
On Sat, Nov 7, 2015 at 12:41 PM, Kumar, Venkataramanan wrote: > Hi Richard, > > I have now implemented storing of DR and references using hash maps. > Please find attached patch. > > As discussed, I am now storing the ref, DR and baseref, DR pairs along with > unconditional read/write informatio

Re: [RFC][PATCH] Preferred rename register in regrename pass

2015-11-10 Thread Bernd Schmidt
On 11/09/2015 02:32 PM, Robert Suchanek wrote: @@ -1707,6 +1749,8 @@ build_def_use (basic_block bb) scan_rtx (insn, &XEXP (note, 0), ALL_REGS, mark_read, OP_INOUT); + terminated_this_insn = NULL; + /* Step 4: Close chains for registers that

Re: [PATCH] Fix target arch attribute for skylake

2015-11-10 Thread Uros Bizjak
On Tue, Nov 10, 2015 at 12:54 PM, Yulia Koval wrote: > Hi, > > This patch fixes the issue, when target(arch="haswell") function was > chosen instead of target(arch="skylake") on skylake. Ok for trunk? > > gcc/ > * config/i386/i386.c: Handle "skylake" and > "skylake-avx512". > > gcc/tests

Re: Enable pointer TBAA for LTO

2015-11-10 Thread Richard Biener
On Sun, 8 Nov 2015, Jan Hubicka wrote: > Hi, > this patch adds basic TBAA for pointers to LTO. The basic scheme is simple; > because TYPE_CANONICAL is not really needed by get_alias_set, we completely > drop the caluclation of these (which also saves about 50% canonical type hash > searches) and

Re: [RFC] Combine vectorized loops with its scalar remainder.

2015-11-10 Thread Richard Biener
On Tue, Nov 3, 2015 at 1:08 PM, Yuri Rumyantsev wrote: > Richard, > > It looks like misunderstanding - we assume that for GCCv6 the simple > scheme of remainder will be used through introducing new IV : > https://gcc.gnu.org/ml/gcc-patches/2015-09/msg01435.html > > Is it true or we missed somethin

Re: [PATCH] Simple optimization for MASK_STORE.

2015-11-10 Thread Richard Biener
On Fri, Nov 6, 2015 at 2:28 PM, Yuri Rumyantsev wrote: > Richard, > > I tried it but 256-bit precision integer type is not yet supported. What's the symptom? The compare cannot be expanded? Just add a pattern then. After all we have modes up to XImode. Richard. > Yuri. > > > 2015-11-06 15:56

Re: [PATCH] PR/67682, break SLP groups up if only some elements match

2015-11-10 Thread Richard Biener
On Mon, Nov 9, 2015 at 3:59 PM, Alan Lawrence wrote: > On 06/11/15 12:55, Richard Biener wrote: >> >>> + /* GROUP_GAP of the first group now has to skip over the second group >>> too. */ >>> + GROUP_GAP (first_vinfo) += group2_size; >> >> Please add a MSG_NOTE debug printf stating that we spli

Re: [PATCH] Simple optimization for MASK_STORE.

2015-11-10 Thread Ilya Enkovich
2015-11-10 15:33 GMT+03:00 Richard Biener : > On Fri, Nov 6, 2015 at 2:28 PM, Yuri Rumyantsev wrote: >> Richard, >> >> I tried it but 256-bit precision integer type is not yet supported. > > What's the symptom? The compare cannot be expanded? Just add a pattern then. > After all we have modes up

Re: [PATCH] PR/67682, break SLP groups up if only some elements match

2015-11-10 Thread Richard Biener
On Tue, Nov 10, 2015 at 1:45 PM, Richard Biener wrote: > On Mon, Nov 9, 2015 at 3:59 PM, Alan Lawrence wrote: >> On 06/11/15 12:55, Richard Biener wrote: >>> + /* GROUP_GAP of the first group now has to skip over the second group too. */ + GROUP_GAP (first_vinfo) += group2_size

Re: [PATCH] Make BB vectorizer work on sub-BBs

2015-11-10 Thread Christophe Lyon
On 6 November 2015 at 12:11, Kyrill Tkachov wrote: > Hi Richard, > > > On 06/11/15 11:09, Richard Biener wrote: >> >> On Fri, 6 Nov 2015, Richard Biener wrote: >> >>> The following patch makes the BB vectorizer not only handle BB heads >>> (until the first stmt with a data reference it cannot hand

Re: [RFC] Combine vectorized loops with its scalar remainder.

2015-11-10 Thread Ilya Enkovich
2015-11-10 15:30 GMT+03:00 Richard Biener : > On Tue, Nov 3, 2015 at 1:08 PM, Yuri Rumyantsev wrote: >> Richard, >> >> It looks like misunderstanding - we assume that for GCCv6 the simple >> scheme of remainder will be used through introducing new IV : >> https://gcc.gnu.org/ml/gcc-patches/2015-09

Re: [PATCH] Make BB vectorizer work on sub-BBs

2015-11-10 Thread Richard Biener
On Tue, 10 Nov 2015, Christophe Lyon wrote: > On 6 November 2015 at 12:11, Kyrill Tkachov wrote: > > Hi Richard, > > > > > > On 06/11/15 11:09, Richard Biener wrote: > >> > >> On Fri, 6 Nov 2015, Richard Biener wrote: > >> > >>> The following patch makes the BB vectorizer not only handle BB heads

Re: Remove instantiations when no concept check

2015-11-10 Thread Jonathan Wakely
On 09/11/15 22:14 +0100, François Dumont wrote: Hi I just committed this trivial cleanup. 2015-11-09 François Dumont * include/bits/stl_algo.h (partial_sort_copy): Instantiate std::iterator_traits only if concept checks. (lower_bound): Likewise. (upper_bound): Likewise.

Re: [PATCH] Add configure flag for operator new (std::nothrow)

2015-11-10 Thread Jonathan Wakely
On 06/11/15 09:59 +, Pedro Alves wrote: On 11/06/2015 01:56 AM, Jonathan Wakely wrote: On 5 November 2015 at 23:31, Daniel Gutson The issue is, as I understand it, to do the actual work of operator new, i.e. allocate memory. It should force us to copy most of the code of the original code

[PATCH] Fix IRA register preferencing

2015-11-10 Thread Wilco Dijkstra
Ping of https://gcc.gnu.org/ml/gcc-patches/2014-12/msg00829.html: This fixes a bug in register preferencing. When live range splitting creates a new register from another, it copies most fields except for the register preferences. The preference GENERAL_REGS is used as reg_pref[i].prefclass is i

remove inadvertent testcase commit

2015-11-10 Thread Nathan Sidwell
I've removed a testcase I inadvertently committed along with the routine testcases: 2015-11-09 Nathan Sidwell * testsuite/libgomp.oacc-c-c++-common/firstprivate-1.c: Remove inadvertent commit. nathan

Re: [PATCH 1/2][ARC] Add support for ARCv2 CPUs

2015-11-10 Thread Joern Wolfgang Rennecke
On 30/10/15 11:19, Claudiu Zissulescu wrote: Hi, Please find the updated patch. I will defer the secondary reload optimization which will use the ld instructions with LIMM, for the time being. Apart from the gen_compare_reg change, the patch is OK. If the v2 support mostly works like supp

Re: [PATCH 2/2][ARC] Add support for ARCv2 CPUs

2015-11-10 Thread Joern Wolfgang Rennecke
On 30/10/15 11:22, Claudiu Zissulescu wrote: Hi, Please find the updated patch. Both ARC patches were tested using dg.exp. The ChangeLog entry is unchanged. This is OK.

[patch] Update C++17 library implementation status

2015-11-10 Thread Jonathan Wakely
Committed to trunk. commit 49c7ea7c21cb4592233904cc1a4eb293ac6d851c Author: Jonathan Wakely Date: Tue Nov 10 14:03:39 2015 + Update C++17 library implementation status * doc/xml/manual/status_cxx2017.xml: Update. * doc/html/*: Regenerate. diff --git a/libstdc++-v3/doc/x

Re: OpenACC Firstprivate

2015-11-10 Thread Nathan Sidwell
On 11/09/15 09:46, Nathan Sidwell wrote: I'm going to try and get clarification, but I think the intent is to initialize with the value seen on the device. Consider: My thinking is that the intent of the firstprivate is to initialize with the value known on the device (and behave as-if copyi

Re: [0/7] Type promotion pass and elimination of zext/sext

2015-11-10 Thread Richard Biener
On Sun, Nov 8, 2015 at 10:43 AM, Kugan wrote: > > Thanks Richard for the comments. Please find the attached patches which > now passes bootstrap with x86_64-none-linux-gnu, aarch64-linux-gnu and > ppc64-linux-gnu. Regression testing is ongoing. Please find the comments > for your questions/sugge

Re: [PATCH][ARM] Fix costing of vmul+vcvt combine pattern

2015-11-10 Thread Ramana Radhakrishnan
On Tue, Oct 27, 2015 at 1:55 PM, Kyrill Tkachov wrote: > Hi all, > > This patch allows us to handle the *combine_vcvtf2i pattern in rtx costs by > properly identifying it > as a toint coversion. Before this I saw a pattern like: > (set (reg/i:SI 0 r0) > (fix:SI (fix:SF (mult:SF (reg:SF 16 s0 [

Re: RFC: Incomplete Draft Patches to Correct Errors in Loop Unrolling Frequencies (bugzilla problem 68212)

2015-11-10 Thread Michael Matz
Hi, On Tue, 10 Nov 2015, Richard Biener wrote: > >> +static bool > >> +same_edge_p (edge an_edge, edge another_edge) > >> +{ > >> + return ((an_edge->src == another_edge->src) > >> + && (an_edge->dest == another_edge->dest)); > >> +} > > > > > > Formatting aside (extra parentheses), I wo

[gomp4] Random omp-low.c backporting

2015-11-10 Thread Nathan Sidwell
I've committed this to backport a bunch of random bits from trunk to gomp4, and thereby reduce divergence. nathan 2015-11-10 Nathan Sidwell * omp-low.c: Backport whitespace & formatting changes from trunk. (is_atomic_compatible_p): Delete. (lower_reduction_clauses): Don't call it. (expan

Re: [PATCH][ARM][cleanup] Remove uses of CONST_DOUBLE_HIGH/LOW

2015-11-10 Thread Ramana Radhakrishnan
On Thu, Nov 5, 2015 at 9:32 AM, Kyrill Tkachov wrote: > Hi all, > > This cleanup patch removes handling of CONST_DOUBLE rtxes that carry large > integers. > These should never be passed down from the midend and the arm backend > doesn't create them. > The code has been there since 2007 but the arm

Re: [1/2] OpenACC routine support

2015-11-10 Thread Cesar Philippidis
On 11/10/2015 12:16 AM, Jakub Jelinek wrote: > On Mon, Nov 09, 2015 at 09:28:47PM -0800, Cesar Philippidis wrote: >> Here's the patch that Nathan was referring to. I ended up introducing a >> boolean variable named first in the various functions which call >> finalize_oacc_routines. The problem the

[PATCH] PR47266

2015-11-10 Thread Dominique d'Humières
I’ld like to close PR47266 as FIXED after the commit on trunk and 5.2.1 of the following test extracted from https://gcc.gnu.org/ml/fortran/2011-01/msg00094.html. The test succeeds on trunk and 5.2.1 (see https://gcc.gnu.org/ml/gcc-testresults/2015-11/msg00965.html in which it was included). O

Re: [PATCH 1/6] Use IFN_SQRT in tree-vect-patterns.c

2015-11-10 Thread Richard Biener
On Tue, Nov 10, 2015 at 11:57 AM, Richard Sandiford wrote: > Richard Biener writes: >> On Mon, Nov 9, 2015 at 5:21 PM, Richard Sandiford >> wrote: >>> In practice all targets that can vectorise sqrt define the appropriate >>> sqrt2 optab. The only case where this isn't immediately obvious >>> i

Re: [Patch GCC 5/Vect] Partial backport of r228751 (pr68238)

2015-11-10 Thread James Greenhalgh
On Tue, Nov 10, 2015 at 10:11:30AM +, James Greenhalgh wrote: > > Hi, > > As requested in the PR, this patch is a partial backport of r228751. > > I can't claim any responsibility for it, but I did take it through the > paces on an aarch64-none-linux-gnu and x86_64-none-linux-gnu bootstrap/

Re: [PATCH] Simple optimization for MASK_STORE.

2015-11-10 Thread Richard Biener
On Tue, Nov 10, 2015 at 1:48 PM, Ilya Enkovich wrote: > 2015-11-10 15:33 GMT+03:00 Richard Biener : >> On Fri, Nov 6, 2015 at 2:28 PM, Yuri Rumyantsev wrote: >>> Richard, >>> >>> I tried it but 256-bit precision integer type is not yet supported. >> >> What's the symptom? The compare cannot be e

Re: [hsa 7/12] Disabling the vectorizer for GPU kernels/functions

2015-11-10 Thread Martin Jambor
On Fri, Nov 06, 2015 at 09:38:21AM +0100, Richard Biener wrote: > On Thu, 5 Nov 2015, Martin Jambor wrote: > > > Hi, > > > > in the previous email I wrote we need to "change behavior" of a few > > optimization passes. One was the flattening of GPU functions and the > > other two are in the patch

Re: [RFC] Combine vectorized loops with its scalar remainder.

2015-11-10 Thread Richard Biener
On Tue, Nov 10, 2015 at 2:02 PM, Ilya Enkovich wrote: > 2015-11-10 15:30 GMT+03:00 Richard Biener : >> On Tue, Nov 3, 2015 at 1:08 PM, Yuri Rumyantsev wrote: >>> Richard, >>> >>> It looks like misunderstanding - we assume that for GCCv6 the simple >>> scheme of remainder will be used through intr

Re: [PATCH] Simple optimization for MASK_STORE.

2015-11-10 Thread Ilya Enkovich
2015-11-10 17:46 GMT+03:00 Richard Biener : > On Tue, Nov 10, 2015 at 1:48 PM, Ilya Enkovich wrote: >> 2015-11-10 15:33 GMT+03:00 Richard Biener : >>> On Fri, Nov 6, 2015 at 2:28 PM, Yuri Rumyantsev wrote: Richard, I tried it but 256-bit precision integer type is not yet supported.

Re: [hsa 7/12] Disabling the vectorizer for GPU kernels/functions

2015-11-10 Thread Richard Biener
On Tue, 10 Nov 2015, Martin Jambor wrote: > On Fri, Nov 06, 2015 at 09:38:21AM +0100, Richard Biener wrote: > > On Thu, 5 Nov 2015, Martin Jambor wrote: > > > > > Hi, > > > > > > in the previous email I wrote we need to "change behavior" of a few > > > optimization passes. One was the flattenin

[patch] libstdc++/68190 Fix return type of heterogeneous find for sets

2015-11-10 Thread Jonathan Wakely
This converts the return type of heterogeneous find members to the correct set iterator type. Tested powerpc64le-linux, committed to trunk. Will commit to the gcc-5-branch too. commit d84e13dd8a7d47016bdfc5a9f45d8658a9d16ed9 Author: Jonathan Wakely Date: Tue Nov 10 14:59:00 2015 + F

Re: [PATCH] Make BB vectorizer work on sub-BBs

2015-11-10 Thread Christophe Lyon
On 10 November 2015 at 14:02, Richard Biener wrote: > On Tue, 10 Nov 2015, Christophe Lyon wrote: > >> On 6 November 2015 at 12:11, Kyrill Tkachov wrote: >> > Hi Richard, >> > >> > >> > On 06/11/15 11:09, Richard Biener wrote: >> >> >> >> On Fri, 6 Nov 2015, Richard Biener wrote: >> >> >> >>> The

Re: [PR64164] drop copyrename, integrate into expand

2015-11-10 Thread Alan Lawrence
On 05/11/15 05:08, Alexandre Oliva wrote: [PR67753] fix copy of PARALLEL entry_parm to CONCAT target_reg for gcc/ChangeLog PR rtl-optimization/67753 PR rtl-optimization/64164 * function.c (assign_parm_setup_block): Avoid allocating a stack slot if we don't have a

Re: [AArch64] Move iterators from atomics.md to iterators.md

2015-11-10 Thread James Greenhalgh
On Mon, Nov 02, 2015 at 11:44:02AM +, Matthew Wahab wrote: > Hello > > One of the review comments for the v8.1 atomics patches was that the > iterators and unspec declarations should be moved out of the atomics.md > file (https://gcc.gnu.org/ml/gcc-patches/2015-09/msg01375.html). > > The iter

[PATCH 02/02] C FE: add fix-it hint for . vs ->

2015-11-10 Thread David Malcolm
This is the most trivial example of a real fix-it example I could think of: if the user writes ptr.field rather than ptr->field. gcc/c/ChangeLog: * c-typeck.c (build_component_ref): Special-case POINTER_TYPE when generating a "not a structure of union" error message, and

[PATCH 01/02] PR/62314: add ability to add fixit-hints

2015-11-10 Thread David Malcolm
This patch adds the ability to add "fix-it hints" to a rich_location, which will be displayed when the corresponding diagnostic is printed. It does not actually add any fix-it hints (that comes in the second patch), but it adds test coverage of the machinery and printing, by using the existing dia

Re: [RFC][PATCH] Preferred rename register in regrename pass

2015-11-10 Thread Christophe Lyon
On 10 November 2015 at 12:41, Robert Suchanek wrote: > Hi Christophe, > >> Hi, >> >> Since you committed this (r230087 if I'm correct), I can see that GCC >> fails to build >> ligfortran for target arm-none-linuxgnueabi --with-cpu=cortex-a9. > ... >> >> Can you have a look? > > Sorry for the break

[PATCH] libcpp: add examples to source_location description

2015-11-10 Thread David Malcolm
This is a followup to: [PATCH 10/10] Compress short ranges into source_location which adds some worked examples of what a source_location/location_t can encode. Successfully bootstrapped®rtested on x86_64-pc-linux-gnu (although it only touches a comment). OK for trunk? libcpp/ChangeLog:

Re: [PATCH 01/02] PR/62314: add ability to add fixit-hints

2015-11-10 Thread Bernd Schmidt
On 11/10/2015 05:35 PM, David Malcolm wrote: + /* Nasty workaround to convince the linker to add + rich_location::add_fixit_insert + rich_location::add_fixit_remove + rich_location::add_fixit_replace + to cc1 for use by diagnostic_plugin_test_show_locus, + before anything

Re: [gomp4] Random omp-low.c backporting

2015-11-10 Thread Thomas Schwinge
Hi Nathan! On Tue, 10 Nov 2015 09:19:50 -0500, Nathan Sidwell wrote: > I've committed this to backport a bunch of random bits from trunk to gomp4, > and > thereby reduce divergence. Yeah, I had some of these on my list, too. > --- omp-low.c (revision 230080) > +++ omp-low.c (working copy) > @

[C/C++ PATCH] Reject declarators with huge arrays (PR c/68107, c++/68266)

2015-11-10 Thread Marek Polacek
While both C and C++ FEs are able to reject e.g. int a[__SIZE_MAX__ / sizeof(int)]; they are accepting code such as int (*a)[__SIZE_MAX__ / sizeof(int)]; As Joseph pointed out, any construction of a non-VLA type whose size is half or more of the address space should receive a compile-time error.

Re: [Patch AArch64] Switch constant pools to separate rodata sections.

2015-11-10 Thread Alan Lawrence
On 04/11/15 14:26, Ramana Radhakrishnan wrote: True and I've just been reading more of the backend - We could now start using blocks for constant pools as well. So let's do that. How does something like this look ? Tested on aarch64-none-elf - no regressions. 2015-11-04 Ramana Radhakrishnan

Re: [Patch AArch64] Switch constant pools to separate rodata sections.

2015-11-10 Thread Ramana Radhakrishnan
On Tue, Nov 10, 2015 at 4:39 PM, Alan Lawrence wrote: > On 04/11/15 14:26, Ramana Radhakrishnan wrote: >> >> >> True and I've just been reading more of the backend - We could now start >> using blocks for constant pools as well. So let's do that. >> >> How does something like this look ? >> >> Tes

Re: [PATCH 1/2] Fix invalid left shift of negative value.

2015-11-10 Thread Mike Stump
On Nov 10, 2015, at 3:13 AM, Dominik Vogt wrote: > On Tue, Nov 10, 2015 at 12:11:23PM +0100, Dominik Vogt wrote: >> The following series of patches fixes all occurences of >> left-shifting negative constants in C code which is undefined by >> the C standard. The patches have been tested on s390x,

Re: [Patch AArch64] Switch constant pools to separate rodata sections.

2015-11-10 Thread Alan Lawrence
On 10/11/15 16:39, Alan Lawrence wrote: Since r229878, I've been seeing FAIL: gcc.dg/attr-weakref-1.c (test for excess errors) UNRESOLVED: gcc.dg/attr-weakref-1.c compilation failed to produce executable (both previously passing) on aarch64-none-elf, aarch64_be-none-elf, and aarch64-none-linux-

Re: [PATCH] Simple optimization for MASK_STORE.

2015-11-10 Thread Mike Stump
On Nov 10, 2015, at 6:56 AM, Ilya Enkovich wrote: > 2015-11-10 17:46 GMT+03:00 Richard Biener : >> On Tue, Nov 10, 2015 at 1:48 PM, Ilya Enkovich >> wrote: >>> 2015-11-10 15:33 GMT+03:00 Richard Biener : On Fri, Nov 6, 2015 at 2:28 PM, Yuri Rumyantsev wrote: > Richard, > > I t

RE: [PATCH 1/2][ARC] Add support for ARCv2 CPUs

2015-11-10 Thread Claudiu Zissulescu
> If you can name a pre-existing testcase to trigger the assert, the patch is > approved for separate check-in. The patch solves the gcc.dg/pr29921-2.c error, visible for ARC700 architecture. I will prepare a new patch for this error. Thank you for the review, Claudiu

Re: [PATCH 01/02] PR/62314: add ability to add fixit-hints

2015-11-10 Thread David Malcolm
On Tue, 2015-11-10 at 17:26 +0100, Bernd Schmidt wrote: > On 11/10/2015 05:35 PM, David Malcolm wrote: > > + /* Nasty workaround to convince the linker to add > > + rich_location::add_fixit_insert > > + rich_location::add_fixit_remove > > + rich_location::add_fixit_replace > > +

Re: State of support for the ISO C++ Transactional Memory TS and remanining work

2015-11-10 Thread Szabolcs Nagy
On 09/11/15 00:19, Torvald Riegel wrote: Hi, I'd like to summarize the current state of support for the TM TS, and outline the current plan for the work that remains to complete the support. I'm aware we're at the end of stage 1, but I'm confident we can still finish this work and hope to inclu

Re: [PATCH][ARM][cleanup] Remove uses of CONST_DOUBLE_HIGH/LOW

2015-11-10 Thread Kyrill Tkachov
Hi Ramana, On 10/11/15 14:33, Ramana Radhakrishnan wrote: On Thu, Nov 5, 2015 at 9:32 AM, Kyrill Tkachov wrote: Hi all, This cleanup patch removes handling of CONST_DOUBLE rtxes that carry large integers. These should never be passed down from the midend and the arm backend doesn't create the

Re: [PATCH 1/6] Use IFN_SQRT in tree-vect-patterns.c

2015-11-10 Thread Joseph Myers
On Tue, 10 Nov 2015, Richard Biener wrote: > Looks ok but I wonder if this is dead code with > > (for pows (POW) > sqrts (SQRT) > cbrts (CBRT) > (simplify > (pows @0 REAL_CST@1) > (with { > const REAL_VALUE_TYPE *value = TREE_REAL_CST_PTR (@1); > REAL_VALUE_TYPE tmp; >}

  1   2   >