Re: [PATCH][ARM/AArch64] PR 68088: Fix RTL checking ICE due to subregs inside accumulator forwarding check

2015-11-09 Thread Nikolai Bozhenov
On 11/06/2015 08:16 PM, Kyrill Tkachov wrote: On 06/11/15 17:09, Kyrill Tkachov wrote: On 06/11/15 17:07, Nikolai Bozhenov wrote: On 11/06/2015 04:46 PM, Ramana Radhakrishnan wrote: Hi! I faced the same issue but I had somewhat different RTL for the consumer: (insn 20 15 21 2 (set

FW: [PATCH, ARM/testsuite] Fix thumb2-slow-flash-data.c failures

2015-11-09 Thread Thomas Preud'homme
[Forwarding to gcc-patches, doh!] Best regards, Thomas --- Begin Message --- Hi, ARM-specific thumb2-slow-flash-data.c testcase shows 2 failures when running for arm-none-eabi with -mcpu=cortex-m7: FAIL: gcc.target/arm/thumb2-slow-flash-data.c (test for excess errors) FAIL: gcc.target/arm/thu

Re: [PING][PATCH][4.9]Backport "Fix register corruption bug in ree"

2015-11-09 Thread Richard Biener
On Fri, 6 Nov 2015, Renlin Li wrote: > Hi Richard, > > I am trying to come up with a simple test case, but failed to do so. > > I have isolated the function where bug is triggered. However, in order to make > it a useful test case, the silently corrupted register should be used > somewhere, and

Re: [gomp4, committed] Remove superfluous pass_expand_omp_ssa

2015-11-09 Thread Thomas Schwinge
Hi! On Sun, 8 Nov 2015 23:00:31 +0100, Tom de Vries wrote: > This patch removes a superfluous pass_expand_omp_ssa. [...] > --- a/gcc/passes.def > +++ b/gcc/passes.def > @@ -122,7 +122,6 @@ along with GCC; see the file COPYING3. If not see > late. */ > NEXT_PASS (pass_split_

[PATCH] Minor refactoring in tree-ssanames.c & freelists verifier

2015-11-09 Thread Jeff Law
This is a piece of a larger refactoring. I'm postponing the larger refactoring until next stage1 -- I have some concerns about the compile-time impact that I'll need to measure. In the mean time I want to get knowledge of the freelists out of pass_release_ssa_names::execute. The larger ref

Re: [PATCH 1/4] [ARM] PR63870 Add qualifiers for NEON builtins

2015-11-09 Thread Ramana Radhakrishnan
On 08/11/15 00:26, charles.bay...@linaro.org wrote: > From: Charles Baylis > > gcc/ChangeLog: > > Charles Baylis > > PR target/63870 > * config/arm/arm-builtins.c (enum arm_type_qualifiers): New enumerator > qualifier_struct_load_store_lane_index. > (builtin_arg): Ne

Re: RFC: C++ delayed folding merge

2015-11-09 Thread Richard Biener
On Mon, 9 Nov 2015, Jason Merrill wrote: > I'm planning to merge the C++ delayed folding branch this week, but I need to > get approval of the back end changes (the first patch attached). Most of > these are the introduction of non-folding variants of convert_to_*, but there > are a few others. >

Re: [PATCH 2/4] [ARM] PR63870 Mark lane indices of vldN/vstN with appropriate qualifier

2015-11-09 Thread Ramana Radhakrishnan
On 08/11/15 00:26, charles.bay...@linaro.org wrote: > From: Charles Baylis > > gcc/ChangeLog: > > Charles Baylis > > PR target/63870 > * config/arm/arm-builtins.c: (arm_load1_qualifiers) Use > qualifier_struct_load_store_lane_index. > (arm_storestruct_lane_qualifiers

Re: FW: [PATCH, ARM/testsuite] Fix thumb2-slow-flash-data.c failures

2015-11-09 Thread Kyrill Tkachov
On 09/11/15 08:21, Thomas Preud'homme wrote: [Forwarding to gcc-patches, doh!] Best regards, Thomas [PATCH, ARM/testsuite] Fix thumb2-slow-flash-data.c failures.eml Subject: [PATCH, ARM/testsuite] Fix thumb2-slow-flash-data.c failures From: Thomas Preud'homme Date: 09/11/15 08:02 To: Ri

Re: [PATCH][ARM/AArch64] PR 68088: Fix RTL checking ICE due to subregs inside accumulator forwarding check

2015-11-09 Thread Kyrill Tkachov
On 09/11/15 08:14, Nikolai Bozhenov wrote: On 11/06/2015 08:16 PM, Kyrill Tkachov wrote: On 06/11/15 17:09, Kyrill Tkachov wrote: On 06/11/15 17:07, Nikolai Bozhenov wrote: On 11/06/2015 04:46 PM, Ramana Radhakrishnan wrote: Hi! I faced the same issue but I had somewhat different RTL fo

Re: RFC: C++ delayed folding merge

2015-11-09 Thread Eric Botcazou
> One question: The branch changes 'convert' to not fold its result, and > it's not clear to me whether that's part of the expected behavior of a > front end 'convert' function or not. I don't think that you should change the behavior for front-ends that have an internal representation distinct f

Re: [PATCH][ARM] PR 68143 Properly update memory offsets when expanding setmem

2015-11-09 Thread Kyrill Tkachov
On 06/11/15 10:46, Kyrill Tkachov wrote: Hi all, In this wrong-code PR the vector setmem expansion and arm_block_set_aligned_vect in particular use the wrong offset when calling adjust_automodify_address. In the attached testcase during the initial zeroing out we get two V16QI stores, but the

Re: [PATCH v2] libitm: Support sized delete.

2015-11-09 Thread Richard Henderson
On 11/09/2015 01:24 AM, Torvald Riegel wrote: This patch supports the sized variants of operator delete. Some change compare to v1. Tested on x86_64-linux. Looks good. r~

[gomp4, committed] Cleanup formatting of pass_expand_omp_ssa::execute

2015-11-09 Thread Tom de Vries
Hi, this patch makes the formatting of pass_expand_omp_ssa::execute identical to the one in trunk. Committed to gomp-4_0-branch. Thanks, - Tom Cleanup formatting of pass_expand_omp_ssa::execute 2015-11-09 Tom de Vries * omp-low.c (pass_expand_omp_ssa::execute): Cleanup formatting. ---

[gomp4, committed] Remove TODO_remove_unused_locals from todo_flags_finish of pass_data_expand_omp_ssa

2015-11-09 Thread Tom de Vries
Hi, this patch removes TODO_remove_unused_locals from todo_flags_finish of pass_data_expand_omp_ssa. I can't reproduce the problem TODO_remove_unused_locals is supposed to fix with the current state of gomp-4_0-branch. Committed to gomp-4_0-branch. Thanks, - Tom Remove TODO_remove_unused_lo

[gomp4, committed] Provide PROP_gimple_eomp unconditionally in pass_expand_omp

2015-11-09 Thread Tom de Vries
Hi, now that we don't postpone expanding the kernels region anymore, we can set PROP_gimple_eomp unconditionally. Committed to gomp-4_0-branch. Thanks, - Tom Provide PROP_gimple_eomp unconditionally in pass_expand_omp 2015-11-09 Tom de Vries * omp-low.c (pass_data_expand_omp): Add PROP_

[gomp4, committed] Remove ssa support in expand_omp_target

2015-11-09 Thread Tom de Vries
Hi, now that we don't postpone expanding the kernels region anymore, we don't need ssa support in expand_omp_target. Committed to gomp-4_0-branch. Thanks, - Tom Remove ssa support in expand_omp_target 2015-11-09 Tom de Vries * omp-low.c (release_first_vuse_in_edge_dest): Remove (expand

Re: [PATCH][combine][RFC] Don't transform sign and zero extends inside mults

2015-11-09 Thread Segher Boessenkool
On Mon, Nov 09, 2015 at 08:52:13AM +0100, Uros Bizjak wrote: > On Sun, Nov 8, 2015 at 9:58 PM, Segher Boessenkool > wrote: > > On Fri, Nov 06, 2015 at 04:00:08PM -0600, Segher Boessenkool wrote: > >> This patch stops combine from generating widening muls of anything else > >> but registers (immedi

Re: [hsa 4/12] OpenMP lowering/expansion changes (gridification)

2015-11-09 Thread Martin Jambor
Hi, On Thu, Nov 05, 2015 at 10:57:33PM +0100, Martin Jambor wrote: > ... > > For convenience of anybody reviewing the code, I'm attaching a very > simple testcase with selection of dumps that illustrate the whole > process. > My apologies, I have forgotten to attach the file, so let me quick

Re: Add a combined_fn enum

2015-11-09 Thread Bernd Schmidt
On 11/07/2015 01:22 PM, Richard Sandiford wrote: I'm working on a patch series that needs to be able to treat built-in functions and internal functions in a similar way. This patch adds a new enum, combined_fn, that combines the two together. It also adds utility functions for seeing which co

Re: Add a combined_fn enum

2015-11-09 Thread Richard Sandiford
Bernd Schmidt writes: > On 11/07/2015 01:22 PM, Richard Sandiford wrote: >> I'm working on a patch series that needs to be able to treat built-in >> functions and internal functions in a similar way. This patch adds a >> new enum, combined_fn, that combines the two together. It also adds >> util

[gomp4] Merge trunk r229831 (2015-11-06) into gomp-4_0-branch

2015-11-09 Thread Thomas Schwinge
Hi! Committed to gomp-4_0-branch in r229996: commit 16dbf91c2738167a38a4870c79015dfd619ef903 Merge: 38d123c 917fa02 Author: tschwinge Date: Mon Nov 9 09:07:26 2015 + svn merge -r 229816:229831 svn+ssh://gcc.gnu.org/svn/gcc/trunk git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/

Fix PR middle-end/68253

2015-11-09 Thread Eric Botcazou
This apparently doesn't have any effect in practice, but valgrind rightfully complains, as reported by Martin L. Tested on x86_64-suse-linux, applied on the mainline as obvious. 2015-11-09 Eric Botcazou PR middle-end/68253 * fold-const.c (fold_truth_andor_1): Initialize new

Re: Add a combined_fn enum

2015-11-09 Thread Bernd Schmidt
On 11/09/2015 11:24 AM, Richard Sandiford wrote: Bernd Schmidt writes: I see it's already acked, but have you considered just doing away with the builtin/internal function distinction? I think they're too different to be done away with entirely. built-in functions map directly to a specific

Re: [AARCH64][PATCH 2/3] Implementing vmulx_lane NEON intrinsic variants

2015-11-09 Thread Bilyan Borisov
On 03/11/15 11:16, James Greenhalgh wrote: On Fri, Oct 30, 2015 at 09:31:08AM +, Bilyan Borisov wrote: In this patch from the series, all vmulx_lane variants have been implemented as a vdup followed by a vmulx. Existing implementations of intrinsics were refactored to use this new approach

Re: [AARCH64][PATCH 2/3] Implementing vmulx_lane NEON intrinsic variants + Changelog

2015-11-09 Thread Bilyan Borisov
On 09/11/15 11:03, Bilyan Borisov wrote: On 03/11/15 11:16, James Greenhalgh wrote: On Fri, Oct 30, 2015 at 09:31:08AM +, Bilyan Borisov wrote: In this patch from the series, all vmulx_lane variants have been implemented as a vdup followed by a vmulx. Existing implementations of intrinsi

[patch] Fix PR middle-end/68251

2015-11-09 Thread Eric Botcazou
Hi, I don't understand how this didn't show up sooner given the amount of testing, but there is a nasty overloading for the new REF_REVERSE_STORAGE_ORDER flag: #define REF_REVERSE_STORAGE_ORDER(NODE) \ (TREE_CHECK2 (NODE, BIT_FIELD_REF, MEM_REF)->base.u.bits.saturating_flag) saturating_flag

[PATCH] Fix memory leaks and use a pool_allocator

2015-11-09 Thread Martin Liška
Hi. This is follow-up of changes that Richi started on Friday. Patch can bootstrap on x86_64-linux-pc and regression tests are running. Ready for trunk? Thanks, Martin >From ece1ad32be127c1e00dd18c8d0358bf842fad2bd Mon Sep 17 00:00:00 2001 From: marxin Date: Mon, 9 Nov 2015 10:49:14 +0100 Subje

Re: [PATCH/RFC/RFA] Machine modes for address printing (all targets)

2015-11-09 Thread Julian Brown
On Thu, 5 Nov 2015 11:22:04 +0100 Bernd Schmidt wrote: > > static void > > -mcore_print_operand_address (FILE * stream, rtx x) > > +mcore_print_operand_address (FILE * stream, machine_mode mode > > ATTRIBUTE_UNUSED, > > +rtx x) > > So apparently we're settling on writi

[gomp4] Re: [openacc] tile, independent, default, private and firstprivate support in c/++

2015-11-09 Thread Thomas Schwinge
Hi! On Thu, 5 Nov 2015 18:10:49 -0800, Cesar Philippidis wrote: > I've applied this patch to trunk. It also includes the fortran and > template changes. [...] > Also, because of these reduction problems, I decided not to merge > combined_loops.f90 with combined-directives.f90 yet because the la

[PATCH][AArch64] PR target/68129: Define TARGET_SUPPORTS_WIDE_INT

2015-11-09 Thread Kyrill Tkachov
Hi all, In this PR we hit an ICE in simplify-rtx.c: #if TARGET_SUPPORTS_WIDE_INT == 0 /* This assert keeps the simplification from producing a result that cannot be represented in a CONST_DOUBLE but a lot of upstream callers expect that this function never fails to simplify s

Re: Unreviewed patch

2015-11-09 Thread Rainer Orth
Jeff Law writes: > On 11/06/2015 06:29 AM, Rainer Orth wrote: >> The following patch has remained unrevied for a month: >> >> [build] Support init priority on Solaris >> https://gcc.gnu.org/ml/gcc-patches/2015-10/msg00716.html >> >> It needs build and ia64 maintainers and someone fa

[PATCH][AArch64][cleanup] Remove uses of CONST_DOUBLE_HIGH, CONST_DOUBLE_LOW

2015-11-09 Thread Kyrill Tkachov
Hi all, From what I understand, we shouldn't encounter the case where CONST_DOUBLE is used to hold a large integer value, accessed through CONST_DOUBLE_LOW and CONST_DOUBLE_HIGH. The aarch64 backend doesn't generate any such rtxes and the midend shouldn't be passing any such rtxes either. This

[PATCH][ARM] Use snprintf rather than sprintf where possible

2015-11-09 Thread Kyrill Tkachov
Hi all, Judging by the thread at https://gcc.gnu.org/ml/gcc-patches/2015-10/msg01912.html I looked at replacing calls to sprintf with calls to snprintf in the arm backend. We use them a lot to print assembly mnemonics into static char buffers. This patch replaces the calls with snprintf and add

[AARCH64] Adding constant folding for __builtin_fmulx* with scalar 32 and 64 bit arguments

2015-11-09 Thread Bilyan Borisov
This patch adds an extension to aarch64_gimple_fold_builtin () that does constant folding on __builtin_fmulx* calls for 32 and 64 bit floating point scalar modes. We fold when both arguments are constant, as well as when only one is. The special cases of 0*inf, -0*inf, 0*-inf, and -0*-inf are also

Re: [patch] Fix PR middle-end/68251

2015-11-09 Thread Richard Biener
On Mon, Nov 9, 2015 at 12:13 PM, Eric Botcazou wrote: > Hi, > > I don't understand how this didn't show up sooner given the amount of testing, > but there is a nasty overloading for the new REF_REVERSE_STORAGE_ORDER flag: > > #define REF_REVERSE_STORAGE_ORDER(NODE) \ >(TREE_CHECK2 (NODE, BIT_F

Re: [vec-cmp, patch 3/6] Vectorize comparison

2015-11-09 Thread Ilya Enkovich
On 26 Oct 16:09, Richard Biener wrote: > On Wed, Oct 14, 2015 at 6:12 PM, Ilya Enkovich wrote: > > + > > + ops.release (); > > + vec_defs.release (); > > No need to release auto_vec<>s at the end of scope explicitely. Fixed > > > + vec_compare = build2 (code, ma

Re: [patch] Fix PR middle-end/68251

2015-11-09 Thread Eric Botcazou
> Looks good to me. Thanks. > I wonder where you store the info on TARGET_MEM_REFs though? Or > is IVOPTs prohibited from messing with such refs (pessmizing them)? Yes, the latter: * tree-ssa-loop-ivopts.c (may_be_nonaddressable_p) : New. Return true if reverse storage order.

Re: [vec-cmp, patch 4/6] Support vector mask invariants

2015-11-09 Thread Ilya Enkovich
On 26 Oct 16:21, Richard Biener wrote: > On Wed, Oct 14, 2015 at 6:13 PM, Ilya Enkovich wrote: > > - val = fold_unary (VIEW_CONVERT_EXPR, TREE_TYPE (type), val); > > + { > > + /* Can't use VIEW_CONVERT_EXPR for booleans because > > +of possibly diffe

Re: [PATCH] Fix memory leaks and use a pool_allocator

2015-11-09 Thread Richard Biener
On Mon, Nov 9, 2015 at 12:22 PM, Martin Liška wrote: > Hi. > > This is follow-up of changes that Richi started on Friday. > > Patch can bootstrap on x86_64-linux-pc and regression tests are running. > > Ready for trunk? * tree-ssa-dom.c (free_edge_info): Make the function extern. ...

[PATCH][optabs][ifcvt][1/3] Define negcc, notcc optabs

2015-11-09 Thread Kyrill Tkachov
Hi all, This is a rebase of the patch I posted at: https://gcc.gnu.org/ml/gcc-patches/2015-09/msg00154.html The patch has been ok'd by Jeff but I wanted to hold off committing it until my fixes for the ifcvt regressions on sparc and x86_64 were fixed. The rebase conflicts were due to Richard's

GCC 6 Status Report (2015-11-09)

2015-11-09 Thread Richard Biener
Status == We've pushed back the switch to Stage 3 to the end of Saturday, Nov 14th. This is to allow smooth draining of review queues. Quality Data Priority # Change from last report --- --- P14+ 2 P2

Re: [PATCH] Fix memory leaks and use a pool_allocator

2015-11-09 Thread Trevor Saunders
On Mon, Nov 09, 2015 at 01:11:48PM +0100, Richard Biener wrote: > On Mon, Nov 9, 2015 at 12:22 PM, Martin Liška wrote: > > Hi. > > > > This is follow-up of changes that Richi started on Friday. > > > > Patch can bootstrap on x86_64-linux-pc and regression tests are running. > > > > Ready for trunk

Re: [PATCH] S/390: Fix warning in "*movstr" pattern.

2015-11-09 Thread Andreas Krebbel
On 11/04/2015 02:39 AM, Dominik Vogt wrote: > On Tue, Nov 03, 2015 at 06:47:28PM +0100, Ulrich Weigand wrote: >> Dominik Vogt wrote: >> >>> @@ -2936,7 +2936,7 @@ >>> (set (mem:BLK (match_operand:P 1 "register_operand" "0")) >>> (mem:BLK (match_operand:P 3 "register_operand" "2"))) >>> (

[patch] backport PIE support for FreeBSD to gcc-49

2015-11-09 Thread Andreas Tobler
Hi, any objections that I apply this patch to gcc-4.9? It is FreeBSD only. TIA, Andreas 2015-11-09 Andreas Tobler Backport from mainline 2015-05-18 Andreas Tobler * config/freebsd-spec.h (FBSD_STARTFILE_SPEC): Add the bits to build pie executables.

[patch] backport remove of soft float for FreeBSD powerpc for gcc-4.9

2015-11-09 Thread Andreas Tobler
Hi all, any objections when I apply the below patch to gcc-4.9? TIA, Andreas 2015-11-09 Andreas Tobler Backport from mainline 2015-03-04 Andreas Tobler * config/rs6000/t-freebsd64: Remove 32-bit soft-float multilibs. Index: gcc/config/rs6000/t-freebsd64 ==

[PATCH] Improve BB vectorization dependence analysis

2015-11-09 Thread Richard Biener
Currently BB vectorization computes all dependences inside a BB region and fails all vectorization if it cannot handle some of them. This is obviously not needed - BB vectorization can restrict the dependence tests to those that are needed to apply the load/store motion effectively performed by t

Re: [PATCH 1/2] s/390: Implement "target" attribute.

2015-11-09 Thread Andreas Krebbel
On 11/02/2015 09:44 AM, Dominik Vogt wrote: > (@Uli: I'd like to hear your opinion on this issue. > Original message: > https://gcc.gnu.org/ml/gcc-patches/2015-10/msg03403.html). > > On Fri, Oct 30, 2015 at 03:09:39PM +0100, Andreas Krebbel wrote: >> Why do we need x_s390_arch_specified and x_s390

Re: [PATCH] Fix memory leaks and use a pool_allocator

2015-11-09 Thread Martin Liška
On 11/09/2015 01:11 PM, Richard Biener wrote: > On Mon, Nov 9, 2015 at 12:22 PM, Martin Liška wrote: >> Hi. >> >> This is follow-up of changes that Richi started on Friday. >> >> Patch can bootstrap on x86_64-linux-pc and regression tests are running. >> >> Ready for trunk? > > * tree-ssa

[PATCH] 02/N Fix memory leaks in IPA

2015-11-09 Thread Martin Liška
Hi. Following changes were consulted with Martin Jambor to properly release memory in IPA. It fixes leaks which popped up in tramp3d with -O2. Bootstrap and regression tests have been running. Ready after it finishes? Thanks, Martin >From 85b63f738030dd7a901c228ba76e24f820d31c5d Mon Sep 17 00:00

Re: [AArch64][PATCH 6/7] Add NEON intrinsics vqrdmlah and vqrdmlsh.

2015-11-09 Thread Christophe Lyon
On 30 October 2015 at 16:52, Matthew Wahab wrote: > On 30/10/15 12:51, Christophe Lyon wrote: >> >> On 23 October 2015 at 14:26, Matthew Wahab >> wrote: >>> >>> The ARMv8.1 architecture extension adds two Adv.SIMD instructions, >>> sqrdmlah and sqrdmlsh. This patch adds the NEON intrinsics vqrdml

RE: [RFC][PATCH] Preferred rename register in regrename pass

2015-11-09 Thread Robert Suchanek
Hi Bernd, Sorry for late reply. The updated patch was bootstrapped on x86_64-unknown-linux-gnu and cross tested on mips-img-linux-gnu using r229786. The results below were generated for CSiBE benchmark and the numbers in columns express bytes in format 'net (gain/loss)' to show the difference wi

Re: [PATCH 4b/4] [ARM] PR63870 Remove error for invalid lane numbers

2015-11-09 Thread Ramana Radhakrishnan
On 08/11/15 00:26, charles.bay...@linaro.org wrote: > From: Charles Baylis > > Charles Baylis > > * config/arm/neon.md (neon_vld1_lane): Remove error for invalid > lane number. > (neon_vst1_lane): Likewise. > (neon_vld2_lane): Likewise. > (neon_vst2_lane): Lik

Re: OpenACC Firstprivate

2015-11-09 Thread Jakub Jelinek
On Sat, Nov 07, 2015 at 08:50:28AM -0500, Nathan Sidwell wrote: > Index: gcc/gimplify.c > === > --- gcc/gimplify.c(revision 229892) > +++ gcc/gimplify.c(working copy) > @@ -108,9 +108,15 @@ enum omp_region_type >/* Data reg

Re: [AArch64][PATCH 6/7] Add NEON intrinsics vqrdmlah and vqrdmlsh.

2015-11-09 Thread Matthew Wahab
On 09/11/15 13:31, Christophe Lyon wrote: On 30 October 2015 at 16:52, Matthew Wahab wrote: On 30/10/15 12:51, Christophe Lyon wrote: On 23 October 2015 at 14:26, Matthew Wahab wrote: The ARMv8.1 architecture extension adds two Adv.SIMD instructions, sqrdmlah and sqrdmlsh. This patch adds

Re: [vec-cmp, patch 2/6] Vectorization factor computation

2015-11-09 Thread Ilya Enkovich
2015-10-20 16:45 GMT+03:00 Richard Biener : > On Wed, Oct 14, 2015 at 1:21 PM, Ilya Enkovich wrote: >> 2015-10-13 16:37 GMT+03:00 Richard Biener : >>> On Thu, Oct 8, 2015 at 4:59 PM, Ilya Enkovich >>> wrote: Hi, This patch handles statements with boolean result in vectorization fa

Re: OpenACC Firstprivate

2015-11-09 Thread Nathan Sidwell
On 11/09/15 08:46, Jakub Jelinek wrote: On Sat, Nov 07, 2015 at 08:50:28AM -0500, Nathan Sidwell wrote: Index: gcc/gimplify.c === If you want to switch to hexadecimal, you should change all values in the enum to hexadecimal for

Re: [PATCH] Use signed boolean type for boolean vectors

2015-11-09 Thread Ilya Enkovich
On 03 Nov 14:42, Richard Biener wrote: > On Wed, Oct 28, 2015 at 4:30 PM, Ilya Enkovich wrote: > > 2015-10-28 18:21 GMT+03:00 Richard Biener : > >> On Wed, Oct 28, 2015 at 2:13 PM, Ilya Enkovich > >> wrote: > >>> Hi, > >>> > >>> Testing boolean vector conversions I found several runtime regressi

Re: OpenACC Firstprivate

2015-11-09 Thread Nathan Sidwell
On 11/09/15 08:59, Nathan Sidwell wrote: On 11/09/15 08:46, Jakub Jelinek wrote: On Sat, Nov 07, 2015 at 08:50:28AM -0500, Nathan Sidwell wrote: Say int arr[64]; // initialize arr #pragma acc data copyin (arr) { // modify arr on the host # pragma acc parallel firstprivate (arr)

Re: RFC: C++ delayed folding merge

2015-11-09 Thread Jason Merrill
On 11/09/2015 04:24 AM, Eric Botcazou wrote: One question: The branch changes 'convert' to not fold its result, and it's not clear to me whether that's part of the expected behavior of a front end 'convert' function or not. I don't think that you should change the behavior for front-ends that h

Re: OpenACC Firstprivate

2015-11-09 Thread Jakub Jelinek
On Mon, Nov 09, 2015 at 08:59:15AM -0500, Nathan Sidwell wrote: > >This I'm afraid performs often two copies rather than just one (one to copy > >the host value to the present_copyin mapped value, another one in the > >region), > > I don't think that can be avoided. The host doesn't have control

Re: [Patch AArch64] Switch constant pools to separate rodata sections.

2015-11-09 Thread Ramana Radhakrishnan
On 08/11/15 11:42, Andreas Schwab wrote: > This is causing a bootstrap comparison failure in gcc/go/gogo.o. I'm looking into this - this is now PR68256. regards Ramana > > Andreas. >

Re: [PATCH] Fix memory leaks and use a pool_allocator

2015-11-09 Thread Richard Biener
On Mon, Nov 9, 2015 at 2:26 PM, Martin Liška wrote: > On 11/09/2015 01:11 PM, Richard Biener wrote: >> On Mon, Nov 9, 2015 at 12:22 PM, Martin Liška wrote: >>> Hi. >>> >>> This is follow-up of changes that Richi started on Friday. >>> >>> Patch can bootstrap on x86_64-linux-pc and regression test

Re: [PATCH] 02/N Fix memory leaks in IPA

2015-11-09 Thread Richard Biener
On Mon, Nov 9, 2015 at 2:29 PM, Martin Liška wrote: > Hi. > > Following changes were consulted with Martin Jambor to properly release > memory in IPA. It fixes leaks which popped up in tramp3d with -O2. > > Bootstrap and regression tests have been running. > > Ready after it finishes? Ok. Richar

Re: [PATCH] Use signed boolean type for boolean vectors

2015-11-09 Thread Richard Biener
On Mon, Nov 9, 2015 at 3:03 PM, Ilya Enkovich wrote: > On 03 Nov 14:42, Richard Biener wrote: >> On Wed, Oct 28, 2015 at 4:30 PM, Ilya Enkovich >> wrote: >> > 2015-10-28 18:21 GMT+03:00 Richard Biener : >> >> On Wed, Oct 28, 2015 at 2:13 PM, Ilya Enkovich >> >> wrote: >> >>> Hi, >> >>> >> >>>

Re: [vec-cmp, patch 2/6] Vectorization factor computation

2015-11-09 Thread Richard Biener
On Mon, Nov 9, 2015 at 2:54 PM, Ilya Enkovich wrote: > 2015-10-20 16:45 GMT+03:00 Richard Biener : >> On Wed, Oct 14, 2015 at 1:21 PM, Ilya Enkovich >> wrote: >>> 2015-10-13 16:37 GMT+03:00 Richard Biener : On Thu, Oct 8, 2015 at 4:59 PM, Ilya Enkovich wrote: > Hi, > > Th

Re: [vec-cmp, patch 3/6] Vectorize comparison

2015-11-09 Thread Richard Biener
On Mon, Nov 9, 2015 at 1:07 PM, Ilya Enkovich wrote: > On 26 Oct 16:09, Richard Biener wrote: >> On Wed, Oct 14, 2015 at 6:12 PM, Ilya Enkovich >> wrote: >> > + >> > + ops.release (); >> > + vec_defs.release (); >> >> No need to release auto_vec<>s at the end of scope exp

Re: [vec-cmp, patch 4/6] Support vector mask invariants

2015-11-09 Thread Richard Biener
On Mon, Nov 9, 2015 at 1:11 PM, Ilya Enkovich wrote: > On 26 Oct 16:21, Richard Biener wrote: >> On Wed, Oct 14, 2015 at 6:13 PM, Ilya Enkovich >> wrote: >> > - val = fold_unary (VIEW_CONVERT_EXPR, TREE_TYPE (type), val); >> > + { >> > + /* Can't use VIEW_CONVERT_

Re: Extend tree-call-cdce to calls whose result is used

2015-11-09 Thread Michael Matz
Hi, On Sat, 7 Nov 2015, Richard Sandiford wrote: > For -fmath-errno, builtins.c currently expands calls to sqrt to: > > y = sqrt_optab (x); > if (y != y) > [ sqrt (x); or errno = EDOM; ] > > - the call to sqrt is protected by the result of the optab rather > than the input. It

[PATCH] Fix PR68248

2015-11-09 Thread Richard Biener
Bootstrapped and tested on x86_64-unknown-linux-gnu, applied. Richard. 2015-11-09 Richard Biener PR tree-optimization/68248 * tree-vect-generic.c (expand_vector_operations_1): Handle scalar rhs2. * gcc.dg/torture/pr68248.c: New testcase. Index: gcc/tree-vect

Re: OpenACC Firstprivate

2015-11-09 Thread Nathan Sidwell
On 11/09/15 09:10, Jakub Jelinek wrote: On Mon, Nov 09, 2015 at 08:59:15AM -0500, Nathan Sidwell wrote: This I'm afraid performs often two copies rather than just one (one to copy the host value to the present_copyin mapped value, another one in the region), I don't think that can be avoided.

Re: [PATCH v2 11/13] Test case for conversion from __seg_tls:0

2015-11-09 Thread Richard Biener
On Tue, Oct 20, 2015 at 11:27 PM, Richard Henderson wrote: > --- > gcc/testsuite/gcc.target/i386/addr-space-3.c | 10 ++ > 1 file changed, 10 insertions(+) > create mode 100644 gcc/testsuite/gcc.target/i386/addr-space-3.c > > diff --git a/gcc/testsuite/gcc.target/i386/addr-space-3.c > b

Re: Add null identifiers to genmatch

2015-11-09 Thread Richard Biener
On Mon, Nov 9, 2015 at 12:17 AM, Jeff Law wrote: > On 11/07/2015 07:31 AM, Pedro Alves wrote: >> >> Hi Richard, >> >> Passerby comment below. >> >> On 11/07/2015 01:21 PM, Richard Sandiford wrote: >>> >>> -/* Lookup the identifier ID. */ >>> +/* Lookup the identifier ID. Allow "null" if ALLOW_NU

Re: Add a combined_fn enum

2015-11-09 Thread Richard Sandiford
Bernd Schmidt writes: > On 11/09/2015 11:24 AM, Richard Sandiford wrote: >> Bernd Schmidt writes: >>> I see it's already acked, but have you considered just doing away with >>> the builtin/internal function distinction? >> >> I think they're too different to be done away with entirely. built-in

Re: [PATCH] PR/67682, break SLP groups up if only some elements match

2015-11-09 Thread Alan Lawrence
On 06/11/15 12:55, Richard Biener wrote: > >> + /* GROUP_GAP of the first group now has to skip over the second group >> too. */ >> + GROUP_GAP (first_vinfo) += group2_size; > > Please add a MSG_NOTE debug printf stating that we split the group and > at which element. Done. > I think you want

Re: [PATCH] Minor refactoring in tree-ssanames.c & freelists verifier

2015-11-09 Thread Michael Matz
Hi, On Mon, 9 Nov 2015, Jeff Law wrote: +verify_ssaname_freelists (struct function *fun) +{ + /* Do nothing if we are in RTL format. */ + basic_block bb; + FOR_EACH_BB_FN (bb, fun) +{ + if (bb->flags & BB_RTL) + return; +} gimple_in_ssa_p (fun); + /* Then note the op

Re: [Patch] Change to argument promotion in fixed conversion library calls

2015-11-09 Thread Richard Biener
On Fri, Nov 6, 2015 at 8:14 PM, Bernd Schmidt wrote: > On 11/06/2015 08:04 PM, Steve Ellcey wrote: >> >> When I made this change I had one regression in the GCC testsuite >> (gcc.dg/fixed-point/convert-sat.c). I tracked this down to the >> fact that emit_library_call_value_1 does not do any argu

Re: Extend tree-call-cdce to calls whose result is used

2015-11-09 Thread Richard Sandiford
Michael Matz writes: > On Sat, 7 Nov 2015, Richard Sandiford wrote: >> For -fmath-errno, builtins.c currently expands calls to sqrt to: >> >> y = sqrt_optab (x); >> if (y != y) >> [ sqrt (x); or errno = EDOM; ] >> >> - the call to sqrt is protected by the result of the optab rather

Re: [PATCH PR52272]Be smart when adding iv candidates

2015-11-09 Thread Bernd Schmidt
On 11/08/2015 10:11 AM, Richard Biener wrote: On November 8, 2015 3:58:57 AM GMT+01:00, "Bin.Cheng" wrote: +inline bool +iv_common_cand_hasher::equal (const iv_common_cand *ccand1, + const iv_common_cand *ccand2) +{ + return ccand1->hash == ccand2->hash +&& op

Re: Add a combined_fn enum

2015-11-09 Thread Bernd Schmidt
On 11/09/2015 03:57 PM, Richard Sandiford wrote: I'm not sure what you mean by "fix" though. I don't think we can change any of the constraints above. I don't see why they couldn't be relaxed. What's stopping us from defining some builtins independently of the frontends, and don't all langu

Re: [PATCH][AArch64] PR target/68129: Define TARGET_SUPPORTS_WIDE_INT

2015-11-09 Thread Marcus Shawcroft
On 9 November 2015 at 11:32, Kyrill Tkachov wrote: > 2015-11-09 Kyrylo Tkachov > > PR target/68129 > * config/aarch64/aarch64.h (TARGET_SUPPORTS_WIDE_INT): Define to 1. > * config/aarch64/aarch64.c (aarch64_print_operand, CONST_DOUBLE): > Delete VOIDmode case. Assert that mode

[PATCH series, 16] Use parloops to parallelize oacc kernels regions

2015-11-09 Thread Tom de Vries
Hi, this patch series for stage1 trunk adds support to: - parallelize oacc kernels regions using parloops, and - map the loops onto the oacc gang dimension. The patch series contains these patches: 1 Insert new exit block only when needed in transform_to_exit_first_loop_alt 2

Re: [PATCH v3 1/2] [PR debug/67192] Fix C loops' back-jump location

2015-11-09 Thread Andreas Krebbel
On 11/04/2015 05:17 PM, Andreas Arnez wrote: > Since r223098 ("Implement -Wmisleading-indentation") the backward-jump > generated for a C while- or for-loop can get the wrong line number. > This is because the check for misleading indentation peeks ahead one > token, advancing input_location to aft

Re: [PATCH v3 2/2] [PR debug/67192] Further fix C loops' back-jump location

2015-11-09 Thread Andreas Krebbel
On 11/04/2015 05:18 PM, Andreas Arnez wrote: > After parsing an unconditional "while"- or "for"-loop, the C front-end > generates a backward-goto statement and implicitly sets its location to > the current input_location. But in some cases the parser peeks ahead > first, such that input_location a

[PATCH, 1/16] Insert new exit block only when needed in transform_to_exit_first_loop_alt

2015-11-09 Thread Tom de Vries
On 09/11/15 16:35, Tom de Vries wrote: Hi, this patch series for stage1 trunk adds support to: - parallelize oacc kernels regions using parloops, and - map the loops onto the oacc gang dimension. The patch series contains these patches: 1Insert new exit block only when needed in

Re: [PATCH][AArch64] PR target/68129: Define TARGET_SUPPORTS_WIDE_INT

2015-11-09 Thread Kyrill Tkachov
On 09/11/15 15:34, Marcus Shawcroft wrote: On 9 November 2015 at 11:32, Kyrill Tkachov wrote: 2015-11-09 Kyrylo Tkachov PR target/68129 * config/aarch64/aarch64.h (TARGET_SUPPORTS_WIDE_INT): Define to 1. * config/aarch64/aarch64.c (aarch64_print_operand, CONST_DOUBLE):

[PATCH, 2/16] Make create_parallel_loop return void

2015-11-09 Thread Tom de Vries
On 09/11/15 16:35, Tom de Vries wrote: Hi, this patch series for stage1 trunk adds support to: - parallelize oacc kernels regions using parloops, and - map the loops onto the oacc gang dimension. The patch series contains these patches: 1Insert new exit block only when needed in

Re: [PATCH][AArch64] PR target/68129: Define TARGET_SUPPORTS_WIDE_INT

2015-11-09 Thread Marcus Shawcroft
On 9 November 2015 at 15:45, Kyrill Tkachov wrote: > > On 09/11/15 15:34, Marcus Shawcroft wrote: >> >> On 9 November 2015 at 11:32, Kyrill Tkachov >> wrote: >> >>> 2015-11-09 Kyrylo Tkachov >>> >>> PR target/68129 >>> * config/aarch64/aarch64.h (TARGET_SUPPORTS_WIDE_INT): Define to

Re: [PATCH], Add power9 support to GCC, patch #2 (add modulus instructions)

2015-11-09 Thread Segher Boessenkool
Hi, On Sun, Nov 08, 2015 at 07:36:16PM -0500, Michael Meissner wrote: > [gcc/testsuite] > * lib/target-supports.exp (check_p9vector_hw_available): Add > checks for power9 availability. > (check_effective_target_powerpc_p9vector_ok): Likewise. It's probably better not to use this

Re: [PATCH][AArch64][cleanup] Remove uses of CONST_DOUBLE_HIGH, CONST_DOUBLE_LOW

2015-11-09 Thread Marcus Shawcroft
On 9 November 2015 at 11:34, Kyrill Tkachov wrote: > * config/aarch64/aarch64.c (aarch64_simd_valid_immediate): > Remove integer CONST_DOUBLE handling. It should never occur. OK /Marcus

[PATCH, 3/16] Ignore reduction clause on kernels directive

2015-11-09 Thread Tom de Vries
On 09/11/15 16:35, Tom de Vries wrote: Hi, this patch series for stage1 trunk adds support to: - parallelize oacc kernels regions using parloops, and - map the loops onto the oacc gang dimension. The patch series contains these patches: 1Insert new exit block only when needed in

Re: Add a combined_fn enum

2015-11-09 Thread Richard Sandiford
Bernd Schmidt writes: > On 11/09/2015 03:57 PM, Richard Sandiford wrote: > >> I'm not sure what you mean by "fix" though. I don't think we can change >> any of the constraints above. > > I don't see why they couldn't be relaxed. What's stopping us from > defining some builtins independently of t

Re: [PATCH], Add power9 support to GCC, patch #3 (scalar count trailing zeros)

2015-11-09 Thread Segher Boessenkool
On Sun, Nov 08, 2015 at 07:37:53PM -0500, Michael Meissner wrote: > This patch adds support for scalar count trailing zeros instruction that is > being added to ISA 3.0 (power9). I bet you should change CTZ_DEFINED_VALUE_AT_ZERO as well. > +(define_insn "ctz2_hw" > + [(set (match_operand:GPR 0 "

Re: [OpenACC] declare directive

2015-11-09 Thread James Norris
Jakub, This is an update of the patch from: https://gcc.gnu.org/ml/gcc-patches/2015-11/msg00893.html. There was an unused variable in c/c-parser.c that was removed. I've included the ChangeLog as a convenience, but nothing was changed in the file. Thanks! Jim 2015-XX-XX James Norris

[PATCH, 4/16] Implement -foffload-alias

2015-11-09 Thread Tom de Vries
On 09/11/15 16:35, Tom de Vries wrote: Hi, this patch series for stage1 trunk adds support to: - parallelize oacc kernels regions using parloops, and - map the loops onto the oacc gang dimension. The patch series contains these patches: 1Insert new exit block only when needed in

Re: [PATCH], Add power9 support to GCC, patch #1 (revised)

2015-11-09 Thread David Edelsohn
On Sun, Nov 8, 2015 at 4:33 PM, Michael Meissner wrote: > This is patch #1 that I revised. I changed -mfusion-toc to -mtoc-fusion. I > changed the references to ISA 2.08 to 3.0. I added two new debug switches for > code in future patches that in undergoing development and is not ready to be >

Re: [PATCH], Add power9 support to GCC, patch #2 (add modulus instructions)

2015-11-09 Thread David Edelsohn
On Sun, Nov 8, 2015 at 4:36 PM, Michael Meissner wrote: > This is patch #2. It adds support for the new modulus instructions that are > being added in ISA 3.0 (power9): > > I have built this patch (along with patches #3 and #4) with a bootstrap build > on a power8 little endian system. There wer

[PATCH 0/6] Automatically use vector optabs

2015-11-09 Thread Richard Sandiford
The main goal of this series is to allow functions to be vectorised simply by defining the associated optab. At the moment you can get a scalar square root instruction by defining an md pattern like sqrtdf2. But if you want to have vectorised sqrt, you need to have a target- specific C-level built

Re: [OpenACC] declare directive

2015-11-09 Thread Jakub Jelinek
On Mon, Nov 09, 2015 at 10:01:32AM -0600, James Norris wrote: > + if (lookup_attribute ("omp declare target", DECL_ATTRIBUTES (decl))) Here you only look up "omp declare target", not "omp declare target link". So, what happens if you mix that (once in some copy clause, once in link), or menti

[PATCH 1/6] Use IFN_SQRT in tree-vect-patterns.c

2015-11-09 Thread Richard Sandiford
In practice all targets that can vectorise sqrt define the appropriate sqrt2 optab. The only case where this isn't immediately obvious is the libmass support in rs6000.c, but Mike Meissner said that it shouldn't be exercised for sqrt. This patch therefore uses the internal function interface inst

  1   2   3   >