Re: PATC: Round up the SSE register save area only if needed

2015-10-08 Thread Uros Bizjak
On Thu, Oct 8, 2015 at 8:29 PM, H.J. Lu wrote: > There is is no point to round up the SSE register save area to 16 bytes if > the incoming stack boundary is less than 16 bytes. > > OK for trunk? OK, with the improved comment: /* The only ABI that has saved SSE registers (Win64) also has a

Re: [PATCH v6][aarch64] Implemented reciprocal square root (rsqrt) estimation in -ffast-math

2015-10-08 Thread Evandro Menezes
LGTM -- Evandro Menezes On 01/02/1970 09:27 PM, Benedikt Huber wrote: This sixth revision of the patch: * Cleans up style issues. * Makes test conform to standards. Ok for check in. Benedikt Huber (1): 2015-10-02 Benedikt Huber Philipp Tomsich gcc/ChangeLog

Re: [PATCH] PR66870 PowerPC64 Enable gold linker with split stack

2015-10-08 Thread Lynn A. Boger
I think my original fix with linux.h doing the #undef on TARGET_CAN_SPLIT_STACK_64BIT is the right fix at least for powerpc-linux-gnu 32 bit only. It works for powerpc-linux-gnu without multilib and doesn't break powerpc64-linux-gnu or powerpc64le-linux-gnu. Can you tell me how you are config

Re: [PATCH] New attribute to create target clones

2015-10-08 Thread Jeff Law
On 09/24/2015 04:28 PM, Evgeny Stupachenko wrote: I've fixed ICE and review issues. x86 make check and bootstrap passed. Thanks, Evgeny ChangeLog 2015-09-25 Evgeny Stupachenko gcc/ * Makefile.in (OBJS): Add multiple_target.o. * multiple_target.c (make_attribute): New.

[Patch] PowerPC IEEE 128-bit patch #7 (revised #2)

2015-10-08 Thread Michael Meissner
This is the revised patch #7 for the IEEE 128-bit software floating point support in the PowerPC. I have tested this on big endian power7 (both 32/64 bit) and little endian power8 with no regressions. Is this ok to install in the trunk? This patch should allow __float128 support on VSX systems, bu

Re: [PATCH][committed] Fix PR67652: wrong sizeof calculation in liboffloadmic

2015-10-08 Thread Ilya Verbin
On Mon, Sep 28, 2015 at 18:15:14 +0200, Jakub Jelinek wrote: > > -char * env_var = (char*) > > malloc(sizeof("COI_DMA_CHANNEL_COUNT=2" + 1)); > > +char * env_var = (char*) > > malloc(sizeof("COI_DMA_CHANNEL_COUNT=2")); > > sprintf(env_var, "COI_DMA_CHANNEL_COU

Re: [PATCH] New attribute to create target clones

2015-10-08 Thread Jan Hubicka
> Sorry this has taken so long to come back to... As I mentioned a > couple months ago, I'd hoped Jan would chime in on the IPA/symtab > requirements. But that didn't happen. Sorry for that. I had bit too many real life things this summer and I am still trying to catch up. > > > SO I went bac

Re: FW: [PATCH] Target hook for disabling the delay slot filler.

2015-10-08 Thread Jeff Law
On 09/18/2015 05:10 AM, Simon Dardis wrote: Are you trying to say that you have the option as to what kind of branch to use? ie, "ordinary", presumably without a delay slot or one with a delay slot? Is the "ordinary" actually just a nullified delay slot or some form of likely/not likely stati

Re: [PATCH] New attribute to create target clones

2015-10-08 Thread Jeff Law
On 10/08/2015 01:23 PM, Jan Hubicka wrote: Sorry this has taken so long to come back to... As I mentioned a couple months ago, I'd hoped Jan would chime in on the IPA/symtab requirements. But that didn't happen. Sorry for that. I had bit too many real life things this summer and I am still t

Re: [PATCH] New attribute to create target clones

2015-10-08 Thread Evgeny Stupachenko
On Thu, Oct 8, 2015 at 10:00 PM, Jeff Law wrote: > On 09/24/2015 04:28 PM, Evgeny Stupachenko wrote: >> >> I've fixed ICE and review issues. >> x86 make check and bootstrap passed. >> >> Thanks, >> Evgeny >> >> ChangeLog >> >> 2015-09-25 Evgeny Stupachenko >> >> gcc/ >> * Makefile.in (OB

[PATCH] [2/n] Fix minor SSA_NAME leaks

2015-10-08 Thread Jeff Law
Another fairly obvious leak, this time in tree-ssa-dse.c where we again call gsi_remove without an associated release_defs. The only thing of note here is this time we have virtual operations on the statement. So before we call gsi_remove and release_defs, we have to call unlink_stmt_vdef to

Re: Do not use TYPE_CANONICAL in useless_type_conversion

2015-10-08 Thread Jan Hubicka
> On Thu, 8 Oct 2015, Jan Hubicka wrote: > > > > > > > && TREE_CODE (outer_type) == OFFSET_TYPE > > > > > > Ok with those changes. > > > > Thank you! I commited the patch. > > At a hike today it appeared to me that for ipa-icf and other calling > > convetions > > checks we should not rely on u

Re: [PATCH] PR66870 PowerPC64 Enable gold linker with split stack

2015-10-08 Thread Matthias Klose
On 08.10.2015 20:56, Lynn A. Boger wrote: I think my original fix with linux.h doing the #undef on TARGET_CAN_SPLIT_STACK_64BIT is the right fix at least for powerpc-linux-gnu 32 bit only. It works for powerpc-linux-gnu without multilib and doesn't break powerpc64-linux-gnu or powerpc64le-linux-

[PATCH] [3/n] Fix minor SSA_NAME leaks

2015-10-08 Thread Jeff Law
And other minor leak. This time in tree-stdarg. Unlike other cases, we're dropping just the virtual definition, other definitions on the statement need to be preserved (they're going to be re-used). Additionally, this one is missing the call to unlink_stmt_vdef. Like other cases, I've got a

Re: [Patch] PowerPC IEEE 128-bit patch #7 (revised #2)

2015-10-08 Thread Joseph Myers
Question: what happens if you mix __float128 and __ibm128 in an arithmetic or conditional expression? __float128 a; __ibm128 b; int x; /* ... */ a + b; x ? a : b; (And likewise if one or both are the corresponding complex types.) As I suggested in

Re: [PATCH] New attribute to create target clones

2015-10-08 Thread Jan Hubicka
> > > >Yes, here you have different names for different variants of the function > >body. Basically this pass takes ctarget attribute and creates bunch of > >verisons > >of the functions and assigns them the proper target attributes, right? > Right. Given a single function in the source tree with

Re: Do not use TYPE_CANONICAL in useless_type_conversion

2015-10-08 Thread Jan Hubicka
> Eric Botcazou writes: > > >> Thank you! I commited the patch. > > > > It breaks the Ada build on x86-64 though: > > Also on ia64: Sorry to hear that :( > > /usr/local/gcc/test/Build/./prev-gcc/xgcc > -B/usr/local/gcc/test/Build/./prev-gcc/ -B/usr/ia64-suse-linux/bin/ > -B/usr/ia64-suse-lin

[PATCH] [4/n] Fix minor SSA_NAME leaks

2015-10-08 Thread Jeff Law
Another, this time in tree-ssa-loop-im. In this case it's just a missing release_defs for a statement we know won't have virtual operands. As with the others, I've got a reduced testcase and will be trying to figure out how to best utilize it. Bootstrapped & regression tested on x86_64-linux

Re: [PATCH] [4/n] Fix minor SSA_NAME leaks

2015-10-08 Thread Jeff Law
On 10/08/2015 05:18 PM, Jeff Law wrote: Another, this time in tree-ssa-loop-im. In this case it's just a missing release_defs for a statement we know won't have virtual operands. As with the others, I've got a reduced testcase and will be trying to figure out how to best utilize it. Bootstrapp

Fix use of availability in ipa-icf

2015-10-08 Thread Jan Hubicka
Hi, this is a bug I noticed while reading the code. We can not assume interposable objects to be equivalent unless they are actually the same symbols. Bootstrapped/regtested x86_64-linux, comitted. Honza * ipa-icf.c (sem_item::compare_symbol_references): Fix use of availability.

Re: Do not use TYPE_CANONICAL in useless_type_conversion

2015-10-08 Thread Jan Hubicka
> > Index: expr.c > === > --- expr.c(revision 228604) > +++ expr.c(working copy) > @@ -6703,7 +6704,7 @@ store_field (rtx target, HOST_WIDE_INT b > emit_group_store (temp_target, temp, TREE_TYPE (exp), size); >

Re: [RFA 1/2]: Don't ignore target_header_dir when deciding inhibit_libc

2015-10-08 Thread Hans-Peter Nilsson
> From: Ulrich Weigand > Date: Thu, 8 Oct 2015 18:52:22 +0200 > Hans-Peter Nilsson wrote: > > > Let me ask you right back: after an installation, should > > installation of a newer gcc *not* automatically pick up the > > header files installed (copied to sys-include) by the previous > > installa

Re: [RFC, Patch]: Optimized changes in the register used inside loop for LICM and IVOPTS.

2015-10-08 Thread Bin.Cheng
On Thu, Oct 8, 2015 at 1:53 PM, Ajit Kumar Agarwal wrote: > > > -Original Message- > From: Bin.Cheng [mailto:amker.ch...@gmail.com] > Sent: Thursday, October 08, 2015 10:29 AM > To: Ajit Kumar Agarwal > Cc: GCC Patches; Vinod Kathail; Shail Aditya Gupta; Vidhumouli Hunsigida; > Nagaraju M

[PATCH] c/67882 - improve -Warray-bounds for invalid offsetof

2015-10-08 Thread Martin Sebor
Gcc attempts to diagnose invalid offsetof expressions whose member designator is an array element with an out-of-bounds index. The logic in the function that does this detection is incomplete, leading to false negatives. Since the result of the expression in these cases can be surprising, this pat

[PATCH] c/67882 - improve -Warray-bounds for invalid offsetof

2015-10-08 Thread Martin Sebor
Gcc attempts to diagnose invalid offsetof expressions whose member designator is an array element with an out-of-bounds index. The logic in the function that does this detection is incomplete, leading to false negatives. Since the result of the expression in these cases can be surprising, this pat

Re: [PATCH] New attribute to create target clones

2015-10-08 Thread Jeff Law
On 10/08/2015 02:01 PM, Evgeny Stupachenko wrote: On Thu, Oct 8, 2015 at 10:00 PM, Jeff Law wrote: On 09/24/2015 04:28 PM, Evgeny Stupachenko wrote: I've fixed ICE and review issues. x86 make check and bootstrap passed. Thanks, Evgeny ChangeLog 2015-09-25 Evgeny Stupachenko gcc/

[PR67828] don't unswitch loops on undefined SSA values (was: Re: [PR64164] drop copyrename, integrate into expand)

2015-10-08 Thread Alexandre Oliva
This patch fixes a latent bug in loop unswitching exposed by the PR64164 changes. We would move a test out of a loop that might never have been executed, and that accessed an uninitialized variable. The uninitialized SSA name, due to uncprop, now gets coalescesd with other SSA names, expanding th

[PR67766] reorder return value copying from PARALLELs and CONCATs (was: Re: [PR64164] drop copyrename, integrate into expand)

2015-10-08 Thread Alexandre Oliva
This fixes fallout from the PR64164 expander revamp. On alpha, PARALLEL hard return values may be modeless, and this confuses the code that wants to copy the pseudo/s in the returned value to the return hard regs. It used to work because PARALLELs and CONCATs used to lead to DECL_RTL with the sam

[PATCH] [5/n] Fix minor SSA_NAME leaks

2015-10-08 Thread Jeff Law
This set of leaks is a bit more interesting. value-prof just blindly clears the vdefs on certain statements. Of course that results in a leaked SSA_NAME. The first of the three instances was the one I hit, the others were found by inspection. Like prior patches, I've kept a minimized test

Re: [nvptx] fix some c++ tests

2015-10-08 Thread Thomas Schwinge
Hi Nathan! Thanks for looking into this. When I reported this, , quite a lot of testcases had been failing -- with recent GCC trunk, the number is smaller (because of other middle end/optimization changes, I supp

<    1   2