Re: [patch match.pd c c++]: Ignore results of 'shorten_compare' and move missing patterns in match.pd

2015-09-11 Thread Kai Tietz
Ping. 2015-09-08 13:17 GMT+02:00 Kai Tietz : > Hi, > > This patch is the first part of obsoleting 'shorten_compare' function > for folding. > It adjusts the uses of 'shorten_compare' to ignore folding returned by > it, and adds > missing pattterns to match.pd to allow full bootstrap of C/C++ witho

Re: [PATCH] PR67401: Fix wrong code generated by expand_atomic_compare_and_swap

2015-09-11 Thread Bernd Schmidt
On 09/11/2015 01:21 AM, John David Anglin wrote: As noted in the PR, expand_atomic_compare_and_swap can generate wrong code when libcalls are emitted for the sync_compare_and_swap and the result comparison test. This is fixed by emitting a move insn to copy the result rtx of the sync_compare_a

Re: [libgo] Use stat_atim.go on Solaris 12+

2015-09-11 Thread Rainer Orth
Ian Lance Taylor writes: > On Wed, Aug 26, 2015 at 4:14 AM, Rainer Orth > wrote: >> Solaris 12 changes the stat_[amc]tim members of struct stat from >> timestruc_t to timespec_t for XPG7 compatiblity, thus breaking the libgo >> build. The following patch checks for this change and uses the comm

Re: [RFC AArch64][PR 63304] Handle literal pools for functions > 1 MiB in size.

2015-09-11 Thread Ramana Radhakrishnan
On Thu, Aug 27, 2015 at 03:07:30PM +0100, Marcus Shawcroft wrote: > On 27 July 2015 at 15:33, Ramana Radhakrishnan > wrote: > > > Ramana Radhakrishnan > > > > PR target/63304 > > * config/aarch64/aarch64.c (aarch64_expand_mov_immediate): Handle > > nopcrelative_literal

Re: [Patch] Teach RTL ifcvt to handle multiple simple set instructions

2015-09-11 Thread Kyrill Tkachov
On 10/09/15 22:11, Jeff Law wrote: On 09/10/2015 12:23 PM, Bernd Schmidt wrote: > No testcase provided, as currently I don't know of targets with a high > enough branch cost to actually trigger the optimisation. Hmm, so the code would not actually be used right now? In that case I'll leave

Re: [PATCH][RTL-ifcvt] PR rtl-optimization/67465: Handle pairs of complex+simple blocks and empty blocks more gracefully

2015-09-11 Thread Rainer Orth
Kyrill Tkachov writes: > On 10/09/15 12:43, Rainer Orth wrote: >> Hi Kyrill, >> >>> Rainer, could you please check that this patch still fixes the SPARC >>> regressions? >> unfortunately, it breaks sparc-sun-solaris2.10 bootstrap: compiling >> stage2 libiberty/regex.c FAILs: >> >> > > Thanks for

Re: [Patch] Teach RTL ifcvt to handle multiple simple set instructions

2015-09-11 Thread Bernd Schmidt
On 09/10/2015 11:11 PM, Jeff Law wrote: I think that's probably what James is most interested in getting some ideas around -- the cost model. I think the fundamental problem is BRANCH_COST isn't actually relative to anything other than the default value of "1". It doesn't directly correspond to

Re: [Patch] Teach RTL ifcvt to handle multiple simple set instructions

2015-09-11 Thread Ramana Radhakrishnan
On Fri, Sep 11, 2015 at 10:53:13AM +0200, Bernd Schmidt wrote: > On 09/10/2015 11:11 PM, Jeff Law wrote: > >I think that's probably what James is most interested in getting some > >ideas around -- the cost model. > > > >I think the fundamental problem is BRANCH_COST isn't actually relative > >to an

[testsuite] Link gcc.dg/pie-link.c with -pie

2015-09-11 Thread Rainer Orth
While starting to develop the patch for Solaris PIE support, the gcc.dg/pie-link.c test succeeded at a point when it shouldn't have, i.e. before I had PIC crt files. In its current form, the test doesn't test what it's supposed to test, namely successfully linking position independent executables,

Re: [PATCH] vectorizing conditional expressions (PR tree-optimization/65947)

2015-09-11 Thread Alan Hayward
Hi Bill, I’d be a bit worried about asking the backend for the cost of a COND_REDUCTION, as that will rely on the backend understanding the implementation the vectorizer is using - every time the vectorizer changed, the backends would need to be updated too. I’m hoping soon to get together a patch

Re: [testsuite] Link gcc.dg/pie-link.c with -pie

2015-09-11 Thread Jakub Jelinek
On Fri, Sep 11, 2015 at 11:08:03AM +0200, Rainer Orth wrote: > While starting to develop the patch for Solaris PIE support, > the gcc.dg/pie-link.c test succeeded at a point when it shouldn't have, > i.e. before I had PIC crt files. In its current form, the test doesn't > test what it's supposed t

Re: [PATCH 2/2] shrink-wrap: Rewrite try_shrink_wrapping

2015-09-11 Thread Bernd Schmidt
On 09/10/2015 05:14 PM, Segher Boessenkool wrote: This patch rewrites the shrink-wrapping algorithm, allowing non-linear pieces of CFG to be duplicated for use without prologue instead of just linear pieces. An example would be good for this kind of patch, also in the comments. - add_to

Re: [PATCH 2/2] shrink-wrap: Rewrite try_shrink_wrapping

2015-09-11 Thread Jiong Wang
Segher Boessenkool writes: > On Thu, Sep 10, 2015 at 08:14:29AM -0700, Segher Boessenkool wrote: >> This patch rewrites the shrink-wrapping algorithm, allowing non-linear >> pieces of CFG to be duplicated for use without prologue instead of just >> linear pieces. > >> Bootstrapped and regression

Re: [testsuite] Link gcc.dg/pie-link.c with -pie

2015-09-11 Thread Rainer Orth
Jakub Jelinek writes: > On Fri, Sep 11, 2015 at 11:08:03AM +0200, Rainer Orth wrote: >> While starting to develop the patch for Solaris PIE support, >> the gcc.dg/pie-link.c test succeeded at a point when it shouldn't have, >> i.e. before I had PIC crt files. In its current form, the test doesn'

Re: [RFC AArch64][PR 63304] Handle literal pools for functions > 1 MiB in size.

2015-09-11 Thread Richard Earnshaw
On 11/09/15 09:48, Ramana Radhakrishnan wrote: > On Thu, Aug 27, 2015 at 03:07:30PM +0100, Marcus Shawcroft wrote: >> On 27 July 2015 at 15:33, Ramana Radhakrishnan >> wrote: >> >>> Ramana Radhakrishnan >>> >>> PR target/63304 >>> * config/aarch64/aarch64.c (aarch64_expand_mov_

Re: [PATCH] [PATCH][ARM] Fix pr63210.c testcase.

2015-09-11 Thread Alex Velenko
Hi, Committed fsf-trunk r227677, fsf-5 r227678. Kind regards, Alex

[patch] libstdc++/65092 Allocator-extended constructors for container adaptors.

2015-09-11 Thread Jonathan Wakely
These should have been added as part of finishing C++11 support but I missed them. Now we have even more constructors to slow down compilation, yay allocators. Tested powerpc64le-linux, commtted to trunk. commit 0a8e02d699f4fe30e44678eb7cbd08bb6c6aed97 Author: Jonathan Wakely Date: Fri Sep

Re: [Patch] Teach RTL ifcvt to handle multiple simple set instructions

2015-09-11 Thread James Greenhalgh
On Fri, Sep 11, 2015 at 10:04:12AM +0100, Ramana Radhakrishnan wrote: > On Fri, Sep 11, 2015 at 10:53:13AM +0200, Bernd Schmidt wrote: > > On 09/10/2015 11:11 PM, Jeff Law wrote: > > >I think that's probably what James is most interested in getting some > > >ideas around -- the cost model. > > > >

[PATCH][PR67476] Add param parloops-schedule

2015-09-11 Thread Tom de Vries
Hi, this patch adds a param parloops-schedule=<0-4>, which sets the omp schedule for loops paralellized by parloops. The <0-4> maps onto . Bootstrapped and reg-tested on x86_64. OK for trunk? Thanks, - Tom Add param parloops-schedule 2015-09-10 Tom de Vries PR tree-optimization/67476

Re: [PATCH][PR67476] Add param parloops-schedule

2015-09-11 Thread Jakub Jelinek
On Fri, Sep 11, 2015 at 12:55:00PM +0200, Tom de Vries wrote: > Hi, > > this patch adds a param parloops-schedule=<0-4>, which sets the omp schedule > for loops paralellized by parloops. > > The <0-4> maps onto . > > Bootstrapped and reg-tested on x86_64. > > OK for trunk? I don't really like

[patch] libstdc++/58265 Implement N4258 noexcept for std::basic_string.

2015-09-11 Thread Jonathan Wakely
This updates the non-COW basic_string to meet the noexcept requirements in the current draft, which required finishing the allocator propagation support. Tested powerpc64le-linux, normal and debug. Committed to trunk. commit 909cf7116d75d42920e4b4f89ee8ddf04c843a9c Author: Jonathan Wakely Date

Re: [PATCH 2/2] shrink-wrap: Rewrite try_shrink_wrapping

2015-09-11 Thread Segher Boessenkool
On Fri, Sep 11, 2015 at 10:24:42AM +0100, Jiong Wang wrote: > > Segher Boessenkool writes: > > > On Thu, Sep 10, 2015 at 08:14:29AM -0700, Segher Boessenkool wrote: > >> This patch rewrites the shrink-wrapping algorithm, allowing non-linear > >> pieces of CFG to be duplicated for use without prol

[patch] libstdc++/64857 Rationalise PCH headers and 17_intro/headers tests.

2015-09-11 Thread Jonathan Wakely
Ensure that includes everything, and rename the 17_intro/headers/c++200x directory to c++2011. Tested powerpc64le-linux, committed to trunk. commit 3b07b2a428725ba70636e00a1f6ed8a28bb59b44 Author: Jonathan Wakely Date: Thu Jan 29 13:12:22 2015 + Rationalise PCH headers and 17_intro

Re: [PATCH] Teach genmatch.c to generate single-use restrictions from flags

2015-09-11 Thread Bernd Schmidt
On 07/08/2015 04:39 PM, Richard Biener wrote: This introduces a :s flag to match expressions which enforces the expression to have a single-use if(!) the simplified expression is larger than one statement. This seems to be missing documentation in match-and-simplify.texi. Bernd

Re: [PATCH 2/2] shrink-wrap: Rewrite try_shrink_wrapping

2015-09-11 Thread Segher Boessenkool
On Fri, Sep 11, 2015 at 11:19:40AM +0200, Bernd Schmidt wrote: > On 09/10/2015 05:14 PM, Segher Boessenkool wrote: > >This patch rewrites the shrink-wrapping algorithm, allowing non-linear > >pieces of CFG to be duplicated for use without prologue instead of just > >linear pieces. > > An example w

Re: [PATCH 2/2] shrink-wrap: Rewrite try_shrink_wrapping

2015-09-11 Thread Bernd Schmidt
On 09/11/2015 02:36 PM, Segher Boessenkool wrote: I'm wondering how your new algorithm prevents the prologue from being placed inside a loop. Can you have a situation where this picks a predecessor that is reachable but not dominated by PRO? It doesn't prevent it! The prologue will not be _in

Re: New power of 2 hash policy

2015-09-11 Thread Michael Matz
Hi, On Thu, 10 Sep 2015, François Dumont wrote: > Here is a patch to offer an alternative hash policy. This one is > using power of 2 number of buckets allowing a faster modulo operation. > This is obvious when running the performance test that I have adapted to > use this alternative poli

Re: New power of 2 hash policy

2015-09-11 Thread Jonathan Wakely
On 11/09/15 15:11 +0200, Michael Matz wrote: Hi, On Thu, 10 Sep 2015, François Dumont wrote: Here is a patch to offer an alternative hash policy. This one is using power of 2 number of buckets allowing a faster modulo operation. This is obvious when running the performance test that I have

Re: [PATCH] vectorizing conditional expressions (PR tree-optimization/65947)

2015-09-11 Thread Bill Schmidt
Hi Alan, I probably wasn't clear enough. The implementation in the vectorizer is fine and I'm not asking that to change per target. What I'm objecting to is the equivalence between a REDUC_MAX_EXPR and a cost associated with vec_to_scalar. This assumes that the back end will implement a REDUC_M

Re: New power of 2 hash policy

2015-09-11 Thread Jonathan Wakely
On 11/09/15 14:18 +0100, Jonathan Wakely wrote: On 11/09/15 15:11 +0200, Michael Matz wrote: Hi, On Thu, 10 Sep 2015, François Dumont wrote: Here is a patch to offer an alternative hash policy. This one is using power of 2 number of buckets allowing a faster modulo operation. This is obvio

Re: [PATCH][PR67476] Add param parloops-schedule

2015-09-11 Thread Tom de Vries
On 11/09/15 12:57, Jakub Jelinek wrote: On Fri, Sep 11, 2015 at 12:55:00PM +0200, Tom de Vries wrote: >Hi, > >this patch adds a param parloops-schedule=<0-4>, which sets the omp schedule >for loops paralellized by parloops. > >The <0-4> maps onto . > >Bootstrapped and reg-tested on x86_64. > >OK

Re: [PATCH][PR67476] Add param parloops-schedule

2015-09-11 Thread Tom de Vries
On 11/09/15 15:28, Tom de Vries wrote: So the definition of param parloop-schedule becomes: ... DEFPARAMENUM PARAM_PARLOOPS_SCHEDULE, "parloops-schedule", "Schedule type of omp schedule for loops parallelized by " "parloops (static, dynamic, guided, auto,

Re: [PATCH 04/22] Reimplement diagnostic_show_locus, introducing rich_location classes

2015-09-11 Thread Michael Matz
Hi, On Thu, 10 Sep 2015, David Malcolm wrote: > +/* FIXME: (dmalcolm) > + This plugin is currently the only user of > + gcc_rich_location::add_range_with_caption > + As such, the symbol is present in libbackend.a, but not in "cc1", > + and running the plugin fails with a linker error: >

[patch] libstdc++/65142 Check read() result in std::random_device.

2015-09-11 Thread Jonathan Wakely
We should not silently ignore a failure to read from the random device. Tested powerpc64le-linux, committed to trunk. I'm going to commit this to the gcc-5 branch too. commit 2d2f7012dc3744dafef0de94dd845bd190253dbd Author: Jonathan Wakely Date: Fri Feb 20 17:29:50 2015 + Check read

Re: [PATCH] vectorizing conditional expressions (PR tree-optimization/65947)

2015-09-11 Thread Ramana Radhakrishnan
On Fri, Sep 11, 2015 at 2:19 PM, Bill Schmidt wrote: > Hi Alan, > > I probably wasn't clear enough. The implementation in the vectorizer is > fine and I'm not asking that to change per target. What I'm objecting > to is the equivalence between a REDUC_MAX_EXPR and a cost associated > with vec_to

Re: [PATCH 07/22] Implement token range tracking within libcpp and C/C++ FEs

2015-09-11 Thread Michael Matz
Hi, On Thu, 10 Sep 2015, David Malcolm wrote: > Does anyone know why this was "carefully packed" and to what extent > this matters? I'm adding an extra 8 bytes to it (or 4 if we eliminate > the existing location_t). As far as I can see, these are > short-lived, and there are only relative few a

Re: [PATCH 04/22] Reimplement diagnostic_show_locus, introducing rich_location classes

2015-09-11 Thread Michael Matz
Hi, On Thu, 10 Sep 2015, David Malcolm wrote: > +/* A range of source locations. > + > + Ranges are half-open: > + m_start is the first location within the range, whereas > + m_finish is the first location *after* the range. I think you eventually decided that they are closed, not half-ope

[gomp4] Override default target hook

2015-09-11 Thread James Norris
Hi! The attached patch overrides the hook's default action for anchored address usage. Committed after regtest on x86_64 and powerpc64le Thanks! Jim Index: nvptx.c === --- nvptx.c (revision 227683) +++ nvptx.c (working copy) @@ -43

[patch] libstdc++/67173 Fix filesystem::canonical for Solaris 10.

2015-09-11 Thread Jonathan Wakely
Solaris 10 doesn't follow POSIX in accepting a null pointer as the second argument to realpath(), so allocate a buffer for it. Tested x86_64-linux, committed to trunk. commit ed4023452f85f6c745ce473b2503f4e46fb02cd9 Author: Jonathan Wakely Date: Fri Sep 11 15:19:27 2015 +0100 Fix filesy

Re: Ping^2 Re: Pass -foffload targets from driver to libgomp at link time

2015-09-11 Thread Joseph Myers
On Thu, 10 Sep 2015, Bernd Schmidt wrote: > On 09/10/2015 03:41 PM, Joseph Myers wrote: > > Ping^2. This patch > > is still > > pending review. > > No fundamental objections, but I have some questions. Cuold you describe > what the han

Re: [PATCH] vectorizing conditional expressions (PR tree-optimization/65947)

2015-09-11 Thread Richard Sandiford
Ramana Radhakrishnan writes: > On Fri, Sep 11, 2015 at 2:19 PM, Bill Schmidt > wrote: >> Hi Alan, >> >> I probably wasn't clear enough. The implementation in the vectorizer is >> fine and I'm not asking that to change per target. What I'm objecting >> to is the equivalence between a REDUC_MAX_E

Re: [PATCH 2/2] shrink-wrap: Rewrite try_shrink_wrapping

2015-09-11 Thread Jiong Wang
Segher Boessenkool writes: > On Fri, Sep 11, 2015 at 10:24:42AM +0100, Jiong Wang wrote: >> >> Segher Boessenkool writes: >> >> > On Thu, Sep 10, 2015 at 08:14:29AM -0700, Segher Boessenkool wrote: >> >> This patch rewrites the shrink-wrapping algorithm, allowing non-linear >> >> pieces of CFG

Re: Ping^2 Re: Pass -foffload targets from driver to libgomp at link time

2015-09-11 Thread Bernd Schmidt
On 09/11/2015 04:23 PM, Joseph Myers wrote: On Thu, 10 Sep 2015, Bernd Schmidt wrote: On 09/10/2015 03:41 PM, Joseph Myers wrote: Ping^2. This patch is still pending review. No fundamental objections, but I have some questions. Cu

Re: [PATCH] vectorizing conditional expressions (PR tree-optimization/65947)

2015-09-11 Thread Bill Schmidt
On Fri, 2015-09-11 at 15:29 +0100, Richard Sandiford wrote: > Ramana Radhakrishnan writes: > > On Fri, Sep 11, 2015 at 2:19 PM, Bill Schmidt > > wrote: > >> Hi Alan, > >> > >> I probably wasn't clear enough. The implementation in the vectorizer is > >> fine and I'm not asking that to change per

Re: [PATCH 04/22] Reimplement diagnostic_show_locus, introducing rich_location classes

2015-09-11 Thread David Malcolm
On Fri, 2015-09-11 at 16:07 +0200, Michael Matz wrote: > Hi, > > On Thu, 10 Sep 2015, David Malcolm wrote: > > > +/* A range of source locations. > > + > > + Ranges are half-open: > > + m_start is the first location within the range, whereas > > + m_finish is the first location *after* the

Re: [PATCH] PR67401: Fix wrong code generated by expand_atomic_compare_and_swap

2015-09-11 Thread John David Anglin
On 2015-09-11 4:15 AM, Bernd Schmidt wrote: On 09/11/2015 01:21 AM, John David Anglin wrote: As noted in the PR, expand_atomic_compare_and_swap can generate wrong code when libcalls are emitted for the sync_compare_and_swap and the result comparison test. This is fixed by emitting a move insn t

Re: [PATCH][AArch64] Use preferred aliases for CSNEG, CSINC, CSINV

2015-09-11 Thread Kyrill Tkachov
Ping. https://gcc.gnu.org/ml/gcc-patches/2015-09/msg00020.html Thanks, Kyrill On 01/09/15 11:08, Kyrill Tkachov wrote: Hi all, The ARMv8-A reference manual says: "CNEG , , is equivalent to CSNEG , , , invert() and is the preferred disassembly when Rn == Rm && cond != '111x'." That is, when t

Re: Ping^2 Re: Pass -foffload targets from driver to libgomp at link time

2015-09-11 Thread Joseph Myers
On Fri, 11 Sep 2015, Bernd Schmidt wrote: > I expect you know best what to do in the OpenACC testsuite driver, but you > might want to run the libgomp.exp parts by Jakub. If the testsuite parts are > independent of the rest of the patch, please repost them separately. Jakub? The testsuite change

Re: [PATCH] vectorizing conditional expressions (PR tree-optimization/65947)

2015-09-11 Thread Richard Sandiford
Bill Schmidt writes: > On Fri, 2015-09-11 at 15:29 +0100, Richard Sandiford wrote: >> Ramana Radhakrishnan writes: >> > On Fri, Sep 11, 2015 at 2:19 PM, Bill Schmidt >> > wrote: >> >> Hi Alan, >> >> >> >> I probably wasn't clear enough. The implementation in the vectorizer is >> >> fine and I'm

Re: [PATCH 21/22] Use Levenshtein distance for various misspellings in C frontend

2015-09-11 Thread Manuel López-Ibáñez
On 10/09/15 22:28, David Malcolm wrote: There are a couple of FIXMEs here: * where to call levenshtein_distance_unit_tests Should this be part of make check? Perhaps a small program that is compiled and linked with spellcheck.c? This would be possible if spellcheck.c did not depend on tree.h

Re: [PATCH][AArch64] Use preferred aliases for CSNEG, CSINC, CSINV

2015-09-11 Thread James Greenhalgh
On Tue, Sep 01, 2015 at 11:08:10AM +0100, Kyrill Tkachov wrote: > Hi all, > > The ARMv8-A reference manual says: > "CNEG , , > is equivalent to > CSNEG , , , invert() > and is the preferred disassembly when Rn == Rm && cond != '111x'." > > That is, when the two input registers are the same we ca

Re: [PATCH][RTL-ifcvt] PR rtl-optimization/67465: Handle pairs of complex+simple blocks and empty blocks more gracefully

2015-09-11 Thread Kyrill Tkachov
On 11/09/15 09:51, Rainer Orth wrote: Kyrill Tkachov writes: On 10/09/15 12:43, Rainer Orth wrote: Hi Kyrill, Rainer, could you please check that this patch still fixes the SPARC regressions? unfortunately, it breaks sparc-sun-solaris2.10 bootstrap: compiling stage2 libiberty/regex.c FAIL

Re: Ping^2 Re: Pass -foffload targets from driver to libgomp at link time

2015-09-11 Thread Jakub Jelinek
On Fri, Sep 11, 2015 at 03:26:04PM +, Joseph Myers wrote: > On Fri, 11 Sep 2015, Bernd Schmidt wrote: > > > I expect you know best what to do in the OpenACC testsuite driver, but you > > might want to run the libgomp.exp parts by Jakub. If the testsuite parts are > > independent of the rest of

Re: [PATCH] vectorizing conditional expressions (PR tree-optimization/65947)

2015-09-11 Thread Bill Schmidt
On Fri, 2015-09-11 at 16:28 +0100, Richard Sandiford wrote: > Bill Schmidt writes: > > On Fri, 2015-09-11 at 15:29 +0100, Richard Sandiford wrote: > >> Ramana Radhakrishnan writes: > >> > On Fri, Sep 11, 2015 at 2:19 PM, Bill Schmidt > >> > wrote: > >> >> Hi Alan, > >> >> > >> >> I probably wasn

Re: Openacc launch API

2015-09-11 Thread Nathan Sidwell
Ping? https://gcc.gnu.org/ml/gcc-patches/2015-08/msg01498.html On 09/07/15 08:48, Nathan Sidwell wrote: On 08/25/15 09:29, Nathan Sidwell wrote: Jakub, This patch changes the launch API for openacc parallels. The current scheme passes the launch dimensions as 3 separate parameters to the G

Re: Ping^2 Re: Pass -foffload targets from driver to libgomp at link time

2015-09-11 Thread Joseph Myers
On Fri, 11 Sep 2015, Jakub Jelinek wrote: > On Fri, Sep 11, 2015 at 03:26:04PM +, Joseph Myers wrote: > > On Fri, 11 Sep 2015, Bernd Schmidt wrote: > > > > > I expect you know best what to do in the OpenACC testsuite driver, but you > > > might want to run the libgomp.exp parts by Jakub. If t

Re: [PATCH][AArch64] Use preferred aliases for CSNEG, CSINC, CSINV

2015-09-11 Thread Kyrill Tkachov
On 11/09/15 16:31, James Greenhalgh wrote: On Tue, Sep 01, 2015 at 11:08:10AM +0100, Kyrill Tkachov wrote: Hi all, The ARMv8-A reference manual says: "CNEG , , is equivalent to CSNEG , , , invert() and is the preferred disassembly when Rn == Rm && cond != '111x'." That is, when the two input

Re: [PATCH] vectorizing conditional expressions (PR tree-optimization/65947)

2015-09-11 Thread Ramana Radhakrishnan
>>> Saying that all reductions have equivalent performance is unlikely to be >>> true for many platforms. On PowerPC, for example, a PLUS reduction has >>> very different cost from a MAX reduction. If the model isn't >>> fine-grained enough, let's please be aggressive about fixing it. I'm >>> f

Re: Use resolution info to get rid of weak symbols

2015-09-11 Thread H.J. Lu
On Sun, May 18, 2014 at 12:38 PM, Jan Hubicka wrote: > Hi, > this patch makes GCC to use resolution info to turn COMDAT and WEAK > symbols into regular symbols based on feedback given by linker plugin. > If resolution says that given symbol is prevailing, it is possible > to turn them into normal

[gomp4] Update fortran tests.

2015-09-11 Thread James Norris
Hi! Attached is a patch to update two (2) tests that were failing because the test cases were incorrect. Committed after regtesting on x86_64 and powerpc64le. Thanks! Jim Index: lib-12.f90 === --- lib-12.f90 (revision 227667) +++ l

[PATCH] Refactor optimize isl

2015-09-11 Thread Aditya Kumar
Updated patch with corrections: Refactor graphite-optimize-isl.c. Renamed function name, variable names etc., and indented the source according to gcc style guidelines. Modified comments accordingly. No functional change intended. Passes regtest and bootstap on x86_64. gcc/ChangeLog: 2015-09-1

[gcc-5-branch][PATCH][AARCH64]Fix for branch offsets over 1 MiB

2015-09-11 Thread Andre Vieira
Conditional branches have a maximum range of [-1048576, 1048572]. Any destination further away can not be reached by these. To be able to have conditional branches in very large functions, we invert the condition and change the destination to jump over an unconditional branch to the original, fa

[PATCH] Remove dead code from graphite-optimize-isl.c

2015-09-11 Thread Aditya Kumar
The variable `static bool enable_polly_vector' is always assigned to false. This results in dead code in optimize-isl.c. Removing the dead code. No functional change intended. Passes bootstrap and regtest. gcc/ChangeLog: 2015-09-11 Aditya Kumar * graphite-optimize-isl.c (get_prevect

Re: [patch] libstdc++/67173 Fix filesystem::canonical for Solaris 10.

2015-09-11 Thread Martin Sebor
On 09/11/2015 08:21 AM, Jonathan Wakely wrote: Solaris 10 doesn't follow POSIX in accepting a null pointer as the second argument to realpath(), so allocate a buffer for it. FWIW, the NULL requirement is new in Issue 7. In Issue 6, the behavior is implementation-defined, and before then it was

RE: [PATCH, MIPS] Frame header optimization for MIPS O32 ABI

2015-09-11 Thread Steve Ellcey
On Fri, 2015-09-04 at 01:40 -0700, Matthew Fortune wrote: > A few comments below. I found some of the comments a bit hard to parse but > have > not attempted any rewording. I'd like Catherine to comment too as I have > barely > any experience at the gimple level to know if this accounts for any

Re: [PATCH] Refactor optimize isl

2015-09-11 Thread Tobias Grosser
On 09/11/2015 07:07 PM, Aditya Kumar wrote: Updated patch with corrections: Refactor graphite-optimize-isl.c. Renamed function name, variable names etc., and indented the source according to gcc style guidelines. Modified comments accordingly. No functional change intended. Looks reasonable.

Re: [PATCH] Remove dead code from graphite-optimize-isl.c

2015-09-11 Thread Tobias Grosser
On 09/11/2015 07:29 PM, Aditya Kumar wrote: The variable `static bool enable_polly_vector' is always assigned to false. This results in dead code in optimize-isl.c. Removing the dead code. No functional change intended. Fine with me as well. This code is used in Polly to enable outer loop vec

libbacktrace patch committed: Update dependencies

2015-09-11 Thread Ian Lance Taylor
Although libbacktrace uses automake, it can't use automatic dependency tracking, because it breaks when using bootstrap-lean (PR 54732). The dependencies for sort.lo and stest.lo were never added to the list. Also, the dependencies for backtrace.lo were not updated for my recent change to that fil

[C++ Patch] PR 51911 V2 ("G++ accepts new auto { list }")

2015-09-11 Thread Paolo Carlini
Hi, this is a slightly reworked (simplified) version of a patch I sent a while ago. The issue is that we are not enforcing at all 5.3.4/2 in the parser, thus we end up rejecting the first test below with a misleading error message talking about list-initialization (and a wrong location), beca

RE: [PATCH] Remove dead code from graphite-optimize-isl.c

2015-09-11 Thread Sebastian Paul Pop
For the record, the patch LGTM. Aditya and I have discussed about this in the morning. Thanks, Sebastian -Original Message- From: Aditya Kumar [mailto:aditya...@samsung.com] Sent: Friday, September 11, 2015 12:30 PM To: gcc-patches@gcc.gnu.org Cc: tob...@grosser.es; richard.guent...@gmai

RE: [PATCH] Refactor optimize isl

2015-09-11 Thread Aditya Kumar
-Original Message- From: Tobias Grosser [mailto:tob...@grosser.es] Sent: Friday, September 11, 2015 1:16 PM To: Aditya Kumar; gcc-patches@gcc.gnu.org Cc: richard.guent...@gmail.com; s@samsung.com; seb...@gmail.com Subject: Re: [PATCH] Refactor optimize isl On 09/11/2015 07:07 PM, Ad

Merge from trunk to gccgo branch

2015-09-11 Thread Ian Lance Taylor
I merged trunk revision 227689 to the gccgo branch. Ian

[gomp4] PTX partition discovery cleanup

2015-09-11 Thread Nathan Sidwell
This preliminary patch changes PTX's loop discovery to use a recursive DFS walk, rather than a worklist. The significant changes, from the POC of the next patch I'll be committing are: 1) always insert a 'fork' insn, which keeps the entry to a partitioned region as a possible Single-Entry-Sin

Re: [PATCH] Convert SPARC to LRA

2015-09-11 Thread David Miller
From: David Miller Date: Tue, 08 Sep 2015 21:41:15 -0700 (PDT) > I'm therefore reasonably confident in these changes, but I will > not apply them just yet to give the other sparc maintainers some > time to review and give feedback. Richard, Eric, any objections?

[PATCH] v2 shrink-wrap: Rewrite

2015-09-11 Thread Segher Boessenkool
[ v2: patch adjusted after Bernd's comments ] This patch rewrites the shrink-wrapping algorithm, allowing non-linear pieces of CFG to be duplicated for use without prologue instead of just linear pieces. On PowerPC, this enables shrink-wrapping of about 2%-3% more functions. I expected more, but

[gomp4] parallel reduction nested inside data regions

2015-09-11 Thread Cesar Philippidis
This patch corrects the way that build_outer_var_ref deals with data mappings in acc parallel and kernels when they are nested in some other construct (i.e. acc data). This issue can be reproduced with acc parallel reduction nested nested inside a acc data region. I've applied this fix to gomp-4_0

Re: [PATCH] Convert SPARC to LRA

2015-09-11 Thread Richard Henderson
On 09/11/2015 12:43 PM, David Miller wrote: > From: David Miller > Date: Tue, 08 Sep 2015 21:41:15 -0700 (PDT) > >> I'm therefore reasonably confident in these changes, but I will >> not apply them just yet to give the other sparc maintainers some >> time to review and give feedback. > > Richard

Re: [C++ Patch] PR 51911 V2 ("G++ accepts new auto { list }")

2015-09-11 Thread Jason Merrill
On 09/11/2015 03:11 PM, Paolo Carlini wrote: this is a slightly reworked (simplified) version of a patch I sent a while ago. The issue is that we are not enforcing at all 5.3.4/2 in the parser, thus we end up rejecting the first test below with a misleading error message talking about list-initia

[PATCH] Another small cleanup to the const_and_copies stack

2015-09-11 Thread Jeff Law
While working on the next significant hunk of changes towards 47679, I saw a few more obvious cleanups that ought to happen. First, we have a policy for data members that they ought to be prefixed with m_ to denote the extra overhead in accessing those members. The data member in the const_

Go patch committed: Fix possible out of bounds memcmp

2015-09-11 Thread Ian Lance Taylor
This patch by Chris Manghane fixes the Go frontend to avoid a possible out of bounds memcmp when looking for a go:nointerface comment. This fixes https://golang.org/issue/11577 . Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian Index: gcc/go/gofrontend/M

Re: [Patch] Teach RTL ifcvt to handle multiple simple set instructions

2015-09-11 Thread Jeff Law
On 09/11/2015 02:49 AM, Kyrill Tkachov wrote: On 10/09/15 22:11, Jeff Law wrote: On 09/10/2015 12:23 PM, Bernd Schmidt wrote: > No testcase provided, as currently I don't know of targets with a high > enough branch cost to actually trigger the optimisation. Hmm, so the code would not actu

[gomp4] SESE region neutering

2015-09-11 Thread Nathan Sidwell
One optimization one can apply to the worker & vector neutering that the PTX backend does, is to neuter Single-Entry, Single-Exit regions, rather than individual BBs. An SESE region in a region bounded by a single entry BB and a single exit BB. (A single BB is a trivial SESE region). Findi

Re: [PATCH] v2 shrink-wrap: Rewrite

2015-09-11 Thread Pat Haugen
On 09/11/2015 02:49 PM, Segher Boessenkool wrote: On PowerPC, this enables shrink-wrapping of about 2%-3% more functions. I expected more, but in most cases this would help we cannot yet shrink- wrap because there are non-volatile registers used, often in the first block already. I looked into sh

[PATCH] PR28901 -Wunused-variable ignores unused const initialised variables

2015-09-11 Thread Mark Wielaard
12 years ago it was decided that -Wunused-variable shouldn't warn about static const variables because some code used const static char rcsid[] strings which were never used but wanted in the code anyway. But as the bug points out this hides some real bugs. These days the usage of rcsids is not ver

Re: [PATCH] PR28901 -Wunused-variable ignores unused const initialised variables

2015-09-11 Thread Bernd Schmidt
On 09/12/2015 12:12 AM, Mark Wielaard wrote: 12 years ago it was decided that -Wunused-variable shouldn't warn about static const variables because some code used const static char rcsid[] strings which were never used but wanted in the code anyway. But as the bug points out this hides some real

Re: [PATCH] v2 shrink-wrap: Rewrite

2015-09-11 Thread Segher Boessenkool
On Fri, Sep 11, 2015 at 05:06:47PM -0500, Pat Haugen wrote: > On 09/11/2015 02:49 PM, Segher Boessenkool wrote: > >On PowerPC, this enables shrink-wrapping of about 2%-3% more functions. > >I expected more, but in most cases this would help we cannot yet shrink- > >wrap because there are non-volati

Re: [PATCH] v2 shrink-wrap: Rewrite

2015-09-11 Thread Pat Haugen
On 09/11/2015 05:40 PM, Segher Boessenkool wrote: Another issue I saw for PowerPC that prevented shrink-wrapping was the >case where non-volatile CR's are used somewhere in the function. This >causes a 'mfcr' to be generated in the prolog to save the non-volatile >CR's, which currently lists all

Re: [PATCH][AArch64] Use preferred aliases for CSNEG, CSINC, CSINV

2015-09-11 Thread Andrew Pinski
On Tue, Sep 1, 2015 at 6:08 PM, Kyrill Tkachov wrote: > Hi all, > > The ARMv8-A reference manual says: > "CNEG , , > is equivalent to > CSNEG , , , invert() > and is the preferred disassembly when Rn == Rm && cond != '111x'." > > That is, when the two input registers are the same we can use the s

Re: [Patch, libstdc++] Add specific error message into exceptions

2015-09-11 Thread Tim Shen
On Mon, Sep 7, 2015 at 4:06 AM, Jonathan Wakely wrote: > On 28/08/15 11:23 -0700, Tim Shen wrote: >> >> On Fri, Aug 28, 2015 at 8:59 AM, Jonathan Wakely >> wrote: >>> >>> There seems to be no need to construct a std::string here, just pass a >>> const char* (see below). >> >> >> To be honest, I w