Re: [PR66726] Factor conversion out of COND_EXPR

2015-07-15 Thread Kugan
Here is a patch to fix to teach tree-ssa-reassoc the sinking the cast. Bootstrapped and regression tested on x86-64-none-linux-gnu with no new regressions. Also regression tested on qemu arm. I also verified the issue Andreas Schwab raised is fixed on arm cortex-a5 where the same issue was presen

Re: [C/C++ PATCH] PR c++/66572. Fix Wlogical-op false positive

2015-07-15 Thread Mikhail Maltsev
On 07/14/2015 07:38 PM, Marek Polacek wrote: > Ok, in that case I think easiest would the following (I hit the same issue > when writing the -Wtautological-compare patch): Thanks for taking care of this issue. -- Regards, Mikhail Maltsev

Re: [PATCH 1/2, rtl-optimization]: Fix PR 58066, __tls_get_addr is called with misaligned stack on x86-64

2015-07-15 Thread Uros Bizjak
On Tue, Jul 14, 2015 at 6:46 AM, Jeff Law wrote: > On 07/13/2015 11:03 AM, Uros Bizjak wrote: >> >> This is rtl-optimization part of a two-part patch series. >> >> As discussed in the PR, we have to prcompute register parameters >> before stack alignment is performed, otherwise eventual call to >>

Re: [PATCH][RFC] Consolidate -O3 torture options

2015-07-15 Thread Richard Biener
On Tue, 14 Jul 2015, Jeff Law wrote: > On 07/14/2015 05:58 AM, Richard Biener wrote: > > > > The following patch tries to consolidate the -O3 torture testing > > options in the attempt to reduce testing time while not losing > > coverage. > > > > It drops testing of -funroll-all-loops (which nob

[PATCH] fix in-tree-binutils builds

2015-07-15 Thread Jan Beulich
Quite a while ago configure.in go renamed to configure.ac in all of binutils' subtrees - allow for both when checking for that case while configuring. gcc/ 2015-07-15 Jan Beulich * acinclude.m4: Replace configure.in by configure.[ai][cn]. * configure.ac: Likewise. * con

Re: [PATCH][AArch64] PR target/66731 Fix fnmul insn with -frounding-math

2015-07-15 Thread Ramana Radhakrishnan
On 09/07/15 15:40, Szabolcs Nagy wrote: > On 06/07/15 16:39, Marcus Shawcroft wrote: >> On 6 July 2015 at 09:20, Szabolcs Nagy wrote: >> >>> 2015-07-06 Szabolcs Nagy PR target/66731 in Changelog ? Ramana >>> >>> * gcc.target/aarch64/fnmul-1.c: New. >>> * gcc.target/aarch6

Re: [PATCH AArch64]Handle wrong cost for addition of minus immediate in aarch64_rtx_costs.

2015-07-15 Thread Bin.Cheng
Ping^2 On Thu, Jul 9, 2015 at 5:42 PM, Bin.Cheng wrote: > Ping. > > On Fri, Jun 26, 2015 at 4:47 PM, Bin Cheng wrote: >> Hi, >> The canonical form of subtract of immediate is (add op0 minus_imm), which is >> supported with addsi3_aarch64 pattern on aarch64. Unfortunately wrong cost >> (8 rather

Re: [PATCH][DRIVER] Wrong C++ include paths when configuring with "--with-sysroot=/"

2015-07-15 Thread Yvan Roux
Hi, (Sorry for the delay I'm just back from a long sick leave) >> There is this old patch submitted by Matthias on that same issue, if >> its logic is the right one for you Joseph I can rebase/validate it >> Joseph. >> >> https://gcc.gnu.org/ml/gcc-patches/2012-02/msg00320.html > > Yes, that seem

Re: conditional lim

2015-07-15 Thread Evgeniya Maenkova
On Tue, Jul 14, 2015 at 2:54 PM, Richard Biener wrote: > On Mon, Jun 29, 2015 at 4:21 PM, Evgeniya Maenkova > wrote: >> On Mon, Jun 29, 2015 at 5:10 PM, Richard Biener >> wrote: >>> On Tue, Jun 9, 2015 at 10:11 PM, Evgeniya Maenkova >>> wrote: On Tue, Jun 9, 2015 at 3:46 PM, Richard Biener

Re: [gomp] constify device data & fix cleanup

2015-07-15 Thread Ilya Verbin
2015-07-15 2:59 GMT+03:00 Nathan Sidwell : > The other thing this does is change the interface between libgommp and the > plugin's load_image and unload_image routines. I've added the ability to > return a pointer to target-specific connection data, and have it provided to > the unload function

Re: [PATCH AArch64]Handle wrong cost for addition of minus immediate in aarch64_rtx_costs.

2015-07-15 Thread James Greenhalgh
On Wed, Jul 15, 2015 at 09:22:01AM +0100, Bin.Cheng wrote: > Ping^2 > +/* ADD -(immediate). */ I'd like to see a more detailed comment in this case. Probably something along the lines of: /* The canonical form of subtract of immediate is (add op0 minus_imm). Catch that here, m

Re: [PATCH][AArch64] PR target/66731 Fix fnmul insn with -frounding-math

2015-07-15 Thread Szabolcs Nagy
On 15/07/15 09:11, Ramana Radhakrishnan wrote: > On 09/07/15 15:40, Szabolcs Nagy wrote: >> On 06/07/15 16:39, Marcus Shawcroft wrote: >>> On 6 July 2015 at 09:20, Szabolcs Nagy wrote: >>> 2015-07-06 Szabolcs Nagy > > > PR target/66731 in Changelog ? > thanks, fixed in r225810.

Re: [PATCH] [gomp] Recycle non-nested team if possible

2015-07-15 Thread Sebastian Huber
Thanks, I checked this in: https://gcc.gnu.org/viewcvs/gcc?view=revision&revision=225811 -- Sebastian Huber, embedded brains GmbH Address : Dornierstr. 4, D-82178 Puchheim, Germany Phone : +49 89 189 47 41-16 Fax : +49 89 189 47 41-09 E-Mail : sebastian.hu...@embedded-brains.de PGP :

RE: [PATCH] MIPS: Correctly update the isa and arch_test_option_p variables after the arch dependency handling code in mips.exp

2015-07-15 Thread Andrew Bennett
> > Ok to commit? > > Yes, this is OK. Committed as SVN 225813. Regards, Andrew

Re: [gomp4] New test loop independent clause

2015-07-15 Thread Thomas Schwinge
Hi! On Tue, 14 Jul 2015 14:10:01 -0500, James Norris wrote: > The attached adds testing for the independent clause > with the loop directive in Fortran. > > Committed to gomp-4_0-branch. > --- /dev/null > +++ b/libgomp/testsuite/libgomp.oacc-fortran/kernels-independent.f90 Thanks! I had a lo

[PATCH][ARM][testsuite][committed] Add -mfloat-abi=softfp to some xscale tests

2015-07-15 Thread Kyrill Tkachov
Hi all, This patch adds -mfloat-abi=softfp to a couple of tests that check xscale functionality and an appropriate skipping directive. This helps avoid "unimplemented Thumb-1 hard float ABI" errors when testing the arm-none-linux-gnueabihf/-mthumb variant. With this patch the two tests PASS on

Re: [gomp] constify device data & fix cleanup

2015-07-15 Thread Thomas Schwinge
Hi! On Tue, 14 Jul 2015 19:59:17 -0400, Nathan Sidwell wrote: > This patch turned out a little larger than expected as I ran into an API > limitation between libgomp and the plugins. > > The patch changes GOMP_offload_{,un}register to take a pointer to constant > target data. I've fixed up th

RE: [Patch] Add support for IEEE-conformant versions of scalar fmin* and fmax*

2015-07-15 Thread David Sherwood
> > > > > On Mon, 29 Jun 2015, David Sherwood wrote: > > > > > > > Hi, > > > > > > > > I have added new STRICT_MAX_EXPR and STRICT_MIN_EXPR expressions to > > > > support the > > > > IEEE versions of fmin and fmax. This is done by recognising the math > > > > library > > > > "fmax" and "fmin" bui

Re: Tests for libgomp based on OpenMP Examples 4.0.2

2015-07-15 Thread Dominique d'Humières
> The patch replaces all FP comparisons with inequalities and epsilons > in those tests for libgomp. In libgomp/testsuite/libgomp.fortran/examples-4/simd-8.f90 integer, parameter :: EPS = 0.005 should be real, parameter :: EPS = 0.005 TIA Dominique

Re: [gomp4] New test loop independent clause

2015-07-15 Thread Tom de Vries
On 15/07/15 11:28, Thomas Schwinge wrote: Hi! On Tue, 14 Jul 2015 14:10:01 -0500, James Norris wrote: The attached adds testing for the independent clause with the loop directive in Fortran. Committed to gomp-4_0-branch. --- /dev/null +++ b/libgomp/testsuite/libgomp.oacc-fortran/kernels-i

Re: conditional lim

2015-07-15 Thread Richard Biener
On Wed, Jul 15, 2015 at 10:36 AM, Evgeniya Maenkova wrote: > On Tue, Jul 14, 2015 at 2:54 PM, Richard Biener > wrote: >> On Mon, Jun 29, 2015 at 4:21 PM, Evgeniya Maenkova >> wrote: >>> On Mon, Jun 29, 2015 at 5:10 PM, Richard Biener >>> wrote: On Tue, Jun 9, 2015 at 10:11 PM, Evgeniya Mae

Re: [PATCH][13/n] Remove GENERIC stmt combining from SCCVN

2015-07-15 Thread Richard Biener
On Thu, 9 Jul 2015, Kyrill Tkachov wrote: > Hi Richard, > > On 07/07/15 15:10, Richard Biener wrote: > > This moves a few more patterns that show up during bootstrap. > > > > Bootstrapped and tested on x86_64-unknown-linux-gnu, applied to trunk. > > > > Richard. > > > > 2015-07-07 Richard Bie

AW: [Bug fortran/52846] [F2008] Support submodules - part 2/3

2015-07-15 Thread Bader, Reinhold
Hello Paul, the attached example fails to compile with the error message Error: Global name »mod_s« at (1) is already being used as a MODULE at (2) subm_10_pos.f90:29:6: use mod_s However, the global identifier of a submodule is the pair (ancestor module name, submodule name) according to

Re: [PATCH][13/n] Remove GENERIC stmt combining from SCCVN

2015-07-15 Thread Kyrill Tkachov
On 15/07/15 11:52, Richard Biener wrote: On Thu, 9 Jul 2015, Kyrill Tkachov wrote: Hi Richard, On 07/07/15 15:10, Richard Biener wrote: This moves a few more patterns that show up during bootstrap. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied to trunk. Richard. 2015-07-07

Re: [Bug fortran/52846] [F2008] Support submodules - part 2/3

2015-07-15 Thread Paul Richard Thomas
Dear Reinhold, I didn't change the internal symbol names because @ is not allowed in linker symbol names. I'll use '.' internally. Thanks for letting me know. Obviously, I have a little bit more work to do before the patch can be committed :-( Paul On 15 July 2015 at 12:58, Bader, Reinhold wro

[gomp4.1] Add support for directive-name-modifiers in if clauses

2015-07-15 Thread Jakub Jelinek
Hi! In OpenMP 4.1, one can optionally use modifiers to say which construct the if clause belongs to. Implemented thusly: 2015-07-15 Jakub Jelinek * tree-core.h (struct tree_omp_clause): Add subcode.if_modifier field. * tree.h (OMP_CLAUSE_IF_MODIFIER): Define.

Re: [PATCH] PR target/66824: Allow software FP SFmode in FP splitter

2015-07-15 Thread Uros Bizjak
On Mon, Jul 13, 2015 at 6:09 PM, H.J. Lu wrote: > On Sun, Jul 12, 2015 at 10:56 AM, Uros Bizjak wrote: >> On Sat, Jul 11, 2015 at 9:23 PM, H.J. Lu wrote: >>> On Thu, Jul 09, 2015 at 01:58:22PM -0700, H.J. Lu wrote: On Thu, Jul 09, 2015 at 12:13:38PM -0700, H.J. Lu wrote: > ix86_split_l

Re: [Patch, Fortran, 66035, v2] [5/6 Regression] gfortran ICE segfault

2015-07-15 Thread Paul Richard Thomas
Dear Andre, I am still in the bizarre situation that the testcase compiles and runs correctly on a clean trunk! That said, the patch applies cleanly and, at very least from my point of view, does not do any harm :-) OK for trunk Thanks for the patch Paul On 11 July 2015 at 14:08, Andre Vehres

Re: [Patch, fortran] PR 37131, inline matmul

2015-07-15 Thread Mikael Morin
Hello, Le 13/07/2015 21:54, Thomas Schwinge a écrit : > Original situation; _gfortran_runtime_error is not being properly > declared (invoked via gcc/fortran/frontend-passes.c:runtime_error_ne), > but, for example, _gfortran_error_runtime_at is being properly declared > (invoked from elsewhere):

RE: [PATCH, MIPS] Support interrupt handlers with hard-float

2015-07-15 Thread Robert Suchanek
Hi, > > Hi Matthew/Catherine, > > > > The attached patch removes the restriction to compile a TU with an ISR with > - > > mhard-float. Instead of forcing -msoft-float, the coprocessor 1 is disabled > in > > an ISR for -mhard-float. > > > > Ok to apply? > > Yes, this one is OK. Committed as r2258

Re: [PATCH][RFC] Consolidate -O3 torture options

2015-07-15 Thread Richard Biener
On Wed, 15 Jul 2015, Richard Biener wrote: > On Tue, 14 Jul 2015, Jeff Law wrote: > > > On 07/14/2015 05:58 AM, Richard Biener wrote: > > > > > > The following patch tries to consolidate the -O3 torture testing > > > options in the attempt to reduce testing time while not losing > > > coverage.

RE: [PATCH, MIPS] Support new interrupt handler options

2015-07-15 Thread Robert Suchanek
Hi Catherine, > This is now OK to commit. > Catherine Committed as r225819. Robert

RE: [PATCH, MIPS] Fix restoration of hi/lo in MIPS64R2 interrupt handlers

2015-07-15 Thread Robert Suchanek
Hi, > > OK. I'll change it to interrupt_handler-5.c, add a comment and commit after > > approval for the new interrupt handler options. > > I believe this change is independent of the new attributes so feel free to > commit > it before. I was to going to commit it before but by the time I did th

Re: [gomp4] New test loop independent clause

2015-07-15 Thread Thomas Schwinge
Hi Tom! On Wed, 15 Jul 2015 12:43:05 +0200, Tom de Vries wrote: > On 15/07/15 11:28, Thomas Schwinge wrote: > > On Tue, 14 Jul 2015 14:10:01 -0500, James Norris > > wrote: > >> The attached adds testing for the independent clause > >> with the loop directive in Fortran. > >> > >> Committed to g

Re: [PATCH] PR target/66824: Allow software FP SFmode in FP splitter

2015-07-15 Thread Uros Bizjak
On Wed, Jul 15, 2015 at 1:36 PM, Uros Bizjak wrote: >> I couldn't figure a way to add conditional constraints for "?r/rmF" and >> "r/rmF". I simply disabled *movsf_internal if TARGET_HARD_FP_REGS >> is false and added a new "*movsf_internal_soft_fp" pattern. >> >> OK for trunk if there is no re

undefined reference to `acc_copyin_array_h_' (was: [PATCH] [gomp] Recycle non-nested team if possible)

2015-07-15 Thread Thomas Schwinge
Hallo! On Tue, 14 Jul 2015 13:47:41 +0200, Sebastian Huber wrote: > [...] > > I run the test suite on x86_64-unknown-linux-gnu with the previously > mentioned asserts and got no unexpected failures. > > With --disable-linux-futex (without asserts) I got several failures, but > none of them i

[PATCH][15/n] Remove GENERIC stmt combining from SCCVN

2015-07-15 Thread Richard Biener
This moves a few more patterns and in turn makes negate_expr_p a predicate (without fully populating it with fold-const.c capabilities - thus also not removing negate_expr_p using patterns from there). Bootstrapped and tested on x86_64-unknown-linux-gnu, applied. Richard. 2015-07-14 Richard Bi

Re: [gomp] constify device data & fix cleanup

2015-07-15 Thread Nathan Sidwell
On 07/15/15 04:42, Ilya Verbin wrote: 2015-07-15 2:59 GMT+03:00 Nathan Sidwell : The other thing this does is change the interface between libgommp and the plugin's load_image and unload_image routines. I've added the ability to return a pointer to target-specific connection data, and have it

Re: [gomp4.1] Support C++ "this" in OpenMP directives

2015-07-15 Thread Ilya Verbin
On Thu, Jul 09, 2015 at 10:50:14 +0200, Jakub Jelinek wrote: > * parser.c (cp_parser_omp_var_list_no_open): Parse this. > * cp-tree.h (finish_omp_declare_simd_methods): New prototype. > * semantics.c (handle_omp_array_sections_1): Disallow this based > array sections for Ope

Re: [PATCH, ARM] stop changing signedness in PROMOTE_MODE

2015-07-15 Thread Michael Matz
Hi, On Tue, 14 Jul 2015, Richard Earnshaw wrote: > > I think it's a backend bug that parameters and locals are extended > > differently. The code in tree-outof-ssa was written with the > > assumption that the modes of RTL objects might be different (larger) > > than the tree types suggest, bu

Re: [Fortran, Patch] Passing function pointer to co_reduce

2015-07-15 Thread Mikael Morin
Hello, Le 13/07/2015 17:31, Alessandro Fanfarillo a écrit : > Dear all, > > during the implementation of co_reduce in OpenCoarrays I noticed that > GFortran passes a pointer to function instead of the function name to > co_reduce. > More exactly there are two address operators ('&') in a row (th

Re: [PATCH, ARM] stop changing signedness in PROMOTE_MODE

2015-07-15 Thread Michael Matz
Hi, On Tue, 14 Jul 2015, Jim Wilson wrote: > Now that we do have the problem, we can't fix it without an ARM port ABI > change, which is undesirable, so we may have to fix it with a MI change. What's the ABI implication of fixing the inconsistency? > There were two MI changes suggested, one wa

Re: Tests for libgomp based on OpenMP Examples 4.0.2

2015-07-15 Thread Ilya Verbin
On Wed, Jul 15, 2015 at 12:29:53 +0200, Dominique d'Humières wrote: > > The patch replaces all FP comparisons with inequalities and epsilons > > in those tests for libgomp. > In libgomp/testsuite/libgomp.fortran/examples-4/simd-8.f90 > > integer, parameter :: EPS = 0.005 > > should be > > real,

Re: undefined reference to `acc_copyin_array_h_'

2015-07-15 Thread Sebastian Huber
On 15/07/15 14:16, Thomas Schwinge wrote: Hallo! On Tue, 14 Jul 2015 13:47:41 +0200, Sebastian Huber wrote: [...] I run the test suite on x86_64-unknown-linux-gnu with the previously mentioned asserts and got no unexpected failures. With --disable-linux-futex (without asserts) I got sever

Re: [PATCH] PR target/66824: Allow software FP SFmode in FP splitter

2015-07-15 Thread H.J. Lu
On Wed, Jul 15, 2015 at 5:05 AM, Uros Bizjak wrote: > On Wed, Jul 15, 2015 at 1:36 PM, Uros Bizjak wrote: > >>> I couldn't figure a way to add conditional constraints for "?r/rmF" and >>> "r/rmF". I simply disabled *movsf_internal if TARGET_HARD_FP_REGS >>> is false and added a new "*movsf_inte

Re: [gomp4] New test loop independent clause

2015-07-15 Thread Tom de Vries
On 15/07/15 14:03, Thomas Schwinge wrote: Hi Tom! On Wed, 15 Jul 2015 12:43:05 +0200, Tom de Vries wrote: On 15/07/15 11:28, Thomas Schwinge wrote: On Tue, 14 Jul 2015 14:10:01 -0500, James Norris wrote: The attached adds testing for the independent clause with the loop directive in Fortra

[PATCH][AArch64] Use cinc mnemonic for *csinc2_insn

2015-07-15 Thread Kyrill Tkachov
Hi all, This pattern performs a csinc of the same register in both operands. This form can be written using the shorter alias CINC. The ARMv8-A ARM says: "CINC , , is equivalent to CSINC , , , invert()" So the patch switches the condition output modifier from 'M' to the inverse 'm'. I don't th

Re: undefined reference to `acc_copyin_array_h_'

2015-07-15 Thread Thomas Schwinge
Hi! On Wed, 15 Jul 2015 15:25:19 +0200, Sebastian Huber wrote: > I deleted my build tree and started from scratch with the latest trunk > version. Now I don't get errors with --disable-linux-futex: > # of expected passes5145 > # of expected failures 8 > # of unsupported te

Re: [PATCH][AArch64] Use cinc mnemonic for *csinc2_insn

2015-07-15 Thread James Greenhalgh
On Wed, Jul 15, 2015 at 02:44:40PM +0100, Kyrill Tkachov wrote: > Hi all, > This pattern performs a csinc of the same register in both operands. > This form can be written using the shorter alias CINC. > The ARMv8-A ARM says: > > "CINC , , > is equivalent to > CSINC , , , invert()" > > So the pa

Re: [Patch, fortran] PR 37131, inline matmul

2015-07-15 Thread Thomas Schwinge
Hi! On Wed, 15 Jul 2015 13:44:38 +0200, Mikael Morin wrote: > Le 13/07/2015 21:54, Thomas Schwinge a écrit : > > Original situation; _gfortran_runtime_error is not being properly > > declared (invoked via gcc/fortran/frontend-passes.c:runtime_error_ne), > > but, for example, _gfortran_error_runti

Re: [PATCH][AArch64] Use cinc mnemonic for *csinc2_insn

2015-07-15 Thread Kyrill Tkachov
On 15/07/15 15:00, James Greenhalgh wrote: On Wed, Jul 15, 2015 at 02:44:40PM +0100, Kyrill Tkachov wrote: Hi all, This pattern performs a csinc of the same register in both operands. This form can be written using the shorter alias CINC. The ARMv8-A ARM says: "CINC , , is equivalent to CSINC

Re: [PATCH][C++] Fix PR65091

2015-07-15 Thread Jason Merrill
On 07/14/2015 07:29 PM, Paolo Carlini wrote: I see. At the time I had this second try: https://gcc.gnu.org/ml/gcc-patches/2015-06/msg01232.html which has the action in cp_parser_unqualified_id but unfortunately is more complex. Certainly we can't just return inconditionally error_mark_node

Re: [PATCH 4/5] Downgrade value_expr_for_decl to non-cache

2015-07-15 Thread Michael Matz
Hi, On Tue, 14 Jul 2015, Richard Biener wrote: > For example have those special caches have two marking phases. The first > phase marks all non-key edges originating from each entry. The second > phase is the same as what we have now - unmarked entries get removed. > > The first phase would go

Re: [PATCH 4/5] Downgrade value_expr_for_decl to non-cache

2015-07-15 Thread Jakub Jelinek
On Wed, Jul 15, 2015 at 04:14:07PM +0200, Michael Matz wrote: > That's Toms other approach with supporting multi-step dependencies. As I > have tried to argue in the other thread, I think this idea is > fundamentally broken and just hides real bugs, and I don't see why this > would be different

Re: [PATCH] Add 'switch' statement to match.pd language

2015-07-15 Thread Michael Matz
Hi, On Tue, 14 Jul 2015, Richard Biener wrote: > I know Micha detests the extra 'if' as much as the extra braces thus > would have prefered > > (switch > (A) B > (B) C > (C) D > E) The lispy way would have been (switch (A) (B) (C) (D) (E) (F) G) i.e. parenthesize t

Re: [PATCH 4/5] Downgrade value_expr_for_decl to non-cache

2015-07-15 Thread Michael Matz
Hi, On Wed, 15 Jul 2015, Jakub Jelinek wrote: > On Wed, Jul 15, 2015 at 04:14:07PM +0200, Michael Matz wrote: > > That's Toms other approach with supporting multi-step dependencies. As I > > have tried to argue in the other thread, I think this idea is > > fundamentally broken and just hides r

Re: [gomp4] libgomp: Cope with DejaGnu having no mechanism to transfer environment variables to remote boards

2015-07-15 Thread Thomas Schwinge
Hi! (CCed to gcc-patches in case this is useful for anyone else, too.) Nathan noticed that the following patch ("hack") no longer applies cleanly to GCC trunk: On Thu, 14 May 2015 00:10:50 +0200, I wrote: > On Fri, 24 Oct 2014 00:18:10 +0200, I wrote: > > On Thu, 23 Oct 2014 17:02:20 +0200, I wr

Re: [PATCH 4/5] Downgrade value_expr_for_decl to non-cache

2015-07-15 Thread Jakub Jelinek
On Wed, Jul 15, 2015 at 04:25:44PM +0200, Michael Matz wrote: > On Wed, 15 Jul 2015, Jakub Jelinek wrote: > > > On Wed, Jul 15, 2015 at 04:14:07PM +0200, Michael Matz wrote: > > > That's Toms other approach with supporting multi-step dependencies. As I > > > have tried to argue in the other thre

Re: [PATCH] remove some usage of expr_list from read_rtx

2015-07-15 Thread Trevor Saunders
On Mon, Jul 13, 2015 at 02:43:46PM +0100, Richard Sandiford wrote: > Nice clean-up :-) > > tbsaunde+...@tbsaunde.org writes: > > @@ -2248,11 +2249,14 @@ process_define_subst (void) > > static void > > rtx_handle_directive (int lineno, const char *rtx_name) > > { > > - rtx queue, x; > > + auto

Re: [PATCH 4/5] Downgrade value_expr_for_decl to non-cache

2015-07-15 Thread Michael Matz
Hi, On Wed, 15 Jul 2015, Jakub Jelinek wrote: > > No, I really meant value. If you think it has meaning, then tell me > > what it is for DECL_VALUE_EXPR (X) to be 'Y', if Y is nowhere else > > mentioned, neither in code, nor in local-decls, nor in globals, or > > anywhere else that would be r

[gomp4.1] C++ iterators with #omp ordered depend(sink:)

2015-07-15 Thread Aldy Hernandez
This fixes the problem with C++ iterators not working as sink() iterator variables. OK for branch? Aldy commit feb44bd0b32a941092441206af9157cb45995d81 Author: Aldy Hernandez Date: Tue Jul 14 19:23:09 2015 -0700 * gimplify.c (gimplify_omp_for): Use OMP_FOR_ORIG_DECLS. * tree

Re: [PATCH 4/5] Downgrade value_expr_for_decl to non-cache

2015-07-15 Thread Michael Matz
Hi, On Wed, 15 Jul 2015, Michael Matz wrote: > Similar for "ptr->foo" if "ptr" is nowhere mentioned in code or tables. > In effect DECL_VALUE_EXPR refers to stale decls that aren't initialized, > aren't given a place and aren't dealt with in code. Or, maybe we're talking past each other. You

Re: [PATCH] Add 'switch' statement to match.pd language

2015-07-15 Thread Richard Biener
On July 15, 2015 4:21:03 PM GMT+02:00, Michael Matz wrote: >Hi, > >On Tue, 14 Jul 2015, Richard Biener wrote: > >> I know Micha detests the extra 'if' as much as the extra braces thus >> would have prefered >> >> (switch >> (A) B >> (B) C >> (C) D >> E) > >The lispy way would have been >

Re: [PATCH 4/5] Downgrade value_expr_for_decl to non-cache

2015-07-15 Thread Richard Biener
On July 15, 2015 4:52:41 PM GMT+02:00, Michael Matz wrote: >Hi, > >On Wed, 15 Jul 2015, Michael Matz wrote: > >> Similar for "ptr->foo" if "ptr" is nowhere mentioned in code or >tables. >> In effect DECL_VALUE_EXPR refers to stale decls that aren't >initialized, >> aren't given a place and aren

Re: [PATCH 4/5] Downgrade value_expr_for_decl to non-cache

2015-07-15 Thread Jakub Jelinek
On Wed, Jul 15, 2015 at 04:52:41PM +0200, Michael Matz wrote: > On Wed, 15 Jul 2015, Michael Matz wrote: > > > Similar for "ptr->foo" if "ptr" is nowhere mentioned in code or tables. > > In effect DECL_VALUE_EXPR refers to stale decls that aren't initialized, > > aren't given a place and aren't

Re: [PATCH] Add 'switch' statement to match.pd language

2015-07-15 Thread Michael Matz
Hi, On Wed, 15 Jul 2015, Richard Biener wrote: > >> (switch > >> (A) B > >> (B) C > >> (C) D > >> E) > > > >The lispy way would have been > > > > (switch > >(A) (B) > >(C) (D) > >(E) (F) > >G) > > > >i.e. parenthesize the result as well, which then would be unambiguousl

Re: [PATCH 4/5] Downgrade value_expr_for_decl to non-cache

2015-07-15 Thread Michael Matz
Hi, On Wed, 15 Jul 2015, Richard Biener wrote: > >Or, maybe we're talking past each other. You mean the case where > >complicated-expr-on-Y is the value-expr, and Y is _no_ stale decl, but > >the complicated expr itself nevertheless is mentioned nowhere else? > >Yes, those trees must be reta

Re: [gomp4.1] C++ iterators with #omp ordered depend(sink:)

2015-07-15 Thread Jakub Jelinek
On Wed, Jul 15, 2015 at 07:47:12AM -0700, Aldy Hernandez wrote: > This fixes the problem with C++ iterators not working as sink() iterator > variables. > > OK for branch? I wonder (though not 100% sure about) if, because we really need the OMP_FOR_ORIG_DECLS on OMP_FOR only, no other construct ca

Re: [gomp4.1] Support C++ "this" in OpenMP directives

2015-07-15 Thread Jakub Jelinek
On Wed, Jul 15, 2015 at 03:47:54PM +0300, Ilya Verbin wrote: > On Thu, Jul 09, 2015 at 10:50:14 +0200, Jakub Jelinek wrote: > > * parser.c (cp_parser_omp_var_list_no_open): Parse this. > > * cp-tree.h (finish_omp_declare_simd_methods): New prototype. > > * semantics.c (handle_omp_array_

Re: [PATCH, ARM] stop changing signedness in PROMOTE_MODE

2015-07-15 Thread Jim Wilson
On Wed, Jul 15, 2015 at 6:04 AM, Michael Matz wrote: > Hi, > > On Tue, 14 Jul 2015, Jim Wilson wrote: > >> Now that we do have the problem, we can't fix it without an ARM port ABI >> change, which is undesirable, so we may have to fix it with a MI change. > > What's the ABI implication of fixing t

[genmatch] reject empty c_expr

2015-07-15 Thread Prathamesh Kulkarni
Hi, We allow c_expr to be empty which accepts cases like the following: (simplify match-operand (if () result-operand)) (simplify match-operand {}) The attached patch rejects empty c_expr. Ok for trunk after bootstrap + test ? Thank you, Prathamesh 2015-07-15 Prathamesh Kulkarni

Re: [PATCH] PR/66760, ipa-inline-analysis.c compile-time hog

2015-07-15 Thread Martin Jambor
Hi, On Mon, Jul 13, 2015 at 03:49:05PM +0200, Richard Biener wrote: > On Mon, Jul 13, 2015 at 3:46 PM, Paolo Bonzini wrote: > > > > > > On 13/07/2015 15:45, Richard Biener wrote: > >> It would be nice to have a patch that can be backported to the GCC 5 branch > >> as well. We can improve this on

Re: [PATCH] PR/66760, ipa-inline-analysis.c compile-time hog

2015-07-15 Thread Paolo Bonzini
On 15/07/2015 18:01, Martin Jambor wrote: > > So unless Martin objects consider the patch approved for trunk and for > > backporting after 5.2 is released and trunk shows no issues. > > > > Martin - can you take care of committing if you are fine with it? > > I have commitred the patch to trunk

[gomp4] Additional tests

2015-07-15 Thread James Norris
Hi, The attached patch add tests for combined directives for, i.e., the parallel + loop directive and the kernel + loop directive for C/C++/Fortran. Tests also added for the private, num_gangs, num_workers, and vector_length clauses with the parallel directive in Fortran. Jim diff --git a/libgom

Re: [PATCH] fix in-tree-binutils builds

2015-07-15 Thread H.J. Lu
On Wed, Jul 15, 2015 at 1:03 AM, Jan Beulich wrote: > Quite a while ago configure.in go renamed to configure.ac in all of > binutils' subtrees - allow for both when checking for that case while > configuring. > > gcc/ > 2015-07-15 Jan Beulich > > * acinclude.m4: Replace configure.in by

Re: [PATCH] fix in-tree-binutils builds

2015-07-15 Thread Jan Beulich
>>> On 15.07.15 at 18:07, wrote: > On Wed, Jul 15, 2015 at 1:03 AM, Jan Beulich wrote: >> --- a/gcc/acinclude.m4 >> +++ b/gcc/acinclude.m4 >> @@ -390,7 +390,7 @@ AC_DEFUN([_gcc_COMPUTE_GAS_VERSION], >> [gcc_cv_as_bfd_srcdir=`echo $srcdir | sed -e 's,/gcc$,,'`/bfd >> for f in $gcc_cv_as_bfd_srcd

Re: [PATCH] fix in-tree-binutils builds

2015-07-15 Thread H.J. Lu
On Wed, Jul 15, 2015 at 9:11 AM, Jan Beulich wrote: On 15.07.15 at 18:07, wrote: >> On Wed, Jul 15, 2015 at 1:03 AM, Jan Beulich wrote: >>> --- a/gcc/acinclude.m4 >>> +++ b/gcc/acinclude.m4 >>> @@ -390,7 +390,7 @@ AC_DEFUN([_gcc_COMPUTE_GAS_VERSION], >>> [gcc_cv_as_bfd_srcdir=`echo $srcdir

[committed] check_GNU_style.sh: Fix quoting in cat_with_prefix

2015-07-15 Thread Tom de Vries
Hi, I've committed this obvious fix. Thanks, - Tom check_GNU_style.sh: Fix quoting in cat_with_prefix 2015-07-15 Tom de Vries * check_GNU_style.sh (cat_with_prefix): Fix quoting. diff --git a/contrib/check_GNU_style.sh b/contrib/check_GNU_style.sh index 033a2c9..ac54ed0 100755 --- a/contr

[patch] options.h and comments on a couple of tm.h #include's

2015-07-15 Thread Andrew MacLeod
I think this is the last patch before I start include reductions and cleanups. options.h is generated with the following snippet: /* Anything that includes tm.h, does not necessarily need this. */" #if !defined(GCC_TM_H) #include "input.h" /* for location_t */ <...> // bunch of prototypes whic

Re: [patch] Adjust *-streamer.h

2015-07-15 Thread Jeff Law
On 07/14/2015 02:25 PM, Andrew MacLeod wrote: THIs patch just does a minor cleanup.. gimple-pretty-print.h doesn't need to include pretty-print.h since tree-pretty-print.h already does. I also cleaned up the 4 streamer files, such that each one includes just the previous one, and then make each

Re: [PATCH] fix in-tree-binutils builds

2015-07-15 Thread Mike Stump
On Jul 15, 2015, at 9:07 AM, H.J. Lu wrote: > On Wed, Jul 15, 2015 at 1:03 AM, Jan Beulich wrote: >> >> - $gcc_cv_as_gas_srcdir/configure.in \ >> + $gcc_cv_as_gas_srcdir/configure.[ai][cn] \ >> $gcc_cv_as_gas_srcdir/Makefile.in ; do >> gcc_cv_gas_version=`sed -n -e 's/

Re: [patch] options.h and comments on a couple of tm.h #include's

2015-07-15 Thread Jeff Law
On 07/15/2015 10:32 AM, Andrew MacLeod wrote: I think this is the last patch before I start include reductions and cleanups. options.h is generated with the following snippet: /* Anything that includes tm.h, does not necessarily need this. */" #if !defined(GCC_TM_H) #include "input.h" /* for l

[Patch ARM] Switch to unified asm for ARM state in the compiler.

2015-07-15 Thread Ramana Radhakrishnan
Hi, This patch switches A32 (ARM) state code generation to unified syntax. The backend already generates unified syntax in Thumb state and for the floating point / SIMD instruction set. The backend still continues to use divided syntax for inline assembler. This is beneficial for a few reason

Re: [PATCH] rs6000: Revamp rotate-and-mask and insert

2015-07-15 Thread Segher Boessenkool
On Wed, Jul 15, 2015 at 12:10:51PM +0930, Alan Modra wrote: > There are one or two regressions related to a TODO that Segher added. > The following produces poorer code than mainline. Yes, that's why it says TODO :-) > Also, rs6000.md patterns uses SImode for the rotate/shift count. > Segher has

[committed] Add kernels-loop-nest-independent.f95

2015-07-15 Thread Tom de Vries
[ was: Re: [gomp4] New test loop independent clause ] On 15/07/15 12:43, Tom de Vries wrote: I'm not sure if I mentioned it at the meeting, but marking the outer loop of that example as independent does not result in parallelization either. So that's something to be investigated. I've got it w

[gomp4, committed] Add c-c++-common/goacc/kernels-loop-nest-independent.c

2015-07-15 Thread Tom de Vries
Hi, this patch adds a testcase testing the independent clause on outer loop in oacc kernels region. Committed to gomp-4_0-branch. Thanks, - Tom Add c-c++-common/goacc/kernels-loop-nest-independent.c 2015-07-15 Tom de Vries * c-c++-common/goacc/kernels-loop-nest-independent.c: New test.

PATCH trunk GCCJIT: adding gcc_jit_context_new_rvalue_from_long_long, etc...

2015-07-15 Thread Basile Starynkevitch
Hello All and David Malcolm The attached patch (relative to trunk r224842) is adding gcc_jit_context_new_rvalue_from_long_long and similar functions to GCCJIT. It is bootstrapping, but I don't have any test cases ## gcc/jit/ChangeLog entry: 2015-07-15 Basile Starynkevitch * libg

[gomp] Fix PTX unloading

2015-07-15 Thread Nathan Sidwell
This patch reworks my previous one to just deal with the PTX-specific unloading breakage. I don't change the API between libgomp and the plugins, and fixup the PTX plugin to have per-device instance lists of loaded programs. As with the previous patch, we fix an ordering problem by unloading t

Re: [PATCH] Add 'switch' statement to match.pd language

2015-07-15 Thread Richard Sandiford
Michael Matz writes: >> >> (switch >> >> (A) B >> >> (B) C >> >> (C) D >> >> E) >> > >> >The lispy way would have been >> > >> > (switch >> >(A) (B) >> >(C) (D) >> >(E) (F) >> >G) >> > >> >i.e. parenthesize the result as well, which then would be unambiguously >> >> Tha

Re: [PR66726] Factor conversion out of COND_EXPR

2015-07-15 Thread Jeff Law
On 07/15/2015 01:09 AM, Kugan wrote: 2015-07-15 Kugan Vivekanandarajah PR middle-end/66726 * tree-ssa-reassoc.c (optimize_range_tests): Handle sinking the cast after PHI. (final_range_test_p): Detect sinking the cast after PHI. (maybe_optimize_range_tests): Hand

Re: [PATCH][DRIVER] Wrong C++ include paths when configuring with "--with-sysroot=/"

2015-07-15 Thread Jeff Law
On 07/15/2015 02:34 AM, Yvan Roux wrote: Hi, (Sorry for the delay I'm just back from a long sick leave) There is this old patch submitted by Matthias on that same issue, if its logic is the right one for you Joseph I can rebase/validate it Joseph. https://gcc.gnu.org/ml/gcc-patches/2012-02/ms

[nvptx] C++ify mkoffloads

2015-07-15 Thread Nathan Sidwell
I've applied this obvious patch to trunk to make mkoffloads work for C++. The equivalent is already on the gomp4 branch. nathan 2015-07-15 Nathan Sidwell * config/nvptx/mkoffload.c (process): Add C++ protection to emitted code. Index: config/nvptx/mkoffload.c

Re: [gomp] Fix PTX unloading

2015-07-15 Thread Ilya Verbin
On Wed, Jul 15, 2015 at 14:36:45 -0400, Nathan Sidwell wrote: > -= devicep->load_image_func (devicep->target_id, target_data, > &target_table); > += devicep->load_image_func (devicep->target_id, target_data, > + &target_table); It was exactly 80 chars long :)

Re: PATCH trunk GCCJIT: adding gcc_jit_context_new_rvalue_from_long_long, etc...

2015-07-15 Thread David Malcolm
On Wed, 2015-07-15 at 20:19 +0200, Basile Starynkevitch wrote: > Hello All and David Malcolm > > The attached patch (relative to trunk r224842) is adding > gcc_jit_context_new_rvalue_from_long_long and similar functions to > GCCJIT. Thanks. [CCing the jit mailing list; please CC patches affecti

Re: [PATCH][4/n] Remove GENERIC stmt combining from SCCVN

2015-07-15 Thread Jeff Law
On 07/14/2015 05:37 AM, Richard Biener wrote: On Tue, 14 Jul 2015, Richard Biener wrote: On Mon, 13 Jul 2015, Jeff Law wrote: 2015-07-13 Richard Biener * tree-ssa-dom.c (record_temporary_equivalences): Merge wideing type conversion case from record_equivalences_from_incomi

fixup gomp register/unregister prototypes

2015-07-15 Thread Nathan Sidwell
I'm almost tempted to commit as obvious. I noticed that the callers of these functions from code generated by mkoffload declare the 2nd arg as an int, because they have no visibility of the enum. I thought it wise to make the definitions match. ok for trunk? nathan 2015-07-15 Nathan Sidwel

Re: [PATCH][4/n] Remove GENERIC stmt combining from SCCVN

2015-07-15 Thread Andrew MacLeod
On 07/15/2015 03:01 PM, Jeff Law wrote: On 07/14/2015 05:37 AM, Richard Biener wrote: On Tue, 14 Jul 2015, Richard Biener wrote: Applied. The following patch adds the equivalences for the destination of use stmts if they simplify. Actually I can't use FOR_EACH_IMM_USE_STMT any longer becau

Re: PATCH trunk GCCJIT: adding gcc_jit_context_new_rvalue_from_long_long, etc...

2015-07-15 Thread Basile Starynkevitch
On 07/15/2015 20:52, David Malcolm wrote: On Wed, 2015-07-15 at 20:19 +0200, Basile Starynkevitch wrote: Hello All and David Malcolm The attached patch (relative to trunk r224842) is adding gcc_jit_context_new_rvalue_from_long_long and similar functions to GCCJIT. Does this actually link and ru

Re: PATCH trunk GCCJIT: adding gcc_jit_context_new_rvalue_from_long_long, etc...

2015-07-15 Thread David Malcolm
On Wed, 2015-07-15 at 21:15 +0200, Basile Starynkevitch wrote: > On 07/15/2015 20:52, David Malcolm wrote: > > On Wed, 2015-07-15 at 20:19 +0200, Basile Starynkevitch wrote: > >> Hello All and David Malcolm > >> > >> The attached patch (relative to trunk r224842) is adding > >> gcc_jit_context_new_

[PATCH, PR66846] Mark inner loop for fixup in parloops

2015-07-15 Thread Tom de Vries
Hi, I. In openmp expansion of loops, we do some effort to try to create matching loops in the loop state of the child function, f.i.in expand_omp_for_generic: ... struct loop *outer_loop; if (seq_loop) outer_loop = l0_bb->loop_father; else { outer_l

  1   2   >