Re: [patch,avr] Fix PR 65657 - read from __memx address space tramples arguments to function call

2015-04-16 Thread Senthil Kumar Selvaraj
On Thu, Apr 16, 2015 at 11:02:05AM +0200, Georg-Johann Lay wrote: > Am 04/16/2015 um 08:43 AM schrieb Senthil Kumar Selvaraj: > >This patch fixes PR 65657. > > The following artifact appears to be PR63633. > I did see that one - unfortunately, that fix won't help here. IIUC, you check if input/o

Re: [PING][PATCH][4.9]Backport "Fix register corruption bug in ree"

2015-04-16 Thread Renlin Li
Ping~ Regards, Renlin Li On 16/04/15 10:09, wrote: Ping~ Anybody has time to review it? Regards, Renlin Li On 06/02/15 17:48, Renlin Li wrote: Hi all, This is a backport patch for branch 4.9. You can find the original=20 patch here:https://gcc.gnu.org/ml/gcc-patches/2014-09/msg00356.html A

[Patch/rtl-expand] Take tree range info into account to improve LSHIFT_EXP expanding

2015-04-16 Thread Jiong Wang
This is a rework of https://gcc.gnu.org/ml/gcc-patches/2014-07/msg01998.html After second thinking, I feel it's better to fix this in earlier stage during RTL expand which is more generic, and we also avoid making the already complex combine pass complexer. Currently gcc expand wide mode left

[PATCH, i386]: Rewrite print_reg

2015-04-16 Thread Uros Bizjak
Hello! Attached patch rewrites print_reg to optimize it and make it more readable. Currently, it looks like 64bit registers were bolted on as an afterthought. 2015-04-16 Uros Bizjak * config/i386/i386.c (print_reg): Rewrite function. Bootstrapped and regression tested on x86_64-linux-gnu

[PATCH] -Warray-bounds TLC

2015-04-16 Thread Richard Biener
The following applies the patch produced earlier this year, applying TLC to array bound warnings and catching a few more cases. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied. Richard. 2015-04-16 Richard Biener PR tree-optimization/64277 * tree-vrp.c (check_arr

[PATCH] Fix PR65774

2015-04-16 Thread Richard Biener
The following avoids invoking bit-tracking on complex types which have zero TYPE_PRECISION where wi::sext () invokes undefined behavior. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied to trunk. Richard. 2015-04-16 Richard Biener PR tree-optimization/65774 * tre

LTO early debug

2015-04-16 Thread Richard Biener
The LTO early debug info prototype project has been completed. The provided patch against the debug-early branch shows that the general idea is sound and works. Now on to the details. What works? --- Simple C and C++ testcases (didn't test more), esp. now libstdc++ pretty-printers fi

Re: [C++ Patch] PR 65340

2015-04-16 Thread Paolo Carlini
Hi again, On 04/15/2015 03:31 AM, Jason Merrill wrote: There are various places in the compiler that error and continue if tf_error is set, but return error_mark_node immediately if not; it seems reasonable to follow that pattern in the places that don't currently check the return value. Thus

[Obvious][AArch64 Testsuite] Fix comments in vldN_lane_1.c

2015-04-16 Thread Alan Lawrence
The comments in vldN_lane_1.c say it is testing vld{1,2,3}{,q}_dup. This is wrong, it is testing vld{1,2,3}{,q}_lane, as per test filename; I've pushed the attached as r222148. gcc/testsuite/ChangeLog: gcc.target/aarch64/vldN_lane_1.c: Correct dup->lane in comments. diff --git a/gcc/t

Re: [PATCH] Save an instruction with -mprofile-kernel style profiling

2015-04-16 Thread David Edelsohn
On Wed, Apr 15, 2015 at 9:57 PM, Anton Blanchard wrote: > Save an instruction with -mprofile-kernel style profiling and require > the mcount handler to save the LR to the stack. > > -mprofile-kernel is an undocumented gcc option that was introduced > specifically for the Linux kernel, so it should

Re: [PATCH] libstdc++: Fix exceptions being generated when compiling with -fno-exceptions

2015-04-16 Thread Federico Lenarduzzi
Jonathan, I don't have commit access though, so if you could commit this for me it'd be great. Regards. 2015-04-15 11:55 GMT-03:00 Jonathan Wakely : > On 15/04/15 11:15 -0300, Federico Lenarduzzi wrote: >> >> The idea of this patch is that using this function not depends from a >> configuration

Re: [PATCH] libstdc++: Fix exceptions being generated when compiling with -fno-exceptions

2015-04-16 Thread Jonathan Wakely
On 16/04/15 11:20 -0300, Federico Lenarduzzi wrote: Jonathan, I don't have commit access though, so if you could commit this for me it'd be great. Yes, but I'm waiting until I do the uncaught_exceptions() commit.

Re: [C++ Patch] PR 65340

2015-04-16 Thread Jason Merrill
OK, thanks. Jason

Re: [PATCH] Do not discard the constructors of empty structs [PR c++/64527]

2015-04-16 Thread Jason Merrill
On 04/15/2015 09:00 PM, Patrick Palka wrote: - if (!cleared || num_nonzero_elements > 0) How about adding || TREE_SIDE_EFFECTS (TREE_OPERAND (*expr_p), 1) to this test rather than removing it entirely? Jason

Re: [Patch][testsuite,i386]: Remove include of values.h from avx512

2015-04-16 Thread Kirill Yukhin
Hello, Thanks! On 15 Apr 12:30, Ryan Mansfield wrote: > OK for trunk and gcc-5-branch? The patch is OK for trunk and gcc-5-branch (when it is open). -- K

Re: [libstdc++ PATCH] Add support for std::uncaught_exceptions

2015-04-16 Thread Jonathan Wakely
On 15/04/15 14:10 -0300, Daniel Gutson wrote: You might want to check this thread https://gcc.gnu.org/ml/libstdc++/2015-04/msg00104.html which is specially useful when creating multilibs with and without exceptions and enabling linker's sections garbage collection. Maybe you could commit the chan

Re: [PATCH] Do not discard the constructors of empty structs [PR c++/64527]

2015-04-16 Thread Patrick Palka
On Thu, 16 Apr 2015, Jason Merrill wrote: On 04/15/2015 09:00 PM, Patrick Palka wrote: - if (!cleared || num_nonzero_elements > 0) How about adding || TREE_SIDE_EFFECTS (TREE_OPERAND (*expr_p), 1) to this test rather than removing it entirely? That works too. Does the following patc

[RFC stage 1] Proposed new warning: -Wmisleading-indentation

2015-04-16 Thread David Malcolm
Attached is a work-in-progress patch for a new -Wmisleading-indentation warning I've been experimenting with, for GCC 6. It kind-of-works, but there are some issues, so I wanted to get feedback on it here. The idea is to issue a warning when the C/C++ compiler's view of the block structure does

[C++ Patch] Rename tsubst_flags_t function parameter

2015-04-16 Thread Paolo Carlini
Hi, while working on the last patch I noticed that in a couple of functions in class.c we name the tsubst_flags_t parameter flags instead of complain. Besides the inconsistency, I find that choice especially misleading, because normally in the front end a parameter of name flags is just an in

[committed, PATCH]: Replace __buitlin_alloca with __builtin_alloca

2015-04-16 Thread H.J. Lu
I checked this patch into trunk and will backport it to GCC 5 branch. H.J. --- Index: ChangeLog === --- ChangeLog (revision 222150) +++ ChangeLog (working copy) @@ -1,3 +1,8 @@ +2015-04-16 H.J. Lu + + * gcc.target/i386/m

Re: [committed, PATCH]: Replace __buitlin_alloca with __builtin_alloca

2015-04-16 Thread Jakub Jelinek
On Thu, Apr 16, 2015 at 08:35:27AM -0700, H.J. Lu wrote: > I checked this patch into trunk and will backport it to GCC 5 branch. Ok for GCC 5 branch now. > --- ChangeLog (revision 222150) > +++ ChangeLog (working copy) > @@ -1,3 +1,8 @@ > +2015-04-16 H.J. Lu > + > + * gcc.target/i386/mpx/a

Re: PATCH] PR target/65612: Multiversioning doesn't work with DSO nor PIE

2015-04-16 Thread Mike Stump
On Apr 14, 2015, at 8:07 AM, H.J. Lu wrote: >> I can confirm that the most current patch bootstraps on >> x86_64-apple-darwin14 and that all of the new tests show up as >> unsupported in the test suite. >> Jack > > I am re-posting this patch. OK for trunk? If Jack is happy, I’m happy.

Re: [patch,avr] Fix PR 65657 - read from __memx address space tramples arguments to function call

2015-04-16 Thread Georg-Johann Lay
Am 04/16/2015 um 11:28 AM schrieb Senthil Kumar Selvaraj: On Thu, Apr 16, 2015 at 11:02:05AM +0200, Georg-Johann Lay wrote: Am 04/16/2015 um 08:43 AM schrieb Senthil Kumar Selvaraj: This patch fixes PR 65657. The following artifact appears to be PR63633. I did see that one - unfortunately,

Re: [patch,avr] Fix PR 65657 - read from __memx address space tramples arguments to function call

2015-04-16 Thread Georg-Johann Lay
...and the sketch against 4.9 Index: config/avr/avr.c === --- config/avr/avr.c (revision 221321) +++ config/avr/avr.c (working copy) @@ -287,6 +287,94 @@ avr_to_int_mode (rtx x) } +static void +avr_rest_of_handle_expand_xload (vo

RE: [PATCH v2][MIPS] fix CRT_CALL_STATIC_FUNCTION macro

2015-04-16 Thread Petar Jovanovic
-Original Message- From: Moore, Catherine [mailto:catherine_mo...@mentor.com] Sent: Friday, February 13, 2015 2:37 AM To: Petar Jovanovic; 'Matthew Fortune'; gcc-patches@gcc.gnu.org; 'Maciej W. Rozycki' Cc: Moore, Catherine Subject: RE: [PATCH v2][MIPS] fix CRT_CALL_STATIC_FUNCTION macro

Re: [patch,avr] Fix PR 65657 - read from __memx address space tramples arguments to function call

2015-04-16 Thread Denis Chertykov
2015-04-16 19:47 GMT+03:00 Georg-Johann Lay : > > Am 04/16/2015 um 11:28 AM schrieb Senthil Kumar Selvaraj: >> >> On Thu, Apr 16, 2015 at 11:02:05AM +0200, Georg-Johann Lay wrote: >>> >>> Am 04/16/2015 um 08:43 AM schrieb Senthil Kumar Selvaraj: This patch fixes PR 65657. >>> >>> >>> The

Re: [RFC stage 1] Proposed new warning: -Wmisleading-indentation

2015-04-16 Thread Mike Stump
On Apr 16, 2015, at 8:01 AM, David Malcolm wrote: > Attached is a work-in-progress patch for a new > -Wmisleading-indentation > warning I've been experimenting with, for GCC 6. Seems like a nice idea in general. Does it also handle: if (cone); stmt; ? Would be good to add that to the test

[PATCH][AArch64] Fix PR/65770 vstN_lane on bigendian

2015-04-16 Thread Alan Lawrence
As per bugzilla entry, indices in the generated assembly for bigendian are flipped when they should not be (and, flipped always relative to a Q-register!). This flips the lane indices back again at assembly time, fixing PR. The "indices" contained in the RTL are still wrong for D registers, but

RE: [PATCH v2][MIPS] fix CRT_CALL_STATIC_FUNCTION macro

2015-04-16 Thread Maciej W. Rozycki
On Thu, 16 Apr 2015, Petar Jovanovic wrote: > > There isn't any need to execute a large testcase. Instead, try adding a > short version of your test to the directory gcc/testsuite/gcc.target/mips. > > There are examples of other tests there they check for specific assembler > sequences by using s

Re: [RFC stage 1] Proposed new warning: -Wmisleading-indentation

2015-04-16 Thread Manuel López-Ibáñez
On 16/04/15 17:01, David Malcolm wrote: Attached is a work-in-progress patch for a new -Wmisleading-indentation warning I've been experimenting with, for GCC 6. It sounds very cool... (D) tabs vs spaces. This is probably the biggest can of worms. I would suggest to be very conservative

Re: [PATCH, i386]: Merge *_sse patterns with *_mixed using enabled attribute.

2015-04-16 Thread Uros Bizjak
Hello! This part merges *fop__1_sse with *fop__1_mixed. 2015-04-16 Uros Bizjak * config/i386/predicates.md (register_mixssei387nonimm_operand): New. * config/i386/i386.md (*fop__1_mixed): Merge with *fop__1_sse using enabled attribute. Use register_mixssei387nonimm_operand op

[PATCH] PR target/65780: [5/6 Regression] Uninitialized common handling in executables

2015-04-16 Thread H.J. Lu
Uninitialized common symbol behavior in executables is target and linker dependent. default_binds_local_p_3 is made public and updated to take an argument to indicate if common symbol may be local. If common symbol may be local, default_binds_local_p_3 will treat non-external variable as defined

Re: [Patch, Fortran, pr60322, addendum] was: [Patch 1/2, Fortran, pr60322] [OOP] Incorrect bounds on polymorphic dummy array

2015-04-16 Thread Paul Richard Thomas
Hi Andre, The delta patch is OK for trunk and eventual backport to 5.2. Thanks for all the hard work Paul On 14 April 2015 at 19:00, Andre Vehreschild wrote: > Hi all, > > during further testing of a big Fortran software I encounter two bugs with > class arrays, that are somehow connected to p

Re: [PATCH] Do not discard the constructors of empty structs [PR c++/64527]

2015-04-16 Thread Jason Merrill
OK. Jason

Re: [PATCH] Fix PR65204

2015-04-16 Thread H.J. Lu
On Mon, Apr 13, 2015 at 7:03 PM, H.J. Lu wrote: > On Wed, Feb 25, 2015 at 5:26 AM, Richard Biener wrote: >> >> This fixes missed tracking of alignment of non-invariant addresses >> in CCP. >> >> Bootstrapped and tested on x86_64-unknown-linux-gnu, queued for GCC 6. >> >> Richard. >> >> 2015-02-25

Re: [PATCH V2] IRA: Speed up setup_left_conflict_sizes_p

2015-04-16 Thread Jeff Law
On 03/11/2015 07:34 PM, Zhouyi Zhou wrote: From: Zhouyi Zhou In function setup_left_conflict_sizes_p, left conflict subnodes sizes are computed in a bottom-to-up fashion through the regnodes foreast. Speed up the process from prevent node itself to involve in this computation. I have no write

[C++ PATCH PING] Reject trailing return type for operator auto()

2015-04-16 Thread Ville Voutilainen
On 28 December 2014 at 20:21, Ville Voutilainen wrote: > Any comments on this? Re-ping. :) The original message is https://gcc.gnu.org/ml/gcc-patches/2014-12/msg01614.html > > On 19 December 2014 at 09:21, Ville Voutilainen > wrote: >> Tested on Linux-x64. >> >> /cp >> 2014-12-19 Ville Voutila

[PATCH] fix PR target/65535

2015-04-16 Thread Andreas Tobler
Hi all, the below is an attempt to warn a user when she/he builds a cross compiler for *-*-freebsd* without giving a major version number. Ok for trunk? Thanks, Andreas 2015-04-16 Andreas Tobler * config.gcc: Exit with a comment when we do not have a major version number f

RE: [PATCH v2][MIPS] fix CRT_CALL_STATIC_FUNCTION macro

2015-04-16 Thread Moore, Catherine
> -Original Message- > From: Maciej W. Rozycki [mailto:ma...@linux-mips.org] > Sent: Thursday, April 16, 2015 2:23 PM > To: Petar Jovanovic > Cc: Moore, Catherine; 'Matthew Fortune'; gcc-patches@gcc.gnu.org > Subject: RE: [PATCH v2][MIPS] fix CRT_CALL_STATIC_FUNCTION macro > > On Thu, 16

Re: [C++ Patch] Rename tsubst_flags_t function parameter

2015-04-16 Thread Jason Merrill
OK. Jason

[PATCH] Fix dwarf2out ICE (PR debug/65771)

2015-04-16 Thread Jakub Jelinek
Hi! As mentioned in the PR, on the following testcase we ICE, because for # DEBUG D#2 => b # DEBUG D#1 => a[D#2].t # DEBUG c => D#1 during expansion we get the a[D#2].t added as MEM_EXPR of a MEM, and because we can't mem_loc_descriptor that MEM (I'll post separately a trunk only patch that

[PATCH, 5.1, rs6000] Fix PR65787

2015-04-16 Thread Bill Schmidt
Hi, https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65787 identifies an issue where the powerpc64le vector swap optimization miscompiles some code. The code for handling vector extract operations did not expect to find those operations wrapped in a PARALLEL with a CLOBBER, but this test shows that th

[PATCH] Improve debug info generation for TLS + const (PR debug/65771)

2015-04-16 Thread Jakub Jelinek
On Thu, Apr 16, 2015 at 11:11:06PM +0200, Jakub Jelinek wrote: > during expansion we get the a[D#2].t added as MEM_EXPR of a MEM, and because > we can't mem_loc_descriptor that MEM (I'll post separately a trunk only > patch that fixes that in this case, but generally not all MEMs can be > represent

[patch, c, ping] Fix PR c/48956: diagnostics for conversions involving complex types (reviewed)

2015-04-16 Thread Mikhail Maltsev
I would like to ping the following patch: https://gcc.gnu.org/ml/gcc-patches/2014-12/msg01925.html Review: https://gcc.gnu.org/ml/gcc-patches/2015-01/msg02672.html I fixed minor issues mentioned in the review and updated the changelog message. Rebased on current trunk (r222157), bootstrapped and r

Re: [PR65768] Check rtx_cost when propagating constant

2015-04-16 Thread Kugan
On 15/04/15 21:18, Richard Biener wrote: > On Wed, Apr 15, 2015 at 11:05 AM, Steven Bosscher > wrote: >> On Wed, Apr 15, 2015 at 9:53 AM, Kugan wrote: >>> 2015-04-15 Kugan Vivekanandarajah < > >>> Zhenqiang Chen <> >>> >>> PR target/65768 >>> * cprop.c (try_replac

[PATCH] remove need for store_values_directly

2015-04-16 Thread tbsaunde+gcc
From: Trevor Saunders Hi, Last stage 1 I introduced a second form of hash_table that stored elements of value_type in addition to the old form that stored elements of type value_type *. That lead to a fair bit of code dupplication in hash_table, but it simplified the transition by allowing it t

Re: [PATCH] Fix inlining checks wrt optimize attribute

2015-04-16 Thread Christian Bruel
On 01/22/2015 11:33 AM, Richard Biener wrote: > On Thu, 22 Jan 2015, Christian Bruel wrote: > >> Hi Richard, >> >> I thought one of my current issue would be solved by this patch, but it is >> not >> : I have some inlining failures with the attribute target on ARM. (e.g >> inline-3.c) where obvio

[PATCH] Perform more pattern matching during SSA propagation

2015-04-16 Thread Richard Biener
The following is an old patch that teaches the SSA propagator to mark stmts it will never re-visit again and thus are safe for pattern matching. Re-bootstrapped and tested on x86_64-unknown-linux-gnu, applied. Richard. 2015-04-16 Richard Biener * tree-ssa-ccp.c (likely_value): See i

Re: unused comparison warning (bug 62182)

2015-04-16 Thread Marek Polacek
On Thu, Apr 16, 2015 at 12:51:33AM +0200, Arnaud Bienner wrote: > Hi, > > I've submitted a patch to bug 62182 [1], and I would like to have some > feedback about it (this is still WIP as noted in the bug). > As it is my first patch to gcc, I'm not sure what is the best way to > discuss/review patc

RE: [PATCH, GCC, stage1] Fallback to copy-prop if constant-prop not possible

2015-04-16 Thread Thomas Preud'homme
> From: Jeff Law [mailto:l...@redhat.com] > Sent: Monday, April 13, 2015 8:48 PM > > I know there were several followups between Steven and yourself. > With > stage1 now open, can you post a final version and do a final > bootstrap/test with it? Here is what came out of our discussion with Steven

[PING^2] [PATCH][5a/5] Postpone expanding va_arg until pass_stdarg

2015-04-16 Thread Tom de Vries
[stage1 ping^2] On 10-03-15 16:30, Tom de Vries wrote: [stage1 ping] On 22-02-15 14:13, Tom de Vries wrote: On 19-02-15 14:03, Richard Biener wrote: On Thu, 19 Feb 2015, Tom de Vries wrote: On 19-02-15 11:29, Tom de Vries wrote: Hi, I'm posting this patch series for stage1: - 0001-Disable-l

[PING^2] [PATCH][5b/5] Avoid running expand_ifn_va_arg_1 in functions without va_arg

2015-04-16 Thread Tom de Vries
[stage1 ping^2] On 10-03-15 16:31, Tom de Vries wrote: [stage1 ping] [was: Postpone expanding va_arg until pass_stdarg] On 24-02-15 07:48, Tom de Vries wrote: On 23-02-15 11:09, Tom de Vries wrote: On 23-02-15 09:26, Michael Matz wrote: Hi, On Sun, 22 Feb 2015, Tom de Vries wrote: Btw, I'm

Re: [PING^2] [PATCH][5a/5] Postpone expanding va_arg until pass_stdarg

2015-04-16 Thread Richard Biener
On Thu, 16 Apr 2015, Tom de Vries wrote: > [stage1 ping^2] > On 10-03-15 16:30, Tom de Vries wrote: > > [stage1 ping] > > On 22-02-15 14:13, Tom de Vries wrote: > > > On 19-02-15 14:03, Richard Biener wrote: > > > > On Thu, 19 Feb 2015, Tom de Vries wrote: > > > > > > > > > On 19-02-15 11:29, Tom

Re: [PING^2] [PATCH][5b/5] Avoid running expand_ifn_va_arg_1 in functions without va_arg

2015-04-16 Thread Richard Biener
On Thu, 16 Apr 2015, Tom de Vries wrote: > [stage1 ping^2] > On 10-03-15 16:31, Tom de Vries wrote: > > [stage1 ping] > > [was: Postpone expanding va_arg until pass_stdarg] > > On 24-02-15 07:48, Tom de Vries wrote: > > > On 23-02-15 11:09, Tom de Vries wrote: > > > > On 23-02-15 09:26, Michael Ma

Re: [patch,avr] Fix PR 65657 - read from __memx address space tramples arguments to function call

2015-04-16 Thread Georg-Johann Lay
Am 04/16/2015 um 08:43 AM schrieb Senthil Kumar Selvaraj: This patch fixes PR 65657. The following artifact appears to be PR63633. When cfgexpand.c expands a function call, it first figures out the registers in which the arguments will go, followed by expansion of the arguments themselves (ri