Re: [PATCH][OpenMP] Fix named critical sections inside target functions

2014-11-21 Thread H.J. Lu
On Fri, Nov 21, 2014 at 1:08 PM, Ilya Verbin wrote: >> On 21 Nov 2014, at 23:36, Jakub Jelinek wrote: >> >>> On Fri, Nov 21, 2014 at 11:19:26PM +0300, Ilya Verbin wrote: >>> Hi, >>> >>> '#pragma omp critical (name)' can be placed in the function, marked >>> with '#pragma omp declare target', in t

Re: [PATCH][OpenMP] Fix named critical sections inside target functions

2014-11-21 Thread Jakub Jelinek
On Sat, Nov 22, 2014 at 12:08:38AM +0300, Ilya Verbin wrote: > > On 21 Nov 2014, at 23:36, Jakub Jelinek wrote: > > > >> On Fri, Nov 21, 2014 at 11:19:26PM +0300, Ilya Verbin wrote: > >> Hi, > >> > >> '#pragma omp critical (name)' can be placed in the function, marked > >> with '#pragma omp decl

Re: [PATCH][OpenMP] Fix named critical sections inside target functions

2014-11-21 Thread Ilya Verbin
> On 22 Nov 2014, at 00:11, H.J. Lu wrote: > > Have you fixed the offloading issue with binutils 2.25? No, I'm still thinking how to make a patch better than the former... Probably will send it on Monday. (Regressions in make check disappeared after disabling offload IR in default configura

RE: [PATCH,MIPS] Refine configure guard for .module availability

2014-11-21 Thread Matthew Fortune
Matthew Fortune writes: > (I'm not sure if I need approval from someone else for MIPS specific > top level 'configure' changes. I'm cautiously assuming I do for now.) FWIW, MIPS maintainership covers all MIPS-specific code and documentation (except for externally-maintained code) so you don't

C++ PATCH for c++/63849 (mangling crash with alias template)

2014-11-21 Thread Jason Merrill
An alias or typedef to a template type parameter is not itself a template type parameter. Tested x86_64-pc-linux-gnu, applying to trunk and 4.9. commit 89ffb512bb8120b0e4bd919a941c44876a6a8ce3 Author: Jason Merrill Date: Fri Nov 21 13:55:11 2014 -0500 PR c++/63849 * mangle.c (decl_

patch to fix PR63897

2014-11-21 Thread Vladimir Makarov
The following patch fixes PR63897. The details can be found on https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63897 The patch was successfully bootstrapped and tested on x86 and x86-64. Committed as rev. 217947. 2014-11-21 Vladimir Makarov PR target/63897 * lra-lives.c (mark

C++ PATCH for c++/63942 (mangling compat alias problems)

2014-11-21 Thread Jason Merrill
In this testcase, the wrong old mangling for one constructor matches the correct mangling for the other constructor, and the testcase was failing to compile as a result. But compatibility aliases should not be treated as conflicting with real declarations; they should be discarded. Tested x86

C++ PATCH for c++/63588 (ICE with empty template args to variable template)

2014-11-21 Thread Jason Merrill
uses_template_parms ought to be able to deal with NULL_TREE. Tested x86_64-pc-linux-gnu, applying to trunk. commit 3a85a7bd7ea664fb594843433c51f3b6cbb320d3 Author: Jason Merrill Date: Fri Nov 21 13:46:34 2014 -0500 PR c++/63588 * pt.c (uses_template_parms): Handle null argument. di

Re: [PATCH v2] gcc/ubsan.c: Use 'pretty_print' for 'pretty_name' to avoid memory overflow

2014-11-21 Thread Jakub Jelinek
On Sat, Nov 22, 2014 at 05:03:37AM +0800, Chen Gang wrote: > According to the next code, 'pretty_name' may need additional bytes more > than 16 (may have unlimited length for array type). There is an easy way > to fix it: use 'pretty_print' for 'pretty_name'. > > Let the code meet 2 white spaces a

Re: [PATCH v2] gcc/ubsan.c: Use 'pretty_print' for 'pretty_name' to avoid memory overflow

2014-11-21 Thread Chen Gang
Thank you very much for your work. I shall send patch v3 for it. Thanks. On 11/22/2014 05:57 AM, Jakub Jelinek wrote: > On Sat, Nov 22, 2014 at 05:03:37AM +0800, Chen Gang wrote: >> According to the next code, 'pretty_name' may need additional bytes more >> than 16 (may have unlimited length for

[Patch,MIPS] Add default SYS_futex definition in libgomp

2014-11-21 Thread Steve Ellcey
Here is another patch for the MIPS android build. It is in the libgomp subdirectory and it has been in the Android tree for a while but I would like to check it in to the official GCC tree so we do not need to keep porting it to new versions of GCC. This patch defines SYS_futex if it is not alrea

Re: [Patch,MIPS] Add default SYS_futex definition in libgomp

2014-11-21 Thread Jakub Jelinek
On Fri, Nov 21, 2014 at 02:30:06PM -0800, Steve Ellcey wrote: > 2014-11-21 Steve Ellcey > > * config/linux/mips/futex.h (SYS_futex): Define if not already done. Ok. > --- a/libgomp/config/linux/mips/futex.h > +++ b/libgomp/config/linux/mips/futex.h > @@ -25,6 +25,11 @@ > /* Provide ta

Re: [RFC] First steps towards segregating types.

2014-11-21 Thread Jeff Law
On 11/21/14 11:48, Andrew MacLeod wrote: There are a few issues, of course :-) The biggest issue is what to do with fields which can be either a type or a tree... ie TREE_VALUE() of a TREE_LIST can be a type, as can a TREE_VEC element or a DECL_CONTEXT. I think the DECL_INITIAL field is o

Re: [wwwdocs] Document ARM --with-cpu changes for 5.0

2014-11-21 Thread Jeff Law
On 11/21/14 06:30, James Greenhalgh wrote: Hi, As requested by Ramana when he OKed the initial change, the attched patch documents the changes I made to --with-cpu and --with-tune in this patch: https://gcc.gnu.org/ml/gcc-patches/2014-05/msg02618.html in the changes for GCC 5.0. OK? OK. jef

Re: [RFC] First steps towards segregating types.

2014-11-21 Thread Andrew MacLeod
On 11/21/2014 05:39 PM, Jeff Law wrote: On 11/21/14 11:48, Andrew MacLeod wrote: There are a few issues, of course :-) The biggest issue is what to do with fields which can be either a type or a tree... ie TREE_VALUE() of a TREE_LIST can be a type, as can a TREE_VEC element or a DECL_CONT

Re: [RFC] First steps towards segregating types.

2014-11-21 Thread David Malcolm
On Fri, 2014-11-21 at 21:13 +0100, Richard Biener wrote: > On November 21, 2014 8:45:09 PM CET, Diego Novillo > wrote: > >On Fri, Nov 21, 2014 at 1:48 PM, Andrew MacLeod > >wrote: > > > >> 1 - introduce a TYPE_REF tree node, which is effectively just a > >'typed' tree > >> node, and the TREE_TYPE

Re: [PATCH, MPX runtime 1/2] Integrate MPX runtime library

2014-11-21 Thread Joseph Myers
On Fri, 21 Nov 2014, Ilya Enkovich wrote: > +# Disable libmpx on unsupported systems. > +if test -d ${srcdir}/libmpx; then > +if test x$enable_libmpx = x; then > + AC_MSG_CHECKING([for libmpx support]) > + if (srcdir=${srcdir}/libmpx; \ > + . ${srcdir}/configure.tgt;

Re: [PATCH, MPX runtime 1/2] Integrate MPX runtime library

2014-11-21 Thread Joseph Myers
On Wed, 19 Nov 2014, Ilya Enkovich wrote: > > If it's intended only as the latter - and this is documented - then you > > don't have the libgcc-like requirements, and there's no point in having > > multiple libraries. If it's intended for both, that points the way to > > separate libraries (wh

Re: [PATCH, MPX wrappers 1/3] Add MPX wrappers library

2014-11-21 Thread Joseph Myers
On Fri, 21 Nov 2014, Ilya Enkovich wrote: > * c-family/c.opt (static-libmpxwrappers): New. New options need documenting in invoke.texi. This includes driver options. > diff --git a/libmpx/mpxwrap/mpx_wrappers.c b/libmpx/mpxwrap/mpx_wrappers.c > new file mode 100644 > index 000..bcff8

Re: [RFC] First steps towards segregating types.

2014-11-21 Thread Joseph Myers
On Fri, 21 Nov 2014, Andrew MacLeod wrote: > The biggest issue is what to do with fields which can be either a type or a > tree... ie TREE_VALUE() of a TREE_LIST can be a type, as can a TREE_VEC > element or a DECL_CONTEXT. I think the DECL_INITIAL field is overloaded and > can sometimes be a

[committed] Update config/pa/linux-atomic.c to use new subword and double word atomic support

2014-11-21 Thread John David Anglin
The attached change updates the linux atomic support to use the new kernel calls for subword and double word types. Tested on hppa-unknown-linux-gnu and committed to trunk. The majority of this change, including the kernel patch, was contributed by Guy Martin. Dave -- John David Anglin

[PING][PATCH] Change contrib/test_installed for testing cross compilers

2014-11-21 Thread Steve Ellcey
I noticed I never got a reply to this patch proposal I sent out back in March. Does anyone have an opinion on this? I think it would make testing of installed cross compilers easier. Steve Ellcey sell...@imgtec.com --- Original Email --- I was doing some testing of an

C++ PATCH for c++/63657 (missed unused reference warning)

2014-11-21 Thread Jason Merrill
The earlier fix for 38958 was too broad; we don't want to suppress the unused warning for all references to type with non-trivial destructor, just references bound to a temporary. Tested x86_64-pc-linux-gnu, applying to trunk. commit 725c1c94f7e14cfc5314a86c3504cb33ec1cb74b Author: Jason Merril

Re: [PATCHv4][MIPS] Implement O32 ABI extensions (GCC)

2014-11-21 Thread Andrew Pinski
On Wed, Nov 12, 2014 at 2:56 PM, Matthew Fortune wrote: >> > Moore, Catherine writes: >> > > The patch looks good. Please fix up these couple of nits prior to >> > > committing. >> > >> > OK, thanks for the second read through. One further amendment below, >> > I'll aim to commit later today. >

[Go] Use the static chain as closure parameter from Go

2014-11-21 Thread Richard Henderson
This is the non-gofrontend patch corresponding to https://codereview.appspot.com/180890043/ Ian, I thought I'd sent it out at the same time as the codereview, but I guess it never went. r~ commit 5a78f18cf8cd2160c62472693222cc72bd4379b6 Author: Richard Henderson Date: Tue Oct 7 12:28:55 20

Re: [committed] Update config/pa/linux-atomic.c to use new subword and double word atomic support

2014-11-21 Thread Richard Henderson
On 11/22/2014 01:25 AM, John David Anglin wrote: > #define ABORT_INSTRUCTION asm ("iitlbp %r0,(%sr0, %r0)") ... > +static inline long > +__kernel_cmpxchg2 (void * oldval, void * newval, void *mem, int val_size) > +{ > + register unsigned long lws_mem asm("r26") = (unsigned long) (mem); > + regis

<    1   2