Re: [PATCH 49/50] varasm.c:mark_constants

2014-08-05 Thread Jeff Law
On 08/03/14 08:43, Richard Sandiford wrote: gcc/ * varasm.c (mark_constant): Replace this for_each_rtx callback with... (mark_constants_in_pattern): ...this new function to iterate over all the subrtxes. (mark_constants): Update accordingly. OK. jeff

Re: [PATCH 46/50] var-tracking.c:use_narrower_mode_test

2014-08-05 Thread Jeff Law
On 08/03/14 08:38, Richard Sandiford wrote: gcc/ * var-tracking.c (use_narrower_mode_test): Turn from being a for_each_rtx callback to being a function that examines each subrtx itself. (adjust_mems): Update accordingly. OK. jeff

Re: [PATCH 48/50] varasm.c:const_rtx_hash

2014-08-05 Thread Jeff Law
On 08/03/14 08:42, Richard Sandiford wrote: const_rtx_hash_1 had code to hash all elements of a CONST_VECTOR, but const_rtx_hash also hashes all subrtxes, so we'd end up hashing the same thing twice. This looked unintentional so I just removed the CONST_VECTOR case. If instead it was a delibera

Re: [PATCH 01/50] Add rtl-iter.h

2014-08-05 Thread Richard Henderson
On 08/03/2014 03:39 AM, Richard Sandiford wrote: > +struct rtx_subrtx_bound_info { > + unsigned char start; > + unsigned char count; > +}; Given this structure is only two bytes... > + /* The bounds to use for iterating over subrtxes. */ > + const rtx_subrtx_bound_info *m_bounds; ... wouldn

[PATCH v2] gcc/testsuite: Disable pr44194-1.c for BE Power64/Linux

2014-08-05 Thread Maciej W. Rozycki
On Mon, 4 Aug 2014, Joseph S. Myers wrote: > > except from the newly-added 64-bit little-endian one (according to > > LINUX64_DEFAULT_ABI_ELFv2 defined in rs6000/sysv4le.h and then > > rs6000_return_in_memory) or where the `-mabi=elfv2' option has been used > > (that, regrettably, looks undetec

Re: [PATCH v2] gcc/testsuite: Disable pr44194-1.c for BE Power64/Linux

2014-08-05 Thread David Edelsohn
On Tue, Aug 5, 2014 at 6:57 PM, Maciej W. Rozycki wrote: > On Mon, 4 Aug 2014, Joseph S. Myers wrote: > >> > except from the newly-added 64-bit little-endian one (according to >> > LINUX64_DEFAULT_ABI_ELFv2 defined in rs6000/sysv4le.h and then >> > rs6000_return_in_memory) or where the `-mabi=elfv

Re: Remove unnecessary and harmful fixincludes for Android

2014-08-05 Thread enh
does https://android-review.googlesource.com/103445 look okay? On Tue, Aug 5, 2014 at 12:01 PM, Bruce Korb wrote: > Hi, > > On Tue, Aug 5, 2014 at 10:36 AM, enh wrote: >> you can see the current version of bionic's stdio.h here: >> >> https://android.googlesource.com/platform/bionic/+/master/lib

Re: Remove unnecessary and harmful fixincludes for Android

2014-08-05 Thread Bruce Korb
Hi, Lines 42 & 43 are not needed for fixincludes, but it is your choice. With that change, you should not need to add that test to fixincludes because __gnuc_va_list will be found within the comment and satisfy the "bypass" expression. That was the long way of saying: Looks good to me. On Tue

Re: Remove unnecessary and harmful fixincludes for Android

2014-08-05 Thread enh
On Tue, Aug 5, 2014 at 5:26 PM, Bruce Korb wrote: > Hi, > > Lines 42 & 43 are not needed for fixincludes, but it is your choice. > With that change, you should not need to add that test to fixincludes > because __gnuc_va_list will be found within the comment and satisfy > the "bypass" expression.

[PATCH 1/2] convert the rest of the users of pointer_map to hash_map

2014-08-05 Thread tsaunders
From: Trevor Saunders hi, just what it says on the tin. bootstrapped + regtested on x86_64-unknown-linux-gnu, also bootstrapped on i686-unknown-linux-gnu, ran config-list.mk, ok? gcc/ Trev * hash-map.h (default_hashmap_traits): Adjust overloads of hash function to not conflic

[PATCH 2/2] remove pointer-set.[ch]

2014-08-05 Thread tsaunders
From: Trevor Saunders hi, just what it says on the tin. bootstrapped + regtested on x86_64-unknown-linux-gnu, also bootstrapped on i686-unknown-linux-gnu, ran config-list.mk, ok? gcc/ Trev gcc/ * Makefile.in: Remove references to pointer-set.c and pointer-set.h. * alias.c, c

Re: [PATCH 2/3]Improve induction variable elimination

2014-08-05 Thread Bin.Cheng
On Fri, Jul 25, 2014 at 8:35 PM, Richard Biener wrote: > On Thu, Jul 17, 2014 at 11:08 AM, Bin Cheng wrote: >> Hi, >> As quoted from the function difference_cannot_overflow_p, >> >> /* TODO: deeper inspection may be necessary to prove the equality. */ >> switch (code) >> { >> case PL

Re: Patch for constexpr variable templates

2014-08-05 Thread Braden Obrzut
I can confirm that this is caused by a change to pt.c that happened, I think, the day before my last patch. This can be fixed by first checking that the template is a function template at that line in pt.c. Since variable templates can't be friends, it might also be suitable to skip that enti

Back porting the LTO fix to upstream gcc 4.9 branch

2014-08-05 Thread Hale Wang
Hi, I have submitted the patch to fix the ABI mis-matching error caused by LTO on 18th June 2014. Refer to : https:// gcc.gnu.org/ml/gcc-patches/2014-06/msg01429.html for details. This fix was done for trunk. We need this fix included for gcc 4.9 branch. So could we back porting this fix to ups

RE: Back porting the LTO fix to upstream gcc 4.9 branch

2014-08-05 Thread Hale Wang
Refer to: https://gcc.gnu.org/ml/gcc-patches/2014-06/msg01429.html. Sorry for an extra whitespace. > -Original Message- > From: gcc-patches-ow...@gcc.gnu.org [mailto:gcc-patches- > ow...@gcc.gnu.org] On Behalf Of Hale Wang > Sent: 2014年8月6日 13:50 > To: GCC Patches > Cc: Mike Stump; Richar

Re: [PATCH, ivopt] Try aligned offset when get_address_cost

2014-08-05 Thread Zhenqiang Chen
On 5 August 2014 21:59, Richard Biener wrote: > On Mon, Aug 4, 2014 at 11:09 AM, Zhenqiang Chen > wrote: >> >> >>> -Original Message- >>> From: Bin.Cheng [mailto:amker.ch...@gmail.com] >>> Sent: Monday, August 04, 2014 4:41 PM >>> To: Zhenqiang Chen >>> Cc: gcc-patches List >>> Subject:

Re: [PATCH, libfortran] Backport xmallocarray to 4.8/4.9 (CVE-2014-5044)

2014-08-05 Thread Tobias Burnus
Jakub Jelinek wrote: On Sat, Aug 02, 2014 at 12:09:24AM +0300, Janne Blomqvist wrote: --- libgfortran/runtime/memory.c.jj 2014-06-18 08:50:33.0 +0200 +++ libgfortran/runtime/memory.c2014-08-01 14:41:08.385856116 +0200 @@ -56,7 +56,9 @@ xmallocarray (size_t nmemb, size_t size)

PING – Re: [Patch, Fortran] -fcoarray=lib - support CRITICAL, prepare for locking support

2014-08-05 Thread Tobias Burnus
* PING * – of the patch with the obvious change mentioned by Alessandro (i.e. using "if(is_lock_type)")? Tobias On 1 August 2014 21:57, Alessandro Fanfarillo wrote: Hello, I was implementing lock/unlock on the library side when I found a possible problem in the patch: if (is_lock_type == GFC

<    1   2