Re: RFA: Fix PR rtl-optimization/60651

2014-05-19 Thread Jeff Law
On 04/02/14 11:40, Joern Rennecke wrote: On 2 April 2014 17:34, Joern Rennecke wrote: Hmm, the sanity check in new_seginfo caused a boostrap failure building libjava on x86. There was a block with CODE_LABEL as basic block head, otherwise empty. I've added the testcase - and a bit more detail

Re: Ping2: [PATCH] PR debug/16063. Add DW_AT_type to DW_TAG_enumeration.

2014-05-19 Thread Jason Merrill
On 05/13/2014 03:21 AM, Mark Wielaard wrote: So the debugger doesn't have to guess the properties of the enum's underlying base type, like size, encoding and signedness. Well, the enum already has DW_AT_byte_size. It seems to me that it should also have DW_AT_encoding to provide the other two

Re: [patch ping] libstdc++ testsuite cxxflags

2014-05-19 Thread Sandra Loosemore
On 05/17/2014 04:07 AM, Jonathan Wakely wrote: On 17 May 2014 10:50, Jonathan Wakely wrote: On 17 May 2014 01:16, Sandra Loosemore wrote: It appears that this patch from last fall never got reviewed. https://gcc.gnu.org/ml/gcc-patches/2013-10/msg02340.html Can someone take a look? I'll commi

Re: [GCC RFC]A new and simple pass merging paired load store instructions

2014-05-19 Thread Mike Stump
On May 19, 2014, at 10:30 AM, Jeff Law wrote: >> Yes, I think it's more than upsizing the mode. There is another >> example from one of x86's candidate peephole patch at >> https://gcc.gnu.org/ml/gcc-patches/2014-04/msg00467.html >> >> The patch wants to do below transformation, which I think is

Re: [PATCH] Ensure count_scale is no larger than REG_BR_PROB_BASE

2014-05-19 Thread Dehao Chen
On Mon, May 19, 2014 at 1:40 PM, Jan Hubicka wrote: >> I've updated the patch. Shall I move the check inside cgraph_clone_node? > > Thanks, > I think it is OK as it is. I belive individual users should know what do to > in such cases themselves. > You may want to also check what ipa-cp is doing.

Re: [PATCH] Fix PR middle-end/61141

2014-05-19 Thread John David Anglin
Hi Jeff, On 19-May-14, at 1:51 PM, Jeff Law wrote: On 05/18/14 09:33, John David Anglin wrote: The attached change appears to fix PR middle-end/61141. On PA, we can get deleted insn notes in call sequences. The attached change checks to make sure we have a valid insn before calling reset_i

Re: patch to fix PR60969

2014-05-19 Thread James Greenhalgh
On Fri, May 16, 2014 at 06:49:45PM +0100, Vladimir Makarov wrote: >The following patch fixes > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=60969 > > The patch was bootstrapped and tested on x86/x86-64. > > Committed as rev. 210519 to gcc 4.9 branch and as rev. 210520 to trunk. > > 2014-0

Re: [PATCH, libgfortran] Add overflow check to xmalloc

2014-05-19 Thread Janne Blomqvist
On Thu, May 15, 2014 at 1:00 AM, Janne Blomqvist wrote: > Hi, > > a common malloc() pattern is "malloc(num_foo * sizeof(foo_t)", that > is, create space for an array of type foo_t with num_foo elements. > There is a slight danger here in that the multiplication can overflow > and wrap around, and

[patch] Use Python3 raise syntax in printers

2014-05-19 Thread Jonathan Wakely
This is a partial patch to make the printers work with Python2 and Python3, there are more changes needed but this bit is simple. Tested x86_64-linux, committed to trunk. commit 0f4c27366c14976900d0420c7c4318d6cc1cbf67 Author: Jonathan Wakely Date: Mon May 19 22:18:13 2014 +0100 * python

Re: RFA: PATCH to allow DECL_COMDAT_GROUP to be a DECL

2014-05-19 Thread Jan Hubicka
> I was playing around with this a few months ago but set it aside > because we weren't in stage 1 at the time. The way we currently set > up comdat groups early means that we need to mangle decls early, > significantly negating the earlier work to lazily set > DECL_ASSEMBLER_NAME. This patch imp

Re: [PATCH] Ensure count_scale is no larger than REG_BR_PROB_BASE

2014-05-19 Thread Jan Hubicka
> On Mon, May 19, 2014 at 1:40 PM, Jan Hubicka wrote: > >> I've updated the patch. Shall I move the check inside cgraph_clone_node? > > > > Thanks, > > I think it is OK as it is. I belive individual users should know what do to > > in such cases themselves. > > You may want to also check what ipa-

[C++ Patch] PR 58664

2014-05-19 Thread Paolo Carlini
Hi, first blush, this is just an ICE on invalid for a quite special case. However, comparing the union case to the struct case (on which we don't ICE): struct S { S s[1] = { 0 }; }; xxx.C:3:16: error: could not convert ‘0’ from ‘int’ to ‘S’ S s[1] = { 0 }; shows that in this area there is d

Re: [C++ Patch] PR 58664

2014-05-19 Thread Paolo Carlini
... in fact, I need to be more careful when comparing the types, also because of cv-qualifiers, eg, for: struct S { const S s[1] = { 0 }; }; the trees for S and const S are definitely different. Done in the attached. Thanks, Paolo. /// /cp 2014-05-20 Paolo Carlini

Re: patch to fix PR60969

2014-05-19 Thread H.J. Lu
On Mon, May 19, 2014 at 2:37 PM, James Greenhalgh wrote: > On Fri, May 16, 2014 at 06:49:45PM +0100, Vladimir Makarov wrote: >>The following patch fixes >> >> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=60969 >> >> The patch was bootstrapped and tested on x86/x86-64. >> >> Committed as rev. 2

Re: [PATCH] Fix ARM NAN fraction bits

2014-05-19 Thread Maciej W. Rozycki
Ian, On Sat, 17 May 2014, Richard Biener wrote: > On May 17, 2014 12:22:23 AM CEST, "Maciej W. Rozycki" > wrote: > >On Fri, 16 May 2014, Joseph S. Myers wrote: > > > >> > 2014-05-16 Maciej W. Rozycki > >> > > >> > PR libgcc/60166 > >> > * sysdeps/arm/soft-fp/sfp-machine.h (_FP_NANFRAC_S,

Re: [libstdc++/61227] Support regex like "[\w]"

2014-05-19 Thread Tim Shen
On Mon, May 19, 2014 at 11:28 AM, Paolo Carlini wrote: > I suggest rewording this or avoiding it completely. Sorry, I just can't tolerate my former quick & dirty code. On Mon, May 19, 2014 at 2:49 PM, Jonathan Wakely wrote: > I'm going to check in my factoring patches soon, so there's no need t

[PATCH, sched] Fix sched_insn debug counter

2014-05-19 Thread Maxim Kuvyrkov
Hi, This patch fixes sched_insn debug counter that was broken by modulo/backtracking changes. Tested on arm-linux-gnueabihf and x86_64-linux-gnu, though testsuite does not exercise this execution path. Real testing was done by me debugging an unrelated problem in the scheduler using sched_ins

RE: [PATCH] Fix PR54733 Optimize endian independent load/store

2014-05-19 Thread Thomas Preud'homme
> From: Richard Biener [mailto:richard.guent...@gmail.com] > > Agreed, but I am happy with doing that as a followup. Btw, > a very simple one would be to reject unaligned > SLOW_UNALIGNED_ACCESS (TYPE_MODE (load_type), align). > [of course that may be true on MIPS even for the cases where > a "re

Re: [PATCH] Fix PR54733 Optimize endian independent load/store

2014-05-19 Thread Andrew Pinski
On Fri, May 16, 2014 at 9:58 AM, wrote: > > >> On May 16, 2014, at 4:13 AM, Richard Biener >> wrote: >> >> On Fri, May 16, 2014 at 1:03 PM, Richard Biener >> wrote: >>> On Fri, May 16, 2014 at 12:56 PM, wrote: > On May 16, 2014, at 3:48 AM, Richard Biener > wrote: > >

Re: [C++ Patch] PR 58664

2014-05-19 Thread Jason Merrill
On 05/19/2014 06:43 PM, Paolo Carlini wrote: if (unqualified_id) - error ("field %qD has incomplete type %qT", -unqualified_id, type); + cxx_incomplete_type_error (unqualified_id, type); else error ("name %qT has in

[PATCH, sched]

2014-05-19 Thread Maxim Kuvyrkov
This patch improves debug printouts for scheduling passes. Tested on arm-linux-gnueabihf and x86_64-linux-gnu. OK to apply? Thank you, -- Maxim Kuvyrkov www.linaro.org 0002-Improve-scheduling-debug-output.patch Description: Binary data

[PATCH, ia64] Remove IA64 speculation tweaking flags

2014-05-19 Thread Maxim Kuvyrkov
Hi, This patch removes msched-prefer-non-data-spec-insns and msched-prefer-non-control-spec-insns IA64 options and handling thereof. I have implemented these option during my youthful indiscrimination and, as far as I can tell, no one uses them. Yet, handling of these options complicate logic

Re: Eliminate write-only variables

2014-05-19 Thread Sandra Loosemore
On 05/18/2014 08:45 PM, Sandra Loosemore wrote: On 05/18/2014 02:59 PM, Jan Hubicka wrote: For cases like local-statics-7 your approach can be "saved" by adding simple IPA analysis to look for static vars that are used only by one function and keeping your DSE code active for them, so we can sti

[PATCH, sched] Cleanup and improve multipass_dfa_lookahead_guard

2014-05-19 Thread Maxim Kuvyrkov
Hi, This patch cleans up haifa-sched.c:choose_ready() function while allow more powerful customization by backends at the same time. The primary change is that targetm.sched.first_cycle_multipass_dfa_lookahead_guard hook is converted from returning a boolean OK/Nada value to returning an actio

Re: Eliminate write-only variables

2014-05-19 Thread Jan Hubicka
> On 05/18/2014 08:45 PM, Sandra Loosemore wrote: > >On 05/18/2014 02:59 PM, Jan Hubicka wrote: > >>For cases like local-statics-7 your approach can be "saved" by adding > >>simple IPA analysis > >>to look for static vars that are used only by one function and keeping > >>your DSE code active > >>f

Re: [libstdc++/61227] Support regex like "[\w]"

2014-05-19 Thread Tim Shen
On Mon, May 19, 2014 at 11:49 AM, Jonathan Wakely wrote: > The patch is OK with the ChangeLog tweak and omitting the new file. Booted, tested and committed. Thanks! -- Regards, Tim Shen

Re: [Google/4_8] LIPO COMDAT profile fixups

2014-05-19 Thread Teresa Johnson
Ping. Teresa On Wed, May 14, 2014 at 4:39 PM, Teresa Johnson wrote: > This patch applies profile fixups to COMDATs on the dyn ipa callgraph > at the end of LIPO module grouping (either in the profile gen run or > in gcov-tool). This is to address issues with missing profiles in the > out-of-line

Re: [PATCH, sched]

2014-05-19 Thread Jeff Law
On 05/19/14 21:39, Maxim Kuvyrkov wrote: This patch improves debug printouts for scheduling passes. Tested on arm-linux-gnueabihf and x86_64-linux-gnu. OK to apply? Yes. This is fine. jeff

Re: [PATCH, ia64] Remove IA64 speculation tweaking flags

2014-05-19 Thread Jeff Law
On 05/19/14 22:00, Maxim Kuvyrkov wrote: Hi, This patch removes msched-prefer-non-data-spec-insns and msched-prefer-non-control-spec-insns IA64 options and handling thereof. I have implemented these option during my youthful indiscrimination and, as far as I can tell, no one uses them. Yet, ha

Re: [PATCH, sched] Fix sched_insn debug counter

2014-05-19 Thread Jeff Law
On 05/19/14 18:47, Maxim Kuvyrkov wrote: Hi, This patch fixes sched_insn debug counter that was broken by modulo/backtracking changes. Tested on arm-linux-gnueabihf and x86_64-linux-gnu, though testsuite does not exercise this execution path. Real testing was done by me debugging an unrelated

[PATCH, AArch64] Fix for PR61202

2014-05-19 Thread Carrot Wei
Hi The last operand of instruction sqdmulh can only be low fp registers, so we should use constraint "x". But the intrinsic functions use "w". This patch fixed the constrains in these intrinsics. Passed dejagnu test on aarch64 qemu. OK for trunk, 4.9 and 4.8? thanks Guozhi Wei 2014-05-19 Guoz

Re: [PATCH, AArch64] Fix for PR61202

2014-05-19 Thread James Greenhalgh
On Tue, May 20, 2014 at 07:18:40AM +0100, Carrot Wei wrote: > Hi Hi, > The last operand of instruction sqdmulh can only be low fp registers, > so we should use constraint "x". But the intrinsic functions use "w". > This patch fixed the constrains in these intrinsics. This restriction is only on

Re: [Google/4_8] LIPO COMDAT profile fixups

2014-05-19 Thread Xinliang David Li
Why duplicating the merger functions in dyn-ipa.c? Should those in libgcov-merge.c be reused? The refactoring of gcov_exit_write_gcda should probably be done in a separate patch -- preferably submitted to trunk too. David On Mon, May 19, 2014 at 10:08 PM, Teresa Johnson wrote: > Ping. > Teresa

Re: Ping2: [PATCH] PR debug/16063. Add DW_AT_type to DW_TAG_enumeration.

2014-05-19 Thread Mark Wielaard
On Mon, May 19, 2014 at 04:50:35PM -0400, Jason Merrill wrote: > On 05/13/2014 03:21 AM, Mark Wielaard wrote: > >So the debugger doesn't have to guess the properties of the enum's > >underlying base type, like size, encoding and signedness. > > Well, the enum already has DW_AT_byte_size. It seems

<    1   2