Re: [Patch, Fortran] Fix an issue with CLASS and -fcoarray=lib on the trunk

2014-05-01 Thread Dominique Dhumieres
This causes several failures with -m32 (see http://gcc.gnu.org/ml/gcc-regression/2014-05/msg3.html): FAIL: gfortran.dg/coarray_lib_this_image_1.f90 -O scan-tree-dump-times original "bar \\(real\\(kind=4\\)\\[2\\] \\* restrict x, void \\* restrict caf_token.., integer\\(kind=8\\) caf_offse

Re: [PATCH] Fix PR c++/60463, PR c++/60755 Incorrect discard of const qualifier

2014-05-01 Thread Momchil Velikov
On 14.04.2014 23:53, Momchil Velikov wrote: Ping Hello, During overload resolution of function calls in the body of a lambda it is possible to use an implicit/dummy 'this', which differs in const-ness from the actual 'this' that would be captured, resulting in choosing a non-const member funct

arc: Fix typo, really

2014-05-01 Thread Jan-Benedict Glaw
Hi! There was still an error with parentheses, fixed in r209978 as obvious: 2014-05-01 Jan-Benedict Glaw * config/arc/arc.c (arc_select_cc_mode): Fix typo. Index: config/arc/arc.c === --- config/arc/arc.c(revision 2

arc: Fix warning about redefinition of TARGET_LRA_P

2014-05-01 Thread Jan-Benedict Glaw
Hi! The attached patch (committed as obvious) fixes this warning (see eg. build http://toolchain.lug-owl.de/buildbot/show_build_details.php?id=214621): g++ -c -g -O2 -DIN_GCC -DCROSS_DIRECTORY_STRUCTURE -fno-exceptions -fno-rtti -fasynchronous-unwind-tables -W -Wall -Wno-narrowing -Wwrite-st

Re: [PATCH ARM]Handle REG addressing mode in output_move_neon explicitly

2014-05-01 Thread Richard Earnshaw
On 29/04/14 04:02, bin.cheng wrote: > Hi, > Function output_move_neon now generates vld1.64 for memory ref like "dx <- > [r1:SI]", this is bogus because it requires at least 64-bit alignment for > 32-bit aligned memory ref. It works now because GCC doesn't generate such > insns in the first place,

RFA: Fix possible typo in lto-cgraph.c

2014-05-01 Thread Richard Sandiford
bootstrap-asan failed on wide-int from what looks like a typo in compute_ltrans_boundary. The first loop uses the function-wide "node" variable while the second loop uses a local "vnode" variable. The problem was that the second loop also had a reference to "node". The patch below gets me past t

Re: [PATCH][RFC] Always require a 64bit HWI

2014-05-01 Thread Pedro Alves
On 04/30/2014 05:00 PM, Jeff Law wrote: > On 04/30/14 02:16, Richard Biener wrote: >> >> Testing coverage for non-64bit hwi configs is really low these >> days (I know of only 32bit hppa-*-* that is still built and >> tested semi-regularly - Dave, I suppose the host compiler >> has a 64bit long lon

Re: Fwd: [PATCH, ARM] Improve 64 bit division performance

2014-05-01 Thread Richard Earnshaw
On 27/02/14 16:38, Charles Baylis wrote: > [resending as text/plain] > > Hi > > These patches optimise 64 bit division by removing the use of the > __gnu_[u]ldivmod_helper functions and hence avoiding the redundant > calculation of the remainder in those functions. > > Bootstrapped, tested and c

Re: [PING] Re: Add const char* constructors for exception classes in

2014-05-01 Thread Oleg Endo
Jonathan, now that we're in stage 1 again, I'd like to revive the issue below. Do you have any particular plans? How should we proceed? Cheers, Oleg On Wed, 2014-01-29 at 23:45 +0100, Oleg Endo wrote: > On Wed, 2014-01-29 at 21:38 +, Jonathan Wakely wrote: > > On 29 January 2014 21:17, Ole

Re: [PATCH] Fix GDB PR15559 (inferior calls using "thiscall" calling convention)

2014-05-01 Thread Julian Brown
On Thu, 27 Mar 2014 12:47:23 + Julian Brown wrote: > On Wed, 26 Mar 2014 10:25:19 -0600 > Tom Tromey wrote: > > > > "Julian" == Julian Brown writes: > > > > Julian> include/ > > Julian> * dwarf2.h (enum dwarf_calling_convention): Add > > Julian> DW_CC_GNU_thiscall_i386. >

Re: [Patch] Fix crtstuff.c compilation with mingw build.

2014-05-01 Thread Steve Ellcey
On Thu, 2014-04-24 at 19:27 +0200, Rainer Orth wrote: > "Steve Ellcey " writes: > > > diff --git a/libgcc/crtstuff.c b/libgcc/crtstuff.c > > index 12bed4b..d09455f 100644 > > --- a/libgcc/crtstuff.c > > +++ b/libgcc/crtstuff.c > > @@ -54,6 +54,7 @@ see the files COPYING3 and COPYING.RUNTIME respe

[PATCH, wwwdocs, AArch64] Document issues with singleton vector types

2014-05-01 Thread Yufeng Zhang
Hi, This patch documents issues with singleton vector types in the 4.9 AArch64 backend. "On AArch64, the singleton vector types int64x1_t, uint64x1_t and float64x1_t exported by arm_neon.h are defined to be the same as their base types. This results in incorrect application of parameter passi

Re: [DOC PATCH] Clarify docs about stmt exprs (PR c/51088)

2014-05-01 Thread Joseph S. Myers
On Tue, 8 Apr 2014, Marek Polacek wrote: > This patch doesn't catch cases like ({ A:0; }); &&A;, in that case the > behavior is just undefined. Those cases can produce link failures just like the cases where the address is taken before the statement expression, so I think they need errors as we

Re: [PATCH, PR58066] preferred_stack_boundary update for tls expanded call

2014-05-01 Thread Wei Mi
On Wed, Apr 30, 2014 at 11:44 PM, Uros Bizjak wrote: > On Thu, May 1, 2014 at 6:42 AM, Wei Mi wrote: >> Ping. Is pr58066-3.patch or pr58066-4.patch ok for trunk? > > None of these patches have correct ChangeLog entries. Please follow > the rules, outlined in http://gcc.gnu.org/contribute.html (Su

Go patch committed: Use backend interface for heap expressions

2014-05-01 Thread Ian Lance Taylor
This patch from Chris Manghane changes the Go frontend to use the backend interface for heap expressions. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian diff -r 93286dc73be0 go/expressions.cc --- a/go/expressions.cc Wed Apr 30 21:18:08 2014 -0400 +++ b

[committed] Update config.guess and config.sub

2014-05-01 Thread Richard Sandiford
I pulled in the latest upstream config.guess and config.sub for MIPS{32,64}r6 support. Thanks, Richard * config.sub, config.guess: Import from upstream. Index: config.guess === --- config.guess2014-05-01 21:48:34.84

Re: [C PATCH] Quash spurious warnings (PR c/60784)

2014-05-01 Thread Joseph S. Myers
On Sun, 13 Apr 2014, Marek Polacek wrote: > This PR is about spurious warnings with -Wmissing-field-initializers > that can be seen when using multi-level designated initializers. > The warning should not be output for designated initializers [*], > pop_init_level checks for constructor_designated

Re: Optimize n?rotate(x,n):x

2014-05-01 Thread Marc Glisse
Hello, here is the latest version. Reviewers seemed happy with different versions, so I went for the simplest one. We only give up on the transformation if we are optimizing for speed, the short-cut has probability >50% and the operation the branch is avoiding is expensive (i.e. only division

Re: [patch] change specific int128 -> generic intN

2014-05-01 Thread Joseph S. Myers
On Mon, 14 Apr 2014, DJ Delorie wrote: > The only non-automatic part of this is the table of pre-computed > constants in builtin_define_type_minmax() (c-family/c-cppbuiltin.c). I'm not aware of any reason those macros need to have decimal values. I'd suggest removing the precomputed table and p

[wwwdocs] Fix svn.html

2014-05-01 Thread Gerald Pfeifer
This fixes a markup issue by adding a closing and reformats lines to be shorter. Applied. Gerald Index: svn.html === RCS file: /cvs/gcc/wwwdocs/htdocs/svn.html,v retrieving revision 1.193 diff -u -r1.193 svn.html --- svn.html1

Re: GCC's -fsplit-stack disturbing Mach's vm_allocate

2014-05-01 Thread Samuel Thibault
Hello, Svante Signell, le Thu 24 Apr 2014 10:39:10 +0200, a écrit : > - Without split stack enabled around 70 libgo tests pass and 50 fails, > most of them with a segfault. > - Enabling split stack and using the libc Samuel built all 122 libgo > tests fail with a segfault. Please provide segfault

Re: [C PATCH] Fix up diagnostics (PR c/25801)

2014-05-01 Thread Joseph S. Myers
On Fri, 18 Apr 2014, Marek Polacek wrote: > @@ -1760,15 +1760,10 @@ c_size_in_bytes (const_tree type) I think the comment on this function should be updated to explain the interface contract when an incomplete (or function) type is passed (i.e. return size_one_node, caller is responsible for an

Re: Contributing new gcc targets: i386-*-dragonfly and x86-64-*-dragonfly

2014-05-01 Thread Joseph S. Myers
The include of from seems risky, given that that's a POSIX header that typically defines various types ISO C does not permit to be defined in (ISO C does not have any general *_t namespace reservation, unlike POSIX). Have you verified that if you include with -std=c90 / -std=c99 / -std=c11

Re: [C PATCH] Make attributes accept enum values (PR c/50459)

2014-05-01 Thread Joseph S. Myers
On Wed, 23 Apr 2014, Marek Polacek wrote: > diff --git gcc/testsuite/c-c++-common/attributes-1.c > gcc/testsuite/c-c++-common/attributes-1.c > index af4dd12..8458e47 100644 > --- gcc/testsuite/c-c++-common/attributes-1.c > +++ gcc/testsuite/c-c++-common/attributes-1.c > @@ -9,7 +9,7 @@ typedef ch

Re: [patch] change specific int128 -> generic intN

2014-05-01 Thread DJ Delorie
Do we have a routine to do that already?

Re: [C PATCH] Warn about variadic main (PR c/60156)

2014-05-01 Thread Joseph S. Myers
On Fri, 25 Apr 2014, Marek Polacek wrote: > On Thu, Apr 24, 2014 at 03:11:15PM -0600, Jeff Law wrote: > > OK. Though in practice I doubt this is going to catch many real > > bugs. Are people still giving main a stdargs style signature? > > I doubt too, it's more a matter of QOI. I've actually n

Re: Contributing new gcc targets: i386-*-dragonfly and x86-64-*-dragonfly

2014-05-01 Thread John Marino
On 5/2/2014 01:03, Joseph S. Myers wrote: > The include of from seems risky, given that > that's a POSIX header that typically defines various types ISO C does not > permit to be defined in (ISO C does not have any general *_t > namespace reservation, unlike POSIX). > > Have you verified tha

Re: [C PATCH] Better column info for initializers (PR c/60139)

2014-05-01 Thread Joseph S. Myers
On Fri, 25 Apr 2014, Marek Polacek wrote: > Another minor fix: use loc instead of input_location. Also add > missing OPT_Wpedantic. Why do you say it's missing? A default pedwarn generally means "this is dubious code, not allowed by ISO C, but we don't want to make it a hard error" (and the

Re: [C PATCH] remove goto in c_parser_sizeof_expression

2014-05-01 Thread Joseph S. Myers
On Fri, 25 Apr 2014, Marek Polacek wrote: > On Thu, Apr 24, 2014 at 03:27:42PM -0600, Jeff Law wrote: > > On 02/24/14 12:28, Marek Polacek wrote: > > >On Tue, Feb 25, 2014 at 12:01:25AM +0530, Prathamesh Kulkarni wrote: > > >>Replaced tab by 4 spaces before error_at. > > >>* c-parser.c (c_parser_s

Re: [Patch] Fix a typo in Chinese msg

2014-05-01 Thread Joseph S. Myers
On Thu, 24 Apr 2014, Tobias Burnus wrote: > Jeff, are you sure that this will not be overridden? I think the translations > are always synced from http://translationproject.org/team/zh_CN.html ? Yes. This should be reverted; we shouldn't make any local changes to these files. When there's a ne

Re: [C PATCH] Some c-typeck.c TLC

2014-05-01 Thread Joseph S. Myers
On Fri, 25 Apr 2014, Marek Polacek wrote: > error_init and pedwarn_init aren't used outside of c-typeck.c, thus > can be made static. (maybe_warn_string_init is used in the parser.) > As they're small, I suspect they will be inlined now. > I had to move the functions a little bit above so we don'

Re: [C PATCH] Another locus improvements (PR c/60257)

2014-05-01 Thread Joseph S. Myers
On Sat, 26 Apr 2014, Marek Polacek wrote: > What is worth mentioning is that the "(near initialization for X)" > message seems next to useless to me now with caret diagnostics (?). The caret diagnostics point to the initializer. "near initialization" says (or should say) what field GCC thinks i

Re: [RFC][ARM] TARGET_ATOMIC_ASSIGN_EXPAND_FENV hook

2014-05-01 Thread Joseph S. Myers
It doesn't seem a good idea to me for a host-side GCC file to use the FE_* names for the target's FE_* values; you'd run into problems if that file ever ends up including the host's , directly or indirectly, on any host. The same comment applies to the AArch64 patch as well. Instead I suggest

Re: [C PATCH] proposal to add new warning -Wsizeof-array-argument

2014-05-01 Thread Joseph S. Myers
The following apply to all versions of this patch: * New options need documenting in invoke.texi. * New options need nonempty help text in c.opt. (It's unfortunate that the -Wsizeof-pointer-memaccess option immediately above got added without such help text.) * Don't use %s with IDENTIFIER_PO

Re: [Patch] Fix a typo in Chinese msg

2014-05-01 Thread Jeff Law
On 05/01/14 17:59, Joseph S. Myers wrote: On Thu, 24 Apr 2014, Tobias Burnus wrote: Jeff, are you sure that this will not be overridden? I think the translations are always synced from http://translationproject.org/team/zh_CN.html ? Yes. This should be reverted; we shouldn't make any local c

Re: [C PATCH] Warn if switch has boolean value (PR c/60439)

2014-05-01 Thread Jeff Law
On 04/18/14 05:50, Marek Polacek wrote: On Fri, Apr 18, 2014 at 01:20:59PM +0200, Steven Bosscher wrote: On Fri, Apr 18, 2014 at 7:30 AM, Marek Polacek wrote: + if (TREE_CODE (type) == BOOLEAN_TYPE + || exp_code == TRUTH_ANDIF_EXPR + || exp_code == TRUTH_AND_EXPR

Re: [C PATCH] remove goto in c_parser_sizeof_expression

2014-05-01 Thread Jeff Law
On 04/25/14 01:18, Marek Polacek wrote: On Thu, Apr 24, 2014 at 03:27:42PM -0600, Jeff Law wrote: On 02/24/14 12:28, Marek Polacek wrote: On Tue, Feb 25, 2014 at 12:01:25AM +0530, Prathamesh Kulkarni wrote: Replaced tab by 4 spaces before error_at. * c-parser.c (c_parser_sizeof_expression): Re

Broken link

2014-05-01 Thread William Leighton Dawson
In this message: http://gcc.gnu.org/ml/gcc-patches/2008-10/msg01096.html Gerald indicated a stale link for 'Guide for the use of the Ada programming language in high integrity systems'. The document is, in fact, not removed, just moved. It's new location is: http://www.dit.upm.es/~str/ork/docume

Re: [PATCH] Try to coalesce for unary and binary ops

2014-05-01 Thread Jeff Law
On 04/17/14 05:38, Richard Biener wrote: The patch below increases the number of coalescs we attempt to also cover unary and binary operations. This improves initial code generation for code like [ ... ] Expansion has special code to improve coalescing of op1 with target thus this is what w

Re: [PATCH] Change HONOR_REG_ALLOC_ORDER to a marco for C expression

2014-05-01 Thread Jeff Law
On 04/16/14 06:14, Kito Cheng wrote: Hi Vladimir: thanks your replay and approve, however I don't have commit right yet, can you help to commit it? thanks! I fixed up some minor whitespace issues and committed your patch. Jeff

Re: [PATCH] Remove "keep_aligning" from get_inner_reference

2014-05-01 Thread Jeff Law
On 04/22/14 03:25, Eric Botcazou wrote: Sure, and thanks again for your help. Thanks! I was not able to find any difference on the generated code with or without that patch. Yes, my gut feeling is that TYPE_ALIGN_OK is really obsolete now. It is set in a single place in the compiler (gcc-i

Re: [PATCH] Change HONOR_REG_ALLOC_ORDER to a marco for C expression

2014-05-01 Thread Kito Cheng
Hi Jeff: > I fixed up some minor whitespace issues and committed your patch. Thanks for your help :)