Re: [C PATCH] Warn about variadic main (PR c/60156)

2014-04-25 Thread Marek Polacek
On Thu, Apr 24, 2014 at 03:11:15PM -0600, Jeff Law wrote: > OK. Though in practice I doubt this is going to catch many real > bugs. Are people still giving main a stdargs style signature? I doubt too, it's more a matter of QOI. I've actually never seen main (int, ...). But it seemed wrong to no

Re: [VRP][PATCH] Improve value range for loop index

2014-04-25 Thread Kugan
On 24/04/14 23:05, Richard Biener wrote: > On Wed, Apr 9, 2014 at 10:07 PM, Kugan > wrote: >> Value range propagation simplifies convergence in vrp_visit_phi_node by >> setting minimum to TYPE_MIN when the computed minimum is smaller than >> the previous minimum. This can however result in pessi

Re: [C PATCH] remove goto in c_parser_sizeof_expression

2014-04-25 Thread Marek Polacek
On Thu, Apr 24, 2014 at 03:27:42PM -0600, Jeff Law wrote: > On 02/24/14 12:28, Marek Polacek wrote: > >On Tue, Feb 25, 2014 at 12:01:25AM +0530, Prathamesh Kulkarni wrote: > >>Replaced tab by 4 spaces before error_at. > >>* c-parser.c (c_parser_sizeof_expression): Remove goto sizeof_expr. > > > >Lo

Re: [PATCH] Fix PR60911

2014-04-25 Thread Richard Biener
On Thu, 24 Apr 2014, Jan Hubicka wrote: > > > > Simple IPA passes are supposed to see function bodies with IPA transforms > > applied - this is what the code in execute_one_pass tries to ensure. > > But that doesn't work anymore with on-demand function-body loading. > > The following addresses t

Re: [VRP][PATCH] Improve value range for loop index

2014-04-25 Thread Richard Biener
On Fri, Apr 25, 2014 at 9:13 AM, Kugan wrote: > > > On 24/04/14 23:05, Richard Biener wrote: >> On Wed, Apr 9, 2014 at 10:07 PM, Kugan >> wrote: >>> Value range propagation simplifies convergence in vrp_visit_phi_node by >>> setting minimum to TYPE_MIN when the computed minimum is smaller than >>

Re: Remove obsolete Solaris 9 support

2014-04-25 Thread Rainer Orth
Rainer Orth writes: > Uros Bizjak writes: > >> It looks to me that one part was left in libgcc/config/i386/crtfastmath.c: >> >> #if !defined __x86_64__ && defined __sun__ && defined __svr4__ >> #include >> #include >> ... >> #endif > > Right, missed it because it carried no Solaris 9 comment.

[build] Remove LIB_TLS_SPEC on Solaris

2014-04-25 Thread Rainer Orth
When looking at badly formatted output from gcc/configure, I noticed that all of LIB_TLS_SPEC on Solaris can go: since Solaris 10, __tls_get_addr/___tls_get_addr live in libc, no need for a separate support library. Bootstrapped without regressions on i386-pc-solaris2.1[01] and sparc-sun-solaris2.

Re: [PATCH 00/89] Compile-time gimple-checking

2014-04-25 Thread Richard Biener
On Thu, Apr 24, 2014 at 4:49 PM, Michael Matz wrote: > Hi, > > On Thu, 24 Apr 2014, Andrew MacLeod wrote: > >> Well, we ought to settle on one... either use the is_a, as_a, and >> dyn_cast paradigm as they exist today, or we use the cast_as_method >> approach everywhere. I'm not fond of each pote

Re: version typeinfo for 128bit types

2014-04-25 Thread Marc Glisse
On Fri, 25 Apr 2014, Jonathan Wakely wrote: On 24/04/14 20:03 +0200, Marc Glisse wrote: Grep seems to indicate that the manual is the only other place that needs updating, but that can wait. Is this patch ok, assuming the tests pass? OK, and sorry for forgetting about that file in the tests

Re: [4.9.1 RFA] [tree-optimization/60902] Invalidate outputs of GIMPLE_ASMs when threading around loops

2014-04-25 Thread Richard Biener
On Thu, Apr 24, 2014 at 5:34 PM, Jeff Law wrote: > On 04/24/14 02:22, Richard Biener wrote: >>> >>> + >>> + if (backedge_seen) >>> + FOR_EACH_SSA_TREE_OPERAND (op, stmt, iter, SSA_OP_ALL_DEFS) >> >> >> You only need SSA_OP_DEF here, no need to process virtual >> operands. > > I w

Re: Examples of gimple statement API (was Re: [PATCH 03/89] Introduce gimple_bind and use it for accessors.)

2014-04-25 Thread Richard Biener
On Thu, Apr 24, 2014 at 4:59 PM, David Malcolm wrote: > On Thu, 2014-04-24 at 09:09 -0400, Andrew MacLeod wrote: >> On 04/24/2014 04:33 AM, Richard Biener wrote: >> > On Wed, Apr 23, 2014 at 11:23 PM, Jeff Law wrote: >> >> On 04/23/14 15:13, David Malcolm wrote: >> >>> On Wed, 2014-04-23 at 15:04

Re: wide-int, cfg

2014-04-25 Thread Richard Biener
On Thu, Apr 24, 2014 at 9:02 PM, Mike Stump wrote: > On Nov 25, 2013, at 2:57 AM, Richard Biener > wrote: >> On Sat, Nov 23, 2013 at 8:21 PM, Mike Stump wrote: >>> Richi has asked the we break the wide-int patch so that the individual port >>> and front end maintainers can review their parts w

Re: wide-int, ada

2014-04-25 Thread Eric Botcazou
> So, given the last change, the remaining bit is: > > Index: gcc/ada/gcc-interface/cuintp.c > === > --- gcc/ada/gcc-interface/cuintp.c(revision 209754) > +++ gcc/ada/gcc-interface/cuintp.c(working copy) > @@ -160,7 +160,11 @@

*ping*: [patch, fortran] Fix PR 59604

2014-04-25 Thread Thomas Koenig
OK for trunk? Full patch at http://gcc.gnu.org/ml/gcc-patches/2014-04/msg00616.html > Hello world, > > please find attached a patch for PR 59604. > > The patch makes sure that, if -fno-range-check is specified, > using int on an overflowing boz constant yields the same > result for compile-tim

Re: [wide-int] tree-ssa-ccp fix

2014-04-25 Thread Richard Biener
On Thu, Apr 24, 2014 at 11:54 PM, Richard Sandiford wrote: > The asm comparison showed a problem with my r204593 change, which dropped > a "val.mask &" in the second hunk below. > > Seeing that the problem was in ccp made me look at the whole file again. > I noticed that we'd changed the VARYING m

Re: [PATCH] Fix PR60930

2014-04-25 Thread Richard Biener
On Fri, 25 Apr 2014, Jakub Jelinek wrote: > On Thu, Apr 24, 2014 at 09:20:50PM -0600, Jeff Law wrote: > > > PR tree-optimization/60930 > > > * gcc.dg/torture/pr60930.c: New test. > > Doesn't the test depend on long long being at least 64 bits? > > But that is guaranteed by C99, isn't it? Bu

emit __float128 typeinfo

2014-04-25 Thread Marc Glisse
Hello, the previous patch had to be reverted as it broke the strange handling of vectors in the ARM target. This new patch should be much more conservative I hope. Instead of adding this typeinfo to libsupc++, I am letting the FE know that it isn't available in libsupc++. There are 2 versions,

Re: [PATCH] Fix web/60933

2014-04-25 Thread Eric Botcazou
> Ah, I didn't see that. So the issue here is that the host compiler > miscompiles the in-tree copy? Maybe we should compile host libraries with > -O0 during stage1 (and require recent host GCC for compiling > cross compilers - which we probably do anyway). In-tree is a red herring, very few peo

Re: [PATCH] Fix PR60930

2014-04-25 Thread Jakub Jelinek
On Fri, Apr 25, 2014 at 10:59:19AM +0200, Richard Biener wrote: > On Fri, 25 Apr 2014, Jakub Jelinek wrote: > > > On Thu, Apr 24, 2014 at 09:20:50PM -0600, Jeff Law wrote: > > > > PR tree-optimization/60930 > > > > * gcc.dg/torture/pr60930.c: New test. > > > Doesn't the test depend on long long b

RE: [Testsuite] getpid in gcc.c-torture/execute/pr58419.c

2014-04-25 Thread Dhakshinamoorthy, Soundararajan
Hi, I have attached a patch based on the recommendation. Can you please review and apply, if it looks ok ?. I don't have commit access. gcc/testsuite/ChangeLog 2014-04-25 Soundararajan Dhakshinamoorthy * gcc.c-torture/execute/pr58419.c: Adjust the test to work with bare metal tar

Re: [Committed][ARM][AArch64] Patches previously ok'd for stage1

2014-04-25 Thread Ramana Radhakrishnan
On Thu, Apr 24, 2014 at 5:50 PM, Kyrill Tkachov wrote: > On 24/04/14 17:46, Ryan Mansfield wrote: >> >> On 14-04-24 12:12 PM, Kyrill Tkachov wrote: >>> >>> On 24/04/14 14:44, Ryan Mansfield wrote: On 14-04-23 11:38 AM, Kyrill Tkachov wrote: > > http://gcc.gnu.org/ml/gcc-patches/2

Re: [PATCH] Fix web/60933

2014-04-25 Thread Richard Biener
On Fri, 25 Apr 2014, Eric Botcazou wrote: > > Ah, I didn't see that. So the issue here is that the host compiler > > miscompiles the in-tree copy? Maybe we should compile host libraries with > > -O0 during stage1 (and require recent host GCC for compiling > > cross compilers - which we probably

[PATCH, testsuite]: Require vect_simd_clones effective target for c-c++-common/gomp/pr60823-2.c

2014-04-25 Thread Uros Bizjak
Hello! This is a runtime test, so check if we are able to at least compile the source. 2014-04-25 Uros Bizjak * c-c++-common/gomp/pr60823-2.c: Require effective target vect_simd_clones. Tested on x86_64 CentOS 5.10. OK for mainline? Uros. Index: c-c++-common/gomp/pr60823-2.c =

Re: [PATCH] Fix web/60933

2014-04-25 Thread Eric Botcazou
> I'm not sure about that. In fact I'm always suggesting the in-tree > variant to people (because then they don't need to fiddle with > LD_LIBRARY_PATH). After suggesting to simply install the requirements > from vendor provided packages, of course. The proper fix to the LD_LIBRARY_PATH issue is

RE: [patch] Shorten Windows path

2014-04-25 Thread Joey Ye
Ping > -Original Message- > From: Joey Ye [mailto:joey...@arm.com] > Sent: Tuesday, April 01, 2014 6:18 PM > To: 'Ian Lance Taylor' > Cc: gcc-patches > Subject: RE: [patch] Shorten Windows path > > Ian, thanks for your comments. Please find answers and new version below: > > > -Origi

Re: [PATCH, testsuite]: Require vect_simd_clones effective target for c-c++-common/gomp/pr60823-2.c

2014-04-25 Thread Jakub Jelinek
On Fri, Apr 25, 2014 at 11:51:06AM +0200, Uros Bizjak wrote: > Hello! > > This is a runtime test, so check if we are able to at least compile the > source. > > 2014-04-25 Uros Bizjak > > * c-c++-common/gomp/pr60823-2.c: Require effective target > vect_simd_clones. > > Tested on x86_

[SPARC] Fix PR target/60941

2014-04-25 Thread Eric Botcazou
2014-04-25 Eric Botcazou PR target/60941 * config/sparc/sparc.md (ashlsi3_extend): Delete. 2014-04-25 Eric Botcazou * gcc.c-torture/execute/20140425-1.c: New test. -- Eric BotcazouIndex: config/spar

Re: [C PATCH] Improve column info of initializers (PR c/60114)

2014-04-25 Thread Marek Polacek
On Tue, Feb 11, 2014 at 12:09:39AM +, Joseph S. Myers wrote: > On Mon, 10 Feb 2014, Marek Polacek wrote: > > > This patch improves location information in a bunch of various > > initializers; see the testcase. Main issue was that digest_init > > was getting only input_location. > > > > Regte

Re: [SPARC] Fix PR target/60941

2014-04-25 Thread Jakub Jelinek
On Fri, Apr 25, 2014 at 12:47:32PM +0200, Eric Botcazou wrote: > /* PR target/60941 */ > /* Reported by Martin Husemann */ > > extern void abort (void); > > static void __attribute__((noinline)) > set (unsigned long *l) > { > *l = 31; > } > > int main (void) > { > unsigned long l; > int i

Re: emit __float128 typeinfo

2014-04-25 Thread Marc Glisse
On Fri, 25 Apr 2014, Marc Glisse wrote: the previous patch had to be reverted as it broke the strange handling of vectors in the ARM target. This new patch should be much more conservative I hope. Instead of adding this typeinfo to libsupc++, I am letting the FE know that it isn't available in

Re: [SPARC] Fix PR target/60941

2014-04-25 Thread Eric Botcazou
> I'm afraid the testcase will fail on int16 targets, so perhaps > you should guard the body of main other than return 0; with > #if __INT_MAX__ >= 2147483647ULL > or > #if __SIZEOF_INT__ >= 4 > or similar (or require int32plus target, but gcc.c-torture/execute/ > is not a good place for that and *

Re: [SPARC] Fix PR target/60941

2014-04-25 Thread Jakub Jelinek
On Fri, Apr 25, 2014 at 01:24:13PM +0200, Eric Botcazou wrote: > > I'm afraid the testcase will fail on int16 targets, so perhaps > > you should guard the body of main other than return 0; with > > #if __INT_MAX__ >= 2147483647ULL > > or > > #if __SIZEOF_INT__ >= 4 > > or similar (or require int32p

Re: [PING^8][PATCH] Add a couple of dialect and warning options regarding Objective-C instance variable scope

2014-04-25 Thread Dimitris Papavasiliou
On 04/25/2014 03:54 AM, Mike Stump wrote: On Apr 24, 2014, at 4:16 PM, Dimitris Papavasiliou wrote: On 04/24/2014 11:17 PM, Jakub Jelinek wrote: How has this been tested? I'm seeing: +FAIL: obj-c++.dg/local-decl-1.mm -fgnu-runtime (test for warnings, line 39) +FAIL: obj-c++.dg/local-decl-1.

Re: [GSoC] use obstack in parse_c_expr

2014-04-25 Thread Prathamesh Kulkarni
On Thu, Apr 24, 2014 at 9:18 PM, Diego Novillo wrote: > Please remember to send patches to gcc-patches. > > I'm wondering if you couldn't just use std::string here. No need to change > one complicated allocation scheme with another. Since we were using c-styled strings throughout genmatch, I thou

[PATCH] Add support for GNU/Hurd in gnat-4.9

2014-04-25 Thread Svante Signell
Hello, Attached is a patch for support of GNU/Hurd in gnat-4.9. This patch has been used and updated in Debian since gnat-4.6, and is currently used to build gnat-4.9. Now when the body file s-osinte-posix.adb in gcc-4.9 defines tv_nsec in timespec POSIX-correctly as long again, we think it is tim

Re: [gomp4] Add tables generation

2014-04-25 Thread Ilya Verbin
On 17 Apr 22:33, Ilya Verbin wrote: > Hi Jakub, > > Could you please take a look at this patch? It fixes the ordering issue in > the > tables stated above, and passes all the tests that I have. But I'm not sure > about its correctness from the architectural point of view. > > Thanks, > -- Il

Re: [GSoC] use obstack in parse_c_expr

2014-04-25 Thread Trevor Saunders
On Fri, Apr 25, 2014 at 05:09:57PM +0530, Prathamesh Kulkarni wrote: > On Thu, Apr 24, 2014 at 9:18 PM, Diego Novillo wrote: > > Please remember to send patches to gcc-patches. > > > > I'm wondering if you couldn't just use std::string here. No need to change > > one complicated allocation scheme

Re: [GSoC] use obstack in parse_c_expr

2014-04-25 Thread Richard Biener
On Fri, Apr 25, 2014 at 2:01 PM, Trevor Saunders On Fri, Apr 25, 2014 at 05:09:57PM +0530, Prathamesh Kulkarni wrote: >> On Thu, Apr 24, 2014 at 9:18 PM, Diego Novillo wrote: >> > Please remember to send patches to gcc-patches. >> > >> > I'm wondering if you couldn't just use std::string here. N

[C PATCH] Better column info for shift warnings (PR c/60351)

2014-04-25 Thread Marek Polacek
A trivial patch to improve column info of warnings about shift count. Tested x86_64-linux, ok for trunk? 2014-04-25 Marek Polacek PR c/60351 * c-typeck.c (build_binary_op): Use location when warning about shift count. * gcc.dg/pr60351.c: New test. diff --git

-fuse-caller-save - Enable for MIPS

2014-04-25 Thread Tom de Vries
On 22-04-14 17:05, Tom de Vries wrote: I've updated the fuse-caller-save patch series to model non-callee call clobbers in CALL_INSN_FUNCTION_USAGE. Richard, this patch enables the fuse-caller-save optimization for MIPS. It adds the $6 clobber in CALL_INSN_FUNCTION_USAGE when required, and s

[PATCH] Fix test for PR18079

2014-04-25 Thread Marek Polacek
A while ago I committed a fix for PR18079, but only later on discovered that the test fails because of wrong quoting in dg-warning. Sorry. Committed. 2014-04-25 Marek Polacek * gcc.dg/pr18079-2.c: Fix quoting in dg-warning. diff --git gcc/testsuite/gcc.dg/pr18079-2.c gcc/testsuite/g

Re: -fuse-caller-save - Enable for MIPS

2014-04-25 Thread Richard Sandiford
Tom de Vries writes: > diff --git a/gcc/config/mips/mips.c b/gcc/config/mips/mips.c > index 45256e9..b61cd44 100644 > --- a/gcc/config/mips/mips.c > +++ b/gcc/config/mips/mips.c > @@ -7027,11 +7027,17 @@ mips_expand_call (enum mips_call_type type, rtx > result, rtx addr, > { >rtx orig_addr,

[PATCH] Make SRA create statements with the correct alias type

2014-04-25 Thread Martin Jambor
Hi, the patch below is inspired by PR 57297 (the most relevant comments are #4 and #5). The problem is that currently SRA creates memory loads and stores with alias type of whatever happens to be in access->base. However, at least when using placement or some nasty type-casting, it is possible t

[PATCH] Fix vector division lowering (PR tree-optimization/60960)

2014-04-25 Thread Jakub Jelinek
Hi! If a vector type has scalar mode, such as 4xchar vector in the testcase SImode, then unfortunately various optabs checks in expand_vector_divmod and functions it calls can succeed, but the operation is actually not a vector operation (e.g. a SImode shift is very different from V4QImode shift w

[wide-int 2/5] Fix large widths in shifted_mask

2014-04-25 Thread Richard Sandiford
shifted_mask would mishandle cases where the start bit is in the middle of a HWI and the end bit is in a different HWI. The "000111000" case needs to check that the start and end are in the same block. In the changed lines, "shift" is the position of the lowest mask bit in its containing HWI. Th

[wide-int 3/5] Fix large widths in shifted_mask

2014-04-25 Thread Richard Sandiford
Very minor, but since shifted_mask copes with out-of-range widths, I think mask should too. Tested on x86_64-linux-gnu. OK to install? Thanks, Richard Index: gcc/wide-int.cc === --- gcc/wide-int.cc 2014-04-25 09:26:57.02594446

[wide-int 1/5] Cosmetic fixes to wide-int.{cc,h}

2014-04-25 Thread Richard Sandiford
This series of patches is from a read-through of wide-int.h and wide-int.cc. (The series from earlier in the week was from a diff of preexisting files.) This first patch fixes some comments, typos and formatting. It also removes some dead code. I'll follow up with a gdb-friendly replacement for

[ada, build] Ignore cp -p failures during Ada make install

2014-04-25 Thread Rainer Orth
When trying to install a freshly built gcc 4.9.0 on Solaris 9 and 10, I ran into make install failures when using INSTALL_DATA_DATE: cp: preserving permissions for '/vol/gcc-4.9/lib/gcc/i386-pc-solaris2.10/4.9.0/adalib/a-assert.ali': Operation not supported on transport endpoint The problem is

[wide-int 4/5] Fix canonize handling of "small_prec" case

2014-04-25 Thread Richard Sandiford
We should write back the sign-extended value. Tested on x86_64-linux-gnu. OK to install? Thanks, Richard Index: gcc/wide-int.cc === --- gcc/wide-int.cc 2014-04-25 09:15:14.297359380 +0100 +++ gcc/wide-int.cc 2014-04-25 09:

Re: [PATCH] Fix vector division lowering (PR tree-optimization/60960)

2014-04-25 Thread Richard Biener
On April 25, 2014 3:39:29 PM CEST, Jakub Jelinek wrote: >Hi! > >If a vector type has scalar mode, such as 4xchar vector in the testcase >SImode, then unfortunately various optabs checks in >expand_vector_divmod >and functions it calls can succeed, but the operation is actually not >a vector operat

Re: [patch] Shorten Windows path

2014-04-25 Thread Ian Lance Taylor
On Fri, Apr 25, 2014 at 3:16 AM, Joey Ye wrote: > Ping To be clear, I am not a libcpp maintainer and I don't plan to approve this patch. This should be reviewed by a libcpp maintainer or a C or C++ frontend maintainer. Ian >> -Original Message- >> From: Joey Ye [mailto:joey...@arm.com

[wide-int 5/5] Add dump () method for gdb debugging

2014-04-25 Thread Richard Sandiford
This patch adds a dump () method so that it's easier to read the contents of the various wide-int types in gdb. I've deliberately not done any extension for "small_prec" cases because I think here we want to see the raw values as much as possible. Tested on x86_64-linux-gnu. OK to install? Than

Re: [wide-int 1/5] Cosmetic fixes to wide-int.{cc,h}

2014-04-25 Thread Kenneth Zadeck
i see nothing in this patch that requires a review. On 04/25/2014 09:35 AM, Richard Sandiford wrote: This series of patches is from a read-through of wide-int.h and wide-int.cc. (The series from earlier in the week was from a diff of preexisting files.) This first patch fixes some comments, typo

Re: [PATCH] Fix PR60930

2014-04-25 Thread Bill Schmidt
On Fri, 2014-04-25 at 10:59 +0200, Richard Biener wrote: > On Fri, 25 Apr 2014, Jakub Jelinek wrote: > > > On Thu, Apr 24, 2014 at 09:20:50PM -0600, Jeff Law wrote: > > > > PR tree-optimization/60930 > > > > * gcc.dg/torture/pr60930.c: New test. > > > Doesn't the test depend on long long being at

[PING*2][C++ Patch, 4.8] Backport fix for c++/54537 to FSF 4.8

2014-04-25 Thread Peter Bergner
I'd like to ping*2 the following backport patch for the fix for PR54537. This did bootstrap and regtest with no regressions on powerpc64-linux. http://gcc.gnu.org/ml/gcc-patches/2014-03/msg01148.html Jonathan approved the library part, so I just need the front-end change approved. Peter

[PATCH][ARM][committed] Fix bootstrap: Initialise fields in Cortex-A8 tuning struct

2014-04-25 Thread Kyrill Tkachov
Hi all, As mentioned in http://gcc.gnu.org/ml/gcc/2014-04/msg00227.html we need to initialise the two fields recently added to the tuning structs for the recently added Cortex-A8 structs. I've committed the attached patch as an obvious fix as r209806. Tested and bootstrapped on arm-none-linu

[PATCH] Typofixes and a trivial change

2014-04-25 Thread Patrick Palka
Hi, This patch fixes a couple of typos in tree-vrp.c and one in invoke.texi. The patch also reorders the operands of an && condition in infer_nonnull_range() under the assumption that operand_equal_p() is much more costly than a simple TREE_TYPE() equality test. Bootstrapped and regtested on x86

[Patch, PR 60158] Generate .fixup sections for .data.rel.ro.local entries.

2014-04-25 Thread rohitarul...@freescale.com
Hello All, This is related to the following bug: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60158 Test case: Refer below Target: e500v2 Command line options: -Os -fdata-sections -fpic -mrelocatable -mno-spe Notes: GCC v4.7.3 puts the address of "abc" into the GOT directly GCC v

Re: [PATCH] Typofixes and a trivial change

2014-04-25 Thread Patrick Palka
I forgot the ChangeLog entry: 2014-04-25 Patrick Palka * doc/invoke.texi: Fix typo. * tree-vrp.c: Fix typos. * gimple.c (infer_nonnull_range): Reorder operands of an && condition.

[PATCH] Make ipa-prop analyze BBs in DOM order

2014-04-25 Thread Martin Jambor
Hi, the following patch deals with requested propagation in PR 53787 in the real benchmark (as opposed to the original simple testcase) by analyzing individual BBs in ipa-prop.c in dominator order. Currently we do the analysis in two loops, in the first the order is given by FOR_EACH_BB_FN and in

Re: [PATCH, ARM] Fix PR60609 (Error: value of 256 too large for field of 1 bytes)

2014-04-25 Thread Charles Baylis
This doesn't seem to have shown problems on trunk/4.9. I have bootstrapped and checked the patch on 4.8 arm-unknown-linux-gnueabihf (Thumb-2) on qemu. I have checked the patch on 4.7 arm-unknown-linux-gnueabihf (Thumb-2) on qemu. OK to backport to 4.8 and 4.7? On 7 April 2014 16:02, Charles Bay

Re: [PATCH, ARM] Fix PR60609 (Error: value of 256 too large for field of 1 bytes)

2014-04-25 Thread Ramana Radhakrishnan
On Fri, Apr 25, 2014 at 4:29 PM, Charles Baylis wrote: > This doesn't seem to have shown problems on trunk/4.9. > > I have bootstrapped and checked the patch on 4.8 > arm-unknown-linux-gnueabihf (Thumb-2) on qemu. > > I have checked the patch on 4.7 arm-unknown-linux-gnueabihf (Thumb-2) on qemu. >

[PATCH] Optionally trap on impossible devirtualization

2014-04-25 Thread Martin Jambor
Hi, the patch below might be useful for testcase preparation and debugging compiler bugs such as PR 60965. When -ftrap-on-impossible-devirtualization is supplied on the command line, it makes the devirtualization produce __builtin_trap instead of __builtin_unreachable when it comes to the conclus

[C PATCH] Better column info for initializers (PR c/60139)

2014-04-25 Thread Marek Polacek
Another minor fix: use loc instead of input_location. Also add missing OPT_Wpedantic. After this is in, my plan is to make pedwarn_init and error_init static (I already have a patch for that) and then add location argument to error_init and pass proper location to it, and to pedwarn_init as well

Re: [DOC PATCH] Rewrite docs for inline asm

2014-04-25 Thread Andrew Haley
On 04/25/2014 04:43 PM, James Greenhalgh wrote: > Beyond comments on ChangeLog formatting, the review for this patch seems > to have stalled again. > > The patch has been in review for two months now, with broadly positive > comments > and all suggestions made thus far have been incorporated. I'd

ALL_COMPILERFLAGS used instead of ALL_LINKERFLAGS in gcc/Makefile.in

2014-04-25 Thread Antonio Diaz Diaz
Hello. I think ALL_COMPILERFLAGS is incorrectly used instead of ALL_LINKERFLAGS in line 1909 of gcc/Makefile.in[1]. [1]http://gcc.gnu.org/viewcvs/gcc/trunk/gcc/Makefile.in?view=markup#l1909 I attach a trivial patch. Best regards, Antonio. --- Makefile.in~2014-04-25 17:40:32.

[C PATCH] Some c-typeck.c TLC

2014-04-25 Thread Marek Polacek
error_init and pedwarn_init aren't used outside of c-typeck.c, thus can be made static. (maybe_warn_string_init is used in the parser.) As they're small, I suspect they will be inlined now. I had to move the functions a little bit above so we don't need a prototypes for them. Bootstrapped on x86_

[patch] libstdc++/60958 disable invalid code in

2014-04-25 Thread Jonathan Wakely
00 }; /* { dg-warning "19:conversion of unsigned constant value to negative integer" } */ + struct S s2 = { .n = 0x8000 }; /* { dg-warning "24:conversion of unsigned constant value to negative integer" } */ + struct S s3 = { .u[1] = 0x8000 }; /* { dg-warning "

Re: [PATCH] Add a couple of dialect and warning options regarding Objective-C instance variable scope

2014-04-25 Thread Dimitris Papavasiliou
On 04/25/2014 04:07 AM, Mike Stump wrote: On Apr 24, 2014, at 4:09 PM, Dimitris Papavasiliou wrote: On 04/24/2014 07:00 PM, Mike Stump wrote: On Feb 6, 2014, at 1:25 AM, Dimitris Papavasiliou wrote: This is a patch regarding a couple of Objective-C related dialect options and warning switch

Re: [PATCH] Add a couple of dialect and warning options regarding Objective-C instance variable scope

2014-04-25 Thread Mike Stump
On Apr 25, 2014, at 9:34 AM, Dimitris Papavasiliou wrote: > --Wreturn-type -Wsequence-point -Wshadow @gol > +-Wreturn-type -Wsequence-point -Wshadow -Wshadow-ivar @gol This has to be -Wno-shadow-ivar, we document the non-default… > +@item -Wshadow-ivar @r{(Objective-C only)} Likewise. >

Re: [PATCH 2/2] Windows libcpp: Make path-exists semantics more Posix-like

2014-04-25 Thread Pedro Alves
On 04/19/2014 09:41 PM, Kai Tietz wrote: > Isn't this function something better placed in libiberty? Also this name > looks a bit confusing. Wouldn't be a an function calling for _WIN32 case > also stat, and just overrides the st_mode member, if it is a link better. So > I would put this fun

Re: [ada, build] Ignore cp -p failures during Ada make install

2014-04-25 Thread Mike Stump
On Apr 25, 2014, at 6:41 AM, Rainer Orth wrote: > When trying to install a freshly built gcc 4.9.0 on Solaris 9 and 10, I > ran into make install failures when using INSTALL_DATA_DATE: Ick, I hate this patch. You kill error checking for all, on something that is important, just because someone

Re: [ada, build] Ignore cp -p failures during Ada make install

2014-04-25 Thread Rainer Orth
Mike Stump writes: > On Apr 25, 2014, at 6:41 AM, Rainer Orth > wrote: >> When trying to install a freshly built gcc 4.9.0 on Solaris 9 and 10, I >> ran into make install failures when using INSTALL_DATA_DATE: > > Ick, I hate this patch. You kill error checking for all, on something > that is

Re: [PATCH 2/2] Windows libcpp: Make path-exists semantics more Posix-like

2014-04-25 Thread Pedro Alves
On 04/19/2014 08:40 PM, Ray Donnelly wrote: > Windows does a short-circuit lookup of paths containing > ../ which means that: > > exists/doesnotexist/../file > > is considered to exist, while on Posix it is considered > not to. The Posix semantics are relied upon when building > glibc so any path

Re: [ada, build] Ignore cp -p failures during Ada make install

2014-04-25 Thread Mike Stump
On Apr 25, 2014, at 10:01 AM, Rainer Orth wrote: > Agreed that this is ugly: ACL support in GNU coreutils has long been a > total mess; no idea if it has improved very recently. So, are there ACLs on these files? If so, why? If no ACLs, I fail to see how anything can error out no matter how po

Re: [ada, build] Ignore cp -p failures during Ada make install

2014-04-25 Thread Rainer Orth
Mike Stump writes: > On Apr 25, 2014, at 10:01 AM, Rainer Orth > wrote: >> Agreed that this is ugly: ACL support in GNU coreutils has long been a >> total mess; no idea if it has improved very recently. > > So, are there ACLs on these files? If so, why? If no ACLs, I fail to see > how anythi

Re: [PATCH] Fix PR60911

2014-04-25 Thread Jan Hubicka
> On Thu, 24 Apr 2014, Jan Hubicka wrote: > > > > > > > Simple IPA passes are supposed to see function bodies with IPA transforms > > > applied - this is what the code in execute_one_pass tries to ensure. > > > But that doesn't work anymore with on-demand function-body loading. > > > The followi

Update doc/gimple.texi to reflect change from union to class hierarchy

2014-04-25 Thread David Malcolm
Commits r205034 (de6bd75e3c9bc1efe8a6387d48eedaa4dafe622d) and r205428 (a90353203da18288cdac1b0b78fe7b22c69fe63f) eliminated the union gimple_statement_d in favor of a C++ class hierarchy. I forgot to update gimple.texi in those commits (sorry), which the following patch belatedly addresses. It r

Re: Examples of gimple statement API (was Re: [PATCH 03/89] Introduce gimple_bind and use it for accessors.)

2014-04-25 Thread David Malcolm
On Fri, 2014-04-25 at 10:37 +0200, Richard Biener wrote: > On Thu, Apr 24, 2014 at 4:59 PM, David Malcolm wrote: > > On Thu, 2014-04-24 at 09:09 -0400, Andrew MacLeod wrote: > >> On 04/24/2014 04:33 AM, Richard Biener wrote: > >> > On Wed, Apr 23, 2014 at 11:23 PM, Jeff Law wrote: > >> >> On 04/2

Re: [ada, build] Ignore cp -p failures during Ada make install

2014-04-25 Thread Mike Stump
On Apr 25, 2014, at 10:12 AM, Rainer Orth wrote: >> What about cp a b && touch -r a b? Seems safer, seem portable enough. > > I don't see why this shouldn't work. It won’t work on a machine from 1982… Honest. Life goes on, oh well… cp a b && { touch -r a b || true; } is the portable version

Re: [wide-int 3/5] Fix large widths in shifted_mask

2014-04-25 Thread Kenneth Zadeck
richard, I think that this patch is fine as is.but in looking at the surrounding code, i saw something that appears to be somewhat troubling. I am worried about the two asserts. Given that we now require that some users write code similar to the code in tree-vrp.c:2628, it seems that t

Re: [ada, build] Ignore cp -p failures during Ada make install

2014-04-25 Thread Arnaud Charlet
> It seems to me that (as already done in one of three cases in the > install-gnatlib target) $(INSTALL_DATA_DATE) errors should be ignored, > to allow for such a case. > > The following patch does just that and allowed the make install to > complete. > > Ok for mainline? No, it's not OK to igno

Re: [libcpp] use CPP_PEDANTIC

2014-04-25 Thread Tom Tromey
> "Prathamesh" == Prathamesh Kulkarni writes: Prathamesh> Use macro CPP_PEDANTIC (PF) instead of directly using Prathamesh> it's definition: CPP_OPTION (PF, cpp_pedantic). I'm curious why you want this. Prathamesh> [libcpp] Prathamesh> * directives.c (_cpp_handle_directive): Use CPP_PEDANTI

Re: [libcpp] use CPP_PEDANTIC

2014-04-25 Thread Prathamesh Kulkarni
On Fri, Apr 25, 2014 at 11:19 PM, Tom Tromey wrote: >> "Prathamesh" == Prathamesh Kulkarni writes: > > Prathamesh> Use macro CPP_PEDANTIC (PF) instead of directly using > Prathamesh> it's definition: CPP_OPTION (PF, cpp_pedantic). > > I'm curious why you want this. CPP_PEDANTIC is used everyw

Re: [ada, build] Ignore cp -p failures during Ada make install

2014-04-25 Thread Rainer Orth
Arnaud Charlet writes: >> It seems to me that (as already done in one of three cases in the >> install-gnatlib target) $(INSTALL_DATA_DATE) errors should be ignored, >> to allow for such a case. >> >> The following patch does just that and allowed the make install to >> complete. >> >> Ok for m

Re: [ada, build] Ignore cp -p failures during Ada make install

2014-04-25 Thread Rainer Orth
Arnaud Charlet writes: >> It seems to me that (as already done in one of three cases in the >> install-gnatlib target) $(INSTALL_DATA_DATE) errors should be ignored, >> to allow for such a case. >> >> The following patch does just that and allowed the make install to >> complete. >> >> Ok for m

Re: [PATCH 2/2] Windows libcpp: Make path-exists semantics more Posix-like

2014-04-25 Thread Kai Tietz
2014-04-25 18:53 GMT+02:00 Pedro Alves : > On 04/19/2014 09:41 PM, Kai Tietz wrote: > >> Isn't this function something better placed in libiberty? Also this name >> looks a bit confusing. Wouldn't be a an function calling for _WIN32 case >> also stat, and just overrides the st_mode member, if i

Re: [PATCH 2/2] Windows libcpp: Make path-exists semantics more Posix-like

2014-04-25 Thread Pedro Alves
On 04/25/2014 08:05 PM, Kai Tietz wrote: > 2014-04-25 18:53 GMT+02:00 Pedro Alves : >> On 04/19/2014 09:41 PM, Kai Tietz wrote: >> >>> Isn't this function something better placed in libiberty? Also this name >>> looks a bit confusing. Wouldn't be a an function calling for _WIN32 case >>> also s

Re: std::experimental::optional operator!=

2014-04-25 Thread Jonathan Wakely
On 30/03/14 12:54 +0200, Lars Gullik Bjønnes wrote: When trying to convert some code using boost::optional to using std::experimental::optional instead if come over the issue that I had to implement operator!= for the contained types. When looking at n3793 it states that operator!= should be imp

[jit] Ensure dlerror failures lead to the overall "compilation" failing

2014-04-25 Thread David Malcolm
Committed to branch dmalcolm/jit: gcc/jit/ * internal-api.c (gcc::jit::playback::context::compile): Put any output of dlerror through the add_error method, rather than merely printing it to stderr, so that the error is also recorded on the context. --- gcc/jit/Chan

Re: [PATCH] Properly check for _Cilk_spawn in return stmt (PR c/60197)

2014-04-25 Thread Jeff Law
On 02/17/14 10:51, Iyer, Balaji V wrote: I don't know Cilk stuff at all, but it seems that _Cilk_spawn is forbidden in a return statement. But then only checking TREE_CODE (retval) == CILK_SPAWN_STMT isn't sufficient, because CILK_SPAWN_STMT can be wrapped e.g. in MINUS_EXPR, C_MAYBE_CONST_EXPR,

Re: [RFC] Remove PUSH_ARGS_REVERSED from the RTL expander.

2014-04-25 Thread Jeff Law
On 03/24/14 05:44, James Greenhalgh wrote: Which is much neater. It seems to me that this would probably be of benefit on all targets. This would be an argument for setting PUSH_ARGS_REVERSED to 1 by default for all targets. However, this would have a perceivable impact on argument evaluation o

Re: [PATCH 2/2] Windows libcpp: Make path-exists semantics more Posix-like

2014-04-25 Thread Kai Tietz
2014-04-25 21:24 GMT+02:00 Pedro Alves : > On 04/25/2014 08:05 PM, Kai Tietz wrote: >> 2014-04-25 18:53 GMT+02:00 Pedro Alves : >>> On 04/19/2014 09:41 PM, Kai Tietz wrote: >>> Isn't this function something better placed in libiberty? Also this name looks a bit confusing. Wouldn't be a

[Patch 1/3] Use manual regex algorithm switching

2014-04-25 Thread Tim Shen
We used _GLIBCXX_REGEX_DFS_QUANTIFIERS_LIMIT to control which algorithm we should use; so when compiling a regex, the number of quantifiers(*, +, ?) will be counted and will be used for the algorithm switching. However, I do think give user the manual switch may make things simpler: _GLIBCXX_REGEX

[Patch 2/3] Make regex's infinite loop detection accurate

2014-04-25 Thread Tim Shen
regex_match("", regex("(?:)*") will cause segfault because the infinite loop detection (writeen by me) is stupid. :O Instead of checking begins and ends, now the executor tracks repeating count for every loop node (typically generated from the Kleene star *). It slows down the executor a bit (fro

[Patch 3/3] Separate `repeating` node from `alternative` node in regex

2014-04-25 Thread Tim Shen
Before this patch both alternative operator "|" and star operator "*" generate _S_opcode_alternative node. Now they generate _S_opcode_alternative and _S_opcode_repeat respectively, because the alternative handing is simpler comparing to the repeat node handling introduced by last patch. The whol

Re: [jit] Fix state issue in gcse.c

2014-04-25 Thread David Malcolm
On Sat, 2014-04-19 at 15:55 +0200, Steven Bosscher wrote: > On Sat, Apr 19, 2014 at 3:24 PM, Steven Bosscher wrote: > > On Tue, Mar 11, 2014 at 8:00 PM, David Malcolm wrote: > >> Investigation revealed the issue to be a CFG from the previous compile > >> being kept alive by this GC root in gcse.c:

PATCH: PR target/60969: [4.9/4.10 Regression] ICE in output_129 in MMXMOV of mode MODE_SF for march=pentium4

2014-04-25 Thread H.J. Lu
I checked this preappoved patch into trunk. But we generate the wrong code for the testcase due to mixing XMM and x87 registers. H.J. --- Index: ChangeLog === --- ChangeLog (revision 209810) +++ ChangeLog (working copy) @@ -1,3 +

Re: [Patch 1/3] Use manual regex algorithm switching

2014-04-25 Thread Jonathan Wakely
--- a/libstdc++-v3/include/bits/regex.tcc +++ b/libstdc++-v3/include/bits/regex.tcc @@ -28,12 +28,12 @@ * Do not attempt to use it directly. @headername{regex} */ -// See below __regex_algo_impl to get what this is talking about. The default -// value 1 indicated a conservative optimization wi

Re: [jit] Fix state issue in gcse.c

2014-04-25 Thread Steven Bosscher
On Fri, Apr 25, 2014 at 9:48 PM, David Malcolm wrote: > Thanks; your patch does indeed fix the issue: with it, I no longer need > the band-aid from my patch to be able to run the jit testsuite with full > optimization. Good. In the mean time I tested the patch, and found a typo: + if (icode != 0

  1   2   >