Re: [C PATCH] Make attributes accept enum values (PR c/50459)

2014-04-16 Thread Richard Henderson
On 04/14/2014 10:32 AM, Marek Polacek wrote: > + if (TREE_CODE (val) != IDENTIFIER_NODE > + && TREE_CODE (val) != FUNCTION_DECL) > + val = default_conversion (val); > + else if (TREE_CODE (val) == IDENTIFIER_NODE) > + { > + tree t = lookup_name (val); > + if (t &

Re: GCC's -fsplit-stack disturbing Mach's vm_allocate

2014-04-16 Thread Samuel Thibault
Thomas Schwinge, le Wed 09 Apr 2014 09:36:42 +0200, a écrit : > Well, the first step is to verify that TARGET_THREAD_SPLIT_STACK_OFFSET > and similar configury is correct for the Hurd, I have added the corresponding field, so we can just use the same offset as on Linux. Samuel

Do not apply loop alignment to final block

2014-04-16 Thread Eric Botcazou
The alignment code in final.c uses some heuristics to decide what alignment a block must be given. For the loop alignment, it's: /* In case block is frequent and reached mostly by non-fallthru edge, align it. It is most likely a first block of loop. */ An immediate counter-exa

Re: [PATCHv3 2/2] libstdc++: Add std::aligned_union.

2014-04-16 Thread Paolo Carlini
Hi, On 04/16/2014 05:47 PM, Rüdiger Sonderfeld wrote: + template Please avoid _ + Uppercase, those are badnames for many targets. Normally we add a p at the end. Also, I would mention in a comment the front-end bug preventing a much more straightforward implementation. Thanks, Paolo.

Re: [PATCHv3 2/2] libstdc++: Add std::aligned_union.

2014-04-16 Thread Paolo Carlini
.. also, per the GNU conventions, ? of a conditional expression should be at the beginning of a line (not at the end of the previous one). Paolo.

Re: [PATCH] Fix PR c++/60765

2014-04-16 Thread Patrick Palka
Thanks, Paolo!

Re: [PATCH] PR60822 (m68k, missing earlyclobber in extendplussidi)

2014-04-16 Thread segher
On Wed, Apr 16, 2014 at 02:45:28PM -0600, Jeff Law wrote: > Isn't the problem that operands 1 is a MEM which use the same register > as operands 3 in the memory address? Yes, exactly. > ISTM either removing the memory constraint entirely, or splitting it off > into a separate alternative and on

Re: [PATCH v2] libstdc++: Add hexfloat/defaultfloat io manipulators.

2014-04-16 Thread Luke Allardyce
> Thanks, I was wrong about that. > > Then I think we should just bite the bullet and provide the new > behaviour. If we do have an abi_tag on those types in the next release > then we can preserve the old behaviour in the old ABI and use the > C++11 semantics for the abi_tagged type, which will be

Re: [PATCH] Fix up rotate expansion (take 2)

2014-04-16 Thread DJ Delorie
Doing some work on the msp430 failures, I discovered that this patch: > --- gcc/expmed.c.jj 2013-05-07 10:26:46.0 +0200 > +++ gcc/expmed.c 2013-05-11 09:11:54.087412982 +0200 > @@ -2181,14 +2182,22 @@ expand_shift_1 (enum tree_code code, enu > rtx temp1; > >

Fix lto/PR60854

2014-04-16 Thread Jan Hubicka
Hi, the testcase shows problem where cpp implicit alias is always inline and symtab_remove_unreachable_nodes removes the body of aliased function before inlininghappens. The real problem is that cgraph_state is set too early and not as the comment says after inlinig, but for release branch I think

Add testcase for PR lto/60820

2014-04-16 Thread Jan Hubicka
Hi, this is stand alone testcase for that PR. Comitted to mainline. PR lto/60820 * gcc.dg/lto/pr60820_0.c: New testcase. * gcc.dg/lto/pr60820_1.c: New testcase. Index: testsuite/gcc.dg/lto/pr60820_1.c

Make ipa-devirt aware of fact that some types doesn't have instances

2014-04-16 Thread Jan Hubicka
Hi, this patch is a revision of the patch I proposed for BINFO_ABSTRACT_P. Basically it teaches ipa-devirt that CXX destructors are never called for types in construction and it also makes it to properly handle vtables of types that may not have instance. In this case we need to consider them only

Re: [PATCH, rs6000] Improve TImode add/sub

2014-04-16 Thread David Edelsohn
On Wed, Apr 16, 2014 at 4:51 PM, Pat Haugen wrote: > Updated patch with above comments incorporated. Bootstrap/regtest on BE/LE > with no new regressions. Ok for trunk? 2014-04-08 Pat Haugen * config/rs6000/rs6000.md (addti3, subti3): New. gcc/testsuite: * gcc.target/powerpc

Re: [PATCH] offline gcda profile processing tool

2014-04-16 Thread Jan Hubicka
> GCOT_TOOL needs to use this function to read the string in gcda file > to memory to construct gcov_info objects. > As you noticed, gcov runtime does not need this interface. But > gcov-tool links with gcov runtime and it also uses the function. > We could make it available in gcov_runtime, but th

RE: [PATCH][2/3] Fix PR54733 Optimize endian independent load/store

2014-04-16 Thread Thomas Preud'homme
> From: Richard Biener [mailto:richard.guent...@gmail.com] > > With handling only the outermost handled-component and then only a > selected subset you'll catch many but not all cases. Why not simply > use get_inner_reference () here (plus stripping the constant offset > from an innermost MEM_REF

Re: [PATCH GCC]Fix pr60363 by adding backtraced value of phi arg along jump threading path

2014-04-16 Thread Jeff Law
On 03/18/14 04:13, bin.cheng wrote: Hi, After control flow graph change made by http://gcc.gnu.org/ml/gcc-patches/2014-02/msg01492.html, case gcc.dg/tree-ssa/ssa-dom-thread-4.c is broken on logical_op_short_circuit targets including cortex-m3/cortex-m0. The regression reveals a missed opportunity

Re: [PATCH] Redesign jump threading profile updates

2014-04-16 Thread Jeff Law
On 03/26/14 17:44, Teresa Johnson wrote: Recently I discovered that the profile updates being performed by jump threading were incorrect in many cases, particularly in the case where the threading path contains a joiner. Some of the duplicated blocks/edges were not getting any counts, leading to

Re: [RFC] proof-of-concept: warning for a bit comparison that is always true/false

2014-04-16 Thread Daniel Marjamäki
Thanks! > I'd actually do this down at the gimple level. You'll have an SSA graph you > can use to identify the masking and verify its producing a single bit result. > You'll also have canonicalized comparisons, so there'll be fewer things to > test. Depending on exactly where you put the op

Reduce -flto -fprofile-generate memory use

2014-04-16 Thread Jan Hubicka
Hi, while compiling firefox I noticed that -fprofile-generage -flto goes to 8GB. It turns out that this is caused by ipa_reference no longer being disabled becaus in_lto_p became flag that is set later (it is not clear to me why it needs to be this way). I however do not see reason why not disable

<    1   2