Re: Do not produce empty try-finally statements

2014-01-20 Thread Richard Biener
Jakub Jelinek wrote: >On Sun, Jan 19, 2014 at 11:46:09PM +0100, Jan Hubicka wrote: >> Bootstrapped/regtested x86_64-linux, OK? > >This looks very wrong. By ignoring the clobbers in the cleanups you >ensure clobbers are hardly ever emitted, but the TRY/FINALLY is the way >how >to make sure the clo

Re: [Patch] Fix regex multiple consecutive quantifiers bug.

2014-01-20 Thread Tim Shen
On Sun, Jan 19, 2014 at 4:59 PM, Tim Shen wrote: > Tested and committed. It's quite interesting that after this change in the patch: - this->_M_quantifier(); + while (this->_M_quantifier()); ...even the regex input is nothing to do with quantifiers at all (say regex re(" ")), g++ -O3 generat

Re: [Patch] Fix regex multiple consecutive quantifiers bug.

2014-01-20 Thread Marc Glisse
On Mon, 20 Jan 2014, Tim Shen wrote: ...even the regex input is nothing to do with quantifiers at all (say regex re(" ")), g++ -O3 generates slower code than -O2: ~ # g++ -O2 perf.cc && time ./a.out ./a.out 0.46s user 0.00s system 99% cpu 0.461 total ~ # g++ -O3 perf.cc && time ./a.out ./a.out

[PATCH] Fix up ix86_avoid_lea_for_addr (PR target/59880)

2014-01-20 Thread Jakub Jelinek
Hi! As mentioned in the PR or even in the comment below, ix86_decompose_address sometimes sets parts.base to some REG and parts.disp to const0_rtx, even when the operands aren't of a lea insn, but normal or zero extending mov. Fixed thusly, bootstrapped/regtested on x86_64-linux and i686-linux, o

Re: [Patch] Fix regex multiple consecutive quantifiers bug.

2014-01-20 Thread Paolo Carlini
Hi, On 01/20/2014 09:31 AM, Marc Glisse wrote: It is a FAQ that you can't get the effects of -Oy with -Ox and a bunch of -f flags. Some things depend directly on the optimization level. For example, inlining of free functions. By the way, I think it is a *very* common experience that -O3 doesn'

Re: [PATCH][buildrobot] PR59496: Fix unused variable warning

2014-01-20 Thread Jakub Jelinek
On Tue, Jan 14, 2014 at 05:59:11PM +0100, Jan-Benedict Glaw wrote: > 2014-01-14 Jan-Benedict Glaw > > PR bootstrap/59496 > * config/rs6000/darwin.h (ADJUST_FIELD_ALIGN): Fix unused variable > warning. Ok, thanks. > diff --git a/gcc/config/rs6000/darwin.h b/gcc/config/rs6000/

Re: [PATCH] Fix up ix86_avoid_lea_for_addr (PR target/59880)

2014-01-20 Thread Uros Bizjak
On Mon, Jan 20, 2014 at 9:38 AM, Jakub Jelinek wrote: > As mentioned in the PR or even in the comment below, ix86_decompose_address > sometimes sets parts.base to some REG and parts.disp to const0_rtx, even > when the operands aren't of a lea insn, but normal or zero extending mov. > > Fixed thus

Re: [PATCH] Don't combine across likely spilled hard reg setters (PR rtl-optimization/59477)

2014-01-20 Thread Eric Botcazou
> I think the problem is still either a missed feature in LRA/reload > (split live-ranges), a problem in how we represent calls & argument > setup (magic hard-reg uses), or a backend problem (should spill > itself if necessary, via a post-reload splitter or always spill > and undo via a peephole2).

Re: Resolve pr44194-1.c failure by refining scan-rtl-dump-not pattern

2014-01-20 Thread Eric Botcazou
> I have made the adjustment and test it. Please check the new attachment. Thanks, applied on the mainline as obvious. -- Eric Botcazou

Re: experimental testsuite patch

2014-01-20 Thread Jonathan Wakely
On 19 January 2014 20:50, François Dumont wrote: > So here is another patch proposal with the faulty debug assertion commented > for the moment. > > 2014-01-20 François Dumont > > > * scripts/create_testsuite_files: Add testsuite/experimental in > the list of folders to introspect for te

Re: Allow passing arrays in registers on AArch64

2014-01-20 Thread Richard Earnshaw
On 17/01/14 23:56, Michael Hudson-Doyle wrote: > Ian Lance Taylor writes: > >> On Fri, Jan 17, 2014 at 11:32 AM, Michael Hudson-Doyle >> wrote: >>> >>> On 18 Jan 2014 07:50, "Yufeng Zhang" wrote: Also can you please try to add some new test(s)? It may not be that straightforward

Patch ping: [C++ PATCH] Emit array initialization from ctor as loop if possible (PR c++/59659)

2014-01-20 Thread Jakub Jelinek
On Fri, Jan 10, 2014 at 09:35:22PM +0100, Jakub Jelinek wrote: > 2014-01-10 Jakub Jelinek > > PR c++/59659 > * init.c (build_vec_init): If there are 10+ elements with the > same value in the CONSTRUCTOR, construct them using a runtime loop > rather than one by one. > >

Re: C++ PATCH to deal with trivial but non-callable [cd]tors

2014-01-20 Thread Eric Botcazou
> 2013-10-31 Eric Botcazou > > c-family/ > * c-ada-spec.h (cpp_operation): Add IS_TRIVIAL. > (dump_ada_specs): Adjust prototype of second callback. It turns out that adjusting (constifying) the prototype of the second callback was a gratuitous change and future enhancements will r

[Ada] Minor code reorganization

2014-01-20 Thread Eric Botcazou
This revamps the E_Component case of gnat_to_gnu_entity and improves comments. No functional changes, tested on x86_64-suse-linux, applied on the mainline. 2014-01-20 Eric Botcazou * gcc-interface/decl.c (gnat_to_gnu_entity) : Remove obsolete code for type_annotate_only mode,

Re: [PATCH, testsuite] Fix g++.dg/debug/ra1.C

2014-01-20 Thread Richard Earnshaw
On 16/01/14 18:44, Yufeng Zhang wrote: > Hi, > > g++.dg/debug/ra1.C fails on arm-none-eabi with the following message > because enum types in arm eabi are represented by the smallest integral > type: > > warning: width of 'tree_base::code' exceeds its type [enabled by default] > > This patch u

[Ada] Fix alignment of array aggregates

2014-01-20 Thread Eric Botcazou
This fixes a long-standing issue in the Ada compiler, whereby the alignment of aggregates whose type is an over-aligned array is lost in translation. Tested on x86_64-suse-linux, applied on the mainline. 2014-01-20 Eric Botcazou * gcc-interface/decl.c (gnat_to_gnu_entity) :

Re: [PATCH][RFC] Fix PR59860

2014-01-20 Thread Richard Biener
On Sun, 19 Jan 2014, Jakub Jelinek wrote: > On Sun, Jan 19, 2014 at 07:05:12PM +0100, Richard Biener wrote: > > The following patch fixes PR59860 by removing the only folding > > builtins.c does that can end up recursing to GIMPLE call stmt > > folding. It does that via strcat -> strlen + strcpy

[Ada] Fix latent issues with thin pointers

2014-01-20 Thread Eric Botcazou
This fixes latent issues with thin pointers, which get exposed with -gnatd6. Tested on x86_64-suse-linux, applied on the mainline. 2014-01-20 Eric Botcazou * gcc-interface/decl.c (gnat_to_gnu_entity) : Robustify tests for aliased objects with an unconstrained nominal subtype.

Re: [AArch64] Make -mcpu, -march and -mtune case-insensitive.

2014-01-20 Thread James Greenhalgh
On Fri, Jan 17, 2014 at 12:00:19PM +, Richard Earnshaw wrote: > On 17/01/14 11:12, Alan Lawrence wrote: > > Small patch to make the -mcpu, -march and -mtune command-line options > > case-insensitive, allowing e.g. -mcpu=CortexA57 -march=ARMv8-A. > > > > Tested on aarch64-none-elf with no regre

Re: [AArch64] Fix behaviour of -mcpu option to match ARM.

2014-01-20 Thread Richard Earnshaw
On 16/01/14 17:32, James Greenhalgh wrote: > > Hi, > > While clarifying the documentation of the -mcpu, -march and -mtune > options for AArch64 and ARM I spotted that their behaviour is not > consistent. > > This patch fixes that in the AArch64 port. > > Now, -mcpu=$CPU is treated as a shorthan

Re: [Patch AArch64] Implement Vector Permute Support

2014-01-20 Thread Alex Velenko
On 17/01/14 15:55, Richard Earnshaw wrote: On 16/01/14 14:43, Alex Velenko wrote: On 14/01/14 15:51, pins...@gmail.com wrote: On Jan 14, 2014, at 7:19 AM, Alex Velenko wrote: Hi, This patch turns off the vec_perm patterns for aarch64_be, this should resolve the issue highlighted here ht

Re: [Patch AArch64] Implement Vector Permute Support

2014-01-20 Thread Richard Earnshaw
On 20/01/14 11:15, Alex Velenko wrote: > On 17/01/14 15:55, Richard Earnshaw wrote: >> On 16/01/14 14:43, Alex Velenko wrote: >>> On 14/01/14 15:51, pins...@gmail.com wrote: > On Jan 14, 2014, at 7:19 AM, Alex Velenko wrote: > > Hi, > > This patch turns off the vec_pe

Re: [PATCH][buildrobot] PR59496: Fix unused variable warning

2014-01-20 Thread Iain Sandoe
On 20 Jan 2014, at 08:45, Jakub Jelinek wrote: > On Tue, Jan 14, 2014 at 05:59:11PM +0100, Jan-Benedict Glaw wrote: >> 2014-01-14 Jan-Benedict Glaw >> >> PR bootstrap/59496 >> * config/rs6000/darwin.h (ADJUST_FIELD_ALIGN): Fix unused variable >> warning. > > Ok, thanks. As di

[AArch64 Documentation] Clarify meaning of -mcpu, -mtune, -march

2014-01-20 Thread James Greenhalgh
Hi, These three options can be a pain to remember how they interact with one another, this patch clarifies the situation giving explicit documentation as to the expected behaviour where they are combined. OK? Thanks, James --- gcc/ 2014-01-20 James Greenhalgh * doc/invoke.texi (-m

Re: Commit: MSP430: Add -mcpu= option

2014-01-20 Thread nick clifton
Hi Gerald, Mind adding an entry to the release notes? Happy to help if you have any questions. Is the following acceptable ? I even remembered to run it through the validator... Cheers Nick Index: htdocs/gcc-4.9/changes.html

Re: [PATCH][RFC] Fix PR59860

2014-01-20 Thread Jakub Jelinek
On Mon, Jan 20, 2014 at 11:54:15AM +0100, Richard Biener wrote: > Ok, the following simpler patch also fixes the issue and causes > no testsuite fallout - we restrict the folding in builtins.c to > the case with known src strlen. But then we simply never optimize this anymore. Or regress when you

Re: [PATCH] Fix up ix86_avoid_lea_for_addr (PR target/59880)

2014-01-20 Thread Uros Bizjak
On Mon, Jan 20, 2014 at 10:11 AM, Uros Bizjak wrote: >> As mentioned in the PR or even in the comment below, ix86_decompose_address >> sometimes sets parts.base to some REG and parts.disp to const0_rtx, even >> when the operands aren't of a lea insn, but normal or zero extending mov. >> >> Fixed

Re: reload autoinc fix

2014-01-20 Thread Bernd Schmidt
On 01/16/2014 09:53 PM, Jeff Law wrote: I happened to be going through the list of regressions and came across this again. I went ahead and installed the patch on the trunk and closed the BZ. Thanks. I was travelling and decided not to install any patches before or during that. Bernd

Re: [build, libgcc] Ensure libgcc_s unwinder is always used on 64-bit Solaris 10+/x86 (PR target/59788)

2014-01-20 Thread Rainer Orth
Rainer Orth writes: > Unfortunately, the patch needs a change to the bundled ltmain.sh: by > default, libtool `optimizes' -lgcc_s -lc -lgcc_s into -lc -lgcc_s. > Combined with direct binding, this lead to exactly the failure the patch > intends to avoid. The libtool bug has already been reported

Re: [build, libgcc] Ensure libgcc_s unwinder is always used on 64-bit Solaris 10+/x86 (PR target/59788)

2014-01-20 Thread Paolo Bonzini
Il 17/01/2014 15:21, Rainer Orth ha scritto: > As described in the PR, the 64-bit Solaris 10+/x86 libc contains an > implementation of those _Unwind_* functions required by the AMD64 ABI, > i.e. those contained in libgcc_s.so.1 at version GCC_3.0. > > If by some circumstance (use of -Bdirect, -z l

Re: [PATCH][RFC] Fix PR59860

2014-01-20 Thread Richard Biener
On Mon, 20 Jan 2014, Jakub Jelinek wrote: > On Mon, Jan 20, 2014 at 11:54:15AM +0100, Richard Biener wrote: > > Ok, the following simpler patch also fixes the issue and causes > > no testsuite fallout - we restrict the folding in builtins.c to > > the case with known src strlen. > > But then we s

Re: [PATCH][RFC] Fix PR59860

2014-01-20 Thread Jakub Jelinek
On Mon, Jan 20, 2014 at 01:35:05PM +0100, Richard Biener wrote: > > tree-ssa-strlen.c apparently both doesn't this case (unknown first strlen, > > known second strlen or movstr pattern, will only transform that if the > > length of the resulting string is needed afterwards), and isn't run > > for -

Re: [PATCH][RFC] Fix PR59860

2014-01-20 Thread Richard Biener
On Mon, 20 Jan 2014, Jakub Jelinek wrote: > On Mon, Jan 20, 2014 at 01:35:05PM +0100, Richard Biener wrote: > > > tree-ssa-strlen.c apparently both doesn't this case (unknown first strlen, > > > known second strlen or movstr pattern, will only transform that if the > > > length of the resulting st

[Ada] Change SPARK_Mode into GNATprove_Mode, and avoid expansion

2014-01-20 Thread Arnaud Charlet
The use of SPARK_Mode to refer to GNAT being called in the context of formal verification was confusing, because of the recent addition of a new pragma SPARK_Mode with a different meaning. This mode of the frontend has been renamed GNATprove_Mode, to refer to the tool it is used in. (This is simila

[Ada] Remove obsolete mode Full_Expander_Active

2014-01-20 Thread Arnaud Charlet
With the rewriting of the GNATprove mode of the frontend, the pseudo-flag Full_Expander_Active is now the same as Expander_Active, so remove it. Also, the special rewriting of renamings into renamed subprograms for each call done in GNATprove mode is now moved to the GNATprove backend. 2014-01-20

[Ada] Abstract views of states and variables

2014-01-20 Thread Arnaud Charlet
This patch implements abstract views of states and variables defined as: State abstractions are visible in the limited view of packages in SPARK 2014. The notion of an abstract view of a variable declaration is also introduced, and the limited view of a package includes the abstract view of any va

[Ada] Memory corruption in GNAT.Array_Split (and String_Split)

2014-01-20 Thread Arnaud Charlet
Use a copy-on-write scheme to ensure that a Slice_Set is not deallocated twice. The following program must execute under valgrind without error: with Ada.Text_IO; use Ada.Text_IO; with GNAT.String_Split; use GNAT.String_Split; procedure Gspl is C, C2 : Slice_Set; begin declare S : Sl

Re: [AArch64 Documentation] Clarify meaning of -mcpu, -mtune, -march

2014-01-20 Thread Richard Earnshaw
On 20/01/14 11:39, James Greenhalgh wrote: > > Hi, > > These three options can be a pain to remember how they interact > with one another, this patch clarifies the situation giving explicit > documentation as to the expected behaviour where they are combined. > > OK? > > Thanks, > James > > --

[Ada] Preliminary work to support ARM unwinder

2014-01-20 Thread Arnaud Charlet
Tested on x86_64-pc-linux-gnu, committed on trunk 2014-01-20 Tristan Gingold * raise-gcc.c (exception_class_eq): New function. (is_handled_by): Use it to compare exception classes. (PERSONALITY_STORAGE): Define. (continue_unwind): New function to be called to r

Re: [PATCH][RFC] Fix PR59860

2014-01-20 Thread Jakub Jelinek
On Mon, Jan 20, 2014 at 02:37:21PM +0100, Richard Biener wrote: > Well, strcat itself can do that ... but yes, as I said, if you can > CSE that strlen call then it's a win. But you can't know this without It can't, strcat doesn't know the length of the src string, we don't have any 3 argument str

Re: [PATCH][RFC] Fix PR59860

2014-01-20 Thread Richard Biener
On Mon, 20 Jan 2014, Jakub Jelinek wrote: > On Mon, Jan 20, 2014 at 02:37:21PM +0100, Richard Biener wrote: > > Well, strcat itself can do that ... but yes, as I said, if you can > > CSE that strlen call then it's a win. But you can't know this without > > It can't, strcat doesn't know the lengt

[Ada] Cleanup of aspect/pragma Refined_Post

2014-01-20 Thread Arnaud Charlet
This patch adds logic to verify that the expression of aspect/pragma Refined_Post mentions 'Result and introduces a post-state when applied to a function. -- Source -- -- result_and_post.ads package Result_And_Post is function OK (Formal : Integer) return Integer;

[Ada] Missing finalization of transient result with exception

2014-01-20 Thread Arnaud Charlet
This patch corrects the finalization machinery to ensure that a controlled transient result is finalized when the related context raises an exception. -- Source -- -- pack.ads with Ada.Finalization; use Ada.Finalization; package Pack is type Ctrl is new Controlled

Re: [PATCH] Don't combine across likely spilled hard reg setters (PR rtl-optimization/59477)

2014-01-20 Thread Vladimir Makarov
On 1/20/2014, 4:12 AM, Eric Botcazou wrote: I think the problem is still either a missed feature in LRA/reload (split live-ranges), a problem in how we represent calls & argument setup (magic hard-reg uses), or a backend problem (should spill itself if necessary, via a post-reload splitter or alw

[Ada] Aspects Depends and Global on subprogram body stubs

2014-01-20 Thread Arnaud Charlet
This patch corrects the relocation of aspects related to a subprogram body stub that also acts as a spect. -- Source -- -- stubs.ads package Stubs is procedure S1 (L, R : in out Integer) with Depends => (L => R, R => L); procedure Error1 (L, R : in out Inte

[Ada] New pragma Allow_Integer_Address

2014-01-20 Thread Arnaud Charlet
The new configuration pragma Allow_Integer_Address sets a mode in which expressions of an integer type may be used in constructs that normally require an expression of type System.Address. The effect is to introduce an implicit unchecked conversion from the integer type to type Address. This mode

[Ada] Enabling assertions in predefined units

2014-01-20 Thread Arnaud Charlet
Some configuration switches that usually do not apply to predefined units, such as enabling assertion checking, can be applied to such a unit when they are the main unit and the switch is provided in the compilation command. When such a unit is a package body, the switch setting must apply as well

[Ada] Refinements for pragma Allow_Integer_Address

2014-01-20 Thread Arnaud Charlet
The switch -gnates is no longer available, this mode must be set using the configuration pragma, or -gnatd.M or is set automatically in CodePeer mode. The pragma is now only allowed if Address is a private type (since otherwise it makes no sense), and finally an error is corrected which caused the

[Ada] 'use all type' syntax error

2014-01-20 Thread Arnaud Charlet
This patch detects a syntax error when "use all" is not followed by "type". The following test must get an error: gcc -c use_all_type_syntax.adb use_all_type_syntax.ads:3:12: "type" expected package Use_All_Type_Syntax is use all TYP Boolean; -- syntax error end Use_All_Type_Syntax; Tested o

[Ada] Fully initialized types

2014-01-20 Thread Arnaud Charlet
This patch adds an enumeration type and a function to determine the default initialization kind of an arbitrary type. These facilities are intended for formal verification proofs. No applicable test. Tested on x86_64-pc-linux-gnu, committed on trunk 2014-01-20 Hristian Kirtchev * sem_

[Ada] Better handling of exponentiation range check

2014-01-20 Thread Arnaud Charlet
This corrects the problem of failing to set the Do_Range_Check flag for the right operand of integer exponentiation when needed. It supercedes the special check previously made in checks to unconditionally set the flag in gnatprove mode. The flag is now properly set, with proper range analysis, in

[Ada] Uniform trees for certain aspects and corresponding source pragmas

2014-01-20 Thread Arnaud Charlet
This patch ensures that the sole argument of pragmas Abstract_State, Contract_Cases, Depends, Global, Initializes, Refined_Depends, Refined_Global and Refined_State is always an aggregate unless it is "null". The end result of this change is a uniform tree in both aspect specifications and pragmas.

Re: [patch] fix libstdc++/56267 - local iterator requirements

2014-01-20 Thread Jonathan Wakely
On 17 January 2014 15:11, Jonathan Wakely wrote: > The issue in PR 56267 is that unordered_xxx::local_iterator sometimes > inherits from the user-defined hash function (via _Hash_code_base, > which inherits from the hash function to use the EBO), and > local_iterator must be DefaultConstructible an

[Ada] Free debug flags used for GNATprove mode

2014-01-20 Thread Arnaud Charlet
Debug flags used during initial development of GNATprove are now freed, at the exception of -gnatd.F, which stays as a pure debug flag to emulate the behavior of the frontend in GNATprove mode. Tested on x86_64-pc-linux-gnu, committed on trunk 2014-01-20 Yannick Moy * debug.adb Free d

[Ada] Missing return statement is illegal in GNATprove mode

2014-01-20 Thread Arnaud Charlet
This patch makes the missing return statement illegal in GNATprove mode as required by official SPARK 2014 syntax/semantics. The following program is compiled with -gnatd.F 1. package Various is 2.subtype Index_Type is 3. Positive range 1 .. 10; 4.type Integer_Arra

Re: Do not produce empty try-finally statements

2014-01-20 Thread Jan Hubicka
> >struct A { char buf[64]; }; > >void foo (char *); > >void test () > >{ > > { A a; foo (a.buf); a.buf[6] = 1; a.buf[7] = 8; } > > { A a; foo (a.buf); a.buf[6] = 1; a.buf[7] = 8; } > > { A a; foo (a.buf); a.buf[6] = 1; a.buf[7] = 8; } > > { A a; foo (a.buf); a.buf[6] = 1; a.buf[7] = 8; } > >

[Ada] Test SPARK_Mode instead of GNATProve_Mode for warnings

2014-01-20 Thread Arnaud Charlet
This changes the handling of cases in which warnings are normally given for constructs that are bound to raise run time exceptions if executed. Previously we converted these to errors unconditionally in GNATProve mode, but that caused trouble with non-SPARK code, notably s-scaval from the run-time

Re: Do not produce empty try-finally statements

2014-01-20 Thread Jakub Jelinek
On Mon, Jan 20, 2014 at 05:07:18PM +0100, Jan Hubicka wrote: > So I guess we can not modify giplifier to output > foo (&a.buf); > a.buf[6] = 1; > a.buf[7] = 8; > a = {CLOBBER}; > > instead of > > try > { > foo (&a.buf); > a.buf[6] = 1; >

Re: Do not produce empty try-finally statements

2014-01-20 Thread Jan Hubicka
> > Yes. Say, this could be surrounded by some try/catch, if we do it the first > way, a would be still considered live across the EH path to whatever catches > it. > > The EH optimizations involving cleanups with only clobbers in them are that > if at the end of the cleanup after only CLOBBER s

Re: [Patch][AArch64] vneg floating point testcase BE fixed

2014-01-20 Thread Alex Velenko
On 17/01/14 14:39, Richard Earnshaw wrote: On 17/01/14 14:22, Alex Velenko wrote: Hi, Here are some more improvements on changelog entry: gcc/testsuite/ 2013-01-16 Alex Velenko * gcc.target/aarch64/vneg_f.c (STORE_INST): New macro. (RUN_TEST): Use new macro. (INDEX6

[PATCH, committed] Fix for PR 58996

2014-01-20 Thread Iyer, Balaji V
Hello Everyone, The attached patch will fix the issue pointed out in PR 58996. The main issue was that the runtime was not checking for the availability of pthread affinity before calling its functions. This patch should fix that. Here is the ChangeLog entry: 2014-01-20 Balaji V. Iyer

Re: [AArch64] Define BE loader name.

2014-01-20 Thread Marcus Shawcroft
On 6 January 2014 15:36, Marcus Shawcroft wrote: > Hi, > > This patch defines the AArch64 BE loader name. Corresponding patches for > glibc and binutils have been posted on the relevant lists. > > /Marcus > > >* config/aarch64/aarch64-linux.h (GLIBC_DYNAMIC_LINKER): Expand > loader >

Re: [Patch AArch64] Implement Vector Permute Support

2014-01-20 Thread Alex Velenko
On 20/01/14 11:16, Richard Earnshaw wrote: On 20/01/14 11:15, Alex Velenko wrote: On 17/01/14 15:55, Richard Earnshaw wrote: On 16/01/14 14:43, Alex Velenko wrote: On 14/01/14 15:51, pins...@gmail.com wrote: On Jan 14, 2014, at 7:19 AM, Alex Velenko wrote: Hi, This patch turns off the v

Re: [PATCH] Fix up ix86_avoid_lea_for_addr (PR target/59880)

2014-01-20 Thread Uros Bizjak
On Mon, Jan 20, 2014 at 1:12 PM, Uros Bizjak wrote: > On Mon, Jan 20, 2014 at 10:11 AM, Uros Bizjak wrote: > >>> As mentioned in the PR or even in the comment below, ix86_decompose_address >>> sometimes sets parts.base to some REG and parts.disp to const0_rtx, even >>> when the operands aren't of

Re: [PATCH][RFC] Fix PR59860

2014-01-20 Thread Jakub Jelinek
On Mon, Jan 20, 2014 at 03:53:08PM +0100, Richard Biener wrote: > That works for me. Ok, here is what I've committed after bootstrap/regtest on x86_64-linux and i686-linux. 2014-01-20 Jakub Jelinek PR middle-end/59860 * tree.h (fold_builtin_strcat): New prototype. * bu

Re: [Patch][AArch64] vneg floating point testcase BE fixed

2014-01-20 Thread Marcus Shawcroft
On 20 January 2014 17:21, Alex Velenko wrote: > Could someone, please, commit it, as I do not have commit rights > > Alex I've committed this for you. /Marcus

Re: [Patch AArch64] Implement Vector Permute Support

2014-01-20 Thread Marcus Shawcroft
On 20 January 2014 17:33, Alex Velenko wrote: > Can someone, please, commit this patch, as I do not have permissions? > Kind regards, > Alex Committed. /Marcus

Re: [build, libgcc] Ensure libgcc_s unwinder is always used on 64-bit Solaris 10+/x86 (PR target/59788)

2014-01-20 Thread Ian Lance Taylor
On Mon, Jan 20, 2014 at 4:29 AM, Rainer Orth wrote: > > Given that there were no other comments, I'd like to install the patch > now. Ian, could you please install the ltmain.sh patch in libgo/config, > or should I do so myself? I'll do it. Thanks. Ian

[Patch, fortran] PR59414 [4.8/4.9 Regression] [OOP] ICE in in gfc_conv_expr_descriptor on ALLOCATE inside SELECT TYPE

2014-01-20 Thread Paul Richard Thomas
Dear All, This is a straightforward patch that is completely described in the ChangeLog entry. I am surprised that this could be a 4.8 regression since, as far as I am aware, SELECT_TYPE was not capable of handling array selectors before... Nonetheless, it flagged it up for me :-) Bootstrapped an

[PATCH] Fix PR59890, improve var-tracking compile-time

2014-01-20 Thread Richard Biener
This improves var-tracking dataflow convergence by using post order on the inverted CFG - which is appropriate for forward dataflow problems. This haves compile-time spent in var-tracking for PR45364 (it also improves other testcases, but that one seems to be the best case). For this to pass bo

Re: Commit: MSP430: Add -mcpu= option

2014-01-20 Thread Gerald Pfeifer
nick clifton wrote:> >Is the following acceptable ? I even remembered to run it through the >validator... Nice. "command-line option", I think, and I suggest to use ... around the actual options. Gerald

Re: [PATCH] libgcc: use linker script for libgcc_s.so on xtensa

2014-01-20 Thread Sterling Augustine
On Sun, Jan 19, 2014 at 1:21 AM, Baruch Siach wrote: > The xtensa port uses __xtensa_libgcc_window_spill in libgcc to implement > __builtin_frame_address. This symbol is local/hidden in libgcc. This is not a > problem when linking against static libgcc. But g++ defaults to > -shared-libgcc, thus b

Re: PATCH: PR middle-end/59789: [4.9 Regression] ICE in in convert_move, at expr.c:333

2014-01-20 Thread Jan Hubicka
> +enum cgraph_inline_failed_flag_t > +{ > + CIF_FINAL_NORMAL = 0, > + CIF_FINAL_ERROR The difference is that some errors will never go away, while others are "temporary" and inliner may revisit them later and inline (such as when indirect call becomes direct). So perhaps CIF_FINAL/CIF_NORMAL?

Re: RFA: Fix assembler data directives emitted for variable length structures

2014-01-20 Thread Eric Botcazou
> * output.h (output_constant): Update prototype and descriptive > comment. Please watch out for long lines (this one has 92 characters). It turns out that output_constant can be privatized, the last use outside varasm.c in the Java front-end was removed in the course of 4.8.x devel

Re: [PATCH] Fix PR59890, improve var-tracking compile-time

2014-01-20 Thread Alexandre Oliva
On Jan 20, 2014, Richard Biener wrote: > local_get_addr_clear_given_value (const void *v ATTRIBUTE_UNUSED, > void **slot, void *x) > { > ! if (*slot != NULL > ! && vt_get_canonicalize_base ((rtx)*slot) == x) > *slot = NULL; > return true; >

Re: [PATCH] libgcc: use linker script for libgcc_s.so on xtensa

2014-01-20 Thread Chris Zankel
Hi Sterling, Given that you are the maintainer on file and I think you have signed the copyright assignment, you should be able to just take it. AFAIK a copyright assignment is only required for large(r) patches. Thanks, -Chris On 1/20/14, 12:06 PM, Sterling Augustine wrote: On Sun, Jan 19,

Re: [PATCH] Fix PR59890, improve var-tracking compile-time

2014-01-20 Thread Jakub Jelinek
On Mon, Jan 20, 2014 at 06:24:36PM -0200, Alexandre Oliva wrote: > > ! if (var->onepart == ONEPART_VALUE) > > { > > rtx x = dv_as_value (dv); > > void **slot; > > --- 2502,2509 > > > gcc_assert (var->n_var_parts == 1); > > > ! if (var->onepart == ONEPART_VAL

Re: [PATCH] Don't combine across likely spilled hard reg setters (PR rtl-optimization/59477)

2014-01-20 Thread Eric Botcazou
> I've just started to work on fixing this in LRA. But I am not going to > work on fixing this in reload. It would be just wasting enormous amount > of time. Yes, fixing it in LRA only would be sufficient for PR rtl-optimization/59477, since it's an x86-specific issue. Other architectures aren

[PATCH] add __attribute__ ((designated_init))

2014-01-20 Thread Tom Tromey
This adds __attribute__((designated_init)) and -Wdesignated-init, a feature from sparse. This is also PR c/59855. The name of the attribute and the option were chosen to be compatible with sparse. I added this warning to -Wall since it seemed like the kind of warning users would ordinarily want

Re: [testsuite] Require -ffat-lto-objects for scan-rtl-dump*

2014-01-20 Thread Mike Stump
On Jan 19, 2014, at 9:13 AM, Richard Sandiford wrote: > We don't compile to RTL or machine instructions for lean LTO objects, > so the scan-assembler tests force -ffat-lto-objects to be used instead. > This patch extends that to scan-rtl-dump*. > > Tested on mips64-linux-gnu, where it fixes an U

[PATCH, i386]: Fix PR59685, ICE with -march=bdver1 -mavx512f

2014-01-20 Thread Uros Bizjak
Hello! Just unhandled V16SFmode in one of the new avx512 patterns. 2014-01-20 Uros Bizjak PR target/59685 * config/i386/sse.md (*andnot3): Handle MODE_V16SF mode attribute in insn output. Tested on x86_64-pc-linux-gnu {,-m32} and committed to mainline SVN. Uros. Index: sse.md =

Re: PATCH: PR middle-end/59789: [4.9 Regression] ICE in in convert_move, at expr.c:333

2014-01-20 Thread H.J. Lu
On Mon, Jan 20, 2014 at 12:09 PM, Jan Hubicka wrote: >> +enum cgraph_inline_failed_flag_t >> +{ >> + CIF_FINAL_NORMAL = 0, >> + CIF_FINAL_ERROR > > The difference is that some errors will never go away, while others are > "temporary" > and inliner may revisit them later and inline (such as when

Re: [patch] fix libstdc++/56267 - local iterator requirements

2014-01-20 Thread François Dumont
On 01/20/2014 04:53 PM, Jonathan Wakely wrote: On 17 January 2014 15:11, Jonathan Wakely wrote: The issue in PR 56267 is that unordered_xxx::local_iterator sometimes inherits from the user-defined hash function (via _Hash_code_base, which inherits from the hash function to use the EBO), and loca

Re: [PATCH, i386]: Fix PR59685, ICE with -march=bdver1 -mavx512f

2014-01-20 Thread Jakub Jelinek
On Mon, Jan 20, 2014 at 09:49:16PM +0100, Uros Bizjak wrote: > Hello! > > Just unhandled V16SFmode in one of the new avx512 patterns. > > 2014-01-20 Uros Bizjak > > PR target/59685 > * config/i386/sse.md (*andnot3): Handle MODE_V16SF > mode attribute in insn output. > > Tested on

Re: [PATCH, i386]: Fix PR59685, ICE with -march=bdver1 -mavx512f

2014-01-20 Thread Uros Bizjak
On Mon, Jan 20, 2014 at 10:14 PM, Jakub Jelinek wrote: >> Just unhandled V16SFmode in one of the new avx512 patterns. >> >> 2014-01-20 Uros Bizjak >> >> PR target/59685 >> * config/i386/sse.md (*andnot3): Handle MODE_V16SF >> mode attribute in insn output. >> >> Tested on x86_64-pc

Re: [PATCH] remove some old code from ansidecl.h

2014-01-20 Thread Tom Tromey
> "Tom" == Tom Tromey writes: Tom> This patch removes the last uses of PARAMS from include, and the last Tom> uses of the obsolete VA_* wrapper macros from libiberty. Then, it Tom> removes many obsolete macro definitions from ansidecl.h. Ping. Tom

Re: [PATCH, i386]: Fix PR59685, ICE with -march=bdver1 -mavx512f

2014-01-20 Thread Jakub Jelinek
On Mon, Jan 20, 2014 at 10:17:35PM +0100, Uros Bizjak wrote: > On Mon, Jan 20, 2014 at 10:14 PM, Jakub Jelinek wrote: > > >> Just unhandled V16SFmode in one of the new avx512 patterns. > >> > >> 2014-01-20 Uros Bizjak > >> > >> PR target/59685 > >> * config/i386/sse.md (*andnot3): Hand

Re: Allow passing arrays in registers on AArch64

2014-01-20 Thread Michael Hudson-Doyle
Richard Earnshaw writes: > On 17/01/14 23:56, Michael Hudson-Doyle wrote: >> Ian Lance Taylor writes: >> >>> On Fri, Jan 17, 2014 at 11:32 AM, Michael Hudson-Doyle >>> wrote: On 18 Jan 2014 07:50, "Yufeng Zhang" wrote: > > Also can you please try to add some new test(s)? It

Re: [PATCH] remove some old code from ansidecl.h

2014-01-20 Thread DJ Delorie
Sorry, did a review, checked the repos, forgot to say OK :-P Ok. intl worried me a bit, but they have duplicates of the macros you're removing.

Re: Allow passing arrays in registers on AArch64

2014-01-20 Thread Tom Tromey
> "Michael" == Michael Hudson-Doyle writes: >> My preferred languages for these tests would be (in approximate order) >> c, c++, fortran, java, ada, go. That order is based on which languages >> are tested most by users. Michael> Well of course it cannot be done in C or C++. A commenter on

Re: [PATCH] remove some old code from ansidecl.h

2014-01-20 Thread Tom Tromey
> "DJ" == DJ Delorie writes: DJ> Sorry, did a review, checked the repos, forgot to say OK :-P :) DJ> Ok. Thanks. DJ> intl worried me a bit, but they have duplicates of the macros you're DJ> removing. FWIW, in binutils-gdb.git, readline in the same position. Tom

Re: [PATCH, i386]: Fix PR59685, ICE with -march=bdver1 -mavx512f

2014-01-20 Thread Uros Bizjak
On Mon, Jan 20, 2014 at 10:37 PM, Jakub Jelinek wrote: >> >> Just unhandled V16SFmode in one of the new avx512 patterns. >> >> >> >> 2014-01-20 Uros Bizjak >> >> >> >> PR target/59685 >> >> * config/i386/sse.md (*andnot3): Handle MODE_V16SF >> >> mode attribute in insn output. >> >

RE: [PATCH] fix for PR 59825

2014-01-20 Thread Iyer, Balaji V
> -Original Message- > From: Jakub Jelinek [mailto:ja...@redhat.com] > Sent: Wednesday, January 15, 2014 5:55 PM > To: Iyer, Balaji V > Cc: gcc-patches@gcc.gnu.org > Subject: Re: [PATCH] fix for PR 59825 > > On Wed, Jan 15, 2014 at 10:37:04PM +, Iyer, Balaji V wrote: > > Hello Everyone

[Patch] Fix regex `nosubs` correctly

2014-01-20 Thread Tim Shen
The semantic of `nosubs` should simply be that `let all parentheses not be a subexpression and do not capture it`. Tested with -m64 and -m32 respectively. Thank you! -- Regards, Tim Shen commit 6972b7eb795adb462182ec96684cc94b7bb8a338 Author: tim Date: Mon Jan 20 17:33:44 2014 -0500 20

[libgfortran] Some minor fix-ups committed

2014-01-20 Thread Jerry DeLisle
I have committed for Dominiq some followup minor cleanup. Index: io/write_float.def === --- io/write_float.def (revision 206864) +++ io/write_float.def (working copy) @@ -373,7 +373,7 @@ updown: rchar = '0'; - if (ft != FMT_

[rl78] verify clobbers

2014-01-20 Thread DJ Delorie
Minor tweak to make sure we don't try to take the REGNO of a MEM. Committed. * config/rl78/rl78.c (rl78_propogate_register_origins): Verify that CLOBBERs are REGs before propogating their values. Index: config/rl78/rl78.c ==

Re: [PATCH] libgcc: use linker script for libgcc_s.so on xtensa

2014-01-20 Thread Baruch Siach
Hi Sterling, On Mon, Jan 20, 2014 at 12:06:59PM -0800, Sterling Augustine wrote: > On Sun, Jan 19, 2014 at 1:21 AM, Baruch Siach wrote: > > The xtensa port uses __xtensa_libgcc_window_spill in libgcc to implement > > __builtin_frame_address. This symbol is local/hidden in libgcc. This is not > >

Re: [PATCH] libgcc: use linker script for libgcc_s.so on xtensa

2014-01-20 Thread Sterling Augustine
On Mon, Jan 20, 2014 at 9:46 PM, Baruch Siach wrote: > Hi Sterling, >> This is OK for mainline. > > Thanks. This is needed for the 4.7 and 4.8 branches as well. > >> I assume your copyright assignment is on file? > > According to > https://www.gnu.org/prep/maintain/html_node/Legally-Significant.ht

Re: [PATCH] libgcc: use linker script for libgcc_s.so on xtensa

2014-01-20 Thread Baruch Siach
Hi Sterling, On Mon, Jan 20, 2014 at 09:53:36PM -0800, Sterling Augustine wrote: > On Mon, Jan 20, 2014 at 9:46 PM, Baruch Siach wrote: > > According to > > https://www.gnu.org/prep/maintain/html_node/Legally-Significant.html, only > > "legally significant" contributions of more than 15 lines of

Re: [PATCH][RFC] Fix PR59860

2014-01-20 Thread Jakub Jelinek
On Mon, Jan 20, 2014 at 11:54:15AM +0100, Richard Biener wrote: > Ok, the following simpler patch also fixes the issue and causes > no testsuite fallout - we restrict the folding in builtins.c to > the case with known src strlen. I've noticed this caused FAIL of strlenopt-4.c which had special reg

  1   2   >