Re: libsanitizer merge from upstream r196090

2013-12-03 Thread Jakub Jelinek
On Tue, Dec 03, 2013 at 07:18:14PM +0400, Konstantin Serebryany wrote: > > ==2738==AddressSanitizer CHECK failed: > > ../../../../libsanitizer/sanitizer_common/sanitizer_linux_libcdep.cc:260 > > "((*tls_addr + *tls_size)) <= ((*stk_addr + *stk_size))" (0x2af8df1bc240, > > 0x2af8df1bc000) > > whic

Re: [PING] [PATCH] Optional alternative base_expr in finding basis for CAND_REFs

2013-12-03 Thread Yufeng Zhang
On 12/03/13 20:35, Richard Biener wrote: Yufeng Zhang wrote: On 12/03/13 14:20, Richard Biener wrote: On Tue, Dec 3, 2013 at 1:50 PM, Yufeng Zhang wrote: On 12/03/13 06:48, Jeff Law wrote: On 12/02/13 08:47, Yufeng Zhang wrote: Ping~ http://gcc.gnu.org/ml/gcc-patches/2013-11/msg03360.ht

Re: [PING] [PATCH] Optional alternative base_expr in finding basis for CAND_REFs

2013-12-03 Thread Bill Schmidt
On Tue, 2013-12-03 at 21:35 +0100, Richard Biener wrote: > Yufeng Zhang wrote: > >On 12/03/13 14:20, Richard Biener wrote: > >> On Tue, Dec 3, 2013 at 1:50 PM, Yufeng Zhang > >wrote: > >>> On 12/03/13 06:48, Jeff Law wrote: > > On 12/02/13 08:47, Yufeng Zhang wrote: > > > > Ping

Re: [PATCH] Add signed integer overflow checking to ubsan

2013-12-03 Thread Jakub Jelinek
On Tue, Dec 03, 2013 at 02:14:17PM -0700, Jeff Law wrote: > >--- gcc/ubsan.h.mp 2013-11-27 08:46:28.046629473 +0100 > >+++ gcc/ubsan.h 2013-11-27 08:46:57.578753342 +0100 > >@@ -21,6 +21,12 @@ along with GCC; see the file COPYING3. > > #ifndef GCC_UBSAN_H > > #define GCC_UBSAN_H > > > >+/*

Re: _Cilk_spawn and _Cilk_sync for C++

2013-12-03 Thread Jason Merrill
On 12/03/2013 10:22 AM, Iyer, Balaji V wrote: Please remove these langhooks and instead add handling of CILK_SPAWN_STMT to c_gimplify_expr and cp_gimplify_expr. I really cannot do this because if the spawned function returns a value, the whole expression must be pushed into the spawn

Re: [PING] [PATCH] Optional alternative base_expr in finding basis for CAND_REFs

2013-12-03 Thread Bill Schmidt
On Tue, 2013-12-03 at 21:57 +, Yufeng Zhang wrote: > On 12/03/13 20:35, Richard Biener wrote: > > Yufeng Zhang wrote: > >> On 12/03/13 14:20, Richard Biener wrote: > >>> On Tue, Dec 3, 2013 at 1:50 PM, Yufeng Zhang > >> wrote: > On 12/03/13 06:48, Jeff Law wrote: > > > > On 12/02/

[PATCH] Enhancing the widen-mult pattern in vectorization.

2013-12-03 Thread Cong Hou
Hi The current widen-mult pattern only considers two operands with the same size. However, operands with different sizes can also benefit from this pattern. The following loop shows such an example: char a[N]; short b[N]; int c[N]; for (int i = 0; i < N; ++i) c[i] = a[i] * b[i]; In this cas

[PATCH] Don't ICE with -fno-devirtualize (PR tree-optimization/59355)

2013-12-03 Thread Jakub Jelinek
Hi! ipa_devirt apparently relies on -fdevirtualize, but -fno-devirtualize doesn't turn off -fdevirtualize-speculatively. I've tried to make it a 3 state option, but then while -O2 implied flag_devirtualize == 2 (i.e. normal + speculative), -O2 -fdevirtualize would imply flag_devirtualize == 1, wh

[C++ PATCH] Don't ICE on POINTER_PLUS_EXPR during tsubst* (PR c++/59268)

2013-12-03 Thread Jakub Jelinek
Hi! The following testcase ICEs because dfs_accumulate_vtbl_inits creates a POINTER_PLUS_EXPR (not type dependent) which is then fed through tsubst_copy_and_build during instantiation. The following patch teaches tsubst_copy_and_build to handle it. Bootstrapped/regtested on x86_64-linux and i686

[PATCH] Fix force_to_mode not to modify in place the passed rtl (PR rtl-optimization/58726)

2013-12-03 Thread Jakub Jelinek
Hi! As described in the PR, the problem here is that during combine i2 pattern is substituted into more than one place in i3 pattern, unique_copy is 0 (but, even if it would be non-zero, it could happen if the comparison was processed first before the normal set inside of the parallel) and thus th

Re: Fix a bug in points-to solver

2013-12-03 Thread Xinliang David Li
Done. Retested with the suggested change. Ok for trunk? thanks, David On Tue, Dec 3, 2013 at 2:13 AM, Richard Biener wrote: > On Mon, Dec 2, 2013 at 6:38 PM, Xinliang David Li wrote: >> Points to solver has a bug that can cause complex constraints to be >> skipped leading to wrong points-to r

Re: [wide-int] Add fast path for hosts with HWI widening multiplication

2013-12-03 Thread Richard Sandiford
Paolo Bonzini writes: > Il 02/12/2013 20:34, Richard Sandiford ha scritto: >> I followed Joseph's suggestion and reused longlong.h. I copied it from >> libgcc rather than glibc since it seemed better for GCC to have a single >> version across both gcc/ and libgcc/. I can put it in

Re: [wwwdocs] Update obvious fix commit policy

2013-12-03 Thread Gerald Pfeifer
On Thu, 28 Nov 2013, Richard Biener wrote: > Why remove ChangeLog files, web pages and comments? I was going to complain about web pages being removed. :-) On Thu, 28 Nov 2013, Diego Novillo wrote: > -Fixes for obvious typos in ChangeLog files, docs, web pages, comments > -and similar stuff. Ju

Re: Add TREE_INT_CST_OFFSET_NUNITS

2013-12-03 Thread Richard Sandiford
Richard Biener writes: >>> Looking at the implementation it seems it would also work with >>> >>>return MIN (TREE_INT_CST_EXT_NUNITS (m_t), N / HOST_BITS_PER_WIDE_INT); >> >> Yeah, the MIN in the patch was probably bogus sorry. It only works >> if we can assume that no bitsizetype will have A

Re: [wide-int] Add fast path for hosts with HWI widening multiplication

2013-12-03 Thread Ian Lance Taylor
On Tue, Dec 3, 2013 at 3:55 PM, Richard Sandiford wrote: > > OK, how about this, against trunk? Tested on x86_64-linux-gnu. > > Thanks, > Richard > > > include/ > * longlong.h: New file. > > libgcc/ > * longlong.h: Delete (moved to include/). > > libquadmath/ > * Makefile.

Re: [PowerPC] libffi fixes and support for PowerPC64 ELFv2

2013-12-03 Thread Alan Modra
On Tue, Dec 03, 2013 at 09:05:53AM -0500, David Edelsohn wrote: > On Thu, Nov 21, 2013 at 9:57 PM, Alan Modra wrote: > > David, > > Here comes the inevitable followup.. I broke backwards compatibility > > when adding an extra field to ffi_cif. I'd like to import again from > > upstream, where I'

Two build != host fixes

2013-12-03 Thread Alan Modra
When build != host, the build compiler obviously isn't the same as the host compiler, but BUILD_CXXFLAGS is currently ALL_CXXFLAGS. ALL_CXXFLAGS contains flags for which we run configure tests on the host compiler, which may not work on the build compiler. I ran into this with -Wno-narrowing. It

libgo patch committed: Use pthread_sigmask, not sigprocmask

2013-12-03 Thread Ian Lance Taylor
A threaded program is supposed to call pthread_sigmask rather than sigprocmask. The functions do the same thing, and there is no difference on GNU/Linux, but pthread_sigmask is preferred. This patch to libgo changes it to do that. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. C

Re: [PowerPC] libffi fixes and support for PowerPC64 ELFv2

2013-12-03 Thread David Edelsohn
> I haven't tested on AIX or Darwin, sorry If you find any problems on > AIX, please let me know and I'll fix them. I have tested on > powerpc-linux, powerpc64-linux, powerpc64le-linux and powerpc-freebsd, > which are the targets most affected by this change. I have also > bootstrapped and regre

Re: [PATCH, testsuite] Fix some testcases for nds32 target and provide new nds32 target specific tests

2013-12-03 Thread Chung-Ju Wu
2013/12/3 Mike Stump : > On Dec 2, 2013, at 5:02 AM, Chung-Ju Wu wrote: >> Perhaps I should have used the following description, which seems much >> better: >> >> +/* { dg-skip-if "Variadic funcs have all args on stack. Normal funcs have >> args in registers." { nds32*-*-* } "*" "" } */ > > Read

Re: [PATCH] Don't ICE with -fno-devirtualize (PR tree-optimization/59355)

2013-12-03 Thread Jeff Law
On 12/03/13 15:36, Jakub Jelinek wrote: Hi! ipa_devirt apparently relies on -fdevirtualize, but -fno-devirtualize doesn't turn off -fdevirtualize-speculatively. I've tried to make it a 3 state option, but then while -O2 implied flag_devirtualize == 2 (i.e. normal + speculative), -O2 -fdevirtual

Re: [PATCH] Add signed integer overflow checking to ubsan

2013-12-03 Thread Jeff Law
On 12/03/13 15:05, Jakub Jelinek wrote: On Tue, Dec 03, 2013 at 02:14:17PM -0700, Jeff Law wrote: --- gcc/ubsan.h.mp 2013-11-27 08:46:28.046629473 +0100 +++ gcc/ubsan.h 2013-11-27 08:46:57.578753342 +0100 @@ -21,6 +21,12 @@ along with GCC; see the file COPYING3. #ifndef GCC_UBSAN_H #def

Re: [PATCH] Fix force_to_mode not to modify in place the passed rtl (PR rtl-optimization/58726)

2013-12-03 Thread Jeff Law
On 12/03/13 15:46, Jakub Jelinek wrote: Hi! As described in the PR, the problem here is that during combine i2 pattern is substituted into more than one place in i3 pattern, unique_copy is 0 (but, even if it would be non-zero, it could happen if the comparison was processed first before the norm

Re: Two build != host fixes

2013-12-03 Thread DJ Delorie
Alan Modra writes: > Bootstrapped etc. powerpc64-linux. OK mainline and 4.8 branch? > > * configure.ac (BUILD_CXXFLAGS) Don't use ALL_CXXFLAGS for > build != host. > : Clear GMPINC. Don't bother > saving CFLAGS. > * configure: Regenerate. Ok for mainline, up to the

Re: libsanitizer merge from upstream r196090

2013-12-03 Thread Konstantin Serebryany
>>> >>> This won't happen any time soon, right? >>> I'd like to ask glibc for many other things, not just this, but the >>> latency >>> of the glibc changes propagating to users is too low, so we don't >>> bother (although we should) >>> E.g. we've been hit by the ugly >>> pthread_getattr_np/pthrea

Re: libsanitizer merge from upstream r196090

2013-12-03 Thread Konstantin Serebryany
On Tue, Dec 3, 2013 at 5:42 PM, Jeff Law wrote: > On 12/03/13 08:47, Jakub Jelinek wrote: >> >> On Tue, Dec 03, 2013 at 07:18:14PM +0400, Konstantin Serebryany wrote: >> >> No, so your patch doesn't regress anything. I can configure with >> --disable-libsanitizer to skip build of libsa

Re: libsanitizer merge from upstream r196090

2013-12-03 Thread Konstantin Serebryany
On Mon, Dec 2, 2013 at 11:32 PM, Jakub Jelinek wrote: > On Mon, Dec 02, 2013 at 05:59:53PM +0100, Konstantin Serebryany wrote: >> >> with #if LINUX_VERSION_CODE >= 132640 >> Good idea, let me try that. > > Had a quick look at this on RHEL 5. > Following patch let me compile at least the first sour

Re: [PE-POST] Adjust Bit-region in expand_assignment

2013-12-03 Thread Jeff Law
On 12/03/13 06:27, Bernd Edlinger wrote: This comment is completely out of sync: There is no longer any force_reg in that if-block, and a constant address in TO_RTX has SImode or DImode in GET_MODE (XEXP (to_rtx, 0)) I do not know how to make it a VOIDmode, therefore the comment does not help

Re: Two build != host fixes

2013-12-03 Thread Alan Modra
On Tue, Dec 03, 2013 at 11:44:46PM -0500, DJ Delorie wrote: > Alan Modra writes: > > Bootstrapped etc. powerpc64-linux. OK mainline and 4.8 branch? > > > > * configure.ac (BUILD_CXXFLAGS) Don't use ALL_CXXFLAGS for > > build != host. > > : Clear GMPINC. Don't bother > > saving CF

Re: *ping* Re: PR37132 – RFC patch for generation of DWARF symbol for Fortran's namelists (DW_TAG_namelist)

2013-12-03 Thread Tobias Burnus
On November 28, 2013, Tobias Burnus wrote: A slightly early *ping* Tobias Burnus wrote: attached is an updated version of the patch. Change: Tobias Burnus wrote: But for "USE mod_name, only: nml", one is supposed to generate a DW_TAG_imported_declaration. And there I am stuck. For normal va

[PATCH] Fix --with-long-double-128 for sparc32 when defaulting to 64-bit

2013-12-03 Thread Aurelien Jarno
On sparc, the --with-long-double-128 option doesn't change anything for a 64-bit compiler, as it always default to 128-bit long doubles. For a 32/64-bit compiler defaulting to 32-bit this correctly control the size of long double of the 32-bit compiler, however for a 32/64-bit compiler defaulting t

RE: [PE-POST] Adjust Bit-region in expand_assignment

2013-12-03 Thread Bernd Edlinger
On Tue, 3 Dec 2013 22:55:32, Jef Law wrote: > > On 12/03/13 06:27, Bernd Edlinger wrote: >>> This comment is completely out of sync: There is no longer any force_reg in >>> that if-block, >>> and a constant address in TO_RTX has SImode or DImode in GET_MODE (XEXP >>> (to_rtx, 0)) >>> I do not kno

Re: [PATCH] Fix --with-long-double-128 for sparc32 when defaulting to 64-bit

2013-12-03 Thread Jakub Jelinek
On Wed, Dec 04, 2013 at 08:49:32AM +0100, Aurelien Jarno wrote: > On sparc, the --with-long-double-128 option doesn't change anything for > a 64-bit compiler, as it always default to 128-bit long doubles. For > a 32/64-bit compiler defaulting to 32-bit this correctly control the > size of long doub

<    1   2