Re: [RFC] Masked load/store vectorization (take 5)

2013-11-14 Thread Jakub Jelinek
On Wed, Nov 13, 2013 at 01:21:03PM +0100, Jakub Jelinek wrote: > Sergey has kindly tested the patch on SPEC2k6, but on 4 tests it revealed > an ICE. Here is an incremental fix for that, for now it just punts on > those. In theory the invariant conditional loads could be handled e.g. > using gathe

Re: [patch] Fix ICEs when DEBUG_MANGLE is enabled

2013-11-14 Thread Dodji Seketeli
I guess we should CC Jason for this ... ccout...@google.com (Cary Coutant) a écrit: This patch fixes a few ICEs I encountered when enabling DEBUG_MANGLE. I've also changed dump_substitution_candidates to output the substitution index in base 36, to match the actual mangled name. OK for trunk? -

Re: [patch] Fix ICEs when DEBUG_MANGLE is enabled

2013-11-14 Thread Jakub Jelinek
On Thu, Nov 14, 2013 at 09:03:02AM +0100, Dodji Seketeli wrote: > I guess we should CC Jason for this ... > > ccout...@google.com (Cary Coutant) a écrit: > > This patch fixes a few ICEs I encountered when enabling DEBUG_MANGLE. > I've also changed dump_substitution_candidates to output the substi

Re: [PATCH] Fix *anddi_2 (PR target/59101)

2013-11-14 Thread Jakub Jelinek
On Wed, Nov 13, 2013 at 08:12:41PM +0100, Uros Bizjak wrote: > Patch is OK everywhere, with or without the suggested change. Ok, here is what I've committed, so far to trunk/4.8, after another round of bootstrap/regtest: 2013-11-14 Jakub Jelinek Uros Bizjak PR target/591

RE: [patch] [arm] New option for PIC offset unfixed

2013-11-14 Thread Joey Ye
> -Original Message- > From: Richard Earnshaw > Sent: Thursday, November 14, 2013 0:57 > To: Joey Ye > Cc: gcc-patches@gcc.gnu.org > Subject: Re: [patch] [arm] New option for PIC offset unfixed > > > So you are suggesting change like this: > > + Target Report Var(arm_pic_data_is_text_relat

Re: [PATCH, PR 10474] Take two on splitting live-ranges of function arguments to help shrink-wrapping

2013-11-14 Thread Jakub Jelinek
On Wed, Nov 06, 2013 at 05:26:08PM +0100, Martin Jambor wrote: > So, Vlad, Steven, do you think that this time I have re-computed all > that is necessary? Do you think the patch is OK? > > Thanks a lot and sorry for the breakage, I'm afraid there are still issues left. Last night I was bootstrap

Re: [PATCH] PR ada/54040: [x32] Incorrect timeval and timespec

2013-11-14 Thread Arnaud Charlet
> FAIL: gnat.dg/memtrap.adb (test for excess errors) > FAIL: gnat.dg/memtrap.adb scan-assembler > __gnat_begin_handler|__gnat_raise_nodefer > FAIL: gnat.dg/specs/addr1.ads (test for bogus messages, line 24) > FAIL: gnat.dg/specs/atomic1.ads (test for errors, line 9) > FAIL: gnat.dg/specs/atomic1.

Re: [gomp4 simd, RFC] Simple fix to override vectorization cost estimation.

2013-11-14 Thread Richard Biener
On Wed, 13 Nov 2013, Sergey Ostanevich wrote: > I will get some tests. > As for cost analysis - simply consider the pragma as a request to > vectorize. How can I - as a developer - enforce it beyond the pragma? You can disable the cost model via -fvect-cost-model=unlimited Richard. > On Wed, No

Re: [PATCH][AArch64] Use common rtx cost table structures with arm

2013-11-14 Thread Marcus Shawcroft
On 13 November 2013 11:16, Kyrill Tkachov wrote: > 2013-11-13 Kyrylo Tkachov > > * config/aarch64/aarch64.c: Include aarch-cost-tables.h. > (generic_rtx_cost_table): Remove. > (aarch64_rtx_costs): Use fields from cpu_cost_table. > * config/aarch64/aarch64-protos.h (tune_params)

Re: [AArch64] [0/5 -mtune cleanup] Update options for -mtune.

2013-11-14 Thread Marcus Shawcroft
On 13/11/13 15:32, James Greenhalgh wrote: Hi, This patch series performs a number of cleanups to the -mtune/-mcpu/-march infrastructure for AArch64. Our goals are: * Remove the example pipeline models. * Tune for Cortex-A53 by default. * Provide sensible tuning for Cortex-A57. The

Re: [PATCH] Isolate erroneous paths optimization -- preserve *0.

2013-11-14 Thread H.J. Lu
On Tue, Nov 12, 2013 at 8:42 AM, Jeff Law wrote: > On 11/10/13 20:11, Jeff Law wrote: >> >> OK. It sounds like there's a pretty general consensus that we ought ot >> go ahead and leave in a load/store of a NULL pointer. I'll go ahead and >> run with that. I'll probably just emit SSA_NAME = *0,

Re: [PATCH] PR ada/54040: [x32] Incorrect timeval and timespec

2013-11-14 Thread H.J. Lu
On Thu, Nov 14, 2013 at 12:38 AM, Arnaud Charlet wrote: >> FAIL: gnat.dg/memtrap.adb (test for excess errors) >> FAIL: gnat.dg/memtrap.adb scan-assembler >> __gnat_begin_handler|__gnat_raise_nodefer >> FAIL: gnat.dg/specs/addr1.ads (test for bogus messages, line 24) >> FAIL: gnat.dg/specs/atomic1

Re: Ping Re: [gomp4] Dumping gimple for offload.

2013-11-14 Thread Ilya Tocar
On 18 Oct 13:30, Richard Biener wrote: > Certainly better than the first version. Jakub should decide for the branch > and eventually Honza for the merge to trunk. It still looks somewhat hackish, > but I suppose that's because we don't have a LTO-state object where we > can encapsulate all this.

Re: [patch] [arm] New option for PIC offset unfixed

2013-11-14 Thread Richard Earnshaw
On 14/11/13 08:23, Joey Ye wrote: >> -Original Message- >> From: Richard Earnshaw >> Sent: Thursday, November 14, 2013 0:57 >> To: Joey Ye >> Cc: gcc-patches@gcc.gnu.org >> Subject: Re: [patch] [arm] New option for PIC offset unfixed >> >>> So you are suggesting change like this: >>> + Targ

Re: [PATCH, PR 10474] Take two on splitting live-ranges of function arguments to help shrink-wrapping

2013-11-14 Thread Martin Jambor
Hi, On Thu, Nov 14, 2013 at 09:24:54AM +0100, Jakub Jelinek wrote: > On Wed, Nov 06, 2013 at 05:26:08PM +0100, Martin Jambor wrote: > > So, Vlad, Steven, do you think that this time I have re-computed all > > that is necessary? Do you think the patch is OK? > > > > Thanks a lot and sorry for the

Re: [PATCH] PR ada/54040: [x32] Incorrect timeval and timespec

2013-11-14 Thread Arnaud Charlet
> > No, introducing all these extra/almost duplicated files is not OK, you'd > > need to find a way to share the existing files instead, thanks. > > I am not familiar with Ada. Can you recommend how to fix it? Can you send a diff between the *-linux files and your new files? This should help giv

Re: patch to implement thread coloring in IRA

2013-11-14 Thread Ulrich Weigand
Vladimir Makarov wrote: > On 11/13/2013, 8:34 PM, Ulrich Weigand wrote: > >> Unfortunately, this patch causes cc1 for powerpc64-linux to crash for me > >> even when compiling "int main () { return 0; }" with -O due to a memory > >> corruption somewhere: > > > I've just fixed it, Ulrich. Really sor

Re: [PATCH][PR middle-end/59119] Avoid referencing released SSA_NAMEs

2013-11-14 Thread Ulrich Weigand
Jeff Law wrote: > * PR middle-end/59119 > * gimple-ssa-isolate-paths.c (find_implicit_erroneous_behaviour): New > function, extracted from gimple_ssa_isolate_erroneous_paths. > (find_explicit_erroneous_behaviour): Similarly. > (insert_trap_and_remove_trailing_statemen

Re: [PATCH] Fix infinite recursion between store_fixed_bit_field/store_split_bit_field with STRICT_ALIGNMENT

2013-11-14 Thread Richard Biener
On Wed, Nov 13, 2013 at 4:21 PM, Julian Brown wrote: > Hi, > > This patch addresses an issue where the compiler gets stuck in an > infinite mutually-recursive loop between store_fixed_bit_field and > store_split_bit_field. This affects versions back at least as far as > 4.6 (or so). We observed th

Re: [PATCH] PR ada/54040: [x32] Incorrect timeval and timespec

2013-11-14 Thread H.J. Lu
On Thu, Nov 14, 2013 at 2:02 AM, Arnaud Charlet wrote: >> > No, introducing all these extra/almost duplicated files is not OK, you'd >> > need to find a way to share the existing files instead, thanks. >> >> I am not familiar with Ada. Can you recommend how to fix it? > > Can you send a diff betw

Re: [PATCH] Fix failing assertion in calls.c:store_unaligned_arguments_into_pseudos

2013-11-14 Thread Ulrich Weigand
Jeff Law wrote: > On 11/11/13 07:32, Ulrich Weigand wrote: > > 2013-11-11 Ulrich Weigand > > > > * calls.c (store_unaligned_arguments_into_pseudos): Skip PARALLEL > > arguments. > OK, so after a lot of worrying, I think this is OK. I kept thinking > this had to tie into the BLKmode ret

RE: [PATCH] reimplement -fstrict-volatile-bitfields v4, part 1/2

2013-11-14 Thread Bernd Edlinger
Hi, sorry, for the delay. Sandra seems to be even more busy than me... Attached is a combined patch of the original part 1, and the update, in diff -up format. On Mon, 11 Nov 2013 13:10:45, Richard Biener wrote: > > On Thu, Oct 31, 2013 at 1:46 AM, Sandra Loosemore > wrote: >> On 10/29/2013 02:

RE: [patch] [arm] New option for PIC offset unfixed

2013-11-14 Thread Joey Ye
> -Original Message- > From: Richard Earnshaw > Sent: Thursday, November 14, 2013 18:00 > To: Joey Ye > Cc: gcc-patches@gcc.gnu.org > Subject: Re: [patch] [arm] New option for PIC offset unfixed > > On 14/11/13 08:23, Joey Ye wrote: > >> -Original Message- > >> From: Richard Earnsh

RE: [patch] [arm] ARM Cortex-M3/M4 tuning

2013-11-14 Thread Joey Ye
In mainline and arm/embedded-4_8-branch now. > -Original Message- > From: Janis Johnson [mailto:janis_john...@mentor.com] > Sent: Thursday, November 14, 2013 1:45 > To: Joey Ye; jani...@codesourcery.com > Cc: gcc-patches@gcc.gnu.org; Ramana Radhakrishnan > Subject: Re: [patch] [arm] ARM Co

[PATCH GCC]Slightly tune to make iv cand choosing algorithm more accurate

2013-11-14 Thread bin.cheng
Hi, The algorithm choosing candidates in IVOPT has some defects that optimal iv set can't be found in some cases. This patch slightly tunes the algorithm to make it more accurate. The reasons are: 1) Changes in iv_ca_extend. Dependences could be changed in the loop, causing check condition " !i

Re: Ping Re: [gomp4] Dumping gimple for offload.

2013-11-14 Thread Richard Biener
On Thu, Nov 14, 2013 at 10:52 AM, Ilya Tocar wrote: > On 18 Oct 13:30, Richard Biener wrote: >> Certainly better than the first version. Jakub should decide for the branch >> and eventually Honza for the merge to trunk. It still looks somewhat >> hackish, >> but I suppose that's because we don'

Re: [PATCH] PR ada/54040: [x32] Incorrect timeval and timespec

2013-11-14 Thread Arnaud Charlet
> >> I am not familiar with Ada. Can you recommend how to fix it? > > > > Can you send a diff between the *-linux files and your new files? This > > should help giving some options. > > > > This is the total diff. OK so I would declare a new type in System.Linux (e.g. time_t), have a new varian

Re: [PATCH][1-3] New configure option to enable Position independent executable as default.

2013-11-14 Thread Marek Polacek
On Wed, Nov 13, 2013 at 08:24:34PM -0800, Ian Lance Taylor wrote: > I don't think we should make -fPIE the default for all users. Yeah, definitely not. Marek

[RFC PATCH] add auto_bitmap

2013-11-14 Thread tsaunders
From: Trevor Saunders Hi, this patch adds and starts to use a class auto_bitmap, which is a very thin wrapper around bitmap. Its advantage is that it takes care of delocation automatically. So you can do things like int f () { auto_bitmap x; // do stuff with x } Another advantage of this

Re: XFAIL a couple of gnat.dg testcases on MIPS

2013-11-14 Thread Eric Botcazou
> Here is a patch. OK to install? Yes, thanks. -- Eric Botcazou

[patch] Fix stack allocation oddity

2013-11-14 Thread Eric Botcazou
Hi, we have a test in the gnat.dg testsuite (stack_usage1.adb) which checks that the allocation of big temporaries created in non-overlapping blocks on the stack is optimal, i.e. that they share a stack slot. It is run at -O0 and passes. If you run it at -O2, it also passes. Now, if you run

Re: [PATCH] Fix infinite recursion between store_fixed_bit_field/store_split_bit_field with STRICT_ALIGNMENT

2013-11-14 Thread Julian Brown
On Thu, 14 Nov 2013 11:09:22 +0100 Richard Biener wrote: > On Wed, Nov 13, 2013 at 4:21 PM, Julian Brown > wrote: > > Hi, > > > > This patch addresses an issue where the compiler gets stuck in an > > infinite mutually-recursive loop between store_fixed_bit_field and > > store_split_bit_field. Th

Re: [PATCH, PR 10474] Take two on splitting live-ranges of function arguments to help shrink-wrapping

2013-11-14 Thread Matthew Leach
Martin Jambor writes: > Hi, Hi Martin, [...] > > 2013-11-04 Martin Jambor > > PR rtl-optimization/10474 > * ira.c (interesting_dest_for_shprep): New function. > (split_live_ranges_for_shrink_wrap): Likewise. > (find_moveable_pseudos): Move calculation of domi

Re: [patch] [arm] ARM Cortex-M3/M4 tuning

2013-11-14 Thread H.J. Lu
On Thu, Nov 14, 2013 at 2:24 AM, Joey Ye wrote: > In mainline and arm/embedded-4_8-branch now. > >> -Original Message- >> From: Janis Johnson [mailto:janis_john...@mentor.com] >> Sent: Thursday, November 14, 2013 1:45 >> To: Joey Ye; jani...@codesourcery.com >> Cc: gcc-patches@gcc.gnu.org;

[PATCH, testsuite] Fix some testcases for nds32 target and provide new nds32 target specific tests

2013-11-14 Thread Chung-Ju Wu
Hi, Mike, Recently the new nds32 port is approved and I committed it into trunk. According to gcc testsuite report on: http://gcc.gnu.org/ml/gcc-testresults/2013-11/msg00751.html http://gcc.gnu.org/ml/gcc-testresults/2013-11/msg00752.html I would like to modify some testcases for nds32 target

[v3 patch] remove PR55043 kluge from unordered containers

2013-11-14 Thread Jonathan Wakely
Because the unordered containers now have noexcept move constructors it is no longer necessary to ensure that is_copy_constructible depends on the value_type, so remove that kluge. 2013-11-14 Jonathan Wakely * include/bits/alloc_traits.h (__allow_copy_cons): Remove. (__check_copy

Re: [PATCH] PR ada/54040: [x32] Incorrect timeval and timespec

2013-11-14 Thread H.J. Lu
On Thu, Nov 14, 2013 at 2:30 AM, Arnaud Charlet wrote: >> >> I am not familiar with Ada. Can you recommend how to fix it? >> > >> > Can you send a diff between the *-linux files and your new files? This >> > should help giving some options. >> > >> >> This is the total diff. > > OK so I would dec

[testsuite] Require fenv_exceptions in gcc.dg/torture/float128* tests

2013-11-14 Thread Rainer Orth
The new gcc.dg/torture/float128* tests FAIL on Solaris 9/x86 which lacks . Fixed by the patch below, tested with the appropriate runtest invocations on i386-pc-solaris2.9 and i386-pc-solaris2.11. Ok for mainline? Btw., the new fenv_exceptions effective-target keywords needs documenting in source

[C++ Patch/RFC PR c++/57887 (and dups)

2013-11-14 Thread Paolo Carlini
Hi, we are getting bug reports about this issue with NSDMIs in template classes, like: struct B { template struct A { int X = N; }; }; 57887.C:6:13: error: ‘N’ was not declared in this scope Looking at cp_parser_class_specifier_1, the comments about the late parsing of default arguments (wh

Re: [patch] Fix stack allocation oddity

2013-11-14 Thread Richard Biener
On Thu, Nov 14, 2013 at 12:52 PM, Eric Botcazou wrote: > Hi, > > we have a test in the gnat.dg testsuite (stack_usage1.adb) which checks that > the allocation of big temporaries created in non-overlapping blocks on the > stack is optimal, i.e. that they share a stack slot. It is run at -O0 and >

Re: [PATCH] Add gimple subclasses for every gimple code (was Re: [PATCH 0/6] Conversion of gimple types to C++ inheritance (v3))

2013-11-14 Thread Michael Matz
Hi, On Thu, 14 Nov 2013, Jeff Law wrote: > Thanks. It's pretty much what I expected. Obviously for other codes > there may be a lot more changes that you have to slog through, but I > think this example shows the main concepts. > > Presumably in this new world order, the various gimple state

Re: [PATCH] Fix infinite recursion between store_fixed_bit_field/store_split_bit_field with STRICT_ALIGNMENT

2013-11-14 Thread Richard Biener
On Thu, Nov 14, 2013 at 1:08 PM, Julian Brown wrote: > On Thu, 14 Nov 2013 11:09:22 +0100 > Richard Biener wrote: > >> On Wed, Nov 13, 2013 at 4:21 PM, Julian Brown >> wrote: >> > Hi, >> > >> > This patch addresses an issue where the compiler gets stuck in an >> > infinite mutually-recursive loo

Re: [PATCH] preprocessor/58580 - preprocessor goes OOM with warning for zero literals

2013-11-14 Thread Dodji Seketeli
Jakub Jelinek writes: > On Tue, Nov 12, 2013 at 04:33:41PM +0100, Dodji Seketeli wrote: >> + >> + memmove (*line, l, len); >> + (*line)[len - 1] = '\0'; >> + *line_len = --len; > > Shouldn't this be testing that len > 0 && (*line)[len - 1] == '\n' > first before you decide to overw

[libcilkrts, build] Only use visibility if supported

2013-11-14 Thread Rainer Orth
libcilkrts.so fails to link on Solaris 9/x86 with Sun as since this configuration lacks visibility support: Text relocation remains referenced against symbol offset in file __cilkrts_get_tls_worker0x41.libs/cilk-abi.o __cilkrts_

Re: [PATCH, rs6000] ELFv2 ABI 1/8: Add options and infrastructure

2013-11-14 Thread Joseph S. Myers
On Thu, 14 Nov 2013, Alan Modra wrote: > On Tue, Nov 12, 2013 at 10:33:46PM +, Joseph S. Myers wrote: > > On Tue, 12 Nov 2013, Ulrich Weigand wrote: > > > Well, we had been thinking about this, but right now it seems we're not > > > going to be able to make that change throughout the ecosystem

Re: [patch] [arm] ARM Cortex-M3/M4 tuning

2013-11-14 Thread Richard Biener
On Thu, Nov 14, 2013 at 1:35 PM, H.J. Lu wrote: > On Thu, Nov 14, 2013 at 2:24 AM, Joey Ye wrote: >> In mainline and arm/embedded-4_8-branch now. >> >>> -Original Message- >>> From: Janis Johnson [mailto:janis_john...@mentor.com] >>> Sent: Thursday, November 14, 2013 1:45 >>> To: Joey Ye;

Re: [PATCH] PR ada/54040: [x32] Incorrect timeval and timespec

2013-11-14 Thread Arnaud Charlet
> I also changed s-osinte-posix.adb and s-osprim-posix.adb > for x32. They aren't Linux specific. What should I do with > them? I would use the time_t type defined in s-osinte* (all POSIX implementations of s-osinte* have such definition, or if they don't, it's easy to add), and in the s-osinte-

Re: [testsuite] Require fenv_exceptions in gcc.dg/torture/float128* tests

2013-11-14 Thread Joseph S. Myers
On Thu, 14 Nov 2013, Rainer Orth wrote: > The new gcc.dg/torture/float128* tests FAIL on Solaris 9/x86 which lacks > . Fixed by the patch below, tested with the appropriate runtest > invocations on i386-pc-solaris2.9 and i386-pc-solaris2.11. > > Ok for mainline? fenv_exceptions isn't correct fo

[PATCH]: backport fix for PR sanitizer/58994

2013-11-14 Thread Jack Howarth
The attached patch backports http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-2013/194748.html to gcc trunk and eliminates the asan.exp failures at -m64 on darwin. Bootstrap and regression tested on x86_64-apple-darwin12 and x86_64-apple-darwin13. Jack p

Re: [testsuite] Require fenv_exceptions in gcc.dg/torture/float128* tests

2013-11-14 Thread Rainer Orth
"Joseph S. Myers" writes: >> Btw., the new fenv_exceptions effective-target keywords needs >> documenting in sourcebuild.texi. > > Duplicating documentation for effective-target keywords in > sourcebuild.texi seems to me to be a mistake like the documentation for > specs in invoke.texi - in bot

Re: Revert libsanitizer patches or fix 59009

2013-11-14 Thread Peter Bergner
On Wed, 2013-11-13 at 16:42 -0600, Peter Bergner wrote: > On Wed, 2013-11-13 at 18:29 +0100, Jakub Jelinek wrote: > > On Wed, Nov 13, 2013 at 11:25:06AM -0600, Peter Bergner wrote: > > > > * sanitizer_common/sanitizer_platform_limits_linux.cc: > > > > Temporarily > > > > ifdef out

Re: [C++ Patch/RFC PR c++/57887 (and dups)

2013-11-14 Thread Jason Merrill
On 11/14/2013 07:59 AM, Paolo Carlini wrote: /* Make sure that any template parameters are in scope. */ maybe_begin_member_template_processing (decl); Hmm, it seems that we use this for non-template member functions of template classes as well; I wonder when that happened. I guess we should

Re: [c++] Fix pr58525

2013-11-14 Thread Alexander Ivchenko
*kind ping* thanks, Alexander 2013/11/8 Alexander Ivchenko : > ups, I did ping in the wrong thread about this issue. Sorry. > > > Anyway, I noticed that after r204334 my patch cannot be applied > without conflicts. > Here is the updated one attached. Bootstrapped and regtested on > x86_64-unknown

Re: [PATCH] Fix infinite recursion between store_fixed_bit_field/store_split_bit_field with STRICT_ALIGNMENT

2013-11-14 Thread Julian Brown
On Thu, 14 Nov 2013 14:04:53 +0100 Richard Biener wrote: > On Thu, Nov 14, 2013 at 1:08 PM, Julian Brown > wrote: > > So that leaves us with store_fixed_bit_field and > > store_split_bit_field being unable to deal with accesses to packed > > structures with non-BLKmode. I experimented earlier wi

Re: [RFC PATCH] add auto_bitmap

2013-11-14 Thread Richard Biener
On Thu, Nov 14, 2013 at 12:04 PM, wrote: > From: Trevor Saunders > > Hi, > > this patch adds and starts to use a class auto_bitmap, which is a very thin > wrapper around bitmap. Its advantage is that it takes care of delocation > automatically. So you can do things like > > int > f () > { >

Re: [PATCH]: backport fix for PR sanitizer/58994

2013-11-14 Thread Kostya Serebryany
On Thu, Nov 14, 2013 at 6:24 PM, Jack Howarth wrote: >The attached patch backports > http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-2013/194748.html > to gcc trunk and eliminates the asan.exp failures at -m64 on darwin. > Bootstrap and regression tested on > x86_64-apple-dar

[patch 1/2] add gimplfy-be.[ch] for iterator-aware BE-only gimplification routines.

2013-11-14 Thread Andrew MacLeod
This patch splits out the force_gimple_operand parts of gimplify.[ch] into their own file which will prevent the front ends from having to see iterators, and breaks the annoying dependency cycle between gimple.h, gimplify.h and gimple-iterator.h. I suspect more stuff may end up here, but this

Re: [patch 2/2] add gimplfy-be.[ch] for iterator-aware BE-only gimplification routines. Include changes

2013-11-14 Thread Andrew MacLeod
patch2 contains the resulting include changes. the remaining changes... Andrew * asan.c: Include only gimplify.h, gimplify-be.h, and/or gimple.h as required. * cfgloopmanip.c: Likewise. * cgraphunit.c: Likewise. * cilk-common.c: Likewise. * fold-const.c: Likewise. * function.c: Likewis

[PATCH] LRA: check_rtl modifies RTL instruction stream

2013-11-14 Thread Robert Suchanek
Hi, This patch follows up the problem outlined here: http://gcc.gnu.org/ml/gcc/2013-11/msg00152.html The patch attached prevents adding clobbers when LRA is running in insn_invalid_p function and lra_in_progress variable is being set just before check_rtl call. This should stop modification of i

Re: [RFC] Masked load/store vectorization (take 5)

2013-11-14 Thread Richard Biener
On Thu, 14 Nov 2013, Jakub Jelinek wrote: > On Wed, Nov 13, 2013 at 01:21:03PM +0100, Jakub Jelinek wrote: > > Sergey has kindly tested the patch on SPEC2k6, but on 4 tests it revealed > > an ICE. Here is an incremental fix for that, for now it just punts on > > those. In theory the invariant co

Re: [patch 3/4] Separate gimple.[ch] and gimplify.[ch] - front end files

2013-11-14 Thread Michael Matz
Hi, On Wed, 13 Nov 2013, Andrew MacLeod wrote: > There needs to be a place which has gimple componentry that is not > related to or require a statement. gimple.h is becoming the home for > just 0gimple statements. There are 3 (for the moment) major classes of > things that are in statements

Re: [RFC PATCH] add auto_bitmap

2013-11-14 Thread Michael Matz
Hi, On Thu, 14 Nov 2013, Richard Biener wrote: > Why not give bitmap_head a constructor/destructor and allow auto use of > that. Isn't that exactly what should get 'auto' handling automagically? auto != c++98 :-/ Ciao, Michael.

Re: [PATCH] reimplement -fstrict-volatile-bitfields v4, part 1/2

2013-11-14 Thread Richard Biener
On Thu, Nov 14, 2013 at 11:16 AM, Bernd Edlinger wrote: > Hi, > > sorry, for the delay. > Sandra seems to be even more busy than me... > > Attached is a combined patch of the original part 1, and the update, > in diff -up format. > > On Mon, 11 Nov 2013 13:10:45, Richard Biener wrote: >> >> On Thu

Re: [patch 3/4] Separate gimple.[ch] and gimplify.[ch] - front end files

2013-11-14 Thread Diego Novillo
On Thu, Nov 14, 2013 at 10:26 AM, Michael Matz wrote: > Put another way: what do you envision that gimple expressions would be. > For example what would you propose we could do with them? The only expressions I have in mind are memory references and aggregates, which can get pretty convoluted.

Re: [patch 3/4] Separate gimple.[ch] and gimplify.[ch] - front end files

2013-11-14 Thread Andrew MacLeod
On 11/14/2013 10:26 AM, Michael Matz wrote: Hi, On Wed, 13 Nov 2013, Andrew MacLeod wrote: There needs to be a place which has gimple componentry that is not related to or require a statement. gimple.h is becoming the home for just 0gimple statements. There are 3 (for the moment) major class

Re: libsanitizer merge from upstream r191666

2013-11-14 Thread Jakub Jelinek
On Tue, Oct 29, 2013 at 07:05:49AM -0700, Konstantin Serebryany wrote: > The calls are emitted by default, but the __asan_stack_malloc call is > done under a run-time flag > __asan_option_detect_stack_use_after_return. > So, to use the stack-use-after-return feature you should simply > compile with

Re: [patch 3/4] Separate gimple.[ch] and gimplify.[ch] - front end files

2013-11-14 Thread Diego Novillo
On Thu, Nov 14, 2013 at 10:34 AM, Andrew MacLeod wrote: > On 11/14/2013 10:26 AM, Michael Matz wrote: >> >> Hi, >> >> On Wed, 13 Nov 2013, Andrew MacLeod wrote: >> >>> There needs to be a place which has gimple componentry that is not >>> related to or require a statement. gimple.h is becoming th

Re: [patch 1/2] add gimplfy-be.[ch] for iterator-aware BE-only gimplification routines.

2013-11-14 Thread Richard Biener
On Thu, Nov 14, 2013 at 4:10 PM, Andrew MacLeod wrote: > This patch splits out the force_gimple_operand parts of gimplify.[ch] into > their own file which will prevent the front ends from having to see > iterators, and breaks the annoying dependency cycle between gimple.h, > gimplify.h and gimple

Re: [patch 3/4] Separate gimple.[ch] and gimplify.[ch] - front end files

2013-11-14 Thread Andrew MacLeod
On 11/14/2013 10:37 AM, Diego Novillo wrote: On Thu, Nov 14, 2013 at 10:34 AM, Andrew MacLeod wrote: On 11/14/2013 10:26 AM, Michael Matz wrote: Hi, On Wed, 13 Nov 2013, Andrew MacLeod wrote: There needs to be a place which has gimple componentry that is not related to or require a statemen

Re: [PATCH, rs6000] ELFv2 ABI 1/8 - 8/8

2013-11-14 Thread David Edelsohn
> To avoid having a partial ABI implementation in tree, it seems best > to commit this whole patch series as a single commit. > Is the series OK for mainline? The 8 patch series implementing and enabling ELFv2 is okay, including the implementation of command line switches. There appear to be a f

Re: [patch 3/4] Separate gimple.[ch] and gimplify.[ch] - front end files

2013-11-14 Thread Michael Matz
Hi, On Thu, 14 Nov 2013, Andrew MacLeod wrote: > > That's why I think talking about a gimple expression as if they were > > somehow some stand-alone concept is fairly confusing, and introducing it > > now as if it would somewhen exist would lead to going down some inferior > > design paths. > >

Re: [patch 3/4] Separate gimple.[ch] and gimplify.[ch] - front end files

2013-11-14 Thread Andrew MacLeod
On 11/14/2013 10:57 AM, Michael Matz wrote: Hi, On Thu, 14 Nov 2013, Andrew MacLeod wrote: That's why I think talking about a gimple expression as if they were somehow some stand-alone concept is fairly confusing, and introducing it now as if it would somewhen exist would lead to going down so

Re: [patch 3/4] Separate gimple.[ch] and gimplify.[ch] - front end files

2013-11-14 Thread Michael Matz
Hi, On Thu, 14 Nov 2013, Andrew MacLeod wrote: > > I think if following through with the whole plan there would (and > > should) be nothing remaining that could be called a gimple expression. > > very possibly, i just haven't gotten to those parts yet. I can change > the name back to gimple-de

Re: [patch 3/4] Separate gimple.[ch] and gimplify.[ch] - front end files

2013-11-14 Thread Diego Novillo
On Thu, Nov 14, 2013 at 11:13 AM, Andrew MacLeod wrote: > very possibly, i just haven't gotten to those parts yet. I can change the > name back to gimple-decl.[ch] or some such thing if you like that better. As much as I hate to paint name sheds: gimple-val.[ch]. Diego.

Re: [PATCH] Do not set flag_complex_method to 2 for C++ by default.

2013-11-14 Thread Xinliang David Li
Can we revisit the decision for this? Here are the reasons: 1) It seems that the motivation to make C++ consistent with c99 is to avoid confusing users who build the C source with both C and C++ compilers. Why should C++'s default behavior be tuned for this niche case? 2) It is very confusing for

Re: [patch 3/4] Separate gimple.[ch] and gimplify.[ch] - front end files

2013-11-14 Thread Andrew MacLeod
On 11/14/2013 11:23 AM, Michael Matz wrote: Hi, On Thu, 14 Nov 2013, Andrew MacLeod wrote: I think if following through with the whole plan there would (and should) be nothing remaining that could be called a gimple expression. very possibly, i just haven't gotten to those parts yet. I can ch

Re: [C++ Patch/RFC PR c++/57887 (and dups)

2013-11-14 Thread Paolo Carlini
Hi, On 11/14/2013 03:41 PM, Jason Merrill wrote: I don't think we need a new parameter; just pass the FIELD_DECL into maybe_end_member_template_processing and adjust it appropriately. Also, call m_e_m_t_p from cp_parser_late_parsing_nsdmi rather than cp_parser_class_specifier_1. Thanks, much

Re: [PATCH, rs6000] ELFv2 ABI 1/8 - 8/8

2013-11-14 Thread Ulrich Weigand
David Edelsohn wrote: > > > To avoid having a partial ABI implementation in tree, it seems best > > to commit this whole patch series as a single commit. > > > Is the series OK for mainline? > > The 8 patch series implementing and enabling ELFv2 is okay, including > the implementation of command

Re: [patch 1/2] add gimplfy-be.[ch] for iterator-aware BE-only gimplification routines.

2013-11-14 Thread Andrew MacLeod
On 11/14/2013 10:41 AM, Richard Biener wrote: On Thu, Nov 14, 2013 at 4:10 PM, Andrew MacLeod wrote: This patch splits out the force_gimple_operand parts of gimplify.[ch] into their own file which will prevent the front ends from having to see iterators, and breaks the annoying dependency cycl

Re: PING: Fwd: Re: [patch] implement Cilk Plus simd loops on trunk

2013-11-14 Thread Joseph S. Myers
Where you have + error ("break statement within <#pragma simd> loop body"); + error ("continue statement within <#pragma simd> loop body"); I think you mean %< and %> (i.e. quotes) not < and >. -- Joseph S. Myers jos...@codesourcery.com

Re: PING: Fwd: Re: [patch] implement Cilk Plus simd loops on trunk

2013-11-14 Thread Jakub Jelinek
On Thu, Nov 14, 2013 at 09:49:41AM -0700, Aldy Hernandez wrote: > +case OMP_PARALLEL: > +case OMP_TASK: > +case OMP_FOR: > +case OMP_SIMD: > +case OMP_SECTIONS: > +case OMP_SINGLE: > +case OMP_SECTION: > +case OMP_MASTER: > +case OMP_ORDERED: > +case OMP_CRIT

Re: PING: Fwd: Re: [patch] implement Cilk Plus simd loops on trunk

2013-11-14 Thread Aldy Hernandez
On 11/14/13 09:57, Joseph S. Myers wrote: Where you have + error ("break statement within <#pragma simd> loop body"); + error ("continue statement within <#pragma simd> loop body"); I think you mean %< and %> (i.e. quotes) not < and >. Indeed. Fixed. Thank you.

Re: [PATCH] Add gimple subclasses for every gimple code (was Re: [PATCH 0/6] Conversion of gimple types to C++ inheritance (v3))

2013-11-14 Thread David Malcolm
On Thu, 2013-11-14 at 00:13 -0700, Jeff Law wrote: > On 11/08/13 12:02, David Malcolm wrote: > >> I wouldn't mind seeing a small example proof of concept posted to help > >> those who don't see where this is going understand the goal. I would > >> recommend against posting another large patch for

Re: [patch 3/4] Separate gimple.[ch] and gimplify.[ch] - front end files

2013-11-14 Thread Richard Biener
Diego Novillo wrote: >On Thu, Nov 14, 2013 at 11:13 AM, Andrew MacLeod >wrote: > >> very possibly, i just haven't gotten to those parts yet. I can change >the >> name back to gimple-decl.[ch] or some such thing if you like that >better. > >As much as I hate to paint name sheds: gimple-val.[ch].

Re: libsanitizer merge from upstream r191666

2013-11-14 Thread Konstantin Serebryany
On Thu, Nov 14, 2013 at 7:33 PM, Jakub Jelinek wrote: > On Tue, Oct 29, 2013 at 07:05:49AM -0700, Konstantin Serebryany wrote: >> The calls are emitted by default, but the __asan_stack_malloc call is >> done under a run-time flag >> __asan_option_detect_stack_use_after_return. >> So, to use the st

Re: PING: Fwd: Re: [patch] implement Cilk Plus simd loops on trunk

2013-11-14 Thread Jakub Jelinek
On Thu, Nov 14, 2013 at 10:39:02AM -0700, Aldy Hernandez wrote: > On 11/14/13 10:05, Jakub Jelinek wrote: > > [Balaji, see below for question.] > > >On Thu, Nov 14, 2013 at 09:49:41AM -0700, Aldy Hernandez wrote: > >>+case OMP_PARALLEL: > >>+case OMP_TASK: > >>+case OMP_FOR: > >>+

[PATCH] Generalize thread_through_normal_block

2013-11-14 Thread Jeff Law
As part of the generalized FSA optimization work we need the ability to start a jump threading path with a joiner, then later in the path have a normal jump threading block (ie, has side effects and thus requires duplication). thread_through_normal_block needs one tweak to make that possible

libgo patch committed: Fix list of supported os's and arch's

2013-11-14 Thread Ian Lance Taylor
This patch from Dave Cheney fixes the list of supported operating systems and architectures in libgo. syslist.go used to be a generated file in the master Go library, but it was changed a while back to a fixed list. This patch makes the same change to libgo. Bootstrapped and ran Go testsuite on

Re: libsanitizer merge from upstream r191666

2013-11-14 Thread Jakub Jelinek
On Thu, Nov 14, 2013 at 09:56:36PM +0400, Konstantin Serebryany wrote: > I thought about alignment but did not reflect it anywhere in the > interface/comments. > The alignment should be min(4096, N), which is enough for most purposes. You mean max(4096, N), right? And, what exactly is N? 1 << (c

Re: libsanitizer merge from upstream r191666

2013-11-14 Thread Jakub Jelinek
On Thu, Nov 14, 2013 at 07:08:17PM +0100, Jakub Jelinek wrote: > On Thu, Nov 14, 2013 at 09:56:36PM +0400, Konstantin Serebryany wrote: > > I thought about alignment but did not reflect it anywhere in the > > interface/comments. > > The alignment should be min(4096, N), which is enough for most pur

[rx] extend mode-dependent address offsets

2013-11-14 Thread DJ Delorie
All RX opcodes which take a dsp:8 also take a dsp:16 so we can relax this offset check. Committed. * config/rx/rx.c (rx_mode_dependent_address_p): Allow offsets up to 16 bits. Index: config/rx/rx.c === --- config/rx

Re: PING: Fwd: Re: [patch] implement Cilk Plus simd loops on trunk

2013-11-14 Thread Aldy Hernandez
Well, if you don't change anything in omp-low.c, then it wouldn't diagnose setjmp call in #pragma simd, but given that also the OpenMP 4.0 spec requires that #pragma omp simd doesn't contain calls to setjmp or longjmp (ditto for #pragma omp declare simd functions), then scan_omp_1_stmt should be

Re: [PATCH] Merge cgraph_get_create_node and cgraph_get_create_real_symbol_node

2013-11-14 Thread Uros Bizjak
On Thu, Nov 14, 2013 at 8:51 AM, Uros Bizjak wrote: > On Wed, Nov 13, 2013 at 6:18 PM, Uros Bizjak wrote: > >>> as discussed with Honza on many occasions, all users of >>> cgraph_get_create_node really want cgraph_get_create_real_symbol_node, >>> i.e. they are not interested in inline nodes and s

libgo patch committed: Fill in list of gccgo architectures

2013-11-14 Thread Ian Lance Taylor
This patch expands the recent one from Dave Cheney to add all the known gccgo architectures. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian diff -r 5d4a0b7216b6 libgo/go/go/build/syslist.go --- a/libgo/go/go/build/syslist.go Thu Nov 14 10:07:00 2013 -0

Re: [PATCH] Do not set flag_complex_method to 2 for C++ by default.

2013-11-14 Thread Andrew Pinski
On Thu, Nov 14, 2013 at 8:25 AM, Xinliang David Li wrote: > Can we revisit the decision for this? Here are the reasons: > > 1) It seems that the motivation to make C++ consistent with c99 is to > avoid confusing users who build the C source with both C and C++ > compilers. Why should C++'s default

Re: [PATCH, PR 10474] Take two on splitting live-ranges of function arguments to help shrink-wrapping

2013-11-14 Thread Martin Jambor
Hi, On Thu, Nov 14, 2013 at 12:18:24PM +, Matthew Leach wrote: > Martin Jambor writes: > > > Hi, > > Hi Martin, > > [...] > > > > > 2013-11-04 Martin Jambor > > > > PR rtl-optimization/10474 > > * ira.c (interesting_dest_for_shprep): New function. > > (split_liv

[committed] Unbreak asan on ppc (PR sanitizer/59122)

2013-11-14 Thread Jakub Jelinek
Hi! I've committed following fix to unbreak asan on -fsection-anchors targets. If anyone has better ideas how to represent for RTL artificial label we emit from final.c at the beginning of current function, I'd appreciate it. 2013-11-14 Jakub Jelinek PR sanitizer/59122 * asan.

Re: [C++ Patch/RFC PR c++/57887 (and dups)

2013-11-14 Thread Jason Merrill
On 11/14/2013 11:37 AM, Paolo Carlini wrote: + ? TREE_TYPE (CLASSTYPE_TEMPLATE_INFO (DECL_CONTEXT (decl))) Use CLASSTYPE_TI_TEMPLATE instead. OK with that change. Jason

Re: [PATCH] Do not set flag_complex_method to 2 for C++ by default.

2013-11-14 Thread Cong Hou
See the following code: #include using std::complex; template complex<_Tp>& mult_assign (complex<_Tp>& __y, const complex<_Up>& __z) { _Up& _M_real = __y.real(); _Up& _M_imag = __y.imag(); const _Tp __r = _M_real * __z.real() - _M_imag * __z.imag(); _M_imag = _M_real * __z.imag() + _M_i

Committed: arc.md: Remove extra alignment in doloop_begin_i

2013-11-14 Thread Joern Rennecke
That extra alignment causes some branches to go out of range. 2013-11-14 Joern Rennecke * config/arc/arc.md (doloop_begin_i): Remove extra alignment; use (.&-4) idiom. Index: config/arc/arc.md === --- config/arc/a

  1   2   >