Re: [PATCH][i386]Fix PR 57756

2013-10-12 Thread Uros Bizjak
On Sat, Oct 12, 2013 at 2:16 AM, Sriraman Tallam wrote: > Ping. This looks nice. I suppose you grepped for effected targets and rs6000 was the only one besides i386. This is ok given target maintainers do not object within 24h and the test successfully bootstrapped and

Re: PATCH: PR target/58690: internal compiler error: in copy_to_mode_reg, at explow.c:641

2013-10-12 Thread Uros Bizjak
On Fri, Oct 11, 2013 at 8:38 PM, H.J. Lu wrote: > In x32, when a TLS address is in DImode and Pmode is SImode, > copy_addr_to_reg will fail. This patch adds ix86_copy_addr_to_reg > to first copy DImode address into a DImode register and then to generate > SImode SUBREG in this case. Tested on x

Re: [PATCH] Reassociate X == CST1 || X == CST2 if popcount (CST2 - CST1) == 1 into ((X - CST1) & ~(CST2 - CST1)) == 0

2013-10-12 Thread Jakub Jelinek
On Sat, Oct 12, 2013 at 10:08:12AM +0800, Zhenqiang Chen wrote: > As you had mentioned, the transition in this patch does not reduce > instructions. But the preexisting optimization does. So we prefer to do the > preexisting optimization first. E.g. > > X == 10 || X == 12 || X == 26 Ok, that make

Re: Apply attribute returns_nonnull in libiberty

2013-10-12 Thread Marc Glisse
On Fri, 11 Oct 2013, DJ Delorie wrote: Alternatively, you could ask the other projects if they're ok with changing the xmalloc rule... Is there an official list where all the users of libiberty can be contacted? -- Marc Glisse

[committed] OpenMP 4.0 affinity fixes and improvements (PR libgomp/58691)

2013-10-12 Thread Jakub Jelinek
Hi! I've committed these changes to trunk. The first two hunks hopefully fixes warnings (turned into -Werror) with older glibc headers, the rest are changes requested in PR58691 - OMP_PROC_BIND default value is implementation defined, and Tobias suggested a better implementation defined default -

Re: [PATCH i386] Use ordered comparisons for rounding builtins when -mno-ieee-fp

2013-10-12 Thread Uros Bizjak
Hello! > 2013-10-11 Alexander Monakov > > * config/i386/i386.c (ix86_expand_sse_compare_and_jump): Use mode > provided by ix86_fp_compare_mode instead of CCFPUmode. > > testsuite/: > * gcc.target/i386/builtin-ucmp.c: New test. OK for mainline. Thanks, Uros.

Re: [AArch64] Fix early-clobber operands to vtbx[1,3]

2013-10-12 Thread James Greenhalgh
On Fri, Oct 11, 2013 at 07:52:48PM +0100, Marcus Shawcroft wrote: > > 2013-10-11 James Greenhalgh > > > > * config/aarch64/arm_neon.h > > (vtbx<1,3>_8): Fix register constriants. > > > > OK? > > OK, and back port to 4.8 please. > /Marcus > Hi Marcus, I've committed this as revision 2

Re: [AArch64] Fix early-clobber operands to vtbx[1,3]

2013-10-12 Thread Jakub Jelinek
On Sat, Oct 12, 2013 at 08:57:51AM +0100, James Greenhalgh wrote: > I've committed this as revision 203478, but 4.8 is currently > frozen for release, so Jakub (+CC) will have to approve it. This is ok for 4.8.2. Jakub

Re: PATCH: PR target/58690: internal compiler error: in copy_to_mode_reg, at explow.c:641

2013-10-12 Thread H.J. Lu
On Sat, Oct 12, 2013 at 12:21 AM, Uros Bizjak wrote: > On Fri, Oct 11, 2013 at 8:38 PM, H.J. Lu wrote: > >> In x32, when a TLS address is in DImode and Pmode is SImode, >> copy_addr_to_reg will fail. This patch adds ix86_copy_addr_to_reg >> to first copy DImode address into a DImode register and

Re: PATCH: PR target/58690: internal compiler error: in copy_to_mode_reg, at explow.c:641

2013-10-12 Thread Uros Bizjak
On Sat, Oct 12, 2013 at 4:57 PM, H.J. Lu wrote: >>> In x32, when a TLS address is in DImode and Pmode is SImode, >>> copy_addr_to_reg will fail. This patch adds ix86_copy_addr_to_reg >>> to first copy DImode address into a DImode register and then to generate >>> SImode SUBREG in this case. Tes

Re: [C++ Patch] PR 58466

2013-10-12 Thread Paolo Carlini
On 10/11/2013 09:31 PM, Paolo Carlini wrote: On 10/11/2013 08:29 PM, Paolo Carlini wrote: Are we maybe failing to bump processing_template_decl somewhere while processing the specialization? ... I'm finishing testing this, already past g++.dg/dg.exp... In the meanwhile testing completed succes

Re: [PATCH PING] Move edge_within_scc to ipa-utils.c

2013-10-12 Thread Jan Hubicka
> Ping. OK, thanks! Honza > > Thanks, > > Martin > > On Wed, Sep 11, 2013 at 03:02:02PM +0200, Martin Jambor wrote: > > Hi, > > > > edge_within_scc should really be a part of API accompanying > > ipa_reduced_postorder just like ipa_get_nodes_in_cycle and so this > > patch moves it to ipa-utils.

[C++ Patch] PR 58700

2013-10-12 Thread Paolo Carlini
Hi, this ICE on invalid, a 4.8/4.9 Regression, simply started when build_lang_decl_loc was introduced, which wants a location as first argument: when the declarator is null, we can't pass the location as declarator->id_loc. For now input_location can do, I think, restores the old behavior.

Go patch committed: Fix import of struct with embedded builtin type

2013-10-12 Thread Ian Lance Taylor
This patch to the Go frontend fixes the handling of an imported struct with an embedded builtin type. We used to permit the importing package to refer to the field, which is wrong because builtin types are not exported. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to

RE: [PATCH, PR 57748] Check for out of bounds access, Part 2

2013-10-12 Thread Bernd Edlinger
Hi, >> That would definitely be a good move. Maybe someone should approve it? > > Yes, but I agree that we ought to restrict it to trailing zero-sized arrays. > That would help to allay Jakub's concerns about possible ABI fallouts. > > -- > Eric Botcazou Other uses of zero-sized arrays in structu