Re: [Patch] catch builtin_bswap16 construct

2012-09-24 Thread Eric Botcazou
> A while ago I've tried doing that for SH (implementing bswap16 with RTL > combine). It was like an explosion of patterns, because combine would > try out a lot of things depending on the surrounding code around the > actual bswap16. In the end I decided to drop that stuff for the most > part.

Re: [Patch] catch builtin_bswap16 construct

2012-09-24 Thread Oleg Endo
On Mon, 2012-09-24 at 09:15 +0200, Eric Botcazou wrote: > > A while ago I've tried doing that for SH (implementing bswap16 with RTL > > combine). It was like an explosion of patterns, because combine would > > try out a lot of things depending on the surrounding code around the > > actual bswap16.

Re: [PATCH] Fix PR52173

2012-09-24 Thread Richard Guenther
On Fri, 21 Sep 2012, Aldy Hernandez wrote: > On 09/21/12 08:52, Richard Guenther wrote: > > > > This bug happens because GIMPLE_TRANSACTION is a statement > > without real but with virtual operands. The short-cut in gimple_copy > > thus is overly optimistic. Fixed as follows. > > Thank you so

Re: [PATCH] fix gcc.dg/torture/pr53922.c on darwin

2012-09-24 Thread Richard Guenther
On Sat, 22 Sep 2012, Jack Howarth wrote: >The attached patch eliminates the failures in linkage of the new > gcc.dg/torture/pr53922.c testcase on darwin by passing > -Wl,-undefined,dynamic_lookup > to the linker as recommended by the darwin linker developer... > > http://gcc.gnu.org/ml/gcc-b

Re: [PATCH] Cilk Plus merging to trunk (2 of n)

2012-09-24 Thread Richard Guenther
On Sun, Sep 23, 2012 at 2:01 AM, Iyer, Balaji V wrote: > Hello Everyone, > Attached, please find a patch that will implement Cilk Plus Array > Notations for the C compiler. Array notations are indented to allow > programmers to directly express parallelism in their programs. Array > notatio

[patch] Stream TYPE_NONALIASED_COMPONENT in LTO mode

2012-09-24 Thread Eric Botcazou
Hi, although the type merging machinery deals with TYPE_NONALIASED_COMPONENT, the flag is actually not streamed, which can result in strange performance drops for Ada applications in LTO mode. The attached patch plugs this hole. Tested on x86_64-suse-linux and LTO-bootstrapped. I also checked

Re: [patch] Stream TYPE_NONALIASED_COMPONENT in LTO mode

2012-09-24 Thread Richard Guenther
On Mon, Sep 24, 2012 at 12:05 PM, Eric Botcazou wrote: > Hi, > > although the type merging machinery deals with TYPE_NONALIASED_COMPONENT, the > flag is actually not streamed, which can result in strange performance drops > for Ada applications in LTO mode. The attached patch plugs this hole. > >

Re: [RFA 1/n] Fix if conversion interactions with block partitioning

2012-09-24 Thread Matthew Gretton-Dann
On Wednesday 05 September 2012 13:47:19 Steven Bosscher wrote: > On Wed, Sep 5, 2012 at 1:25 PM, Matthew Gretton-Dann wrote: > > + /* If the two blocks are in different partitions we do not want to mark > > + this as a fallthru edge. */ > > + if (BB_PARTITION (b) != BB_PARTITION (c)) > > +

Re: [RFC] Move ehcleanup pass to before early SRA

2012-09-24 Thread Richard Guenther
On Sun, Sep 23, 2012 at 10:46 AM, Eric Botcazou wrote: > Hi, > > we have run into optimization regressions in Ada caused by the interaction > between the new GIMPLE clobbers and SRA: on the one hand GIMPLE clobbers > create artificial EH handlers for aggregate variables, on the other hand SRA > re

Re: [PATCH] Fix PR54650

2012-09-24 Thread Richard Guenther
On Sat, Sep 22, 2012 at 4:08 AM, Dehao Chen wrote: > Hi, > > The problem is due to a bug when move_block_to_fn. edge->goto_block > should be updated even when its locus is unknown. This patch also > fixes the way to reset block for expr. I think the machinery is much more fragile (which is probab

Re: forwprop: bit_field_ref(constructor)

2012-09-24 Thread Richard Guenther
On Sat, Sep 22, 2012 at 11:17 PM, Marc Glisse wrote: > Hello, > > this patch lets forwprop fold bit_field_refs of constructors. It is > particularly useful in forwprop4, which happens after the pass that lowers > unsupported vector operations. Indeed, that pass keeps breaking vectors into > pieces

[PATCH] Fix PR54632

2012-09-24 Thread Richard Guenther
This fixes PR54632 - we can end up with garbage collected BLOCKs (those not part of any BLOCK tree) being still referenced from DECL_DEBUG_EXPRs. We try to handle that in clear_unused_block_pointer but fail to walk all local decls as source of them (but only catch those that are still actively us

[PATCH] Fix PR54684

2012-09-24 Thread Richard Guenther
This fixes PR54684 where optimizing __builtin_unreachable () during builtin folding fails to update SSA operands properly. Bootstrapped on x86_64-unknown-linux-gnu, testing in progress. Richard. 2012-09-24 Richard Guenther PR tree-optimization/54684 * tree-ssa-ccp.c (optimiz

[PATCH] Fix PR53663

2012-09-24 Thread Richard Guenther
This fixes PR53663 - for redundant store removal we may not use VN translation, but the native encode / interpret trick is of such a kind because it looks through type changes. Thus, mark it so. Bootstrap and regtest queued on x86_64-unknown-linux-gnu. Richard. 2012-09-24 Richard Guenther

[Patch / RFC] PR 50828

2012-09-24 Thread Paolo Carlini
Hi, some time ago Jon filed this diagnostic enhancement PR: explaining it requires a bit, please be patient, if you can ;) Essentially, we are comparing a "note" emitted for template struct A { template void f() { } }; int main() { A a; a.f(0); } vs the version of the "not

Re: [Patch / RFC] PR 50828

2012-09-24 Thread Jason Merrill
I think dump_function_decl should strip TFF_TEMPLATE_NAME from flags before passing flags along to other functions, like dump_template_parms does. Jason

Re: [PATCH] PR c++/53551 - -Wunused-local-typedefs misses uses

2012-09-24 Thread Jason Merrill
OK. Jason

RE: [PATCH] Cilk Plus merging to trunk (2 of n)

2012-09-24 Thread Iyer, Balaji V
Hi Richard, Please see my comments embedded below. >-Original Message- >From: Richard Guenther [mailto:richard.guent...@gmail.com] >Sent: Monday, September 24, 2012 5:53 AM >To: Iyer, Balaji V >Cc: gcc-patches@gcc.gnu.org; al...@redhat.com; r...@redhat.com; >l...@redhat.com >Subjec

Re: PING Re: [PATCH, MIPS] add new peephole for 74k dspr2

2012-09-24 Thread Maciej W. Rozycki
On Tue, 18 Sep 2012, Richard Sandiford wrote: > > Have you had time to think about this some more? I am not sure I can > > guess how you'd like me to fix this patch now without some more specific > > review and/or suggestions about where the optimization should happen and > > what cases it sho

Re: [Patch / RFC] PR 50828

2012-09-24 Thread Paolo Carlini
On 09/24/2012 04:53 PM, Jason Merrill wrote: I think dump_function_decl should strip TFF_TEMPLATE_NAME from flags before passing flags along to other functions, like dump_template_parms does. I see. The below also works on the "note" and passes the testsuite. Note: I'm adding to the existing s

Re: [Patch / RFC] PR 50828

2012-09-24 Thread Jason Merrill
OK. Jason

Two tiny C++ PATCHes

2012-09-24 Thread Jason Merrill
1) parser.o was missing a dependency on decl.h. 2) The assignment to fn_ptr_type was dead. Tested x86_64-pc-linux-gnu, applying to trunk. commit 330ecdbe393e3bd068c14c6639a5ace9764d2191 Author: Jason Merrill Date: Thu Sep 20 09:52:42 2012 -0400 * Make-lang.in (cp/parser.o): Depend on dec

Re: Rewrite lto-symtab to work on symbol table

2012-09-24 Thread Martin Jambor
Hi, On Tue, Sep 18, 2012 at 03:35:45PM +0200, Jan Hubicka wrote: > Hi, > this patch reorganize lto-symtab to work across symtab's symbol table instead > of building its own. This simplifies things a bit and with the previous > changes it is rather straighforward - i.e. replace all uses of > lto_s

Re: [patch] PR middle-end/53850: memset builtin problem in TM

2012-09-24 Thread Aldy Hernandez
On 09/21/12 20:32, Richard Henderson wrote: On 09/21/2012 02:00 PM, Aldy Hernandez wrote: + /* ?? For TM_* builtin replacements, can we set this to FALSE?? +Otherwise, do we need to propagate the may_irr bit? */ + node->local.tm_may_enter_irr = true; Yes we can. I

Re: Rewrite lto-symtab to work on symbol table

2012-09-24 Thread H.J. Lu
On Mon, Sep 24, 2012 at 8:50 AM, Martin Jambor wrote: > Hi, > > On Tue, Sep 18, 2012 at 03:35:45PM +0200, Jan Hubicka wrote: >> Hi, >> this patch reorganize lto-symtab to work across symtab's symbol table instead >> of building its own. This simplifies things a bit and with the previous >> change

[Patch, testsuite] Changes in tests for the case when long double size is equal double size

2012-09-24 Thread Igor Zamyatin
Hi All! After recent commit (http://gcc.gnu.org/ml/gcc-cvs/2012-08/msg00576.html, patch - http://gcc.gnu.org/ml/gcc-patches/2012-08/msg01512.html), which sets size of long double equal to double for Bionic, several tests required some adjustment to pass on Android. Tested both for Linux and Andor

Re: [Patch, testsuite] Changes in tests for the case when long double size is equal double size

2012-09-24 Thread Mike Stump
On Sep 24, 2012, at 9:56 AM, Igor Zamyatin wrote: > After recent commit > (http://gcc.gnu.org/ml/gcc-cvs/2012-08/msg00576.html, patch - > http://gcc.gnu.org/ml/gcc-patches/2012-08/msg01512.html), which sets > size of long double equal to double for Bionic, several tests required > some adjustment

New template for 'cpplib' made available

2012-09-24 Thread Translation Project Robot
Hello, gentle maintainer. This is a message from the Translation Project robot. (If you have any questions, send them to .) A new POT file for textual domain 'cpplib' has been made available to the language teams for translation. It is archived as: http://translationproject.org/POT-files/c

New template for 'gcc' made available

2012-09-24 Thread Translation Project Robot
Hello, gentle maintainer. This is a message from the Translation Project robot. (If you have any questions, send them to .) A new POT file for textual domain 'gcc' has been made available to the language teams for translation. It is archived as: http://translationproject.org/POT-files/gcc-

Ping: [patch] pr/54508: fix incomplete debug information for class

2012-09-24 Thread Paul_Koning
Ping... paul Begin forwarded message: > From: > Date: September 20, 2012 4:55:05 PM EDT > To: > Subject: Re: [patch] pr/54508: fix incomplete debug information for class > > Attached below is an update to the testcase file, to fix the scan-assembler > regexp comment character matchin

Re: [google] Added new dump flag -pmu to display pmu data in pass summaries (issue 6489092)

2012-09-24 Thread Teresa Johnson
On Wed, Sep 19, 2012 at 3:03 PM, wrote: > FYI. > > Dehao Thanks. Responses below. New patch being uploaded shortly. Teresa > > > https://codereview.appspot.com/6489092/diff/4001/gcc/common.opt > File gcc/common.opt (right): > > https://codereview.appspot.com/6489092/diff/4001/gcc/common.opt#ne

[Patch, Fortran, committed] PR54690 - Fix of the commit of PR54618

2012-09-24 Thread Tobias Burnus
This patch fixes PR54690; it is rather obvious and has been also approved by Paul in the PR. Tobias Index: gcc/fortran/ChangeLog === --- gcc/fortran/ChangeLog (Revision 191675) +++ gcc/fortran/ChangeLog (Arbeitskopie) @@ -1,3 +1,9 @

Re: [PATCH] PR c++/29028 - Missed unused warning on using declaration

2012-09-24 Thread Jason Merrill
OK. Jason

Re: [PATCH] PR c++/54372 - unused attribute inactive on dependant entities

2012-09-24 Thread Jason Merrill
On 09/20/2012 10:01 AM, Dodji Seketeli wrote: This is because in cplus_decl_attributes, save_template_attributes makes so that the 'unused' attribute is applied to its appertaining entity only at instantiation time. But then at parsing time maybe_warn_unused_local_typedefs checks for TREE_USED b

Re: [patch] PR middle-end/53850: memset builtin problem in TM

2012-09-24 Thread Richard Henderson
On 09/24/2012 09:02 AM, Aldy Hernandez wrote: > PR middle-end/53850 > * trans-mem.c (expand_call_tm): Handle late built built-ins. Looks good. Typo in the changelog. r~

Re: [PATCH] Add option for dumping to stderr (issue6190057)

2012-09-24 Thread Sharad Singhai
Ping.

[google] Add new dump flag -pmu to display PMU data in dumps (issue6551072)

2012-09-24 Thread Teresa Johnson
Revised patch to add a new dump flag that dumps PMU profile information using the -pmu dump option. (Was issue 6489092, creating new issue since I don't own that one.) Ok for google/main? Passes bootstrap and regression tests. Teresa 2012-09-24 Teresa Johnson Chris Manghane

Re: [patch] PR54645 move location_adhoc_data map into GC

2012-09-24 Thread Hans-Peter Nilsson
On Fri, 21 Sep 2012, Dehao Chen wrote: > This patch moves location_adhoc_data into GC, and also rebuild the > hash table when reading in the PCH. After the patch, PCH can work as > expected. > > Bootstrapped and passed gcc regression tests on x8664_linux. If you have a moment to consider improveme

[PATCH] Fix PR54674

2012-09-24 Thread William J. Schmidt
In cases where pointers and ints are cast back and forth, SLSR can be tricked into introducing a multiply where one of the operands is of pointer type. Don't do that! Verified that the reduced test case in the PR is fixed with a cross-compile to sh4-unknown-linux-gnu with -Os, which is the only k

Re: PING Re: [PATCH, MIPS] add new peephole for 74k dspr2

2012-09-24 Thread Richard Sandiford
"Maciej W. Rozycki" writes: > On Tue, 18 Sep 2012, Richard Sandiford wrote: > >> > Have you had time to think about this some more? I am not sure I can >> > guess how you'd like me to fix this patch now without some more specific >> > review and/or suggestions about where the optimization shoul

Re: [Patch] catch builtin_bswap16 construct

2012-09-24 Thread Christophe Lyon
On 21 September 2012 12:56, Eric Botcazou wrote: >> Here is a new patch, modifying tree-ssa-math-opts.c as you suggested. >> It's indeed simpler :-) >> >> Validated with qemu-arm on target arm-none-linux-gnueabi. > > I cannot formally approve, but this looks good to me. > > However, could you chec

Re: [Patch] catch builtin_bswap16 construct

2012-09-24 Thread Eric Botcazou
> I have not yet been able to build an environment to run the testsuite > with qemu-ppc (not sure about the best target & dejagnu board > selection). No problem, that wasn't really a requirement. > However, when compiling a sample test > short myswaps16(short x) { >return (x << 8) | (x >> 8);

[google 4.7] fix unsatified symbols in lipo-use (issue6562044)

2012-09-24 Thread Rong Xu
Hi, This patch is for google branches only. It fixes the unsatified symbol in lipo-use build. Tested with SPEC and google internal benchmarks. Thanks, -Rong 2012-09-24 Rong Xu * gcc/l-ipo.c (cgraph_is_aux_decl_external): output comdat virtual functions when they are auxili

[google 4.7] not group modules with -frtti and -fno-rtti (issue6569045)

2012-09-24 Thread Rong Xu
Hi, This patch is for google branches only. It prohibits the grouping of modules with diffent flag_rtti value. otherwise it may cause profile mismatch, undefined symbols and some other internal errors. Tested with google internal benchmarks. Thanks, -Rong 2012-09-24 Rong Xu * gcc/

[google 4.7] fix line number checksum mismatch in lipo-use (issue6566044)

2012-09-24 Thread Rong Xu
Hi, This is for google branches only. It fix the lino number checksum mismatch during LIPO-use build. Tested with SPEC and google internal banchmarks. Thanks, -Rong 2012-09-24 Rong Xu * gcc/coverage.c (coverage_checksum_string): strip out LIPO specific string. (

Re: [google 4.7] fix unsatified symbols in lipo-use (issue6562044)

2012-09-24 Thread Xinliang David Li
ok. David On Mon, Sep 24, 2012 at 2:40 PM, Rong Xu wrote: > Hi, > > This patch is for google branches only. > It fixes the unsatified symbol in lipo-use build. > Tested with SPEC and google internal benchmarks. > > Thanks, > > -Rong > > > 2012-09-24 Rong Xu > > * gcc/l-ipo.c (cgraph_i

Re: [google 4.7] not group modules with -frtti and -fno-rtti (issue6569045)

2012-09-24 Thread Xinliang David Li
Ok. David On Mon, Sep 24, 2012 at 2:41 PM, Rong Xu wrote: > Hi, > > This patch is for google branches only. > It prohibits the grouping of modules with diffent flag_rtti value. > otherwise it may cause profile mismatch, undefined symbols and some other > internal errors. > > Tested with google i

[patch, fortran] Fix PR 52724, internal list-directed read/write with kind=4

2012-09-24 Thread Thomas Koenig
Hello world, not much to say, the patch is pretty straightforward. Regression-tested. OK for trunk? Thomas 2012-09-24 Thomas König PR fortran/52724 * list_read.c (next_char): Handle kind=4 characters. * unix.c (open_internal4): Correct lenth of internal fil

Re: PING Re: [PATCH, MIPS] add new peephole for 74k dspr2

2012-09-24 Thread Maciej W. Rozycki
On Mon, 24 Sep 2012, Richard Sandiford wrote: > > From the context I am assuming none of this matters for the 74K (and > > presumably the 24KE/34K) and a MULT $0, $0 is indeed faster, but overall > > isn't it something that should be decided based on instruction costs from > > DFA schedulers?

Re: [patch] PR middle-end/53850: memset builtin problem in TM

2012-09-24 Thread Aldy Hernandez
On 09/24/12 15:08, Richard Henderson wrote: On 09/24/2012 09:02 AM, Aldy Hernandez wrote: PR middle-end/53850 * trans-mem.c (expand_call_tm): Handle late built built-ins. Looks good. Typo in the changelog. r~ Actually, that was not a typo. Late built built-ins... as in b

Contents of PO file 'cpplib-4.7.2.vi.po'

2012-09-24 Thread Translation Project Robot
cpplib-4.7.2.vi.po.gz Description: Binary data The Translation Project robot, in the name of your translation coordinator.

New Vietnamese PO file for 'cpplib' (version 4.7.2)

2012-09-24 Thread Translation Project Robot
Hello, gentle maintainer. This is a message from the Translation Project robot. A revised PO file for textual domain 'cpplib' has been submitted by the Vietnamese team of translators. The file is available at: http://translationproject.org/latest/cpplib/vi.po (This file, 'cpplib-4.7.2.vi.p

[PATCH] rs6000: Fix ne0 patterns (PR51274)

2012-09-24 Thread Segher Boessenkool
The current patterns will never match. Fix that. Also, merge the SI and DI variants of each. Also, remove an unnecessary earlyclobber. And add a pattern for what combine considers the canonical form of one of these patterns. Bootstrapped and regression checked on powerpc64-linux. Also tested a

Re: [Patch] catch builtin_bswap16 construct

2012-09-24 Thread Segher Boessenkool
The generated code is now: myswaps16: rlwinm 10,3,8,16,23 rlwinm 9,3,24,24,31 or 9,9,10 extsh 3,9 blr myswapu16: rlwinm 10,3,8,16,23 rlwinm 9,3,24,24,31 or 9,9,10 rlwinm 3,9,0,0x blr While it was (without my patc