Re: [PATCH] Fix i?86 *mov*insv_1* patterns (PR target/54436)

2012-09-01 Thread Uros Bizjak
On Sat, Sep 1, 2012 at 8:32 AM, Jakub Jelinek wrote: > The following testcase results in an assembler warning on movb $700415, %ch > The problem is that the *mov*_insv_1* patterns use SImode or DImode for the > source operand, accept CONST_INTs in the constraints and nothing truncates > the const

Re: [PATCH] Handle truncate of a memory location

2012-09-01 Thread Richard Sandiford
Sorry for the slow review. Andrew Pinski writes: > Index: simplify-rtx.c > === > --- simplify-rtx.c(revision 190730) > +++ simplify-rtx.c(working copy) > @@ -869,6 +869,14 @@ simplify_unary_operation_1 (enum rtx_cod >

Re: [middle-end] Add machine_mode to address_cost target hook

2012-09-01 Thread Richard Sandiford
Oleg Endo writes: > While experimenting a little bit with an idea for an address mode > selection RTL pass for SH, I realized that SH's sh_address_cost function > is quite broken. When trying to fix it, I ran against a wall, since the > mode of the MEM is not passed to the target hook function, a

Re: [TILE-Gx, committed] support -mcmodel=MODEL

2012-09-01 Thread Gerald Pfeifer
On Tue, 28 Aug 2012, Walter Lee wrote: > This patch adds support for the -mcmodel=MODEL flag on TILE-Gx. At which point I cannot help asking for an update to the release notes at http://gcc.gnu.org/gcc-4.8/changes.html. ;-) Let me know if you need help with that. > Index: gcc/doc/invoke.texi > =

[PATCH, C] Mixed pointer types in call to streamer_tree_cache_lookup() in gcc/lto-streamer-out.c

2012-09-01 Thread Andris Pavenis
uint32_t * is used as a 3rd parameter in call to streamer_tree_cache_lookup() in 2 places in gcc/lto-streamer-out.c when the procedure prototype have unsigned *. They are not guaranteed to be the same for all targets (I got error when building for DJGPP) Andris ChangeLog entry 2012-09-01 Andri

Re: [middle-end] Add machine_mode to address_cost target hook

2012-09-01 Thread Oleg Endo
On Sat, 2012-09-01 at 10:10 +0100, Richard Sandiford wrote: > Thanks for doing this. We should perhaps add the address space too, > but if you don't feel like redoing the whole patch, that can wait until > someone wants it. I just had a look at the address space thing... There are already target

[PING] C++ conversion - pull in cstdlib

2012-09-01 Thread Oleg Endo
Ping! This allows one to include e.g. in GCC source files. Since the switch to C++ has been made, this should be OK to do now, I guess. Cheers, Oleg On Sat, 2012-08-25 at 23:59 +0200, Oleg Endo wrote: > Hello, > > This one makes system.h pull in when compiling as C++. > It fixes issues when e

Re: [PATCH, middle-end]: Introduce TARGET_LEGITIMATE_COMBINED_INSN target hook

2012-09-01 Thread Uros Bizjak
On Sun, Aug 26, 2012 at 11:00 AM, Uros Bizjak wrote: > Actually a v3 of TARGET_REJECT_COMBINED_INSN target hook. > > Changes: > - rename the hook and reverse the return value > > 2012-08-25 Uros Bizjak > > * target.def (legitimate_combined_insn): New target hook. > * doc/tm.tex

Fold VEC_PERM_EXPR a little more

2012-09-01 Thread Marc Glisse
Hello, I noticed while writing the patch posted at: http://gcc.gnu.org/ml/gcc-patches/2012-08/msg01755.html that fold_ternary_loc sometimes doesn't go all the way for VEC_PERM_EXPR, calling it a second time would fold even more. Fixed by a simple reordering. (bootstrap and testsuite are ok)

Re: [Jiří Paleček] [PATCH][C++] Fix constant reference in a lambda (PR c++/53488)

2012-09-01 Thread Jason Merrill
On 08/31/2012 09:17 PM, Gabriel Dos Reis wrote: Hmm, would we not run the risk of doing the "wrong" capture if everything is postponed? We wouldn't postpone name lookup, just the capture transformation. The long-term solution is to implement the rules properly, which depend on how a variable

Re: [Jiří Paleček] [PATCH][C++] Fix constant reference in a lambda (PR c++/53488)

2012-09-01 Thread Gabriel Dos Reis
On Sat, Sep 1, 2012 at 10:50 AM, Jason Merrill wrote: > On 08/31/2012 09:17 PM, Gabriel Dos Reis wrote: >> >> Hmm, would we not run the risk of doing the "wrong" capture if everything >> is postponed? > > > We wouldn't postpone name lookup, just the capture transformation. > > The long-term soluti

Re: [PING] C++ conversion - pull in cstdlib

2012-09-01 Thread Joseph S. Myers
On Sat, 1 Sep 2012, Oleg Endo wrote: > Ping! > > This allows one to include e.g. in GCC source files. > Since the switch to C++ has been made, this should be OK to do now, I > guess. This is not a review, but have you tested building the Ada front end with this patch applied? Given recent iss

Re: [PING] C++ conversion - pull in cstdlib

2012-09-01 Thread Oleg Endo
On Sat, 2012-09-01 at 16:17 +, Joseph S. Myers wrote: > On Sat, 1 Sep 2012, Oleg Endo wrote: > > > Ping! > > > > This allows one to include e.g. in GCC source files. > > Since the switch to C++ has been made, this should be OK to do now, I > > guess. > > This is not a review, but have you t

Re: [PATCH, middle-end]: Introduce TARGET_LEGITIMATE_COMBINED_INSN target hook

2012-09-01 Thread H.J. Lu
On Sat, Sep 1, 2012 at 7:32 AM, Uros Bizjak wrote: > On Sun, Aug 26, 2012 at 11:00 AM, Uros Bizjak wrote: > >> Actually a v3 of TARGET_REJECT_COMBINED_INSN target hook. >> >> Changes: >> - rename the hook and reverse the return value >> >> 2012-08-25 Uros Bizjak >> >> * target.def (leg

Re: [PATCH, middle-end]: Introduce TARGET_LEGITIMATE_COMBINED_INSN target hook

2012-09-01 Thread Uros Bizjak
On Sat, Sep 1, 2012 at 7:32 PM, H.J. Lu wrote: >>> Actually a v3 of TARGET_REJECT_COMBINED_INSN target hook. >>> >>> Changes: >>> - rename the hook and reverse the return value >>> >>> 2012-08-25 Uros Bizjak >>> >>> * target.def (legitimate_combined_insn): New target hook. >>>

[patch] PR bootstrap/54453 (libstdc++ doesn't build)

2012-09-01 Thread Steven Bosscher
Hello, r190783 breaks bootstrap on powerpc64-unknown-linux-gnu. The problem is caused by a regexp that used to check for space|tab before the patch but now only looks for tab. The attached patch fixes this problem for me, but I'm not sure why (I haven't tried to look into the details of the proble

combine BIT_FIELD_REF and VEC_PERM_EXPR

2012-09-01 Thread Marc Glisse
Hello, this patch makes it so that instead of taking the k-th element of a shuffle of V, we directly take the k'-th element of V. Note that I am *not* checking that the shuffle is only used once. There can be some circumstances where this optimization will make us miss other opportunities la

[Patch, Forttran] PR54426 - handle common_head in gfc_undo_symbols

2012-09-01 Thread Tobias Burnus
In one of my recent patches, I delete the sym->common_head to plug a memory leak. However, for invalid commons, gfc_undo_symbols is called, which might remove the common head while it is still referenced from namespace->common_root, leading to invalid memory access and (on some systems) to IC

Re: [Fortran] PR37336 - FIINAL patch [1/n]: Implement the finalization wrapper subroutine

2012-09-01 Thread Mikael Morin
On 29/08/2012 21:53, Tobias Burnus wrote: > Dear all, > > that's the revised version of patch at > http://gcc.gnu.org/ml/fortran/2012-08/msg00095.html, taking the review > comments into account. > > Reminder: This patch only generates the finalization wrapper, which is > in the virtual table. It

[patch, fortran] Set -Wcompare-reals from -Wextra

2012-09-01 Thread Thomas Koenig
Hello world, the attached patch sets -Wcompare-reals from -Wextra. It also dcouments a few cases (found while browsing the source) of options included in -Wall in invoke.texi. It also allows easy adding of other warning options to -Wextra. Regression-tested. OK for trunk? Thomas 2012-

Re: [PING] C++ conversion - pull in cstdlib

2012-09-01 Thread Oleg Endo
On Sat, 2012-09-01 at 18:25 +0200, Oleg Endo wrote: > On Sat, 2012-09-01 at 16:17 +, Joseph S. Myers wrote: > > On Sat, 1 Sep 2012, Oleg Endo wrote: > > > > > Ping! > > > > > > This allows one to include e.g. in GCC source files. > > > Since the switch to C++ has been made, this should be OK

Re: VxWorks Patches Back from the Dead!

2012-09-01 Thread rbmj
Hi all, I have a new set of patches attached to this email. I've made a few changes since last time, and a full build works (finally, again). -The ioctl patch removes superfluous parens (thanks Paolo) -The mkdir patch has a more precise (or uglier, depending on your point of view :P) regex,