Re: [PATCH, i386, Android] -mandroid support for i386 target

2012-04-01 Thread Ilya Enkovich
Hello Maxim, Thanks a lot for review. My comments are below. > On 28/02/2012, at 3:41 AM, Ilya Enkovich wrote: > >>> You should keep those *_SPEC and define them with new >>> GNU_*_SPEC in gnu-user.h since gnu-user.h is also used >>> by other non-linux targets.  In linux.h, you undef *_SPEC >>> b

Re: [PATCH, i386, Android] -mandroid support for i386 target

2012-04-01 Thread Ilya Enkovich
Hello Honza, >> 2012-02-27  Enkovich Ilya   >> >>       * gcc/config/i386/gnu-user.h (GNU_USER_TARGET_CC1_SPEC): New. >>       (CC1_SPEC): Use GNU_USER_TARGET_CC1_SPEC. >>       (GNU_USER_TARGET_LINK_SPEC): New. >>       (LINK_SPEC): Use GNU_USER_TARGET_LINK_SPEC. >>       (GNU_USER_TARGET_MATHFIL

Re: [PATCH, i386, Android] -mandroid support for i386 target

2012-04-01 Thread H.J. Lu
On Sun, Apr 1, 2012 at 8:23 AM, Ilya Enkovich wrote: >> i386/linux.h is used only for simple x86 32-bit builds; i386/linux64.h is >> used for multilib-enabled x86 toolchains.  Placing below definitions in >> i386/linux.h will not allow adding an Android as an additional multilib to >> -m32/-m6

Re: [google] Work around PR52796 by replacing empty packs with explicit overloads. (issue5971053)

2012-04-01 Thread Diego Novillo
On 3/30/12 9:55 PM, Jeffrey Yasskin wrote: Work around http://gcc.gnu.org/PR52796 in gcc-4.6 by adding an overload of each function that passes a parameter pack directly as the only arguments of an object's constructor, which explicitly takes no arguments in place of the pack. Tested with check-

[v3] Fix std::function to cope with volatile-qualified pointers to members

2012-04-01 Thread Jonathan Wakely
(N.B. not pointers to volatile member functions!) * include/std/functional (__callable_functor): Overload for volatile-qualified pointers. * testsuite/20_util/function/10.cc: New. Tested x86_64-linux, committed to trunk. I think the problem is obscure enough that the fix

PATCH: Update x32 rt_sigreturn syscall number to 0x40000201

2012-04-01 Thread H.J. Lu
On Tue, Aug 2, 2011 at 9:38 PM, Ian Lance Taylor wrote: > "H.J. Lu" writes: > >> 2011-08-02  H.J. Lu   >> >>       * config/i386/linux-unwind.h (RT_SIGRETURN_SYSCALL): New. >>       (x86_64_fallback_frame_state): Use RT_SIGRETURN_SYSCALL and >>       long long to check rt_sigreturn syscall. > > T

Re: [C++ RFC / Patch] Implementing "Deducing "noexcept" for destructors"

2012-04-01 Thread Jason Merrill
On 03/30/2012 09:34 PM, Paolo Carlini wrote: Thus I'm adding a !TYPE_BEING_DEFINED (DECL_CONTEXT (decl)) check Sounds good. we reject, with a "different exception specifier" error, both: template struct A { ~A() noexcept; }; template A::~A() { } and: template struct A { ~A(); }; temp

Re: [PATCH, i386, Android] -mandroid support for i386 target

2012-04-01 Thread Maxim Kuvyrkov
On 2/04/2012, at 3:23 AM, Ilya Enkovich wrote: >> As is, it appears this patch did not see much testing, I'm pretty sure it >> breaks building shared libraries and PIE executable for Linux. > > I do not expect any changes in compiler behavior for non Android > targets. I bootstrapped and checked

Re: [PATCH, i386, Android] -mandroid support for i386 target

2012-04-01 Thread Maxim Kuvyrkov
On 30/03/2012, at 6:48 AM, Jan Hubicka wrote: >> 2012-02-27 Enkovich Ilya >> >> * gcc/config/i386/gnu-user.h (GNU_USER_TARGET_CC1_SPEC): New. >> (CC1_SPEC): Use GNU_USER_TARGET_CC1_SPEC. >> (GNU_USER_TARGET_LINK_SPEC): New. >> (LINK_SPEC): Use GNU_USER_TARGET_LINK_SPEC. >>

[v3] fix libstdc++/52591

2012-04-01 Thread Jonathan Wakely
This allows move-assignment for std::vector when T is not MoveAssignable but the allocator is moved or equal, as a QoI extension. It also makes the code a bit cleaner and simpler, so I plan to use the same pattern as I make the rest of the library meet the allocator-aware container requirements.

Re: [v3] fix libstdc++/52476

2012-04-01 Thread Paolo Carlini
Hi, Attached patch applied. 2012-03-16 François Dumont PR libstdc++/52476 * include/bits/hashtable.h (_Hashtable<>::_M_rehash_aux): Add. (_Hashtable<>::_M_rehash): Use the latter. * testsuite/23_containers/unordered_multimap/insert/52476.cc: New. * tes

Re: [PATCH] Preserve loops from tree to RTL loop optimizers

2012-04-01 Thread David Edelsohn
> If there are no further comments I am inclined to commit this > patch early next week (possibly causing quite some fallout ...). I am glad there was not more fallout. Unfortunately powerpc-aix was not so lucky: /farm/dje/src/src/libstdc++-v3/src/c++98/streambuf.cc: In function 'std::streamsize

Re: [C++ RFC / Patch] Implementing "Deducing "noexcept" for destructors"

2012-04-01 Thread Paolo Carlini
Hi, we reject, with a "different exception specifier" error, both: template struct A { ~A() noexcept; }; template A::~A() { } and: template struct A { ~A(); }; template A::~A() noexcept { } Over the last days I wasted a lot of time trying painfully to not reject either, but actually no

Re: [PATCH] PR c++/40942 - Failure of template specialization partial ordering

2012-04-01 Thread Jason Merrill
OK. Jason

Re: [PATCH] Preserve loops from tree to RTL loop optimizers

2012-04-01 Thread Ramana Radhakrishnan
On 1 April 2012 23:55, David Edelsohn wrote: >> If there are no further comments I am inclined to commit this >> patch early next week (possibly causing quite some fallout ...). > > I am glad there was not more fallout.  Unfortunately powerpc-aix was > not so lucky: > > /farm/dje/src/src/libstdc++